Re: [E-devel] [PATCH] Add a checking null of im_info to get_ic().

2011-09-29 Thread The Rasterman
On Mon, 5 Sep 2011 15:33:58 +0900 Naruto TAKAHASHI said: actually it was the im_info thing i was asking about - never mind as that was a bit of the patch that was not needed. > this part moves get_ic(). > > filter_event() is occurred at input event(mount event or keyboard event). > when occurri

Re: [E-devel] [PATCH] Add a checking null of im_info to get_ic().

2011-09-04 Thread Naruto TAKAHASHI
this part moves get_ic(). filter_event() is occurred at input event(mount event or keyboard event). when occurring mouse event, don't need to get XIC. so I move get_ic() to in if(type == ECORE_IMF_EVENT_KEY_DOWN) nest. And the reason of deleting checking return value of get_ic() is get_ic() has a

Re: [E-devel] [PATCH] Add a checking null of im_info to get_ic().

2011-09-02 Thread The Rasterman
On Mon, 29 Aug 2011 18:18:31 +0900 Naruto TAKAHASHI said: hmm the 2nd part - if (!im_info) looks ok - but the first seems pointless/useless. why the first bit? > Hi All, > > I've added a checking null of im_info to get_ic(). > > Would you review this patch? > > Best Regards. > -- > Naruto TA

[E-devel] [PATCH] Add a checking null of im_info to get_ic().

2011-08-29 Thread Naruto TAKAHASHI
Hi All, I've added a checking null of im_info to get_ic(). Would you review this patch? Best Regards. -- Naruto TAKAHASHI tnar...@gmail.com diff --git a/ecore/src/modules/immodules/xim/ecore_imf_xim.c b/ecore/src/modules/immodules/xim/ecore_imf_xim.c index 791fdab..76ae9aa 100644 --- a/ecore/s