Re: [E-devel] E SVN: mcalamelli trunk/e/src/modules/wizard

2009-04-22 Thread Dave Andreoli
2009/4/21 Vincent Torri > > > On Tue, 21 Apr 2009, Gustavo Sverzut Barbieri wrote: > > On Tue, Apr 21, 2009 at 11:39 AM, Massimiliano Calamelli >> wrote: >> >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> On Tue, 21 Apr 2009 10:20:27 -0300 >>> Gustavo Sverzut Barbieri wrote: >>>

Re: [E-devel] E SVN: mcalamelli trunk/e/src/modules/wizard

2009-04-21 Thread Vincent Torri
On Tue, 21 Apr 2009, Gustavo Sverzut Barbieri wrote: On Tue, Apr 21, 2009 at 11:39 AM, Massimiliano Calamelli wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 21 Apr 2009 10:20:27 -0300 Gustavo Sverzut Barbieri wrote: this is bad, don't remove warnings just for the sake. When

Re: [E-devel] E SVN: mcalamelli trunk/e/src/modules/wizard

2009-04-21 Thread Gustavo Sverzut Barbieri
On Tue, Apr 21, 2009 at 11:39 AM, Massimiliano Calamelli wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Tue, 21 Apr 2009 10:20:27 -0300 > Gustavo Sverzut Barbieri wrote: >> >> this is bad, don't remove warnings just for the sake. When I added >> WARN_UNUSED_RESULT to evas_object_

Re: [E-devel] E SVN: mcalamelli trunk/e/src/modules/wizard

2009-04-21 Thread Massimiliano Calamelli
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 21 Apr 2009 10:20:27 -0300 Gustavo Sverzut Barbieri wrote: > > this is bad, don't remove warnings just for the sake. When I added > WARN_UNUSED_RESULT to evas_object_key_grab() I did think that it > should be handled, but I'm no expert there.

Re: [E-devel] E SVN: mcalamelli trunk/e/src/modules/wizard

2009-04-21 Thread Gustavo Sverzut Barbieri
On Tue, Apr 21, 2009 at 6:55 AM, Enlightenment SVN wrote: > Log: >  Fix compiler warnings about attribute warn_unused_result > -   evas_object_key_grab(o, "Tab", mask, ~mask, 0); > +   kg = evas_object_key_grab(o, "Tab", mask, ~mask, 0); this is bad, don't remove warnings just for the sake. When