Re: [E-devel] configure.ac change proposal

2010-12-21 Thread The Rasterman
On Tue, 21 Dec 2010 00:13:34 -0500 Mike Blumenkrantz said: > On Mon, 20 Dec 2010 15:52:52 -0800 > Michael Jennings wrote: > > > On Tuesday, 21 December 2010, at 08:37:01 (+0900), > > Carsten Haitzler wrote: > > > > > i'd say no - why change what works just to make the shell script shorter > >

Re: [E-devel] configure.ac change proposal

2010-12-20 Thread Mike Blumenkrantz
On Mon, 20 Dec 2010 15:52:52 -0800 Michael Jennings wrote: > On Tuesday, 21 December 2010, at 08:37:01 (+0900), > Carsten Haitzler wrote: > > > i'd say no - why change what works just to make the shell script shorter by > > a bit? michael already made a point - you will get the M. by changing th

Re: [E-devel] configure.ac change proposal

2010-12-20 Thread Michael Jennings
On Tuesday, 21 December 2010, at 08:37:01 (+0900), Carsten Haitzler wrote: > i'd say no - why change what works just to make the shell script shorter by a > bit? michael already made a point - you will get the M. by changing this you: > > 1. risk breaking things where grep isn't a full gnu grep >

Re: [E-devel] configure.ac change proposal

2010-12-20 Thread The Rasterman
On Mon, 20 Dec 2010 16:30:33 -0500 Mike Blumenkrantz said: > On Sun, 19 Dec 2010 15:19:31 -0800 > Michael Jennings wrote: > > > On Sunday, 19 December 2010, at 23:47:43 (+0100), > > Joerg Sonnenberger wrote: > > > > > > The spec files use: > > > > > > > > svnversion | sed 's/[^0-9].*$//' || e

Re: [E-devel] configure.ac change proposal

2010-12-20 Thread Mike Blumenkrantz
On Sun, 19 Dec 2010 15:19:31 -0800 Michael Jennings wrote: > On Sunday, 19 December 2010, at 23:47:43 (+0100), > Joerg Sonnenberger wrote: > > > > The spec files use: > > > > > > svnversion | sed 's/[^0-9].*$//' || echo > > > > > > which is portable. > > > > One important differences is

Re: [E-devel] configure.ac change proposal

2010-12-19 Thread Christopher Michael
That's git's problem, yea ? dh On 12/19/2010 04:32 PM, Albin Tonnerre wrote: > On Sun, 19 Dec 2010 16:18 -0500, Mike Blumenkrantz wrote : >> On Sun, 19 Dec 2010 15:36:57 -0500 >> Mike Blumenkrantz wrote: >> >>> Currently we use some really ugly shell scripting to grab the svn revision >>> of >>

Re: [E-devel] configure.ac change proposal

2010-12-19 Thread Christopher Michael
On 12/19/2010 03:36 PM, Mike Blumenkrantz wrote: > Currently we use some really ugly shell scripting to grab the svn revision of > our packages. I propose that we change this to what I have been using with > the > darkness theme for some time: > > current: > (svnversion "${SVN_REPO_PATH:-.}" | gr

Re: [E-devel] configure.ac change proposal

2010-12-19 Thread Michael Jennings
On Sunday, 19 December 2010, at 23:47:43 (+0100), Joerg Sonnenberger wrote: > > The spec files use: > > > > svnversion | sed 's/[^0-9].*$//' || echo > > > > which is portable. > > One important differences is that it picks up M if you have any local > changes. Check again. :) Michael --

Re: [E-devel] configure.ac change proposal

2010-12-19 Thread Joerg Sonnenberger
On Sun, Dec 19, 2010 at 02:20:21PM -0800, Michael Jennings wrote: > On Sunday, 19 December 2010, at 22:30:18 (+0100), > Joerg Sonnenberger wrote: > > > "grep -o" is not portable. Can't you do: > > > > svnversion -n "${SVN_REPO_PATH:-.}"| sed 's,^\([0-9]*\).*$,\1,' > > The spec files use: >

Re: [E-devel] configure.ac change proposal

2010-12-19 Thread Michael Jennings
On Sunday, 19 December 2010, at 22:30:18 (+0100), Joerg Sonnenberger wrote: > "grep -o" is not portable. Can't you do: > > svnversion -n "${SVN_REPO_PATH:-.}"| sed 's,^\([0-9]*\).*$,\1,' The spec files use: svnversion | sed 's/[^0-9].*$//' || echo which is portable. Michael -- Mi

Re: [E-devel] configure.ac change proposal

2010-12-19 Thread Joerg Sonnenberger
On Sun, Dec 19, 2010 at 03:36:57PM -0500, Mike Blumenkrantz wrote: > changed: > svnversion -n "${SVN_REPO_PATH:-.}"|grep -Eo "^[0-9]+" "grep -o" is not portable. Can't you do: svnversion -n "${SVN_REPO_PATH:-.}"| sed 's,^\([0-9]*\).*$,\1,' for much the same result? Joerg --

Re: [E-devel] configure.ac change proposal

2010-12-19 Thread Albin Tonnerre
On Sun, 19 Dec 2010 16:18 -0500, Mike Blumenkrantz wrote : > On Sun, 19 Dec 2010 15:36:57 -0500 > Mike Blumenkrantz wrote: > > > Currently we use some really ugly shell scripting to grab the svn revision > > of > > our packages. I propose that we change this to what I have been using with > > t

Re: [E-devel] configure.ac change proposal

2010-12-19 Thread Mike Blumenkrantz
On Sun, 19 Dec 2010 15:36:57 -0500 Mike Blumenkrantz wrote: > Currently we use some really ugly shell scripting to grab the svn revision of > our packages. I propose that we change this to what I have been using with > the darkness theme for some time: > > current: > (svnversion "${SVN_REPO_PAT

[E-devel] configure.ac change proposal

2010-12-19 Thread Mike Blumenkrantz
Currently we use some really ugly shell scripting to grab the svn revision of our packages. I propose that we change this to what I have been using with the darkness theme for some time: current: (svnversion "${SVN_REPO_PATH:-.}" | grep -v export || echo 0) | awk -F : '{printf("%s\n", $1);}' | tr