Dear Hyoyoung,
There are some coding conventions issues in your patch, for example:
for example the spaces around the + in this line:
eqchar = strchr(curlocater+key_len, '=');
Please fix those and re-send the patch. Also, if possible please also
include a quick explanation on what the problem
On Thu, 13 Jan 2011 16:10:23 +0900 Hyoyoung Chang hyoyoung.ch...@samsung.com
said:
how does this relate to your patches from 11/01/2011 with wrap mode stuff? i
see some potential overlap. is the re a chance you can collect this patch and
those from the 11th of jan int a patch set that also
On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote:
how does this relate to your patches from 11/01/2011 with wrap mode stuff? i
see some potential overlap. is the re a chance you can collect this patch and
those from the 11th of jan int a patch set that also implement enums?
wrap mode?
On Mon, 31 Jan 2011 10:11:52 +0200 Tom Hacohen
tom.haco...@partner.samsung.com said:
On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote:
how does this relate to your patches from 11/01/2011 with wrap mode stuff? i
see some potential overlap. is the re a chance you can collect this
Yeah yeah, I understand now.
On Mon, 2011-01-31 at 18:02 +0900, Carsten Haitzler wrote:
On Mon, 31 Jan 2011 10:11:52 +0200 Tom Hacohen
tom.haco...@partner.samsung.com said:
On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote:
how does this relate to your patches from 11/01/2011
Message-
From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com]
Sent: Tuesday, January 11, 2011 3:52 PM
To: Hyoyoung Chang
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] elm_label patch(bugfix and wrapmode changing)
Dear Hyoyoung,
I don't
Dear Elementary developers.
It's a bugfix patch at elm_label.
Revised some char iteration and fix potential null ptr ref in
strbuf_key_value_replace.
Thank you.
---
Hyoyoung CHANG
Engineer
SAMSUNG ELECTRONICS, Co., Ltd.
E-mail: hyoyoung.ch...@samsung.com
Dear Elementary developers.
It's a bugfix patch and adding new functionality for wrapmode changing at
elm_label.
1. bugfix strbuf_key_value_replace which is internal function
2. add wrapmode change api (wordwrap or charwrap)
Thank you.
---
Hyoyoung
Dear Hyoyoung,
I don't currently have the time to fully review the patches, but
regarding the wrapping: please be advised that after the release there
will be a new wrap mode, mixedwrap which is a word-wrap that falls
back to charwrap if a wordwrap can't be done (I assume you have seen
that
3:52 PM
To: Hyoyoung Chang
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] elm_label patch(bugfix and wrapmode changing)
Dear Hyoyoung,
I don't currently have the time to fully review the patches, but
regarding the wrapping: please be advised that after the release
: Re: [E-devel] elm_label patch(bugfix and wrapmode changing)
Dear Hyoyoung,
I don't currently have the time to fully review the patches, but
regarding the wrapping: please be advised that after the release there
will be a new wrap mode, mixedwrap which is a word-wrap that falls
back
On Thu, 30 Dec 2010 19:12:40 +0900 Hyoyoung Chang hyoyoung.ch...@samsung.com
said:
ok- in svn... but i fixed your ()'s - like:
while (*replocater *replocater != ' ' *replocater != '')
use ()'s to group operations to make sure you dont make order-of-operation
errors and you describe the
Dear Elementary developers.
It's a bugfix patch of elm_label.
In strbuf_key_value_replace, null pointer reference can be occured
Thank you.
---
Hyoyoung CHANG
Engineer
SAMSUNG ELECTRONICS, Co., Ltd.
E-mail: hyoyoung.ch...@samsung.com
13 matches
Mail list logo
