Dear all,
This is a patch for elm_map_marker_remove.
there are two seg-fault issues in this function.
1. the range of marker to remove.
2. after free(marker->groups[i]), reuse the value.
pls review this patch.
Thanks.
BR
Index: elementary/src/lib/elm_map.c
==
Dear all,
This is a patch for elm_map_marker_remove test code.
I added one button for marker_remove to test_map.c
pls review this patch.
Thanks.
BR
Index: elementary/src/bin/test_map.c
===
--- elementary/src/bin/test_map.c (리비
* Marc Koschewski [2011-02-09 09:07:45 +0100]:
> * Carsten Haitzler [2011-02-09 10:10:29 +0900]:
>
> > On Tue, 8 Feb 2011 15:36:25 +0100 Marc Koschewski
> > said:
> >
> > > Hi all,
> > >
> > > due the amount of configure flags for the verious parts of E17 I just
> > > lost my overview of th
I have checked, this is ok. You can commit.
2011/2/9 sangho park
> Dear all,
>
> This is a patch for elm_map_marker_remove.
> there are two seg-fault issues in this function.
>
> 1. the range of marker to remove.
> 2. after free(marker->groups[i]), reuse the value.
>
> pls review this patch.
>
* Marc Koschewski [2011-02-09 09:23:18 +0100]:
> * Marc Koschewski [2011-02-09 09:07:45 +0100]:
>
> > * Carsten Haitzler [2011-02-09 10:10:29 +0900]:
> >
> > > On Tue, 8 Feb 2011 15:36:25 +0100 Marc Koschewski
> > > said:
> > >
> > > > Hi all,
> > > >
> > > > due the amount of configure f
Hey all,
We recently released 1.0 for the core libraries, so now it's a good time
to review how we worked in the past, draw conclusions and hopefully also
improve our work-flow. When using the word "patches" in the following mail I
also mean commits done by developers with commit access (when that
2011/2/9 Carsten Haitzler :
> On Tue, 8 Feb 2011 14:40:13 +0100 Nicolas Aguirre
> said:
>
>> Hi,
>>
>> I would like to know if it would be hard to modify a bit everything
>> module to become a gadget. It would be awesome to have everything
>> displaying on the gadman layer or directly on the deskt
thanks, but do I have a privilege to commit?
If then, how can I commit? :)
On Wed, Feb 9, 2011 at 5:46 PM, Atton Jonathan wrote:
> I have checked, this is ok. You can commit.
>
> 2011/2/9 sangho park
>
>> Dear all,
>>
>> This is a patch for elm_map_marker_remove.
>> there are two seg-fault issu
On 02/09/2011 03:52 AM, Tom Hacohen wrote:
> Hey all,
>
> We recently released 1.0 for the core libraries, so now it's a good time
> to review how we worked in the past, draw conclusions and hopefully also
> improve our work-flow. When using the word "patches" in the following mail I
> also mean co
My comment are in-lined.
On Tue, 2011-02-08 at 09:28 +, ChunEon Park wrote:
> Hi Tom, sorry for replying lately.
It's ok. :)
>
>
> The reason, a ctxpopup is openning really far from where user click,
> is...
>
> currently it is intended to be affected by finger size.
>
> Yes. I realize
On Wed, 9 Feb 2011 09:51:41 +0100 Nicolas Aguirre
said:
> 2011/2/9 Carsten Haitzler :
> > On Tue, 8 Feb 2011 14:40:13 +0100 Nicolas Aguirre
> > said:
> >
> >> Hi,
> >>
> >> I would like to know if it would be hard to modify a bit everything
> >> module to become a gadget. It would be awesome to
Yeah,
On Wed, Feb 9, 2011 at 9:52 AM, Tom Hacohen
wrote:
> We recently released 1.0 for the core libraries, so now it's a good time
> to review how we worked in the past, draw conclusions and hopefully also
> improve our work-flow. When using the word "patches" in the following mail I
> also mean
On Wed, 2011-02-09 at 13:08 +0100, Cedric BAIL wrote:
> I am for enforcing commit by a svn hook for all top level library.
> This mean that if you wan to commit something in eina, eet, evas, ...,
> you should at least start by editing your info.txt and set that now
> you are a contributor to one of
On Wed, Feb 9, 2011 at 7:42 AM, Christopher Michael
wrote:
> On 02/09/2011 03:52 AM, Tom Hacohen wrote:
>> Hey all,
>>
>> We recently released 1.0 for the core libraries, so now it's a good time
>> to review how we worked in the past, draw conclusions and hopefully also
>> improve our work-flow. W
Tom Hacohen partner.samsung.com> writes:
>
> Hey all,
>
> We recently released 1.0 for the core libraries, so now it's a good time
> to review how we worked in the past, draw conclusions and hopefully also
> improve our work-flow. When using the word "patches" in the following mail I
> also mea
Hi,
I think we should update file monitoring events to match inotify.
Inotify is probably the one most use, and the API hasn't changed for a
while.
Is this patch ok?
S.
>From 36f0f4124c522abd0837f5816ddf1fb79ffefb88 Mon Sep 17 00:00:00 2001
From: Sebastian Dransfeld
Date: Wed, 9 Feb 2011 15
Hello,
On Wed, Feb 9, 2011 at 3:25 PM, Sebastian Dransfeld
wrote:
> I think we should update file monitoring events to match inotify. Inotify is
> probably the one most use, and the API hasn't changed for a while.
>
> Is this patch ok?
Sorry, not at all. It break ABI and API, that's a no go for
2011/2/7 Enlightenment SVN :
> Log:
> Manual merge of proxy code (inc ChangeLog)
>
> Author: nash
> Date: 2011-02-06 20:18:37 -0800 (Sun, 06 Feb 2011)
> New Revision: 56780
> Trac: http://trac.enlightenment.org/e/changeset/56780
>
> Modified:
> trunk/evas/ChangeLog trunk/evas
2011/2/9 Carsten Haitzler :
>
> but why not be in a window? how does being on the desktop canvas
> change/improve
> anything(well ok u can have translucency without compositing... that's about
> it
> - it's also going to be a little less resource hungry than a composited
> world).
> though i'd s
On Wed, 9 Feb 2011, Tom Hacohen wrote:
> Hey all,
>
> We recently released 1.0 for the core libraries, so now it's a good time
> to review how we worked in the past, draw conclusions and hopefully also
> improve our work-flow. When using the word "patches" in the following mail I
> also mean com
On Wed, 2011-02-09 at 16:19 +0100, Vincent Torri wrote:
> That's what I proposed with the patch ML and you said you didn't agree...
> as a lot of other people who are now thinking that your idea is good.
>
I think you misunderstood me. I don't think core developers should send
their patches to th
Hello,
I modified my previous patch that adds the necessary functions for controlling
the backlight levels. I fixed an small inconsistency in the function returning
the backlight level. Since my previous patch is not already applied, could one
you consider this modified version instead.
I sho
On Wed, 9 Feb 2011, Tom Hacohen wrote:
> On Wed, 2011-02-09 at 16:19 +0100, Vincent Torri wrote:
>> That's what I proposed with the patch ML and you said you didn't agree...
>> as a lot of other people who are now thinking that your idea is good.
>>
> I think you misunderstood me. I don't think
Hey,
I don't know ecore enough to commit it myself, but I still have a couple
of comments:
1. Your patch includes both logic and formatting changes, please split
to two different patches.
2. Please also include the changelog change in the same patch.
Also, if possible please also include a nice s
On Wed, 2011-02-09 at 16:54 +0100, Vincent Torri wrote:
>
> On Wed, 9 Feb 2011, Tom Hacohen wrote:
>
> > On Wed, 2011-02-09 at 16:19 +0100, Vincent Torri wrote:
> >> That's what I proposed with the patch ML and you said you didn't agree...
> >> as a lot of other people who are now thinking that y
Spank !
edje_cc: Error. Unable to load image "images/scrollframe_im2.png" used
by file "detour-elm.edj": File (or file path) does not exist. Check if
path to file "images/scrollframe_im2.png" is correct (both directory
and file name).
2011/2/9 Enlightenment SVN :
> Log:
> detour-elm: add entry an
In SVN!
> thanks, but do I have a privilege to commit?
Maybe not yet.
I committed it to upstream because it's reviewed by Atton Jonathan.
Thanks.
Daniel Juyung Seo (SeoZ)
On Wed, Feb 9, 2011 at 6:34 PM, sangho park wrote:
> thanks, but do I have a privilege to commit?
> If then, how can I com
Hey Tom,
I don't know ecore enough to commit it myself, but I still have a couple
of comments:
1. Your patch includes both logic and formatting changes, please split
to two different patches.
Two patches for three functions of fifteen lines each ? The formatting is
changed because I had to add a
On Wed, 9 Feb 2011, Enlightenment SVN wrote:
> Log:
> evas: make less noise when configuring
> Remove the following warning during bootstrap:
>
> configure.ac:790: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected
> in body
AC_LANG_PROGRAM is better
Vincent
>
> Reference:
> http
Fixed
2011/2/9 Nicolas Aguirre
> Spank !
> edje_cc: Error. Unable to load image "images/scrollframe_im2.png" used
> by file "detour-elm.edj": File (or file path) does not exist. Check if
> path to file "images/scrollframe_im2.png" is correct (both directory
> and file name).
>
>
> 2011/2/9 Enlig
evas_object_main.c: In function 'evas_object_del':
evas_object_main.c:406: warning: implicit declaration of function
'evas_object_image_source_unset'
evas_font_main.c: In function 'evas_common_font_ascent_get':
evas_font_main.c:91: warning: implicit declaration of function
'evas_common_font_int_r
Hy Mathieu
On Wed, Feb 9, 2011 at 3:50 PM, wrote:
> Hey Tom,
>
> I don't know ecore enough to commit it myself, but I still have a couple
> of comments:
> 1. Your patch includes both logic and formatting changes, please split
> to two different patches.
>
> Two patches for three functions of fif
Regarding formatting and logic: I mean actual code changes and spaces
changes.
For example you changed those empty lines at the start but also changed
features,
yes, your patch is short and easy to understand as is, but since I don't
work on ecore
I can't really tell if it's good or not so I won't
Please use pastebin, I can't read this. P.s what are your configure flags?
On Wed, Feb 9, 2011 at 8:05 PM, Mike Blumenkrantz wrote:
> evas_object_main.c: In function 'evas_object_del':
> evas_object_main.c:406: warning: implicit declaration of function
> 'evas_object_image_source_unset'
>
>
> ev
On 02/09/2011 01:05 PM, Mike Blumenkrantz wrote:
> evas_object_main.c: In function 'evas_object_del':
> evas_object_main.c:406: warning: implicit declaration of function
> 'evas_object_image_source_unset'
>
Fixed.
>
> evas_font_main.c: In function 'evas_common_font_ascent_get':
> evas_font_main.c:
On Wed, Feb 9, 2011 at 3:50 PM, wrote:
> Hey Tom,
>
> I don't know ecore enough to commit it myself, but I still have a couple
> of comments:
> 1. Your patch includes both logic and formatting changes, please split
> to two different patches.
>
> Two patches for three functions of fifteen lines
enclosed is the split version of the patch.
The first one remove trailing whitespaces. The second one implement backlight
support in Ecore. The ChangeLog is modified accordingly.
Best
Mathieu
- Mail Original -
De: "Tom Hacohen"
À: "mathieu taillefumier"
Cc: "Tom Hacohen" , "enlight
Thanks a lot, sorry for bugging you, but it makes life easier for everyone.
Sorry I can't commit, but I honestly don't know ecore well enough.
Thanks for your quick adjustments,
Tom.
On Wed, Feb 9, 2011 at 9:10 PM, wrote:
> enclosed is the split version of the patch.
>
> The first one remove tr
Hi Seb,
Latest efreet from trunk is a naughty boy ! ;) BT Here:
http://pastebin.com/Kd9xtPHv
dh
--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before th
I really hate to nit-pick, but it's still not correct :/
_backlight = XInternAtom (_ecore_x_disp, RANDR_PROPERTY_BACKLIGHT, True);
should be:
_backlight = XInternAtom(_ecore_x_disp, RANDR_PROPERTY_BACKLIGHT, True);
IE: We don't use spaces between function and function parameters.
This is done
On Wed, Feb 9, 2011 at 9:45 PM, Christopher Michael
wrote:
> I really hate to nit-pick, but it's still not correct :/
>
I didn't even take a look at the "real" changes. Just at the most obvious
ones. :)
--
Tom.
--
The ul
On Wed, 9 Feb 2011 15:57:42 +0100 Nicolas Aguirre
said:
> 2011/2/9 Carsten Haitzler :
> >
> > but why not be in a window? how does being on the desktop canvas
> > change/improve anything(well ok u can have translucency without
> > compositing... that's about it
> > - it's also going to be a littl
I really hate to nit-pick, but it's still not correct :/
_backlight = XInternAtom (_ecore_x_disp, RANDR_PROPERTY_BACKLIGHT, True);
should be:
_backlight = XInternAtom(_ecore_x_disp, RANDR_PROPERTY_BACKLIGHT, True);
IE: We don't use spaces between function and function parameters.
Too lazy to r
Hello
I fixed one small strange code in elm_gengrid.
"item" null checked after used item in elm_gengrid_item_selected_set()
function.
I deleted null checking code because already done in
ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN.
Can anybody check about this ?
Thanks.
Index:
On Wed, 9 Feb 2011 19:05:15 -0800
"Enlightenment SVN" wrote:
> Log:
> implemented full postgresql support (cell types aren't 100% implemented yet
> because I'm too lazy, but they're easy to add) fixed a bunch of bugs
> updated test example to demonstrate using the same object for both psql and
On 02/09/2011 06:49 PM, mathieu.taillefum...@free.fr wrote:
> I really hate to nit-pick, but it's still not correct :/
>
> _backlight = XInternAtom (_ecore_x_disp, RANDR_PROPERTY_BACKLIGHT, True);
>
> should be:
>
> _backlight = XInternAtom(_ecore_x_disp, RANDR_PROPERTY_BACKLIGHT, True);
>
> IE: We
On Wed, 09 Feb 2011 23:48:01 -0500
Christopher Michael wrote:
> On 02/09/2011 06:49 PM, mathieu.taillefum...@free.fr wrote:
> > I really hate to nit-pick, but it's still not correct :/
> >
> > _backlight = XInternAtom (_ecore_x_disp, RANDR_PROPERTY_BACKLIGHT, True);
> >
> > should be:
> >
> > _ba
On 02/10/2011 12:01 AM, Mike Blumenkrantz wrote:
> On Wed, 09 Feb 2011 23:48:01 -0500
> Christopher Michael wrote:
>
>> On 02/09/2011 06:49 PM, mathieu.taillefum...@free.fr wrote:
>>> I really hate to nit-pick, but it's still not correct :/
>>>
>>> _backlight = XInternAtom (_ecore_x_disp, RANDR_PR
On Thu, 10 Feb 2011 00:04:57 -0500
Christopher Michael wrote:
> On 02/10/2011 12:01 AM, Mike Blumenkrantz wrote:
> > On Wed, 09 Feb 2011 23:48:01 -0500
> > Christopher Michael wrote:
> >
> >> On 02/09/2011 06:49 PM, mathieu.taillefum...@free.fr wrote:
> >>> I really hate to nit-pick, but it's st
Hello,
Govindaraju SM and Prince Kumar Dubey sent me a new widget
elm_segment_control.
They're not allowed to send a file to out of company. :(
Anybody can review this?
I attached screenshot and patch codes.
And below are an email from them.
Thanks.
Daniel Juyung Seo (SeoZ)
--
Dear all,
Govindaraju SM sent me a elm_genlist show_region_hook patch like below.
Author: Govindaraju SM
Change Log: Enabling show_region_hook to handle the genlist item sub
objects hierarchical region show. Scroller pan geometry is included, as
scr
Dear EFL developers.
I have one question about elm_bg.
Please listen and reply me your opinion if you are interested in.
Currently, elm_bg loads the image data as original size and keeps it's
original buffer data. (even it is resized)
I don't know the concept of elm_bg exactly th
On Fri, 4 Feb 2011 13:29:20 +0100 Cedric BAIL said:
> On Fri, Feb 4, 2011 at 12:03 PM, Vincent Torri wrote:
> > On Fri, 4 Feb 2011, Cedric BAIL wrote:
> >> On Mon, Jan 31, 2011 at 7:12 PM, Vincent Torri wrote:
> >>> in elementary, the edje externals search the icons in PACKAGE_DATA_DIR
> >>> (s
On Thu, 10 Feb 2011, Carsten Haitzler (The Rasterman) wrote:
> On Fri, 4 Feb 2011 13:29:20 +0100 Cedric BAIL said:
>
>> On Fri, Feb 4, 2011 at 12:03 PM, Vincent Torri wrote:
>>> On Fri, 4 Feb 2011, Cedric BAIL wrote:
On Mon, Jan 31, 2011 at 7:12 PM, Vincent Torri wrote:
> in elementa
Hey Daniel,
Could you please explain a bit about this widget? (for those of us that
are too lazy to try it)
And please also generate a patch so it'll be easier for all of us to
test.
One last comment: I didn't yet test it, so I don't know if it even makes
sense for this widget, but it doesn't ha
55 matches
Mail list logo
