Re: [FFmpeg-devel] [PATCH] lavfi: add drawgraph filter

2015-06-27 Thread Paul B Mahol
Dana 26. 6. 2015. 21:26 osoba Dave Rice d...@dericed.com napisala je: Hi, On Jun 26, 2015, at 11:27 AM, Paul B Mahol one...@gmail.com wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- Waiting for comments and flames. Here are some comments and flames: I noticed that when I

Re: [FFmpeg-devel] [PATCH] Fixes the bug of comparing zero bytes. Also new check for linesize is added.

2015-06-27 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 02:01:15AM +0300, Ludmila Glinskih wrote: --- libavcodec/api-flac-test.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/libavcodec/api-flac-test.c b/libavcodec/api-flac-test.c index 402d4df..4cd0db7 100644 ---

Re: [FFmpeg-devel] [PATCH] lavfi: add drawgraph filter

2015-06-27 Thread Dave Rice
On Jun 27, 2015, at 3:47 AM, Paul B Mahol one...@gmail.com wrote: Dana 26. 6. 2015. 21:26 osoba Dave Rice d...@dericed.com napisala je: Hi, On Jun 26, 2015, at 11:27 AM, Paul B Mahol one...@gmail.com wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- Waiting for comments and

Re: [FFmpeg-devel] [PATCH] library.mak: add rpath to shared libraries

2015-06-27 Thread Ganesh Ajjanagadde
On Sat, Jun 27, 2015 at 2:22 AM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Sat, Jun 27, 2015 at 3:09 AM, Ganesh Ajjanagadde gajjanaga...@gmail.com wrote: Fixes Ticket4673 Signed-off-by: Ganesh Ajjanagadde gajjanaga...@gmail.com --- library.mak | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH 3/4] lavf/brstm: if the file lies about the last block's size, correct it

2015-06-27 Thread Michael Niedermayer
On Tue, Jun 23, 2015 at 12:35:35PM -0500, Rodger Combs wrote: --- libavformat/brstm.c | 9 + 1 file changed, 9 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of

Re: [FFmpeg-devel] [PATCH 01/12] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [1/4]

2015-06-27 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 02:43:31AM +0200, Michael Niedermayer wrote: On Fri, Jun 12, 2015 at 08:15:51AM +, Nedeljko Babic wrote: On Thu, Jun 11, 2015 at 4:08 PM, Nedeljko Babic nedeljko.ba...@imgtec.com wrote: From: Jovan Zelincevic jovan.zelince...@imgtec.com Move existing code

[FFmpeg-devel] [PATCH] Fix the bug of comparing zero bytes

2015-06-27 Thread Ludmila Glinskih
Add check for linesize. --- tests/api/api-flac-test.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tests/api/api-flac-test.c b/tests/api/api-flac-test.c index a6180bc..07030d6 100644 --- a/tests/api/api-flac-test.c +++ b/tests/api/api-flac-test.c @@

Re: [FFmpeg-devel] [PATCH] nutdec: check maxpos in read_sm_data before reading count

2015-06-27 Thread Andreas Cadhalpun
On 27.06.2015 18:02, Michael Niedermayer wrote: On Sat, Jun 27, 2015 at 05:53:26PM +0200, Andreas Cadhalpun wrote: nutdec.c |3 +++ 1 file changed, 3 insertions(+) 4e07b069348ca9b9d65b7850291448201c4d81f6 0001-nutdec-check-maxpos-in-read_sm_data-before-returning.patch From

[FFmpeg-devel] [PATCH] huffyuvdec: validate image size

2015-06-27 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/huffyuvdec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index 98c6128..71fb9e3 100644 --- a/libavcodec/huffyuvdec.c +++ b/libavcodec/huffyuvdec.c @@

Re: [FFmpeg-devel] [PATCH] nutdec: check maxpos in read_sm_data before reading count

2015-06-27 Thread Andreas Cadhalpun
On 27.06.2015 02:31, Michael Niedermayer wrote: On Fri, Jun 26, 2015 at 07:28:36PM +0200, Andreas Cadhalpun wrote: On 26.06.2015 01:36, Michael Niedermayer wrote: On Thu, Jun 25, 2015 at 11:46:41PM +0200, Andreas Cadhalpun wrote: Otherwise sm_size can be larger than size, which results in a

Re: [FFmpeg-devel] [PATCH] avutil/intmath: use bzhi gcc builtin in av_mod_uintp2()

2015-06-27 Thread James Almer
On 26/06/15 8:14 PM, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- Now making sure it's not used with ICC. Pushed the original. Oked by Cehoyos who confirmed ICC never reaches this code to begin with. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] nutdec: check maxpos in read_sm_data before reading count

2015-06-27 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 05:53:26PM +0200, Andreas Cadhalpun wrote: On 27.06.2015 02:31, Michael Niedermayer wrote: On Fri, Jun 26, 2015 at 07:28:36PM +0200, Andreas Cadhalpun wrote: On 26.06.2015 01:36, Michael Niedermayer wrote: On Thu, Jun 25, 2015 at 11:46:41PM +0200, Andreas Cadhalpun

[FFmpeg-devel] [PATCH] wavpack: use get_bits_long to read up to 32 bits

2015-06-27 Thread Andreas Cadhalpun
get_bits should not be used for more than 25 bits. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/wavpack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c index b51a21c..d91b66c 100644 ---

[FFmpeg-devel] [PATCH] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-06-27 Thread Andreas Cadhalpun
Claiming to have decoded more bytes than the packet size is wrong. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/wmavoice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index

[FFmpeg-devel] [PATCH] avcodec: Add support for Closed Caption export in h264

2015-06-27 Thread Kieran Kunhya
--- libavcodec/h264.c | 10 ++ libavcodec/h264.h | 2 ++ libavcodec/h264_sei.c | 32 +++- 3 files changed, 43 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 1cbd4cb..d971c7b 100644 --- a/libavcodec/h264.c +++

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/ebur128: fix indentation after last commit

2015-06-27 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 08:50:02PM +, Paul B Mahol wrote: On 11/16/14, Marton Balint c...@passwd.hu wrote: Signed-off-by: Marton Balint c...@passwd.hu --- libavfilter/f_ebur128.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_ebur128.c

Re: [FFmpeg-devel] [PATCH] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-06-27 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 08:36:15PM +0200, Andreas Cadhalpun wrote: Claiming to have decoded more bytes than the packet size is wrong. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/wmavoice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH] wavpack: use get_bits_long to read up to 32 bits

2015-06-27 Thread Paul B Mahol
On 6/27/15, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: get_bits should not be used for more than 25 bits. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/wavpack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCHv2] avcodec: Add support for Closed Caption export in h264

2015-06-27 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 09:12:20PM +0100, Kieran Kunhya wrote: Fix missing line --- libavcodec/h264.c | 11 +++ libavcodec/h264.h | 2 ++ libavcodec/h264_sei.c | 32 +++- 3 files changed, 44 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/ebur128: fix indentation after last commit

2015-06-27 Thread Paul B Mahol
On 11/16/14, Marton Balint c...@passwd.hu wrote: Signed-off-by: Marton Balint c...@passwd.hu --- libavfilter/f_ebur128.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index 8780062..63b4dad 100644 ---

[FFmpeg-devel] [PATCH] lavfi: add drawgraph filter

2015-06-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 76 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_drawgraph.c | 297 + 4 files changed, 375 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH 02/11] aaccoder: remove previous PNS implementation from twoloop

2015-06-27 Thread Claudio Freire
On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: This commit essentially undoes commit c5d4f87e8427c0952278ec247fa8ab1e6e52 and removes PNS band marking from the twoloop coder. LGTM, but I wouldn't apply it before #09

Re: [FFmpeg-devel] [PATCH 03/11] aaccoder: add intensity stereo coding support for the trellis quantizer

2015-06-27 Thread Claudio Freire
On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: +/* Energy spread threshold value below which no PNS is used, this corresponds to + * typically around 17Khz, after which PNS usage decays ending at 19Khz */ +#define NOISE_SPREAD_THRESHOLD 152234544.0f + +/*

[FFmpeg-devel] [PATCH] api-h264-test: build with another api test

2015-06-27 Thread Ludmila Glinskih
Location of api-h264-test changed to special directory for api tests. --- libavformat/Makefile| 1 - libavformat/api-h264-test.c | 183 tests/api/Makefile | 1 + tests/api/api-h264-test.c | 183

Re: [FFmpeg-devel] [PATCH 01/11] aac: add additional fields needed by the encoder for intensity stereo

2015-06-27 Thread Michael Niedermayer
On Fri, Jun 26, 2015 at 09:16:30PM +0100, Rostislav Pehlivanov wrote: This commit adds additional fields which are used by the native encoder to add intensity stereo support. It also adds some clarifying statements to the comments for the codebooks. --- libavcodec/aac.h | 9 +++-- 1

Re: [FFmpeg-devel] [PATCH] Fix the bug of comparing zero bytes

2015-06-27 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 05:31:08PM +0300, Ludmila Glinskih wrote: Add check for linesize. --- tests/api/api-flac-test.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] library.mak: add rpath to shared libraries

2015-06-27 Thread Ganesh Ajjanagadde
On Sat, Jun 27, 2015 at 9:49 AM, Ganesh Ajjanagadde gajja...@mit.edu wrote: On Sat, Jun 27, 2015 at 2:22 AM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Sat, Jun 27, 2015 at 3:09 AM, Ganesh Ajjanagadde gajjanaga...@gmail.com wrote: Fixes Ticket4673 Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 06/11] aacpsy: Add energy spread for each band

2015-06-27 Thread Claudio Freire
LGTM On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: -float distortion; -float perceptual_weight; Those are in fact in disuse. Thought I'd clarify. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] huffyuvdec: validate image size

2015-06-27 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 07:42:48PM +0200, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/huffyuvdec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index

[FFmpeg-devel] [PATCHv2] avcodec: Add support for Closed Caption export in h264

2015-06-27 Thread Kieran Kunhya
Fix missing line --- libavcodec/h264.c | 11 +++ libavcodec/h264.h | 2 ++ libavcodec/h264_sei.c | 32 +++- 3 files changed, 44 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 1cbd4cb..1569ec8 100644 ---

Re: [FFmpeg-devel] Intel QSV encoder

2015-06-27 Thread Roger Pack
You basically build it normally but build this as a library first: https://github.com/mjb2000/mfx_dispatch.git and configure with --enable-libmfx (NB that this mfx_dispatch thinger isn't compatible with windows XP so I don't use it personally):

Re: [FFmpeg-devel] GSoC update

2015-06-27 Thread Stephan Holljes
Hi, attached patches are the current state of work. It's probably still a bit rough around the edges, but I think I made some progress. The sample code in doc/examples does not write any data as of yet, but the HTTP handshake works. From b43aeaa27f6ca7df476aa194b2f78aa1b49516d0 Mon Sep 17 00:00:00