Re: [FFmpeg-devel] [PATCH] lavc/vaapi_decode: add va_profile format map support for HEVC_REXT

2019-03-27 Thread Fu, Linjie
> -Original Message- > From: myp...@gmail.com [mailto:myp...@gmail.com] > Sent: Thursday, March 28, 2019 13:03 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_decode: add va_profile > format map support

Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi header search

2019-03-27 Thread Song, Ruiling
> > > > > > Neo is the successor to Beignet, correct? > > Yes, that's the truth. > > Currently we simply checking against the specific header file of OpenCL, > > which is in-fact not accurate. > > I am not sure whether you would like to use Neo together with > > intel-media-driver, which is the

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_decode: add va_profile format map support for HEVC_REXT

2019-03-27 Thread myp...@gmail.com
On Thu, Mar 28, 2019 at 12:03 PM Linjie Fu wrote: > > HEVC_REXT will be map to {VAProfileHEVCMain422_10, VAProfileHEVCMain444, > VAProfileHEVCMain444_10} in vaapi_profile_map[], since need to be > distinguished > to select the exact va_profile. > > Add va_profile -> AV_PIX_FMT map for

Re: [FFmpeg-devel] [PATCH 3/5] doc/general.texi: remove note about regressed AviSynth+ header

2019-03-27 Thread Gyan
On 25-03-2019 01:59 AM, Stephen Hutchinson wrote: It's been fixed both AviSynth+-side and locally. --- doc/general.texi | 13 - 1 file changed, 13 deletions(-) diff --git a/doc/general.texi b/doc/general.texi index fe94c40386..6ec52962ff 100644 --- a/doc/general.texi +++

[FFmpeg-devel] [PATCH] x11grab: fix vertical repositioning

2019-03-27 Thread Octavio Alvarez
There is a calculation error in xcbgrab_reposition() that breaks vertical repositioning on follow_mouse. It made the bottom reposition occur when moving the mouse lower than N pixels after the capture bottom edge, instead of before. This commit fixes the calculation to match the documentation.

[FFmpeg-devel] [PATCH v2] libavcodec/vp8dec: fix the multi-thread HWAccel decode error

2019-03-27 Thread Shaofei Wang
Fix the issue: https://github.com/intel/media-driver/issues/317 the root cause is update_dimensions will be called multple times when decoder thread number is not only 1, but update_dimensions call get_pixel_format in each decode thread will trigger the hwaccel_uninit/hwaccel_init more than once.

[FFmpeg-devel] [PATCH] lavc/vaapi_decode: add va_profile format map support for HEVC_REXT

2019-03-27 Thread Linjie Fu
HEVC_REXT will be map to {VAProfileHEVCMain422_10, VAProfileHEVCMain444, VAProfileHEVCMain444_10} in vaapi_profile_map[], since need to be distinguished to select the exact va_profile. Add va_profile -> AV_PIX_FMT map for FF_PROFILE_HEVC_REXT to match the exact va_profile. Signed-off-by: Linjie

Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi header search

2019-03-27 Thread Dennis Mungai
On Thu, 28 Mar 2019 at 06:27, Song, Ruiling wrote: > > > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > Dennis Mungai > > Sent: Thursday, March 28, 2019 11:15 AM > > To: FFmpeg development discussions and patches > > Subject: Re:

Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi header search

2019-03-27 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Dennis Mungai > Sent: Thursday, March 28, 2019 11:15 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi >

Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi header search

2019-03-27 Thread Dennis Mungai
On Thu, 28 Mar 2019 at 06:10, Song, Ruiling wrote: > > > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > Dennis Mungai > > Sent: Thursday, March 28, 2019 7:11 AM > > To: FFmpeg development discussions and patches > > Subject: Re:

Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi header search

2019-03-27 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Dennis Mungai > Sent: Thursday, March 28, 2019 7:11 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi >

Re: [FFmpeg-devel] [PATCH] lavf/tls_gnutls: retry gnutls_handshake on non fatal errors

2019-03-27 Thread amine remita
this patch is based on the documentation for gnutls_handshake : > On these non-fatal errors call this function again, until it returns 0 > and the examples from the gnutls manual, such as:

Re: [FFmpeg-devel] [PATCH v1 1/1] swscale/swscale_unscaled: fixed the issue that when width/height is not 2-multiple, transition of nv12 to u/v planes is not completed.

2019-03-27 Thread Michael Niedermayer
On Wed, Mar 27, 2019 at 06:18:28PM +0800, Decai Lin wrote: > From: "Dong, Jerry" > > Signed-off-by: Dong, Jerry > Signed-off-by: Decai Lin > --- > libswscale/swscale_unscaled.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libswscale/swscale_unscaled.c

Re: [FFmpeg-devel] [PATCH]configure: Use -Wno-gnu-variable-sized-type-not-at-end with clang

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 15:18 GMT+01:00, Carl Eugen Hoyos : > Attached patch fixes many warnings when compiling vaapi with clang. > Also tested with clang-3.4. Will push if there are no comments. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavc/vaap_hevc: Do not initialize fields twice

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 23:10 GMT+01:00, Mark Thompson : > On 27/03/2019 13:58, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes a warning when compiling vaapi with clang. >> >> From 6463a3cf5730be9e9e6003f4aaf6c9fab7f68407 Mon Sep 17 00:00:00 2001 >> From: Carl Eugen Hoyos >> Date: Wed, 27 Mar 2019

Re: [FFmpeg-devel] [PATCH]lavc/vaapi_h264: Do not set unused deprecated fields

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 23:16 GMT+01:00, Mark Thompson : > On 27/03/2019 14:02, Carl Eugen Hoyos wrote: >> Hi! >> >> I don't think setting vaapi fields that are deprecated makes sense, this >> also silences a warning when compiling with clang. >> >> Please comment, Carl Eugen >> >> From

Re: [FFmpeg-devel] [PATCH] lavf/tls_gnutls: retry gnutls_handshake on non fatal errors

2019-03-27 Thread Michael Niedermayer
On Wed, Mar 27, 2019 at 01:03:07PM +0100, Remita Amine wrote: > fixes #7801 > > Signed-off-by: Remita Amine > --- > libavformat/tls_gnutls.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c > index

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add bink2 video decoder

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 21:21 GMT+01:00, Paul B Mahol : > Signed-off-by: Paul B Mahol > --- > Missing deblocking. Patch contains an "if (0 && ..." somewhere, I assume this is unintended. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: get vps extradata from MSDK

2019-03-27 Thread Mark Thompson
On 27/03/2019 10:27, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > V2: Fix the regression of qsv h264 encoding since no VPS for h264 > > libavcodec/qsvenc.c | 53 ++-- > libavcodec/qsvenc.h | 3 +++ > libavcodec/qsvenc_hevc.c | 10 +--- > 3

Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi header search

2019-03-27 Thread Dennis Mungai
On Thu, 28 Mar 2019 at 02:05, Mark Thompson wrote: > On 20/03/2019 07:57, Zhong Li wrote: > > Currectly just standard header path and be found, > > check_type/struct will fail if vaapi is installed somewhere else. > > --- > > configure | 18 ++ > > 1 file changed, 10

Re: [FFmpeg-devel] [CLT2019] FFmpeg at Chemnitzer Linux-Tage

2019-03-27 Thread Carl Eugen Hoyos
2019-03-23 16:11 GMT+01:00, Thilo Borgmann : > Hi, > >> FFmpeg has been accepted for CLT 2019 in Chemnitz, Germany! >> This "Chemnitzer Linux Tage" will take place on 16th and 17th of March. >> You can find more details on their homepage: >> >> https://chemnitzer.linux-tage.de/2019/en/ > > we

Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi header search

2019-03-27 Thread Mark Thompson
On 20/03/2019 07:57, Zhong Li wrote: > Currectly just standard header path and be found, > check_type/struct will fail if vaapi is installed somewhere else. > --- > configure | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/configure b/configure >

Re: [FFmpeg-devel] [CLT2019] FFmpeg at Chemnitzer Linux-Tage

2019-03-27 Thread Thomas Volkert
Hi, On 23.03.2019 16:11, Thilo Borgmann wrote: > Hi, > >> FFmpeg has been accepted for CLT 2019 in Chemnitz, Germany! >> This "Chemnitzer Linux Tage" will take place on 16th and 17th of March. >> You can find more details on their homepage: >> >> https://chemnitzer.linux-tage.de/2019/en/ > we

Re: [FFmpeg-devel] [PATCH] configure: Do not enable both OpenCL-VAAPI interop modes simultaneously

2019-03-27 Thread Mark Thompson
On 27/03/2019 00:59, Song, Ruiling wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Mark Thompson >> Sent: Wednesday, March 27, 2019 7:39 AM >> To: FFmpeg development discussions and patches >> Subject: [FFmpeg-devel] [PATCH]

Re: [FFmpeg-devel] [PATCH] Fix loss of precision for silencedetecton large files

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 23:13 GMT+01:00, Allan Cady via ffmpeg-devel : > On Tue, Mar 26, 2019 at 10:07:10PM +, Allan Cady via ffmpeg-devel > wrote: > >> When the silencedetect filter is run against very large files, the >> output timestamps gradually lose precision as the scan proceeds >> further into the

Re: [FFmpeg-devel] [PATCH] qsv: fix the dangerous macro definitions

2019-03-27 Thread Mark Thompson
On 27/03/2019 10:24, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/qsv_internal.h | 8 > libavfilter/qsvvpp.h | 8 > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/qsv_internal.h b/libavcodec/qsv_internal.h > index

Re: [FFmpeg-devel] [PATCH]lavc/vaapi_h264: Do not set unused deprecated fields

2019-03-27 Thread Mark Thompson
On 27/03/2019 14:02, Carl Eugen Hoyos wrote: > Hi! > > I don't think setting vaapi fields that are deprecated makes sense, this > also silences a warning when compiling with clang. > > Please comment, Carl Eugen > > From b1f4e64e577ffecd1eab7b95d8d6f90e261cdd74 Mon Sep 17 00:00:00 2001 > From:

Re: [FFmpeg-devel] [PATCH]lavc/vaap_hevc: Do not initialize fields twice

2019-03-27 Thread Mark Thompson
On 27/03/2019 13:58, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a warning when compiling vaapi with clang. > > From 6463a3cf5730be9e9e6003f4aaf6c9fab7f68407 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Wed, 27 Mar 2019 14:52:35 +0100 > Subject: [PATCH] lavc/vaapi_hevc:

Re: [FFmpeg-devel] [PATCH] Fix loss of precision for silencedetecton large files

2019-03-27 Thread Allan Cady via ffmpeg-devel
On Tue, Mar 26, 2019 at 10:07:10PM +, Allan Cady via ffmpeg-devel wrote: > When the silencedetect filter is run against very large files, the > output timestamps gradually lose precision as the scan proceeds > further into the file. This is because the output is formatted (in >

Re: [FFmpeg-devel] [PATCH 2/4] lavc/qsvenc: fix hevc vps extradata issues

2019-03-27 Thread Mark Thompson
On 26/03/2019 19:46, Zhong Li wrote: > cbs trace qsv vps header failed due to some reasons: > 1. vps_temporal_id_nesting_flag is not set but spec required it must to >be 1 when vps_max_sub_layers_minus1 is equal to 0. > 2. vps_num_hrd_parameters is not set and written. > 3. other issues in

Re: [FFmpeg-devel] [PATCH] libavcodec Adding ff_v210_planar_unpack AVX2

2019-03-27 Thread James Darnley
On 2019-03-26 21:22, Mike Stoner via ffmpeg-devel wrote: > Hello, > I’ve accounted for all feedback on this so far, I’m wondering if it is ready > to be pushed upstream? > > Here are my results from ‘checkasm’ (lower is better): > > v210_unpack_c: 1636 > v210_unpack_ssse3: 611 >

Re: [FFmpeg-devel] avcodec/videotoolbox: add support for full range and 10bit pixel formats

2019-03-27 Thread der richter
apparently the first patch didn't make it through 0001-avcodec-videotoolbox-add-support-for-10bit-pixel-for.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] avcodec/videotoolbox: add support for full range and 10bit pixel formats

2019-03-27 Thread der richter
the second patch 0002-avcodec-videotoolbox-add-support-for-full-range-deco.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-27 Thread Alexander Strasser
Hi Stephan! On 2019-03-25 20:32 +0100, Stephan Hilb wrote: > Alexander Strasser wrote on 21.03.2019 at 23:34: > > > 3. Return zero-sized packets => This works and is consistent with how > >we handle frames flagged to be corrupted (V4L2_BUF_FLAG_ERROR). > >See commit

Re: [FFmpeg-devel] [PATCH v9 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-03-27 Thread Mark Thompson
On 27/03/2019 17:13, Vittorio Giovara wrote: > On Tue, Mar 26, 2019 at 10:47 PM Jing Sun wrote: > >> Signed-off-by: Zhengxu Huang >> Signed-off-by: Hassene Tmar >> Signed-off-by: Jun Zhao >> Signed-off-by: Jing Sun >> --- >> configure| 4 + >> libavcodec/Makefile |

[FFmpeg-devel] avcodec/videotoolbox: add support for full range and 10bit pixel formats

2019-03-27 Thread der richter
these additions consist of two patches. the first one is a slight modified version of a patch from issue #7704 that adds a 10bit pixel format. i basically just added the pixel format availability checks. the second patch adds full range pixel formats. the issue arose on the mpv issue tracker.

[FFmpeg-devel] [PATCH] Check if we do have also a filter_complex filter.

2019-03-27 Thread Thierry Foucu
Right now, the code check for no filter description, but if we use a filter_complex, the code will use the AVFrame.duration which could be wrong in case of using fps filter. How to reproduce the problem: ffmpeg -f lavfi -i testsrc=duration=1 -vf fps=fps=50 -vsync 1 -f null - output 50 frames

[FFmpeg-devel] [PATCH 1/2] avformat/bink: properly mark packets that are key frames

2019-03-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/bink.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/bink.c b/libavformat/bink.c index 631b8c4d7d..44eb04362e 100644 --- a/libavformat/bink.c +++ b/libavformat/bink.c @@ -56,6 +56,7 @@ typedef struct

Re: [FFmpeg-devel] [PATCH] Fix loss of precision for silencedetect on large files

2019-03-27 Thread Michael Niedermayer
On Tue, Mar 26, 2019 at 10:07:10PM +, Allan Cady via ffmpeg-devel wrote: > When the silencedetect filter is run against very large files, the > output timestamps gradually lose precision as the scan proceeds > further into the file. This is because the output is formatted (in >

Re: [FFmpeg-devel] [PATCH v9 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-03-27 Thread Vittorio Giovara
On Tue, Mar 26, 2019 at 10:47 PM Jing Sun wrote: > Signed-off-by: Zhengxu Huang > Signed-off-by: Hassene Tmar > Signed-off-by: Jun Zhao > Signed-off-by: Jing Sun > --- > configure| 4 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + >

Re: [FFmpeg-devel] scaling option

2019-03-27 Thread Dennis Mungai
On Wed, 27 Mar 2019 at 17:51, Yufei He wrote: > On 03/26/2019 02:36 PM, Dennis Mungai wrote: > > > > On Tue, Mar 26, 2019, 21:20 Yufei He wrote: > >> On 03/26/2019 11:31 AM, Dennis Mungai wrote: >> > On Tue, 26 Mar 2019 at 18:21, Yufei He wrote: >> > >> >> On 03/26/2019 08:53 AM, Timo

Re: [FFmpeg-devel] [PATCH 4/4] lavc/qsvenc_h264: remove the privite option trellis

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 15:51 GMT+01:00, Moritz Barsnick : > On Wed, Mar 27, 2019 at 20:51:47 +0800, Zhong Li wrote: >> Just simply remove the private option, and switch to the AVCodecContext >> definition. Compatibility should not a big problem (expect can't exact >> map) >> since the option name is same as

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 16:30 GMT+01:00, Yufei He : > Here is the fixed patch for a new H.264 codec with Matrox > M264 card. Please do not send another version of this patch that doesn't add the non-free requirement in configure (or open-source your library). Carl Eugen

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-27 Thread Nicolas George
Yufei He (12019-03-27): > Here is the fixed patch for a new H.264 codec with Matrox M264 card. > > It calls the default library from the card's driver installation. > Please review. You are still using programmatic dynamic linking instead of normal dynamic linking, and you have not given a good

[FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-27 Thread Yufei He
Hi Here is the fixed patch for a new H.264 codec with Matrox M264 card. It calls the default library from the card's driver installation. Please review. Thanks. Yufei. From da521d4e1315199a5fb781adf8a56efdc64c2b42 Mon Sep 17 00:00:00 2001 From: yhe Date: Wed, 27 Mar 2019 11:05:41 -0400

Re: [FFmpeg-devel] [PATCH 4/4] lavc/qsvenc_h264: remove the privite option trellis

2019-03-27 Thread Moritz Barsnick
On Wed, Mar 27, 2019 at 20:51:47 +0800, Zhong Li wrote: > Just simply remove the private option, and switch to the AVCodecContext > definition. Compatibility should not a big problem (expect can't exact map) > since the option name is same as AVCodecContext. You should probably bump libavcodec's

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -drop_deviant_frames option

2019-03-27 Thread Gyan
Weird. Attached corrected patch. Thanks. On 27-03-2019 08:19 PM, Moritz Barsnick wrote: On Wed, Mar 27, 2019 at 18:05:32 +0530, Gyan wrote: +@item -drop_deviant_frames (@emph{input,per-stream}) +Allows discarding decoded frames whose parameters differ from initialized +stream parameters. May

Re: [FFmpeg-devel] scaling option

2019-03-27 Thread Yufei He
On 03/26/2019 02:36 PM, Dennis Mungai wrote: On Tue, Mar 26, 2019, 21:20 Yufei He mailto:y...@matrox.com>> wrote: On 03/26/2019 11:31 AM, Dennis Mungai wrote: > On Tue, 26 Mar 2019 at 18:21, Yufei He > mailto:y...@matrox.com>> wrote: > >> On 03/26/2019 08:53 AM, Timo Rothenpieler wrote: >> On

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -drop_deviant_frames option

2019-03-27 Thread Moritz Barsnick
On Wed, Mar 27, 2019 at 18:05:32 +0530, Gyan wrote: > +@item -drop_deviant_frames (@emph{input,per-stream}) > +Allows discarding decoded frames whose parameters differ from initialized > +stream parameters. May be useful in > + It looks like this was truncated. Moritz Cheers,

Re: [FFmpeg-devel] [PATCH 00/21] New Version

2019-03-27 Thread Pedro Arthur
Em qua, 27 de mar de 2019 às 09:23, Andreas Rheinhardt via ffmpeg-devel escreveu: > > Carl Eugen Hoyos: > > 2019-03-27 12:18 GMT+01:00, Andreas Rheinhardt: > > > >> I have cced Steve for this (I didn't the first time, > >> because I thought that he (as a maintainer) would > >> also be a

[FFmpeg-devel] [PATCH]configure: Use -Wno-gnu-variable-sized-type-not-at-end with clang

2019-03-27 Thread Carl Eugen Hoyos
Hi! Attached patch fixes many warnings when compiling vaapi with clang. Also tested with clang-3.4. Please comment, Carl Eugen From 0df0773aaf6fa3b920ad078c534f4e1b4e203413 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 27 Mar 2019 15:15:54 +0100 Subject: [PATCH] configure: Use

[FFmpeg-devel] [PATCH]lavc/vaapi_h264: Do not set unused deprecated fields

2019-03-27 Thread Carl Eugen Hoyos
Hi! I don't think setting vaapi fields that are deprecated makes sense, this also silences a warning when compiling with clang. Please comment, Carl Eugen From b1f4e64e577ffecd1eab7b95d8d6f90e261cdd74 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 27 Mar 2019 14:58:51 +0100 Subject:

[FFmpeg-devel] [PATCH]lavc/vaap_hevc: Do not initialize fields twice

2019-03-27 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a warning when compiling vaapi with clang. Please comment, Carl Eugen From 6463a3cf5730be9e9e6003f4aaf6c9fab7f68407 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 27 Mar 2019 14:52:35 +0100 Subject: [PATCH] lavc/vaapi_hevc: Do not initialize fields twice.

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/latmenc: Error out for unsupported codecs.

2019-03-27 Thread Carl Eugen Hoyos
2019-03-21 10:06 GMT+01:00, Nicolas George : > Carl Eugen Hoyos (12019-03-20): >> +if (par->codec_id != AV_CODEC_ID_AAC && par->codec_id != >> AV_CODEC_ID_MP4ALS) { >> +av_log(ctx, AV_LOG_ERROR, "Only AAC, LATM and ALS are >> supported\n"); >> +return AVERROR_INVALIDDATA; >> +

[FFmpeg-devel] Avoid MPEG-TS 1-cycle delay

2019-03-27 Thread Paolo Pr
Hello, looking at the code of libavformat/mpegtsenc.c I experienced a 1-cycle delay with the mpegts muxer that could be avoided (at least for Opus codec) by putting the following lines: ( https://ffmpeg.org/doxygen/4.1/mpegtsenc_8c_source.html#l01777 ) memcpy(ts_st->payload +

[FFmpeg-devel] [PATCH 3/4] lavc/qsvenc: use the common option "trellis" of AVCodecContext

2019-03-27 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 5 - libavcodec/qsvenc_h264.c | 2 +- libavcodec/qsvenc_hevc.c | 2 +- libavcodec/qsvenc_mpeg2.c | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index

[FFmpeg-devel] [PATCH 2/4] lavc/qsvenc: enable hevc gpb option

2019-03-27 Thread Zhong Li
GPB is the default type, just contains forward references but the slice_type is B slice. Add this option to allow user to set regular P slice. Fix ticket#6870 Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 7 +++ libavcodec/qsvenc.h | 4 libavcodec/qsvenc_hevc.c | 2 ++ 3

[FFmpeg-devel] [PATCH 4/4] lavc/qsvenc_h264: remove the privite option trellis

2019-03-27 Thread Zhong Li
There are many problems of current qsv trellis option: 1. Duplicated with AVCodecContext definition 2. MFX_TRELLIS_XXX is introduced by MSDK API 1.17 Currently Without MSDK API checking thus may cause compilation issue. 3. user is inclined to enable trellis when set "-trellis 1", but

[FFmpeg-devel] [PATCH 1/4] lavc/qsvenc: enable hevc coding options configuration

2019-03-27 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 2f128597db..1d9893efbf 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -625,9 +625,10 @@ static int

[FFmpeg-devel] [PATCH] ffmpeg: add -drop_deviant_frames option

2019-03-27 Thread Gyan
Essential in avoiding loss of output streams (audio) for me, when input has unreliable transport. Tested with software decoding (h264, aac, mp1, mp2) pipeline. Gyan From ca04af063ee4a9406b6f09e12126827728aff875 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Mon, 25 Mar 2019 22:01:07 +0530

Re: [FFmpeg-devel] [PATCH 00/21] New Version

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
Carl Eugen Hoyos: > 2019-03-27 12:18 GMT+01:00, Andreas Rheinhardt: > >> I have cced Steve for this (I didn't the first time, >> because I thought that he (as a maintainer) would >> also be a subscriber to this list). > > Everybody welcomes reviews by Steve but I don't > think he maintains

Re: [FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

2019-03-27 Thread Ulf Zibis
Am 26.03.19 um 17:12 schrieb Carl Eugen Hoyos: > I was under the impression that we exchanged all > these emails today only because you still hadn't > found a way to measure the performance of your > patch. As I had written, I found a way with "-vf loop=loop=1024:size=1:start=0", but I was

[FFmpeg-devel] [PATCH] lavf/tls_gnutls: retry gnutls_handshake on non fatal errors

2019-03-27 Thread Remita Amine
fixes #7801 Signed-off-by: Remita Amine --- libavformat/tls_gnutls.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c index e3c43683be..f32bc2821b 100644 --- a/libavformat/tls_gnutls.c +++

Re: [FFmpeg-devel] [PATCH 00/21] New Version

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 12:18 GMT+01:00, Andreas Rheinhardt: > I have cced Steve for this (I didn't the first time, > because I thought that he (as a maintainer) would > also be a subscriber to this list). Everybody welcomes reviews by Steve but I don't think he maintains anything within FFmpeg. > Oh, and I

[FFmpeg-devel] [PATCH 06/21] avformat/matroskadec: Don't copy attached pictures

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
This commit replaces copying attached pictures by using references to the already existing buffers. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskadec.c

[FFmpeg-devel] [PATCH 21/21] avformat/matroskadec: Typos and cosmetics

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index bd0dfee4db..8243b858da 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c

[FFmpeg-devel] [PATCH 20/21] avformat/matroskadec: Redo EOF handling

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
This commit adds a check and a corresponding warning whether there is data beyond the Matroska segment (only reasonable for finite-sized segments). If everything looks alright, then parsing is stopped as soon as EOF is reached (in contrast, the current code would always call matroska_resync at the

[FFmpeg-devel] [PATCH 18/21] avformat/matroskadec: Combine two arrays

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
By including SimpleBlocks and Blocksgroups twice in the same EbmlSyntax array (with different semantics), one can reduce the duplication of the other values. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-)

[FFmpeg-devel] [PATCH 19/21] avformat/matroskadec: Add SilentTracks to cluster syntax

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
This is important as unknown-sized elements end upon encountering an unknown EBML ID. Signed-off-by: Andreas Rheinhardt --- libavformat/matroska.h| 1 + libavformat/matroskadec.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavformat/matroska.h b/libavformat/matroska.h index

[FFmpeg-devel] [PATCH 17/21] avformat/matroskadec: Don't reset cluster position

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
The new code does not rely on whether the cluster's position is set or not to infer whether a cluster needs to be closed or not (instead, the levels are closed during ebml_parse), so there is no need to reset the cluster's position at all any more. It will be automatically set to the correct value

[FFmpeg-devel] [PATCH 14/21] avformat/matroskadec: Use proper levels after discontínuity

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
The earlier code set the level to zero upon seeking and after a discontinuity although in both cases parsing (re)starts at a level 1 element. Also set the segment's length to unkown if an error occured in order not to drop any valid data that happens to be beyond the designated end of the

[FFmpeg-devel] [PATCH 15/21] avformat/matroskadec: Redo level handling

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
This commit changes how levels are handled: If the level used for ebml_parse ends directly after an element that has been consumed, then ebml_parse ends the level itself (and any finite-sized levels that end there as well) and informs the caller via the return value; if the current level is

[FFmpeg-devel] [PATCH 16/21] avformat/matroskadec: Make cluster parsing level compatible

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
Before this commit, the parsing of clusters mixed EBML levels by allowing elements from different levels in a EbmlSyntax (namely matroska_cluster_parsing). This has been changed. The level is now explicitly used to determine how to parse. Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH 12/21] avformat/matroskadec: Remove redundant variable declaration

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index b98e690f01..6fa324c0cc 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -1179,7 +1179,6 @@

[FFmpeg-devel] [PATCH 13/21] avformat/matroskadec: Improve length check

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
The earlier code had three flaws: 1. The case of an unknown-sized element inside a finite-sized element (which is against the specifications) was not caught. 2. The error message wasn't helpful: It compared the length of the child with the offset of the end of the parent and claimed that the

[FFmpeg-devel] [PATCH 11/21] avformat/matroskadec: Treat SimpleBlock as EBML_BIN

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
Up until now, the SimpleBlock was treated specially: It basically had its own EBML category and it was also included in the BlockGroup EBML syntax (although a SimpleBlock must not exist in a BlockGroup according to the Matroska specifications). The latter fact also meant that a MatroskaBlock's

[FFmpeg-devel] [PATCH 08/21] avformat/matroskadec: Improve error messages

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
ebml_read_num had a number of flaws: 1. The check for read errors/EOF was totally wrong. E.g. an EBML number beginning with the invalid 0x00 would be considered a read error, although it is just invalid data. 2. The check for read errors/EOF was done just once, after reading the first byte of the

[FFmpeg-devel] [PATCH 09/21] avformat/matroskadec: Remove non-incremental parsing of clusters

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
When the new incremental parser was introduced, the old parser was kept, because the new parser was unable to handle the way SSA packets are put into Matroska. But since 2014 (since c7d8dbad14ed5fa3c217a4fc1790021d6c0b6416) this is no longer needed, so that the old parser can be completely

[FFmpeg-devel] [PATCH 10/21] avformat/matroskadec: Don't keep old blocks

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
Before this commit, the Matroska muxer would read a block when required to do so, parse the block, create and return the necessary AVPackets and yet keep the blocks (in a dynamically allocated list), although they aren't used at all any more. This has been changed. There is no list any more and

[FFmpeg-devel] [PATCH 05/21] avformat/matroskadec: Set offset of first cluster

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
By default, the data_offset member of the AVFormatInternal of the AVFormatContext associated with the MatroskaDemuxContext has not been initialized explicitly by any Matroska-specific function, so that it was initialized by default to the offset at the end of matroska_read_header, i.e. usually to

[FFmpeg-devel] [PATCH 07/21] avformat/matroskadec: Remove redundant initialization

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
Every new element of an EbmlList is zeroed initially in ebml_parse_elem, so that in particular a SimpleBlock's duration is initialized to zero. Therefore it is unnecessary to initialize this field again (for SimpleBlocks) in matroska_parse_cluster_incremental. Signed-off-by: Andreas Rheinhardt

[FFmpeg-devel] [PATCH 04/21] avformat/matroskadec: Use generic size check for signed integers

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
and drop the redundant checks contained in ebml_read_uint and ebml_read_sint. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index

[FFmpeg-devel] [PATCH 02/21] avformat/matroskadec: Don't zero unnecessarily

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
It is only necessary to zero the initial allocated memory used to store the size of laced frames if the block used Xiph lacing. Otherwise no unintialized data was ever used, so use av_malloc instead of av_mallocz. Also use the correct type for the allocations. Signed-off-by: Andreas Rheinhardt

[FFmpeg-devel] [PATCH 01/21] avformat/matroskadec: Remove unused variables

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 81e9bb9bff..48b1ba3872 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@

[FFmpeg-devel] [PATCH 03/21] avformat/matroskadec: Get rid of cluster size field assumption

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
The earlier code relied on the length of clusters always being coded on eight bytes (as is current Matroska muxer behaviour). But there is no need to rely on this and this commit changes it. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 13 - 1 file changed, 8

[FFmpeg-devel] [PATCH 00/21] New Version

2019-03-27 Thread Andreas Rheinhardt via ffmpeg-devel
Here is a new version. Some of the already sent patches were slightly modified: The first patch now removes two unused variables and "Improve length check" has been rewritten. Furthermore, some new patches not directly needed in order to fix the garbage error message have been added: 1. The

Re: [FFmpeg-devel] [PATCH] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-03-27 Thread Wang, Shaofei
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Carl Eugen Hoyos > Sent: Tuesday, March 26, 2019 6:36 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] Improved the performance of 1 decode + > N

[FFmpeg-devel] [PATCH v2] lavc/qsvenc: get vps extradata from MSDK

2019-03-27 Thread Zhong Li
Signed-off-by: Zhong Li --- V2: Fix the regression of qsv h264 encoding since no VPS for h264 libavcodec/qsvenc.c | 53 ++-- libavcodec/qsvenc.h | 3 +++ libavcodec/qsvenc_hevc.c | 10 +--- 3 files changed, 54 insertions(+), 12 deletions(-)

[FFmpeg-devel] [PATCH] qsv: fix the dangerous macro definitions

2019-03-27 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/qsv_internal.h | 8 libavfilter/qsvvpp.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/qsv_internal.h b/libavcodec/qsv_internal.h index 394c558883..86a5dbad98 100644 --- a/libavcodec/qsv_internal.h +++

[FFmpeg-devel] [PATCH v1 1/1] swscale/swscale_unscaled: fixed the issue that when width/height is not 2-multiple, transition of nv12 to u/v planes is not completed.

2019-03-27 Thread Decai Lin
From: "Dong, Jerry" Signed-off-by: Dong, Jerry Signed-off-by: Decai Lin --- libswscale/swscale_unscaled.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c index 058f2b9..2ba2907 100644 ---

Re: [FFmpeg-devel] [PATCH] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-03-27 Thread Wang, Shaofei
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Wednesday, March 27, 2019 5:24 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] Improved the performance of 1 decode + > N

Re: [FFmpeg-devel] [PATCH] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-03-27 Thread Wang, Shaofei
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Wednesday, March 27, 2019 6:44 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] Improved the performance of 1 decode + > N filter graphs and

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/zmbvenc: add support for 24-bit encoding, using pix_fmt BGR24.

2019-03-27 Thread Tomas Härdin
tis 2019-03-26 klockan 22:13 + skrev Matthew Fearnley: > Support is #ifdef'd out at this stage, using ZMBV_ENABLE_24BPP (like in > the zmbv.c decoder) > --- >  libavcodec/zmbvenc.c | 9 + >  1 file changed, 9 insertions(+) > > diff --git a/libavcodec/zmbvenc.c b/libavcodec/zmbvenc.c >

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-03-27 Thread Tomas Härdin
tis 2019-03-26 klockan 22:13 + skrev Matthew Fearnley: > This brings the channel order in line with that used in 32-bit mode (BGR0). > > 24-bit decoding is disabled by default (#ifdef ZMBV_ENABLE_24BPP), and no > prior encoders or sample videos are known to exist for this bit depth, so > I

Re: [FFmpeg-devel] [PATCH]lavc/bmp: Avoid a heap buffer overwrite for 1bpp

2019-03-27 Thread Tomas Härdin
tis 2019-03-26 klockan 13:38 +0100 skrev Carl Eugen Hoyos: > Hi! > > Attached patch intends to fix a buffer overwrite reported today. Funny, I was looking at this code a few weeks ago as a good candidate for some static analysis/formal verification > ptr[avctx->width - (avctx->width & 7) + j] =

Re: [FFmpeg-devel] [PATCH 3/3] doc/examples: add QSV decode GPU copy sample

2019-03-27 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Wednesday, March 27, 2019 11:17 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 3/3] doc/examples: add QSV decode >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevcdec: Avoid only partly skiping duplicate first slices

2019-03-27 Thread Michael Niedermayer
On Tue, Mar 26, 2019 at 10:19:44PM -0300, James Almer wrote: > On 3/26/2019 9:17 PM, Michael Niedermayer wrote: > > Fixes: NULL pointer dereference and out of array access > > Fixes: > > 13871/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5746167087890432 > > Fixes: > >

Re: [FFmpeg-devel] [PATCH v2 resend] swscale/ppc: VSX-optimize yuv2rgb_full

2019-03-27 Thread Lauri Kasanen
On Thu, 21 Mar 2019 09:54:17 +0200 Lauri Kasanen wrote: > ./ffmpeg -f lavfi -i yuvtestsrc=duration=1:size=1200x1440 \ > -s 1200x1440 -f null -vframes 100 -pix_fmt $i -nostats \ > -cpuflags 0 -v error - > > This uses 32-bit mul, so POWER8 only. > > The following output formats get

Re: [FFmpeg-devel] [PATCH v2] swscale: Remove duplicated code

2019-03-27 Thread Lauri Kasanen
On Tue, 26 Mar 2019 22:00:54 +0100 Michael Niedermayer wrote: > On Tue, Mar 26, 2019 at 08:58:34AM +0200, Lauri Kasanen wrote: > > In this function, the exact same clamping happens both in the if and > > unconditionally. > > > > Signed-off-by: Lauri Kasanen > > --- > > libswscale/output.c |