[FFmpeg-devel] [PATCH v3 4/4] avcodec/mips: cabac.h provide fallback for wsbh instruction

2021-07-22 Thread Jiaxun Yang
wsbh is only avilable for MIPS R2+. Provide a fallback for older processors. Signed-off-by: Jiaxun Yang Reviewed-by: Shiyou Yin --- libavcodec/mips/cabac.h | 24 1 file changed, 24 insertions(+) diff --git a/libavcodec/mips/cabac.h b/libavcodec/mips/cabac.h index

[FFmpeg-devel] [PATCH v3 3/4] avutil/mips: Use $at as MMI macro temporary register

2021-07-22 Thread Jiaxun Yang
Some function had exceed 30 inline assembly register oprands limiation when using LOONGSON2 version of MMI macros. We can avoid that by take $at, which is register reserved for assembler, as temporary register. As none of instructions used in these macros is pseudo, it is safe to utilize $at

[FFmpeg-devel] [PATCH v3 2/4] avcodec/mips: Use MMI marcos to replace Loongson3 instructions

2021-07-22 Thread Jiaxun Yang
Loongson3's extention instructions (prefixed with gs) are widely used in our MMI codebase. However, these instructions are not avilable on Loongson-2E/F while MMI code should work on these processors. Previously we introduced mmiutils marcos to provide backward compactbility but newly commited

[FFmpeg-devel] [PATCH v3 1/4] avutil/mips: Use MMI_{L, S}QC1 macro in {SAVE, RECOVER}_REG

2021-07-22 Thread Jiaxun Yang
{SAVE,RECOVER}_REG will be available for Loongson2 again, also comment about the magic. Signed-off-by: Jiaxun Yang Reviewed-by: Shiyou Yin --- libavutil/mips/mmiutils.h | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git

[FFmpeg-devel] [PATCH v3 0/4] avcodec Loongson-2 MMI fixes

2021-07-22 Thread Jiaxun Yang
Get MMI optimizations build for Loongson-2 again. Tested on Loongson-2 and Loongson-3A. --- v2: Rebase and add patch 5 v3: Drop load pair patch and collect review tags --- Jiaxun Yang (4): avutil/mips: Use MMI_{L, S}QC1 macro in {SAVE, RECOVER}_REG avcodec/mips: Use MMI marcos to replace

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/mips: Extract load store with shift C1 pair marco

2021-07-22 Thread Jiaxun Yang
在 2021/7/23 上午11:59, yinshiyou...@loongson.cn 写道: -原始邮件- 发件人: "Jiaxun Yang" 发送时间: 2021-07-22 21:59:03 (星期四) 收件人: ffmpeg-devel@ffmpeg.org 抄送: 主题: Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/mips: Extract load store with shift C1 pair marco 在 2021/7/22 下午7:55,

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/mips: Extract load store with shift C1 pair marco

2021-07-22 Thread yinshiyou-hf
-原始邮件- 发件人: "Jiaxun Yang" 发送时间: 2021-07-22 21:59:03 (星期四) 收件人: ffmpeg-devel@ffmpeg.org 抄送: 主题: Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/mips: Extract load store with shift C1 pair marco 在 2021/7/22 下午7:55, yinshiyou...@loongson.cn 写道: -原始邮件- 发件人: "Jiaxun Yang"

Re: [FFmpeg-devel] [PATCH v1] configure: fix mmi check

2021-07-22 Thread Jiaxun Yang
在 2021/7/23 上午9:39, Jin Bo 写道: pxor is loongson media extension instruction, it's not supported yet on upstream gcc complier. Disable mmi to avoid build error if the compiler does not support it. Hi Bo, Well I have to repeat that your statement is *NOT* true. Upstream GCC *DO* support

[FFmpeg-devel] [PATCH] libsvtav1: pass color description info

2021-07-22 Thread Christopher Degawa
these fields are only available past svt-av1 0.8.7 Signed-off-by: Christopher Degawa --- libavcodec/libsvtav1.c | 20 1 file changed, 20 insertions(+) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index fabc4e6428..6c12777911 100644 ---

Re: [FFmpeg-devel] [PATCH] Revert "libavcodec/mips: Fix specification of instruction name"

2021-07-22 Thread Jiaxun Yang
在 2021/7/22 下午9:02, yinshiyou...@loongson.cn 写道: I mean the upstream compiler not support ’pxor‘ yet, not mean MMI. upstream gcc supports 'xor' for 2F and 3A is true, user can use it with old version ffmpeg? According to the latest instruction mannual, we should use 'pxor' but not 'xor' which

[FFmpeg-devel] [PATCH v1] configure: fix mmi check

2021-07-22 Thread Jin Bo
pxor is loongson media extension instruction, it's not supported yet on upstream gcc complier. Disable mmi to avoid build error if the compiler does not support it. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index bb6b096414..ec536dea40

[FFmpeg-devel] [PATCH V5] lavf/vf_ocr: add subregion support

2021-07-22 Thread Lingjiang Fang
remove TODO assignee --- doc/filters.texi | 8 libavfilter/vf_ocr.c | 45 +++- 2 files changed, 52 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index d991c06628..f41ba0ce46 100644 --- a/doc/filters.texi +++

Re: [FFmpeg-devel] [PATCH][libavcodec] Adding sprite support to duck truemotion1

2021-07-22 Thread ffmpegandmahanstreamer
Yes, i have them, obviously. >From the mahanstreamer maintainer: >https://drive.google.com/drive/folders/1L0b4h3sYc_fWFTdndtRO5vGSNmLW3pGD?usp=sharing The file you are looking for is "buttons.avi" (I am not committer so can't upload to ffmpeg sample server) July 22, 2021 4:30 PM, "Paul B

[FFmpeg-devel] [PATCH][libavcodec] Adding sprite support to duck truemotion1

2021-07-22 Thread ffmpegandmahanstreamer
Overrides previous patch i submitted regarding this as the old patch I submitted had a bug that is fixed in this one. --- libavcodec/truemotion1.c | 206 +-- 1 file changed, 174 insertions(+), 32 deletions(-) diff --git a/libavcodec/truemotion1.c

[FFmpeg-devel] [PATCH] avcodec/tableprint_vlc: Fix building with hardcoded tables

2021-07-22 Thread Andreas Rheinhardt
This has been broken in 25c8507818d8559a6654a5b30a0f8aae11a48181, because the hacks for headers that are incompatible with building for the host in libavcodec/tableprint_vlc.h have not been adjusted. Moving AV_INPUT_BUFFER_PADDING_SIZE to defs.h which is valid for both the target as well as the

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Adjust threshold for libvorbis

2021-07-22 Thread Michael Niedermayer
On Fri, Apr 23, 2021 at 11:10:03AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 33513/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVORBIS_fuzzer-6481006635909120 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Avoid undefined overflow in time_offset calculation

2021-07-22 Thread Michael Niedermayer
On Wed, Apr 21, 2021 at 02:31:17PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 8511838621821575200 - -3954125146725285889 > cannot be represented in type 'long' > Fixes: > 33414/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6610119325515776 > > Found-by:

Re: [FFmpeg-devel] [PATCH][libavcodec] Adding sprite support to duck truemotion1

2021-07-22 Thread Paul B Mahol
Samples to test this? On Thu, Jul 22, 2021 at 10:27 PM wrote: > Overrides previous patch i submitted regarding this as the old patch I > submitted had a bug that is fixed in this one. > > --- > libavcodec/truemotion1.c | 206 +-- > 1 file changed, 174

[FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: Switch to init_get_bits8 and checks return value

2021-07-22 Thread Thierry Foucu
--- libavcodec/mpeg12dec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index b27ed5bd6d..269619540a 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1341,8 +1341,11 @@ static int

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: Switch to init_get_bits8 and checks return value

2021-07-22 Thread Thierry Foucu
On Wed, Jul 21, 2021 at 6:19 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Thierry Foucu: > > --- > > libavcodec/mpeg12dec.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c > > index

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegdec: Use table instead of repeated "else if"

2021-07-22 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_shufflepixels: Check ff_get_video_buffer()

2021-07-22 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 3/8] libavutil/hwcontext_qsv: enabling d3d11va usage by default, add usage child_device_type argument

2021-07-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Artem Galin > Sent: Thursday, 22 July 2021 12:57 > To: ffmpeg-devel@ffmpeg.org; ffmpeg-de...@ffmpeg.org > Cc: Artem Galin > Subject: [FFmpeg-devel] [PATCH 3/8] libavutil/hwcontext_qsv: enabling > d3d11va usage by default, add

Re: [FFmpeg-devel] [PATCH 3/8] libavutil/hwcontext_qsv: enabling d3d11va usage by default, add usage child_device_type argument

2021-07-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Artem Galin > Sent: Thursday, 22 July 2021 12:57 > To: ffmpeg-devel@ffmpeg.org; ffmpeg-de...@ffmpeg.org > Cc: Artem Galin > Subject: [FFmpeg-devel] [PATCH 3/8] libavutil/hwcontext_qsv: enabling > d3d11va usage by default, add

[FFmpeg-devel] [PATCH 1/3] cbs_h264: add support for Film Grain Characteristics SEI messages

2021-07-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h264.h | 21 +++ libavcodec/cbs_h2645.c| 6 ++ libavcodec/cbs_h264_syntax_template.c | 83 +++ 3 files changed, 110 insertions(+) diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h

[FFmpeg-devel] [PATCH 2/3] avutil/film_grain_params: add support for H.274 Film Grain Characteristics

2021-07-22 Thread James Almer
Used by codecs like H.264, HEVC, and VVC. Signed-off-by: James Almer --- Missing version bump and APIchanges entry. libavutil/film_grain_params.h | 89 +++ 1 file changed, 89 insertions(+) diff --git a/libavutil/film_grain_params.h

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/mips: Extract load store with shift C1 pair marco

2021-07-22 Thread Jiaxun Yang
在 2021/7/22 下午7:55, yinshiyou...@loongson.cn 写道: -原始邮件- 发件人: "Jiaxun Yang" 发送时间: 2021-07-21 17:19:10 (星期三) 收件人: ffmpeg-devel@ffmpeg.org 抄送: yinshiyou...@loongson.cn, "Jiaxun Yang" 主题: [FFmpeg-devel] [PATCH v2 2/5] avutil/mips: Extract load store with shift C1 pair marco We're

Re: [FFmpeg-devel] [PATCH] Revert "libavcodec/mips: Fix specification of instruction name"

2021-07-22 Thread Jiaxun Yang
在 2021/7/22 下午9:02, yinshiyou...@loongson.cn 写道: No that's not true, Loongson-MMI had upstream toolchain support for Loongson-3A since 2019, which is binutils-2.32 and GCC-9. And these instruction naming (and or xor) is available since 2008 for Loongson-2F. I mean the upstream compiler

[FFmpeg-devel] [PATCH 3/3] avcodec/h264_sei: parse and export Film Grain Characteristics SEI messages

2021-07-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h264_sei.c | 47 +++ libavcodec/h264_sei.h | 22 + libavcodec/h264_slice.c | 54 + 3 files changed, 123 insertions(+) diff --git a/libavcodec/h264_sei.c

Re: [FFmpeg-devel] [PATCH v1 2/2] avfilter/vf_subtitles: Added shift option for subtitles/ass filters.

2021-07-22 Thread Gyan Doshi
On 2021-07-22 00:08, Manolis Stamatogiannakis wrote: Would it be possible to have a quick review for this patch? It is pretty straightforward. Will test within a few days. Regards, Gyan Plus, this is its second submission. It already includes the requested changes from the first time

Re: [FFmpeg-devel] [PATCH] Revert "libavcodec/mips: Fix specification of instruction name"

2021-07-22 Thread yinshiyou-hf
-原始邮件- 发件人: "Jiaxun Yang" 发送时间: 2021-07-22 17:14:17 (星期四) 收件人: yinshiyou...@loongson.cn, "FFmpeg development discussions and patches" 抄送: "Jin Bo" , xuchueng...@loongson.cn 主题: Re: [FFmpeg-devel] [PATCH] Revert "libavcodec/mips: Fix specification of instruction name" 在

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/mips: Extract load store with shift C1 pair marco

2021-07-22 Thread yinshiyou-hf
-原始邮件- 发件人: "Jiaxun Yang" 发送时间: 2021-07-21 17:19:10 (星期三) 收件人: ffmpeg-devel@ffmpeg.org 抄送: yinshiyou...@loongson.cn, "Jiaxun Yang" 主题: [FFmpeg-devel] [PATCH v2 2/5] avutil/mips: Extract load store with shift C1 pair marco We're doing some fancy hacks with load store with shift

[FFmpeg-devel] [PATCH 3/8] libavutil/hwcontext_qsv: enabling d3d11va usage by default, add usage child_device_type argument

2021-07-22 Thread Artem Galin
From: Artem Galin Rebase of last patch set over current master. Makes selection of d3d11va/DX11 device type by default and over dxva/DX9, helps to cover more HW configurations without explicit parameters need. Fixes TGL / AV1 decode as requires DX11 with default parameters Add headless/multi

[FFmpeg-devel] [PATCH 6/8] libavfilter/vf_scale_qsv: enabling d3d11va support, added mfxhdlpair

2021-07-22 Thread Artem Galin
From: Artem Galin Adding DX11 relevant device type checks and adjusting callback with proper MediaSDK pair type support. Signed-off-by: Artem Galin --- libavfilter/vf_scale_qsv.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git

[FFmpeg-devel] [PATCH 5/8] libavfilter/qsvvpp: enabling d3d11va support, added mfxhdlpair

2021-07-22 Thread Artem Galin
From: Artem Galin Adding DX11 relevant device type checks and adjusting callback with proper MediaSDK pair type support. Signed-off-by: Artem Galin --- libavfilter/qsvvpp.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git

[FFmpeg-devel] [PATCH 7/8] libavfilter/vf_scale_qsv: add MFX_MEMTYPE_FROM_VPPOUT flag to frame_type

2021-07-22 Thread Artem Galin
From: Artem Galin In case of DX11 device type, Media SDK is sensitive to these flags. Signed-off-by: Artem Galin --- libavfilter/vf_scale_qsv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c index

[FFmpeg-devel] [PATCH 1/8] libavcodec/qsv: enabling d3d11va support, added mfxhdlpair

2021-07-22 Thread Artem Galin
From: Artem Galin Adding DX11 relevant device type checks and adjusting callbacks with proper MediaSDK pair type support. Extending structure for proper MediaSDK pair type support. Signed-off-by: Artem Galin --- libavcodec/qsv.c | 53 ++-

[FFmpeg-devel] [PATCH 8/8] libavfilter/vf_deinterlace_qsv: enabling d3d11va support, added mfxhdlpair

2021-07-22 Thread Artem Galin
From: Artem Galin Adding DX11 relevant device type checks and adjusting callback with proper MediaSDK pair type support. Signed-off-by: Artem Galin --- libavfilter/vf_deinterlace_qsv.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git

[FFmpeg-devel] [PATCH 4/8] libavutil/hwcontext_d3d11va: adding more texture information to the D3D11 hwcontext API

2021-07-22 Thread Artem Galin
From: Artem Galin Microsoft VideoProcessor requires texture with D3DUSAGE_RENDERTARGET flag as output. There is no way to allocate array of textures with D3D11_BIND_RENDER_TARGET flag and .ArraySize > 2 by ID3D11Device_CreateTexture2D due to the Microsoft limitation. Adding

[FFmpeg-devel] [PATCH 2/8] libavutil/hwcontext_qsv: supporting d3d11va device type

2021-07-22 Thread Artem Galin
From: Artem Galin This enables usage of non-powered/headless GPU, better HDR support. Pool of resources is allocated as one texture with array of slices. Signed-off-by: Artem Galin --- libavutil/hwcontext_qsv.c | 323 +++--- 1 file changed, 262 insertions(+),

Re: [FFmpeg-devel] [PATCH] Revert "libavcodec/mips: Fix specification of instruction name"

2021-07-22 Thread Jiaxun Yang
在 2021/7/22 下午4:00, yinshiyou...@loongson.cn 写道: -原始邮件- 发件人: "Jiaxun Yang" 发送时间: 2021-07-21 17:39:22 (星期三) 收件人: ffmpeg-devel@ffmpeg.org 抄送: yinshiyou...@loongson.cn, "Jin Bo" , "Jiaxun Yang" 主题: [FFmpeg-devel] [PATCH] Revert "libavcodec/mips: Fix specification of instruction

[FFmpeg-devel] [PATCH] avfilter/vf_shufflepixels: Check ff_get_video_buffer()

2021-07-22 Thread Andreas Rheinhardt
There would be a segfault in case of (likely memory allocation) failure. Fixes Coverity issue #1322338. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_shufflepixels.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/vf_shufflepixels.c b/libavfilter/vf_shufflepixels.c

Re: [FFmpeg-devel] [PATCH] Revert "libavcodec/mips: Fix specification of instruction name"

2021-07-22 Thread yinshiyou-hf
-原始邮件- 发件人: "Jiaxun Yang" 发送时间: 2021-07-21 17:39:22 (星期三) 收件人: ffmpeg-devel@ffmpeg.org 抄送: yinshiyou...@loongson.cn, "Jin Bo" , "Jiaxun Yang" 主题: [FFmpeg-devel] [PATCH] Revert "libavcodec/mips: Fix specification of instruction name" This reverts commit

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-07-22 Thread Steven Liu
> 2021年7月17日 上午1:18,Nachiket Tarate 写道: > > These will be used by HLS demuxer in case of sample decryption. > > Signed-off-by: Nachiket Tarate > --- > libavcodec/adts_header.c | 1 + > libavcodec/adts_header.h | 14 ++ > libavcodec/adts_parser.c | 28 >

[FFmpeg-devel] [PATCH] tools/graph2dot: Don't use sizeof(AVFilterGraph), check allocation

2021-07-22 Thread Andreas Rheinhardt
Use avfilter_graph_alloc() instead of av_mallocz(sizeof(AVFilterGraph)) to allocate an AVFilterGraph; this also properly allocates the graph's internal. The current code just happened to work because it did not make any use of said internal. Also check the allocation; this fixes Coverity