Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-05-11 Thread Tobias Rapp
On 11/05/2022 01:32, Soft Works wrote: [...] The prefixing can be implemented as a function and then be used in file_open.c. Other file system related functions like mkdir, rename, rmdir, etc. are already intercepted in os_support.h, and the prefixing can be applied there. Maybe I missed some

Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-05-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Tobias Rapp > Sent: Wednesday, May 11, 2022 9:46 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] > libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and > utf8toansi > > On 11/05/2022 01:32,

Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-05-11 Thread Hendrik Leppkes
On Wed, May 11, 2022 at 9:58 AM Soft Works wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Tobias Rapp > > Sent: Wednesday, May 11, 2022 9:46 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] > > libavutil/wchar_filename.h: Add

[FFmpeg-devel] [PATCH 3/9] fftools/ffmpeg: reindent after previous commit

2022-05-11 Thread Anton Khirnov
--- fftools/ffmpeg.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 9fa0719cf6..69b9c42822 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -840,15 +840,15 @@ static int encode_frame(OutputFile *of, OutputStream

[FFmpeg-devel] [PATCH 2/9] fftools/ffmpeg: reuse the encoding code for flushing encoders

2022-05-11 Thread Anton Khirnov
--- fftools/ffmpeg.c | 75 +++- 1 file changed, 16 insertions(+), 59 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0e62c39522..9fa0719cf6 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -836,12 +836,12 @@ static int encode_

[FFmpeg-devel] [PATCH 4/9] fftools/ffmpeg: drop a useless check and reduce indentation

2022-05-11 Thread Anton Khirnov
do_video_stats() is only ever called for video. --- fftools/ffmpeg.c | 48 +++- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 69b9c42822..2bc612f448 100644 --- a/fftools/ffmpeg.c +++ b/fftools/f

[FFmpeg-devel] [PATCH 1/9] fftools/ffmpeg: share the code encoding a single frame between video and audio

2022-05-11 Thread Anton Khirnov
Call do_video_stats() for every video packets produced by the encoder, rather than for every frame sent to the encoder. --- fftools/ffmpeg.c | 145 --- 1 file changed, 60 insertions(+), 85 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c in

[FFmpeg-devel] [PATCH 7/9] fftools/ffmpeg: stop using av_stream_get_end_pts() in do_video_stats()

2022-05-11 Thread Anton Khirnov
It retrieves libavformat's internal dts value (contrary to the function's name), which is not only incorrect in general, but also unnecessary because we can access the packet directly. --- fftools/ffmpeg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpe

[FFmpeg-devel] [PATCH 5/9] fftools/ffmpeg: move do_video_stats() to avoid a forward declaration

2022-05-11 Thread Anton Khirnov
--- fftools/ffmpeg.c | 93 1 file changed, 46 insertions(+), 47 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 2bc612f448..ae3cc57bef 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -127,7 +127,6 @@ typedef struct Bench

[FFmpeg-devel] [PATCH 8/9] fftools/ffmpeg: merge variable declaration and initialization

2022-05-11 Thread Anton Khirnov
--- fftools/ffmpeg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 5983c57410..fe7c37db62 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -837,7 +837,7 @@ static double psnr(double d) static void do_video_stats(OutputStre

[FFmpeg-devel] [PATCH 6/9] fftools/ffmpeg: stop using AVStream.nb_frames in do_video_stats()

2022-05-11 Thread Anton Khirnov
Its use for muxing is not documented, in practice it is incremented per each packet successfully passed to the muxer's write_packet(). Since there is a lot of indirection between ffmpeg receiving a packet from the encoder and it actually being written (e.g. bitstream filters, the interleaving queue

[FFmpeg-devel] [PATCH 9/9] fftools/ffmpeg: move processing AV_PKT_DATA_QUALITY_STATS to do_video_stats()

2022-05-11 Thread Anton Khirnov
This is a more appropriate place for this code, since the values we read from AV_PKT_DATA_QUALITY_STATS side data are primarily written into video stats. This ensures that the values written into stats actually apply to the right packet. Rename the function to update_video_stats() to better reflec

Re: [FFmpeg-devel] [PATCH 1/9] fftools/ffmpeg: share the code encoding a single frame between video and audio

2022-05-11 Thread Anton Khirnov
In case anyone cares about the context - these patches were previously a part of the muxer-threading set, but I've decided to factor them out and reshuffle them. do_video_stats() is now kept close to the encoder rather than being moved to the muxing code. -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-05-11 Thread nil-admirari
> I think that can be changed easily. How about writing the necessary patches yourself? > A path using forward slashes can still be prefixed with '\\?\' It cannot. Only backslashes are valid in \\?\ paths. > The prefixing can be implemented as a function and then be used > in file_open.c. > Ot

Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-05-11 Thread nil-admirari
> I'm not sure how much you had followed, so please excuse in case you > had already read it: the manifest approach does not work on a default > Windows installation. > To activate long path support, the users needs to opt-in to a behavior > that is probably deactivated by default for some reason.

Re: [FFmpeg-devel] [PATCH v2 1/7] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122

2022-05-11 Thread Anton Khirnov
Quoting Zane van Iperen (2022-04-24 12:14:03) > +void av_uuid_nil_set(AVUUID uu) ^^^ sounds weird av_uuid_zero()? av_uuid_reset()? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/lis

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-10 13:40:54) > So far, -metadata:s:v rotate would only be applied to streamcopied > video streams. Using -metadata for this functionality is a hack that should be removed, not extended. -- Anton Khirnov ___ ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add an AVCodecContext flag to export A53/SCTE20/DVD CC side data on demand

2022-05-11 Thread Anton Khirnov
Quoting lance.lmw...@gmail.com (2022-05-08 09:17:01) > From: Limin Wang > > some samples include both A53 and SCTE20 data. Before the commit, both > of the will be exported, so the CC data will be repeated or garbarge Why would it be garbage? That sounds like a bug. Why can't we just export both

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Gyan Doshi
On 2022-05-11 05:26 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-10 13:40:54) So far, -metadata:s:v rotate would only be applied to streamcopied video streams. Using -metadata for this functionality is a hack that should be removed, not extended. When there's a replacement for CLI

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add an AVCodecContext flag to export A53/SCTE20/DVD CC side data on demand

2022-05-11 Thread lance . lmwang
On Wed, May 11, 2022 at 02:00:10PM +0200, Anton Khirnov wrote: > Quoting lance.lmw...@gmail.com (2022-05-08 09:17:01) > > From: Limin Wang > > > > some samples include both A53 and SCTE20 data. Before the commit, both > > of the will be exported, so the CC data will be repeated or garbarge > > W

Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-05-11 Thread Tobias Rapp
On 11/05/2022 09:57, Soft Works wrote: [...] I'm not sure how much you had followed, so please excuse in case you had already read it: the manifest approach does not work on a default Windows installation. To activate long path support, the users needs to opt-in to a behavior that is probably d

[FFmpeg-devel] [PATCH 1/4] remove sccenc dependency on subtitles

2022-05-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 3b9995a9d3..8e612b6cc7 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -514,7 +514,7 @@ OBJS-

[FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length

2022-05-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ccaption_dec.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 34f0513b1a..8f61e8aa03 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_

[FFmpeg-devel] [PATCH 3/4] avformat/sccenc: avoid potential invalid access

2022-05-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/sccenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/sccenc.c b/libavformat/sccenc.c index c8c4d097e4..2b924ba6e7 100644 --- a/libavformat/sccenc.c +++ b/libavformat/sccenc.c @@ -72,11 +72,11 @@ s

[FFmpeg-devel] [PATCH 4/4] avcodec/dvdsubenc: return error if canvas_size is too small for subtitle render

2022-05-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/dvdsubenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/dvdsubenc.c b/libavcodec/dvdsubenc.c index fc3b7d1816..d29db7d49c 100644 --- a/libavcodec/dvdsubenc.c +++ b/libavcodec/dvdsubenc.c @@ -376,6 +376,12 @@ stat

Re: [FFmpeg-devel] [PATCH v2 1/7] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122

2022-05-11 Thread Zane van Iperen
On 10/5/22 23:18, Andreas Rheinhardt wrote: +int av_uuid_parse_range(const char *in_start, const char *in_end, AVUUID uu) +{ +int i; +const char *cp; +char buf[3]; + +if ((in_end - in_start) != 36) +return -1; + +for (i = 0, cp = in_start; i < 36; i++, cp++) { +

Re: [FFmpeg-devel] [PATCH v2 1/7] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122

2022-05-11 Thread Zane van Iperen
On 11/5/22 21:53, Anton Khirnov wrote: Quoting Zane van Iperen (2022-04-24 12:14:03) +void av_uuid_nil_set(AVUUID uu) ^^^ sounds weird av_uuid_zero()? av_uuid_reset()? Good point, `av_uuid_zero()` has a nice ring to it. ___

[FFmpeg-devel] [PATCH 1/2] avcodec/wrapped_avframe: Don't attach FrameDecodeData unnecessarily

2022-05-11 Thread Andreas Rheinhardt
It is unneeded, as this decoder does not call ff_get_buffer(). Signed-off-by: Andreas Rheinhardt --- libavcodec/wrapped_avframe.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavcodec/wrapped_avframe.c b/libavcodec/wrapped_avframe.c index 3af007d478..06c274eed0 100644 --- a/libavco

[FFmpeg-devel] [PATCH 2/2] avcodec/decode: Don't allocate FrameDecodeData if it is unneeded

2022-05-11 Thread Andreas Rheinhardt
Currently, every call to ff_get_buffer() allocates FrameDecodeData, although only very few decoders (those that might use nvdec or videotoolbox hardware acceleration) actually need it. This commit addresses this by adding an internal codec cap to ensure that FrameDecodeData is only allocated for c

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Gyan Doshi
On 2022-05-10 05:10 pm, Gyan Doshi wrote: So far, -metadata:s:v rotate would only be applied to streamcopied video streams. Plan to push tomorrow. Gyan --- fftools/ffmpeg.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index a85ed18b08..

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-11 Thread Vignesh Venkatasubramanian
On Wed, May 4, 2022 at 10:15 AM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specification: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif > > S

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-11 Thread Gyan Doshi
On 2022-05-11 10:24 pm, Vignesh Venkatasubramanian wrote: On Wed, May 4, 2022 at 10:15 AM Vignesh Venkatasubramanian wrote: Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specification: https://aomediacodec.github.io/av1-avif Sample usage for still image: ffmpeg -i imag

Re: [FFmpeg-devel] [PATCH] avcodec/internal: Hide stuff only used by the core decode API

2022-05-11 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The general decoding API uses bitstream filters and an AVFifo > and therefore AVCodecInternal contains pointers to an AVBSFContext > and to an AVFifo and lavc/internal.h includes lavc/bsf.h and > lavu/fifo.h. > Yet actually, only two files are supposed to use these, namely > a

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-11 18:30:41) > > > On 2022-05-10 05:10 pm, Gyan Doshi wrote: > > So far, -metadata:s:v rotate would only be applied to streamcopied > > video streams. > > Plan to push tomorrow. WTF? This is not how development works. I had an objection to your patch, it was not res

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-11 14:18:49) > > > On 2022-05-11 05:26 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-05-10 13:40:54) > >> So far, -metadata:s:v rotate would only be applied to streamcopied > >> video streams. > > Using -metadata for this functionality is a hack that should be

Re: [FFmpeg-devel] [PATCH 2/9] fftools/ffmpeg: reuse the encoding code for flushing encoders

2022-05-11 Thread Michael Niedermayer
On Wed, May 11, 2022 at 10:16:47AM +0200, Anton Khirnov wrote: > --- > fftools/ffmpeg.c | 75 +++- > 1 file changed, 16 insertions(+), 59 deletions(-) breaks 2pass with ffv1 ./ffmpeg -y -i mm-short.mpg -an -vcodec ffv1 -strict -2 -slices 4 -t 1 -coder

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Gyan Doshi
On 2022-05-12 12:19 am, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-11 14:18:49) On 2022-05-11 05:26 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-10 13:40:54) So far, -metadata:s:v rotate would only be applied to streamcopied video streams. Using -metadata for this functional

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length

2022-05-11 Thread Paul B Mahol
why? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] configure: extend check to less than 3.0.0

2022-05-11 Thread Christopher Degawa
sdl2 recently changed their versioning, moving the patch level to minor level https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff and have said that they will instead ship sdl3.pc for 3.0.0 trac: https://trac.ffmpeg.org/ticket/9768 Signed-off-by: Christopher Degawa

Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-05-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Tobias Rapp > Sent: Wednesday, May 11, 2022 3:33 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] > libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and > utf8toansi > > On 11/05/2022 09:57,

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length

2022-05-11 Thread lance . lmwang
On Wed, May 11, 2022 at 09:47:52PM +0200, Paul B Mahol wrote: > why? assuming the len is 1, the following code will access the next 3 array anymore, I think it's better to check the i with len -2. for (i = 0; i < len; i += 3) { to for (i = 0; i < len - 2; i += 3) { for the return, I think it's

[FFmpeg-devel] [PATCH v1] avfilter/vf_vpp_qsv: set outlink to EOF correctly

2022-05-11 Thread Fei Wang
1. Return error if filter frame fail before set outlink to EOF in none pass through mode. 2. Set outlink to EOF before return success in pass through mode. Fix endless cmd: ffmpeg -hwaccel qsv -qsv_device /dev/dri/renderD128 -hwaccel_output_format \ qsv -v debug -c:v hevc_qsv -i 4k.h265

Re: [FFmpeg-devel] [PATCH] configure: extend check to less than 3.0.0

2022-05-11 Thread Gyan Doshi
On 2022-05-12 01:41 am, Christopher Degawa wrote: sdl2 recently changed their versioning, moving the patch level to minor level https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff and have said that they will instead ship sdl3.pc for 3.0.0 Will apply. Regards,

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-11 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-11 21:15:15) > > > On 2022-05-12 12:19 am, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-05-11 14:18:49) > >> > >> On 2022-05-11 05:26 pm, Anton Khirnov wrote: > >>> Quoting Gyan Doshi (2022-05-10 13:40:54) > So far, -metadata:s:v rotate would only be applied

[FFmpeg-devel] [PATCH 1/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-05-11 Thread Dawid Kozinski
Prerequisites that must be met before adding new codec - Added new entry to codec IDs list - Added new entry to the codec descriptor list - Bumped libavcodec minor version - Changes in Changelog and MAINTAINERS files Signed-off-by: Dawid Kozinski --- Changelog | 3 ++- MAINTAINERS

[FFmpeg-devel] [PATCH 2/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-05-11 Thread Dawid Kozinski
- Added xeve encoder wrapper - Added xevd dencoder wrapper - Added documentation for xeve and xevd wrappers - Added parser for EVC format - Changes in project configuration file and libavcodec Makefile Signed-off-by: Dawid Kozinski --- configure |8 + doc/decoders.texi

[FFmpeg-devel] [PATCH 3/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-05-11 Thread Dawid Kozinski
- Added muxer for EVC format (MP4, raw) - Added demuxer for EVC format (MP4) - Added evc extension to the list of extensions for ff_mov_demuxer Signed-off-by: Dawid Kozinski --- doc/muxers.texi | 6 ++ libavformat/Makefile | 2 + libavformat/allformats.c | 2 + libavformat/evc

Re: [FFmpeg-devel] [PATCH] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-05-11 Thread PLT
Thank you for your review. All your suggestions have been taken into account and new patches have just been put on the mailing list. -Original Message- From: ffmpeg-devel On Behalf Of Andreas Rheinhardt Sent: Tuesday, April 5, 2022 7:37 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpe

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length

2022-05-11 Thread Paul B Mahol
On Thu, May 12, 2022 at 1:39 AM wrote: > On Wed, May 11, 2022 at 09:47:52PM +0200, Paul B Mahol wrote: > > why? > > assuming the len is 1, the following code will access the next 3 > array anymore, I think it's better to check the i with len -2. > > for (i = 0; i < len; i += 3) { > to > for (i =

Re: [FFmpeg-devel] [PATCH] configure: extend check to less than 3.0.0

2022-05-11 Thread Gyan Doshi
On 2022-05-12 10:35 am, Gyan Doshi wrote: On 2022-05-12 01:41 am, Christopher Degawa wrote: sdl2 recently changed their versioning, moving the patch level to minor level https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff and have said that they will instead