Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-11 Thread Michael Niedermayer
Hi Vittorio On Fri, Jul 11, 2025 at 10:41:04AM +0200, Vittorio Palmisano wrote: > > > + > > > +memcpy(wctx->audio_buffer, wctx->audio_buffer + end_pos, > > > + end_pos * sizeof(float)); > > > > sizeof(*wctx->audio_buffer) is more robust than float > > But end_pos is not necessarily

Re: [FFmpeg-devel] [PATCH v2 2/4] avformat/tls_openssl: fix dtls_handshake return code

2025-07-11 Thread Jack Lau
> On Jul 11, 2025, at 23:05, Steven Liu > wrote: > > Jack Lau > 于2025年7月11日周五 21:22写道: >> >> If the handshake is still in progress, dtls_handshake should >> return a positive status code. >> >> Signed-off-by: Jack Lau >> --- >> libavformat/tls_

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils: Add av_freep() to avoid memory leak

2025-07-11 Thread Michael Niedermayer
On Thu, Jul 10, 2025 at 07:41:49PM +, Jiasheng Jiang wrote: > Add av_freep() to free new_elem to avoid memory leak. > > Fixes: 2d0bfbd0fa ("fftools/cmdutils: Use av_dynarray_add_nofree()") > Signed-off-by: Jiasheng Jiang > --- > fftools/cmdutils.c | 8 ++-- > 1 file changed, 6 insertions

Re: [FFmpeg-devel] [PATCH v2] ffprobe: add -codec: option

2025-07-11 Thread Michael Niedermayer
Hi Maryla On Thu, Jul 10, 2025 at 06:29:06PM +0200, Maryla Ustarroz via ffmpeg-devel wrote: [...] > Friendly ping. > This is a v2 of the patch that includes the shorter -c flag in > addition to -codec as suggested in the v1 review. > It also updates ffprobe.texi which was missing from v1. > > Th

Re: [FFmpeg-devel] [PATCH v5] gcc: Don't disable '-ftree-vectorize' if gcc version higher than 13.

2025-07-11 Thread Michael Niedermayer
Hi Martin On Thu, Jul 10, 2025 at 02:35:10PM +0300, Martin Storsjö wrote: > On Thu, 10 Jul 2025, Jiawei wrote: > > > Hi Martin, > > > > Is there any progress for this patch, should I resend it to the mailing > > list again? > > When I posted the updated version of the patch, the patchwork test

[FFmpeg-devel] [PATCH 4/4] avformat/takdec: Don't truncate return value

2025-07-11 Thread Andreas Rheinhardt
From: Andreas Rheinhardt This is unlikely to matter for real files. Signed-off-by: Andreas Rheinhardt --- libavformat/takdec.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavformat/takdec.c b/libavformat/takdec.c index b8f76aaa67..c1271601b5 100644 --- a/liba

[FFmpeg-devel] [PATCH 3/4] avformat/tta: Avoid seek when reading header

2025-07-11 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Signed-off-by: Andreas Rheinhardt --- libavformat/tta.c | 41 +++-- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/libavformat/tta.c b/libavformat/tta.c index fdc18216c8..6e3c3a0007 100644 --- a/libavformat/tta.c +++

[FFmpeg-devel] [PATCH 2/4] avformat/oggdec: Don't skip over data whose checksum is used

2025-07-11 Thread Andreas Rheinhardt
From: Andreas Rheinhardt The behavior of the ffio_*_checksum feature is not well defined when using avio_skip(). The code in oggdec.c relied on the skipped data (four bytes) to be checksummed, which is mostly true because short_seek_threshold is 32768 by default, so that avio_seek() will normally

[FFmpeg-devel] [PATCH 1/4] avformat/aviobuf: Keep checksum_ptr consistent in avio_seek()

2025-07-11 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Otherwise it might be > buf_ptr in which case ffio_get_checksum() could segfault (s->buf_ptr - s->checksum_ptr would be negative which would be converted to something very big when converted to unsigned for the update_checksum callback). Fixes ticket #11233. Reported-by

[FFmpeg-devel] [PATCH 0/4] Crc crash

2025-07-11 Thread ffmpegagent
The main aim of this patchset is to fix ticket 11233. Andreas Rheinhardt (4): avformat/aviobuf: Keep checksum_ptr consistent in avio_seek() avformat/oggdec: Don't skip over data whose checksum is used avformat/tta: Avoid seek when reading header avformat/takdec: Don't truncate return value

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-11 Thread Michael Niedermayer
On Fri, Jul 11, 2025 at 10:29:30AM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-07-11): > > ok, chanegd it to AVERROR_INVALIDDATA > > Thanks. > > > Yes > > but this also affects releases, and adding a field to AVFormatContext > > is an issue for releases as it changes ABI > > > >

[FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

2025-07-11 Thread Kacper Michajłow
Fixes: signed integer overflow: 9223372036854737920 + 1649410 cannot be represented in type 'int64_t' Fixes OSS-Fuzz: 410100610 Signed-off-by: Kacper Michajłow --- libavformat/subfile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/subfile.c b/libavformat

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-11 Thread Marvin Scholz
On 11 Jul 2025, at 11:07, Vittorio Palmisano wrote: > It adds a new audio filter for running audio transcriptions with the whisper > model. > Documentation and examples are included into the patch. > > Signed-off-by: Vittorio Palmisano > --- > configure| 5 + > doc/filters.t

[FFmpeg-devel] [PATCH v2] avformat: remove HLS protocol

2025-07-11 Thread Marvin Scholz
The use of this protocol was already discouraged and warned about for years with the recommendation to use the HLS demuxer instead. --- Changelog | 1 + doc/protocols.texi | 20 --- libavformat/Makefile| 2 - libavformat/hlsproto.c | 318 ---

[FFmpeg-devel] [PATCH 5/5] avcodec/encode: Remove redundant av_image_check_size2()

2025-07-11 Thread Andreas Rheinhardt
From: Andreas Rheinhardt The dimensions have already been checked during init. Signed-off-by: Andreas Rheinhardt --- libavcodec/encode.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 2f789c5b7a..c12cb1aa09 100644 --- a/libavcodec/encode.

[FFmpeg-devel] [PATCH 4/5] avcodec/encode: Remove dead code

2025-07-11 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Can be readded if needed (likely never). Signed-off-by: Andreas Rheinhardt --- libavcodec/encode.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 0308c73630..2f789c5b7a 100644

[FFmpeg-devel] [PATCH 3/5] avcodec/encode: Ignore coded_{width, height}

2025-07-11 Thread Andreas Rheinhardt
From: Andreas Rheinhardt It is supposed to be unused by encoders. Signed-off-by: Andreas Rheinhardt --- libavcodec/encode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index b9782a0581..0308c73630 100644 --- a/libavcodec/enc

[FFmpeg-devel] [PATCH 2/5] avcodec/encode: Simplify pixel format validity check

2025-07-11 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Signed-off-by: Andreas Rheinhardt --- libavcodec/encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 38833c566c..b9782a0581 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -551,7 +551

[FFmpeg-devel] [PATCH 1/5] avcodec/av1dec, libdav1d, wbmpdec: Avoid direct access to GetByteContext

2025-07-11 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Signed-off-by: Andreas Rheinhardt --- libavcodec/av1dec.c | 2 +- libavcodec/libdav1d.c | 2 +- libavcodec/wbmpdec.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 8ff1bf394c..dcbe4ef2ce 100644

[FFmpeg-devel] [PATCH 0/5] Encode checks

2025-07-11 Thread ffmpegagent
Mostly removal of dead encode checks. Andreas Rheinhardt (5): avcodec/av1dec,libdav1d,wbmpdec: Avoid direct access to GetByteContext avcodec/encode: Simplify pixel format validity check avcodec/encode: Ignore coded_{width,height} avcodec/encode: Remove dead code avcodec/encode: Remove re

[FFmpeg-devel] [PATCH] amfenc: Fix for full PA queue

2025-07-11 Thread Araz Iusubov
Fixes AMF_INPUT_FULL errors with pre-analysis (PA) enabled. Added wait and poll encoder output to free up internal buffers before submitting new frames. Improves stability and performance by accounting for encoder and analysis stage queue limits (incl. lookahead buffering). Reproduce: ffmpeg.ex

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself

2025-07-11 Thread Kacper Michajłow
Signed-off-by: Kacper Michajłow --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 07cea8afeb..650300dadc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -547,6 +547,7 @@ James Darnley Jan Ekström Joakim Plate Jun Zhao +Kacper Michajłow Kieran Ku

Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations

2025-07-11 Thread Marvin Scholz
On 25 Jun 2025, at 23:39, Tristan Matthews via ffmpeg-devel wrote: > On Monday, June 16th, 2025 at 2:22 PM, Andreas Rheinhardt > wrote: > > Tristan Matthews via ffmpeg-devel: > > On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt > andreas.rheinha...@outlook.com wrote: > > Patch attac

Re: [FFmpeg-devel] [PATCH v2 3/4] avformat/tls_openssl: remove all redundant "TLS: " in log with AVClass

2025-07-11 Thread Steven Liu
Jack Lau 于2025年7月11日周五 21:22写道: > > Signed-off-by: Jack Lau > --- > libavformat/tls_openssl.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index ffd9cd51d2..a519c8c880 100644 > --- a/libavf

Re: [FFmpeg-devel] [PATCH v2 2/4] avformat/tls_openssl: fix dtls_handshake return code

2025-07-11 Thread Steven Liu
Jack Lau 于2025年7月11日周五 21:22写道: > > If the handshake is still in progress, dtls_handshake should > return a positive status code. > > Signed-off-by: Jack Lau > --- > libavformat/tls_openssl.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavformat/tls_openssl.

[FFmpeg-devel] [PATCH 2/2] doc: mark functions related to AVCodecParameters

2025-07-11 Thread Marvin Scholz
This makes these functions appear in the AVCodecParameters documentation page, so they are easier to find. --- libavcodec/avcodec.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index a004cccd2d..a1d82cb9a9 100644 --- a/libavcodec/avcodec.h +++

[FFmpeg-devel] [PATCH 1/2] doc: style changes for the AVCodecParameters

2025-07-11 Thread Marvin Scholz
Mostly adding references and making the video/audio only annotations not be the brief description. --- libavcodec/codec_par.h | 123 - 1 file changed, 84 insertions(+), 39 deletions(-) diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h index f4b9b

Re: [FFmpeg-devel] [PATCH v2 1/4] avformat/tls_openssl: add record trace function

2025-07-11 Thread Steven Liu
Jack Lau 于2025年7月11日周五 21:21写道: > > Signed-off-by: Jack Lau > --- > libavformat/tls_openssl.c | 51 +-- > 1 file changed, 49 insertions(+), 2 deletions(-) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index 2a01fb387d..8639ac9758 100

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rtsp: add TLS options

2025-07-11 Thread Marvin Scholz
On 7 Jul 2025, at 13:15, Andreas Rheinhardt wrote: > Marvin Scholz: >> From: Daniel N Pettersson >> >> Add TLS options to RTSP for when TLS is used for the lower protocol. >> >> Signed-off-by: Marvin Scholz >> Co-authored-by: Marvin Scholz >> --- >> libavformat/rtsp.c | 26 +

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtsp: fix misleading indentation

2025-07-11 Thread Marvin Scholz
On 10 Jul 2025, at 12:51, Marvin Scholz wrote: > On 8 Jul 2025, at 17:09, Marvin Scholz wrote: > >> --- >> libavformat/rtsp.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c >> index 8d360b375f..6201f09136 100644 >> --- a/

Re: [FFmpeg-devel] [PATCH 1/7] vf_libplacebo: add support for specifying a LUT for the input

2025-07-11 Thread Lynne
On 11/07/2025 19:39, Niklas Haas wrote: On Fri, 11 Jul 2025 00:13:29 +0900 Lynne wrote: This makes it possible to apply Adobe .cube files to inputs. --- libavfilter/vf_libplacebo.c | 28 1 file changed, 28 insertions(+) diff --git a/libavfilter/vf_libplacebo.c b

[FFmpeg-devel] [PATCH v2 3/4] avformat/tls_openssl: remove all redundant "TLS: " in log with AVClass

2025-07-11 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index ffd9cd51d2..a519c8c880 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.

[FFmpeg-devel] [PATCH v2 4/4] avformat/udp: fix udp server mode haven't dest_addr

2025-07-11 Thread Jack Lau
If udp is in server mode(init local addr and port through url), then it maybe haven't dest_addr, so we should set it after udp_read get the client addr and port This feature only enable when the new udp option autodetect_dest is specified Signed-off-by: Jack Lau --- libavformat/udp.c | 4

[FFmpeg-devel] [PATCH v2 2/4] avformat/tls_openssl: fix dtls_handshake return code

2025-07-11 Thread Jack Lau
If the handshake is still in progress, dtls_handshake should return a positive status code. Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 8639ac9758..ffd

[FFmpeg-devel] [PATCH v2 1/4] avformat/tls_openssl: add record trace function

2025-07-11 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 51 +-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a01fb387d..8639ac9758 100644 --- a/libavformat/tls_openssl.c +++ b/libavf

[FFmpeg-devel] [PATCH v2 0/4] Fix some issues in tls_openssl and udp

2025-07-11 Thread Jack Lau
v2 patchset add new udp option autodetect_dest. Original description: This patchset aims to fix some issues when i try to utilize DTLS using avio. I create a simple DTLS client and server case here https://github.com/JackLau1222/openssl-dtls-bio-example/tree/master/ffmpeg_case This patchset fix:

Re: [FFmpeg-devel] [PATCH 1/7] vf_libplacebo: add support for specifying a LUT for the input

2025-07-11 Thread Niklas Haas
On Fri, 11 Jul 2025 00:13:29 +0900 Lynne wrote: > This makes it possible to apply Adobe .cube files to inputs. > --- > libavfilter/vf_libplacebo.c | 28 > 1 file changed, 28 insertions(+) > > diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c > ind

[FFmpeg-devel] [PATCH v3 2/2] avcodec/aac_ac3_parser: do not override the profile set by the decoder

2025-07-11 Thread Nicolas Gaullier
Parsing the ADTS header is not enough to detect HE-AAC v1/v2. Regression since 64bb91fd3b5a00a8849531c7e8dd207f2a626096. Fixes #11600 Signed-off-by: Nicolas Gaullier --- libavcodec/aac_ac3_parser.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aac_ac3_parser.

[FFmpeg-devel] [PATCH v3 0/2] fix HE-AAC profile probing and simplify

2025-07-11 Thread Nicolas Gaullier
v3: complete overhaul of the commit message of the first patch Code is unchanged. Second patch is unchanged ("should be ok" by James). Nicolas Gaullier (2): avcodec/aac_ac3_parser: simplify avcodec/aac_ac3_parser: do not override the profile set by the decoder libavcodec/aac_ac3_parser.c | 1

[FFmpeg-devel] [PATCH v3 1/2] avcodec/aac_ac3_parser: simplify

2025-07-11 Thread Nicolas Gaullier
Remove unused USAC/ADTS code: ff_adts_header_parse() parse the object_type from a 2 bits field. See also 696ea1c2236842572df88d573e24a39be3f19c98. Use ff_adts_header_parse_buf() wrapper to simplify as GetBitContext is no longer needed (it was introduced for USAC). Partially reverts 64bb91fd3b5a00

[FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-11 Thread Vittorio Palmisano
It adds a new audio filter for running audio transcriptions with the whisper model. Documentation and examples are included into the patch. Signed-off-by: Vittorio Palmisano --- configure| 5 + doc/filters.texi | 105 + libavfilter/Makefile | 2 + libavfi

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-11 Thread Vittorio Palmisano
> > + > > +memcpy(wctx->audio_buffer, wctx->audio_buffer + end_pos, > > + end_pos * sizeof(float)); > > sizeof(*wctx->audio_buffer) is more robust than float But end_pos is not necessarily equal to the audio_buffer size, it could be lower. > > not sure how others think of this, but

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-11 Thread Nicolas George
Michael Niedermayer (HE12025-07-11): > ok, chanegd it to AVERROR_INVALIDDATA Thanks. > Yes > but this also affects releases, and adding a field to AVFormatContext > is an issue for releases as it changes ABI > > So the concat patch would go into old release branches and the > AVFormatContext one