Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Thanks a lot Michael. (and for spotting the avfree I missed) Le 25 août 2017 11:44 PM, "Michael Niedermayer" a écrit : On Thu, Aug 24, 2017 at 11:10:49PM +0200, pkv.stream wrote: > Thanks a lot Martin !!! all sorted out thanks to your kind help. > I had run fate

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

On Thu, Aug 24, 2017 at 11:10:49PM +0200, pkv.stream wrote: > Thanks a lot Martin !!! all sorted out thanks to your kind help. > I had run fate previously but obviously missed something; so re-run > and it's ok. > > I created two tests per your advice testing for a third channel in a > stereo

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Thanks a lot Martin !!! all sorted out thanks to your kind help. I had run fate previously but obviously missed something; so re-run and it's ok. I created two tests per your advice testing for a third channel in a stereo file and then in a 2.1 file. Instead of CRC, I've used MD5 because the

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-24 21:16 GMT+02:00 pkv.stream : > Hi > working on creating a fate test. > I am stumbling on probably a dumb issue; I want to re-use a file already > used for mapchan test: > > FATE_MAPCHAN-$(CONFIG_CHANNELMAP_FILTER) += fate-mapchan-6ch-extract-2 >

[FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Hi working on creating a fate test. I am stumbling on probably a dumb issue; I want to re-use a file already used for mapchan test: FATE_MAPCHAN-$(CONFIG_CHANNELMAP_FILTER) += fate-mapchan-6ch-extract-2 fate-mapchan-6ch-extract-2: tests/data/asynth-22050-6.wav (first two lines in ffmpeg.mak)

[FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Thanks a lot Martin. I had spotted ffmpeg.mak but your input is very helpful Le 24 août 2017 11:32 AM, "Martin Vignali" a écrit : 2017-08-24 11:03 GMT+02:00 Kv Pham : > Ah ok! > Sure, I will do that. I need first to acquaint myself more with

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-24 11:03 GMT+02:00 Kv Pham : > Ah ok! > Sure, I will do that. I need first to acquaint myself more with fate. > > > Hello, You can take a look at ./tests/fate/ffmpeg.mak (begin of the file seems to have test for map_channel) I think you need to add two test, one

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Ah ok! Sure, I will do that. I need first to acquaint myself more with fate. Le 24 août 2017 10:52 AM, "Michael Niedermayer" a écrit : On Thu, Aug 24, 2017 at 10:36:20AM +0200, Kv Pham wrote: > Yes I did a make fate. Went ok. > Is there a log to attach ? Or stdout ? i

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

On Thu, Aug 24, 2017 at 10:36:20AM +0200, Kv Pham wrote: > Yes I did a make fate. Went ok. > Is there a log to attach ? Or stdout ? i meant can you add a test that tests the new feature when one runs make fate that is if the user runs "make fate" it would execute ffmpeg with map and "trailing ?"

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Yes I did a make fate. Went ok. Is there a log to attach ? Or stdout ? Le 24 août 2017 10:34 AM, "Michael Niedermayer" a écrit : On Thu, Aug 24, 2017 at 08:17:58AM +0200, pkv.stream wrote: > Le 24/08/2017 à 2:30 AM, Michael Niedermayer a écrit : > >On Wed, Aug 23, 2017

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

On Thu, Aug 24, 2017 at 08:17:58AM +0200, pkv.stream wrote: > Le 24/08/2017 à 2:30 AM, Michael Niedermayer a écrit : > >On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: > >>Hello, > >> > >>the following patch allows one to add a trailing ? to -map_channel > >>as in -map option. > >> >

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Le 24/08/2017 à 2:30 AM, Michael Niedermayer a écrit : On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: Hello, the following patch allows one to add a trailing ? to -map_channel as in -map option. E.g: -map_channel 0.0.2? so that if the channel does not exist, the command does not

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Ah sorry about that. I forgot about the tabs. Will correct and add update to doc. Thanks Le 24 août 2017 2:32 AM, "Michael Niedermayer" a écrit : > On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: > > Hello, > > > > the following patch allows one to add a

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: > Hello, > > the following patch allows one to add a trailing ? to -map_channel > as in -map option. > > E.g: -map_channel 0.0.2? so that if the channel does not exist, the > command does not stop. > > This is similar to what one can

[FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Hello, the following patch allows one to add a trailing ? to -map_channel as in -map option. E.g: -map_channel 0.0.2? so that if the channel does not exist, the command does not stop. This is similar to what one can do with -map. Thanks for any input. From