Re: [FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-18 Thread Tomas Härdin
ons 2019-09-18 klockan 06:41 +0800 skrev Limin Wang: > On Tue, Sep 17, 2019 at 06:22:39PM +0200, Marton Balint wrote: > > > > On Mon, 16 Sep 2019, Tomas Härdin wrote: > > > > > mån 2019-09-16 klockan 09:03 +0800 skrev lance.lmw...@gmail.com: > > > > Fro

Re: [FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-16 Thread Tomas Härdin
mån 2019-09-16 klockan 09:03 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/avstring.c | 12 > libavutil/avstring.h | 13 + > 2 files changed, 17 insertions(+), 8 deletions(-) > > diff --git

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-19 Thread Tomas Härdin
tor 2019-09-19 klockan 13:58 +0900 skrev Hyun Yoo: > On Thu, Sep 19, 2019 at 7:28 AM Carl Eugen Hoyos wrote: > > Am Di., 17. Sept. 2019 um 02:37 Uhr schrieb Hyun Yoo > > : > > > I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 > > > as external lib like libilbc, libspeex(ex.

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Remove unused function

2019-07-30 Thread Tomas Härdin
tis 2019-07-30 klockan 09:12 +0200 skrev Andreas Rheinhardt: > klv_ber_length is unused since 9e24b98b. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mxfenc.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index

Re: [FFmpeg-devel] [PATCH 2/3] avformat: Support s337m in mxf/wav/w64

2019-07-30 Thread Tomas Härdin
fre 2019-07-26 klockan 18:45 +0200 skrev Nicolas Gaullier: > @@ -1951,6 +1951,13 @@ typedef struct AVFormatContext { > * - decoding: set by user > */ > int skip_estimate_duration_from_pts; > + > +/** > + * Probe dolby_e in PCM streams > + * - encoding: unused > + *

Re: [FFmpeg-devel] [PATCH 2/3] avformat: Support s337m in mxf/wav/w64

2019-07-30 Thread Tomas Härdin
tis 2019-07-30 klockan 15:24 +0200 skrev Carl Eugen Hoyos: > > > > Am 30.07.2019 um 14:02 schrieb Tomas Härdin : > > > > fre 2019-07-26 klockan 18:45 +0200 skrev Nicolas Gaullier: > > > > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c &g

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/hnm4video: Optimize postprocess_current_frame()

2019-08-05 Thread Tomas Härdin
lör 2019-08-03 klockan 18:57 +0200 skrev Michael Niedermayer: > On Sat, Aug 03, 2019 at 04:07:22PM +0200, Tomas Härdin wrote: > > lör 2019-08-03 klockan 01:49 +0200 skrev Michael Niedermayer: > > > -uint32_t x, y, src_x, src_y; > > > +uint32_t x, y, src_y; > &

Re: [FFmpeg-devel] [PATCH] avcodec: add msrle encoder

2019-08-05 Thread Tomas Härdin
mån 2019-08-05 klockan 10:39 +0200 skrev Paul B Mahol: > Hi, > > Patch attached. > +static av_cold int msrle_encode_init(AVCodecContext *avctx) > +{ > +MsrleEncContext *s = avctx->priv_data; > + > +if (av_image_check_size(avctx->width, avctx->height, 0, avctx) < 0) > +return

Re: [FFmpeg-devel] [PATCH v2 5/5] avformat/s337m: Test wav subdemux

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 13:09 + skrev Gaullier Nicolas: > > > +FATE_SAMPLES_AUDIO-$(call DEMDEMDEC, WAV, S337M, DOLBY_E) += > > > +fate-dolby-e-wav > > > +fate-dolby-e-wav: CMD = dolbye2pcm16 -i > > > +$(TARGET_SAMPLES)/dolby_e/512.wav > > > +fate-dolby-e-wav: CMP = oneoff > > >

Re: [FFmpeg-devel] [PATCH v3 3/6] avformat/s337m: Make available as subdemuxer

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 17:08 +0200 skrev Nicolas Gaullier: > +int avpriv_s337m_probe_stream(void *avc, AVIOContext *pb, AVStream **st, int > size) > +{ > +if ( size >= S337M_MIN_OFFSET && > +((*st)->codecpar->codec_id == AV_CODEC_ID_PCM_S16LE || > (*st)->codecpar->codec_id ==

Re: [FFmpeg-devel] [PATCH v3 4/6] avformat/wavdec: s337m support

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 17:08 +0200 skrev Nicolas Gaullier: > Enabled by AVOption dolbyeprobe > Requires stereo > --- > libavformat/s337m.h | 1 + > libavformat/wavdec.c | 23 +++ > 2 files changed, 24 insertions(+) > > diff --git a/libavformat/s337m.h b/libavformat/s337m.h

Re: [FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 18:33 +0200 skrev Nicolas George: > Nicolas Gaullier (12019-08-06): > > --- > > doc/developer.texi | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/doc/developer.texi b/doc/developer.texi > > index 5c342c9106..1e95768364 100644 > > ---

Re: [FFmpeg-devel] [PATCH 2/3] avformat: Support s337m in mxf/wav/w64

2019-07-31 Thread Tomas Härdin
tis 2019-07-30 klockan 21:07 +0200 skrev Carl Eugen Hoyos: > Am Di., 30. Juli 2019 um 21:04 Uhr schrieb Tomas Härdin : > > tis 2019-07-30 klockan 15:24 +0200 skrev Carl Eugen Hoyos: > > > > > > > Am 30.07.2019 um 14:02 schrieb Tomas Härdin : > > > >

Re: [FFmpeg-devel] [PATCH v2 3/5] avformat/s337m: Make available as subdemuxer

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 13:50 +0200 skrev Nicolas Gaullier: > +int avpriv_s337m_probe_stream(void *avc, AVIOContext *pb, AVStream > **st, int size) > +{ > +if ( size >= S337M_MIN_OFFSET && > +((*st)->codecpar->codec_id == AV_CODEC_ID_PCM_S16LE || > (*st)->codecpar->codec_id ==

Re: [FFmpeg-devel] [PATCH v2 2/5] avformat/s337m: Split read_packet/get_packet

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 13:50 +0200 skrev Nicolas Gaullier: > Prepare use of s337m_get_packet from outside > --- > libavformat/s337m.c | 29 +++-- > 1 file changed, 23 insertions(+), 6 deletions(-) Looks OK /Tomas ___

Re: [FFmpeg-devel] [PATCH v2 1/5] avformat/s337m: Use base AVClass for av_log usage

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 13:50 +0200 skrev Nicolas Gaullier: > s337m_get_offset_and_codec does not make use of > AVFormatContext: AVClass is enough for logging. > Will facilitate further use from outside > --- > libavformat/s337m.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [FFmpeg-devel] [PATCH v2 5/5] avformat/s337m: Test wav subdemux

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 13:50 +0200 skrev Nicolas Gaullier: > diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak > index c41958ea2d..0e56d401ea 100644 > --- a/tests/fate/audio.mak > +++ b/tests/fate/audio.mak > @@ -24,6 +24,11 @@ fate-dolby-e: CMD = pcm -i $(TARGET_SAMPLES)/dolby_e/16-11 >

Re: [FFmpeg-devel] [PATCH v2 4/5] avformat/wavdec: s337m support

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 13:50 +0200 skrev Nicolas Gaullier: > Enabled by AVOption dolbyeprobe > Requires stereo > static void set_spdif(AVFormatContext *s, WAVDemuxContext *wav) > @@ -593,6 +599,10 @@ break_loop: > } else if (st->codecpar->codec_id == AV_CODEC_ID_ADPCM_MS && >

Re: [FFmpeg-devel] [PATCH v3 3/6] avformat/s337m: Make available as subdemuxer

2019-08-08 Thread Tomas Härdin
tor 2019-08-08 klockan 10:28 + skrev Gaullier Nicolas: > > > +if (pos < size - 9 && pos >= > > > S337M_PROBE_GUARDBAND_MIN_BYTES) > > I think this 9 should be an 11 or 12.. > Indeed, thank you, my mistake. > > > This isn't quite what I meant by turning it into an integer test :) > >

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: fix index byte count in partition header

2019-07-19 Thread Tomas Härdin
tor 2019-07-18 klockan 11:39 -0700 skrev Baptiste Coudurier: > --- > libavformat/mxfenc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index b677f6af8e..2e54320cf0 100644 > --- a/libavformat/mxfenc.c > +++

Re: [FFmpeg-devel] FFmpeg classification

2019-07-17 Thread Tomas Härdin
ons 2019-07-17 klockan 18:04 +1000 skrev Peter Ross: > On Wed, Jul 17, 2019 at 10:10:13AM +0900, Maaya Murakami (JP) wrote: > > Hello > > > > Hope all is well. > > Currently I am researching about the trends of FFmpeg and its supporting > > codecs, and in order to do so I am trying to classify

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: fix index byte count in partition header

2019-07-22 Thread Tomas Härdin
fre 2019-07-19 klockan 09:51 -0700 skrev Baptiste Coudurier: > Hi Tomas > > > On Jul 19, 2019, at 8:48 AM, Tomas Härdin > > wrote: > > > > tor 2019-07-18 klockan 11:39 -0700 skrev Baptiste Coudurier: > > > --- > > > libavformat/mxfenc.c | 3 +-- &

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/flicvideo: Use bytestream2_get_buffer() in flic_decode_frame_15_16BPP() for FLI_COPY

2019-09-28 Thread Tomas Härdin
tor 2019-09-26 klockan 23:10 +0200 skrev Michael Niedermayer: > Fixes: Timeout(103sec -> 3sec) > Fixes: > 17678/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5715436989054976 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v2 10/15] avcodec/cinepakenc: Fix invalid shifts

2019-09-28 Thread Tomas Härdin
lör 2019-09-28 klockan 04:26 +0200 skrev Andreas Rheinhardt: > Fixes: left shift of 1 by 31 places cannot be represented in type 'int'. > Affected the FATE-tests vsynth1-cinepak, vsynth2-cinepak and > vsynth_lena-cinepak. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cinepakenc.c |

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/g2meet: Check for end of input in jpg_decode_block()

2019-09-30 Thread Tomas Härdin
lör 2019-09-28 klockan 17:47 +0200 skrev Michael Niedermayer: > On Thu, Sep 12, 2019 at 11:09:16PM +0200, Tomas Härdin wrote: > > tor 2019-09-12 klockan 00:21 +0200 skrev Michael Niedermayer: > > > On Wed, Sep 11, 2019 at 11:18:47PM +0200, Tomas Härdin wrote: > > > >

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-06 Thread Tomas Härdin
lör 2019-07-06 klockan 00:08 +0200 skrev Michael Niedermayer: > As we are already off topic, heres an example to test static > analysis, does this trigger undefined behavior by executing the memcpy > for some user input ? > > void f(unsigned bigint a) { > bigint i; > for (i = 2;

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-06 Thread Tomas Härdin
lör 2019-07-06 klockan 18:34 +0200 skrev Michael Niedermayer: > On Sat, Jul 06, 2019 at 02:34:34PM +0200, Tomas Härdin wrote: > > lör 2019-07-06 klockan 00:08 +0200 skrev Michael Niedermayer: > > > As we are already off topic, heres an example to test static > > >

Re: [FFmpeg-devel] [PATCH 4/8] avformat/mxfdec: cleanup on "essence prior to first PartitionPack"

2019-11-06 Thread Tomas Härdin
tor 2019-10-31 klockan 18:58 +0100 skrev Michael Niedermayer: > Fixes: memleak > Fixes: 18473/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer- > 5738557074833408 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] Add support to a PCM audio codec (Win)

2019-11-06 Thread Tomas Härdin
tis 2019-11-05 klockan 20:45 +0100 skrev cumdacon: > Hi to all dev! > > FFmpeg on Windows32; > request of full audio codec support > pcm_s16be > into a container MP4. > > LOG: > [mp4 @ 00a5f840] Could not find tag for codec pcm_s16be in stream #1, > codec not currently supported in container

Re: [FFmpeg-devel] Reimbursement request

2019-11-06 Thread Tomas Härdin
tis 2019-10-29 klockan 16:34 +0800 skrev Steven Liu: > Hi, > I'm requesting the reimbursement of travel expenses for the Google > Mentor Summit. > I mentored the Derain project, more details can be found in [1]. > > > Flight (CNY) ¥ 7062.00 > One night hotel (CNY) ¥ 632.00 > > Total

Re: [FFmpeg-devel] [PATCH 5/8] avformat/mxfdec: Clear metadata_sets_count in mxf_read_close()

2019-11-06 Thread Tomas Härdin
tor 2019-10-31 klockan 18:58 +0100 skrev Michael Niedermayer: > This avoids problems if the function is called twice > > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: correctly set width values for dvcprohd

2019-11-13 Thread Tomas Härdin
mån 2019-11-11 klockan 15:52 -0800 skrev Baptiste Coudurier: > > On Nov 11, 2019, at 3:30 PM, Tomas Härdin wrote: > > > > lör 2019-11-09 klockan 15:46 -0800 skrev Baptiste Coudurier: > > > --- > > > libavformat/mxfenc.c | 15 --- > > >

Re: [FFmpeg-devel] [PATCH] avformat/dvenc: support muxing dvcprohd

2019-11-13 Thread Tomas Härdin
ons 2019-11-13 klockan 09:22 -0800 skrev Baptiste Coudurier: > --- > libavformat/dvenc.c | 48 + > 1 file changed, 22 insertions(+), 26 deletions(-) > > diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c > index 93c103b316..a7d1413eb2 100644 > ---

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dv ul handling

2019-11-13 Thread Tomas Härdin
ons 2019-11-13 klockan 09:25 -0800 skrev Baptiste Coudurier: > > On Nov 11, 2019, at 4:07 PM, Baptiste Coudurier < > > baptiste.coudur...@gmail.com> wrote: > > > > --- > > libavformat/mxfenc.c | 128 -- > > - > > 1 file changed, 46 insertions(+), 82

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dv ul handling

2019-11-11 Thread Tomas Härdin
lör 2019-11-09 klockan 15:46 -0800 skrev Baptiste Coudurier: > +static const UID mxf_dv_container_uls[] = { > +{ > 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x0D,0x01,0x03,0x01,0x02,0x02,0x01,0x01 > }, // IEC DV25 525/60 > +{ >

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: correctly set width values for dvcprohd

2019-11-11 Thread Tomas Härdin
lör 2019-11-09 klockan 15:46 -0800 skrev Baptiste Coudurier: > --- > libavformat/mxfenc.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index b7ae5cc637..f7df9c3daf 100644 > --- a/libavformat/mxfenc.c > +++

Re: [FFmpeg-devel] headers for gapless playback

2019-11-21 Thread Tomas Härdin
tis 2019-11-19 klockan 19:16 + skrev John Kaplan: > Hi Guys, > > We just did some research on gapless playback across multiple client > devices, and could not find support for adding gapless metadata > headers in ffmpeg. Our interest is specifically in AAC/MP4, and we > ended up shifting to

Re: [FFmpeg-devel] [PATCH v2] avfilter/formats: optimize ff_all_formats

2019-12-09 Thread Tomas Härdin
lör 2019-12-07 klockan 01:06 +0800 skrev Zhao Zhili: > This is a micro-optimization. Saving almost 200 reallocations makes > it > worth a try. > --- > fix commit message typo: relocations -> reallocations > > libavfilter/formats.c | 35 +-- > 1 file changed, 21

Re: [FFmpeg-devel] [PATCH v2] avfilter/formats: optimize ff_all_formats

2019-12-15 Thread Tomas Härdin
tis 2019-12-10 klockan 22:14 +0800 skrev zhilizhao: > > On Dec 10, 2019, at 4:20 AM, Tomas Härdin wrote: > > > > lör 2019-12-07 klockan 01:06 +0800 skrev Zhao Zhili: > > > This is a micro-optimization. Saving almost 200 reallocations makes > > > it > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-27 Thread Tomas Härdin
ons 2019-11-27 klockan 20:00 +0100 skrev Paul B Mahol: > On 11/27/19, James Almer wrote: > > On 11/27/2019 3:42 PM, Paul B Mahol wrote: > > > On 11/27/19, Tomas Härdin wrote: > > > > tis 2019-11-26 klockan 20:29 +0100 skrev Paul B Mahol: > > &

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-27 Thread Tomas Härdin
tis 2019-11-26 klockan 20:29 +0100 skrev Paul B Mahol: > On 11/26/19, James Almer wrote: > > On 11/26/2019 6:47 AM, Paul B Mahol wrote: > > > On 11/25/19, Tomas Härdin wrote: > > > > mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: > > > > > S

Re: [FFmpeg-devel] [PATCH] avcodec: add mvdv video decoder

2019-11-24 Thread Tomas Härdin
sön 2019-11-24 klockan 11:12 +0100 skrev Paul B Mahol: > +static ptrdiff_t lzss_uncompress(MidiVidContext *s, GetByteContext *gb, > uint8_t *dst, int size) > +{ > +uint8_t *dst_start = dst; > +uint8_t *dst_end = dst + size; > + > +for (;bytestream2_get_bytes_left(gb) > 0;) {

Re: [FFmpeg-devel] headers for gapless playback

2019-11-24 Thread Tomas Härdin
tor 2019-11-21 klockan 23:35 +0100 skrev Marton Balint: > > On Thu, 21 Nov 2019, Tomas Härdin wrote: > > > tis 2019-11-19 klockan 19:16 + skrev John Kaplan: > > > Hi Guys, > > > > > > We just did some research on gapless playback across multipl

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add mvdv video decoder

2019-11-25 Thread Tomas Härdin
mån 2019-11-25 klockan 22:09 +0100 skrev Paul B Mahol: > Signed-off-by: Paul B Mahol > +static int decode_mvdv(MidiVidContext *s, AVCodecContext *avctx, AVFrame > *frame) > +{ > +GetByteContext *gb = >gb; > +GetBitContext mask; > +GetByteContext idx9; > +uint16_t nb_vectors,

Re: [FFmpeg-devel] headers for gapless playback

2019-11-25 Thread Tomas Härdin
mån 2019-11-25 klockan 22:53 +0100 skrev Marton Balint: > > On Sun, 24 Nov 2019, Tomas Härdin wrote: > > > tor 2019-11-21 klockan 23:35 +0100 skrev Marton Balint: > > > On Thu, 21 Nov 2019, Tomas Härdin wrote: > > > > > > > tis 2019-11-19 klockan 19:

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Simplify assigning decode_intra function pointer

2019-10-07 Thread Tomas Härdin
mån 2019-10-07 klockan 02:57 +0200 skrev Andreas Rheinhardt: > zmbv has only one function for decoding intra frames, namely > decode_intra. This can be used to simplify the process of choosing the > right function pointer. > > This also removes spec-incompliant conversions between function

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Simplify assigning decode_intra function pointer

2019-10-08 Thread Tomas Härdin
mån 2019-10-07 klockan 16:42 + skrev Andreas Rheinhardt: > Tomas Härdin: > > mån 2019-10-07 klockan 02:57 +0200 skrev Andreas Rheinhardt: > > > zmbv has only one function for decoding intra frames, namely > > > decode_intra. This can be used to simplify the process

Re: [FFmpeg-devel] [PATCH] avcodec/zmbvenc: Correct offset in buffer

2019-10-10 Thread Tomas Härdin
tor 2019-10-10 klockan 11:47 +0200 skrev Andreas Rheinhardt: > zmbvenc allocates a buffer for a picture with padding on all four sides: > The stride is choosen so large that it already contains padding on the > right; the height also includes padding rows. The padding on the right > of each row is

Re: [FFmpeg-devel] [PATCH] web: add hosting provider

2019-12-18 Thread Tomas Härdin
tis 2019-12-17 klockan 15:58 -0900 skrev Lou Logan: > Hosting has been provided by telepoint.bg for 4 years now. > This places an unobtrusive note placed in the footer to acknowledge > their continuing support. > > Signed-off-by: Lou Logan > --- > src/template_footer1 | 1 + > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mxfenc: add some missing content package rates

2020-03-04 Thread Tomas Härdin
ons 2020-03-04 klockan 11:31 +0100 skrev Carl Eugen Hoyos: > Am Di., 3. März 2020 um 02:18 Uhr schrieb Marton Balint : > > > 2) support all frame rates and write 0 (undefined) as the package rate > > for frame rates which cannot be exactly represented > > Why not? > > Allow me to repeat:

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxf: get rid of samples per frame array usage

2020-03-03 Thread Tomas Härdin
mån 2020-03-02 klockan 21:35 +0100 skrev Marton Balint: > > On Mon, 2 Mar 2020, Tomas Härdin wrote: > > > fre 2020-02-28 klockan 01:37 +0100 skrev Marton Balint: > > > Signed-off-by: Marton Balint > > > ---

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mxfenc: add some missing content package rates

2020-03-03 Thread Tomas Härdin
> > > > > > On Mar 2, 2020, at 12:57 PM, Marton Balint wrote: > > > > On Mon, 2 Mar 2020, Tomas Härdin wrote: > > > > > fre 2020-02-28 klockan 10:30 +0100 skrev Marton Balint: > > > > > > On Fri, 28 Feb 2020, Carl Eugen Hoyos wro

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Never set codec_ul UID to NULL

2020-03-02 Thread Tomas Härdin
fre 2020-02-28 klockan 05:14 +0100 skrev Andreas Rheinhardt: > mxf distinguishes codec profiles by different UIDs and therefore needs > to check that the input is actually compatible with mxf (i.e. if there > is a defined UID for it). If not, then sometimes the UID would be set to > NULL and

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfenc: move content package rates and timebase combinations to a separate struct

2020-03-02 Thread Tomas Härdin
fre 2020-02-28 klockan 01:37 +0100 skrev Marton Balint: > Signed-off-by: Marton Balint > --- > libavformat/mxf.c | 28 > libavformat/mxf.h | 5 + > 2 files changed, 17 insertions(+), 16 deletions(-) > Reasonable enough. /Tomas

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxf: get rid of samples per frame array usage

2020-03-02 Thread Tomas Härdin
fre 2020-02-28 klockan 01:37 +0100 skrev Marton Balint: > Signed-off-by: Marton Balint > --- > libavformat/mxf.c| 44 > libavformat/mxf.h| 6 -- > libavformat/mxfdec.c | 23 +++ > libavformat/mxfenc.c | 24

Re: [FFmpeg-devel] [PATCH 1/4] avformat/audiointerleave: disallow using a samples_per_frame array

2020-03-02 Thread Tomas Härdin
Sorry for replying a bit late, I've been sick fre 2020-02-28 klockan 01:37 +0100 skrev Marton Balint: > Only MXF used an actual sample array, and that is unneeded there > because simple > rounding rules can be used instead. Does this produce the exact same rounding? Like 1602, 1601, 1602, 1601,

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mxfenc: add some missing content package rates

2020-03-02 Thread Tomas Härdin
fre 2020-02-28 klockan 10:30 +0100 skrev Marton Balint: > > On Fri, 28 Feb 2020, Carl Eugen Hoyos wrote: > > > Am Fr., 28. Feb. 2020 um 01:38 Uhr schrieb Marton Balint : > > > Fixes ticket #8523. > > > > > > Signed-off-by: Marton Balint > > > --- > > > libavformat/mxf.c | 13 + > >

Re: [FFmpeg-devel] [PATCH v2] avformat/mxfenc: use a zero based continuity counter

2020-03-02 Thread Tomas Härdin
lör 2020-02-29 klockan 21:06 +0100 skrev Marton Balint: > The standard does not seem to require the counter to be zero based, but some > checker tools (MyriadBits MXFInspect, Interra Baton) have validations against > 0 > start... > > Fixes ticket #6781. > > Signed-off-by: Marton Balint > --- >

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxf: get rid of samples per frame array usage

2020-03-03 Thread Tomas Härdin
tis 2020-03-03 klockan 11:22 -0800 skrev Baptiste Coudurier: > Hey guys, > > > > On Mar 3, 2020, at 10:54 AM, Tomas Härdin wrote: > > > > mån 2020-03-02 klockan 21:35 +0100 skrev Marton Balint: > > > On Mon, 2 Mar 2020, Tomas Härdin wrote: > > >

Re: [FFmpeg-devel] Two weird requests

2020-02-27 Thread Tomas Härdin
tor 2020-02-27 klockan 00:03 -0800 skrev Unidef Defshrizzle: > Could you integrate this code into ffmpeg? > > > https://unidef.org/wp-content/uploads/2019/12/qlib.zip < > https://unidef.org/wp-content/uploads/2019/12/qlib.zip> It doesn't compile. Additionally: > General Purpose Quantum

[FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as mxf* maintainer

2020-02-01 Thread Tomas Härdin
* Baptiste Coudurier, Tomas Härdin nistspheredec.c Paul B Mahol nsvdec.c Francois Revol nut* Michael Niedermayer -- 2.20.1 signature.asc Description: This is a digitally signed message part

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as mxf* maintainer

2020-02-02 Thread Tomas Härdin
lör 2020-02-01 klockan 21:07 +0100 skrev Paul B Mahol: > On 2/1/20, Marton Balint wrote: > > > > On Sat, 1 Feb 2020, Carl Eugen Hoyos wrote: > > > > > > > > > Am 01.02.2020 um 16:22 schrieb Paul B Mahol : > > > > > > > > > O

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: add decoder for argonaut games' adpcm codec

2020-01-19 Thread Tomas Härdin
sön 2020-01-19 klockan 08:33 + skrev Zane van Iperen: > Adds support for the ADPCM variant used by some Argonaut Games' > games, > such as 'Croc! Legend of the Gobbos', and 'Croc 2'. > > Signed-off-by: Zane van Iperen > --- > Changelog | 2 +- > doc/general.texi| 1

Re: [FFmpeg-devel] [PATCH 9/9] avformat/wavdec: Test s337m

2020-01-13 Thread Tomas Härdin
mån 2020-01-13 klockan 16:10 + skrev Gaullier Nicolas: > > > > > > +FATE_SAMPLES_AUDIO-$(call DEMDEMDEC, WAV, S337M, DOLBY_E) += > > > +fate-dolby-e-wav > > > +fate-dolby-e-wav: CMD = dolbye2pcm16 -i > > > +$(TARGET_SAMPLES)/dolby_e/512.wav > > > +fate-dolby-e-wav: CMP = oneoff > > >

Re: [FFmpeg-devel] [PATCH 3/9] avformat/s337m: Consider container bit resolution

2020-01-13 Thread Tomas Härdin
mån 2020-01-13 klockan 14:02 + skrev Gaullier Nicolas: > > > +if (container_word_bits && (container_word_bits+7)/8 != > > > + (word_bits+7)/8) { > > > > Can it happen that word_bits is anything but 16 or 24 with a valid > > stream? If not then I'd check container_word_bits == word_bits

Re: [FFmpeg-devel] [PATCH 1/9] avformat/s337m: Use base AVClass for av_log usage

2020-01-14 Thread Tomas Härdin
tis 2020-01-14 klockan 18:02 +0100 skrev Michael Niedermayer: > On Sun, Jan 12, 2020 at 09:13:49PM +0100, Tomas Härdin wrote: > > fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > > > s337m_get_offset_and_codec does not make use of > > > AVFormatContext: AV

Re: [FFmpeg-devel] [PATCH 1/9] avformat/s337m: Use base AVClass for av_log usage

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > s337m_get_offset_and_codec does not make use of > AVFormatContext: AVClass is enough for logging. > Will facilitate further use from outside > --- > libavformat/s337m.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [FFmpeg-devel] [PATCH 2/9] avformat/s337m: Split read_packet/get_packet

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Prepare use of s337m_get_packet from outside. > --- > libavformat/s337m.c | 28 +--- > libavformat/s337m.h | 38 ++ > 2 files changed, 59 insertions(+), 7 deletions(-) >

Re: [FFmpeg-devel] [PATCH 3/9] avformat/s337m: Consider container bit resolution

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Prepare the support of s337m in muxers other than raw (ex: wav). > For example, this forbids reading 16 bits DolbyE stream from a 24 bit wav > file. > --- > libavformat/s337m.c | 20 ++-- > libavformat/s337m.h | 3 ++-

Re: [FFmpeg-devel] [PATCH 4/9] avformat/s337m: New ff_s337m_probe()

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Similar to ff_spdif_probe() with two additionnal parameters: > - an AVClass for logging > - the bit resolution of the container as it may be 16 or 24 for s337m > --- > libavformat/s337m.c | 35 +++ >

Re: [FFmpeg-devel] [PATCH 5/9] avformat/wavdec: s337m support

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Add s337m probing/reading similarly to spdif. > Add a new AVOption 'dolbyeprobe' to enable it. > --- > libavformat/wavdec.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > -static void

Re: [FFmpeg-devel] [PATCH 9/9] avformat/wavdec: Test s337m

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Test the new 'dolbyeprobe' AVOption. > Test dolby_e decoding for 24 bits with program config '5.1+2' > --- > tests/Makefile | 1 + > tests/fate-run.sh| 4 > tests/fate/audio.mak | 5 + > 3 files changed, 10

Re: [FFmpeg-devel] [PATCH 7/9] avformat/wavdec: Fix s337m last packet parsing

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Fix reading beyond data_end. > --- > libavformat/wavdec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c > index ccb9576b84..039ec1658e 100644 > ---

Re: [FFmpeg-devel] [PATCH 6/9] avformat/wavdec: fix s337m/spdif probing beyond data_end

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > --- > libavformat/wavdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c > index 2796905e1f..ccb9576b84 100644 > --- a/libavformat/wavdec.c > +++

Re: [FFmpeg-devel] [PATCH v2 6/7] avformat/mxfenc: allow all frame rates if -strict mode is set to unofficial or lower

2020-03-07 Thread Tomas Härdin
tor 2020-03-05 klockan 22:56 +0100 skrev Marton Balint: > There was no consensus wheter or not to allow unofficial frame rates due to > possible interoperability issues, a compromise is to only allow it if -strict > mode is set to unofficial. > > Signed-off-by: Marton Balint > --- >

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxf: get rid of samples per frame array usage

2020-03-07 Thread Tomas Härdin
ons 2020-03-04 klockan 19:58 +0100 skrev Michael Niedermayer: > On Tue, Mar 03, 2020 at 07:54:55PM +0100, Tomas Härdin wrote: > > mån 2020-03-02 klockan 21:35 +0100 skrev Marton Balint: > > > On Mon, 2 Mar 2020, Tomas Härdin wrote: > > > > > > > fre 2020

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mxfenc: add some missing content package rates

2020-03-07 Thread Tomas Härdin
ons 2020-03-04 klockan 17:48 +0100 skrev Carl Eugen Hoyos: > Am Mi., 4. März 2020 um 17:29 Uhr schrieb Tomas Härdin < > tjop...@acc.umu.se>: > > ons 2020-03-04 klockan 11:31 +0100 skrev Carl Eugen Hoyos: > > > Am Di., 3. März 2020 um 02:18 Uhr schrieb Marton Ba

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Reorder fields in MXFIndexEntry to make it smaller

2020-03-14 Thread Tomas Härdin
fre 2020-03-13 klockan 11:18 +0100 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mxfenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index 5e0dc0e889..55c715d776 100644 > ---

Re: [FFmpeg-devel] [PATCH v2 6/7] avformat/mxfenc: allow all frame rates if -strict mode is set to unofficial or lower

2020-03-14 Thread Tomas Härdin
tor 2020-03-12 klockan 22:21 +0100 skrev Marton Balint: > > On Sat, 7 Mar 2020, Tomas Härdin wrote: > > > tor 2020-03-05 klockan 22:56 +0100 skrev Marton Balint: > > > There was no consensus wheter or not to allow unofficial frame rates due > > > to >

Re: [FFmpeg-devel] [PATCH v3 7/7] avformat/audiointerleave: use a fixed frame duration for non-audio packets

2020-03-14 Thread Tomas Härdin
fre 2020-03-13 klockan 02:31 +0100 skrev Marton Balint: > The packet durations might not be set properly which can cause the MXF muxer > to write more than one packet of a stream to an edit unit messing up the > constant byte per element index... Shouldn't this be fixed "higher up"? > Also warn

Re: [FFmpeg-devel] [PATCH v3 7/7] avformat/audiointerleave: use a fixed frame duration for non-audio packets

2020-03-16 Thread Tomas Härdin
lör 2020-03-14 klockan 17:59 +0100 skrev Marton Balint: > > On Sat, 14 Mar 2020, Tomas Härdin wrote: > > > fre 2020-03-13 klockan 02:31 +0100 skrev Marton Balint: > > > The packet durations might not be set properly which can cause the MXF > > > muxer &g

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Correct confusing struct tag

2020-03-29 Thread Tomas Härdin
sön 2020-03-29 klockan 06:06 +0200 skrev Andreas Rheinhardt: > Don't use typedef struct MXFTrack {...} MXFTimecodeComponent, in > particular given the fact that MXFTrack is a type of its own. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mxfdec.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 2/5] avformat/mxfdec: reindent code

2020-05-04 Thread Tomas Härdin
mån 2020-05-04 klockan 18:58 +0800 skrev Lance Wang: > On Mon, May 4, 2020 at 4:13 PM Tomas Härdin > wrote: > > > tor 2020-04-30 klockan 20:59 +0800 skrev lance.lmw...@gmail.com: > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > &

Re: [FFmpeg-devel] [PATCH v4 7/8] avformat: implement retiming directly in mxfenc and gxfenc

2020-05-04 Thread Tomas Härdin
tis 2020-04-28 klockan 19:37 +0200 skrev Marton Balint: > Generic retime functionality is replaced by a few lines of code directly in > the > muxers which used it, which seems a lot easier to understand and this way the > retiming is not dependant of the input durations. > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/5] avformat/mxfdec: reindent code

2020-05-04 Thread Tomas Härdin
tor 2020-04-30 klockan 20:59 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/mxfdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index fdd0dd2a88..02a2a6d97a

Re: [FFmpeg-devel] [PATCH v4 7/8] avformat: implement retiming directly in mxfenc and gxfenc

2020-05-04 Thread Tomas Härdin
tis 2020-04-28 klockan 19:37 +0200 skrev Marton Balint: > Generic retime functionality is replaced by a few lines of code > directly in the > muxers which used it, which seems a lot easier to understand and this > way the > retiming is not dependant of the input durations. > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH v1] avformat/mxfdec: use av_asprintf()

2020-03-23 Thread Tomas Härdin
sön 2020-03-22 klockan 23:03 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/mxfdec.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index

Re: [FFmpeg-devel] [RFC] Meeting / Upcoming Conferences

2020-03-10 Thread Tomas Härdin
tis 2020-03-10 klockan 13:40 +0100 skrev Michael Niedermayer: > Hi all > [...] > About reimbursements, my personal oppinion is that anyone who has previously > paid for travel fully believing that a conference would occur, and cannot get > their money back should be reimbursed by our funds. >

Re: [FFmpeg-devel] [RFC]separation of multiple outputs' encoding

2020-05-19 Thread Tomas Härdin
fre 2020-05-15 klockan 10:14 +0800 skrev Tao Zhang: > Marton Balint 于2020年5月15日周五 上午2:33写道: > > > > > > On Thu, 14 May 2020, Tao Zhang wrote: > > > > > Hi, > > > FFmpeg supports multiple outputs created out of the same input in the > > > same process like > > > ffmpeg -i input -filter_complex

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF

2020-09-07 Thread Tomas Härdin
mån 2020-08-31 klockan 20:07 +0100 skrev Harry Mallon: > * As embedded by Apple Compressor This needs a sample since it isn't part of any official spec, so that we can have a test for this. > +if (IS_KLV_KEY(uid, mxf_coll_apple_max_cll)) { > +if (!descriptor->coll) { > +

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mxfenc: Write Mastering Display Colour Volume to MXF

2020-09-07 Thread Tomas Härdin
mån 2020-08-31 klockan 20:07 +0100 skrev Harry Mallon: > +static const MXFLocalTagPair mxf_mastering_display_local_tags[] = { > +{ 0x8201, > {0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x01,0x00,0x00}}, > /* Mastering Display Primaries */ > +{ 0x8202, >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: Read Mastering Display Colour Volume from MXF

2020-09-07 Thread Tomas Härdin
mån 2020-08-31 klockan 20:07 +0100 skrev Harry Mallon: > +static const uint8_t mxf_mastering_display_primaries[]= { > 0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x01,0x00,0x00 > }; > +static const uint8_t mxf_mastering_display_white_point_chromaticity[] = {

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: Read Mastering Display Colour Volume from MXF

2020-09-07 Thread Tomas Härdin
mån 2020-09-07 klockan 11:40 +0200 skrev Tomas Härdin: > mån 2020-08-31 klockan 20:07 +0100 skrev Harry Mallon: > > +static const uint8_t mxf_mastering_display_primaries[]= { > > 0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x01,0x00,0x00 >

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fix pixel format extraction for cinema j2k

2020-09-14 Thread Tomas Härdin
mån 2020-09-14 klockan 10:48 +0100 skrev Rémi Achard: > > Why this added hunk? Appending strong refs like this is likely to have > > all sorts of unintended effects. The same MaterialPackages will appear > > multiple times for example. > > This is my attempt to fix an issue in the fate tests.

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fix pixel format extraction for cinema j2k

2020-09-14 Thread Tomas Härdin
sön 2020-09-13 klockan 23:42 +0100 skrev Rémi Achard: > > @@ -855,15 +857,19 @@ static int mxf_read_cryptographic_context(void *arg, > AVIOContext *pb, int tag, i > > static int mxf_read_strong_ref_array(AVIOContext *pb, UID **refs, int *count) > { > -*count = avio_rb32(pb); > -

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: Write Mastering Display Colour Volume to MXF

2020-09-14 Thread Tomas Härdin
ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > Described in Annex B SMPTE ST 2067-21:2020 > > Signed-off-by: Harry Mallon Simple enough. /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mxfdec: Read Mastering Display Colour Volume from MXF

2020-09-14 Thread Tomas Härdin
ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > Described in Annex B SMPTE ST 2067-21:2020 > > Signed-off-by: Harry Mallon > av_freep(&((MXFDescriptor *)*ctx)->sub_descriptors_refs); > @@ -1272,6 +1276,42 @@ static int mxf_read_generic_descriptor(void *arg, > AVIOContext *pb,

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF

2020-09-14 Thread Tomas Härdin
ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > * As embedded by Apple Compressor > > Signed-off-by: Harry Mallon > --- > libavformat/mxfdec.c| 27 + > tests/fate/mxf.mak | 4 + > tests/ref/fate/mxf-probe-applehdr10 | 169

Re: [FFmpeg-devel] libopenjpeg decoder not correctly setting the pixel format for cinema JP2K wrapped MXF

2020-09-04 Thread Tomas Härdin
tis 2020-09-01 klockan 11:06 +0100 skrev Rémi Achard: > > If you want the IS_KLV_KEY() check to be more lenient then you should > > make mxf_jp2k_rsiz[] shorter, not replace the end of it with NULs > > This UL come straight from SMPTE ST 422M, not sure what you mean but I > didn't replace it with

Re: [FFmpeg-devel] libopenjpeg decoder not correctly setting the pixel format for cinema JP2K wrapped MXF

2020-08-31 Thread Tomas Härdin
sön 2020-08-30 klockan 18:22 +0100 skrev Rémi Achard: > Hi, > > As you are probably aware, the libopenjpeg decoder is not able to interpret > cinema jp2k mxf correctly, the pixel format being assigned as rgb48 instead > of xyz12 as it should. Note that ffmpeg native jp2k decoder parse the RSIZ >

<    1   2   3   4   5   6   7   8   9   10   >