Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread Kurtis Rader
We should end this thread since I can reproduce the problem and it clear there is a real bug introduced in the past couple of days with commit ab189a7 . Further discussion should take place here: https://githu

Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread Kurtis Rader
On Wed, Jan 25, 2017 at 7:40 PM, David B. Lamkins wrote: > Correction. Not the head. I used git gui for the first time and > misinterpreted the output. But it's definitely that branch. Ignore that the change originated on ridiculousfish's `iothread_perform_lambda` branch. It is irrelevant unles

Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread Kurtis Rader
On Wed, Jan 25, 2017 at 7:26 PM, David B. Lamkins wrote: > Just to be clear, I'm doing > > > git checkout f4476100 > > That looks like the head of a branch, iothread_perform_lambda, that has > several other commits. > Huh? After I do that checkout running `git log --stat -100` reports the follow

Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread David B. Lamkins
On Wed, Jan 25, 2017 at 07:26:17PM -0800, David B. Lamkins wrote: > Just to be clear, I'm doing > > > git checkout f4476100 > > That looks like the head of a branch, iothread_perform_lambda, that has > several other commits. Correction. Not the head. I used git gui for the first time and misint

Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread Kurtis Rader
Your testing suggests the problem is not deterministic. Which is not surprising since SIGINT handling has always been slightly flakey. But there is absolutely no way commit f4476100 can "restore proper ^C behavior." Just do `git log -p -1 f4476100` to see that it cannot possibly change the behavior

Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread David B. Lamkins
Just to be clear, I'm doing > git checkout f4476100 That looks like the head of a branch, iothread_perform_lambda, that has several other commits. On Wed, Jan 25, 2017 at 07:13:15PM -0800, Kurtis Rader wrote: > Your testing suggests the problem is not deterministic. Which is not > surprising

Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread David B. Lamkins
Heh. Fair enough. :) This is a different system than the one on which I noticed the problem this morning. Also, I neglected to do a clean build. So let me be more rigourous about building and testing, this time... With > ./configure; and make clean all; and sudo make install ... followed by star

Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread Kurtis Rader
On Wed, Jan 25, 2017 at 6:04 PM, David B. Lamkins wrote: > Commit f4476100 does correct the problem. > Not on my system. And it isn't possible for that commit to fix the problem because it only changes a comment. This is the entirety of that change: -/// A class to aid iteration over jobs list.

Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread David B. Lamkins
Commit f4476100 does correct the problem. On Wed, Jan 25, 2017 at 05:54:11PM -0800, Kurtis Rader wrote: > On Wed, Jan 25, 2017 at 10:12 AM, David B. Lamkins <[1]dlamk...@galois.com> > wrote: > > fish, version 2.4.0-418-gec19159-dirty > > Is it just me, or is ^C handling broken? > >

Re: [Fish-users] Recent change broke INT handling?

2017-01-25 Thread Kurtis Rader
On Wed, Jan 25, 2017 at 10:12 AM, David B. Lamkins wrote: > fish, version 2.4.0-418-gec19159-dirty > > Is it just me, or is ^C handling broken? > > $ while true; echo here; sleep 1; end > > Typing ^C does not interrupt the loop as expected. > Thanks for bringing this to our attention. I've opene

[Fish-users] Recent change broke INT handling?

2017-01-25 Thread David B. Lamkins
fish, version 2.4.0-418-gec19159-dirty Is it just me, or is ^C handling broken? $ while true; echo here; sleep 1; end Typing ^C does not interrupt the loop as expected. -- Check out the vibrant tech community on one of