Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-04-05 Thread Fabien Costantini
NP problem, after more than 15 years, it is still a pleasure to contribute to fltk :-) > It'working fine for me. > Thanks for the correction. ___ fltk mailing list fltk@easysw.com http://lists.easysw.com/mailman/listinfo/fltk

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-04-05 Thread David FLEURY
Le 05/04/2012 17:08, Albrecht Schlosser a écrit : > This has been addressed differently now by adding an accessor method > (svn r 9325, by Fabien), and the other problem is now fixed as well, > as suggested by your patch (r 9327). Please test if this is okay now. > It all worked well for me with V

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-04-05 Thread Albrecht Schlosser
On 26.03.2012 19:46, David FLEURY wrote: > Le 26/03/2012 17:28, MacArthur, Ian (SELEX GALILEO, UK) a écrit : >>> > I also believe that we already had a similar problem. This one can >>> > be fixed easily with "friend class Fl_X;" in Fl_Widget.H, like this >>> > patch: >>> > >>> > Index: FL/Fl_Widge

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-27 Thread Albrecht Schlosser
On 26.03.2012 17:28, MacArthur, Ian (SELEX GALILEO, UK) wrote: > >> I also believe that we already had a similar problem. This one can >> be fixed easily with "friend class Fl_X;" in Fl_Widget.H, like this >> patch: >> >> Index: FL/Fl_Widget.H >>

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-26 Thread David FLEURY
Le 26/03/2012 17:28, MacArthur, Ian (SELEX GALILEO, UK) a écrit : >> > I also believe that we already had a similar problem. This one can >> > be fixed easily with "friend class Fl_X;" in Fl_Widget.H, like this >> > patch: >> > >> > Index: FL/Fl_Widget.H >> > ==

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-26 Thread MacArthur, Ian (SELEX GALILEO, UK)
> I also believe that we already had a similar problem. This one can > be fixed easily with "friend class Fl_X;" in Fl_Widget.H, like this > patch: > > Index: FL/Fl_Widget.H > === > --- FL/Fl_Widget.H (revision 9300) > +++ FL/Fl

Re: [fltk.general] Compilation error on windows VS 2010 (r9300) -drift in fltk3 compatibility being broken...

2012-03-26 Thread Ian MacArthur
> All, > > One thing I did just notice is that the r9300/r9301 fltk3 build is somewhat= > borked. > > A few days ago, if I built the "test1" folder, to verify that the fltk-1 co= > mpatibility was working, I was getting 50 out of 70 tests building OK. > > As of this morning, with r9301 checked out

Re: [fltk.general] Compilation error on windows VS 2010 (r9300) - drift in fltk3 compatibility being broken...

2012-03-26 Thread MacArthur, Ian (SELEX GALILEO, UK)
All, One thing I did just notice is that the r9300/r9301 fltk3 build is somewhat borked. A few days ago, if I built the "test1" folder, to verify that the fltk-1 compatibility was working, I was getting 50 out of 70 tests building OK. As of this morning, with r9301 checked out, I get 2 out of

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-26 Thread Albrecht Schlosser
On 25.03.2012 22:46, Ian MacArthur wrote: > > On 25 Mar 2012, at 06:50, David FLEURY wrote: >> >> Hum, the code is from Fl_win32.cxx, the function is : >> Fl_X* Fl_X::make(Fl_Window* w) and try to access a protected enum. >> >> Under VS, I don't see any link between Fl_X and Fl_Widget. >> >> The fi

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-25 Thread Ian MacArthur
On 25 Mar 2012, at 06:50, David FLEURY wrote: > > Hum, the code is from Fl_win32.cxx, the function is : > Fl_X* Fl_X::make(Fl_Window* w) and try to access a protected enum. > > Under VS, I don't see any link between Fl_X and Fl_Widget. > > The filename is Fl_win32.cxx this is probably why it no

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-25 Thread Nikita Egorov
2012/3/25 Greg Ercolano : > On 03/24/12 14:39, Nikita Egorov wrote: >> I think VS applies 'static' attribute only to first variable from list >> ('no_fullscreen_x'). > >        I'm not sure that's the problem, at least not as a general >        case with 'static'. Though perhaps the DLL context is

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-24 Thread David FLEURY
>> First, it is >> src\Fl_win32.cxx(1318[and 1629]): error C2248: 'FULLSCREEN' : cannot >> access protected enumerator declared in class 'Fl_Widget' > > OK - that's presumably what the patch was changing in Fl_Wideget.H, then, by > changing the visibility of the enumerated values - though I can

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-24 Thread Greg Ercolano
On 03/24/12 14:39, Nikita Egorov wrote: > I think VS applies 'static' attribute only to first variable from list > ('no_fullscreen_x'). I'm not sure that's the problem, at least not as a general case with 'static'. Though perhaps the DLL context is complicating things.

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-24 Thread Greg Ercolano
On 03/24/12 16:41, Greg Ercolano wrote: > On 03/24/12 14:39, Nikita Egorov wrote: >> I think VS applies 'static' attribute only to first variable from list >> ('no_fullscreen_x'). > > I'm not sure that's the problem, at least not as a general > case with 'static'. Though perhaps the DL

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-24 Thread Ian MacArthur
Hi Nikita, On 24 Mar 2012, at 21:39, Nikita Egorov wrote: >> I don't have VS2010, so can you tell us what errors you were getting? >> >> And what the last version that did work OK was? >> >> >> Looking at the patch to Fl_Window.H, for example, it's not even obvious to >> me that it is actual

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-24 Thread Nikita Egorov
> I don't have VS2010, so can you tell us what errors you were getting? > > And what the last version that did work OK was? > > > Looking at the patch to Fl_Window.H, for example, it's not even obvious to me > that it is actually changing anything, in so far as I understand the C++ > syntax anywa

Re: [fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-24 Thread Ian MacArthur
On 24 Mar 2012, at 19:25, David FLEURY wrote: > > the branch 1.3.x r 9300 do not compile under windows VS2010. > > Here the patch for locating theses issues. > My patch is only here to compile my own version. I don't have VS2010, so can you tell us what errors you were getting? And what the la

[fltk.general] Compilation error on windows VS 2010 (r9300)

2012-03-24 Thread David FLEURY
Hi, the branch 1.3.x r 9300 do not compile under windows VS2010. Here the patch for locating theses issues. My patch is only here to compile my own version. Regards, David Index: Fl_Widget.H === --- Fl_Widget.H (revision 9300) +++