Re: CFT: if_bridge performance improvements

2020-04-24 Thread Xin Li via freebsd-stable
On 4/24/20 06:42, Kristof Provost wrote: > On 22 Apr 2020, at 18:15, Xin Li wrote: >> On 4/22/20 01:45, Kristof Provost wrote: >>> On 22 Apr 2020, at 10:20, Xin Li wrote: Hi, On 4/14/20 02:51, Kristof Provost wrote: > Hi, > > Thanks to support from The FreeBSD Foundation

Re: CFT: if_bridge performance improvements

2020-04-24 Thread Kristof Provost
On 22 Apr 2020, at 18:15, Xin Li wrote: On 4/22/20 01:45, Kristof Provost wrote: On 22 Apr 2020, at 10:20, Xin Li wrote: Hi, On 4/14/20 02:51, Kristof Provost wrote: Hi, Thanks to support from The FreeBSD Foundation I’ve been able to work on improving the throughput of if_bridge. It change

Re: CFT: if_bridge performance improvements

2020-04-22 Thread peter . blok
Just using pf is enough to provoke this panic. I had the same back trace. This patch from Kristof fixed it for me. diff --git a/sys/net/if_bridge.c b/sys/net/if_bridge.c index 373fa096d70..83c453090bb 100644 --- a/sys/net/if_bridge.c +++ b/sys/net/if_bridge.c @@ -2529,7 +2529,6 @@ bridge_input(st

Re: CFT: if_bridge performance improvements

2020-04-22 Thread Xin Li via freebsd-stable
On 4/22/20 01:45, Kristof Provost wrote: > On 22 Apr 2020, at 10:20, Xin Li wrote: >> Hi, >> >> On 4/14/20 02:51, Kristof Provost wrote: >>> Hi, >>> >>> Thanks to support from The FreeBSD Foundation I’ve been able to work on >>> improving the throughput of if_bridge. >>> It changes the (data path)

Re: CFT: if_bridge performance improvements

2020-04-22 Thread Kristof Provost
On 22 Apr 2020, at 10:20, Xin Li wrote: Hi, On 4/14/20 02:51, Kristof Provost wrote: Hi, Thanks to support from The FreeBSD Foundation I’ve been able to work on improving the throughput of if_bridge. It changes the (data path) locking to use the NET_EPOCH infrastructure. Benchmarking shows

Re: CFT: if_bridge performance improvements

2020-04-22 Thread Xin Li via freebsd-stable
Hi, On 4/14/20 02:51, Kristof Provost wrote: > Hi, > > Thanks to support from The FreeBSD Foundation I’ve been able to work on > improving the throughput of if_bridge. > It changes the (data path) locking to use the NET_EPOCH infrastructure. > Benchmarking shows substantial improvements (x5 in te

Re: CFT: if_bridge performance improvements

2020-04-16 Thread Kristof Provost
On 16 Apr 2020, at 10:36, Peter Blok wrote: Another issue I found with pf was with "set skip on bridge”. It doesn’t work on the interface group, unless a bridge exists prior to enabling pf. Makes sense, but I didn’t think of it. Other rules work fine with interface groups. I am aware of this

Re: CFT: if_bridge performance improvements

2020-04-16 Thread peter . blok
Hi Mark/Kristof, I have been using ng_bridge for more than a year. It was very stable and it allowed to have members with different MTU. My jails were using jng to setup the bridge and I changed iohyve to use ng_bridge. But I recently switched to if_bridge. I needed to have pf work on a member

Re: CFT: if_bridge performance improvements

2020-04-16 Thread Kristof Provost
Hi Mark, I wouldn’t expect these changes to make a difference in the performance of this setup. My work mostly affects setups with multi-core systems that see a lot of traffic. Even before these changes I’d expect the if_bridge code to saturate a wifi link easily. I also wouldn’t expect ng_b

Re: CFT: if_bridge performance improvements

2020-04-16 Thread Kristof Provost
On 16 Apr 2020, at 8:34, Pavel Timofeev wrote: Hi! Thank you for your work! Do you know if epair suffers from the same issue as tap? I’ve not tested it, but I believe that epair scales significantly better than tap. It has a per-cpu mutex (or more accurately, a mutex in each of its per-cpu str

Re: CFT: if_bridge performance improvements

2020-04-15 Thread Pavel Timofeev
вт, 14 апр. 2020 г., 12:51 Kristof Provost : > Hi, > > Thanks to support from The FreeBSD Foundation I’ve been able to work > on improving the throughput of if_bridge. > It changes the (data path) locking to use the NET_EPOCH infrastructure. > Benchmarking shows substantial improvements (x5 in tes

Re: CFT: if_bridge performance improvements

2020-04-15 Thread Mark Saad
Kristof Up until a month ago I ran a set of FreeBSD based ap in my house and even long ago at work . They were Pc engines apu ‘s or Alix’s with one em/igb nic and one ath nic in a bridge . They worked well for a long time however the need for more robust wifi setup caused me to swap them ou

Re: CFT: if_bridge performance improvements

2020-04-15 Thread Kristof Provost
On 15 Apr 2020, at 19:16, Mark Saad wrote: All Should this improve wifi to wired bridges in some way ? Has this been tested ? What sort of setup do you have to bridge wired and wireless? Is the FreeBSD box also a wifi AP? I’ve not done any tests involving wifi. Best regards, Kristof ___

Re: CFT: if_bridge performance improvements

2020-04-15 Thread Mark Saad
All Should this improve wifi to wired bridges in some way ? Has this been tested ? --- Mark Saad | nones...@longcount.org > On Apr 15, 2020, at 1:08 PM, Raúl Muñoz - CUSTOS via freebsd-stable > wrote: > > El 14/4/20 a las 11:53, Kristof Provost escribió: > >> Patches for stable/12: http

Re: CFT: if_bridge performance improvements

2020-04-15 Thread Raúl Muñoz - CUSTOS via freebsd-stable
El 14/4/20 a las 11:53, Kristof Provost escribió: > Patches for stable/12: https://people.freebsd.org/~kp/if_bridge/stable_12/ Bridges and taps here, r359859 with your if_bridge patches, happily running for more than two days ;). Regards, Raúl ___ free

CFT: if_bridge performance improvements

2020-04-14 Thread Kristof Provost
Hi, Thanks to support from The FreeBSD Foundation I’ve been able to work on improving the throughput of if_bridge. It changes the (data path) locking to use the NET_EPOCH infrastructure. Benchmarking shows substantial improvements (x5 in test setups). This work is ready for wider testing now.