Follow-up Comment #5, bug #13846 (project freeciv):
I added 'bool read_cmd'. I thin this can be changed
to 'int read_level' and for 'read_level = 5' there
will be an error message ...
___
Reply to this item at:
Follow-up Comment #10, bug #13810 (project freeciv):
Why do you use the setting number as first argument
to almost every setting function? The only function
that takes a setting id should be setting_by_number().
for (i = 0; i SETTINGS_NUM; i++) {
This way I can use
Follow-up Comment #11, bug #13810 (project freeciv):
This way I can use
pset_scategory(i)
else I would have
pset_scategory(setting_by_number(i))
There is an example of how to create an iteration
macro when the array pointer is not available in
the header in the patch in bug #13793.
Am Thursday 02 July 2009 01:19:19 schrieben Sie:
On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
You don't need to. As I said the 3 GB size is not a problem. I think I
will also get warclient and longturn to compare ...
The 3 GB is just silly. The entire history of
Follow-up Comment #12, bug #13810 (project freeciv):
Sorry if something was unclear beforehand.
Unfortunately I will not be able to explain so much
now as I will be trying to finish the work for 2.2.
Thanks for the help! I did learn something in the
discussions and the last thing I did
URL:
http://gna.org/bugs/?13850
Summary: add min/max definitions for saveturns
Project: Freeciv
Submitted by: syntron
Submitted on: Donnerstag 02.07.2009 um 20:48
Category: general
Severity: 2 - Minor
Follow-up Comment #1, bug #13848 (project freeciv):
Looks good in most part.
- I don't like switch and case at same indentation level. I would vote
for half indent step (2/2 = 1) for case
- Could you add assert() rule that instead of assert(FALSE) assert with
more verbose error message should
Update of bug #13726 (project freeciv):
Status:None = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13770 (project freeciv):
Status:None = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13637 (project freeciv):
Status:None = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13828 (project freeciv):
Status:None = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13850 (project freeciv):
Assigned to:None = cazfi
___
Reply to this item at:
http://gna.org/bugs/?13850
___
Message sent
2009/7/2 Madeline Book madeline.b...@gmail.com:
On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
You don't need to. As I said the 3 GB size is not a problem. I think I will
also get warclient and longturn to compare ...
The 3 GB is just silly. The entire history of the
Am Thursday 02 July 2009 23:24:09 schrieb Marko Lindqvist:
2009/7/2 Madeline Book madeline.b...@gmail.com:
On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
You don't need to. As I said the 3 GB size is not a problem. I think I
will also get warclient and longturn to
Hello,
does the list has hickups? I'm missing some emails about comments to patches
on gna since Thursday. The newest mail in the email archive is also from
Thursday (https://mail.gna.org/public/freeciv-dev/2009-07/threads.html). I
hope this Email will find its way.
Matthias
--
Matthias
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39923
2007/11/28 Jason Dorje Short jdo...@gmail.com:
However the default
profile hard-coded in freeciv is for pubserver.freeciv.org as the
server. This patch should be applied to change that default profile, or
pubserver.freeciv.org
On 30/06/2009, Madeline Book no-reply.invalid-addr...@gna.org wrote:
Follow-up Comment #8, bug #13726 (project freeciv):
(Book, why don't I receive your message on my e-mail account?)
I have no idea, maybe it was just late in arriving?
Maybe your spam filter got tired of reading through
my
2009/7/3 Madeline Book madeline.b...@gmail.com:
Now I'm not getting any email from gna when I post
comments to tickets. O-o
It seems that commit messages are not being sent to freeciv-commits.
Neither does cia.vc see them. http://cia.vc/stats/project/FreeCiv
- ML
Update of bug #13707 (project freeciv):
Category:None = general
Status:None = Fixed
Assigned to:None = cazfi
Open/Closed:
URL:
http://gna.org/bugs/?13860
Summary: [Patch] Scripting: create_base
Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 03:17
Category: None
Severity: 3 - Normal
Follow-up Comment #4, bug #13848 (project freeciv):
Some rules I was just reminded of:
- No more than 2 empty lines between any sections
in the code.
- #include the header corresponding to the current
c source file after all other headers.
Update of bug #13823 (project freeciv):
Status:None = Fixed
Assigned to:None = cazfi
Open/Closed:Open = Closed
URL:
http://gna.org/bugs/?13857
Summary: [Patch] Debian package building
Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 00:48
Category: None
Severity: 3 - Normal
Follow-up Comment #1, bug #13860 (project freeciv):
Are there rules for the included files, i.e. sort
them alphabetical?
+/* server */
+#include citytools.h
#include barbarian.h
+#include maphand.h
#include plrhand.h
-#include citytools.h
#include techtools.h
#include unittools.h
URL:
http://gna.org/bugs/?13859
Summary: [Patch] Gen-movement version of prohibiting units
in cities in the middle of non-native
Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 02:05
Category:
Update of bug #13863 (project freeciv):
Assigned to:None = cazfi
___
Reply to this item at:
http://gna.org/bugs/?13863
___
Message sent
URL:
http://gna.org/bugs/?13862
Summary: [Patch] Separate default.lua script.lua
Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 12:14
Category: general
Severity: 3 - Normal
URL:
http://gna.org/bugs/?13851
Summary: [Patch] Update wish list URL in TODO
Project: Freeciv
Submitted by: cazfi
Submitted on: Friday 07/03/2009 at 01:34
Category: docs
Severity: 3 - Normal
Update of bug #13735 (project freeciv):
Status:None = Fixed
Assigned to:None = cazfi
Open/Closed:Open = Closed
URL:
http://gna.org/bugs/?13858
Summary: [Patch] Move SINGLE_MOVE co to movement.h
Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 01:50
Category: None
Severity: 3 - Normal
Follow-up Comment #3, bug #13848 (project freeciv):
Could you add assert() rule that instead of
assert(FALSE) assert with more verbose error
message should be used when possible: [...]
There is the die() function which can be used
if the assert condition is not descriptive
enough. I'll add a
Follow-up Comment #5, bug #13848 (project freeciv):
Reason why I want case labels intendet is that having ending } as first
line starting at the same level as switch itself makes it easier to see at
one glance where current switch ends. My eyes (and brain) just work that
way :-)
Follow-up Comment #6, bug #13848 (project freeciv):
I discourage use of die() in most cases. I don't think CodingStyle should
advertise it.
Note that die() kills even release builds (those with NDEBUG) when assert()
does not. Of course failing assert() sometimes indicates problem that causes
Follow-up Comment #1, bug #13811 (project freeciv):
Some general notes:
- The #include shared.h in iterator.h can be
committed separately immediately if desired.
- The string vector header+implementation and
the changes in common/tech.c should be separate
patch submissions.
- Use 8 spaces
Update of bug #13834 (project freeciv):
Status:None = Fixed
Assigned to:None = cazfi
Open/Closed:Open = Closed
Follow-up Comment #2, bug #13811 (project freeciv):
- I suggest a shorter class name, e.g. 'strvec'.
This would also help to distinguish it from
vectors created with the specvec macro.
I renamed it str_vec, but it really looks ugly to me. I prefer the original
name. What about string_vec ?
Am Saturday 04 July 2009 18:10:58 schrieb Matthias Pfafferodt:
Hello,
does the list has hickups? I'm missing some emails about comments to
patches on gna since Thursday. The newest mail in the email archive is also
from Thursday
(https://mail.gna.org/public/freeciv-dev/2009-07/threads.html).
37 matches
Mail list logo
