[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #22, patch #1188 (project freeciv): Understood, thanks Marko. I wasn't sure what to check in order to follow your request on the dev list. I'll first check that link in the future. ___ Reply to this item at:

[Freeciv-Dev] [patch #1212] command key revamp (see also patch #1188)

Follow-up Comment #2, patch #1212 (project freeciv): > Compilation failed. Oops - thanks for catching that, Marko. Until I can get things set up for Windows, I'm editing blind... ___ Reply to this item at:

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #20, patch #1188 (project freeciv): Cool, thanks Marko! It feels cool to have my first patch integrated into Freeciv... I wasn't sure if you were going to wait to run "update-po" until after committing the patches for the other clients (#1211, #1212, #1213). But the four patch

[Freeciv-Dev] [bug #13931] implement reset command

Follow-up Comment #14, bug #13931 (project freeciv): Thanks for adding the release field, Daniel. It's at least useful for non-admins to see what the admins think for timing. Touching on my previous comment, is there a way that non-admin users can set bug/patch dependencies? It would be helpful

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #18, patch #1188 (project freeciv): Hi, Marko and Matthias. Thank you both again for taking time to review my patches and for your comments. I've created a new patch, which rolls both stages into a single patch. (I figured that this was less confusing than trying to keep the me

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #17, patch #1188 (project freeciv): > I use the new menu structure. It is a little bit strange first - I expect tax setting in the game menu. Speaking of my incorporating feedback, I'd definitely like to take the opportunity to learn your other feelings. This first round was ve

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #16, patch #1188 (project freeciv): > I use the new menu structure. It is a little bit strange first - I expect tax setting in the game menu. I can understand the initial confusion. I'd agree to an extent, since I myself am still not sure this is the most optimal structure - bu

[Freeciv-Dev] [bug #13931] implement reset command

Follow-up Comment #11, bug #13931 (project freeciv): > As written in [...] tickets can depend on each other > Perhaps such a meta ticket is possible? That would be great, though I haven't been able to figure out how to set dependencies in the Savane interface. Besides meta tickets, that would al

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #13, patch #1188 (project freeciv): Hi, Marko. Just wanted to check whether you still wanted me to modify the menu order, or if you were okay with the order as in my patches. As I said earlier, I'm happy to make your requested modifications now. As I mentioned below, my rationa

[Freeciv-Dev] [patch #1212] command key revamp (see also patch #1188)

URL: Summary: command key revamp (see also patch #1188) Project: Freeciv Submitted by: jkeller Submitted on: Saturday 08/01/2009 at 15:19 Category: client-win32 Priority: 5 - N

[Freeciv-Dev] [patch #1211] command key revamp (see also patch #1188)

URL: Summary: command key revamp (see also patch #1188) Project: Freeciv Submitted by: jkeller Submitted on: Saturday 08/01/2009 at 15:19 Category: client-sdl Priority: 5 - Nor

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #12, patch #1188 (project freeciv): I just submitted patches for the other clients: * patch #1211: SDL * patch #1212: Windows native * patch #1213: XAW These three bring the same changes to other clients as the files in this patch: * file #6194: (apply first) menu.c.01_reorg.di

[Freeciv-Dev] [patch #1213] command key revamp (see also patch #1188)

URL: Summary: command key revamp (see also patch #1188) Project: Freeciv Submitted by: jkeller Submitted on: Saturday 08/01/2009 at 15:19 Category: client-xaw Priority: 5 - Nor

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #11, patch #1188 (project freeciv): OK, I'll get patches together and put each one in a separate ticket, so that they can be reviewed independently. > - "Civilization" has general settings affecting your whole > civilization, yet it is next to last menu. I would move it > secon

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #9, patch #1188 (project freeciv): Excuse me, I must have a tired brain. I meant "2.2" where I wrote "2.1" in my previous comment... i.e. hoping to get these changes into 2.2 before it's branched. ___ Reply to this item

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #8, patch #1188 (project freeciv): Wow, Marco. Thanks for the willingness to experiment! I definitely understand and respect not wanting to make different key usage in different clients. I tried to make these changes logical and at the same time not too disruptive (I don't thi

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #6, patch #1188 (project freeciv): Glad to hear the patches worked for you, Marko! I had split the patch into two patches in order to avoid "noise" created by the renaming. That makes it possible to see the basic restructuring ("menu.c.01_reorg.diff") and the (necessary) refine

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #3, patch #1188 (project freeciv): Huh, that's odd. menu.c hasn't changed since I made the patches. Maybe I made an error? Which patch doesn't work? Did you apply them in order? ("menu.c.01_reorg.diff", "menu.c.02_accels_revised.diff", then "helpdata.txt.diff") "menu.c.02_acce

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

Follow-up Comment #7, bug #13843 (project freeciv): OK, that makes sense - much better to fix the problem deeper down. Shows how much I have to learn about the depths of the code. :-) Still, I can't help but wonder: can_units_do_base() and can_units_do_base_gui() return essentially the same info

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

Follow-up Comment #5, bug #13843 (project freeciv): Sorry, Marko. I suppose I should have given more info so that you could reproduce. Steps: * with a unit capable of it, build a fortress (either with new "Build Base > Fortress" or with old "Build Fortress") * after fortress is built, now look a

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #1, patch #1188 (project freeciv): Oops - already a fix... "menu.c.02_accels_revised.diff" replaces "menu.c.02_accels.diff" The previous version of the patch didn't correctly set the sensitivity of "Unload All From Transporter". As long as I'm here, here's the bulleted list c

[Freeciv-Dev] menu & accelerator revamp, and next steps

Hooray for a working bug/patch tracker! I've submitted a renewed and revised version of my proposed menu+command revamp. I've even used the patch tracker (second patch in there) per the previous discussion for non-bug tickets. You can find my full explanation and the patches in patch #1188. Thi

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

URL: Summary: proposed menu and command key revamp Project: Freeciv Submitted by: jkeller Submitted on: Saturday 07/11/2009 at 16:56 Category: None Priority: 5 - Normal

[Freeciv-Dev] [bug #13867] [patch 01/07] get game settings via wrapper functions

Follow-up Comment #4, bug #13867 (project freeciv): Ah, oops - my apologies for the noise. I really should have read the patch before sounding off (since I clearly misunderstood the translation tags as being used for static text rather than calculated text). :-p [Still... it's unfortunate that

[Freeciv-Dev] [bug #13867] [patch 01/07] get game settings via wrapper functions

Follow-up Comment #2, bug #13867 (project freeciv): > Using '_()' within the setting_*() functions is not > done because the some callers need the untranslated > string (see stdinhand.c:send_server_setting()). Wouldn't it be better, then, to use N_() instead of simply dropping _() ? This chang

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

Follow-up Comment #3, bug #13843 (project freeciv): Thanks for taking the time to explain more in-depth, Marko! That really helps me to understand the context. I've make changes to my (upcoming) menu reorg patch. I have some better ideas, but for now I punted too and left the menu as-is. :-) On

Re: [Freeciv-Dev] Patch tracker

Daniel Markstedt wrote: > On Tue, Jul 7, 2009 at 11:41 PM, Marko Lindqvist wrote: >> 2009/7/8 John Keller : >>> Patch-for-bug vs. patch-for-new feature might seem clear to those >>> involved for a time, >> The fact it's sometimes hard to say if patch is ne

Re: [Freeciv-Dev] Patch tracker

Daniel Markstedt wrote: > I've noticed numerous bugs with the [patch] tags in the gna bug > tracker. Just though it'd mention, if you haven't noticed already, > that there's a separate patch tracker available at > https://gna.org/patch/?group=freeciv > > Do you think we'd use it, or shall I just c

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

Follow-up Comment #1, bug #13843 (project freeciv): I'm sorry I'm posting after this bug is closed, but it's of interest to me. I'm in the middle of redoing a menu layout change that I originally submitted about a year ago. Would you be able to go into a bit more depth about why this path moves

Re: [Freeciv-Dev] (PR#40228) Lone "And, became more experienced!" -message

Marko Lindqvist wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=40228 > > > S2_2 > > After successful attack, Messages tab shows: > "Start of turn 2" > "And, became more experienced!" > > > "And, became more experienced" has event type separate from the > 'parent' message. So it's

[Freeciv-Dev] wrong NEWS linked to from wiki front page

Just thought I'd let someone know: the release announcement from 21 April on the wiki front page links to NEWS-2.1.3 instead of NEWS-2.1.4. I'm not sure if this list is the best place to post that, but I figured I'd give it a try... - John ___ Freeciv-

Re: [Freeciv-Dev] (PR#40216) Re: [patch] proposed menu restructuring

Hi, Ulrik. Sorry about replying on-list, you'll see why below. Ulrik Sverdrup wrote: > Forwarding the patches too, as they seemed to be missing. > > John, this is a very good proposition. I'll try to look at it. Cool, thanks! I'm hoping to make it a first of many... > And -- you can create tick

Re: [Freeciv-Dev] [patch] proposed menu restructuring

Daniel Markstedt wrote: > On 4/27/08, John Keller <[EMAIL PROTECTED]> wrote: >> [...] >> >> >> I'd be interested in people's reactions to these patches. Hopefully they >> (or something like them) could eventually make their way into Freeciv. >

Re: [Freeciv-Dev] [patch] proposed menu restructuring

Marko Lindqvist wrote: > Forwading to request tracker (and thus creating new ticket) for > storing the patches. We don't want them to get lost and forgotten. > > John: If you have something to add, please try to reply to the copy > RT sends to the list. Gah, my previous reply-to opened a ticket.

[Freeciv-Dev] (PR#40217) Re: [patch] proposed menu restructuring

http://bugs.freeciv.org/Ticket/Display.html?id=40217 > Marko Lindqvist wrote: > Forwading to request tracker (and thus creating new ticket) for > storing the patches. We don't want them to get lost and forgotten. > > John: If you have something to add, please try to reply to the copy > RT sends

Re: [Freeciv-Dev] [patch] proposed menu restructuring

John Keller wrote: > I renamed the "Reports" menu to "Civilization". Freeciv isn't a > spreadsheet [2], but this menu roughly corresponds to the "Window" menu > [2] http://bugs.freeciv.org/Ticket/Display.html#txn-238668 Oops, I meant: [2] http://b

[Freeciv-Dev] can't add comments to any tickets in RT

Sorry for an email to the whole list. It's been a while, so I wasn't sure who was best to write. And I can't use the RT ticket system for this bug since the problem is in the system itself... :-p I have my own account on RT. I can submit a new ticket via email (and maybe via the web interface, but

[Freeciv-Dev] (PR#40102) testing

http://bugs.freeciv.org/Ticket/Display.html?id=40102 > Please ignore this ticket. I'm trying to see if I'm able to open new tickets by email again (was broken for me last I tried)... ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.o

Re: [Freeciv-Dev] (PR#39593) trunk: can't select Amplio or most other tilesets

Christian Prochaska wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=39593 > > >> [jkeller - Mo 20. Aug 2007, 16:10:26]: >> >> I play svn trunk, and am at revision 13359. I always upgrade by doing >> "make clean", "svn up", "./autogen.sh --prefix=[path to dir in my home]" >> before "make" a

[Freeciv-Dev] tileset (esp. Amplio) problems in trunk?

I've checked the list and tickets, and couldn't find anything that seemed to fit. Apologies if this was already covered under some other subject. I haven't been able to select any but the basic tilesets (isotrident, trident, isophex, and hex2t) in trunk for some time. I usually do a "make clean" +

[Freeciv-Dev] Message not recorded [was (PR#39673) Can't buy anything!]

G... (original message below) - John > Permission Denied > > > > Arman Ordookhani wrote: >> > http://bugs.freeciv.org/Ticket/Display.html?id=39673 > >> > >> > I can't buy anything >> > Progressbar of production is always full >> > Governor always shows `Production completed: 1 turn' >> >

Re: [Freeciv-Dev] RT problems?

Christian Prochaska wrote: > On 9/4/07, John Keller <[EMAIL PROTECTED]> wrote: >> The weird thing is that I added a comment yesterday to PR#39662 ("Build >> cost always shown as '1' for current production"). >> >> It still hasn't sh

Re: [Freeciv-Dev] RT problems?

Marko Lindqvist wrote: > On 04/09/07, Per I. Mathisen wrote: >> On Mon, 3 Sep 2007, Marko Lindqvist wrote: It seems to me that we have problems with this list. Could RT be the reason of delaying messages? Can anyone look? >>> My experience is that mails about new tickets are not coming t

[Freeciv-Dev] (PR#39593) trunk: can't select Amplio or most other tilesets

http://bugs.freeciv.org/Ticket/Display.html?id=39593 > I play svn trunk, and am at revision 13359. I always upgrade by doing "make clean", "svn up", "./autogen.sh --prefix=[path to dir in my home]" before "make" and "make install". I'm not sure if this is the result of ongoing work for terrain,

[Freeciv-Dev] (PR#39592) trunk: can't buy item being produced

http://bugs.freeciv.org/Ticket/Display.html?id=39592 > I play svn trunk, and am at revision 13359. I always upgrade by doing "make clean", "svn up" and then "./autogen.sh --prefix=[path to dir in my home]". Production always shows "xxx/1" in the city report page or popup dialog, though the numbe