Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-27 Thread Pierre Ossman
Duncan Webb wrote: Regular expressions are generally a bad thing for programs, other than being difficult to read and so hard to maintain, they do tend to cause problems over time. For example just parsing the version string from mplayer, xine and xmame cause problems so mplayer and xine

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-23 Thread Duncan Webb
Pierre Ossman wrote: Duncan Webb wrote: It is a great idea to use the event driver in freevo, I said that before, and it's something we should definitely have. This is exactly the way, that I would like the event driver to work. There are too many different kernels out there that I think

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-22 Thread Pierre Ossman
Duncan Webb wrote: It is a great idea to use the event driver in freevo, I said that before, and it's something we should definitely have. This is exactly the way, that I would like the event driver to work. There are too many different kernels out there that I think parsing the

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread Pierre Ossman
Duncan Webb wrote: What about writing a helper to generate the correct stuff that can then be merged into local_conf.py, a bit like convert_config.py. This way the everything is set up once and no parsing is required at run time. There's evdev._print_tables() that generates python code for

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread Pierre Ossman
Justin Wetherell wrote: Im not sure which input.h you need but here is mine from: /usr/include/linux/input.h Ah, you have a broken input.h. It hasn't been stripped of in-kernel definitions. Still, the parser should be more forgiving. I'll see what can be done. Rgds -- -- Pierre Ossman

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread Duncan Webb
Pierre Ossman wrote: Duncan Webb wrote: What about writing a helper to generate the correct stuff that can then be merged into local_conf.py, a bit like convert_config.py. This way the everything is set up once and no parsing is required at run time. There's evdev._print_tables() that

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread Pierre Ossman
Duncan Webb wrote: Pierre Ossman wrote: News to me, but I'm no lirc expert. Still, that's one extra dependency for something we can do directly. No extra dependency as lirc is already supported It is for the user as he could (with this patch) have his evdev device supported with just the

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread Rob Shortt
Pierre Ossman wrote: Duncan Webb wrote: Pierre Ossman wrote: News to me, but I'm no lirc expert. Still, that's one extra dependency for something we can do directly. No extra dependency as lirc is already supported It is for the user as he could (with this patch) have his evdev device

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread Jason Tackaberry
On Sat, 2006-10-21 at 20:26 -0300, Rob Shortt wrote: an aweful state. Instead of things going into the kernel, development on lirc continued and I guess got a little better (correct me if I'm wrong). I can say that with multiple IR devices, lirc has improved significantly. Before I had to do

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread TC Wan
Duncan wrote: Pierre Ossman wrote: Sorry Pierre, I can't accept this patch as it stands because it parses linux/input.h, which requires that kernel headers are installed. I have reversed the patches from rel-1-6 and rel-1 There must be a better way to do this without this dependency. Duncan

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread Rob Shortt
Jason Tackaberry wrote: On Sat, 2006-10-21 at 20:26 -0300, Rob Shortt wrote: an aweful state. Instead of things going into the kernel, development on lirc continued and I guess got a little better (correct me if I'm wrong). I can say that with multiple IR devices, lirc has improved

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread TC Wan
Rob Shortt wrote: Lirc drives me nuts and I'd rather not use it at all. :) On my main Freevo box running 2.0 I use DirectFB for input, but used to use the event device plugin before that. On one box here I am forced to use lirc since that is the only thing that supports my serial IR receiver.

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread Rob Shortt
TC Wan wrote: The problem I'm having right now is that the event driver enumeration seems to have changed for 2.6.18 (in 2.6.18, the PC speaker has become a new input source??! What's this?). I usually get my IR remote as input3, sometimes as input2. This breaks lirc and probably will affect

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-21 Thread Duncan Webb
TC Wan wrote: Duncan wrote: Pierre Ossman wrote: Sorry Pierre, I can't accept this patch as it stands because it parses linux/input.h, which requires that kernel headers are installed. I have reversed the patches from rel-1-6 and rel-1 There must be a better way to do this without this

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-20 Thread Pierre Ossman
Duncan Webb wrote: Pierre Ossman wrote: Sorry Pierre, I can't accept this patch as it stands because it parses linux/input.h, which requires that kernel headers are installed. I have reversed the patches from rel-1-6 and rel-1 There must be a better way to do this without this

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-20 Thread Duncan Webb
Pierre Ossman wrote: Duncan Webb wrote: Pierre Ossman wrote: Sorry Pierre, I can't accept this patch as it stands because it parses linux/input.h, which requires that kernel headers are installed. I have reversed the patches from rel-1-6 and rel-1 There must be a better way to do this

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-20 Thread Pierre Ossman
Duncan Webb wrote: I think that event support is a great feature but I needs to be very robust if it is being called from rc.py. I'm more that happy to put this back when we have a better solution. Well if it's not in the tree, then it's difficult to submit proper patches to fix problems.

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-20 Thread Justin Wetherell
Im not sure which input.h you need but here is mine from: /usr/include/linux/input.hOn 10/20/06, Pierre Ossman [EMAIL PROTECTED] wrote:Duncan Webb wrote: I think that event support is a great feature but I needs to be very robust if it is being called from rc.py. I'm more that happy to put

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-20 Thread Duncan Webb
Pierre Ossman wrote: Duncan Webb wrote: I think that event support is a great feature but I needs to be very robust if it is being called from rc.py. I'm more that happy to put this back when we have a better solution. Well if it's not in the tree, then it's difficult to submit proper

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-19 Thread Duncan Webb
Pierre Ossman wrote: Sorry Pierre, I can't accept this patch as it stands because it parses linux/input.h, which requires that kernel headers are installed. I have reversed the patches from rel-1-6 and rel-1 There must be a better way to do this without this dependency. Duncan As I recently

[Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Pierre Ossman
As I recently bought an ATI remote control, I felt that Freevo really lacked good support for Linux event devices. So I decided to add it. :) Included is a patch that adds that support, relevant configuration options and a default key map that should handle most devices out there. Comparison

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Rob Shortt
Hi, Pierre Ossman wrote: As I recently bought an ATI remote control, I felt that Freevo really lacked good support for Linux event devices. So I decided to add it. :) Included is a patch that adds that support, relevant configuration options and a default key map that should handle most

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Pierre Ossman
Rob Shortt wrote: This is for Freevo 1.x right? There is basic evdev support on the 2.0 trunk in SVN in the form of an input plugin. Yup, it's 1.x. I haven't dared try 2.0 yet as, judging from the wiki, it doesn't have basic functionality yet. I agree, using the event device is great,

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Duncan Webb
Pierre Ossman wrote: As I recently bought an ATI remote control, I felt that Freevo really lacked good support for Linux event devices. So I decided to add it. :) Included is a patch that adds that support, relevant configuration options and a default key map that should handle most devices

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Hans Meine
Hi Duncan! On Tuesday 17 October 2006 17:18, Duncan Webb wrote: I shouldn't apply this patch in 1.6, but it may be too important to exclude. So I have done. Is this related to that patch? [EMAIL PROTECTED]:/usr/src/freevo-1.5svn/freevo - freevo cache Traceback (most recent call last): File

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Hans Meine
On Tuesday 17 October 2006 20:04, Hans Meine wrote: Is this related to that patch? [EMAIL PROTECTED]:/usr/src/freevo-1.5svn/freevo - freevo cache Traceback (most recent call last): File /usr/lib/python2.4/site-packages/freevo/helpers/cache.py, line 57, in ? import config File

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Pierre Ossman
Hans Meine wrote: Hi Duncan! On Tuesday 17 October 2006 17:18, Duncan Webb wrote: I shouldn't apply this patch in 1.6, but it may be too important to exclude. So I have done. Is this related to that patch? [EMAIL PROTECTED]:/usr/src/freevo-1.5svn/freevo - freevo cache Traceback (most

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Duncan Webb
Pierre Ossman wrote: Hans Meine wrote: Hi Duncan! On Tuesday 17 October 2006 17:18, Duncan Webb wrote: I shouldn't apply this patch in 1.6, but it may be too important to exclude. So I have done. Is this related to that patch? [EMAIL PROTECTED]:/usr/src/freevo-1.5svn/freevo - freevo cache

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Duncan Webb
Hans Meine wrote: On Tuesday 17 October 2006 20:04, Hans Meine wrote: Is this related to that patch? [EMAIL PROTECTED]:/usr/src/freevo-1.5svn/freevo - freevo cache Traceback (most recent call last): File /usr/lib/python2.4/site-packages/freevo/helpers/cache.py, line 57, in ? import

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Pierre Ossman
Duncan Webb wrote: I've now merged all the 1.6 changes into rel-1 and added to rel-1 the encoding server and apple trailers for people to play with. Very nice. But you should probably change the comment at the top of appletrailers.py as it is incorrect now that it's in src/plugins (and not

Re: [Freevo-devel] [PATCH] Linux event device support

2006-10-17 Thread Duncan Webb
Pierre Ossman wrote: Duncan Webb wrote: I've now merged all the 1.6 changes into rel-1 and added to rel-1 the encoding server and apple trailers for people to play with. Very nice. But you should probably change the comment at the top of appletrailers.py as it is incorrect now that it's in