Re: [Ganglia-developers] Granted Matthias SVN access

2008-01-24 Thread Bernard Li
Hi Brad: On 1/24/08, Brad Nicholes <[EMAIL PROTECTED]> wrote: > I was wondering what the process is for granting somebody commit rights and > also wondering why Matthias didn't already have rights. > > Maybe as an agenda item during our meet-up at the end of Feb., we can discuss > what the proc

Re: [Ganglia-developers] Granted Matthias SVN access

2008-01-24 Thread Brad Nicholes
>>> On 1/24/2008 at 1:48 PM, in message <[EMAIL PROTECTED]>, Matthias Blankenhaus <[EMAIL PROTECTED]> wrote: > > On Thu, 24 Jan 2008, Bernard Li wrote: > >> Dear all: >> >> Just a quick note letting you guys know that I have just granted >> Matthias SVN access to our tree. I expect great pat

Re: [Ganglia-developers] Granted Matthias SVN access

2008-01-24 Thread Matthias Blankenhaus
On Thu, 24 Jan 2008, Bernard Li wrote: > Dear all: > > Just a quick note letting you guys know that I have just granted > Matthias SVN access to our tree. I expect great patches and check-ins > from him :-) > > Welcome! Bernard and all ! Thank you very much for welcoming me to the Ganglia c

[Ganglia-developers] Granted Matthias SVN access

2008-01-24 Thread Bernard Li
Dear all: Just a quick note letting you guys know that I have just granted Matthias SVN access to our tree. I expect great patches and check-ins from him :-) Welcome! Cheers, Bernard - This SF.net email is sponsored by: M

Re: [Ganglia-developers] module metric spoofing (for IPMI module)

2008-01-24 Thread Matthias Blankenhaus
On Thu, 24 Jan 2008, Brad Nicholes wrote: > No, this is a bug. Ganglia_collection_group_send() should be using the > passed in 'now' parameter rather than redefining its own. By using the > passed in 'now' parameter, both collection and sending will be using the same > time interval which

Re: [Ganglia-developers] module metric spoofing (for IPMI module)

2008-01-24 Thread Brad Nicholes
No, this is a bug. Ganglia_collection_group_send() should be using the passed in 'now' parameter rather than redefining its own. By using the passed in 'now' parameter, both collection and sending will be using the same time interval which is defined during the main() iteration loop. As it

Re: [Ganglia-developers] module metric spoofing (for IPMI module)

2008-01-24 Thread Matthias Blankenhaus
On Thu, 24 Jan 2008, Brad Nicholes wrote: > I like your plan. It is easier to review smaller patches that deal with > specific parts of the overall feature, than it is to try to wrap your head > around one big patch. I would suggest that you go with the smaller patches. > > Brad > Excellent.

Re: [Ganglia-developers] module metric spoofing (for IPMI module)

2008-01-24 Thread Brad Nicholes
>>> On 1/23/2008 at 11:23 PM, in message <[EMAIL PROTECTED]>, Matthias Blankenhaus <[EMAIL PROTECTED]> wrote: > Howdy ! > > As announced during our last meeting in SF I finally started to work on > this module. Came out that I need to extend gmond and the module area > a bit in order to support