Re: [2/5] C-SKY port v3: Backend implementation

2018-08-16 Thread Jeff Law
On 08/05/2018 10:34 PM, Sandra Loosemore wrote: > > csky-gcc-2.log > > > 2018-08-05 Jojo > Huibin Wang > Sandra Loosemore > Chung-Lin Tang > > C-SKY port: Backend implementation > > gcc/ > * config/csky/*: New. > *

Re: [PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-08-16 Thread Andrew Pinski
On Thu, Aug 16, 2018 at 9:29 PM Omar Sandoval wrote: > > Hi, > > This fixes the issue that it is impossible to distinguish a zero-length array > type from a flexible array type given the DWARF produced by GCC (which I > reported here [1]). We do so by adding a DW_AT_count attribute with a value

[Bug debug/86985] Generated DWARF does not distinguish between zero-length and flexible array types

2018-08-16 Thread osandov at osandov dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86985 --- Comment #3 from Omar Sandoval --- They are not equivalent in GCC, see https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html. In particular, flexible arrays cannot be the only member in a struct, cannot be a member of a union, cannot be used as

[Bug debug/86985] Generated DWARF does not distinguish between zero-length and flexible array types

2018-08-16 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86985 --- Comment #2 from Andrew Pinski --- Considering GCC considers zero length array as the same as flexible array types, I don't think this is really an issue. >this fails in some cases where zero-length and flexible array types are not

Re: PING [PATCH] warn for strlen of arrays with missing nul (PR 86552, 86711, 86714) )

2018-08-16 Thread Jeff Law
On 08/01/2018 08:44 PM, Martin Sebor wrote: > Since the foundation of the patch is detecting and avoiding > the overly aggressive folding of unterminated char arrays, > besides issuing a warning for such arguments to strlen, > the patch also fixes pr86711 - wrong folding of memchr, and > pr86714 -

Re: [PATCH] Make strlen range computations more conservative

2018-08-16 Thread Jeff Law
On 08/09/2018 12:27 AM, Richard Biener wrote: > On August 9, 2018 7:26:19 AM GMT+02:00, Jeff Law wrote: >> On 07/24/2018 05:18 PM, Bernd Edlinger wrote: >>> On 07/24/18 23:46, Jeff Law wrote: On 07/24/2018 01:59 AM, Bernd Edlinger wrote: > Hi! > > This patch makes strlen range

Re: [PATCH, Darwin] Move fixed _Unwind_find_Enclosing_func to a crt.

2018-08-16 Thread Jeff Law
On 08/15/2018 12:50 PM, Iain Sandoe wrote: > Hi, > > This is a pre-cursor to other tidy-ups aimed at being able to dispense with > the “ext” library that we introduced (a lng time ago) to deal with the > differences between Darwin’s installed libgcc_s and the current compiler. > > Since

Re: [PATCH] Check the STRING_CSTs in varasm.c

2018-08-16 Thread Jeff Law
On 08/05/2018 04:28 AM, Bernd Edlinger wrote: > Hi, > > I would like to do a minor tweak to the patch. > While staring at the other patch I realized that I should > better pass size and not thissize to the check > function, instead of making use of how thissize is > computed using MIN above.

[Bug debug/86985] Generated DWARF does not distinguish between zero-length and flexible array types

2018-08-16 Thread osandov at osandov dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86985 --- Comment #1 from Omar Sandoval --- Posted a patch here: https://gcc.gnu.org/ml/gcc-patches/2018-08/msg00994.html.

[Bug c++/86986] New: Unexpected errors for template parameter pack in a template template parameter

2018-08-16 Thread v.reshetnikov at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86986 Bug ID: 86986 Summary: Unexpected errors for template parameter pack in a template template parameter Product: gcc Version: 9.0 Status: UNCONFIRMED Severity:

[PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-08-16 Thread Omar Sandoval
Hi, This fixes the issue that it is impossible to distinguish a zero-length array type from a flexible array type given the DWARF produced by GCC (which I reported here [1]). We do so by adding a DW_AT_count attribute with a value of zero only for zero-length arrays (this is what clang does in

[Bug debug/86985] New: https://gcc.gnu.org/bugzilla/enter_bug.cgi?product=gcc

2018-08-16 Thread osandov at osandov dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86985 Bug ID: 86985 Summary: https://gcc.gnu.org/bugzilla/enter_bug.cgi?product=gcc Product: gcc Version: unknown Status: UNCONFIRMED Severity: normal Priority: P3

Re: [PATCH] v2: Formatted printing for dump_* in the middle-end

2018-08-16 Thread Jeff Law
On 08/02/2018 11:54 AM, David Malcolm wrote: > On Tue, 2018-07-31 at 19:56 +, Joseph Myers wrote: >> On Tue, 31 Jul 2018, David Malcolm wrote: >> >>> I didn't exhaustively check every callsite to the changed calls; >>> I'm >>> assuming that -Wformat during bootstrap has effectively checked >>>

[Bug tree-optimization/86853] sprintf optimization for wide strings doesn't account for conversion failure

2018-08-16 Thread law at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86853 --- Comment #2 from Jeffrey A. Law --- Author: law Date: Fri Aug 17 04:01:14 2018 New Revision: 263612 URL: https://gcc.gnu.org/viewcvs?rev=263612=gcc=rev Log: gcc/ChangeLog: PR tree-optimization/86853 * gimple-ssa-sprintf.c

Re: [PATCH] assume sprintf formatting of wide characters may fail (PR 86853)

2018-08-16 Thread Jeff Law
On 08/04/2018 12:46 PM, Martin Sebor wrote: > The sprintf handling of wide characters neglects to consider > that calling the function may fail due to a conversion error > (when the wide character is invalid or not representable in > the current locale).  The handling also misinterprets > the 

[Bug c++/16166] -Weffc++ finer granularity

2018-08-16 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16166 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org ---

C++ PATCH for c++/67012, c++/86942, detect invalid cases with function return type deduction

2018-08-16 Thread Marek Polacek
As I promised in , this patch fixes a couple of invalid cases we weren't detecting. It's got testcases from two PRs and another case I found out; they're intertwined so I think it makes sense to fix them in one go. Bootstrapped/regtested

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-16 Thread Jeff Law
On 08/16/2018 05:01 PM, Joseph Myers wrote: > On Thu, 16 Aug 2018, Jeff Law wrote: > >> restores previous behavior. The sprintf bits want to count element >> sized chunks, which for wchars is 4 bytes (that count will then be > >>/* Compute the range the argument's length can be in. */ >> -

[Bug c++/86980] Lambda function with return type rvalue reference dtor issue

2018-08-16 Thread neeraj.sharma at alumni dot iitg.ernet.in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86980 --- Comment #3 from Neeraj --- Ah! Alright so the following two code snippets are equivalent. // -- auto f = []() { Traceable tmp; return std::move(tmp); }; // --- auto f = []() -> Traceable { Traceable

[Bug fortran/84539] ICE and segfault with assignment to CLASS(*) array

2018-08-16 Thread neil.n.carlson at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84539 --- Comment #4 from Neil Carlson --- Update with 8.2.0 The ICE is gone, but a run time segfault remains: Program received signal SIGSEGV: Segmentation fault - invalid memory reference. Backtrace for this error: #0 0x7f82986c06df in ??? #1

Re: [PATCH, RFC, rs6000, v2] folding of vec_splat

2018-08-16 Thread Will Schmidt
On Thu, 2018-08-16 at 15:51 -0500, Segher Boessenkool wrote: > Hi Will, > > On Thu, Aug 16, 2018 at 10:50:45AM -0500, Will Schmidt wrote: > > 2018-08-16 Will Schmidt > > > > * config/rs6000/rs6000.c (rs6000_gimple_fold_builtin): Add support for > > early gimple folding of

[Bug target/86984] invalid relocation accessing a const char arrray

2018-08-16 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86984 --- Comment #2 from Martin Sebor --- The excessive offset appears in the first RTL dump: $ grep -A3 -B3 2305843009213693936 plural.c.230r.expand (insn 87 86 88 10 (set (reg:DI 154) (lshiftrt:DI (reg:DI 155) (const_int 3

[Bug target/86984] invalid relocation accessing a const char arrray

2018-08-16 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86984 --- Comment #1 from Martin Sebor --- Created attachment 44552 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=44552=edit Reduced test case. Compiling the attached test case shows the invalid offsets in the assembly: $ gcc -S -O2 -Wall

[Bug target/86984] New: invalid relocation accessing a const char arrray

2018-08-16 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86984 Bug ID: 86984 Summary: invalid relocation accessing a const char arrray Product: gcc Version: 9.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component:

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-16 Thread Joseph Myers
On Thu, 16 Aug 2018, Jeff Law wrote: > restores previous behavior. The sprintf bits want to count element > sized chunks, which for wchars is 4 bytes (that count will then be >/* Compute the range the argument's length can be in. */ > - fmtresult slen = get_string_length (arg); > + int

Re: [PATCH] assume sprintf formatting of wide characters may fail (PR 86853)

2018-08-16 Thread Jeff Law
On 08/09/2018 01:29 PM, Bernd Edlinger wrote: >>> + bool one_2_one_ascii >>> + = (target_to_host_charmap[0] == 1 && target_to_host ('a') == >>> 97); >> Hmm. Is this really sufficient?I have nowhere near enough knowledge >> of the potential target character sets to know if

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-16 Thread Jeff Law
On 08/14/2018 04:25 AM, Bernd Edlinger wrote: > 2018-08-14 Bernd Edlinger > > * builtins.c (c_strlen): Add new parameter eltsize. > * builtins.h (c_strlen): Adjust prototype. > * expr.c (string_constant): Add new parameter mem_size. > * expr.h (string_constant): Adjust

gcc-7-20180816 is now available

2018-08-16 Thread gccadmin
Snapshot gcc-7-20180816 is now available on ftp://gcc.gnu.org/pub/gcc/snapshots/7-20180816/ and on various mirrors, see http://gcc.gnu.org/mirrors.html for details. This snapshot has been generated from the GCC 7 SVN branch with the following options: svn://gcc.gnu.org/svn/gcc/branches/gcc-7

[committed] diagnostics: fix bad interaction between line spans and line numbers

2018-08-16 Thread David Malcolm
Without this patch, the "line span" markers and the line numbering interacted badly, leading to stray copies of the line-span markers appearing as prefixes on the first source line in a span: missing-header-fixit-3.c: In function 'test': missing-header-fixit-3.c:9:3: warning: implicit declaration

[Bug c++/67906] Missing warning about std::move without effect

2018-08-16 Thread virkony at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67906 --- Comment #9 from Nikolay Orliuk --- Yes. Return value optimization blocked by abusing std::move also close. Somehow I had feeling that I saw something similar from gcc in pre-C++11 times. Regarding sample: struct X { X() { } X(const X&)

[committed] diagnostics: tweak to line-insertion fix-it hints with line-numbering

2018-08-16 Thread David Malcolm
This commit slightly tweaks line-insertion fix-it hints, so that with line-numbering, rather than e.g.: 99 | x = a; |+ break; 110 | case 'b': | ^~~~ we fill the margin with "+": 99 | x = a; +++ |+ break; 110 | case 'b': | ^~~~ to

Re: [ARM/FDPIC v2 00/21] FDPIC ABI for ARM

2018-08-16 Thread Christophe Lyon
Ping? Le mer. 1 août 2018 à 10:03, Christophe Lyon a écrit : > Ping? > > > On 13/07/2018 18:10, christophe.l...@st.com wrote: > > From: Christophe Lyon > > > > Hello, > > > > This patch series implements the GCC contribution of the FDPIC ABI for > > ARM targets. > > > > This ABI enables to run

[Bug c++/86094] [8/9 Regression] Call ABI changed for small objects with defaulted ctor

2018-08-16 Thread a3at.mail at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86094 Azat changed: What|Removed |Added CC||a3at.mail at gmail dot com --- Comment #12 from

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-16 Thread Bernd Edlinger
On 08/16/18 23:27, Jeff Law wrote: > On 08/16/2018 12:47 PM, Bernd Edlinger wrote: > > Parameterizing the function to return either the number of > bytes or the number of elements makes sense as an enhancement. > It makes less sense (and could be the source of bugs) to let >

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-16 Thread Jeff Law
On 08/16/2018 12:47 PM, Bernd Edlinger wrote: Parameterizing the function to return either the number of bytes or the number of elements makes sense as an enhancement. It makes less sense (and could be the source of bugs) to let callers pass in anything else.  A boolean flag

[Bug target/84438] Another code pattern that breaks PDP11 with -m10: including reproducer code

2018-08-16 Thread cptjustice at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84438 Patrick Conlon changed: What|Removed |Added CC||cptjustice at gmail dot com ---

[Bug target/84437] long long casting breaks PDP-11 with -m10 model option (includes trivial reproducer)

2018-08-16 Thread cptjustice at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84437 Patrick Conlon changed: What|Removed |Added CC||cptjustice at gmail dot com ---

[Bug rtl-optimization/59942] pdp11-aout-gcc: PDP-11/10 code generation crashes when trying to do multiple shifts.

2018-08-16 Thread cptjustice at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59942 Patrick Conlon changed: What|Removed |Added CC||cptjustice at gmail dot com ---

Re: [PATCH, RFC, rs6000, v2] folding of vec_splat

2018-08-16 Thread Segher Boessenkool
Hi Will, On Thu, Aug 16, 2018 at 10:50:45AM -0500, Will Schmidt wrote: > 2018-08-16 Will Schmidt > > * config/rs6000/rs6000.c (rs6000_gimple_fold_builtin): Add support for > early gimple folding of vec_splat(). Continuation lines should be indented to the *, not to the text

Re: [PATCH, Darwin, drivers] Split DWARF is not supported on Darwin.

2018-08-16 Thread Mike Stump
On Aug 16, 2018, at 6:55 AM, Iain Sandoe wrote: > > The Darwin toolchains have a separate debug linker (dsymutil) so that the > link-time penalty for debug data is not usually seen. At present, it's not > clear how we would support split DWARF on Darwin (or if it would bring > any additional

[Bug target/59847] cast to long makes compiler crash if using option pdp-11/10

2018-08-16 Thread cptjustice at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59847 Patrick Conlon changed: What|Removed |Added CC||cptjustice at gmail dot com ---

[Bug tree-optimization/78257] missing memcmp optimization with constant arrays

2018-08-16 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78257 --- Comment #8 from Martin Sebor --- With r263561 brace-enclosed initializers for constant character arrays are handled by transforming them into STRING_CSTs. It should be possible to also handle wide character types (wchar_t, char16_t,

[Bug target/86592] [9 regression] gcc.target/powerpc/p8-vec-xl-xst-v2.c fails starting with r261510

2018-08-16 Thread willschm at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86592 --- Comment #1 from Will Schmidt --- This should have cleared up once the gimple-folding support for unaligned loads and stores went in, and the instruction counts settled on the expected values. commit

[Bug c/86983] New: documentation inconsistent with always_inline diagnostics for computed goto

2018-08-16 Thread richard-gccbugzilla at metafoo dot co.uk
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86983 Bug ID: 86983 Summary: documentation inconsistent with always_inline diagnostics for computed goto Product: gcc Version: unknown Status: UNCONFIRMED Severity:

[PATCH] RFC: reduce likelihood of fully-dynamic-string throwing on move

2018-08-16 Thread Jonathan Wakely
With --enable-fully-dynamic-string the COW basic_string move constructor is noexcept(false), because it has to allocate a new empty rep for the moved-from string. If we did this, it would only throw when the string we're moving from is "leaked" (that is, there are potentially pointers,

[Bug libstdc++/31413] FAIL: 22_locale/time_get/get_date/wchar_t/4.cc execution test

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=31413 --- Comment #26 from Jonathan Wakely --- This still fails on any Debian system, such as gcc20 in the compile farm. I'd like to either make it pass, or add dg-xfail-if or dg-skip-if to the test. Paolo, do you remember if this testcase was

[Bug testsuite/86519] [9 Regression] New test case gcc.dg/strcmpopt_6.c fails with its introduction in r262636

2018-08-16 Thread ro at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86519 Rainer Orth changed: What|Removed |Added CC||ro at gcc dot gnu.org --- Comment #18

[Bug libstdc++/71641] 22_locale/time_get/get_date/wchar_t/4.cc runs failure if static linking

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71641 Jonathan Wakely changed: What|Removed |Added See Also||https://gcc.gnu.org/bugzill

[Bug libstdc++/31413] FAIL: 22_locale/time_get/get_date/wchar_t/4.cc execution test

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=31413 --- Comment #25 from Jonathan Wakely --- The test is disabled unless the machine actually has the relevant locale installed: // { dg-require-namedlocale "zh_TW.UTF-8" } That will be why some systems show UNSUPPORTED.

[PATCH] Macro definition parameter parsing

2018-08-16 Thread Nathan Sidwell
This next patch in the macro cleanup changes the internal interface to the parameter parsing logic. Rather than pass a macro pointer in, we pass explicit variable pointers in. This'll allow later creation of the macro object itself. While there, I cleaned up the parsing logic for more

[Bug testsuite/86745] [9 regression] gcc.target/i386/avx-cvt-2.c etc. FAIL on 64-bit x86

2018-08-16 Thread ubizjak at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86745 Uroš Bizjak changed: What|Removed |Added Status|ASSIGNED|RESOLVED Component|target

[PATCH, testsuite]: Loosen scan-assembler strings in gcc.target/i386/avx{,2}-cvt-2.c

2018-08-16 Thread Uros Bizjak
Hello! These instructions can take memory operands and current scan-assembler strings were too tight to accept them. 2018-08-16 Uros Bizjak PR testsuite/86745 * gcc.target/i386/avx-cvt-2.c: Loosen scan-assembler strings. * gcc.target/i386/avx2-cvt-2.c: Ditto. Tested on

[Bug target/86745] [9 regression] gcc.target/i386/avx-cvt-2.c etc. FAIL on 64-bit x86

2018-08-16 Thread uros at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86745 --- Comment #4 from uros at gcc dot gnu.org --- Author: uros Date: Thu Aug 16 18:52:26 2018 New Revision: 263598 URL: https://gcc.gnu.org/viewcvs?rev=263598=gcc=rev Log: PR testsuite/86745 * gcc.target/i386/avx-cvt-2.c: Loosen

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-16 Thread Bernd Edlinger
On 08/16/18 19:35, Jeff Law wrote: > On 08/15/2018 12:51 PM, Bernd Edlinger wrote: > [ snip -- comment attribution is likely lost... ] > > > 2018-08-14  Bernd Edlinger  > > * builtins.c (c_strlen): Add new parameter eltsize. > * builtins.h (c_strlen): Adjust

[Bug libstdc++/71641] 22_locale/time_get/get_date/wchar_t/4.cc runs failure if static linking

2018-08-16 Thread dave.anglin at bell dot net
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71641 --- Comment #5 from dave.anglin at bell dot net --- On 2018-08-16 7:35 AM, redi at gcc dot gnu.org wrote: > So this is not a libstdc++ bug, it's a glibc bug. Debian's glibc 2.13 has bad > locale data for zh_TW, and all versions of glibc have the

[Bug c++/86980] Lambda function with return type rvalue reference dtor issue

2018-08-16 Thread neeraj.sharma at alumni dot iitg.ernet.in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86980 --- Comment #2 from Neeraj --- (In reply to Jonathan Wakely from comment #1) > This is a bug in your code, not GCC. you're returning a reference to a local > variable, which goes out of scope, leaving a dangling reference. > I was just playing

[Bug libstdc++/71641] 22_locale/time_get/get_date/wchar_t/4.cc runs failure if static linking

2018-08-16 Thread dave.anglin at bell dot net
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71641 --- Comment #4 from dave.anglin at bell dot net --- On 2018-08-16 12:26 PM, redi at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71641 > > --- Comment #3 from Jonathan Wakely --- > (In reply to John David Anglin from

Re: [PATCH] [C] Warn when calculating abs(unsigned_value)

2018-08-16 Thread Martin Sebor
On 08/16/2018 10:49 AM, Joseph Myers wrote: On Wed, 15 Aug 2018, Martin Sebor wrote: Detecting some of these bugs without too much noise would require moving the warning out of the front-end and to some later point after VRP has run. But you need the information about whether the conversion

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-16 Thread Jeff Law
On 08/15/2018 12:51 PM, Bernd Edlinger wrote: [ snip -- comment attribution is likely lost... ] 2018-08-14  Bernd Edlinger  * builtins.c (c_strlen): Add new parameter eltsize. * builtins.h (c_strlen): Adjust prototype. * expr.c (string_constant): Add new

[PATCH] Fix warning with -Wsign-compare -Wsystem-headers in __sph_legendre

2018-08-16 Thread Jonathan Wakely
Ed, I'm checking this in as it looks correct anyway, quite apart from the fact it fixes a warning, but could you please double check it? * include/tr1/legendre_function.tcc (__sph_legendre): Avoid warning about signed/unsigned comparison. Tested x86_64-linux, committed to trunk.

[PATCH 4/4] rs6000: Delete old add+cmp patterns

2018-08-16 Thread Segher Boessenkool
There are some patterns that recognise the parallel of an add and a compare, and split it back to the same two insns. This apparently helped RIOS machines before RTL scheduling existed? Either way, it isn't helpful anymore, and even hurts a tiny bit. So, delete it. 2018-08-16 Segher

[PATCH 3/4] rs6000: Remove "length 4" from other insns

2018-08-16 Thread Segher Boessenkool
There were many insns that set "length 4" explicitly while that does not make anything clearer to the reader. So, simplify the code. 2018-08-16 Segher Boessenkool * config/rs6000/altivec.md: Don't set length attribute to the default value. * config/rs6000/darwin.md:

[PATCH 2/4] rs6000: Remove "length 4" from branch insns

2018-08-16 Thread Segher Boessenkool
Now that it is the default for branch insns like for all other insns, we don't need to set it explicitly so often anymore. 2018-08-16 Segher Boessenkool * config/rs6000/altivec.md: Don't set length attribute to the default value, for branch instructions. *

[Bug c/86972] [6/7/8/9 Regression] Incorrect array-bounds warning with -O2 when creating pointer from array

2018-08-16 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86972 Martin Sebor changed: What|Removed |Added Status|NEW |RESOLVED CC|

[PATCH 1/4] rs6000: Change the length attribute default

2018-08-16 Thread Segher Boessenkool
This moves what is currently the default of the length attribute to the only branch instruction patterns where it applies, namely, the B-form instructions. It was used for the "jump" instruction as well before, but that is an I-form instruction and always has length 4. 2018-08-16 Segher

[PATCH 0/4] rs6000: length attribute

2018-08-16 Thread Segher Boessenkool
This series makes some changes to the length attribute. Currently, the length attribute for branch instructions defaults to what is needed for B-form instructions, that is, branches with an immediate 16-bit displacement field. There is only one such machine insn, and only three such RTL

[Bug c++/86911] [9 Regression] ICE in gcc/c-family/c-indentation.c:403

2018-08-16 Thread dmalcolm at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86911 --- Comment #3 from David Malcolm --- Does r263595 fix the issue? (it relates to having stray carriage returns somewhere above in the file, leading to line-numbering becoming confused)

[committed] -Wmisleading-indentation: fix ICE in get_visual_column (PR c++/70693)

2018-08-16 Thread David Malcolm
PR c++/70693 reports a crash within -Wmisleading-indentation in get_visual_column, reading past the end of a source line. The issue occurs due to a stray carriage return aka '\r' aka ^M, occurring towards the end of line 35 of attachment 38289 - but not at the end itself. This carriage return

[Bug c++/70693] valgrind error in get_visual_column

2018-08-16 Thread dmalcolm at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70693 --- Comment #10 from David Malcolm --- Author: dmalcolm Date: Thu Aug 16 17:07:15 2018 New Revision: 263595 URL: https://gcc.gnu.org/viewcvs?rev=263595=gcc=rev Log: -Wmisleading-indentation: fix ICE in get_visual_column (PR c++/70693) PR

[PATCH] Avoid deprecation warning with -Wsystem-headers

2018-08-16 Thread Jonathan Wakely
C++17 says to use std::uncaught_exceptions() here instead of std::uncaught_exception() but since we only care whether the result is non-zero (and we aren't planning to remove the deprecated version) we can just keep using std::uncaught_exception() and suppress the warning. *

Re: [PATCH] Merge Ignore and Deprecated in .opt files.

2018-08-16 Thread Joseph Myers
On Thu, 16 Aug 2018, Martin Liška wrote: > On 08/15/2018 06:38 PM, Joseph Myers wrote: > > On Wed, 15 Aug 2018, Martin Liška wrote: > > > >> Ok, so you have very similar opinion as Jakub. Thus I'm sending new > >> version that preserves status quo, it only does: > > > > This is removing

[Bug target/86640] [8/9 regression] ICE in combine

2018-08-16 Thread tnfchris at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86640 Tamar Christina changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: [PATCH] [C] Warn when calculating abs(unsigned_value)

2018-08-16 Thread Joseph Myers
On Wed, 15 Aug 2018, Martin Sebor wrote: > Detecting some of these bugs without too much noise would require > moving the warning out of the front-end and to some later point > after VRP has run. But you need the information about whether the conversion was explicit or implicit. If someone

Re: [RFC][PATCH][mid-end] Optimize immediate choice in comparisons.

2018-08-16 Thread Jeff Law
On 08/16/2018 10:46 AM, Vlad Lazar wrote: >> Thanks.  I fixed up the ChangeLog entry and installed this on the trunk. >> >> Richard S -- thanks for working with Vlad to push this forward. >> >> jeff >> > Thanks for committing.  Sorry about the ChangeLog. No worries. Just trivial stuff that we

[Bug middle-end/86968] Unaligned big-endian (scalar_storage_order) access on armv7-a yields 4 ldrb instructions rather than ldr+rev

2018-08-16 Thread joseph at codesourcery dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86968 --- Comment #4 from joseph at codesourcery dot com --- Any unaligned access things that don't work for big-endian ARM are probably fallout from the issues with big-endian NEON (NEON architectural lane numbers are different from the

Re: [RFC][PATCH][mid-end] Optimize immediate choice in comparisons.

2018-08-16 Thread Vlad Lazar
On 16/08/18 17:35, Jeff Law wrote: On 08/14/2018 11:01 AM, Vlad Lazar wrote: On 13/08/18 15:00, Richard Sandiford wrote: Vlad Lazar writes: diff --git a/gcc/expmed.h b/gcc/expmed.h index 2890d9c9bbd034f01030dd551d544bf73e73b784..86a32a643fdd0fc9f396bd2c7904244bd484df16 100644 ---

[Bug libstdc++/86590] Codegen is poor when passing std::string by value with _GLIBCXX_EXTERN_TEMPLATE undefined

2018-08-16 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86590 --- Comment #30 from Jakub Jelinek --- The thing is that even with the foo that doesn't contain all those __builtin_constant_p 's after early inlining, we with -std=c++17 -O3 don't inline for some reason _M_construct.constprop, while we do

Re: [RFC][PATCH][mid-end] Optimize immediate choice in comparisons.

2018-08-16 Thread Jeff Law
On 08/14/2018 11:01 AM, Vlad Lazar wrote: > On 13/08/18 15:00, Richard Sandiford wrote: >> Vlad Lazar writes: >>> diff --git a/gcc/expmed.h b/gcc/expmed.h >>> index >>> 2890d9c9bbd034f01030dd551d544bf73e73b784..86a32a643fdd0fc9f396bd2c7904244bd484df16 >>> 100644 >>> --- a/gcc/expmed.h >>> +++

[Bug libstdc++/71641] 22_locale/time_get/get_date/wchar_t/4.cc runs failure if static linking

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71641 --- Comment #3 from Jonathan Wakely --- (In reply to John David Anglin from comment #1) > Fails on hppa-linux with libc 2.25: Is that a Debian system too? Maybe we can figure out a condition to use for dg-xfail-if or dg-skip-if.

Re: Questions related to creation of libgcov.so

2018-08-16 Thread Michael Matz
Hi, On Thu, 16 Aug 2018, Joseph Myers wrote: > On Thu, 16 Aug 2018, Michael Matz wrote: > > > > About the location of libgcov.{a,so}, I believe right place would be now: > > > > > > /home/marxin/bin/gcc/lib64/libgcov.so.1 > > > /home/marxin/bin/gcc/lib64/libgcov.so > > >

Re: Questions related to creation of libgcov.so

2018-08-16 Thread Joseph Myers
On Thu, 16 Aug 2018, Michael Matz wrote: > > About the location of libgcov.{a,so}, I believe right place would be now: > > > > /home/marxin/bin/gcc/lib64/libgcov.so.1 > > /home/marxin/bin/gcc/lib64/libgcov.so > > /home/marxin/bin/gcc/lib64/libgcov.a > > No. With version dependend dirs the .so

Re: Workaround for bugs 42614 and 42691 in GCC 4.4.2

2018-08-16 Thread Vicent Brocal Tortosa
Hello Jeff, > El 16 ag 2018, a les 17:50, Jeff Law va escriure: > > On 08/16/2018 09:43 AM, Vicent Brocal Tortosa wrote: >> Hello, >> >> We are forced to use version 4.4.2 of GCC C compiler for a certain project >> and to analyze the potential impact, to our software, of bugs detected for >>

Re: Questions related to creation of libgcov.so

2018-08-16 Thread Joseph Myers
On Thu, 16 Aug 2018, Martin Liška wrote: > About the location of libgcov.{a,so}, I believe right place would be now: > > /home/marxin/bin/gcc/lib64/libgcov.so.1 > /home/marxin/bin/gcc/lib64/libgcov.so > /home/marxin/bin/gcc/lib64/libgcov.a Yes, I think so. > Because of LD_LIBRARY_PATH location

[Bug libstdc++/86447] gcc 9.0 from r262456 can't build cross compiler for mingw-w64 target

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86447 --- Comment #3 from Jonathan Wakely --- Author: redi Date: Thu Aug 16 15:56:21 2018 New Revision: 263590 URL: https://gcc.gnu.org/viewcvs?rev=263590=gcc=rev Log: Fix bootstrap with --enable-fully-dynamic-string PR libstdc++/86447

[Bug libstdc++/86447] gcc 9.0 from r262456 can't build cross compiler for mingw-w64 target

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86447 Jonathan Wakely changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[PATCH] Fix bootstrap with --enable-fully-dynamic-string

2018-08-16 Thread Jonathan Wakely
PR libstdc++/86447 * src/c++11/cow-stdexcept.cc [_GLIBCXX_FULLY_DYNAMIC_STRING] (logic_error::logic_error(logic_error&&)) (logic_error::operator=(logic_error&&)) (runtime_error::runtime_error(runtime_error&&))

[PATCH, RFC, rs6000, v2] folding of vec_splat

2018-08-16 Thread Will Schmidt
Hi Enable GIMPLE folding of the vec_splat() intrinsic. (v2). This uses the tree_vec_extract() function out of tree-vect-generic.c to retrieve the splat value, which is a BIT_FIELD_REF. That function is made non-static as part of this change. Testcases are already in-tree. V2

Re: Workaround for bugs 42614 and 42691 in GCC 4.4.2

2018-08-16 Thread Jeff Law
On 08/16/2018 09:43 AM, Vicent Brocal Tortosa wrote: > Hello, > > We are forced to use version 4.4.2 of GCC C compiler for a certain project > and to analyze the potential impact, to our software, of bugs detected for > this GCC version. > > I am already aware that bugs reported for 4.4.x

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

2018-08-16 Thread Julian Brown
On Wed, 15 Aug 2018 21:56:54 +0200 Bernhard Reutner-Fischer wrote: > On 15 August 2018 18:46:37 CEST, Julian Brown > wrote: > >On Mon, 13 Aug 2018 12:06:21 -0700 > >Cesar Philippidis wrote: > > atttribute has more t than strictly necessary. > Don't like signed integer levels where they

Workaround for bugs 42614 and 42691 in GCC 4.4.2

2018-08-16 Thread Vicent Brocal Tortosa
Hello, We are forced to use version 4.4.2 of GCC C compiler for a certain project and to analyze the potential impact, to our software, of bugs detected for this GCC version. I am already aware that bugs reported for 4.4.x versions may also be present in 4.4.2, but for the moment we have

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-16 Thread Jeff Law
On 08/16/2018 09:23 AM, Martin Sebor wrote: > On 08/15/2018 03:34 PM, Jeff Law wrote: >> On 08/15/2018 03:02 PM, Martin Sebor wrote: >>> On 08/15/2018 06:07 AM, Joseph Myers wrote: On Tue, 14 Aug 2018, Martin Sebor wrote: >> This is with Bison 3.0.4, should the version used to

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-16 Thread Martin Sebor
On 08/15/2018 03:34 PM, Jeff Law wrote: On 08/15/2018 03:02 PM, Martin Sebor wrote: On 08/15/2018 06:07 AM, Joseph Myers wrote: On Tue, 14 Aug 2018, Martin Sebor wrote: This is with Bison 3.0.4, should the version used to produce intl/plural.c prove relevant. Can you send me the

[Bug c++/86982] New: Make -Wreturn-local-addr know about std::move and std::forward

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86982 Bug ID: 86982 Summary: Make -Wreturn-local-addr know about std::move and std::forward Product: gcc Version: 9.0 Status: UNCONFIRMED Keywords: diagnostic

Re: [PATCH, testsuite] Make pr80263 work for Darwin by suppressing pubnames/types.

2018-08-16 Thread Jeff Law
On 08/16/2018 08:35 AM, Iain Sandoe wrote: > > Darwin emits pubnames/types by default which masks the intended check. > > OK for trunk? > Iain > > gcc/testsuite > > * gcc.dg/debug/dwarf2/pr80263.c: Suppress pubtypes output for Darwin. OK jeff

Re: [PATCH][GCC][DOCS] Remove rtl.texi references to old RTX code class names

2018-08-16 Thread Jeff Law
On 08/16/2018 08:44 AM, Sandra Loosemore wrote: > On 08/16/2018 02:42 AM, Matthew Malcomson wrote: >> >> On 15/08/18 20:26, Sandra Loosemore wrote: >>> >>> Use @item for the first item in a group, @itemx for all the others. >> >> Thanks for the spot, updated patch attached. > > This version looks

[Bug c++/86981] Add Clang's -Wpessmizing-move warning

2018-08-16 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86981 Marek Polacek changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/67906] Missing warning about std::move without effect

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67906 --- Comment #8 from Jonathan Wakely --- Kinda related: PR 86981

[Bug c++/86981] New: Add Clang's -Wpessmizing-move warning

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86981 Bug ID: 86981 Summary: Add Clang's -Wpessmizing-move warning Product: gcc Version: 9.0 Status: UNCONFIRMED Keywords: diagnostic Severity: enhancement Priority:

Re: [Patch wwwdocs] Document arm-8-branch

2018-08-16 Thread Gerald Pfeifer
On Wed, 15 Aug 2018, Ramana Radhakrishnan wrote: > As $subject. > > Ok ? Yes, and you do not need anyone's approval. :-) Though since you asked: + This branch provides bug fixes and minor enhancements for GCC when + used targeting the AArch64 and the Arm architecture. Most patches Could

[Bug c++/86980] Lambda function with return type rvalue reference dtor issue

2018-08-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86980 Jonathan Wakely changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

  1   2   >