[Bug go/90482] [10 regression] Many 32-bit Solaris/SPARC tests FAIL with SIGBUS

2019-05-16 Thread ian at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90482 --- Comment #1 from ian at gcc dot gnu.org --- Author: ian Date: Fri May 17 05:49:22 2019 New Revision: 271310 URL: https://gcc.gnu.org/viewcvs?rev=271310=gcc=rev Log: PR go/90482 compiler: make value method of direct interface type

Go patch committed: Make value method of direct iface take pointer

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang make value methods of direct interface types take a pointer argument. Currently, a value method of a direct interface type takes the value of the receiver, which is pointer shaped, as the first parameter. When this method is called through interface,

Strenghten aliasing_component_refs_p

2019-05-16 Thread Jan Hubicka
Hi, this patch cuts walks in aliasing_component_refs_p if the type we look for can not fit into a given type by comparing their sizes. Similar logic already exists in indirect_ref_may_alias_decl_p. When we walk reference a.b.c.d.e looking for type x we only need to do it if sizeof(a)>=sizeof(x)

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Kugan Vivekanandarajah
Hi, On Fri, 17 May 2019 at 13:37, wrote: > > From: Kewen Lin > > Hi, > > Previous version link: > https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html > > Comparing with the previous version, I moved the generic > parts of rs6000 target hook to IVOPTs. But I still kept > the target hook as

[Bug middle-end/90514] New: Issue about enum type in gcc tree

2019-05-16 Thread JunMa at linux dot alibaba.com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90514 Bug ID: 90514 Summary: Issue about enum type in gcc tree Product: gcc Version: tree-ssa Status: UNCONFIRMED Severity: normal Priority: P3 Component: middle-end

[Bug target/90513] Pwerplcelfv2 :R2 is not updated to the TOC base .

2019-05-16 Thread linkw at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90513 Kewen Lin changed: What|Removed |Added CC||linkw at gcc dot gnu.org --- Comment #1

Re: Deque code cleanup and optimizations

2019-05-16 Thread François Dumont
Here is the simplified patch. I put back the _M_map checks, we'll see later if those can be removed.     * include/bits/stl_deque.h     (_Deque_iterator<>::__ptr_to): Remove, use std::__ptr_rebind.     (_Deque_base(_Deque_base&&, const allocator_type&)): New.    

Re: LWG2593 Move from allocator state is preserved

2019-05-16 Thread François Dumont
2 other tests needed to be adapted in 21_strings. Attached patch applied. 2019-05-17  François Dumont     Move from state of allocators (LWG2593)     * include/bits/stl_deque.h     (_Deque_base(_Deque_base&&, false_type)): Remove.     (_Deque_base(_Deque_base&&, true_type)): Remove.    

[PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-05-16 Thread Feng Xue OS
This patch is meant to give user a way to optimize away those empty loops which are impossible to be recognized by compiler, such as C++ STL container-based loop, void f (std::map )   {     for (auto it = m.begin (); it != m.end (); ++it);   } An option "-ffinite-loop" is added to

Re: [PowerPC 64]r12 is not updated to GEP when control transferred from virtual thunk function .

2019-05-16 Thread Umesh Kalappa
Hi Segher, Please refer the https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90513 . Thank you ~Umesh On Fri, May 17, 2019 at 4:22 AM Segher Boessenkool wrote: > > Hi Umesh, > > On Thu, May 16, 2019 at 06:12:48PM +0530, Umesh Kalappa wrote: > > We are very new to Power abi and we are thinking to

[Bug target/90512] New: Pwerplcelfv2 :R2 is not updated to the TOC base .

2019-05-16 Thread umesh.kalappa0 at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90512 Bug ID: 90512 Summary: Pwerplcelfv2 :R2 is not updated to the TOC base . Product: gcc Version: 10.0 Status: UNCONFIRMED Severity: normal Priority: P3

[Bug target/90513] New: Pwerplcelfv2 :R2 is not updated to the TOC base .

2019-05-16 Thread umesh.kalappa0 at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90513 Bug ID: 90513 Summary: Pwerplcelfv2 :R2 is not updated to the TOC base . Product: gcc Version: 10.0 Status: UNCONFIRMED Severity: normal Priority: P3

[PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread linkw
From: Kewen Lin Hi, Previous version link: https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html Comparing with the previous version, I moved the generic parts of rs6000 target hook to IVOPTs. But I still kept the target hook as previous which checks some target specific criteria like

New Spanish PO file for 'gcc' (version 9.1.0)

2019-05-16 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: https://translationproject.org/latest/gcc/es.po (This file, 'gcc-9.1.0.es.po', has

[Bug lto/90500] ICE error in copy_forbiden

2019-05-16 Thread neochen.life at aliyun dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90500 Guobing changed: What|Removed |Added CC||neochen.life at aliyun dot com --- Comment #9

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread JunMa
在 2019/5/17 上午6:04, Jakub Jelinek 写道: On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: One possibility is to add -fdump-tree-optimized and scan for /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ resp. /* { dg-final { scan-tree-dump "log

[Bug lto/90500] ICE error in copy_forbiden

2019-05-16 Thread guobing.chen at intel dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90500 Guobing changed: What|Removed |Added CC||guobing.chen at intel dot com --- Comment #8

[Bug tree-optimization/90270] [8/9/10 Regression] Do not select best induction variable optimization

2019-05-16 Thread rjiejie at me dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90270 --- Comment #13 from jojo --- Hi, guys, Any solution for this issue ? My be the following patch is choice :) ? Are there issue with applied this patch ? --- tree-ssa-loop-ivopts-orig.c 2019-05-17 09:32:58.05200 +0800 +++

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 16 May 2019 at 21:14, Richard Biener wrote: > > On Wed, May 15, 2019 at 4:40 AM wrote: > > > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > * tree-ssa-loop-ivopts.c

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Martin Sebor
On 5/16/19 5:22 PM, Joseph Myers wrote: On Tue, 14 May 2019, Martin Sebor wrote: The attached patch fixes quoting, spelling, and other formatting issues in diagnostics issued from files in the c-family/ directory and pointed out by the -Wformat-diag warning. Some of the changes in this patch

Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang intrinsifies the runtime/internal/atomic functions. Currently the runtime/internal/atomic functions are implemented in C using C compiler intrinsics. This patch lets the Go frontend recognize these functions and turn them into intrinsics directly.

[Bug c/90511] New: bogus attributes silently accepted before struct or union

2019-05-16 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90511 Bug ID: 90511 Summary: bogus attributes silently accepted before struct or union Product: gcc Version: 9.0 Status: UNCONFIRMED Severity: normal

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Joseph Myers
On Thu, 16 May 2019, Maxim Kuvyrkov wrote: > Let's avoid mixing the two discussions: (1) converting svn repo to git > (and getting community consensus to switch to git) and (2) deciding on > which branches to keep in the new repo. > > With git, we can always split away unneeded history by

Re: [PATCH] soft-fp: Update soft-fp from glibc

2019-05-16 Thread Joseph Myers
On Wed, 15 May 2019, H.J. Lu wrote: > This patch is updating all soft-fp from glibc, most changes are > copyright years update, and changes other than years update are > > * soft-fp/extenddftf2.c: Use "_FP_W_TYPE_SIZE < 64" to check if > 4_FP_W_TYPEs are used for IEEE quad precision.

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: This patch really exposes a significant deficiency in our current implementation of default_target_compile: the order of various flags can be significant, but we only have that order implicitly expressed in the code,

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Wed, 15 May 2019 at 16:57, Richard Sandiford wrote: > > Thanks for doing this. > > kugan.vivekanandara...@linaro.org writes: > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > *

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Joseph Myers
On Tue, 14 May 2019, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. Some of the changes in this patch are questionable. The diagnostics

Go patch committed: Add intrinsics for runtime/internal/sys functions

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang adds intrinsics for runtime/internal/sys functions. runtime/internal/sys.Ctz32/64 and Bswap32/64 are currently implemented with compiler builtin functions. But if they are called from another package, the compiler does not know and therefore cannot

[Bug libstdc++/90299] std::filesystem::absolute("") and std::filesystem::absolute("", ec) behave differently

2019-05-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90299 --- Comment #8 from Jonathan Wakely --- Author: redi Date: Thu May 16 23:09:51 2019 New Revision: 271302 URL: https://gcc.gnu.org/viewcvs?rev=271302=gcc=rev Log: PR libstdc++/90299 make filesystem::absolute overloads consistent In this

[Bug libstdc++/90509] failing typing std::transform with policies on std::insert_iterator

2019-05-16 Thread maurizio.drocco at pnnl dot gov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90509 --- Comment #4 from Maurizio Drocco --- Sorry I was forgetting the requirement, thank you for remarking it.

[C++ Patch] PR 67184 ("Missed optimization with C++11 final specifier")

2019-05-16 Thread Paolo Carlini
Hi, when Roberto Agostino and I implemented the front-end devirtualization of final overriders we missed this case, where it comes from the base. It seems to me that by way of access_path the existing approach can be neatly extended. Tested x86_64-linux. Thanks, Paolo.

[Bug libstdc++/90299] std::filesystem::absolute("") and std::filesystem::absolute("", ec) behave differently

2019-05-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90299 Jonathan Wakely changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug libstdc++/90299] std::filesystem::absolute("") and std::filesystem::absolute("", ec) behave differently

2019-05-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90299 --- Comment #7 from Jonathan Wakely --- Author: redi Date: Thu May 16 23:00:26 2019 New Revision: 271301 URL: https://gcc.gnu.org/viewcvs?rev=271301=gcc=rev Log: PR libstdc++/90299 make filesystem::absolute overloads consistent In this

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Joseph Myers
On Tue, 14 May 2019, Maxim Kuvyrkov wrote: > The scripts convert svn history branch by branch. They rely on git-svn > on convert individual branches. Git-svn is a good tool for converting > individual branches. It is, however, either very slow at converting the > entire GCC repo, or goes

[Bug libstdc++/90509] failing typing std::transform with policies on std::insert_iterator

2019-05-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90509 Jonathan Wakely changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: [...] We are not consistent here in `gnat_target_compile' anyway, as you can see from the two existing `concat' invocations, and also the `timeout=300' element. That is the GCC testsuite rather than DejaGnu itself, so

[Bug libstdc++/90509] failing typing std::transform with policies on std::insert_iterator

2019-05-16 Thread maurizio.drocco at pnnl dot gov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90509 Maurizio Drocco changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED

Re: [PowerPC 64]r12 is not updated to GEP when control transferred from virtual thunk function .

2019-05-16 Thread Segher Boessenkool
Hi Umesh, On Thu, May 16, 2019 at 06:12:48PM +0530, Umesh Kalappa wrote: > We are very new to Power abi and we are thinking to handle this case > in loader like go through the relocations like R_PPC64_REL24 and > found symbol has the localentry ,then compute the delta (GEP - LEP ) > and patch

[PATCH] Remove incorrect assertion from filesystem::absolute

2019-05-16 Thread Jonathan Wakely
The assertion is wrong, it should be *s.end() == 0, but that's not allowed. Just remove it, but keep the comment. * src/c++17/fs_ops.cc (absolute(const path&, error_code&)) [_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Remove bogus assertion. Tested x86_64-w64-mingw32, committed to trunk.

Re: [PATCH, Darwin, PowerPC, testsuite] Exclude Darwin from VSX, Power8 and Power9 tests.

2019-05-16 Thread Segher Boessenkool
On Thu, May 16, 2019 at 12:03:14PM +0100, Iain Sandoe wrote: > I did a quick check... > > dfp.exp most (all?) fail despite > > /* { dg-require-effective-target powerpc_p9vector_ok } */ > > with errors like this… > > error: decimal floating point not supported for this target Okay, so the test

[Bug libstdc++/90509] failing typing std::transform with policies on std::insert_iterator

2019-05-16 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90509 Jonathan Wakely changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

gcc-7-20190516 is now available

2019-05-16 Thread gccadmin
Snapshot gcc-7-20190516 is now available on ftp://gcc.gnu.org/pub/gcc/snapshots/7-20190516/ and on various mirrors, see http://gcc.gnu.org/mirrors.html for details. This snapshot has been generated from the GCC 7 SVN branch with the following options: svn://gcc.gnu.org/svn/gcc/branches/gcc-7

Re: [PATCH] Fix PR 81721: ICE with PCH and Pragma warning and C++ operator

2019-05-16 Thread Joseph Myers
On Mon, 1 Apr 2019, apin...@marvell.com wrote: > From: Andrew Pinski > > Hi, > The problem here is the token->val.node is not saved over > a precompiled header for C++ operator. This can cause an > internal compiler error as we tried to print out the spelling > of the token as we assumed it

[Bug libstdc++/90509] New: failing typing std::transform with policies on std::insert_iterator

2019-05-16 Thread maurizio.drocco at pnnl dot gov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90509 Bug ID: 90509 Summary: failing typing std::transform with policies on std::insert_iterator Product: gcc Version: 9.1.0 Status: UNCONFIRMED Severity: normal

[Bug c/90472] “extern int i;” declaration inside function isn't allowed to shadow “static int i;” at file scope

2019-05-16 Thread joseph at codesourcery dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90472 --- Comment #3 from joseph at codesourcery dot com --- This is not a bug. If 'i' is not redeclared in an intermediate scope, so the visible declaration is one at file scope, the rule that "if the prior declaration specifies internal or

[Bug tree-optimization/90510] New: [10 Regression] Unnecessary permutation

2019-05-16 Thread hjl.tools at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90510 Bug ID: 90510 Summary: [10 Regression] Unnecessary permutation Product: gcc Version: 9.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component:

[Bug tree-optimization/90510] [10 Regression] Unnecessary permutation

2019-05-16 Thread hjl.tools at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90510 H.J. Lu changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: > One possibility is to add -fdump-tree-optimized and scan for > /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" > "optimized" } } */ > resp. > /* { dg-final { scan-tree-dump "log \\(\[^\n\r]*\\); \\\[tail

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jonathan Wakely
On 16/05/19 13:07 -0600, Jeff Law wrote: On 5/16/19 12:36 PM, Ramana Radhakrishnan wrote: On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov wrote: On May 16, 2019, at 7:22 PM, Jeff Law wrote: On 5/15/19 5:19 AM, Richard Biener wrote: For the official converted repo do we really want all

[PATCH] i386: Enable MMX intrinsics without SSE/SSE2/SSSE3

2019-05-16 Thread H.J. Lu
Since MMX intrinsics are marked with SSE/SSE2/SSSE3 for SSE emulation, enable them without SSE/SSE2/SSSE3 if MMX is enabled. Restore TARGET_3DNOW check, which was changed to TARGET_3DNOW_A by revision 271235. gcc/ PR target/90497 * config/i386/i386-expand.c

[committed] Fix ICE in equal_mem_array_ref_p (PR c++/90484)

2019-05-16 Thread Jakub Jelinek
Hi! As mentioned in the PR, if we are very unlucky and have a hash collision not just when hash % hash table size is equal, but when the whole 32-bit hash is equal, we can actually end up with compatible types (bool vs. unsigned : 1 on the testcase), but sz0 != sz1 (one is 1-bit, the other

[Bug c++/90484] [9/10 Regression] ICE in equal_mem_array_ref_p at gcc/tree-ssa-scopedtables.c:550 since r270433 on i586

2019-05-16 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90484 --- Comment #5 from Jakub Jelinek --- Author: jakub Date: Thu May 16 21:45:34 2019 New Revision: 271299 URL: https://gcc.gnu.org/viewcvs?rev=271299=gcc=rev Log: PR c++/90484 * tree-ssa-scopedtables.c (equal_mem_array_ref_p):

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Segher Boessenkool
Hi Jeff, On Thu, May 16, 2019 at 12:41:16PM -0600, Jeff Law wrote: > For architectures like PPC, we probably don't want to use the loop count > for anything else as it's likely expensive to get data in/out of the the > loop count register. That is part of it. Another part is that it costs extra

[Bug bootstrap/90497] [10 Regression] Broken bootstrap on i686-linux

2019-05-16 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90497 --- Comment #6 from Jakub Jelinek --- Looks good on i686-linux, results in FAIL: gcc.target/i386/pr90497-2.c (test for excess errors) Excess errors: /home/jakub/src/gcc/gcc/testsuite/gcc.target/i386/pr90497-2.c:11:10: warning: implicit

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Wed, May 08, 2019 at 06:09:06PM +0800, JunMa wrote: > 2019-05-07  Jun Ma > >     PR tree-optimization/90106 >     * gcc.dg/cdce1.c: Check tailcall code generation after cdce pass. >     * gcc.dg/cdce2.c: Likewise. This is wrong and results in UNSUPPORTED failures. Both tests are dg-do run,

[RFC PATCH] Enhancements to profiledbootstrap

2019-05-16 Thread Arvind Sankar
Hi, I've been playing some with the PGO build infrastructure and have a few changes I thought I'd share and get feedback on whether they're completely crazy or not. I'm not terribly familiar with the innards of the build infra, so would appreciate any comments and suggestions. First, a recap of

[Bug middle-end/89765] [9/10 Regression] Multiple problems with vec-insert implementation on PowerPC

2019-05-16 Thread kelvin at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89765 --- Comment #14 from kelvin at gcc dot gnu.org --- Author: kelvin Date: Thu May 16 21:10:32 2019 New Revision: 271297 URL: https://gcc.gnu.org/viewcvs?rev=271297=gcc=rev Log: gcc/ChangeLog: 2019-05-16 Kelvin Nilsen Backport from

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Hi Janne, I differ there. A longer explanation: fork() is standard POSIX. Not all systems have posix_spawn. For those systems which do not have it, we would cause a regression by simply removing that functionality for this. The patch is OK from my side if you add fork() as a fallback

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Am 16.05.19 um 22:10 schrieb Janne Blomqvist: On Thu, May 16, 2019 at 10:59 PM Thomas Koenig wrote: Hi Janne, fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g.

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Ville Voutilainen
On Thu, 16 May 2019 at 23:28, Jonathan Wakely wrote: > Here's what I've tested and am about to commit. Looks good to me.

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Jonathan Wakely
On 16/05/19 12:43 +0100, Jonathan Wakely wrote: On 16/05/19 12:29 +0100, Jonathan Wakely wrote: These two changes both result in smaller code for std::variant. The first one means smaller tables of function pointers, because we don't generate an instantiation for the valueless state. Instead

[PATCH] Implement sane variant converting constructor (P0608R3)

2019-05-16 Thread Jonathan Wakely
* include/std/variant (__overload_set): Remove. (_Arr): New helper. (_Build_FUN): New class template to define a single FUN overload, with specializations to prevent unwanted conversions, as per P0608R3. (_Build_FUNs): New class template to build an

Re: patches to detect GCC diagnostics

2019-05-16 Thread Martin Sebor
On 5/16/19 8:58 AM, Roland Illig wrote: Hi Martin, I'm impressed how much work you have put into the patches for detecting nonoptimal diagnostics. It takes a long time to read through the patches, but it's worth it, knowing that it took much longer for you to prepare the patch, and that I won't

[Bug target/90458] mingw64: ICE in i386_pe_seh_unwind_emit, at config/i386/winnt.c:1258 with -fstack-clash-protection

2019-05-16 Thread law at redhat dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90458 --- Comment #2 from Jeffrey A. Law --- So this is an interaction between stack-clash protection and SEH. I'm not *at all* familiar with SEH, though obviously I know a bit about stack clash. In general on x86 the compiler handles stack

[Bug c++/90508] New: GCC does not produce full template backtraces when instantiating but not calling virtual functions

2019-05-16 Thread m101010a at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90508 Bug ID: 90508 Summary: GCC does not produce full template backtraces when instantiating but not calling virtual functions Product: gcc Version: 8.3.0 Status: UNCONFIRMED

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Janne Blomqvist
On Thu, May 16, 2019 at 10:59 PM Thomas Koenig wrote: > > Hi Janne, > > > fork() semantics can be problematic. Most unix style OS'es have > > posix_spawn which can be used to replace fork + exec in many cases. > > For more information see > > e.g. > >

[PATCH] x86-64: Add vararg ABI tests

2019-05-16 Thread H.J. Lu
We can scan stack for return address to get vector arguments passed on stack. * gcc.target/x86_64/abi/test_varargs-m128.c: New file. * gcc.target/x86_64/abi/avx/test_varargs-m256.c: Likewise. * gcc.target/x86_64/abi/avx512f/test_varargs-m512.c: Likewise. ---

[Bug libfortran/90038] execute_command_line should not use fork()

2019-05-16 Thread jb at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90038 Janne Blomqvist changed: What|Removed |Added URL||https://gcc.gnu.org/ml/gcc-

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Hi Janne, fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.microsoft.com/en-us/research/uploads/prod/2019/04/fork-hotos19.pdf This replaces the one use of fork in

[PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Janne Blomqvist
fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.microsoft.com/en-us/research/uploads/prod/2019/04/fork-hotos19.pdf This replaces the one use of fork in libgfortran with

Re: OpenACC Profiling Interface: 'acc_register_library'

2019-05-16 Thread Thomas Schwinge
Hi Jakub! On Thu, 16 May 2019 17:54:23 +0200, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 05:21:56PM +0200, Thomas Schwinge wrote: > > > Jakub, would you please especially review the non-OpenACC-specific > > > changes here, including the libgomp ABI changes? > > > > Given a baseline that

Re: [PATCH 9/12] adjust tests to quoting/spelling diagnostics fixes

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch adjusts the expected test output to the quoting, > spelling and other formatting changes in diagnostics to fix issues > pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-tests.diff > > gcc/testsuite/ChangeLog:

Re: patches to detect GCC diagnostics

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 04:58:08PM +0200, Roland Illig wrote: > - error ("#pragma GCC target string... is badly formed"); > + error ("%<#pragma GCC target%> string is badly formed"); > - error ("#pragma GCC optimize string... is badly formed"); > + error ("%<#pragma GCC

Re: [PATCH 8/12] fix diagnostic quoting/spelling in the middle-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in middle-end files and > pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-midend.diff > > gcc/ChangeLog: > > *

Re: [PATCH 6/12] fix diagnostic quoting/spelling in C++

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the C++ front-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-cp.diff > > gcc/cp/ChangeLog: > > * call.c

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-c-family.diff > >

Re: [PATCH 11/12] fix diagnostic quoting/spelling issues in i386 back-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:33 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the i386 back-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-i386.diff > > gcc/ChangeLog: > > *

Re: [PATCH 10/12] fix diagnostic quoting/spelling in D

2019-05-16 Thread Jeff Law
On 5/14/19 3:33 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the D front end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-d.diff > > gcc/d/ChangeLog: > > * d/d-builtins.cc

Re: [PATCH 3/12] fix diagnostic quoting/spelling in Brig

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the Brig front end and pointed > out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-brig.diff > > gcc/brig/ChangeLog: > > *

Re: [PATCH 7/12] fix diagnostic quoting/spelling in libgcc

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the libgcc directory > and pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-libgcc.diff > > libgcc/ChangeLog: > >

Re: [PATCH 4/12] fix diagnostic quoting/spelling in the C front-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the C front-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-c.diff > > gcc/c/ChangeLog: > > * c-decl.c

Re: [PATCH 2/12] fix diagnostic quoting/spelling in ada

2019-05-16 Thread Jeff Law
On 5/14/19 3:31 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the Ada front and pointed out by > the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-ada.diff > > gcc/ada/ChangeLog: > > *

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jeff Law
On 5/16/19 12:36 PM, Ramana Radhakrishnan wrote: > On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov > wrote: >> >>> On May 16, 2019, at 7:22 PM, Jeff Law wrote: >>> >>> On 5/15/19 5:19 AM, Richard Biener wrote: For the official converted repo do we really want all (old) development

[PATCH] Refactor tree-affine.c to not build GENERIC trees

2019-05-16 Thread Richard Biener
The following picks up the patch from last December, refactoring aff_combination_expand to not use gimple_assign_rhs_to_tree but analyze GIMPLE stmts directly. Last December I was stuck at FAIL: gcc.dg/tree-ssa/ivopts-lt-2.c scan-tree-dump-times ivopts "PHI" 1 FAIL:

[Bug tree-optimization/88440] size optimization of memcpy-like code

2019-05-16 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88440 --- Comment #8 from rguenther at suse dot de --- On Thu, 16 May 2019, marxin at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88440 > > --- Comment #7 from Martin Liška --- > (In reply to Richard Biener from comment

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Jeff Law
On 5/16/19 12:46 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: >> >> On 5/15/19 3:03 PM, Alexandre Oliva wrote: >>> On May 15, 2019, Richard Biener wrote: >>> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > > Gimple jump threading does not

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: > > On 5/15/19 3:03 PM, Alexandre Oliva wrote: > > On May 15, 2019, Richard Biener wrote: > > > >> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > >>> > >>> Gimple jump threading does not duplicate forwarder blocks that might > >>> be

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Jeff Law
On 5/15/19 2:47 AM, Richard Biener wrote: > On Wed, 15 May 2019, Kewen.Lin wrote: > >> on 2019/5/14 下午3:26, Richard Biener wrote: >>> On Tue, May 14, 2019 at 5:10 AM wrote: From: Kewen Lin Previous version link for background:

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 4:04 PM Martin Jambor wrote: > > Hi Richi, > > On Thu, May 16 2019, Richard Biener wrote: > > On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: > >> > >> Hello, > >> > >> this is a follow-up from a WIP patch I sent here in late December: > >>

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Ramana Radhakrishnan
On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov wrote: > > > On May 16, 2019, at 7:22 PM, Jeff Law wrote: > > > > On 5/15/19 5:19 AM, Richard Biener wrote: > >> > >> For the official converted repo do we really want all (old) > >> development branches to be in the > >> main git repo? I suppose

[Bug middle-end/90501] [10 regression] ICE: address taken, but ADDRESSABLE bit not set

2019-05-16 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90501 Richard Biener changed: What|Removed |Added CC||seurer at gcc dot gnu.org --- Comment

[Bug tree-optimization/90507] [10 regression] ICE in gdc.test/runnable/mars1.d test case after r271209

2019-05-16 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90507 Richard Biener changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [PATCH 2/2] [PR88836][aarch64] Fix CSE to process parallel rtx dest one by one

2019-05-16 Thread Jeff Law
On 5/15/19 8:08 PM, kugan.vivekanandara...@linaro.org wrote: > From: Kugan Vivekanandarajah > > This patch changes cse_insn to process parallel rtx one by one such that > any destination rtx in cse list is invalidated before processing the > next. > > gcc/ChangeLog: > > 2019-05-16 Kugan

Re: [PATCH] Handle a location with NULL as a file (PR driver/90495)

2019-05-16 Thread Jeff Law
On 5/16/19 5:19 AM, Martin Liška wrote: > Hi. > > With LTO and -fsanitize we end up with a static ctor > (_GLOBAL__sub_I_00099_0_main) that has no source location. > With that stack usage will print '(artificial)' as a location > of the function. > > Patch can bootstrap on x86_64-linux-gnu and

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

2019-05-16 Thread Jeff Law
On 5/14/19 10:29 PM, bin.cheng wrote: > Hi, > As noted in PR57534 comment #33, SLSR currently doesn't strength reduce memory > references in reported cases, which conflicts with its comment at the > beginning of file. > The main reason is in functions slsr_process_ref and restructure_reference >

Re: [PATCH] gcc: move assemble_start_function / assemble_end_function to output_mi_thunk

2019-05-16 Thread Max Filippov
On Wed, May 15, 2019 at 2:46 PM Richard Sandiford wrote: > > Max Filippov writes: > > Let backends call assemble_start_function after they have generated > > thunk function body so that a constant pool could be output if it is > > required. This may help backends to avoid implementing custom

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Segher Boessenkool
On Thu, May 16, 2019 at 09:25:49AM +0200, Richard Biener wrote: > On Wed, 15 May 2019, Segher Boessenkool wrote: > > > Otherwise I understand that IVOPTs doesn't properly cost > > > the doloop IV update and conditional branch. > > > > Currently it doesn't even *know* something is or isn't a

[Bug middle-end/90501] [10 regression] ICE: address taken, but ADDRESSABLE bit not set

2019-05-16 Thread ibuclaw at gdcproject dot org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90501 --- Comment #11 from Iain Buclaw --- (In reply to Jakub Jelinek from comment #8) > So the first question would be why D passes the return value as > DECL_BY_REFERENCE if it doesn't have TREE_ADDRESSABLE type. Looking at the places where

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Maxim Kuvyrkov
> On May 16, 2019, at 7:22 PM, Jeff Law wrote: > > On 5/15/19 5:19 AM, Richard Biener wrote: >> >> For the official converted repo do we really want all (old) >> development branches to be in the >> main git repo? I suppose we could create a readonly git from the >> state of the whole

[Bug c++/90505] [9/10 Regression] g++ rejects a valid code

2019-05-16 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90505 --- Comment #3 from Marek Polacek --- Seems to be caused by this change: @@ -16327,15 +16388,6 @@ cp_parser_template_name (cp_parser* parser, } } - /* If DECL is dependent, and refers to a function, then just return - its name;

  1   2   3   >