Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Monday, September 18, 2023 11:36 AM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Support VLS mode for vec_set
LGTM
On Mon, Sep 18, 2023 at 11:27
Committed, thanks Jeff and Robin.
Pan
-Original Message-
From: Jeff Law
Sent: Tuesday, September 19, 2023 1:44 AM
To: Robin Dapp ; Li, Pan2 ;
gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; Wang, Yanzhang ;
kito.ch...@gmail.com
Subject: Re: [PATCH v1] RISC-V: Bugfix for scalar move
Thanks Robin, let's wait Jeff's confirmation for this.
Pan
-Original Message-
From: Robin Dapp
Sent: Monday, September 18, 2023 6:01 PM
To: Jeff Law ; Li, Pan2 ;
gcc-patches@gcc.gnu.org
Cc: rdapp@gmail.com; juzhe.zh...@rivai.ai; Wang, Yanzhang
; kito.ch...@gmail.com
Subject: Re:
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Monday, September 18, 2023 4:01 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; kito.ch...@gmail.com; jeffreya...@gmail.com;
rdapp@gmail.com
Subject: Re: [PATCH]
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Monday, September 18, 2023 4:20 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; kito.ch...@sifive.com; jeffreya...@gmail.com;
rdapp@gmail.com
Subject: Re: [PATCH]
> I must be missing something. Doesn't insn 10 broadcast the immediate
> 0x2 to both elements of r142?!? What am I missing?
Thanks Jeff for comments.
The insn 10 is VECTOR_SCALAR_MOV, aka vmv.s.x from the asm code.
Pan
-Original Message-
From: Jeff Law
Sent: Sunday, September 17,
Committed, thanks Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Friday, September 15, 2023 11:44 PM
To: 钟居哲 ; Jeff Law ; kito.cheng
Cc: rdapp@gmail.com; gcc-patches ; kito.cheng
Subject: Re: [PATCH V4] RISC-V: Expand VLS mode to
Committed, thanks Juzhe.
Pan
From: 钟居哲
Sent: Saturday, September 16, 2023 7:21 AM
To: Li, Pan2 ; gcc-patches
Cc: Li, Pan2 ; Wang, Yanzhang ;
kito.cheng
Subject: Re: [PATCH v1] RISC-V: Support FP SGNJX autovec for VLS mode
lgtm
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Friday, September 15, 2023 6:07 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; jeffreya...@gmail.com
Subject: Re: [PATCH] test: Block SLP check of slp-35.c for
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Friday, September 15, 2023 6:07 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; jeffreya...@gmail.com
Subject: Re: [PATCH] test: Block SLP check of slp-34.c for
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Friday, September 15, 2023 6:07 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; jeffreya...@gmail.com
Subject: Re: [PATCH] test: Block vect_strided5 for
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Friday, September 15, 2023 5:38 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; jeffreya...@gmail.com; richard.sandif...@arm.com
Subject: Re: [PATCH] test: Block
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Friday, September 15, 2023 5:38 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; jeffreya...@gmail.com; richard.sandif...@arm.com
Subject: Re: [PATCH] test: Isolate
Thanks Lehua, actually Yes.
Consider we will have a try for hashmap way and will keep you posted.
Pan
-Original Message-
From: Lehua Ding
Sent: Friday, September 15, 2023 10:29 AM
To: Li, Pan2 ; gcc-patches@gcc.gnu.org
Cc: Wang, Yanzhang ; kito.ch...@gmail.com;
juzhe.zh...@rivai.ai
Thanks Juzhe for comments, got the point and will have a try for hashmap liked
approach to get the non-overloaded later in PATCH v4. Sorry for that in the
middle of something.
Pan
From: juzhe.zh...@rivai.ai
Sent: Friday, September 15, 2023 10:21 AM
To: Li, Pan2 ; gcc-patches
Cc: Li, Pan2 ;
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Thursday, September 14, 2023 10:23 PM
To: Juzhe-Zhong
Cc: GCC Patches ; Kito Cheng ;
Jeff Law ; Robin Dapp
Subject: Re: [PATCH] RISC-V: Support VLS modes mask operations
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Thursday, September 14, 2023 3:56 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; kito.ch...@gmail.com; jeffreya...@gmail.com;
rdapp@gmail.com
Subject: Re: [PATCH V3]
Committed, thanks Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Wednesday, September 13, 2023 8:46 PM
To: juzhe.zh...@rivai.ai; gcc-patches
Cc: rdapp@gmail.com; kito.cheng ; Kito.cheng
; jeffreyalaw
Subject: Re: [PATCH] RISC-V:
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Wednesday, September 13, 2023 2:16 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Bugfix PR111362 for incorrect frm emit
LGTM :)
On Wed, Sep 13,
Committed, thanks Jeff.
Pan
-Original Message-
From: Jeff Law
Sent: Tuesday, September 12, 2023 9:12 PM
To: Li, Pan2 ; gcc-patches@gcc.gnu.org
Cc: Wang, Yanzhang ; kito.ch...@gmail.com;
juzhe.zh...@rivai.ai
Subject: Re: [PATCH v1] RISC-V: Remove unused structure in cost model
On
Committed, thanks Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Tuesday, September 12, 2023 7:07 PM
To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org
Cc: kito.ch...@sifive.com; kito.ch...@gmail.com
Subject: Re: [PATCH V5] RISC-V: Support Dynamic
>I think it's better to move 'get_non_overloaded_instance' into function_base.
Sure.
> Plz rewrite the comments, don't mention aarch64 sve.
Sure
>Could you run your rvv intrinsic api ci with this patch?
>I am worrying that the resolve stuff will destroy the existing APi support.
This patch only
Got it, will have a try.
Pan
From: juzhe.zh...@rivai.ai
Sent: Tuesday, September 12, 2023 9:30 AM
To: Li, Pan2
Cc: kito.cheng ; gcc-patches ;
Wang, Yanzhang
Subject: Re: RE: [PATCH v1] RISC-V: Implement RESOLVE_OVERLOADED_BUILTIN for
RVV intrinsic
Add a function call
We cannot leverage this instance for correctness.
The rfun of below code is the overloaded builtin is for the overloaded
function, which is registered as void xxx(void) as aarch64 did to avoid the
conflict.
Let’s take vmv_v_i32m1 as example in rfun table.
Index 0: void vmv_v(void) overloaded
For function instance with void or void arguments, it is easy as you mentioned
as below.
For generate API (to get the right hash), you need to build the rvv_type_info,
predications_type_index and rvv_op_info
from the arglist (aka vec) from hook.
Then we need to construct above parameters from
Committed, thanks Jeff.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Jeff Law via Gcc-patches
Sent: Monday, September 11, 2023 9:12 PM
To: juzhe.zh...@rivai.ai; gcc-patches
Cc: Kito.cheng ; kito.cheng
Subject: Re: [PATCH] RISC-V: Enable RVV scalable vectorization by
> No. You must construct instance. 'strcmp' is very ugly.
Strcmp here is defensive code here for early exit if not found (can be removed
for correctness), which is not required to find the right declaration.
Pan
From: juzhe.zhong
Sent: Monday, September 11, 2023 8:20 PM
To: Li, Pan2
Cc:
> -if (overloaded_p && instance.pred == PRED_TYPE_m)
> +if (overloaded_p)
Thanks for pointing this out, my misunderstanding for policy function result in
this change as mistake, will send V2 for this.
> Plz change it into :
Actually, it is not easy to convert to this approach as
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Monday, September 11, 2023 5:26 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; kito.ch...@gmail.com
Subject: Re: [PATCH] RISC-V: Remove redundant functions
LGTM
On Mon,
erting at end of previous block from the comments.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Li, Pan2 via Gcc-patches
Sent: Thursday, August 24, 2023 12:54 PM
To: Jeff Law ; gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; Wang, Yanzhang ;
kito.ch...@gmail.com
Subject: RE: [P
Committed, thanks Jeff.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Jeff Law via Gcc-patches
Sent: Sunday, September 10, 2023 9:38 PM
To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org
Cc: kito.ch...@sifive.com; kito.ch...@gmail.com
Subject: Re: [PATCH] RISC-V: Expand fixed-vlmax/vls
Committed, thanks Jeff.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Jeff Law via Gcc-patches
Sent: Sunday, September 10, 2023 11:25 PM
To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org
Cc: kito.ch...@sifive.com; kito.ch...@gmail.com
Subject: Re: [PATCH V2] RISC-V: Avoid unnecessary
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Sunday, September 10, 2023 9:22 AM
To: Juzhe-Zhong
Cc: GCC Patches ; Kito Cheng
Subject: Re: [PATCH] RISC-V: Fix dump FILE of VSETVL PASS[PR111311]
LGTM
Juzhe-Zhong 於
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Friday, September 8, 2023 4:27 PM
To: Juzhe-Zhong
Cc: GCC Patches ; Kito Cheng
Subject: Re: [PATCH] RISC-V: Suppress bogus warning for VLS types
LGTM
Juzhe-Zhong 於
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Friday, September 8, 2023 4:12 PM
To: Juzhe-Zhong
Cc: GCC Patches ; Kito Cheng
Subject: Re: [PATCH] RISC-V: Fix incorrect nregs calculation for VLS modes
LGTM
Juzhe-Zhong
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Thursday, September 7, 2023 11:39 AM
To: Juzhe-Zhong
Cc: GCC Patches ; Kito Cheng
Subject: Re: [PATCH] RISC-V: Remove incorrect earliest vsetvl post
optimization[PR111313]
Committed, thanks Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Wednesday, September 6, 2023 9:39 PM
To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org
Cc: kito.ch...@sifive.com; kito.ch...@gmail.com
Subject: Re: [PATCH] RISC-V: Remove
Committed, thanks Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Wednesday, September 6, 2023 9:38 PM
To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org
Cc: kito.ch...@sifive.com; kito.ch...@gmail.com
Subject: Re: [PATCH] RISC-V: Fix VSETVL PASS
Committed, thanks Juzhe and sorry for my silly mistake.
Pan
From: juzhe.zhong
Sent: Wednesday, September 6, 2023 8:53 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; Li, Pan2 ; Wang, Yanzhang
; kito.ch...@gmail.com
Subject: Re: [PATCH v1] RISC-V: Fix incorrect folder for VRGATHERI16 test case
Committed, thanks Juzhe.
Pan
From: juzhe.zh...@rivai.ai
Sent: Tuesday, September 5, 2023 7:14 PM
To: Li, Pan2 ; gcc-patches
Cc: Li, Pan2 ; Wang, Yanzhang ;
kito.cheng
Subject: Re: [PATCH v1] RISC-V: Support FP SGNJ autovec for VLS mode
LGTM
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Monday, September 4, 2023 3:29 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; Wang, Yanzhang ;
juzhe.zh...@rivai.ai
Subject: Re: [PATCH v1] RISC-V: Support FP16 for RVV VRGATHEREI16 intrinsic
LGTM
On Mon, Sep 4,
Committed, thanks Kito.
Pan
From: Kito Cheng
Sent: Saturday, September 2, 2023 11:41 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Support FP MAX/MIN autovec for VLS mode
Ok
Pan Li via Gcc-patches
Committed, thank Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Friday, September 1, 2023 5:58 PM
To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org
Cc: kito.ch...@sifive.com; kito.ch...@gmail.com
Subject: Re: [PATCH] RISC-V: Enable
Committed, thanks Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Friday, September 1, 2023 5:58 PM
To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org
Cc: kito.ch...@sifive.com; kito.ch...@gmail.com
Subject: Re: [PATCH] RISC-V: Add dynamic LMUL
Committed, thanks Juzhe.
Pan
From: 钟居哲
Sent: Friday, September 1, 2023 3:28 PM
To: Li, Pan2 ; gcc-patches
Cc: Li, Pan2 ; Wang, Yanzhang ;
kito.cheng
Subject: Re: [PATCH v1] RISC-V: Support FP ADD/SUB/MUL/DIV autovec for VLS mode
LGTM。
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Thursday, August 31, 2023 9:09 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Support rounding mode for VFMSAC/VFMSUB autovec
LGTM
On Thu, Aug
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Thursday, August 31, 2023 9:10 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Support rounding mode for VFMADD/VFMACC autovec
LGTM
On Thu, Aug
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Thursday, August 31, 2023 8:39 PM
To: Robin Dapp
Cc: gcc-patches@gcc.gnu.org; kito.ch...@gmail.com; Juzhe-Zhong
Subject: Re: [PATCH] RISC-V: Add Vector cost model framework
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Wednesday, August 30, 2023 8:23 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] test: Adapt slp-26.c check for RVV
On Wed, 30 Aug 2023,
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Wednesday, August 30, 2023 8:23 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] test: Add xfail into slp-reduc-7.c for RVV VLA
vectorization
On
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Wednesday, August 30, 2023 4:36 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] test: Add xfail for riscv_vector
On Wed, 30 Aug 2023, Juzhe-Zhong
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Wednesday, August 30, 2023 6:24 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] test: Fix XPASS of RVV
On Wed, 30 Aug 2023, Juzhe-Zhong wrote:
>
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Wednesday, August 30, 2023 10:57 AM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; kito.ch...@sifive.com
Subject: Re: [PATCH] RISC-V: Make sure we get VL REG operand for VLMAX
Committed, thanks Jeff and Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of ???
Sent: Wednesday, August 30, 2023 6:27 AM
To: Jeff Law ; kito.cheng
Cc: gcc-patches ; kito.cheng
Subject: Re: Re: [PATCH] RISC-V: Enable movmisalign for VLS modes
> OK for the trunk.
Thanks.
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Tuesday, August 29, 2023 9:46 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; Wang, Yanzhang ;
juzhe.zh...@rivai.ai
Subject: Re: [PATCH v1] RISC-V: Fix one ICE for vect test vect-multitypes-5
LGTM, thanks :)
On Tue,
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Monday, August 28, 2023 8:59 PM
To: Juzhe-Zhong
Cc: GCC Patches ; Kito Cheng
Subject: Re: [PATCH] RISC-V: Fix uninitialized probability for GIMPLE IR tests
LGTM
Committed, thanks Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Thursday, August 24, 2023 6:23 PM
To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org
Cc: rdapp@gmail.com; kito.ch...@gmail.com; kito.ch...@sifive.com;
jeffreya...@gmail.com
: Gcc-patches On Behalf
Of Li, Pan2 via Gcc-patches
Sent: Thursday, August 24, 2023 12:54 PM
To: Jeff Law ; gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; Wang, Yanzhang ;
kito.ch...@gmail.com
Subject: RE: [PATCH v1] Mode-Switching: Add optional EMIT_AFTER hook
Thanks Jeff.
> That implies a s
Thanks Kito, will commit it after VFMADD, VFMSAC.
Pan
-Original Message-
From: Kito Cheng
Sent: Thursday, August 24, 2023 10:24 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Support rounding mode for VFNMSAC/VFNMSUB
Committed, thanks Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Thursday, August 24, 2023 7:03 PM
To: 钟居哲 ; gcc-patches
Cc: rdapp@gmail.com; kito.cheng ; kito.cheng
; Jeff Law
Subject: Re: [PATCH] RISC-V: Add
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Sandiford via Gcc-patches
Sent: Thursday, August 24, 2023 6:34 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; rguent...@suse.de
Subject: Re: [PATCH V2] gimple_fold: Support
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Thursday, August 24, 2023 2:39 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; richard.sandif...@arm.com
Subject: Re: [PATCH] VECT: Apply LEN_FOLD_EXTRACT_LAST into
Committed, thanks Juzhe.
Pan
From: 钟居哲
Sent: Thursday, August 24, 2023 4:37 PM
To: Li, Pan2 ; gcc-patches
Cc: Li, Pan2 ; Wang, Yanzhang ;
kito.cheng
Subject: Re: [PATCH v2] RISC-V: Fix one typo in autovec.md pattern comment
LGTM
Thanks Kito. Looks need some additional change and will send the V2 for this.
Pan
From: Kito Cheng
Sent: Thursday, August 24, 2023 3:44 PM
To: Li, Pan2
Cc: GCC Patches ; 钟居哲 ; Wang,
Yanzhang
Subject: Re: [PATCH v1] RISC-V: Fix one typo in autovec.md pattern comment
LGTM
Pan Li via
Committed, thanks Kito.
Pan
From: Kito Cheng
Sent: Thursday, August 24, 2023 3:44 PM
To: Li, Pan2
Cc: GCC Patches ; 钟居哲 ; Robin
Dapp ; Jeff Law ; Wang, Yanzhang
Subject: Re: [PATCH v2] RISC-V: Refactor RVV class by frm_op_type template arg
LGTM
Pan Li via Gcc-patches
oks like add a case OP_TYPE_vx but actually not.
As Jeff pre-approved, will commit the v2 (add gcc_assert suggested by kito)
around the end of this week if no more comments.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Li, Pan2 via Gcc-patches
Sent: Tuesday, August 22, 2023 8
Thanks Jeff.
> That implies a save/restore pair around the call (possibly optimized so
> that we minimize the number of save/restores). I would have expected
> x86 to already be doing this. But maybe there's some ABI thing around
> mmx vs x86 state that allows it to be avoided
Very
Thanks Jeff for comments.
> Understood. So the natural question is why does x86/sh not need this
> for its mode switching? Don't all the same issues exist on those
> targets as well?
AFAIK, it comes from the different design principle between the risc-v and
x86/arm intrinsic API.
The
Thanks Jeff for comments, and sorry for late response.
The background comes from the CALL insn. For the RISC-V dynamic rounding mode
we need to
1. restore the frm BEFORE call, to avoid the static rounding mode pollute the
call.
2. Backup the frm AFTER call, to ensure the frm value after call
Committed as passed both the regression and bootstrap tests in x86, thanks
Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Tuesday, August 22, 2023 7:08 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; richard.sandif...@arm.com
Committed, thanks all.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Stefan Schulze Frielinghaus via Gcc-patches
Sent: Tuesday, August 22, 2023 2:23 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; richard.sandif...@arm.com; rguent...@suse.de;
li...@linux.ibm.com
Subject: Re:
Thanks Kito and Jeff for comments, will double check and address the comment in
v2.
Pan
-Original Message-
From: Kito Cheng
Sent: Monday, August 21, 2023 11:07 PM
To: Jeff Law
Cc: Li, Pan2 ; gcc-patches@gcc.gnu.org;
juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1]
Committed, thanks Jeff.
Pan
-Original Message-
From: Jeff Law
Sent: Monday, August 21, 2023 11:06 PM
To: Li, Pan2 ; gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; Wang, Yanzhang ;
kito.ch...@gmail.com
Subject: Re: [PATCH v1] RISC-V: Support RVV VFWREDUSUM.VS rounding mode
By design, HAS_FRM must be present if this insn honor FRM.
For example, if one insn don't honor FRM, there should be only one declaration
as below.
static CONSTEXPR const binop vfmax_obj;
But if one insn honors FRM, there will be 2 declaration as below for code reuse.
static CONSTEXPR const
To double confirm, you mean this declaration ?
+static CONSTEXPR const widen_freducop
vfwredusum_frm_obj;
Pan
From: juzhe.zh...@rivai.ai
Sent: Monday, August 21, 2023 2:40 PM
To: Li, Pan2 ; gcc-patches
Cc: Li, Pan2 ; Wang, Yanzhang ;
kito.cheng
Subject: Re: [PATCH v1] RISC-V: Support RVV
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Thursday, August 17, 2023 3:30 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Support RVV VFREDOSUM.VS rounding mode
intrinsic API
lgtm
On Thu,
Committed, thanks Kito.
Pan
-Original Message-
From: Li, Pan2
Sent: Thursday, August 17, 2023 2:23 PM
To: gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; Li, Pan2 ; Wang, Yanzhang
; kito.ch...@gmail.com
Subject: [PATCH v1] RISC-V: Support RVV VFREDOSUM.VS rounding mode intrinsic API
Committed, thanks Kito.
Pan
From: Kito Cheng
Sent: Thursday, August 17, 2023 11:33 AM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Support RVV VFREDUSUM.VS rounding mode
intrinsic API
Lgtm
Pan Li via Gcc-patches
Committed, thanks Kito.
Pan
From: Kito Cheng
Sent: Thursday, August 17, 2023 11:32 AM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Support RVV VFNCVT.F.{X|XU|F}.W rounding mode
intrinsic API
Lgtm
Pan Li via Gcc-patches
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Li, Pan2 via Gcc-patches
Sent: Thursday, August 17, 2023 10:18 AM
To: Kito Cheng
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: RE: [PATCH v1] RISC-V: Support RVV VFNCVT.XU.F.W
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Thursday, August 17, 2023 3:30 PM
To: Li, Pan2
Cc: juzhe.zh...@rivai.ai
Subject: Re: [PATCH v1] RISC-V: Support RVV VFNCVT.X.F.W rounding mode
intrinsic API
Yeah, I missed that, LGTM :P
On Thu, Aug 17, 2023 at
Committed, thanks Kito.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Kito Cheng via Gcc-patches
Sent: Thursday, August 17, 2023 2:08 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; kito.ch...@sifive.com; jeffreya...@gmail.com;
rdapp@gmail.com
Subject: Re: [PATCH] RISC-V:
Thanks Kito, will commit it after the VFNCVT.X.F.W one, aka the signed integer
cvt.
Pan
-Original Message-
From: Kito Cheng
Sent: Thursday, August 17, 2023 9:30 AM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v1] RISC-V: Support
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Wednesday, August 16, 2023 5:54 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@sifive.com; Wang,
Yanzhang
Subject: Re: [PATCH v2] RISC-V: Support RVV VFWCVT.XU.F.V rounding mode
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Wednesday, August 16, 2023 5:49 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@sifive.com; Wang,
Yanzhang
Subject: Re: [PATCH v1] RISC-V: Fix one build error for template default arg
Committed, thanks Kito.
Pan
From: Kito Cheng
Sent: Wednesday, August 16, 2023 3:38 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v2] RISC-V: Support RVV VFWCVT.X.F.V rounding mode
intrinsic API
lgtm
On Wed, Aug 16, 2023 at 3:32 PM
Committed, thanks Kito.
Pan
From: Kito Cheng
Sent: Wednesday, August 16, 2023 3:12 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v2] RISC-V: Support RVV VFCVT.F.X.V and VFCVT.F.XU.V
rounding mode intrinsic API
lgtm
On Wed, Aug 16,
Committed, thanks Kito.
Pan
-Original Message-
From: Kito Cheng
Sent: Wednesday, August 16, 2023 3:02 PM
To: Li, Pan2
Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Wang, Yanzhang
Subject: Re: [PATCH v2] RISC-V: Support RVV VFCVT.XU.F.V rounding mode
intrinsic API
lgtm
On
Committed, thanks Jeff.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of juzhe.zh...@rivai.ai
Sent: Wednesday, August 16, 2023 9:23 AM
To: jeffreyalaw ; gcc-patches
Cc: kito.cheng ; Kito.cheng ;
Robin Dapp
Subject: Re: Re: [PATCH] RISC-V: Support
Committed, thanks Richard.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Richard Biener via Gcc-patches
Sent: Tuesday, August 15, 2023 8:35 PM
To: Juzhe-Zhong
Cc: gcc-patches@gcc.gnu.org; richard.sandif...@arm.com
Subject: Re: [PATCH V2] VECT: Apply MASK_LEN_{LOAD_LANES,
Committed, thanks Kito.
Pan
From: Kito Cheng
Sent: Wednesday, August 16, 2023 1:57 PM
To: Li, Pan2
Cc: GCC Patches ; 钟居哲 ; Wang,
Yanzhang
Subject: Re: [PATCH v2] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic
API
LGTM
mailto:pan2...@intel.com>> 於 2023年8月16日 週三 13:17 寫道：
From: Pan
VFCVT.X.F.V rounding mode intrinsic
API
I would prefer to introduce an enum template argument and refactor
existing code later :)
On Wed, Aug 16, 2023 at 11:40 AM Li, Pan2 via Gcc-patches
wrote:
>
> That should work as well, but may require some changes to existing codes like
> declara
That should work as well, but may require some changes to existing codes like
declaration, etc.
I am OK for both the enum or inherit, and will start with the CVT parts, then
refactor the existing frm class.
Do you have any suggestion for the decision making?
Pan
-Original Message-
Thanks Kito for comments. How about leverage inherit instead of template?
AFAIK, the bool argument isn't recommended up to a point.
For example, as below to reuse the expand part.
class vfcvt_x : public function_base
{
public:
+ virtual bool has_rounding_mode_operand_p () const { return
Committed, thanks Robin.
Pan
-Original Message-
From: Gcc-patches On Behalf
Of Robin Dapp via Gcc-patches
Sent: Tuesday, August 15, 2023 6:43 PM
To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org
Cc: rdapp@gmail.com; kito.ch...@sifive.com; kito.ch...@gmail.com;
jeffreya...@gmail.com
Committed as passed both the bootstrap and regression test in x86, thanks Jeff.
Pan
-Original Message-
From: Jeff Law
Sent: Tuesday, August 15, 2023 1:21 AM
To: Li, Pan2 ; gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; kito.ch...@sifive.com; Wang, Yanzhang
Subject: Re: [PATCH v4]
Committed, thanks Kito.
Pan
From: Kito Cheng
Sent: Monday, August 14, 2023 11:02 PM
To: Li, Pan2
Cc: Wang, Yanzhang ; gcc-patches
; 钟居哲
Subject: Re: [PATCH v1] RISC-V: Support RVV VFREC7 rounding mode intrinsic API
Checked with doc and llvm implementation, LGTM
Thanks Kito for comments, updated in PATCH v2.
https://gcc.gnu.org/pipermail/gcc-patches/2023-August/627367.html
Pan
-Original Message-
From: Kito Cheng
Sent: Monday, August 14, 2023 10:07 PM
To: 钟居哲
Cc: Li, Pan2 ; gcc-patches ; Wang,
Yanzhang
Subject: Re: [PATCH v1] RISC-V:
Committed, thanks Juzhe.
Pan
From: juzhe.zh...@rivai.ai
Sent: Monday, August 14, 2023 3:44 PM
To: Li, Pan2 ; gcc-patches
Cc: Li, Pan2 ; Wang, Yanzhang ;
kito.cheng
Subject: Re: [PATCH v1] RISC-V: Support RVV VFSQRT rounding mode intrinsic API
LGTM
Committed, thanks Juzhe.
Pan
From: juzhe.zh...@rivai.ai
Sent: Monday, August 14, 2023 2:43 PM
To: Li, Pan2 ; gcc-patches
Cc: Li, Pan2 ; Wang, Yanzhang ;
kito.cheng
Subject: Re: [PATCH v1] RISC-V: Support RVV VFWNMSAC rounding mode intrinsic API
LGTM
1 - 100 of 533 matches
Mail list logo
