Re: Proposal: Improving patch tracking and review using Rietveld

2011-02-23 Thread Diego Novillo
I have addressed some of the requests brought up in this thread by modifying Rietveld's upload.py script. The new version of the upload script is called upload-gcc-patch.py and it's available at http://gcc.gnu.org/wiki/rietveld. It adds a couple of new features: 1- It takes a patch file to deter

Re: Proposal: Improving patch tracking and review using Rietveld

2011-02-01 Thread Alexandre Oliva
On Jan 28, 2011, Diego Novillo wrote: > Technically, Rietveld solves the ENOPATCH problem because the patch is > *always* available at the URL produced in the patch message. Hi, Diego, I just got your e-mail with the patch. It didn't look that big, but it will give me something useful to do in

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-28 Thread Diego Novillo
On Fri, Jan 28, 2011 at 08:25, Joseph S. Myers wrote: > If a patch (over 400kB) is being excluded from the message because of size > (and somewhat larger patches could still be included as gzipped I have not looked into upload.py's source code, so I don't know if the limits are set in the upload

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-28 Thread Joseph S. Myers
On Fri, 28 Jan 2011, Diego Novillo wrote: > On Thu, Jan 27, 2011 at 19:44, Joseph S. Myers > wrote: > > On Wed, 26 Jan 2011, Diego Novillo wrote: > > > >> 1- Rietveld always send the patch sent to it to gcc-patches@ (provided > >> the submitter added gcc-patches to the CC list). > > > >

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-28 Thread Diego Novillo
On Thu, Jan 27, 2011 at 19:44, Joseph S. Myers wrote: > On Wed, 26 Jan 2011, Diego Novillo wrote: > >> 1- Rietveld always send the patch sent to it to gcc-patches@ (provided >> the submitter added gcc-patches to the CC list). > > appears to

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Joseph S. Myers
On Wed, 26 Jan 2011, Diego Novillo wrote: > 1- Rietveld always send the patch sent to it to gcc-patches@ (provided > the submitter added gcc-patches to the CC list). appears to be a patch sent using this system where it failed to include

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Ian Lance Taylor
Richard Guenther writes: > Sure, as it is non-invasive trying it is ok. I just wanted to see if it > fixes any existing problem - it does not seem to (apart from > maybe e-mail is so hard, a minor problem compared to > programming GCC is so hard ;)) It does fix an existing problem, which is tha

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Jeffrey Yasskin
On Thu, Jan 27, 2011 at 6:53 AM, Diego Novillo wrote: > On Thu, Jan 27, 2011 at 09:49, Richard Guenther > wrote: > >> Sure, as it is non-invasive trying it is ok.  I just wanted to see if it >> fixes any existing problem - it does not seem to (apart from >> maybe e-mail is so hard, a minor proble

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Diego Novillo
On Thu, Jan 27, 2011 at 09:55, Richard Guenther wrote: > It's of course more useful if it is integrated with bugzilla, SVN and > possibly a patch tester doing bootstrap & regtest (you probably > have all that internally). Yes. Internally, it has bug fields and it detects commits. Diego.

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Richard Guenther
On Thu, Jan 27, 2011 at 3:53 PM, Diego Novillo wrote: > On Thu, Jan 27, 2011 at 09:49, Richard Guenther > wrote: > >> Sure, as it is non-invasive trying it is ok.  I just wanted to see if it >> fixes any existing problem - it does not seem to (apart from >> maybe e-mail is so hard, a minor proble

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Diego Novillo
On Thu, Jan 27, 2011 at 09:49, Richard Guenther wrote: > Sure, as it is non-invasive trying it is ok.  I just wanted to see if it > fixes any existing problem - it does not seem to (apart from > maybe e-mail is so hard, a minor problem compared to > programming GCC is so hard ;)) For it to be a

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Richard Guenther
On Thu, Jan 27, 2011 at 3:46 PM, Diego Novillo wrote: > On Thu, Jan 27, 2011 at 05:25, Richard Guenther > wrote: > >> Does the tool know when a patch is approved or rejected based on >> review e-mail content? > > I don't think so (the internal version we use does, but I haven't seen > this one im

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Diego Novillo
On Thu, Jan 27, 2011 at 05:25, Richard Guenther wrote: > Does the tool know when a patch is approved or rejected based on > review e-mail content? I don't think so (the internal version we use does, but I haven't seen this one implement the same scoring system). An issue is either open or close

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Diego Novillo
On Thu, Jan 27, 2011 at 05:24, Paolo Bonzini wrote: > How does this work WRT multiple versions of the same patch? It supports refreshening the patch. See for instance the phony review I've set up with some random changes I've made to the pph branch (http://codereview.appspot.com/4060045/). Dif

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Paolo Bonzini
On 01/26/2011 08:56 PM, Diego Novillo wrote: At Google we use a code review tool which was open sourced a couple of years ago: Rietveld (http://code.google.com/appengine/articles/rietveld.html). The best way of thinking about it is "bugzilla for patches". The system creates an entry for every p

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Richard Guenther
On Wed, Jan 26, 2011 at 8:56 PM, Diego Novillo wrote: > At Google we use a code review tool which was open sourced a couple of > years ago: Rietveld > (http://code.google.com/appengine/articles/rietveld.html). > > The best way of thinking about it is "bugzilla for patches".  The > system creates a

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Paolo Bonzini
On 01/26/2011 08:56 PM, Diego Novillo wrote: At Google we use a code review tool which was open sourced a couple of years ago: Rietveld (http://code.google.com/appengine/articles/rietveld.html). The best way of thinking about it is "bugzilla for patches". The system creates an entry for every p

Proposal: Improving patch tracking and review using Rietveld

2011-01-26 Thread Diego Novillo
At Google we use a code review tool which was open sourced a couple of years ago: Rietveld (http://code.google.com/appengine/articles/rietveld.html). The best way of thinking about it is "bugzilla for patches". The system creates an entry for every patch submitted, provides a web tool for manipul