Re: [PATCH] Redesign pthread in LIB_SPEC for systems without libpthread

2013-05-15 Thread Pavel Chupin
On Mon, Apr 29, 2013 at 5:36 PM, Alexander Ivchenko wrote: > *ping* > > thank you, > Alexander > > 2013/4/15 Pavel Chupin : >> On Tue, Apr 2, 2013 at 1:59 PM, Pavel Chupin >> wrote: >>> On Mon, Apr 1, 2013 at 7:07 PM, Pavel Chupin >>> wrote: On Android pthread is integrated into libc. >>>

Re: [PATCH, ARM][2 of 2] Enable shrink-wrap for ARM

2013-05-15 Thread Zhenqiang Chen
On 15 May 2013 06:36, Ramana Radhakrishnan wrote: > What happens to the *arm_simple_return pattern that already exists in > the backend ? Can you rebase to trunk ? The *arm_simple_return is the same as "simple_return" used by shrink-wrap. *arm_return and *arm_simple_return are not merged since *a

Break infinite folding loop

2013-05-15 Thread Marc Glisse
Hello, we can get into a cycle where: (x<0)|1 becomes (x<0)?-1:1 and (y?-1:1) becomes y|1 Contrary to what I posted in the PR, I am disabling the second transformation here. It can be done later (the x86 target partially does it in the vcond expansion), and the VEC_COND_EXPR allows us to perfo

Re: [PATCH, ARM][1 of 2] Add epilogue dwarf info for shrink-wrap

2013-05-15 Thread Zhenqiang Chen
On 15 May 2013 06:31, Ramana Radhakrishnan wrote: > Sorry this had dropped off my list of patches to review somehow but > anyway here's a first cut review. > > On Thu, Mar 21, 2013 at 6:58 AM, Zhenqiang Chen > wrote: >> Hi, >> >> When shrink-wrap is enabled, the "returns" from simple-return path

Re: [PATCH, PR preprocessor/42014] Added LAST_SOURCE_COLUMN in while loop

2013-05-15 Thread Shakthi Kannan
Hi, - Original Message - | From: "Mike Stump" | | The output of make -k, or the contents of all the .sum and .log files, \-- The output of "make -k". I did a "grep '^#'" on the output and the following results were the same, with and without the patch applied: # of expected passes

[PATCH] Refactor rtl_verify_flow_info and rtl_verify_flow_info_1

2013-05-15 Thread Teresa Johnson
This patch refactors rtl_verify_flow_info_1 and rtl_verify_flow_info by outlining the verification code into several different routines. rtl_verify_flow_info_1 in particular was getting very large. For the most part the functionality is exactly the same, although I did eliminate one redundant chec

Re: PR c++/56782 - Regression with empty pack expansions

2013-05-15 Thread Jason Merrill
On 05/15/2013 06:56 PM, Dodji Seketeli wrote: So here is what bootstraped. I thought I approved this on IRC; please apply it to trunk and 4.8. Jason

Re: [PATCH] New switch optimization pass (PR tree-optimization/54742)

2013-05-15 Thread Jeff Law
On 05/15/2013 12:28 PM, Steve Ellcey wrote: Here is a patch that adds a flag to gimple_duplicate_sese_region to tell it whether or not to update the dominator information. I had to add the same flag to copy_bbs to make it all work. How does this look? I tested it with a bootstrap and test on x

Re: GCC does not support *mmintrin.h with function specific opts

2013-05-15 Thread Sriraman Tallam
On Tue, May 14, 2013 at 3:04 AM, Jakub Jelinek wrote: > On Tue, May 14, 2013 at 10:39:13AM +0200, Jakub Jelinek wrote: >> When trying with -O2 -mno-avx: >> #ifndef __AVX__ >> #pragma GCC push_options >> #pragma GCC target("avx") >> #define __DISABLE_AVX__ >> #endif >> typedef float __v8sf __attrib

Re: [GOOGLE] Back port discriminator patches to gcc-4_8

2013-05-15 Thread Cary Coutant
>> I think warn_uninit in tree-ssa.c needs one of these: >> >> location = map_discriminator_location (location); >> >> There may still be other places where calls to >> linemap_resolve_location have been added since this patch was >> originally developed. > > Yeah, I've added location = map_discr

Re: PR c++/56782 - Regression with empty pack expansions

2013-05-15 Thread Dodji Seketeli
Jason Merrill writes: > On 05/15/2013 10:33 AM, Dodji Seketeli wrote: >> So let's rule out the particular case of a zero argument pack >> length. > > I don't think there's anything special about zero length; if > has_empty_arg is true and parm_packs is non-null, we want to return > true. Does th

Re: [GOOGLE] Back port discriminator patches to gcc-4_8

2013-05-15 Thread Dehao Chen
On Wed, May 15, 2013 at 3:44 PM, Cary Coutant wrote: >> The warning was attributed to the wrong lineno. Looks like >> discriminator does not work well when it coexists with macros. > > I think warn_uninit in tree-ssa.c needs one of these: > > location = map_discriminator_location (location); > >

Re: [GOOGLE] Back port discriminator patches to gcc-4_8

2013-05-15 Thread Cary Coutant
> The warning was attributed to the wrong lineno. Looks like > discriminator does not work well when it coexists with macros. I think warn_uninit in tree-ssa.c needs one of these: location = map_discriminator_location (location); There may still be other places where calls to linemap_resolve_l

Re: std::getline

2013-05-15 Thread Jonathan Wakely
On 15 May 2013 09:23, Jonathan Wakely wrote: > On 15 May 2013 08:50, Jonathan Wakely wrote: >> Yes, it's wrong. I think the comment was copied from operator>> and >> not corrected. I'll fix it, thanks for reporting it. > > * include/bits/basic_string.h (getline): Fix doxygen comments. > >

Re: [PATCH] New switch optimization pass (PR tree-optimization/54742)

2013-05-15 Thread Zdenek Dvorak
Hi, > > I realize you're trying to do the same, but by using the SESE copier, you're > > implicitly trying to do an incremental update. I think you're going to > > really need to look at the assumptions of that code and verify that the > > switch FSA optimization doesn't violate those assumptions

Re: [DWARF] Fix multiple register spanning location.

2013-05-15 Thread Cary Coutant
> > How about using dbx_reg_number (XVECEXP (regs, 0, i)) instead? The > > bare use of DBX_REGISTER_NUMBER earlier in that function is protected > > by a gcc_assert, but this one isn't. > > OK dbx_reg_number better than DBX_REGISTER_NUMBER here. > while we are on it, it looks like the spanning ca

Re: Using GS for TLS on x86-64 for target RDOS

2013-05-15 Thread Uros Bizjak
On Wed, May 15, 2013 at 9:00 PM, Leif Ekblad wrote: > I made the suggested changes, and enclose a new patch. <...> > It's been tested with target RDOS, but not with target Linux. > > Uros, could you commit the patch if it is acceptable? I have committed attached patch with following ChangeLog:

Unordered container insertion hints

2013-05-15 Thread François Dumont
Hi Here is a patch to consider the hint that users can give to enhancement insertion performances. As you can see I only use it for unordered_multi* containers to potentially avoid research within the bucket nodes. Note that I have use a call to _M_equals to avoid a hash code comput

[MIPS, committed] Fix PR 57260 (sibling calls vs. lazy binding)

2013-05-15 Thread Richard Sandiford
The sibling call optimisation shouldn't prevent functions from being lazily bound. This was a problem for n32 and n64 PIC, because MIPS lazy binding stubs require $gp to be valid on entry, and because $gp is a call-saved register. (o32 is OK because $gp is call-clobbered.) I was going to remove

Re: Using GS for TLS on x86-64 for target RDOS

2013-05-15 Thread Leif Ekblad
I made the suggested changes, and enclose a new patch. Change log: * gcc/config/i386/i386.c: Use DEFAULT_TLS_SEG_REG to access TLS * gcc/config/i386/i386.h: Define default segment register for TLS * gcc/config/i386/rdos.h: Added TLS configuration for RDOS It's been tested with target RDOS, but n

Re: [PATCH] New switch optimization pass (PR tree-optimization/54742)

2013-05-15 Thread Steve Ellcey
On Wed, 2013-05-15 at 10:44 +0200, Richard Biener wrote: > Indeed. I'd rather have a flag to the SESE copier that tells it the region > is SEME and in that case make it not update dominators but leave that > to the caller (which means, recompute them). It seems the code already > handles ME regi

Re: RFC: PATCH to avoid linking multiple front ends at once with parallel make

2013-05-15 Thread Mike Stump
On May 15, 2013, at 10:30 AM, Jason Merrill wrote: > In my testing, bash seems to consistently run the 0 trap when it exits due to > a signal; are there other shells that don't? trap 0 is for every exit case, normal, error, abnormal. This is why you'd see two removals if you used 0 and any oth

Re: [PATCH] Use indentation in gtype.state to show nested structure

2013-05-15 Thread Jeff Law
On 05/14/2013 01:07 PM, David Malcolm wrote: On Tue, 2013-05-14 at 11:44 -0600, Jeff Law wrote: On 05/06/2013 03:05 PM, David Malcolm wrote: [...snip review and comments about auto-checking of formatting...] Anyway, the patch is good to go. Please install. Thanks for reviewing. Probably

[PATCH, i386]: Update processor_alias_table for missing PTA_PRFCHW and PTA_FXSR flags

2013-05-15 Thread Uros Bizjak
Hello! Attached patch adds missing PTA_PRFCHW and PTA_FXSR flags to x86 processor alias table. PRFCHW CPUID flag is shared with 3dnow prefetch flag, so some additional logic is needed to avoid generating SSE prefetches for non-SSE 3dNow! targets, while still generating full set of 3dnow prefetches

Re: [PATCH, PR preprocessor/42014] Added LAST_SOURCE_COLUMN in while loop

2013-05-15 Thread Mike Stump
On May 15, 2013, at 3:22 AM, Shakthi Kannan wrote: > - Original Message - > | From: "Tom Tromey" > | > | Does this cause test suite regressions? > \-- > > I built gcc-4.8.0 with and without the patch, and ran the test suite for both > instances using: > > $ make -k check > > There wa

Re: [C++ Patch] Use inform more in pushdecl_maybe_friend_1

2013-05-15 Thread Jason Merrill
OK. Jason

Re: RFC: PATCH to avoid linking multiple front ends at once with parallel make

2013-05-15 Thread Jason Merrill
On 05/15/2013 03:51 AM, Alexandre Oliva wrote: I borrowed the general approach from libtool's shell locking machinery. I suppose it might be the case that lock files (in libtool's case) get removed twice, but I'm pretty sure there was broad portability testing in the process that led to that cons

Re: [PATCH] Fix incorrect discriminator assignment.

2013-05-15 Thread Dehao Chen
On Wed, May 15, 2013 at 9:50 AM, Cary Coutant wrote: >> gcc/ChangeLog: >> >> * tree-cfg.c (locus_descrim_hasher::hash): Only hash lineno. >> (locus_descrim_hasher::equal): Likewise. >> (next_discriminator_for_locus): Likewise. >> (assign_discriminator): Add return value. >> (make_edges): Assign mo

Re: cfgexpand.c patch for [was new port: msp430-elf]

2013-05-15 Thread Mike Stump
On May 15, 2013, at 1:27 AM, Richard Biener wrote: > My question is, if you end up with > > (truncate:PSI (reg:SI 27)) > > and then constant propagate 0x7fff to reg:SI 27, what does simplify-rtx.c > do here? Truncate to _what_ precision exactly? In my world, I change PSI to be P28SI, and

Re: [PATCH] Don't invalidate string length cache when not needed

2013-05-15 Thread Jakub Jelinek
On Wed, May 15, 2013 at 06:59:09PM +0200, Marek Polacek wrote: > This is a strlen opt patch that better optimizes attached testcase; > there's just no need to call strlen again, as we're not changing > the length of the string. Unfortunately this still handles only > p[0], not for instance p[1], p

Re: [GOOGLE] Back port discriminator patches to gcc-4_8

2013-05-15 Thread Dehao Chen
The warning was attributed to the wrong lineno. Looks like discriminator does not work well when it coexists with macros. Dehao On Wed, May 15, 2013 at 9:58 AM, Cary Coutant wrote: >> Bootstrapped. It will fail gcc.dg/uninit-6-O0.c, which also fails in >> google-4_7 branch. > > It'd be nice to f

[C++ Patch] Use inform more in pushdecl_maybe_friend_1

2013-05-15 Thread Paolo Carlini
Hi, while working on the last patch I noticed a few more cases of warning_at and permerror pairs where it makes sense to use inform. Tested x86_64-linux. Thanks, Paolo. /// /cp 2013-05-15 Paolo Carlini * name-lookup.c (pushdecl_maybe_friend_1): Replace pai

[PATCH] Don't invalidate string length cache when not needed

2013-05-15 Thread Marek Polacek
This is a strlen opt patch that better optimizes attached testcase; there's just no need to call strlen again, as we're not changing the length of the string. Unfortunately this still handles only p[0], not for instance p[1], p[2], ... so we likely don't want to put this in now. But I'm posting i

Re: [GOOGLE] Back port discriminator patches to gcc-4_8

2013-05-15 Thread Cary Coutant
> Bootstrapped. It will fail gcc.dg/uninit-6-O0.c, which also fails in > google-4_7 branch. It'd be nice to fix this -- what's the nature of the failure? -cary

Re: [PATCH] Fix incorrect discriminator assignment.

2013-05-15 Thread Cary Coutant
> gcc/ChangeLog: > > * tree-cfg.c (locus_descrim_hasher::hash): Only hash lineno. > (locus_descrim_hasher::equal): Likewise. > (next_discriminator_for_locus): Likewise. > (assign_discriminator): Add return value. > (make_edges): Assign more discriminator if necessary. > (make_cond_expr_edges): Like

Re: [PATCH] New switch optimization pass (PR tree-optimization/54742)

2013-05-15 Thread Jeff Law
On 05/15/2013 02:44 AM, Richard Biener wrote: Indeed. I'd rather have a flag to the SESE copier that tells it the region is SEME and in that case make it not update dominators but leave that to the caller (which means, recompute them). It seems the code already handles ME regions if the other

[PATCH] Fix incorrect discriminator assignment.

2013-05-15 Thread Dehao Chen
This patch fixes a common case where one line is distributed to 3 BBs, but only 1 discriminator is assigned. Bootstrapped and passed gcc regression test. OK for trunk? Thanks, Dehao gcc/ChangeLog: * tree-cfg.c (locus_descrim_hasher::hash): Only hash lineno. (locus_descrim_hasher::equal): Likew

Fix rot[hq]i3+1 patterns in m68k backend

2013-05-15 Thread Andreas Schwab
r198864 uncovered a very old bug in the m68k backend, introduced in 1997: probably due to a copy-paste bug the rot[hq]i3+1 patterns reference a non-existing operand. Apparently these patterns have never matched before. Tested on m68k-linux and checked in. Andreas. * config/m68k/m68k.md

Re: [PATCH, x86] Use vector moves in memmove expanding

2013-05-15 Thread H.J. Lu
On Wed, May 15, 2013 at 5:47 AM, Michael Zolotukhin wrote: > Hi HJ, >> You use Pmode as the largest integer mode. Is word_mode better >> than Pmode since word_mode is DI and Pmode may be SI for x32. > I updated the patch to use word_mode instead of Pmode. Bootstrap, > make check and Specs2000 ar

Re: [C++ Patch] PR 31952

2013-05-15 Thread Jason Merrill
On 05/14/2013 11:22 PM, Paolo Carlini wrote: here is a patch to produce permerrors for all the cases of shadowing mentioned in the PR (the comment gives references to the Standard). I took the occasion to change the existing pair of errors added by Janis to error + inform (thus I had to tweak 3 t

Re: [build, driver] RFC: Support compressed debug sections

2013-05-15 Thread Rainer Orth
Hi Joseph, > I still have no idea from your answer how a user is meant to know whether > to use the option when compiling, linking or both, which is what needs to > be clear from invoke.texi. > > What does it mean for the option to be supported for compiling but not > linking? What in that cas

Re: PR c++/56782 - Regression with empty pack expansions

2013-05-15 Thread Jason Merrill
On 05/15/2013 10:33 AM, Dodji Seketeli wrote: So let's rule out the particular case of a zero argument pack length. I don't think there's anything special about zero length; if has_empty_arg is true and parm_packs is non-null, we want to return true. Does that make sense to you? Jason

Re: Fix weakrefs and LTO

2013-05-15 Thread Jan Hubicka
Hi, my testcase unfortunately passes with plugin disabled only. With plugin enabled it hits a bug where we won't associate alais with its taerget across units and we optimize out the target as unused. Funilly enough this hits yet another bug in GNU LD that makes the testcase to run infinitely, wh

[PATCH, PR 57276] Add a missing break in cgraph_edge_brings_all_agg_vals_for_node

2013-05-15 Thread Martin Jambor
Hi, in PR 57276, Po-Chun Chang noticed there is a missing break in a loop in cgraph_edge_brings_all_agg_vals_for_node. This patch adds it. Bootstrapped and tested on x86_64-linux. I consider it trivial and will commit t some time tomorrow if there are no objections. Thanks, Martin 2013-05-1

RFA: fix rtl-optimization/56833

2013-05-15 Thread Joern Rennecke
The problem was that we had some optimzations added to the reload_cse_move2add pass that would attempt transformations with multi-hard-register registers, without keeping track of the validity of the values in all hard registers involved. The attached patch fixes this by updating reg_set_luid for

Re: [PATCH] Suppress -fopt-info message for non-unrolled loops

2013-05-15 Thread Richard Biener
On Wed, May 15, 2013 at 4:50 PM, Teresa Johnson wrote: > This patch suppresses -fopt-info messages for loops that were not > unrolled/peeled, to avoid emitting "Unroll loop 0 times" messages. > > Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? Ok. Thanks, Richard. > 2013-05-1

[PATCH] Suppress -fopt-info message for non-unrolled loops

2013-05-15 Thread Teresa Johnson
This patch suppresses -fopt-info messages for loops that were not unrolled/peeled, to avoid emitting "Unroll loop 0 times" messages. Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? 2013-05-15 Teresa Johnson * loop-unroll.c (report_unroll_peel): Check decision before

Re: [PATCH] Add SCEV cprop dump

2013-05-15 Thread Marek Polacek
On Wed, May 15, 2013 at 02:58:22PM +0200, Richard Biener wrote: > On Wed, May 15, 2013 at 2:07 PM, Marek Polacek wrote: > > /* Replace the uses of the name. */ > > if (name != ev) > > - replace_uses_by (name, ev); > > + { > > + replace_uses_by (

PR c++/56782 - Regression with empty pack expansions

2013-05-15 Thread Dodji Seketeli
Hello, In the example of the patch below, during the instantiation of is_convertible at #1, we see at some point Tuple<>. (Let's note '{}' an empty argument pack.) In that context, during the partial specialization the member template template Tuple<>::Tuple...

[libffi] Fix several libffi testsuite failures on 64-bit SPARC and PowerPC (PR libffi/56033)

2013-05-15 Thread Rainer Orth
As reported in the PR, the recent libffi import into the gcc tree caused a couple of testsuite failures on 64-bit big-endian targets (like SPARC or PowerPC). The following patch (mostly by Dominique) fixes them and finally gets us clean libffi testsuite results. Tested on sparc-sun-solaris2.11 on

Re: [PATCH] Improvements to -freorder-blocks-and-partition support

2013-05-15 Thread Teresa Johnson
On Tue, May 14, 2013 at 11:04 PM, Jeff Law wrote: > On 05/15/2013 12:02 AM, Steven Bosscher wrote: >> >> On Wed, May 15, 2013 at 12:50 AM, Teresa Johnson wrote: >>> >>> On Tue, May 14, 2013 at 2:49 PM, Steven Bosscher wrote: One nit: Can you keep the verify_hot_cold_block_grouping functi

Re: [PATCH] Allow nested use of attributes in MD-files

2013-05-15 Thread Michael Zolotukhin
Ping. On 9 May 2013 17:07, Michael Zolotukhin wrote: >> Sweet, I like it… > Thanks! > Who could approve it for commit if it's ok? > > Best regards, Michael > > On 28 April 2013 23:43, Mike Stump wrote: >> On Apr 26, 2013, at 8:17 AM, Michael Zolotukhin >> wrote: >>> This patch allows to use at

Re: [ping][patch, ARM] Fix PR42017, LR not used in leaf functions

2013-05-15 Thread Chung-Lin Tang
On 13/5/15 9:43 PM, Kugan wrote: > On 14/05/13 19:18, Ramana Radhakrishnan wrote: >> On 05/13/13 04:15, Kugan wrote: >>> Hi, >>> >>> Ping this patch by Chung-Lin. >>> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01179.html >>> >>> This patch allows lr registers to be used in leaf functions for ARM.

Re: [ping][patch, ARM] Fix PR42017, LR not used in leaf functions

2013-05-15 Thread Kugan
On 14/05/13 19:18, Ramana Radhakrishnan wrote: On 05/13/13 04:15, Kugan wrote: Hi, Ping this patch by Chung-Lin. http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01179.html This patch allows lr registers to be used in leaf functions for ARM. There were some concerns about performance regression i

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-15 Thread Julian Brown
On Tue, 7 May 2013 16:05:50 +0100 Julian Brown wrote: > On Mon, 6 May 2013 11:53:20 -0600 > Jeff Law wrote: > > > On 05/03/2013 07:10 AM, Julian Brown wrote: > > > Hi, > > > > > > This is a patch which fixes a latent bug in RTL GCSE/PRE, > > > described more fully in: > > > > > > http://gcc.gnu

Re: [PATCH] Pattern recognizer for rotates

2013-05-15 Thread Richard Biener
On Fri, 10 May 2013, Jakub Jelinek wrote: > Hi! > > This patch allows us to vectorize attached testcases again, rot1.c > and rot3.c e.g. with -O3 -mavx, rot2.c only with -O3 -mavx2. > > The problem with rot2.c is that the rotation count is there > vect_external_def, but when we insert some stmts

Re: [PATCH] Add SCEV cprop dump

2013-05-15 Thread Richard Biener
On Wed, May 15, 2013 at 2:07 PM, Marek Polacek wrote: > This is an attempt to add more dumping to scev_cprop. I don't know what > exactly > would you want to see in there, so now it prints e.g.: > > (replace_stmt > (virtual_p_1 with 0) > ) > > and > > (final_value_replacement > o__lsm.3_2 =

Re: [PATCH, x86] Use vector moves in memmove expanding

2013-05-15 Thread Michael Zolotukhin
Hi HJ, > You use Pmode as the largest integer mode. Is word_mode better > than Pmode since word_mode is DI and Pmode may be SI for x32. I updated the patch to use word_mode instead of Pmode. Bootstrap, make check and Specs2000 are ok. Thanks, Michael On 14 May 2013 19:55, H.J. Lu wrote: > On T

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-15 Thread Richard Sandiford
Chung-Lin Tang writes: > On 13/5/10 6:37 PM, Richard Sandiford wrote: >> Chung-Lin Tang writes: >>> +case UNSPEC: >>> + /* Reach for a contained symbol. */ >>> + return nonzero_address_p (XVECEXP (x, 0, 0)); >> >> I don't think this is safe. UNSPECs really are unspecified :-), >>

[PATCH] Add SCEV cprop dump

2013-05-15 Thread Marek Polacek
This is an attempt to add more dumping to scev_cprop. I don't know what exactly would you want to see in there, so now it prints e.g.: (replace_stmt (virtual_p_1 with 0) ) and (final_value_replacement o__lsm.3_2 = PHI <_6(4)> with o__lsm.3_2 = pretmp_10 + 20; ) Comments? Maybe tha

[Patch ARM] Fix PR target/19599

2013-05-15 Thread Ramana Radhakrishnan
Hi, Atlast a fix for this PR which has been on my plate for ages. I've chosen to create a new class for all caller save registers rather than just sticking to maybe a single temporary register as IP_REGNUM on the grounds that this means we have more registers to choose from - we need another

[ping] Re: [PATCH] Remove unnecessaily included limits.h in libgcc2.c

2013-05-15 Thread Matthias Klose
ping? regenerated the patch for the trunk, check with builds on arm-linux-gnueabihf and x86_64-linux-gnu Matthias * libgcc2.c: Don't include . Am 14.01.2013 22:54, schrieb Matthias Klose: > Am 04.01.2013 20:01, schrieb Wookey: >> I filed http://gcc.gnu.org/bugzilla/show_bug.cgi?id=557

Re: [GOOGLE] Back port discriminator patches to gcc-4_8

2013-05-15 Thread Diego Novillo
On 2013-05-14 22:46 , Dehao Chen wrote: This patch ports r173196 from google-main and r190269 from google-4_7 to add discriminator support in google-4_8 branch. Bootstrapped. It will fail gcc.dg/uninit-6-O0.c, which also fails in google-4_7 branch. OK to backport to google-4_8 branch? If ther

[PATCH] Fix -fopt-info-vec-optimized

2013-05-15 Thread Richard Biener
This fixes -fopt-info-vec-optimized to be less of an unreadable mess ... in fact the following tames it down to just print LOOP VECTORIZED and BASIC BLOCK VECTORIZED messages, nothing else. In particular not messages from analysis time. Eventually a "verbose" flavor could enable some more message

Re: [libgfortran, build] Use -z ignore instead of --as-needed on Solaris

2013-05-15 Thread Rainer Orth
Hi Tobias, > Rainer Orth wrote: >> As requested by Tobias, this patch supports -z ignore with Solaris ld >> instead of GNU ld's --as-needed. > > For reference, my request was motivated by > http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00425.html > (The patch has been approved, but it does not seem

Re: [Patch, Aarch64] [RFC] : Macros for profile code generation to enable gprof support

2013-05-15 Thread Marcus Shawcroft
On 12/05/13 17:47, Venkataramanan Kumar wrote: +# We support profiling for AArch64 linux target. +if { [istarget aarch64*-linux-*] + && ($test_what == "-p" || $test_what == "-pg") } { + return 1 } Can't this clause be removed completely now ? We are not supporting profiling in "

Re: [PATCH, PR preprocessor/42014] Added LAST_SOURCE_COLUMN in while loop

2013-05-15 Thread Shakthi Kannan
Hi, - Original Message - | From: "Tom Tromey" | | Does this cause test suite regressions? \-- I built gcc-4.8.0 with and without the patch, and ran the test suite for both instances using: $ make -k check There was no difference in the test result output. Is this the same as the tes

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-15 Thread Chung-Lin Tang
On 13/5/10 6:37 PM, Richard Sandiford wrote: > Chung-Lin Tang writes: >> +case UNSPEC: >> + /* Reach for a contained symbol. */ >> + return nonzero_address_p (XVECEXP (x, 0, 0)); > > I don't think this is safe. UNSPECs really are unspecified :-), > so we can't assume that (unspec

Re: [PATCH] Consistent and slightly better IPA dumps

2013-05-15 Thread Jan Hubicka
> Hi, > > I have noticed that whereas all of the dumps in ipa-inline*, ipa-cp.c, > ipa-prop.c and elsewhere dump node UIDs, function dump_cgraph_node, > which is the core of call graph dumping, dumps node->symbol.uid. This > unnecessarily makes it more difficult to see what has happened to a > no

[Committed] S/390: Adjust register move costs for z10 or higher

2013-05-15 Thread Andreas Krebbel
Hi, I've committed the attached patch. With z10 introduction of ldgr and lgdr I've adjusted SECONDARY_MEMORY_NEEDED but forgot about the GPR-FPR reg move cost hook. Comitted after testing on s390x and s390 (-march=zEC12). Bye, -Andreas- 2013-05-15 Andreas Krebbel * config/s390/s3

Re: [PATCH] New switch optimization pass (PR tree-optimization/54742)

2013-05-15 Thread Steven Bosscher
On Wed, May 15, 2013 at 10:44 AM, Richard Biener wrote: > Indeed. I'd rather have a flag to the SESE copier that tells it the region > is SEME and in that case make it not update dominators but leave that > to the caller (which means, recompute them). And rename the copier to SEME copier instead

Re: [PATCH] New switch optimization pass (PR tree-optimization/54742)

2013-05-15 Thread Richard Biener
On Wed, May 15, 2013 at 7:02 AM, Jeff Law wrote: > On 05/14/2013 03:14 PM, Steve Ellcey wrote: >> >> >> While Jeff works on the threader, I was wondering if I could get approval >> for >> just the dominance.c part of the patch. This would allow me to use my >> pass as >> a dynamically loaded opti

Re: Print column information in dump_loc

2013-05-15 Thread Richard Biener
On Tue, May 14, 2013 at 6:58 PM, Easwaran Raman wrote: > This patch dumps the column number as part of dump_loc making the > output similar to inform(). This allows these messages to be pattern > matched by dg_message. Bootstraps with this change. Ok for trunk? Eh, column numbers are mostly noise

Re: [PATCH] Add explicit default constructors where required by the standard

2013-05-15 Thread Evgeniy Stepanov
Thanks! On Wed, May 15, 2013 at 3:05 AM, Jonathan Wakely wrote: > On 14 May 2013 10:56, Jonathan Wakely wrote: >> On 14 May 2013 10:45, Evgeniy Stepanov wrote: >>> This must have fallen through the cracks. >> >> It's still in my Git branch at home. I've been too busy to push any >> commits recent

Re: cfgexpand.c patch for [was new port: msp430-elf]

2013-05-15 Thread Richard Biener
On Tue, May 14, 2013 at 6:03 PM, DJ Delorie wrote: > >> How can you then ever "truncate" from SImode to PSImode? > > If you use PARTIAL_INT_MODE(), you get a PSImode that has a "default" > bitsize (i.e. the value stored in the data structure) that's the same > as SImode, that is, 32. There is no

Re: std::getline

2013-05-15 Thread Jonathan Wakely
On 15 May 2013 08:50, Jonathan Wakely wrote: > On 15 May 2013 06:57, ntysdd wrote: >> Hi, >> >> I found this in the file `include\bits\basic_string.h': >> /** >> * @brief Read a line from stream into a string. >> * @param __is Input stream. >> * @param __str Buffer to store into. >> * @return Refer

[PATCH] Fix PR57275

2013-05-15 Thread Richard Biener
This fixes PR57275 - when moving dependency testing for gather loads from data-ref analysis to dependence analysis I put in the wrong return value (oops) for failed analysis. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2013-05-15 Richard Biener PR

Re: RFC: PATCH to avoid linking multiple front ends at once with parallel make

2013-05-15 Thread Andreas Schwab
Alexandre Oliva writes: > constructs as 'rm ; (exit $status); exit', but I won't even pretend > to recall the rationale for that ;-) See the autoconf manual. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And

Re: RFC: PATCH to avoid linking multiple front ends at once with parallel make

2013-05-15 Thread Alexandre Oliva
On May 14, 2013, Jason Merrill wrote: >> trap 'rmdir "$lockdir"; exit $status' 0 1 2 15 > In my testing I found that trapping signals other than 0 resulted in > trying to rmdir twice if the process is interrupted. Interesting... I guess it's one for the signal and one for the exit... I borrow

RE: [PATCH,i386] FSGSBASE for AMD bdver3

2013-05-15 Thread Gopalasubramanian, Ganesh
Thank you Uros! Patch for FSGSBASE instruction generation for AMD bdver3 committed to trunk (rr198916). Regards Ganesh -Original Message- From: Uros Bizjak [mailto:ubiz...@gmail.com] Sent: Monday, May 13, 2013 5:50 PM To: Gopalasubramanian, Ganesh Cc: gcc-patches@gcc.gnu.org Subject: R