Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

2014-05-09 Thread Jeff Law
On 05/08/14 02:07, Zhenqiang Chen wrote: Hi, The patch splits the live_edge for move_insn_for_shrink_wrap to sink the copy out of the entry block. Bootstrap and no make check regression on X86-64 and ARM. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-05-08 Zhenqiang Chen

Re: RFC: Faster for_each_rtx-like iterators

2014-05-09 Thread Jeff Law
On 05/07/14 14:52, Richard Sandiford wrote: I noticed for_each_rtx showing up in profiles and thought I'd have a go at using worklist-based iterators instead. So far I have three: FOR_EACH_SUBRTX: iterates over const_rtx subrtxes of a const_rtx FOR_EACH_SUBRTX_VAR: iterates over rtx

Re: [PATCH] copyprop_hardreg_forward needs to check HARD_REGNO_CALL_PART_CLOBBERED

2014-05-09 Thread Jeff Law
On 05/07/14 09:52, Matthew Fortune wrote: The MIPS O32 FPXX ABI exposes a bug in regcprop where call part clobbered information is not checked when calculating clobbered registers. This is only one of many places that regs_invalidated_by_call is used without also checking

Re: [PATCH Ping v2] Extend -fstack-protector-strong to cover calls with return slot

2014-05-09 Thread Jeff Law
On 05/05/14 05:58, Florian Weimer wrote: On 02/03/2014 10:05 AM, Florian Weimer wrote: On 01/17/2014 11:26 AM, Florian Weimer wrote: On 01/08/2014 03:57 PM, Florian Weimer wrote: What about the attached version? It still does not exactly match your original suggestion because

Re: [patch] Shorten Windows path

2014-05-09 Thread Jeff Law
On 04/25/14 04:16, Joey Ye wrote: Ping I've spoke with Kai a bit about this and he thinks it's appropriate and desirable to shorten paths on these kinds of filesystems. Ok for the trunk. Thanks and sorry for the wait, Jeff

Re: [PATCH 19/89] Const-correctness of gimple_call_builtin_p

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * gimple.h (gimple_builtin_call_types_compatible_p): Accept a const_gimple, rather than a gimple. (gimple_call_builtin_p): Likewise, for the three variants. * gimple.c (gimple_builtin_call_types_compatible_p):

Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

2014-05-09 Thread Zhenqiang Chen
On 9 May 2014 14:08, Jeff Law l...@redhat.com wrote: On 05/08/14 02:07, Zhenqiang Chen wrote: Hi, The patch splits the live_edge for move_insn_for_shrink_wrap to sink the copy out of the entry block. Bootstrap and no make check regression on X86-64 and ARM. OK for trunk? Thanks!

Re: [PATCH 0/3] Compile-time gimple checking, without typedefs

2014-05-09 Thread Jeff Law
On 05/02/14 15:56, David Malcolm wrote: This patch series demonstrates a way of reimplementing the 89-patch series: [PATCH 00/89] Compile-time gimple-checking http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01148.html whilst avoiding introducing a pair of gimple_foo/const_gimple_foo

Re: [RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-05-09 Thread Eric Botcazou
It has been two weeks since Richard commited this to trunk. Perhaps it's ok to backport to 4.8 branch now? Richard, can you do that before the 4.8.3 release? Thanks in advance. -- Eric Botcazou

Re: [PATCH, 1/2] shrink wrap a function with a single loop: copy propagation

2014-05-09 Thread Jeff Law
On 05/08/14 02:06, Zhenqiang Chen wrote: Hi, Similar issue was discussed in thread http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01145.html. The patches are close to Jeff's suggestion: sink just the moves out of the incoming argument registers. The patch and following one try to shrink wrap a

Re: [PATCH 1/3] Handwritten part of conversion of gimple to gimple_stmt *

2014-05-09 Thread Jeff Law
On 05/02/14 15:56, David Malcolm wrote: gcc/ * coretypes.h (gimple): Drop typedef. (const_gimple): Likewise. (gimple_seq): Convert from being a gimple to a gimple_stmt *. So instead, we just want to convert from gimple to gimple *, right? That was my understanding of

Re: [PATCH 2/3] Autogenerated part of conversion of gimple to gimple_stmt *

2014-05-09 Thread Jeff Law
On 05/02/14 15:56, David Malcolm wrote: This autogenerated patch is 1.2M in size, so I've uploaded it to: http://dmalcolm.fedorapeople.org/gcc/large-patches/e5a7d209a8789e6df9eccb9210d4a6dbe26d0fd4-0002-Autogenerated-part-of-conversion-of-gimple-to-gimple.patch to avoid being anti-social on the

Re: [PATCH 3/3] Introduce gimple_switch and use it in various places

2014-05-09 Thread Jeff Law
On 05/02/14 15:56, David Malcolm wrote: gcc/ * gimple.h (gimple_switch): New subclass of gimple_stmt_with_ops, adding the invariant that stmt-code == GIMPLE_SWITCH. (is_a_helper gimple_switch *::test): New. (is_a_helper const gimple_switch *::test): New.

Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly

2014-05-09 Thread John Marino
On 5/9/2014 07:26, Jeff Law wrote: On 05/03/14 01:11, John Marino wrote: In config.gcc: +no | gnat | single) + # Let these non-posix thread selections fall through if requested Support for gnat as a thread model was removed in 2011. So I think you need to remove that case. I

Re: [RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-05-09 Thread Richard Sandiford
Eric Botcazou ebotca...@adacore.com writes: It has been two weeks since Richard commited this to trunk. Perhaps it's ok to backport to 4.8 branch now? Richard, can you do that before the 4.8.3 release? Thanks in advance. Sure, that'd be fine by me. I'm not sure whether the backport has been

[C PATCH] Add location to error_init (PR c/61096)

2014-05-09 Thread Marek Polacek
Another piece of puzzle. error_init didn't have a location parameter, so initialization errors had wrong column info. This patch adds location parameter to error_init and to a few of other functions. The testcases show what has better column info now. Note what I wrote in

Re: [PATCH, 1/2] shrink wrap a function with a single loop: copy propagation

2014-05-09 Thread Zhenqiang Chen
On 9 May 2014 14:00, Jeff Law l...@redhat.com wrote: On 05/08/14 02:06, Zhenqiang Chen wrote: Hi, Similar issue was discussed in thread http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01145.html. The patches are close to Jeff's suggestion: sink just the moves out of the incoming argument

[PATCH] Remove tree-ssa-propagate vectors out of GC space

2014-05-09 Thread Richard Biener
Boostrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-05-09 Richard Biener rguent...@suse.de * Makefile.in (GTFILES): Remove tree-ssa-propagate.c. * tree-ssa-propagate.c: Do not include gt-tree-ssa-propagate.h. (interesting_ssa_edges,

Re: [patch] change specific int128 - generic intN

2014-05-09 Thread Marc Glisse
On Thu, 8 May 2014, DJ Delorie wrote: Assuming that the formula sizeof(type)*char_bit==precision works for all It doesn't. THe MSP430 has __int20 for example. Well, it wasn't a hard requirement, it is just that the library has to use a more complicated way to get the precision (use

[patch] Partially fix PR debug/53927

2014-05-09 Thread Eric Botcazou
Hi, this makes sure we always generate a static chain for nested functions at -O0 and force it onto the stack in this case so that DW_AT_static_link is always meaningful (but not necessarily fully correct, see the audit trail). FWIW this has been done for years in AdaCore's compilers. Tested

Re: [PATCH] Fix PR c++/60463, PR c++/60755 Incorrect discard of const qualifier

2014-05-09 Thread Momchil Velikov
Ping On 14.04.2014 23:53, Momchil Velikov wrote: Hello, During overload resolution of function calls in the body of a lambda it is possible to use an implicit/dummy 'this', which differs in const-ness from the actual 'this' that would be captured, resulting in choosing a non-const member

Re: [wide-int] Add fast path for hosts with HWI widening multiplication

2014-05-09 Thread Ramana Radhakrishnan
+#if GCC_VERSION = 3000 (W_TYPE_SIZE == 32 || defined (__SIZEOF_INT128__)) W_TYPE_SIZE == 32 is always false and on 32-bit hosts, __SIZEOF_INT128__ won't be defined. Right, but we won't try to use TImode if in future we do revert to using 32-bit types for 32-bit hosts. For now, I've

Re: [RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-05-09 Thread Jakub Jelinek
On Fri, May 09, 2014 at 10:16:14AM +0200, Eric Botcazou wrote: Sure, that'd be fine by me. I'm not sure whether the backport has been approved yet though. At least it looks fine to me... [I still don't grasp this wait-a-little-before-backporting policy, it always leads to forgotten

Re: [PATCH] testsuite: Register loaded libs

2014-05-09 Thread Sebastian Huber
On 2014-04-28 18:24, Mike Stump wrote: On Apr 28, 2014, at 12:32 AM, Sebastian Hubersebastian.hu...@embedded-brains.de wrote: On 2014-04-28 04:23, Mike Stump wrote: On Apr 27, 2014, at 10:45 AM, Sebastian Hubersebastian.hu...@embedded-brains.de wrote: 2014-04-27 Sebastian

Re: [wide-int] Add fast path for hosts with HWI widening multiplication

2014-05-09 Thread Richard Earnshaw
On 08/05/14 19:31, Richard Sandiford wrote: Joseph S. Myers jos...@codesourcery.com writes: On Thu, 8 May 2014, Ramana Radhakrishnan wrote: DATE Ramana Radhakrishnan ramana.radhakrish...@arm.com * wide-int.cc (UTItype): Define. (UDWtype): Define for appropriate W_TYPE_SIZE.

Re: [RFC][PING^2] Do not consider volatile asms as optimization barriers #1

2014-05-09 Thread Richard Sandiford
Eric Botcazou ebotca...@adacore.com writes: Sure, that'd be fine by me. I'm not sure whether the backport has been approved yet though. At least it looks fine to me... OK, thanks. Richard also gave an RM's OK on IRC so I've now applied it. [I still don't grasp this

RE: [PATCH] Fix PR54733 Optimize endian independent load/store

2014-05-09 Thread Thomas Preud'homme
Sorry, took longer than expected as I got distracted by some other patch. I merged the whole patchset in a single patch as I was told the current setup is actually more difficult to read. Here are the updated ChangeLogs: *** gcc/ChangeLog *** 2014-05-09 Thomas Preud'homme

Re: [PATCH, Pointer Bounds Checker 1/x] Pointer bounds type and mode

2014-05-09 Thread Richard Biener
On Thu, May 8, 2014 at 9:45 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, May 8, 2014 at 12:28 PM, Jeff Law l...@redhat.com wrote: On 05/08/14 02:17, Ilya Enkovich wrote: Right. Richi explicitly wanted the entire set approved before staging in any of the bits. I thought it would be

RE: [PATCH] Add support for MIPS r3 and r5

2014-05-09 Thread Andrew Bennett
-Original Message- From: Richard Sandiford [mailto:rdsandif...@googlemail.com] Sent: 08 May 2014 20:28 To: Andrew Bennett Cc: gcc-patches@gcc.gnu.org; Matthew Fortune; Saeed Ghazanfar; Rich Fuhler Subject: Re: [PATCH] Add support for MIPS r3 and r5 Andrew Bennett

Re: [PATCH 1/3] Handwritten part of conversion of gimple to gimple_stmt *

2014-05-09 Thread Richard Biener
On Fri, May 9, 2014 at 8:49 AM, Jeff Law l...@redhat.com wrote: On 05/02/14 15:56, David Malcolm wrote: gcc/ * coretypes.h (gimple): Drop typedef. (const_gimple): Likewise. (gimple_seq): Convert from being a gimple to a gimple_stmt *. So instead, we just want to

Re: [patch,avr] Fix PR61055: Wrong branch instruction after INC, DEC.

2014-05-09 Thread Denis Chertykov
2014-05-08 17:04 GMT+04:00 Georg-Johann Lay a...@gjlay.de: Some instructions like INC, DEC, NEG currently set cc0 to set_zn which is not the whole story because they also set the V flag. This leads to a wrong branch instruction in the remainder as cc0 is used. Fix is to do same as clobber

Re: [PATCH] Add support for MIPS r3 and r5

2014-05-09 Thread Richard Sandiford
Andrew Bennett andrew.benn...@imgtec.com writes: @@ -141,7 +151,8 @@ along with GCC; see the file COPYING3. If not see %{EL:-m elf32lmip} \ %{EB:-m elf32bmip} \ %(endian_spec) \ - %{G*} %{mips1} %{mips2} %{mips3} %{mips4} %{mips32} %{mips32r2} %{mips64} \ + %{G*}

RE: [PATCH] Add support for MIPS r3 and r5

2014-05-09 Thread Andrew Bennett
-Original Message- From: Richard Sandiford [mailto:rdsandif...@googlemail.com] Sent: 09 May 2014 12:07 To: Andrew Bennett Cc: gcc-patches@gcc.gnu.org; Matthew Fortune; Saeed Ghazanfar; Rich Fuhler Subject: Re: [PATCH] Add support for MIPS r3 and r5 Andrew Bennett

[backport,avr,4.9] Fix typo in avr-mcus.de for built-in macro

2014-05-09 Thread Georg-Johann Lay
Hi, I just applied the following backport to 4.9: http://gcc.gnu.org/ml/gcc-cvs/2014-05/msg00310.html Thanks. 2014-04-16 Pitchumani Sivanupandi pitchuman...@atmel.com Backport from 2014-04-16 trunk r209446 2014-04-16 Pitchumani Sivanupandi pitchuman...@atmel.com

[patch,avr,committed]: Fix build warning for -1 in unsigned int initializers.

2014-05-09 Thread Georg-Johann Lay
http://gcc.gnu.org/ml/gcc-cvs/2014-05/msg00311.html Hi, applied this obvious patch to trunk in order to fix build warnings like these: gcc/config/avr/avr-fixed.md:434:59: warning: narrowing conversion of ‘-1’ from ‘int’ to ‘const unsigned int’ inside { } is ill-formed in C++11 [-Wnarrowing]

[PATCH]: fix pr61111 Fixed width of mask.

2014-05-09 Thread Kenneth Zadeck
2014-05-09 Kenneth Zadeck zad...@naturalbridge.com PR middle-end/6 * fold-const.c (fold_binary_loc): Changed width of mask. committed as revision 210274. kenny Index: gcc/fold-const.c === --- gcc/fold-const.c

[patch,arm] Add GCC runtime library exceptions to files that go into libgcc

2014-05-09 Thread Georg-Johann Lay
This patch adds GCC Runtime Library Exception to files that go into libgcc because libgcc2.c includes tm.h and libgcc_tm.h. Most of these files contain much code, some used by libgcc, some not. Some potential users of (lib)gcc have objections that missing RLE might infect their target code.

Re: [PATCH, Pointer Bounds Checker 1/x] Pointer bounds type and mode

2014-05-09 Thread Jeff Law
On 05/09/14 04:36, Richard Biener wrote: On Thu, May 8, 2014 at 9:45 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, May 8, 2014 at 12:28 PM, Jeff Law l...@redhat.com wrote: On 05/08/14 02:17, Ilya Enkovich wrote: Right. Richi explicitly wanted the entire set approved before staging in any

fix fortran 0 lengthed arrays

2014-05-09 Thread Mike Stump
This fixes a small bug in the conversion of the fortran front-end conversion to wide-int. PR fortran/61109 * trans-array.c (gfc_conv_array_initializer): Fix wide-int conversion bug. Index: trans-array.c ===

Re: [PATCH 04/89] Introduce gimple_cond and use it in various places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * coretypes.h (gimple_cond): New typedef. (const_gimple_cond): Likewise. * gimple.h (struct gimple_statement_cond): New subclass of gimple_statement_with_ops, adding the invariant that stmt-code == GIMPLE_COND.

Re: [PATCH 05/89] Introduce gimple_assign and use it in various places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * coretypes.h (gimple_assign): New typedef. (const_gimple_assign): New typedef. * gimple.h (struct gimple_statement_assign): New subclass of gimple_statement_with_memory_ops, adding the invariant that stmt-code

Re: [PATCH 06/89] Introduce gimple_label and use it in a few places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * coretypes.h (gimple_label): New typedef. (const_gimple_label): New typedef. * gimple.h (struct gimple_statement_label): New subclass of gimple_statement_with_ops, adding the invariant that stmt-code ==

Re: [PATCH 07/89] Introduce gimple_debug and use it in a few places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * coretypes.h (gimple_debug): New typedef. (const_gimple_debug): New typedef. * gimple.h (struct gimple_statement_debug): New subclass of gimple_statement_with_ops, adding the invariant that stmt-code ==

Re: [patch] make the libstdc++ pretty printers compatible with both Python 2 and Python3

2014-05-09 Thread Jonathan Wakely
[ping] On 11 January 2014 19:19, Jonathan Wakely wrote: On 31 October 2013 16:46, Tom Tromey tro...@redhat.com wrote: Matthias == Matthias Klose d...@ubuntu.com writes: Matthias Starting with gdb 7.6, gdb can be linked with both Python 2.x Matthias and Python 3.x. Therefore the pretty

[PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-09 Thread Andrew Burgess
Fixes issue: https://sourceware.org/bugzilla/show_bug.cgi?id=16817 A call to gnu_special within internal_cplus_demangle could cause memory resources to be allocated, even if the demangle eventually fails. The following call into demangle_prefix will then be passed some partially initialised

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-09 Thread Dominique Dhumieres
This fixes a regression introduced with 4.8, ... This caused pr61126. Dominique

Re: [PATCH 1/2] teach mklog to get name / email from git config when available

2014-05-09 Thread Diego Novillo
On Mon, Apr 28, 2014 at 10:11 PM, tsaund...@mozilla.com wrote: 2014-04-28 Trevor Saunders tbsau...@mozilla.com * mklog: if in a git checkout try to get name and email from git. --- contrib/mklog | 14 ++ 1 file changed, 14 insertions(+) diff --git a/contrib/mklog

Re: [PATCH 2/2] allow running mklog as a filter

2014-05-09 Thread Diego Novillo
On Tue, Apr 29, 2014 at 6:16 AM, Trevor Saunders tsaund...@mozilla.com wrote: +# In any case if we got the diff on stdin then write the ChangeLog to stdout. Hm, this is breaks semantics: you only dump CL instead of CL+diff just because diff comes from stdin. Perhaps we could append contents

[PATCH] Fix cgraph dumping bug

2014-05-09 Thread Teresa Johnson
Fixed a place where the wrong dump file was being used, leading to an inconsistency and seg fault when dump_file was non-NULL but cgraph_dump_file was NULL. Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2014-05-09 Teresa Johnson tejohn...@google.com

[PATCH] Add missing -fdump-* options

2014-05-09 Thread Teresa Johnson
I discovered that the support for the documented -fdump-* options optimized, missed, note and optall was missing. Added that and fixed a minor typo in the documentation. Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2014-05-09 Teresa Johnson

[patch] Remove shadow variable

2014-05-09 Thread James Norris
Hi! Removed three occurrences of a shadow variable. Bootstrapped and tested on x86-64-unknown-linux-gnu. 2014-05-09 James Norris jnor...@codesourcery.com * omp-low.c (expand_parallel_call): Remove shadow variable. (expand_omp_taskreg): Likewise. diff --git a/gcc/omp-low.c

Re: [patch] Remove shadow variable

2014-05-09 Thread Jakub Jelinek
On Fri, May 09, 2014 at 11:03:35AM -0500, James Norris wrote: Removed three occurrences of a shadow variable. Bootstrapped and tested on x86-64-unknown-linux-gnu. 2014-05-09 James Norris jnor...@codesourcery.com * omp-low.c (expand_parallel_call): Remove shadow variable.

Re: Add AArch64 to backends.html

2014-05-09 Thread Andrew Pinski
On Fri, May 9, 2014 at 9:27 AM, Richard Earnshaw rearn...@arm.com wrote: It was pointed out that AArch64 wasn't listed in backends.html. This is an attempt to rectify that. Hopefully I've got all the bits the right way around. You missed: r Port can switch between ILP32 and LP64 at

Re: [PATCH] Fix GDB PR15559 (inferior calls using thiscall calling convention)

2014-05-09 Thread Julian Brown
On Wed, 7 May 2014 09:41:27 -0600 Tom Tromey tro...@redhat.com wrote: Tom The usual approach is some appropriate text somewhere on the GCC Tom wiki (though I suppose a note in the mail archives would do in a Tom pinch) along with a URL in a comment in the appropriate file Tom (dwarf2.h or

Re: [C PATCH] Add location to error_init (PR c/61096)

2014-05-09 Thread Joseph S. Myers
On Fri, 9 May 2014, Marek Polacek wrote: Another piece of puzzle. error_init didn't have a location parameter, so initialization errors had wrong column info. This patch adds location parameter to error_init and to a few of other functions. The testcases show what has better column info

[C++ Patch] Small SFINAE fix

2014-05-09 Thread Paolo Carlini
Hi, noticed only today that convert_nontype_argument calls convert_nontype_argument_function which has error calls. Tested x86_64-linux. Thanks, Paolo. // 2014-05-09 Paolo Carlini paolo.carl...@oracle.com * pt.c (convert_nontype_argument_function): Add

Re: [PATCH] Fix cgraph dumping bug

2014-05-09 Thread Richard Biener
On May 9, 2014 5:53:06 PM CEST, Teresa Johnson tejohn...@google.com wrote: Fixed a place where the wrong dump file was being used, leading to an inconsistency and seg fault when dump_file was non-NULL but cgraph_dump_file was NULL. Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for

Re: [patch libgcc]: Fix PR c++/57440

2014-05-09 Thread Ian Lance Taylor
On Wed, May 7, 2014 at 12:06 PM, Kai Tietz ktiet...@googlemail.com wrote: this patch adds for Windows targets the define _GTHREAD_USE_MUTEX_INIT_FUNC, which is necessary as pthread-emulation for those targets are just handling pthread_mutext_init, othread_mutex_destroy proper. ChangeLog

C++ PATCHes for conditional operator issues

2014-05-09 Thread Jason Merrill
While I was working on reference binding diagnostics, I noticed a latent bug with conversion10.C that I tracked down to a problem with the fix for c++/22434: we don't want to do a bad conversion early if we will find a better one later through overload resolution. So the first patch fixes

C++ PATCH for c++/60019 / CWG 5 (copy-initialization of cv-qualified object)

2014-05-09 Thread Jason Merrill
CWG DR 5 specifies that in the two-step copy-initialization process, the temporary object of the target type which is created and then copied into the target object has cv-unqualified type; this allows volatile objects to be copy-initialized with the usual copy-constructor signature. Tested

Re: [patch] change specific int128 - generic intN

2014-05-09 Thread DJ Delorie
Well, it wasn't a hard requirement, it is just that the library has to use a more complicated way to get the precision (use (unsigned TYPE)(-1) to get the unsigned max and compute the precision from that, probably). We could define macros for the precision too, and we already know max and

Re: [PATCH 08/89] Introduce gimple_phi and use it in various places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * coretypes.h (gimple_phi): New typedef. (const_gimple_phi): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_phi): New. (gimple_statement_base::dyn_cast_gimple_phi): New. * gdbhooks.py

Re: [PATCH 11/89] tree-parloops.c: use gimple_phi in various places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * tree-parloops.c (struct reduction_info): Strengthen field new_phi from gimple to gimple_phi. (create_phi_for_local_result): Convert local new_phi to gimple_phi. (loop_has_vector_phi_nodes): Require a gimple_phi rather

Re: [PATCH 10/89] Update ssa_prop_visit_phi_fn callbacks to take a gimple_phi

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * tree-ssa-propagate.h (typedef ssa_prop_visit_phi_fn): Strengthen type of parameter from gimple to gimple_phi. * tree-complex.c (complex_visit_phi): Update signature of callback implementation accordingly. *

Re: [PATCH 14/89] tree-ssa-loop-niter.c: use gimple_phi in a few places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * tree-ssa-loop-niter.c (chain_of_csts_start): Return a gimple_phi rather than a gimple. (get_base_for): Likewise; convert local phi to be a gimple_phi. (loop_niter_by_eval): Convert local phi to be a gimple_phi. OK

Re: [PATCH 13/89] tree-ssa-phiprop.c: use gimple_phi

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * tree-ssa-phiprop.c (phiprop_insert_phi): Strengthen types of parameter phi and local new_phi from gimple to gimple_phi. OK when prerequisites have gone in. jeff

Re: [C++ Patch] Small SFINAE fix

2014-05-09 Thread Jason Merrill
OK. Jason

Re: [PATCH 15/89] tree-ssa-loop-manip.c: use gimple_phi in three places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * tree-ssa-loop-manip.c (add_exit_phi): Convert local phi to be a gimple_phi. (split_loop_exit_edge): Likewise for phi and new_phi. OK when prerequisites have gone in. jeff

Re: [PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * tree-ssa-loop-ivopts.c (determine_biv_step): Require a gimple_phi. (find_bivs): Convert local phi into a gimple_phi. (mark_bivs): Likewise. OK when prerequisites have gone in. Actually that's true for #17 #18 as well.

Re: [PATCH 12/89] tree-predcom.c: use gimple_phi in various places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * tree-predcom.c (find_looparound_phi): Return a gimple_phi rather than just a gimple. (insert_looparound_copy): Require a gimple_phi rather than just a gimple. (add_looparound_copies): Convert local phi to be a

[PATCH, testsuite] Fix rs6000 test case pack03.c to use new dg-require-effective-target dfp_hw

2014-05-09 Thread Peter Bergner
Pat noticed that the updated pack03.c DFP test case is FAILing on older Power hardware without DFP support (ie, power5 and earlier). The problem is that the dg-require-effective-target dfprt use only protects against use on system without a DFP runtime, not a system without dfp hardware

Re: [PATCH 21/89] Introduce gimple_return

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * coretypes.h (gimple_return): New typedef. (const_gimple_return): New typedef. * gimple.h (gimple_statement_return): New subclass of gimple_statement_with_memory_ops, adding the invariant that stmt-code ==

Impact of gimple renamings on reviews (was Re: [PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places)

2014-05-09 Thread David Malcolm
On Fri, 2014-05-09 at 12:34 -0600, Jeff Law wrote: On 04/21/14 10:56, David Malcolm wrote: gcc/ * tree-ssa-loop-ivopts.c (determine_biv_step): Require a gimple_phi. (find_bivs): Convert local phi into a gimple_phi. (mark_bivs): Likewise. OK when prerequisites have gone in.

Re: [PATCH 09/89] Introduce gimple_phi_iterator

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * gimple-iterator.h (struct gimple_phi_iterator): New subclass of gimple_stmt_iterator with identical layout, but adding... (gimple_phi_iterator::phi): ...new method, equivalent to gsi_stmt (), but casting the

Re: Impact of gimple renamings on reviews (was Re: [PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places)

2014-05-09 Thread Jeff Law
On 05/09/14 12:47, David Malcolm wrote: Jeff: thanks. Note that I'm currently working on a grand renaming, as per the subthread here: http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00346.html so that all of these will be gphi * rather than gimple_phi, with analogous change to the other

[PING][RFC][PATCH] RL78 - Add predicates to reduce code bloat when accessing volatile memory.

2014-05-09 Thread Richard Hulme
http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01108.html Original Message Subject: [RFC][PATCH] RL78 - Add predicates to reduce code bloat when accessing volatile memory. Date: Fri, 18 Apr 2014 21:15:01 +0200 From: Richard Hulme pepe...@yahoo.com To: GCC Patches

Re: [PATCH 20/89] Introduce gimple_call

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * coretypes.h (gimple_call): New typedef. (const_gimple_call): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_call): New. (gimple_statement_base::dyn_cast_gimple_call): New.

Re: [PATCH 31/89] Use subclasses of gimple in various places

2014-05-09 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * asan.c (insert_if_then_before_iter): Require a gimple cond rathern than a plain gimple. (instrument_mem_region_access): Strengthen local from gimple to gimple_cond. * cfgloopmanip.c

Re: [PATCH, testsuite] Fix rs6000 test case pack03.c to use new dg-require-effective-target dfp_hw

2014-05-09 Thread David Edelsohn
On Fri, May 9, 2014 at 2:43 PM, Peter Bergner berg...@vnet.ibm.com wrote: Pat noticed that the updated pack03.c DFP test case is FAILing on older Power hardware without DFP support (ie, power5 and earlier). The problem is that the dg-require-effective-target dfprt use only protects against use

Re: [PATCH 32/89] Introduce gimple_try

2014-05-09 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_try): New typedef. (const_gimple_try): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_try): New. * gimple-low.c (gimple_try_catch_may_fallthru): Require a gimple_try rather

Re: [PING][RFC][PATCH] RL78 - Add predicates to reduce code bloat when accessing volatile memory.

2014-05-09 Thread DJ Delorie
The key to the msp430 change is that I reviewed every pattern that used the predicates, and only changed the ones where the pattern was known to be volatile-safe. For the RL78, the devirtualizer may make a pattern non-volatile-safe, and many patterns are macros which are not always

Re: [PATCH, testsuite] Fix rs6000 test case pack03.c to use new dg-require-effective-target dfp_hw

2014-05-09 Thread Rainer Orth
Peter Bergner berg...@vnet.ibm.com writes: Pat noticed that the updated pack03.c DFP test case is FAILing on older Power hardware without DFP support (ie, power5 and earlier). The problem is that the dg-require-effective-target dfprt use only protects against use on system without a DFP

Re: -Wvariadic-macros does not print warning

2014-05-09 Thread Jeff Law
On 04/29/14 08:14, Prathamesh Kulkarni wrote: On Tue, Apr 29, 2014 at 7:37 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: On Tue, Apr 29, 2014 at 6:49 PM, Manuel López-Ibáñez lopeziba...@gmail.com wrote: This hunk in your patch doesn't seem related: Oops, Sorry. Removed that, and

Re: [PATCH] Fortran OpenMP 4.0 support, part 1

2014-05-09 Thread Tobias Burnus
Hi! Jakub Jelinek wrote: This patch attempts to implement first part of Fortran OpenMP 4.0 support, The testsuite coverage could certainly be improved, volunteers for that and/or bugreports will be certainly appreciated. Don't know how to actually test aligned clauses, is there any way (except

Re: [PATCH] Fix uninitialised variable warning in tree-ssa-loop-ivcanon.c

2014-05-09 Thread Jeff Law
On 04/17/14 10:43, Kyrill Tkachov wrote: Hi all, While looking at the build logs I noticed a warning while building tree-ssa-loop-ivcanon.c about a potential use of an uninitialised variable. This patchlet fixes that warning by initialising it to 0. Tested arm-none-eabi. Ok for trunk?

[patch] add missing export for std::regex_error

2014-05-09 Thread Jonathan Wakely
Jakub noticed I got the exports wrong for std::regex_error. Tested x86_64-linux, committed to trunk. Not planning to fix this on the 4.9 branch. commit 33024aacc31cc7a1fdaba934952150fdc3db7e3f Author: Jonathan Wakely jwak...@redhat.com Date: Fri May 9 13:51:39 2014 +0100 *

Re: [ PATCH] Extend mode-switching to support toggle (1/2)

2014-05-09 Thread Jeff Law
On 04/17/14 07:58, Christian Bruel wrote: Hello, He is a new version of the patch. It hookizes the mode-setting and mode-toggling macros. Split in 2 parts. Successfully bootstrapped/regtested on ix86 and SH4/SH4a. I was able to do a limited build on Epiphany, if someone could give it a try on

Re: [PATCH] Fix PR c++/60463, PR c++/60755 Incorrect discard of const qualifier

2014-05-09 Thread Jason Merrill
Thanks for the patch, and for pinging me directly. It looks like you don't have a copyright assignment on file; this and your other patch are small enough not to need one, but if you're going to continue working on GCC it would be good to get on file so that it doesn't hold up future patches.

Re: [PATCH] Typofixes and a trivial change

2014-05-09 Thread Jeff Law
On 04/25/14 09:03, Patrick Palka wrote: I forgot the ChangeLog entry: 2014-04-25 Patrick Palka patr...@parcs.ath.cx * doc/invoke.texi: Fix typo. * tree-vrp.c: Fix typos. * gimple.c (infer_nonnull_range): Reorder operands of an condition. This is fine.

Re: [PATCH] Fortran OpenMP 4.0 support, part 1

2014-05-09 Thread Jakub Jelinek
On Fri, May 09, 2014 at 09:35:03PM +0200, Tobias Burnus wrote: This patch attempts to implement first part of Fortran OpenMP 4.0 support, The testsuite coverage could certainly be improved, volunteers for that and/or bugreports will be certainly appreciated. Don't know how to actually test

Re: [C PATCH] Add location to error_init (PR c/61096)

2014-05-09 Thread Jeff Law
On 05/09/14 01:27, Marek Polacek wrote: Another piece of puzzle. error_init didn't have a location parameter, so initialization errors had wrong column info. This patch adds location parameter to error_init and to a few of other functions. The testcases show what has better column info now.

Re: [GSoC] use obstack in parse_c_expr

2014-05-09 Thread Jeff Law
On 04/25/14 05:39, Prathamesh Kulkarni wrote: On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo dnovi...@google.com wrote: Please remember to send patches to gcc-patches. I'm wondering if you couldn't just use std::string here. No need to change one complicated allocation scheme with another.

[Google/4-8] Support for user-guided feedback-directed library optimization

2014-05-09 Thread Teresa Johnson
The attached patch adds support for user-guided feedback-directed library optimization, for google/gcc-4_8 initially (to be ported to google/gcc-4_9). Cc'ing Honza for any comments since I would eventually like to send this and follow-on work to trunk. Patch to add support for user-guided

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-09 Thread Ian Lance Taylor
On Fri, May 9, 2014 at 7:35 AM, Andrew Burgess aburg...@broadcom.com wrote: if ((AUTO_DEMANGLING || GNU_DEMANGLING)) { success = gnu_special (work, mangled, decl); + if (!success) +{ + delete_work_stuff (work); +

[PATCH 1/2] Handwritten part of introduction of GCC_OPTION macro

2014-05-09 Thread David Malcolm
This is the hand-written half of the patch series. gcc/ada/gcc-interface/misc.c requires some special care: it undeffed some options macros in order to support explicit variables for 5 options, whilst using other options via macros. I ported this file by hand, disabling the refactoring script

[PATCH 0/2] Make option-lookup macros explicit

2014-05-09 Thread David Malcolm
GCC's code is full of references to options like: static bool gate_vrp (void) { return flag_tree_vrp != 0; } where flag_tree_vrp is actually an autogenerated macro to: global_options.x_flag_tree_vrp This is deeply confusing to a newbie (and indeed still to me after ~two years of

[PATCH 2/2] Autogenerated part of introduction of GCC_OPTION macro

2014-05-09 Thread David Malcolm
This patch is 2.2MB in size, so I've uploaded it to: http://dmalcolm.fedorapeople.org/gcc/large-patches/6fb783b39f914574a1889aa51d06c08cf55678b4-0002-Autogenerated-part-of-introduction-of-GCC_OPTION-mac.patch (even just the ChangeLog would be 160KB)

Re: [PING][RFC][PATCH] RL78 - Add predicates to reduce code bloat when accessing volatile memory.

2014-05-09 Thread Andrew Pinski
On Fri, May 9, 2014 at 12:20 PM, DJ Delorie d...@redhat.com wrote: The key to the msp430 change is that I reviewed every pattern that used the predicates, and only changed the ones where the pattern was known to be volatile-safe. For the RL78, the devirtualizer may make a pattern

RE: [RFC][PATCH][MIPS] Patch to enable LRA for MIPS backend

2014-05-09 Thread Matthew Fortune
Richard/Vlad, Richard Sandiford rdsandif...@googlemail.com writes: Kyrill Tkachov kyrylo.tkac...@arm.com writes: On 03/05/14 20:21, Richard Sandiford wrote: ...snip... Hi all, This caused some testsuite failures on arm: FAIL: gcc.target/arm/vfp-ldmdbd.c scan-assembler fldmdbd FAIL:

[C++ patch] Fix c++/PR61133, implement the resolution of DR1760

2014-05-09 Thread Ville Voutilainen
I guess the subject says it all. Tested on Linux x86-64. diff --git a/gcc/cp/lambda.c b/gcc/cp/lambda.c index 3ce9ebb..bb6014b 100644 --- a/gcc/cp/lambda.c +++ b/gcc/cp/lambda.c @@ -367,10 +367,7 @@ build_capture_proxy (tree member) object = TREE_OPERAND (object, 0); /* Remove the __

  1   2   >