Re: [Patch] PR67351 Implement << N & >> N optimizers

Hi, Thanks for all the review and comments. >> replace the precision test with wi::ltu_p (@1, TYPE_PRECISION (type) >> use element_precision instead of TYPE_PRECISION Please find attached the modified patch as per review comments. Please review the same and let me know if the patch is okay? Re

Re: [Patch] PR67351 Implement << N & >> N optimizers

On Thu, Sep 3, 2015 at 9:29 AM, Hurugalawadi, Naveen wrote: > Hi, > > Thanks for all the review and comments. > >>> replace the precision test with wi::ltu_p (@1, TYPE_PRECISION (type) >>> use element_precision instead of TYPE_PRECISION > > Please find attached the modified patch as per review com

Re: Fix reload1.c warning for some targets

Rainer Orth writes: > Richard Sandiford writes: >> Jeff Law writes: >>> On 08/05/2015 08:18 AM, Richard Sandiford wrote: Building some targets results in a warning about orig_dup[i] potentially being used uninitialised. I think the warning is fair, since it isn't obvious that the

Re: [PATCH] Fix PR66705

> > supplied by foreign code, so you need to be conservative anyway. > > I use all_refs_explicit_p () to go a conservative path. And indeed Yep, that should be safe. I guess you want two things 1) discover any possible ADDR_REF of a given symbol with all_refs_explicit_p. For that you want

Re: [PATCH][1/5] Add param parloops-chunk-size

On Mon, Aug 31, 2015 at 01:45:25PM +0200, Tom de Vries wrote: > Add param parloops-chunk-size > > 2015-08-31 Tom de Vries > > * doc/invoke.texi (parloops-chunk-size): Add item. > * params.def (PARAM_PARLOOPS_CHUNK_SIZE): Add DEFPARAM. > * tree-parloops.c: Include params.h. >

Re: [PATCH][2/5] Handle simple latch bb in expand_omp_for_static_chunk

On Mon, Aug 31, 2015 at 01:50:42PM +0200, Tom de Vries wrote: > @@ -7351,14 +7357,25 @@ expand_omp_for_static_chunk (struct omp_region > *region, > >if (!broken_loop) > { > + struct loop *loop = body_bb->loop_father; >struct loop *trip_loop = alloc_loop (); >trip_lo

Re: [libgo] Use stat_atim.go on Solaris 12+

Rainer Orth writes: > Solaris 12 changes the stat_[amc]tim members of struct stat from > timestruc_t to timespec_t for XPG7 compatiblity, thus breaking the libgo > build. The following patch checks for this change and uses the common > stat_atim.go if appropriate. > > Btw., I noticed that go/os/

Re: [PR65637][PATCH][3/5] Fix gcc_assert in expand_omp_for_static_chunk

On Mon, Aug 31, 2015 at 01:55:40PM +0200, Tom de Vries wrote: > Fix gcc_assert in expand_omp_for_static_chunk > > 2015-08-31 Tom de Vries > > PR tree-optimization/65637 > * omp-low.c (expand_omp_for_static_chunk): Fix gcc_assert for the case > that head is NULL. > > *

Re: [PR65637][PATCH][4/5] Fix inner loop phi in expand_omp_for_static_chunk

On Mon, Aug 31, 2015 at 02:00:10PM +0200, Tom de Vries wrote: > --- a/gcc/omp-low.c > +++ b/gcc/omp-low.c > @@ -6885,6 +6885,22 @@ expand_omp_for_static_nochunk (struct omp_region > *region, > } > } > Please add a function comment. > +static gphi * > +find_phi_with_arg_on_edge (tree arg,

Re: [PR65637][PATCH][5/5] Handle 2 preds for fin_bb in expand_omp_for_static_chunk

On Mon, Aug 31, 2015 at 02:02:57PM +0200, Tom de Vries wrote: > 2015-08-31 Tom de Vries > > PR tree-optimization/65637 > * omp-low.c (expand_omp_for_static_chunk): Handle case that fin_bb has 2 > predecessors. Ok. > > * gcc.dg/autopar/reduc-3-chunk-size.c: New test. B

Re: [Patch] Add to the libgfortran/newlib bodge to "detect" ftruncate support in ARM/AArch64/SH

On Sun, Aug 30, 2015 at 02:46:26PM +0100, Hans-Peter Nilsson wrote: > (Pruned the CC list a bit as lists are included anyway) > > On Fri, 28 Aug 2015, James Greenhalgh wrote: > > On Fri, Aug 28, 2015 at 10:40:31AM +0100, James Greenhalgh wrote: > > > On Tue, Aug 25, 2015 at 03:44:05PM +0100, FX wr

Re: [PATCH] Fix ICE when generating a vector shift by scalar

On Wed, Sep 2, 2015 at 11:14 PM, Bill Schmidt wrote: > > On Wed, 2015-09-02 at 14:44 +0200, Richard Biener wrote: >> On Tue, Sep 1, 2015 at 5:53 PM, Bill Schmidt >> wrote: >> > On Tue, 2015-09-01 at 11:01 +0200, Richard Biener wrote: >> >> On Mon, Aug 31, 2015 at 10:28 PM, Bill Schmidt >> >> wro

Re: [PATCH] [gomp] Simplify thread pool initialization

On Wed, Jul 22, 2015 at 02:56:15PM +0200, Sebastian Huber wrote: > 2015-07-22 Sebastian Huber > > * team.c (gomp_new_thread_pool): Delete and move content to ... > (gomp_get_thread_pool): ... new function. Allocate and > initialize thread pool on demand. > (get_last_tea

Re: [PATCH] fix PR53852: stop ISL after a given number of operations

On Thu, Sep 3, 2015 at 12:34 AM, Sebastian Pop wrote: > 2015-09-02 Sebastian Pop > > * config.in: Regenerate. > * configure: Regenerate. > * configure.ac (HAVE_ISL_CTX_MAX_OPERATIONS): Detect. > * graphite-optimize-isl.c (optimize_isl): Stop compu

Re: [PATCH 1/3] [gomp] Add RTEMS configuration

On Tue, Jul 28, 2015 at 01:04:57PM +0200, Sebastian Huber wrote: > libgomp/ChangeLog > 2015-07-28 Sebastian Huber > > * config/rtems/bar.c: New. > * config/rtems/bar.h: Likewise. > * config/rtems/mutex.c: Likewise. > * config/rtems/mutex.h: Likewise. > * config/rte

Re: [PATCH 00/10] removal of typedefs that hide pointerness episode 1

On Thu, Sep 3, 2015 at 7:26 AM, wrote: > From: Trevor Saunders > > Hi, > > Personally I think hiding that variables are pointers is confusing, and I > believe consensus is we should move away from this style. So this series > starts to do that. Btw, what happened to the promised gimple -> gimp

Re: [Patch] PR67351 Implement << N & >> N optimizers

On Thu, Sep 3, 2015 at 9:29 AM, Hurugalawadi, Naveen wrote: > Hi, > > Thanks for all the review and comments. > >>> replace the precision test with wi::ltu_p (@1, TYPE_PRECISION (type) >>> use element_precision instead of TYPE_PRECISION > > Please find attached the modified patch as per review com

Re: [PATCH 1/3] [gomp] Add RTEMS configuration

On Thu, Sep 03, 2015 at 11:46:49AM +0200, Jakub Jelinek wrote: > On Tue, Jul 28, 2015 at 01:04:57PM +0200, Sebastian Huber wrote: > > libgomp/ChangeLog > > 2015-07-28 Sebastian Huber > > > > * config/rtems/bar.c: New. > > * config/rtems/bar.h: Likewise. > > * config/rtems/mutex.c: L

Re: [PATCH 2/3] [gomp] Thread pool management

On Tue, Jul 28, 2015 at 01:04:58PM +0200, Sebastian Huber wrote: > +#ifndef GOMP_POOL_H > +#define GOMP_POOL_H 1 > + > +#include Please use #include "libgomp.h" here. > +#include Similarly. > + > +#include "libgomp.h" > +#include > +#include #include "pool.h" (and perhaps if possible move

Re: [PATCH 3/3] [gomp] Add thread attribute customization

On Tue, Jul 28, 2015 at 01:04:59PM +0200, Sebastian Huber wrote: > libgomp/ChangeLog > 2015-07-28 Sebastian Huber > > * config/posix/pool.h (gomp_adjust_thread_attr): New. > * config/rtems/pool.h (gomp_adjust_thread_attr): Likewise. > (gomp_thread_pool_reservoir): Add priority

Re: [PATCH 3/3] [gomp] Add thread attribute customization

On 03/09/15 12:19, Jakub Jelinek wrote: @@ -292,7 +292,7 @@ gomp_team_start (void (*fn) (void *), void *data, unsigned nthreads, >bool nested; >struct gomp_thread_pool *pool; >unsigned i, n, old_threads_used = 0; >- pthread_attr_t thread_attr, *attr; >+ pthread_attr_t mutable_attr,

Re: [PR64164] drop copyrename, integrate into expand

On 02/09/15 23:12, Alexandre Oliva wrote: On Sep 2, 2015, Alan Lawrence wrote: One more failure to report, I'm afraid. On AArch64 Bigendian, aapcs64/func-ret-4.c ICEs in simplify_subreg (line refs here are from r227348): Thanks. The failure mode was different in the current, revamped git b

[patch] libstdc++/65473 Make define libstdc++ version macros.

This change would allow including to be used to check for __GLIBCXX__ and detect whether youre using libstdc++ or not. Howard Hinnant recommends including that header for libc++ because it has no other effects in C++. We could make every header include so that any of them can be used, but I ca

Re: [PATCH 3/3] [gomp] Add thread attribute customization

On Thu, Sep 03, 2015 at 12:57:53PM +0200, Sebastian Huber wrote: > On 03/09/15 12:19, Jakub Jelinek wrote: > >>@@ -292,7 +292,7 @@ gomp_team_start (void (*fn) (void *), void *data, > >>unsigned nthreads, > >>>bool nested; > >>>struct gomp_thread_pool *pool; > >>>unsigned i, n, old_thre

Re: [PATCH 3/3] [gomp] Add thread attribute customization

On 03/09/15 13:05, Jakub Jelinek wrote: On Thu, Sep 03, 2015 at 12:57:53PM +0200, Sebastian Huber wrote: >On 03/09/15 12:19, Jakub Jelinek wrote: > >>@@ -292,7 +292,7 @@ gomp_team_start (void (*fn) (void *), void *data, unsigned nthreads, > >>>bool nested; > >>>struct gomp_thread_po

Re: [PATCH 3/3] [gomp] Add thread attribute customization

On Thu, Sep 03, 2015 at 01:09:23PM +0200, Sebastian Huber wrote: > >>>We have only thread attributes in this function: mutable_attr and attr. The > >>>attr is initialized with &gomp_thread_attr and gomp_thread_attr is supposed > >>>to be read-only by this function. Under certain conditions we have

Re: [PATCH v2][GCC] Algorithmic optimization in match and simplify

On 01/09/15 15:01, Richard Biener wrote: On Tue, Sep 1, 2015 at 3:40 PM, Andre Vieira wrote: Hi Marc, On 28/08/15 19:07, Marc Glisse wrote: (not a review, I haven't even read the whole patch) On Fri, 28 Aug 2015, Andre Vieira wrote: 2015-08-03 Andre Vieira * match.pd: Added new pat

Re: [Patch] Add to the libgfortran/newlib bodge to "detect" ftruncate support in ARM/AArch64/SH

On Thu, 3 Sep 2015, James Greenhalgh wrote: > On Sun, Aug 30, 2015 at 02:46:26PM +0100, Hans-Peter Nilsson wrote: > > (Pruned the CC list a bit as lists are included anyway) > > > > On Fri, 28 Aug 2015, James Greenhalgh wrote: > > > Give me a shout if you see issues in your build systems. > > > > S

Re: [testsuite] Clean up effective_target cache

On Wed, Sep 2, 2015 at 7:02 AM, Christophe Lyon wrote: > On 1 September 2015 at 16:04, Christophe Lyon > wrote: >> On 25 August 2015 at 17:31, Mike Stump wrote: >>> On Aug 25, 2015, at 1:14 AM, Christophe Lyon >>> wrote: Some subsets of the tests override ALWAYS_CXXFLAGS or TEST_ALWA

Re: [PATCH 3/3] [gomp] Add thread attribute customization

On 03/09/15 13:10, Jakub Jelinek wrote: On Thu, Sep 03, 2015 at 01:09:23PM +0200, Sebastian Huber wrote: We have only thread attributes in this function: mutable_attr and attr. The attr is initialized with &gomp_thread_attr and gomp_thread_attr is supposed to be read-only by this function. Under

RE: RFC: Combine of compare & and oddity

> Segher Boessenkool wrote: > Hi Wilco, > > On Wed, Sep 02, 2015 at 06:09:24PM +0100, Wilco Dijkstra wrote: > > Combine canonicalizes certain AND masks in a comparison with zero into > > extracts of the > widest > > register type. During matching these are expanded into a very inefficient > > se

Re: [wwwdocs] Skeleton for GCC 6 release notes

Hello, how can I add something to the release notes? I would like to mention some RTEMS changes. The RTEMS thread model implementation changed. For the mutexes self-contained objects defined in Newlib are used instead of Classic API semaphores. The keys and the once function are directly

Re: [RFC] Try vector as a new representation for vector masks

Adding CCs. 2015-09-03 15:03 GMT+03:00 Ilya Enkovich : > 2015-09-01 17:25 GMT+03:00 Richard Biener : >> On Tue, Sep 1, 2015 at 3:08 PM, Ilya Enkovich wrote: >>> On 27 Aug 09:55, Richard Biener wrote: On Wed, Aug 26, 2015 at 5:51 PM, Ilya Enkovich wrote: > > Yes, I want to tr

Re: [RFC] Try vector as a new representation for vector masks

On Thu, Sep 3, 2015 at 2:03 PM, Ilya Enkovich wrote: > Adding CCs. > > 2015-09-03 15:03 GMT+03:00 Ilya Enkovich : >> 2015-09-01 17:25 GMT+03:00 Richard Biener : >>> On Tue, Sep 1, 2015 at 3:08 PM, Ilya Enkovich >>> wrote: On 27 Aug 09:55, Richard Biener wrote: > On Wed, Aug 26, 2015 at

[PATCH] Side-step wide_int_to_tree issue

In this particular place which otherwise triggers with Index: gcc/tree.c === --- gcc/tree.c (revision 227429) +++ gcc/tree.c (working copy) @@ -1395,6 +1395,8 @@ wide_int_to_tree (tree type, const wide_ gcc_checking_assert

Re: RFC: Combine of compare & and oddity

On Thu, Sep 03, 2015 at 12:43:34PM +0100, Wilco Dijkstra wrote: > > > Combine canonicalizes certain AND masks in a comparison with zero into > > > extracts of the > > widest > > > register type. During matching these are expanded into a very inefficient > > > sequence that > > fails to > > > matc

Re: [RFC] Try vector as a new representation for vector masks

2015-09-03 15:11 GMT+03:00 Richard Biener : > On Thu, Sep 3, 2015 at 2:03 PM, Ilya Enkovich wrote: >> Adding CCs. >> >> 2015-09-03 15:03 GMT+03:00 Ilya Enkovich : >>> 2015-09-01 17:25 GMT+03:00 Richard Biener : >>> >>> Totally disabling old style vector comparison and bool pattern is a >>> goal bu

[PATCH][committed] Some trivial dwarf2out.c refactoring

I split this bit out from the early-LTO debug work and the [1/n] patch that is still pending review. As I figured I need to preserve the old LTO behavior because of tooling issues with old linkers I am now concentrating on getting dwarf2out early + late phases refactored in a way that do not brea

Re: [gomp4.1] Depend clause support for offloading

On Wed, Sep 02, 2015 at 05:58:54PM +0200, Jakub Jelinek wrote: > Here is the start of the async offloading support I've talked about, > but nowait is not supported on the library side yet, only depend clause > (and for that I haven't added a testcase yet). Added testcase revealed two (small) issue

Re: [PING] Re: [PATCH] c/66516 - missing diagnostic on taking the address of a builtin function

The C++ parts are OK. Jason

[PATCH] Refactor dwarf2out_late_global_decl WRT early debug

The following patch refactors dwarf2out_late_global_decl to only add location or const value attributes in late dwarf phase. It adds LTO support by doing the early phase there as well (just what it would have done on-the-fly when using dwarf2out_decl). This change enables the other part of the p

[patch] libstdc++/62039 Add concept checks to std::next and std::prev.

Marc suggested adding concept checks to std::prev, I've also done so for std::next. Even though these checks are deprecated, they give us somewhere to consider putting C++17 concept requirements. Tested powerpx64le-linux, committed to trunk. commit 48d52e4f02e6c392086dce8832319c68ebec68b9 Author

[patch] libstdc++/66998 Make std::experimental::not_fn SFINAE-friendly.

Tested powerpc64le-linux, committed to trunk. commit dd64ea78da1f6e92ba011605ece7cc4bb08e41cc Author: Jonathan Wakely Date: Thu Sep 3 12:26:55 2015 +0100 Make std::experimental::not_fn SFINAE-friendly. PR libstdc++/66998 * include/experimental/functional (_Not_fn): A

[hsa] Represent atomic loads with atomic insn, introduce set_op

Hi, generation of atomic load instructions was still in its first ancient implementation when it was not generating atomic loads at all. This is fixed by the subsequent patch. The patch also introduces a method of hsa_insn_basic set_op which we plan to use to use almost everywhere to set instruc

[hsa] Implement a number of atomic builtins

Hi, The patch below implements expansion of a number of atomic builtin calls into HSA atomic instructions. Committed to the branch. Thanks, Martin 2015-09-03 Martin Jambor * hsa-gen.c (gen_hsa_ternary_atomic_for_builtin): New function. (gen_hsa_insns_for_call): Use it to i

Re: [PING] Re: [PATCH] c/66516 - missing diagnostic on taking the address of a builtin function

On Thu, 3 Sep 2015, Jason Merrill wrote: > The C++ parts are OK. The diagnostic should say "built-in" not "builtin" (see codingconventions.html). The C parts are OK with that change (which will require testcases to be updated). -- Joseph S. Myers jos...@codesourcery.com

Ping Re: Pass -foffload targets from driver to libgomp at link time

Ping. This patch is pending review. -- Joseph S. Myers jos...@codesourcery.com

RE: RFC: Combine of compare & and oddity

> Segher Boessenkool wrote: > On Thu, Sep 03, 2015 at 12:43:34PM +0100, Wilco Dijkstra wrote: > > > > Combine canonicalizes certain AND masks in a comparison with zero into > > > > extracts of the > > > widest > > > > register type. During matching these are expanded into a very > > > > inefficie

Re: Reviving SH FDPIC target

On Wed, 2 Sep 2015, Rich Felker wrote: > So if __fpscr_values was the only reason for patch 1/3 in the FDPIC > patchset, I think we can safely drop it. And patch 2/3 was already > committed, so 3/3, the one I was originally looking at, seems to be > all we need. It was approved at the time, so I'l

Re: patch for PR61578

On 09/02/2015 11:32 AM, Christophe Lyon wrote: Hi Vladimir, On 1 September 2015 at 21:39, Vladimir Makarov wrote: The following patch is for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61578 The patch was bootstrapped and tested on x86 and x86-64. Committed as rev. 227382. Sin

Re: [testsuite] Clean up effective_target cache

On 3 September 2015 at 13:31, H.J. Lu wrote: > On Wed, Sep 2, 2015 at 7:02 AM, Christophe Lyon > wrote: >> On 1 September 2015 at 16:04, Christophe Lyon >> wrote: >>> On 25 August 2015 at 17:31, Mike Stump wrote: On Aug 25, 2015, at 1:14 AM, Christophe Lyon wrote: > Some subsets

Re: [patch] libstdc++/66998 Make std::experimental::not_fn SFINAE-friendly.

On 03/09/15 15:35 +0100, Jonathan Wakely wrote: Tested powerpc64le-linux, committed to trunk. And gcc-5-branch. commit dd64ea78da1f6e92ba011605ece7cc4bb08e41cc Author: Jonathan Wakely Date: Thu Sep 3 12:26:55 2015 +0100 Make std::experimental::not_fn SFINAE-friendly. PR libstd

Re: RFC: Combine of compare & and oddity

On Thu, Sep 3, 2015 at 10:59 PM, Wilco Dijkstra wrote: >> Segher Boessenkool wrote: >> On Thu, Sep 03, 2015 at 12:43:34PM +0100, Wilco Dijkstra wrote: >> > > > Combine canonicalizes certain AND masks in a comparison with zero into >> > > > extracts of the >> > > widest >> > > > register type. Dur

[PATCH, rs6000] Use hardware support for vector character multiply

Hi, It was pointed out to me recently that multiplying two vector chars is performed using scalarization, even though we have hardware support for byte multiplies in vectors. This patch adds an expansion for mulv16qi3 to correct this. The expansion is pretty simple. We do a multiply-even and mu

Re: [PATCH] fix PR53852: stop ISL after a given number of operations

Richard Biener wrote: > > * gcc.dg/graphite/uns-interchange-12.c: Adjust pattern to pass > > with > > both isl-0.12 and isl-0.15. > > Does it mean with 0.15 we now "time out" on some of the cases? "time out" will not trigger on the testcases modified in this patch. > O

Re: RFC: Combine of compare & and oddity

On 09/02/2015 03:00 PM, Segher Boessenkool wrote: On Wed, Sep 02, 2015 at 01:59:58PM -0600, Jeff Law wrote: (set (reg:CC 66 cc) (compare:CC (and:DI (lshiftrt:DI (subreg:DI (reg/v:SI 76 [ xD.2641 ]) 0) (const_int 1 [0x1])) (const_int 1 [0x1])) (con

Re: [PATCH, rs6000] Use hardware support for vector character multiply

On Thu, Sep 3, 2015 at 11:20 PM, Bill Schmidt wrote: > Hi, > > It was pointed out to me recently that multiplying two vector chars is > performed using scalarization, even though we have hardware support for > byte multiplies in vectors. This patch adds an expansion for mulv16qi3 > to correct thi

Re: [PATCH, rs6000] Use hardware support for vector character multiply

On Thu, Sep 3, 2015 at 11:20 AM, Bill Schmidt wrote: > Hi, > > It was pointed out to me recently that multiplying two vector chars is > performed using scalarization, even though we have hardware support for > byte multiplies in vectors. This patch adds an expansion for mulv16qi3 > to correct thi

[PATCH] PR67421, Cost instruction sequences when doing left wide shift

As Rainer reported at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67421 Also, as described at https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01147.html This patch relax the restriction on wide left shift. Previously we always honor target private pattern, so when the following check be tru

Re: [PATCH, rs6000] Use hardware support for vector character multiply

On Thu, 2015-09-03 at 23:26 +0800, Andrew Pinski wrote: > On Thu, Sep 3, 2015 at 11:20 PM, Bill Schmidt > wrote: > > Hi, > > > > It was pointed out to me recently that multiplying two vector chars is > > performed using scalarization, even though we have hardware support for > > byte multiplies in

Re: RFC: Combine of compare & and oddity

On 09/03/2015 07:18 AM, Segher Boessenkool wrote: On Thu, Sep 03, 2015 at 12:43:34PM +0100, Wilco Dijkstra wrote: Combine canonicalizes certain AND masks in a comparison with zero into extracts of the widest register type. During matching these are expanded into a very inefficient sequence t

Re: [PATCH, rs6000] Use hardware support for vector character multiply

On Thu, 2015-09-03 at 11:36 -0400, David Edelsohn wrote: > On Thu, Sep 3, 2015 at 11:20 AM, Bill Schmidt > wrote: > > Hi, > > > > It was pointed out to me recently that multiplying two vector chars is > > performed using scalarization, even though we have hardware support for > > byte multiplies i

Re: Reviving SH FDPIC target

On Thu, Sep 03, 2015 at 02:58:39PM +, Joseph Myers wrote: > On Wed, 2 Sep 2015, Rich Felker wrote: > > > So if __fpscr_values was the only reason for patch 1/3 in the FDPIC > > patchset, I think we can safely drop it. And patch 2/3 was already > > committed, so 3/3, the one I was originally lo

Re: [PATCH] 2015-07-31 Benedikt Huber Philipp Tomsich

On Wed, Aug 26, 2015 at 11:58 AM, Benedikt Huber wrote: > ping > > [PATCH v4][aarch64] Implemented reciprocal square root (rsqrt) estimation in > -ffast-math > > https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02698.html > >> On 31 Jul 2015, at 19:05, Benedikt Huber >> wrote: >> >> * config

Re: RFC: Combine of compare & and oddity

On 09/03/2015 08:59 AM, Wilco Dijkstra wrote: Segher Boessenkool wrote: On Thu, Sep 03, 2015 at 12:43:34PM +0100, Wilco Dijkstra wrote: Combine canonicalizes certain AND masks in a comparison with zero into extracts of the widest register type. During matching these are expanded into a very i

Re: [PATCH] Make ubsan tests less picky about ansi escape codes in diagnostics.

+kcc, mrs Ping On 8/27/15 4:44 PM, Jonathan Roelofs wrote: The attached patch makes the ubsan tests agnostic to ansi escape codes in their diagnostic output. Tested on an x86_64-linux-gnu target. 2015-08-27 Jonathan Roelofs * c-c++-common/ubsan/align-2.c: Don't be picky

Re: [PATCH] 2015-07-31 Benedikt Huber Philipp Tomsich

> On Sep 3, 2015, at 11:58 PM, Sebastian Pop wrote: > > On Wed, Aug 26, 2015 at 11:58 AM, Benedikt Huber > wrote: >> ping >> >> [PATCH v4][aarch64] Implemented reciprocal square root (rsqrt) estimation in >> -ffast-math >> >> https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02698.html >> >>

Re: [PATCH] Make ubsan tests less picky about ansi escape codes in diagnostics.

On Thu, Sep 03, 2015 at 10:15:02AM -0600, Jonathan Roelofs wrote: > +kcc, mrs > > Ping > > On 8/27/15 4:44 PM, Jonathan Roelofs wrote: > >The attached patch makes the ubsan tests agnostic to ansi escape codes > >in their diagnostic output. It wouldn't hurt if you explained in detail what is the

Re: RFC: Combine of compare & and oddity

On Thu, Sep 03, 2015 at 03:59:00PM +0100, Wilco Dijkstra wrote: > > > However there are 2 issues with this, one is the spurious subreg, > > > > Combine didn't make that up out of thin air; something already used > > DImode here. It could simplify it to SImode in this case, that is > > true, don't

Re: [PATCH 3/3] [gomp] Add thread attribute customization

On Thu, Sep 03, 2015 at 01:36:35PM +0200, Sebastian Huber wrote: > On 03/09/15 13:10, Jakub Jelinek wrote: > >On Thu, Sep 03, 2015 at 01:09:23PM +0200, Sebastian Huber wrote: > >We have only thread attributes in this function: mutable_attr and attr. > >The > >attr is initialized with &

Re: RFC: Combine of compare & and oddity

On 03/09/15 17:18, Segher Boessenkool wrote: On Thu, Sep 03, 2015 at 03:59:00PM +0100, Wilco Dijkstra wrote: However there are 2 issues with this, one is the spurious subreg, Combine didn't make that up out of thin air; something already used DImode here. It could simplify it to SImode in thi

Re: RFC: Combine of compare & and oddity

On Thu, Sep 03, 2015 at 10:09:36AM -0600, Jeff Law wrote: > >>You will end up with a *lot* of target hooks like this. It will also > >>make testing harder (less coverage). I am not sure that is a good idea. > > > >We certainly need a lot more target hooks in general so GCC can do the > >right th

RE: RFC: Combine of compare & and oddity

> Kyrill Tkachov wrote: > A testcase I was looking at is: > int > foo (int a) > { >return (a & 7) != 0; > } > > For me this generates: > and w0, w0, 7 > cmp w0, wzr > csetw0, ne > ret > > when it could be: > tst w0, 7 > cs

Re: [Patch, fortran] F2008 - implement pointer function assignment

Dear Paul, I have tested your patch (with the two patches in pr67429) and got the following regressions: FAIL: gfortran.dg/bind_c_usage_12.f03 -O (test for errors, line 33) FAIL: gfortran.dg/bind_c_usage_12.f03 -O (test for errors, line 51) FAIL: gfortran.dg/bind_c_usage_12.f03 -O (t

Re: [PATCH] Make ubsan tests less picky about ansi escape codes in diagnostics.

On 9/3/15 10:17 AM, Jakub Jelinek wrote: On Thu, Sep 03, 2015 at 10:15:02AM -0600, Jonathan Roelofs wrote: +kcc, mrs Ping On 8/27/15 4:44 PM, Jonathan Roelofs wrote: The attached patch makes the ubsan tests agnostic to ansi escape codes in their diagnostic output. It wouldn't hurt if you

Re: RFC: Combine of compare & and oddity

On Thu, Sep 03, 2015 at 05:25:43PM +0100, Kyrill Tkachov wrote: > >void g(void); > >void f(int *x) { if (*x & 2) g(); } > A testcase I was looking at is: > int > foo (int a) > { > return (a & 7) != 0; > } > > For me this generates: > and w0, w0, 7 > cmp w0, wzr >

Re: RFC: Combine of compare & and oddity

On 04 Sep 2015, at 01:54, Segher Boessenkool wrote: > On Thu, Sep 03, 2015 at 05:25:43PM +0100, Kyrill Tkachov wrote: >>> void g(void); >>> void f(int *x) { if (*x & 2) g(); } > >> A testcase I was looking at is: >> int >> foo (int a) >> { >> return (a & 7) != 0; >> } >> >> For me this genera

Re: [PING] Re: [PATCH] c/66516 - missing diagnostic on taking the address of a builtin function

On Wed, Sep 02, 2015 at 03:53:07PM -0600, Martin Sebor wrote: > gcc/ChangeLog > 2015-09-02 Martin Sebor > > PR c/66516 > * doc/extend.texi (Other Builtins): Document when the address > of a builtin function can be taken. > > gcc/c-family/ChangeLog > 2015-09-02 Martin Sebor

Re: [PATCH] Add __builtin_argument_pointer

On Tue, Sep 1, 2015 at 7:52 AM, H.J. Lu wrote: > On Wed, Aug 19, 2015 at 3:35 PM, Segher Boessenkool > wrote: >> On Wed, Aug 19, 2015 at 03:18:46PM -0700, H.J. Lu wrote: >>> @deftypefn {Built-in Function} {void *} __builtin_argument_pointer (void) >>> This function is similar to @code{__builtin_f

Re: [PATCH] Make ubsan tests less picky about ansi escape codes in diagnostics.

On 9/3/15 10:45 AM, Jonathan Roelofs wrote: On 9/3/15 10:17 AM, Jakub Jelinek wrote: On Thu, Sep 03, 2015 at 10:15:02AM -0600, Jonathan Roelofs wrote: +kcc, mrs Ping On 8/27/15 4:44 PM, Jonathan Roelofs wrote: The attached patch makes the ubsan tests agnostic to ansi escape codes in thei

Re: [gomp4.1] Depend clause support for offloading

Hi! FYI, I've merged trunk into the gomp-4_1-branch, it has been a while since that has been done. make -C check RUNTESTFLAGS=gomp.exp and make check-target-libgomp still pass without offloading and when offloading to mic emul (the latter with the libgomp.c/for-5.c and libgomp.c++/for-13.C LTO IC

Re: [PING] Re: [PATCH] c/66516 - missing diagnostic on taking the address of a builtin function

You've committed empty gcc/builtins.c.orig file, I've removed it, but please be more careful next time. And c/ or cp/ prefixes don't belong to c/ChangeLog or cp/ChangeLog (also fixed). Jakub Thank you for fixing that up. Martin

Re: patch for PR61578

On 09/03/2015 11:00 AM, Vladimir Makarov wrote: On 09/02/2015 11:32 AM, Christophe Lyon wrote: Hi Vladimir, On 1 September 2015 at 21:39, Vladimir Makarov wrote: The following patch is for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61578 The patch was bootstrapped and tested on x

RE: RFC: Combine of compare & and oddity

> Oleg Endo wrote: > On 04 Sep 2015, at 01:54, Segher Boessenkool > wrote: > > > On Thu, Sep 03, 2015 at 05:25:43PM +0100, Kyrill Tkachov wrote: > >>> void g(void); > >>> void f(int *x) { if (*x & 2) g(); } > > > >> A testcase I was looking at is: > >> int > >> foo (int a) > >> { > >> return (a

Re: RFC: Combine of compare & and oddity

On 09/03/2015 10:18 AM, Segher Boessenkool wrote: But there are more efficient ways to emit single bit and masks tests that apply to most CPUs rather than doing something specific that works for just one target only. For example single bit test is a simple shift into carry flag or into the sign

RE: RFC: Combine of compare & and oddity

> Segher Boessenkool wrote: > On Thu, Sep 03, 2015 at 10:09:36AM -0600, Jeff Law wrote: > > >>You will end up with a *lot* of target hooks like this. It will also > > >>make testing harder (less coverage). I am not sure that is a good idea. > > > > > >We certainly need a lot more target hooks in

Re: RFC: Combine of compare & and oddity

On 09/03/2015 12:53 PM, Wilco Dijkstra wrote: Segher Boessenkool wrote: On Thu, Sep 03, 2015 at 10:09:36AM -0600, Jeff Law wrote: You will end up with a *lot* of target hooks like this. It will also make testing harder (less coverage). I am not sure that is a good idea. We certainly need a l

Re: [patch] libstdc++/66902 Make _S_debug_messages static.

On 26/08/15 21:22 +0100, Jonathan Wakely wrote: This patch removes a public symbol from the .so, which is generally a bad thing, but there should be no users of this anywhere (it's never declared in any public header). For targets using symbol versioning this isn't exported at all, as it isn't i

Re: RFC: Combine of compare & and oddity

On Thu, Sep 03, 2015 at 12:42:30PM -0600, Jeff Law wrote: > Note huge parts of combine are structured around the needs of processors > from the late 80s and early 90s. The canonical forms selected for those > processors may not be optimal for today's processors. Or, more precisely, for the back

Re: RFC: Combine of compare & and oddity

Jeff Law writes: > On 09/03/2015 12:53 PM, Wilco Dijkstra wrote: >>> Segher Boessenkool wrote: >>> On Thu, Sep 03, 2015 at 10:09:36AM -0600, Jeff Law wrote: >> You will end up with a *lot* of target hooks like this. It will also >> make testing harder (less coverage). I am not sure that

Re: RFC: Combine of compare & and oddity

On Thu, Sep 03, 2015 at 07:53:12PM +0100, Wilco Dijkstra wrote: > > > >>You will end up with a *lot* of target hooks like this. It will also > > > >>make testing harder (less coverage). I am not sure that is a good idea. > > > > > > > >We certainly need a lot more target hooks in general so GCC c

Re: [patch] libstdc++/65473 Make define libstdc++ version macros.

On 09/03/2015 04:58 AM, Jonathan Wakely wrote: This change would allow including to be used to check for __GLIBCXX__ and detect whether youre using libstdc++ or not. Howard Hinnant recommends including that header for libc++ because it has no other effects in C++. We could make every header in

Re: [patch] libstdc++/65473 Make define libstdc++ version macros.

On 03/09/15 13:22 -0600, Martin Sebor wrote: On 09/03/2015 04:58 AM, Jonathan Wakely wrote: This change would allow including to be used to check for __GLIBCXX__ and detect whether youre using libstdc++ or not. Howard Hinnant recommends including that header for libc++ because it has no other e

[patch] Clean up libstdc++ includes slightly.

This adjusts some missing or redundant includes, and replaces "throw bad_alloc()" (which won't work with -fno-exceptions) with a call to __throw_bad_alloc(). Tested powerpc64e-linux, committed to trunk. commit ca17448c303cfd58191c64abe42a750c9590aa14 Author: Jonathan Wakely Date: Thu Sep 3 21

Re: RFC: Combine of compare & and oddity

On 09/03/2015 01:14 PM, Richard Sandiford wrote: If the (and ...) form is a better canonical form (IMO yes) then I think it would be better to make it the canonical form across the baord and update the existing ports to use it. The criteria could be something like no unjustifiable differences i

[PATCH, MIPS] Frame header optimization for MIPS O32 ABI

Here is an update of my MIPS frame header optimization patch. This is actually only one part of the patch but I would like to get this approved and checked in before proceeding with the second half. The O32 ABI on MIPS requires that calling functions allocate space on the stack for arguments that

Re: [Fortran, committed] XFAIL read_dir.f90 on FreeBSD

On Wed, Sep 2, 2015 at 6:03 PM, Steve Kargl wrote: > On Wed, Sep 02, 2015 at 11:30:07AM +0300, Janne Blomqvist wrote: >> On Wed, Sep 2, 2015 at 1:28 AM, Jerry DeLisle wrote: >> > On 09/01/2015 11:18 AM, Steve Kargl wrote: >> >> On Tue, Sep 01, 2015 at 11:16:27AM -0700, Steve Kargl wrote: >> >>>

[PATCH, rs6000] Add memory barriers to tbegin, tend, etc.

While debugging a transaction lock elision issue, we noticed that the compiler was moving some loads/stores outside of the transaction body, because the HTM instructions were not marked as memory barriers, which is bad. Looking deeper, I also noticed that neither Intel and S390 have their HTM inst

Re: [patch] Clean up libstdc++ includes slightly.

I'm committing the __throw_bad_alloc() part on the branch too. commit 02221ce47cade82036c7d78ed79e5fe536fdfcfd Author: Jonathan Wakely Date: Thu Sep 3 23:01:02 2015 +0100 * include/std/shared_mutex (shared_timed_mutex::shared_timed_mutex): Replace throw with __throw_bad_alloc. diff

Re: [wwwdocs] Skeleton for GCC 6 release notes

Hi Sebastian, On Thu, 3 Sep 2015, Sebastian Huber wrote: > how can I add something to the release notes? I would like to mention > some RTEMS changes. is it possible checking out https://gcc.gnu.org/about.html is all you are looking for, or am I thinking to simple? :-) > The RTEMS thread model

  1   2   >