Re: [PATCH] Add save_expr langhook (PR c/68513)

2015-11-27 Thread Richard Biener
On November 27, 2015 7:55:43 PM GMT+01:00, Marek Polacek wrote: >As suggested here > >and here , >this patch >adds a new langhook to distinguish whether to call c_save_expr or >save

Re: [PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-27 Thread Richard Biener
On November 27, 2015 8:40:56 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The recent changes where vector sqrt is represented in the IL using >IFN_SQRT instead of target specific builtins broke the discovery >of vector rsqrt, as targetm.builtin_reciprocal is called only >on builtin functions (not i

Re: [PATCH PR68529]Fix not recognized scev by computing no-overflow info for loop with NE_EXPR exit condition

2015-11-27 Thread Bin.Cheng
On Fri, Nov 27, 2015 at 8:51 PM, Richard Biener wrote: > On Fri, Nov 27, 2015 at 12:44 PM, Bin Cheng wrote: >> Hi, >> This patch is to fix PR68529. In my previous scev/niter overflow patches, I >> only computed no-overflow information for control iv in simple loops with >> LT_EXPR as exit condit

Re: [PR67335] drop dummy zero from reverse VTA ops, fix infinite recursion

2015-11-27 Thread Alexandre Oliva
On Nov 27, 2015, Jakub Jelinek wrote: > I'm sorry, but I don't remember. Perhaps it has been before some recursion > prevention has been added or whatever, maybe your own PR52001? Yeah. Thanks anyway. > Have you checked if your patch results in any significant debug info quality > changes It

Re: [PATCH] Add save_expr langhook (PR c/68513)

2015-11-27 Thread Joseph Myers
On Fri, 27 Nov 2015, Marek Polacek wrote: > I didn't know where to put setting of in_late_processing. With the current > placement, we won't (for valid programs) call c_save_expr from c_genericize > or c_gimplify_expr. Well, the placement in this patch (in c_parser_compound_statement) is certai

[PATCH] [ping] Add support for ARM embedded multilibs

2015-11-27 Thread Jasmin J.
Hello ! Did rebase the patch (sent at 11/08/2015 01:24 AM) to latest trunk (335ce86cb6cea8046993ab93d573316fd9ff798c). The patch is originally from Terry Guo (see https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00729.html). SVN commit r210320 on svn://gcc.gnu.org/svn/gcc/branches/ARM/embedded-4_9-

[PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-27 Thread Jakub Jelinek
Hi! The recent changes where vector sqrt is represented in the IL using IFN_SQRT instead of target specific builtins broke the discovery of vector rsqrt, as targetm.builtin_reciprocal is called only on builtin functions (not internal functions). Furthermore, for internal fns, not only the IFN_* i

[PATCH] Fix up target {{enter,exit} nowait,update} depend nowait

2015-11-27 Thread Jakub Jelinek
Hi! I've recently changed the code so that GOMP_TARGET_TASK_DATA depend nowait, if it doesn't need to wait for any dependencies, is handled non-asynchronously, and before that the task created because we didn't know if there are dependencies or not, is freed. But, I forgot to remove the depend ent

Re: [PATCH] Add save_expr langhook (PR c/68513)

2015-11-27 Thread Marek Polacek
On Fri, Nov 27, 2015 at 07:55:43PM +0100, Marek Polacek wrote: > +/* The C version of the save_expr langhook. Either call save_expr or > c_save_expr, > + depending on IN_LATE_PROCESSING. */ Consider this too long line fixed. Marek

[PATCH] Add save_expr langhook (PR c/68513)

2015-11-27 Thread Marek Polacek
As suggested here and here , this patch adds a new langhook to distinguish whether to call c_save_expr or save_expr from match.pd. Does this look reasonable? I didn't know where to

Re: Improving the cxx0x_warning.h diagnostic

2015-11-27 Thread Jonathan Wakely
On 27/11/15 12:53 -0500, NightStrike wrote: You could add a pragma that turns on -Wfatal-errors That might be better, I'll try it, thanks.

Re: [patch] Copy-edit the Option Summary in invoke.texi

2015-11-27 Thread Jonathan Wakely
On 27/11/15 09:45 +0100, Bernd Schmidt wrote: On 11/26/2015 01:16 PM, Jonathan Wakely wrote: At https://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html we document -Waggressive-loop-optimizations but you can't find that option at https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html because we

patch to fix PR68536

2015-11-27 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68536 The patch was tested and bootstrapped on x86/x86-64. Committed as rev. 231021. Index: lra-constraints.c === --- lra-constraints.c (revision 230986) +++ l

Re: [PATCH] Fix PR68067

2015-11-27 Thread Alan Lawrence
On 27/11/15 15:07, Alan Lawrence wrote: On 23/11/15 09:43, Richard Biener wrote: On Fri, 20 Nov 2015, Alan Lawrence wrote: ...the asserts you suggested in (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D68117#c27)... >> So I have to ask, how sure are you that those assertions are(/should be

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

2015-11-27 Thread Eric Botcazou
> So, I'm not familiar with Ada 'fat pointers' but if that is one - > well, it's a record, with an alignment that the 'new' AAPCS now > ignores, so yes the ABI has changed between gcc 5.1 and 5.2, rather > more significantly for Ada than for C. Yes, XUP suffixed types are fat pointers and they are

Re: [PATCH 1/7][ARM] Add support for ARMv8.1.

2015-11-27 Thread Christophe Lyon
On 27 November 2015 at 18:05, Matthew Wahab wrote: > On 27/11/15 14:05, Christophe Lyon wrote: >> >> On 26 November 2015 at 16:55, Matthew Wahab >> wrote: > > >>> ARMv8.1 includes an extension to ARM which adds two Adv.SIMD >>> instructions, vqrdmlah and vqrdmlsh. This patch set adds support for

Re: [PATCH 5/7][Testsuite] Support ARMv8.1 ARM tests.

2015-11-27 Thread Matthew Wahab
On 27/11/15 13:44, Christophe Lyon wrote: On 26/11/15 16:02, Matthew Wahab wrote: This patch adds ARMv8.1 support to GCC Dejagnu, to allow ARM tests to specify targest and to set up command line options. It builds on the ARMv8.1 target support added for AArch64 tests, partly reworking that sup

Re: [PATCH 5/7][Testsuite] Support ARMv8.1 ARM tests.

2015-11-27 Thread Matthew Wahab
On 27/11/15 13:44, Christophe Lyon wrote: On 26/11/15 16:02, Matthew Wahab wrote: This patch adds ARMv8.1 support to GCC Dejagnu, to allow ARM tests to specify targest and to set up command line options. It builds on the ARMv8.1 target support added for AArch64 tests, partly reworking that sup

Re: [PATCH 1/7][ARM] Add support for ARMv8.1.

2015-11-27 Thread Matthew Wahab
On 27/11/15 14:05, Christophe Lyon wrote: On 26 November 2015 at 16:55, Matthew Wahab wrote: ARMv8.1 includes an extension to ARM which adds two Adv.SIMD instructions, vqrdmlah and vqrdmlsh. This patch set adds support for ARMv8.1 and for the new instructions, enabling the architecture with -

Re: [PATCH] GCC system.h and Graphite header order

2015-11-27 Thread David Edelsohn
On Fri, Nov 27, 2015 at 11:24 AM, Thomas Schwinge wrote: > Hi! > > On Tue, 24 Nov 2015 10:32:12 +, Alan Lawrence > wrote: >> I note doc/install.texi says that gcc uses "ISL Library version 0.15, >> 0.14, 0.13, or 0.12.2". This patch breaks the build with 0.12.2 (a >> subset of errors below)

Re: [gomp4.5] Handle #pragma omp declare target link

2015-11-27 Thread Ilya Verbin
On Thu, Nov 19, 2015 at 16:31:15 +0100, Jakub Jelinek wrote: > On Mon, Nov 16, 2015 at 06:40:43PM +0300, Ilya Verbin wrote: > > @@ -2009,7 +2010,8 @@ scan_sharing_clauses (tree clauses, omp_context *ctx) > > decl = OMP_CLAUSE_DECL (c); > > /* Global variables with "omp declare target" a

Re: basic asm and memory clobbers

2015-11-27 Thread Segher Boessenkool
Hi Bernd, On Fri, Nov 27, 2015 at 09:26:40AM +, Bernd Edlinger wrote: > On Tue, 17 Nov 2015 14:31:29, Jeff Law wrote: > > The benefit is traditional asms do the expected thing. With no way to > > describe dataflow, the only rational behaviour for a traditional asm is > > that it has to be co

Re: [PATCH] GCC system.h and Graphite header order

2015-11-27 Thread Thomas Schwinge
Hi! On Tue, 24 Nov 2015 10:32:12 +, Alan Lawrence wrote: > I note doc/install.texi says that gcc uses "ISL Library version 0.15, > 0.14, 0.13, or 0.12.2". This patch breaks the build with 0.12.2 (a > subset of errors below) has been filed. I set you guys on CC.

Re: [PATCH] Fix PR68067

2015-11-27 Thread Alan Lawrence
On 23/11/15 09:43, Richard Biener wrote: On Fri, 20 Nov 2015, Alan Lawrence wrote: ...the asserts you suggested in (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D68117#c27)... >> So I have to ask, how sure are you that those assertions are(/should be!) "correct"? :) Ideally they should be

[PATCH committed] PR other/61321 - demangler crash on casts in template parameters

2015-11-27 Thread Markus Trippelsdorf
I've committed the patch from Pedro Alves for PR61321. It was approved by Jason over a year ago and the dups kept piling up. PR other/61321 - demangler crash on casts in template parameters The fix for bug 59195: [C++ demangler handles conversion operator incorrectly] h

[HSA] fix emission of function names with user-defined assembly names

2015-11-27 Thread Martin Liška
Hello. The patch has just been applied to the HSA branch. Martin >From 9f791cd1715b65599a4b022a56a7eac7e0816e72 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 27 Nov 2015 09:06:58 +0100 Subject: [PATCH 3/5] HSA: fix emission of function names with user-defined names gcc/ChangeLog: 2015-11-2

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case

2015-11-27 Thread Kyrill Tkachov
On 27/11/15 14:35, Bernd Schmidt wrote: On 11/27/2015 03:33 PM, Kyrill Tkachov wrote: Sorry for that. That is caused not by this patch but rather by the followup https://gcc.gnu.org/ml/gcc-patches/2015-11/msg03327.html The checking assert fails: gcc_checking_assert (!emit_a || !modified_in_p (

[HSA] Implementation of various omp_* function

2015-11-27 Thread Martin Liška
Hello. Following pair of patches implements missing omp function. Installed to the HSA branch. Thanks, Martin >From 90cb91ca75ce29e560184fbd1ca03a7e58fc6685 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 26 Nov 2015 10:18:44 +0100 Subject: [PATCH 1/5] HSA: implement omp_get_level libgomp/Chan

Re: [Fortran, patch, pr68218, backport to 5 and 4.9, v1] ALLOCATE with size given by a module function

2015-11-27 Thread Andre Vehreschild
Hi Mikael, hi all, Mikael, thanks for the fast review. Committed after sync with richi for 5.3 as r231014 and r231017 for 4.9. Regards, Andre On Fri, 27 Nov 2015 14:09:15 +0100 Mikael Morin wrote: > Le 27/11/2015 13:20, Andre Vehreschild a écrit : > > Hi all, > > > > I have backported

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case

2015-11-27 Thread Bernd Schmidt
On 11/27/2015 03:33 PM, Kyrill Tkachov wrote: Sorry for that. That is caused not by this patch but rather by the followup https://gcc.gnu.org/ml/gcc-patches/2015-11/msg03327.html The checking assert fails: gcc_checking_assert (!emit_a || !modified_in_p (orig_b, emit_a)); emit_a is: (parallel [

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case

2015-11-27 Thread Kyrill Tkachov
On 27/11/15 14:09, Richard Biener wrote: On Fri, Nov 27, 2015 at 10:44 AM, Kyrill Tkachov wrote: On 26/11/15 16:54, Kyrill Tkachov wrote: On 26/11/15 16:49, Bernd Schmidt wrote: On 11/26/2015 05:45 PM, Kyrill Tkachov wrote: that doesn't help, punt. */ - modified_in_a = emit_a

Re: [Ping][PATCH][GCC][ARM] testcase memset-inline-10.c uses -mfloat-abi=hard but does not check whether target supports it

2015-11-27 Thread Andre Vieira
On 12/11/15 15:16, Andre Vieira wrote: On 12/11/15 15:08, Andre Vieira wrote: Hi, This patch changes the memset-inline-10.c testcase to make sure that it is only compiled for ARM targets that support -mfloat-abi=hard using the fact that all non-thumb1 targets do. This is correct because

[PTX] address space patch

2015-11-27 Thread Nathan Sidwell
I've committed this cleanup of some of the address space machinery. As with the fn recording helpers, the address space helper was accepting many things that were not symbols. Changed the two callers to only pass a symbol -- one of them had already done the symbol extraction anyway. Also, th

Re: [PATCH] Allocate constant size dynamic stack space in the prologue

2015-11-27 Thread Dominik Vogt
On Fri, Nov 27, 2015 at 03:09:15PM +0100, Dominik Vogt wrote: > +++ b/gcc/config/s390/s390.h ... > +/* Constant size dynamic stack space can be allocated through the function > + prologue to save the extra instructions to adjust the stack pointer. */ > +#define ALLOCATE_DYNAMIC_STACK_SPACE_IN_PR

[PATCH] Fix PR68559

2015-11-27 Thread Richard Biener
The following fixes the excessive peeling for gaps we do when doing SLP now that I removed most of the restrictions on having gaps in the first place. This should make low-trip vectorized loops more efficient (sth also the combine-epilogue-with-vectorized-body-by-masking patches claim to do). Bo

Re: [PATCH] Allocate constant size dynamic stack space in the prologue

2015-11-27 Thread Dominik Vogt
New patch with the following changes: * Fixed comment about dynamic var area placement. * The area is now placed further away from the stack pointer than the non-dynamic stack variables (tested only with STACK_GROWS_DOWNWARD). This is a possible performance improvement on S/390 (hoping that

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case

2015-11-27 Thread Richard Biener
On Fri, Nov 27, 2015 at 10:44 AM, Kyrill Tkachov wrote: > > On 26/11/15 16:54, Kyrill Tkachov wrote: >> >> >> On 26/11/15 16:49, Bernd Schmidt wrote: >>> >>> On 11/26/2015 05:45 PM, Kyrill Tkachov wrote: that doesn't help, punt. */ - modified_in_a = emit_a != NULL_RT

Re: [PATCH 1/7][ARM] Add support for ARMv8.1.

2015-11-27 Thread Christophe Lyon
On 26 November 2015 at 16:55, Matthew Wahab wrote: > Hello, > > > ARMv8.1 includes an extension to ARM which adds two Adv.SIMD > instructions, vqrdmlah and vqrdmlsh. This patch set adds support for > ARMv8.1 and for the new instructions, enabling the architecture with > --march=armv8.1-a. The new

[PTX] Another libcall patch

2015-11-27 Thread Nathan Sidwell
I've committed this further cleanup of function decl recording. We were recording libcalls during call expansion, but recording other calls during call outputting. This moves all recording to the call outputting. The recording helpers were a little confusing -- for intsance 'record_fndecl',

Re: [Patch AArch64] Reinstate CANNOT_CHANGE_MODE_CLASS to fix pr67609

2015-11-27 Thread Richard Biener
On Fri, Nov 27, 2015 at 2:01 PM, James Greenhalgh wrote: > > Hi, > > This patch follow Richard Henderson's advice to tighten up > CANNOT_CHANGE_MODE_CLASS for AArch64 to avoid a simplification bug in > the middle-end. > > There is nothing AArch64-specific about the testcase which triggers this, >

[PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-11-27 Thread Claudiu Zissulescu
Properly emit DWARF2 related information while expanding epilogue. Remove the -m[no]-epilogue-cfi option as it is not needed any longer. This patch solves the dwarf2cfi errors observed while running dejagnu tests. Ok to commit? Claudiu gcc/ 2015-11-27 Claudiu Zissulescu * config/arc/a

RE: [PATCH 1/4 v2][AArch64] Generalize CCMP support

2015-11-27 Thread Wilco Dijkstra
> James Greenhalgh wrote: > > Could you please repost this with the word-wrapping issues fixed. > > I can't apply it to my tree for review or to commit it on your behalf in > > the current form. So it looks like Outlook no longer supports sending emails without wrapping and the maximum is only

Re: [RFC] Combine vectorized loops with its scalar remainder.

2015-11-27 Thread Richard Biener
On Fri, Nov 13, 2015 at 11:35 AM, Yuri Rumyantsev wrote: > Hi Richard, > > Here is updated version of the patch which 91) is in sync with trunk > compiler and (2) contains simple cost model to estimate profitability > of scalar epilogue elimination. The part related to vectorization of > loops wit

Re: [PATCH 5/7][Testsuite] Support ARMv8.1 ARM tests.

2015-11-27 Thread Christophe Lyon
On 26 November 2015 at 17:10, Matthew Wahab wrote: > Attached the missing patch. > Matthew > > > On 26/11/15 16:02, Matthew Wahab wrote: >> >> Hello, >> >> This patch adds ARMv8.1 support to GCC Dejagnu, to allow ARM >> tests to specify targest and to set up command line options. >> It builds on t

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

2015-11-27 Thread Alan Lawrence
On 26 November 2015 at 14:00, Alan Lawrence wrote: > On 6 November 2015 at 16:59, Jakub Jelinek wrote: >> >> In any case, to manually reproduce, compile >> gnatmake -g -gnatws macrosub.adb >> with GCC 5.1.1 (before the ARM changes) and then try to run that process >> against >> GCC 5.2.1 (after

Re: [PATCH] Fix PR68029

2015-11-27 Thread Jiří Engelthaler
2015-11-27 13:49 GMT+01:00 Bernd Schmidt : > On 11/27/2015 01:30 PM, Jiří Engelthaler wrote: >> >> Sorry for international characters in my name. It should be >> >> Jiri Engelthaler >> >> 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří : > > > There is precedent for non-ASCII characters in ChangeLogs.

Re: [PATCH] Fix PR68029

2015-11-27 Thread Jiří Engelthaler
2015-11-27 13:49 GMT+01:00 Bernd Schmidt : > On 11/27/2015 01:30 PM, Jiří Engelthaler wrote: >> >> Sorry for international characters in my name. It should be >> >> Jiri Engelthaler >> >> 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří : > > > There is precedent for non-ASCII characters in ChangeLogs.

Re: [Fortran, patch, pr68218, backport to 5 and 4.9, v1] ALLOCATE with size given by a module function

2015-11-27 Thread Mikael Morin
Le 27/11/2015 13:20, Andre Vehreschild a écrit : Hi all, I have backported the patch for 68218 (multiple calls of the same function, where only one call is expected and reasonable) to gcc-5-branch and gcc-4_9-branch. Bootstrapped and regtested on x86_64-linux-gnu/f21. Ok for gcc-5-branch? Ok

[testsuite][ARM target attributes] Fix effective_target tests

2015-11-27 Thread Christophe Lyon
Hi, After the recent commits from Christian adding target attributes support for ARM FPU settings, I've noticed that some of the tests were failing because of incorrect assumptions wrt to the default cpu/fpu/float-abi of the compiler. This patch fixes the problems I've noticed in the following w

[Patch AArch64] Reinstate CANNOT_CHANGE_MODE_CLASS to fix pr67609

2015-11-27 Thread James Greenhalgh
Hi, This patch follow Richard Henderson's advice to tighten up CANNOT_CHANGE_MODE_CLASS for AArch64 to avoid a simplification bug in the middle-end. There is nothing AArch64-specific about the testcase which triggers this, so I'll put it in the testcase for other targets. If you see a regression

Re: [PATCH PR68529]Fix not recognized scev by computing no-overflow info for loop with NE_EXPR exit condition

2015-11-27 Thread Richard Biener
On Fri, Nov 27, 2015 at 12:44 PM, Bin Cheng wrote: > Hi, > This patch is to fix PR68529. In my previous scev/niter overflow patches, I > only computed no-overflow information for control iv in simple loops with > LT_EXPR as exit condition code. This bug is about loop with NE_EXPR as exit > condi

Re: [PATCH] Fix PR68029

2015-11-27 Thread Bernd Schmidt
On 11/27/2015 01:30 PM, Jiří Engelthaler wrote: Sorry for international characters in my name. It should be Jiri Engelthaler 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří : There is precedent for non-ASCII characters in ChangeLogs. Grep for Rafael Ávila de Espíndola. But I think there should b

Re: [PATCH] Fix PR68029

2015-11-27 Thread Jiří Engelthaler
Sorry for international characters in my name. It should be Jiri Engelthaler 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří : > > > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On > Behalf Of Jiří Engelthaler > Sent: Friday, November 27, 20

Re: [Fortran, patch, pr68218, backport to 5 and 4.9, v1] ALLOCATE with size given by a module function

2015-11-27 Thread Andre Vehreschild
Hi all, I have backported the patch for 68218 (multiple calls of the same function, where only one call is expected and reasonable) to gcc-5-branch and gcc-4_9-branch. Bootstrapped and regtested on x86_64-linux-gnu/f21. Ok for gcc-5-branch? Ok for gcc-4_9-branch? The Changelog is identical for

Re: [RFC] [Patch] PR67326 - relax trap assumption by looking at similar DRS

2015-11-27 Thread Richard Biener
On Fri, Nov 27, 2015 at 9:24 AM, Kumar, Venkataramanan wrote: > Hi Richard, > >> -Original Message- >> From: Richard Biener [mailto:richard.guent...@gmail.com] >> Sent: Tuesday, November 24, 2015 9:07 PM >> To: Kumar, Venkataramanan >> Cc: Jakub Jelinek (ja...@redhat.com); gcc-patches@gcc.

[PATCH] Add testcase for PR rtl-optimization/68250

2015-11-27 Thread Jakub Jelinek
Hi! Another REE issue dup. 2015-11-27 Jakub Jelinek PR rtl-optimization/68250 * gcc.c-torture/execute/pr68250.c: New test. --- gcc/testsuite/gcc.c-torture/execute/pr68250.c.jj2015-11-27 13:10:13.718447138 +0100 +++ gcc/testsuite/gcc.c-torture/execute/pr68250.c 2015

Re: [PATCH, 4/16] Implement -foffload-alias

2015-11-27 Thread Tom de Vries
On 27/11/15 12:42, Tom de Vries wrote: On 23/11/15 12:41, Richard Biener wrote: On Sat, 21 Nov 2015, Tom de Vries wrote: >On 13/11/15 12:39, Jakub Jelinek wrote: > >On Fri, Nov 13, 2015 at 12:29:51PM +0100, Richard Biener wrote: > > > >thanks for the explanation. Filed as PR68331 - '[meta-bu

[PATCH PR68529]Fix not recognized scev by computing no-overflow info for loop with NE_EXPR exit condition

2015-11-27 Thread Bin Cheng
Hi, This patch is to fix PR68529. In my previous scev/niter overflow patches, I only computed no-overflow information for control iv in simple loops with LT_EXPR as exit condition code. This bug is about loop with NE_EXPR as exit condition code. Given below example: #include #include int mai

Re: [PATCH] Convert a test to GIMPLE

2015-11-27 Thread Marek Polacek
On Fri, Nov 27, 2015 at 12:37:32PM +0100, Jakub Jelinek wrote: > I think it is just fine for 5 branch too. Ok, committed there as well. > You could even use int tem3 = ~m; and use tem3 instead of ~m if you really > wanted to test whether GIMPLE folding works. Sure. Marek

Re: [PATCH, 4/16] Implement -foffload-alias

2015-11-27 Thread Tom de Vries
On 23/11/15 12:41, Richard Biener wrote: On Sat, 21 Nov 2015, Tom de Vries wrote: >On 13/11/15 12:39, Jakub Jelinek wrote: > >On Fri, Nov 13, 2015 at 12:29:51PM +0100, Richard Biener wrote: > > > >thanks for the explanation. Filed as PR68331 - '[meta-bug] fipa-pta > > > >issues'. > > > > > >

[PATCH 4/7] S/390: Sort builtin types - cleanup only.

2015-11-27 Thread Andreas Krebbel
This patch sorts the builtin type definitions in the s390-builtin-types.def file properly. The file is script-generated from s390-builtins.def and this hopefully makes future patches smaller. 2015-11-27 Andreas Krebbel * config/s390/s390-builtin-types.def: Sort builtin types. --- gcc

[PATCH 5/7] S/390: Fix vec_splat_* builtins.

2015-11-27 Thread Andreas Krebbel
This enables the vec_splat_* builtins to make use of vrepi for constant operands. gcc/testsuite/ChangeLog: 2015-11-27 Andreas Krebbel * gcc.target/s390/zvector/vec-splat-2.c: New test. gcc/ChangeLog: 2015-11-27 Andreas Krebbel * config/s390/s390-builtin-types.def: New b

[PATCH 6/7] S/390: vec_set mode DI->SI for shift_count

2015-11-27 Thread Andreas Krebbel
gcc/ChangeLog: 2015-11-27 Andreas Krebbel * config/s390/vector.md ("*vec_set"): Change shift count mode from DI to SI. --- gcc/config/s390/vector.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md index

[PATCH 2/7] S/390: Enable vrepi constants.

2015-11-27 Thread Andreas Krebbel
This enables vrepi to be used on more situations. gcc/testsuite/ChangeLog: 2015-11-27 Andreas Krebbel * gcc.target/s390/vector/vec-vrepi-1.c: New test. gcc/ChangeLog: 2015-11-27 Andreas Krebbel * config/s390/constraints.md ("jKK"): New constraint. * config/s390/s

[PATCH 7/7] S/390: Make constant checking more strict

2015-11-27 Thread Andreas Krebbel
This makes the predicates and constraints on constant integer operands more strict in order to catch more problems at compile-time. gcc/ChangeLog: 2015-11-27 Andreas Krebbel * config/s390/predicates.md (const_mask_operand): New predicate. * config/s390/s390-builtins.def: Set a

[PATCH 3/7] S/390: Fix RT flag in vstrc instruction.

2015-11-27 Thread Andreas Krebbel
gcc/ChangeLog: 2015-11-27 Andreas Krebbel * config/s390/s390-c.c (s390_get_vstring_flags): Invert the condition for the RT flag. --- gcc/config/s390/s390-c.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/gcc/config/s390/s390-c.c

[PATCH 0/7] S/390: Minor fixes and improvements for the vector builtins.

2015-11-27 Thread Andreas Krebbel
The patchset has been tested as a whole on current mainline on s390 and s390x. I'll wait a couple of days for comments before committing them. Bye, -Andreas- Andreas Krebbel (7): S/390: Fix vrepi constraint letter. S/390: Enable vrepi constants. S/390: Fix RT flag in vstrc instruction.

[PATCH 1/7] S/390: Fix vrepi constraint letter.

2015-11-27 Thread Andreas Krebbel
gcc/ChangeLog: 2015-11-27 Andreas Krebbel * config/s390/vector.md ("*vec_splats"): Fix constraint latter I->K. gcc/testsuite/ChangeLog: 2015-11-27 Andreas Krebbel * gcc.target/s390/zvector/vec-splat-1.c: New test. --- gcc/config/s390/vector.md

[gomp4] Re: OpenACC declare directive updates

2015-11-27 Thread Thomas Schwinge
Hi! On Thu, 19 Nov 2015 10:22:16 -0600, James Norris wrote: > --- a/gcc/fortran/dump-parse-tree.c > +++ b/gcc/fortran/dump-parse-tree.c Don't you need to handle OMP_LIST_LINK in gcc/fortran/dump-parse-tree.c:show_omp_clauses; OMP_LIST_DEVICE_RESIDENT is being handled there (but maps to the wron

Re: [PATCH] Convert a test to GIMPLE

2015-11-27 Thread Jakub Jelinek
On Fri, Nov 27, 2015 at 12:30:24PM +0100, Richard Biener wrote: > On Fri, Nov 27, 2015 at 11:41 AM, Marek Polacek wrote: > > In the process of dealing with PR68513, it turned out this test should have > > been written with GIMPLE in mind. > > > > Tested on x86_64-linux, ok for trunk? Maybe we'll

[PATCH] Fix oacc kernels default mapping for scalars

2015-11-27 Thread Tom de Vries
Hi, The OpenACC 2.0a standard says this about the default mapping for variables used in a kernels region: ... An array or variable of aggregate data type referenced in the kernels construct that does not appear in a data clause for the construct or any enclosing data construct will be treated

Re: [PATCH] Convert a test to GIMPLE

2015-11-27 Thread Richard Biener
On Fri, Nov 27, 2015 at 11:41 AM, Marek Polacek wrote: > In the process of dealing with PR68513, it turned out this test should have > been written with GIMPLE in mind. > > Tested on x86_64-linux, ok for trunk? Maybe we'll want this even for 5, I > don't know yet. Ok. Richard. > 2015-11-27 Ma

Re: [PR67383][ARM][4.9]Backport of "Allow any register for DImode values in Thumb2"

2015-11-27 Thread Ramana Radhakrishnan
On 27/11/15 09:40, Renlin Li wrote: > Hi Ramana, > > On 16/10/15 14:54, Renlin Li wrote: >> >> >>> The command line implies we remove r7 (frame pointer in Thumb2 - historical >>> accident, fno-omit-frame-pointer), r9 (ffixed-r9), r10 (-mpic-register) >>> which >>> leaves us with: >>> >>> * r0,

Re: [PATCH] Fix PR68470, ICE in IPA split

2015-11-27 Thread Richard Biener
On Fri, 27 Nov 2015, Richard Biener wrote: > > This fixes the case where we split the returning part of a function > and keep the non-returning part as main. We were keeping the return > block with stmts not relevant to main in the return path of the > split which obviously doesn't work as it ma

[PATCH] Convert a test to GIMPLE

2015-11-27 Thread Marek Polacek
In the process of dealing with PR68513, it turned out this test should have been written with GIMPLE in mind. Tested on x86_64-linux, ok for trunk? Maybe we'll want this even for 5, I don't know yet. 2015-11-27 Marek Polacek * gcc.dg/pr63568.c: Convert to GIMPLE. diff --git gcc/test

[PATCH] Fix PR68029

2015-11-27 Thread Jiří Engelthaler
Hi all, the attached patch fixes PR68029 where GCC -fdiagnostics_color parameter was ignored if it was as first parameter. The problem is in GCC 6.0 version only so should be applied to the trunk. Jiří Engelthaler 2015-11-27 Jiří Engelthaler PR driver/68029 * opts-common.c (p

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

2015-11-27 Thread Bernd Schmidt
On 11/26/2015 10:46 AM, Richard Biener wrote: Ok with the change suggested by Micha for the asm()s. Note that I originally used gimple_vuse () instead of gimple_vdef () as even reading random memory is a barrier for the compiler to move stores across it (not reads, of course). Which is why I a

Re: [PATCH][RTL-ifcvt] Reject insns that are multiple_sets

2015-11-27 Thread Bernd Schmidt
On 11/27/2015 10:45 AM, Kyrill Tkachov wrote: As discussed, I've added a check for multiple_sets to insn_valid_noce_process_p and replaced the modified_a and modified_b redundant definitions with checking asserts to catch cases if any unexpected multiple sets get through the net. Ok, thanks!

[PATCH][RTL-ifcvt] Reject insns that are multiple_sets

2015-11-27 Thread Kyrill Tkachov
Hi all, As discussed, I've added a check for multiple_sets to insn_valid_noce_process_p and replaced the modified_a and modified_b redundant definitions with checking asserts to catch cases if any unexpected multiple sets get through the net. Bootstrapped and tested on arm, aarch64, x86_64. As

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case

2015-11-27 Thread Kyrill Tkachov
On 26/11/15 16:54, Kyrill Tkachov wrote: On 26/11/15 16:49, Bernd Schmidt wrote: On 11/26/2015 05:45 PM, Kyrill Tkachov wrote: that doesn't help, punt. */ - modified_in_a = emit_a != NULL_RTX && modified_in_p (orig_b, emit_a); if (tmp_b && then_bb) { These bits I though

Re: regrename/i386: ROP vs df and stack-regs

2015-11-27 Thread Eric Botcazou
> Both good points. Ok with those changes (will retest)? Yes, thanks. -- Eric Botcazou

Re: [PR67383][ARM][4.9]Backport of "Allow any register for DImode values in Thumb2"

2015-11-27 Thread Renlin Li
Hi Ramana, On 16/10/15 14:54, Renlin Li wrote: The command line implies we remove r7 (frame pointer in Thumb2 - historical accident, fno-omit-frame-pointer), r9 (ffixed-r9), r10 (-mpic-register) which leaves us with: * r0, r1 * r2, r3 * r4, r5 as the only free registers available for DImo

Re: [PATCH 1/6] Fix memory leak in cilk

2015-11-27 Thread Martin Liška
On 11/27/2015 10:21 AM, Bernd Schmidt wrote: > Already improved, wasn't it? (Please don't quote the entire previous patch > next time). > > > Bernd Thanks, I just applied nits pointed by you. Patch installed as r231001. Thank you, Martin

[PATCH] Fix PR68470, ICE in IPA split

2015-11-27 Thread Richard Biener
This fixes the case where we split the returning part of a function and keep the non-returning part as main. We were keeping the return block with stmts not relevant to main in the return path of the split which obviously doesn't work as it may use SSA names no longer defined (but split out). Th

Re: regrename/i386: ROP vs df and stack-regs

2015-11-27 Thread Bernd Schmidt
On 11/27/2015 10:26 AM, Eric Botcazou wrote: +#ifdef STACK_REGS + if (regstack_completed + && REG_P (recog_data.operand[i]) + && IN_RANGE (REGNO (recog_data.operand[i]), + FIRST_STACK_REG, LAST_STACK_REG)) + u

Re: regrename/i386: ROP vs df and stack-regs

2015-11-27 Thread Eric Botcazou
> Both of these are fixed in the i386 backend. As a further safety > measure, I've added some extra code to regrename to ignore stack regs > after regstack_complete - they can't be dealt with anymore. +#ifdef STACK_REGS + if (regstack_completed + && REG_P (recog_data.op

Re: basic asm and memory clobbers

2015-11-27 Thread Bernd Edlinger
Hi, On Tue, 17 Nov 2015 14:31:29, Jeff Law wrote: > The benefit is traditional asms do the expected thing. With no way to > describe dataflow, the only rational behaviour for a traditional asm is that > it has to be considered a use/clobber of memory and hard registers. I'd like to mention he

Re: [AArch64] Rework ARMv8.1 command line options.

2015-11-27 Thread Matthew Wahab
On 24/11/15 15:22, James Greenhalgh wrote: > On Mon, Nov 16, 2015 at 04:31:32PM +, Matthew Wahab wrote: >> >> The command line options for target selection allow ARMv8.1 extensions >> to be individually enabled/disabled. They also allow the extensions to >> be enabled with -march=armv8-a. This

Re: [PATCH 1/6] Fix memory leak in cilk

2015-11-27 Thread Bernd Schmidt
On 11/26/2015 09:59 PM, Martin Liška wrote: I'm sending v2 of the patch, where I removed adding of 'const' to certain function arguments. Apart from that, I found one more leak related to cilk. As I've retested in valgrind, there should not be any memory leak related to cilk. Ready to be install

regrename/i386: ROP vs df and stack-regs

2015-11-27 Thread Bernd Schmidt
This is a patch for PRs 68471 and 68472, which show problems with the ROP mitigation: * reg-stack doesn't call df_insn_update when it makes changes, and if df checking is enabled, any subsequent df_analyze call will abort * Using -mcmodel=medium fails because of a pattern that has lea typ

[PATCH][2/2] Fix PR68553

2015-11-27 Thread Richard Biener
This detects 1:1 permutations and avoids asking the target if it can create those as well as generating VEC_PERM_EXPR in the vectorized code. Bootstrap / regtest in progress on x86_64-unknown-linux-gnu. Richard. 2015-11-27 Richard Biener PR tree-optimization/68553 * tree-vec

Re: [PR67335] drop dummy zero from reverse VTA ops, fix infinite recursion

2015-11-27 Thread Jakub Jelinek
On Thu, Nov 26, 2015 at 09:45:06PM -0200, Alexandre Oliva wrote: > VTA's cselib expression hashing compares expressions with the same > hash before adding them to the hash table. When there is a collision > involving a self-referencing expression, we could get infinite > recursion, in spite of the

Re: [patch] Copy-edit the Option Summary in invoke.texi

2015-11-27 Thread Bernd Schmidt
On 11/26/2015 01:16 PM, Jonathan Wakely wrote: At https://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html we document -Waggressive-loop-optimizations but you can't find that option at https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html because we document -Wno-aggressive-loop-optimizations in

Re: [PATCH 7/N] Fix newly introduced memory leak in tree-ssa-loop-ivopts.c

2015-11-27 Thread Bin.Cheng
On Fri, Nov 27, 2015 at 4:29 PM, Martin Liška wrote: > On 11/27/2015 04:54 AM, Bin.Cheng wrote: >> On Fri, Nov 27, 2015 at 5:08 AM, Martin Liška wrote: >>> Hi. >>> >>> There's one more patch that fixes really of lot memory leaks related to loop >>> ivopts. >>> The regression was introduced by r23

[PATCH][1/2] Fix PR68553

2015-11-27 Thread Richard Biener
This is part 1 of a fix for PR68533 which shows that some targets cannot can_vec_perm_p on an identity permutation. I chose to fix this in the vectorizer by detecting the identity itself but with the current structure of vect_transform_slp_perm_load this is somewhat awkward. Thus the following n

Re: [PATCH 7/N] Fix newly introduced memory leak in tree-ssa-loop-ivopts.c

2015-11-27 Thread Martin Liška
On 11/27/2015 04:54 AM, Bin.Cheng wrote: > On Fri, Nov 27, 2015 at 5:08 AM, Martin Liška wrote: >> Hi. >> >> There's one more patch that fixes really of lot memory leaks related to loop >> ivopts. >> The regression was introduced by r230647. >> >> Patch was tested in the series with the rest and t

RE: [RFC] [Patch] PR67326 - relax trap assumption by looking at similar DRS

2015-11-27 Thread Kumar, Venkataramanan
Hi Richard, > -Original Message- > From: Richard Biener [mailto:richard.guent...@gmail.com] > Sent: Tuesday, November 24, 2015 9:07 PM > To: Kumar, Venkataramanan > Cc: Jakub Jelinek (ja...@redhat.com); gcc-patches@gcc.gnu.org > Subject: Re: [RFC] [Patch] PR67326 - relax trap assumption by