Re: [v3 PATCH] PR libstdc++/68139

2015-12-10 Thread Ville Voutilainen
On 11 December 2015 at 09:52, Marc Glisse wrote: /libstdc++-v3 * libsupc++/nested_exception.h (_S_rethrow): Use __std::addressof. >>> Typo. >> I must be blind, but I don't see what you mean. :) > Shouldn't the underscores apply to addressof, not to the namespace? Hah! Yes, thanks

Re: [v3 PATCH] PR libstdc++/68139

2015-12-10 Thread Markus Trippelsdorf
On 2015.12.11 at 09:50 +0200, Ville Voutilainen wrote: > On 11 December 2015 at 08:55, Marc Glisse wrote: > > On Fri, 11 Dec 2015, Ville Voutilainen wrote: > > > >> Tested on Linux-PPC64. > >> > >> 2015-12-11 Ville Voutilainen > >> > >>PR libstdc++/68139 > >> > >>/libstdc++-v3 > >>*

Re: [v3 PATCH] PR libstdc++/68139

2015-12-10 Thread Marc Glisse
On Fri, 11 Dec 2015, Ville Voutilainen wrote: On 11 December 2015 at 08:55, Marc Glisse wrote: On Fri, 11 Dec 2015, Ville Voutilainen wrote: Tested on Linux-PPC64. 2015-12-11 Ville Voutilainen PR libstdc++/68139 /libstdc++-v3 * libsupc++/nested_exception.h (_S_rethrow): Use __

Re: [v3 PATCH] PR libstdc++/68139

2015-12-10 Thread Ville Voutilainen
On 11 December 2015 at 08:55, Marc Glisse wrote: > On Fri, 11 Dec 2015, Ville Voutilainen wrote: > >> Tested on Linux-PPC64. >> >> 2015-12-11 Ville Voutilainen >> >>PR libstdc++/68139 >> >>/libstdc++-v3 >>* libsupc++/nested_exception.h (_S_rethrow): Use __std::addressof. > >

extend shift count warnings to vector types

2015-12-10 Thread Jan Beulich
gcc/c/ 2015-12-10 Jan Beulich * c-fold.c (c_fully_fold_internal): Also emit shift count warnings for vector types. * c-typeck.c (build_binary_op): Likewise. --- 2015-12-09/gcc/c/c-fold.c +++ 2015-12-09/gcc/c/c-fold.c @@ -320,8 +320,6 @@ c_fully_fold_internal (tree expr,

Re: [PATCH, i386] Use scalar mask for 16-byte and 32-byte vectors when possible

2015-12-10 Thread Kirill Yukhin
Hi, On 10 Dec 14:25, Ilya Enkovich wrote: > Ping > > 2015-11-26 13:33 GMT+03:00 Ilya Enkovich : > > This patch allows usage of scalar masks for ymm and xmm registers when > > target supports it. Bootstrapped and regtested on > > x86_64-unknown-linux-gnu. OK for trunk? Impact is not high. Your

Re: [v3 PATCH] PR libstdc++/68139

2015-12-10 Thread Marc Glisse
On Fri, 11 Dec 2015, Ville Voutilainen wrote: Tested on Linux-PPC64. 2015-12-11 Ville Voutilainen PR libstdc++/68139 /libstdc++-v3 * libsupc++/nested_exception.h (_S_rethrow): Use __std::addressof. ^^ Typo. /testsuite

Re: [PATCH] Fix ICE with -fno-if-conversion (PR rtl-optimization/68730)

2015-12-10 Thread Richard Biener
On December 10, 2015 9:11:16 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >It seems some passes in between the combiner and ira aren't prepared to >update dominance info. It usually is not a problem, because already >before >the combiner we call free_dominance_info. But we now have a new i?86 >stv

Register pressure aware loop unrolling

2015-12-10 Thread Shiva Chen
Hi all, Loop unrolling would decrease performance in some case due to unrolling high register pressure loops and produce lots of spill code. I try to implement register pressure aware loop unrolling(-funroll-loops-pressure-aware) to avoid unrolling high register pressure loops. The idea is to

Reduce global decl stream

2015-12-10 Thread Jan Hubicka
Hi, this patch saves about 30% of global decl stream size in firefox. While implementing the lto sections for initializers I put very stupid heursitcs to get_symbol_initial_value deciding whether the initializer is better streamed inline or offline. This ignores strings and may get bit out of han

Re: [PATCH][combine] Don't create LSHIFTRT of zero bits in change_zero_ext

2015-12-10 Thread Segher Boessenkool
On Thu, Dec 10, 2015 at 05:05:12PM +0100, Bernd Schmidt wrote: > On 12/10/2015 03:36 PM, Kyrill Tkachov wrote: > >I'm okay with delaying this for next stage 1 if people prefer, though I > >think it's > >pretty low risk. > > I think this is something we should fix now. I agree. > >+ x = XEXP

Do not decompress functions sections when copying them to ltrans

2015-12-10 Thread Jan Hubicka
Hi, this patch makes WPA to copy sections w/o decompressing them. This leads to a nice /tmp usage for GCC bootstrap (about 70%) and little for Firefox. In GCC about 5% of the ltrans object file is the global decl section, while for Firefox it is 85%. I will try to figure out if there is something

Re: [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)

2015-12-10 Thread Daniel Kahn Gillmor
On Thu 2015-12-10 18:59:33 -0500, Joseph Myers wrote: > On Thu, 10 Dec 2015, Daniel Kahn Gillmor wrote: > >> Specifically, if the first character of the "old" argument is a >> literal $, then gcc will treat it as an environment variable name, and >> use the value of the env var for prefix mapping.

Re: [Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %>

2015-12-10 Thread Joseph Myers
On Thu, 10 Dec 2015, Manuel López-Ibáñez wrote: > On 12/09/2015 03:53 PM, Tobias Burnus wrote: > > In principle, %<%c%> and %<%d%> should be convertable to %qc and > > %qd (as the code is more readable), but the current function > > annotation prevent this, telling that the q flag is not valid for

Re: [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)

2015-12-10 Thread Joseph Myers
On Thu, 10 Dec 2015, Daniel Kahn Gillmor wrote: > Specifically, if the first character of the "old" argument is a > literal $, then gcc will treat it as an environment variable name, and > use the value of the env var for prefix mapping. I don't think a literal $ in option arguments is a good ide

[PATCH] Fix PR c++/68831 (superfluous -Waddress warning for C++ delete)

2015-12-10 Thread Patrick Palka
Is this OK to commit if bootstrap + regtest on x86_64 succeeds? gcc/cp/ChangeLog: PR c++/68831 * init.c (build_delete): Use a warning sentinel to disable -Waddress warnings when building the conditional that tests if the operand is NULL. gcc/testsuite/ChangeLog:

Re: [PATCH] rtlanal: Fix bits/bytes confusion in set_noop_p (PR68814)

2015-12-10 Thread Segher Boessenkool
On Thu, Dec 10, 2015 at 01:26:06PM +0100, Eric Botcazou wrote: > Thanks. It seems a little odd for the condition to test the POS (operand #2) > and not also the LEN (operand #1) of the ZERO_EXTRACT before returning true, > but I'm not sure what the test would be given the above example. Or mayb

[v3 PATCH] PR libstdc++/68139

2015-12-10 Thread Ville Voutilainen
Tested on Linux-PPC64. 2015-12-11 Ville Voutilainen PR libstdc++/68139 /libstdc++-v3 * libsupc++/nested_exception.h (_S_rethrow): Use __std::addressof. /testsuite * 18_support/nested_exception/68139.cc: New. diff --git a/libstdc++-v3/libsupc++/nested_exception.h b/libstd

Transparent alias suport part 11: fix warning and error attributes with LTO

2015-12-10 Thread Jan Hubicka
Hi, this patch makes lto-symtab to not merge decls where warning and error attributes mismatch and finally clears up the invalid wanring compiling testcase from PR 61886. So it took only 11 patches and year and half to fix this beast... I am now finished with merging the original transparent alia

Re: [PATCH 1/6] [DJGPP] libstdc++-v3/config/os/djgpp/error_constants.h: Update according to errno codes available for DJGPP

2015-12-10 Thread DJ Delorie
> I can't really judge this one. Either DJ or Jon would need to some in > on this. Looks OK to me, although in the default configuration (plain DJGPP) the #ifdefs will always be false (omitted), which is harmless.

Re: [PATCH 5/6] [DJGPP] gcc/config/i386: update DJGPP configuration related files

2015-12-10 Thread Jeff Law
On 12/05/2015 10:22 AM, Andris Pavenis wrote: Patch include updates to DJGPP related files in gcc/config/i386. There are too many changes to gcc/config/i386/djgpp.h and gcc/config/i386/xm-djgpp.h to list them completely in changelog entry. Andris 2015-11-25 Andris Pavenis Subject: [PATCH 6/6

Re: [PATCH 4/6] [DJGPP] config/i386/djgpp: Update definitions of signed types

2015-12-10 Thread Jeff Law
On 12/05/2015 10:19 AM, Andris Pavenis wrote: Included patch updates typedefs of integer types in config/i386/djgpp-stdint.h. Patch is similar but not identical as attached to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41557 Andris 2015-12-05 Andris Pavenis * config/i386/djgpp-stdint.h: up

Re: [PATCH 1/6] [DJGPP] libstdc++-v3/config/os/djgpp/error_constants.h: Update according to errno codes available for DJGPP

2015-12-10 Thread Jeff Law
On 12/05/2015 11:36 AM, Andris Pavenis wrote: On 12/05/2015 06:35 PM, Andris Pavenis wrote: Included patch updates libstdc++-v3/config/os/djgpp/error_constants.h according to defines available in DJGPP errno.h. I'm reposting a patch as earlier post (Nov 15, 2015) have bug in changelog entry An

Re: [PATCH 6/6] [DJGPP] configure.ac: enable LTO

2015-12-10 Thread Jeff Law
On 12/05/2015 10:25 AM, Andris Pavenis wrote: Patch enables LTO support for DJGPP in top level configure.ac Andris 2015-12-05 Andris Pavenis * configure.ac: enable LTO for *-*-msdosdjgpp OK once prereqs have gone in. Note you should to the autoconf dance to update the generated files. Ment

Re: [PATCH 2/6] [DJGPP] libgcc: Add djgpp to lists of i[34567]86-*-* and x86_64-*-* soft-fp targets.

2015-12-10 Thread Jeff Law
On 12/05/2015 10:05 AM, Andris Pavenis wrote: Included patch adds *-*-msdosdjgpp to lists of i[34567]86-*-* soft-fp targets. Andris PS. Sending from different address as posts from other address seems not to go through 2015-12-05 Andris Pavenis * config.host: Add *-*-msdosdjgpp to lists of

Re: [PATCH 3/6] [DJGPP] libbacktrace/configure.ac: specify that DJGPP do not have mmap()

2015-12-10 Thread Jeff Law
On 12/05/2015 10:14 AM, Andris Pavenis wrote: Patch specifies that DJGPP do not have mmap() even when sys/mman.h is available. libbacktrace is perhaps currently unusable for DJGPP but otherwise mmap() usability misdetection breaks cross-compiler build for DJGPP target (for example Linux hosted cr

Re: [PATCH] Fix phiopt ICE in Factor conversion in COND_EXPR (PR tree-optimization/66949)

2015-12-10 Thread Jeff Law
On 12/08/2015 09:21 AM, Marek Polacek wrote: The following is a conservative fix for this PR. This is an ICE transpiring in the new "Factor conversion in COND_EXPR" optimization added in r225722. Before this optimization kicks in, we have : ... p1_32 = (short unsigned int) _20; :

Re: Free up bits in DECLs and TYPEs

2015-12-10 Thread DJ Delorie
I'm OK with the msp430 part :-)

Re: [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)

2015-12-10 Thread Daniel Kahn Gillmor
On Thu 2015-12-10 12:36:18 -0500, Daniel Kahn Gillmor wrote: > Work on the reproducible-builds project [0] has identified that build > paths are one cause of output variation between builds. This > changeset allows users to avoid this variation when building C objects > with debug symbols, while l

Re: [Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %>

2015-12-10 Thread Manuel López-Ibáñez
On 12/09/2015 03:53 PM, Tobias Burnus wrote: In principle, %<%c%> and %<%d%> should be convertable to %qc and %qd (as the code is more readable), but the current function annotation prevent this, telling that the q flag is not valid for %c and %d. As %< is fine, I didn't dig into it. You need t

RFA (hash-*): PATCH for c++/68309

2015-12-10 Thread Jason Merrill
The C++ front end uses a temporary hash table to remember specializations of local variables during template instantiations. In a nested function such as a lambda or local class member function, we need to retain the elements from the enclosing function's local_specializations table; otherwise

Re: [PATCH, testsuite] Fix PR68629: attr-simd-3.c failure on arm-none-eabi targets

2015-12-10 Thread Jeff Law
On 12/09/2015 02:56 AM, Thomas Preud'homme wrote: c-c++-common/attr-simd-3.c fails to compile on arm-none-eabi targets due to -fcilkplus needing -pthread which is not available for those targets. This patch solves this issue by adding a condition to the cilkplus effective target that compiling

[PATCH] Fix PR c++/21802 (two-stage name lookup fails for operators)

2015-12-10 Thread Patrick Palka
This patch fixes name-lookup of operators in template definitions whose operands are non-dependent expressions, i.e. PR c++/21802 (and incidentally 53223). The approach that this patch takes is to detect when build_new_op() returns a call to an overloaded function and to store a call to this overl

Re: [PATCH] Fix ICE with -fno-if-conversion (PR rtl-optimization/68730)

2015-12-10 Thread Jeff Law
On 12/10/2015 01:11 PM, Jakub Jelinek wrote: Hi! It seems some passes in between the combiner and ira aren't prepared to update dominance info. It usually is not a problem, because already before the combiner we call free_dominance_info. But we now have a new i?86 stv pass that is injected aft

[PTX] reorder function calling hooks

2015-12-10 Thread Nathan Sidwell
This patch reorders the function calling hooks so they come before write_one_arg. There's no change to their functionality, but it will allow them to be called from write_one_arg and write_result, rather than have those functions continue to independently perform essentially the same calculatio

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-12-10 Thread Jeff Law
On 12/03/2015 07:45 AM, Richard Biener wrote: Ah, some EEMBC one. Btw, the testcase that was added shows if (xc < xm) { xk = (unsigned char) (xc < xy ? xc : xy); } else { xk = (unsigned char) (xm < xy ? xm : xy); }

[PATCH] Fix ICE with -fno-if-conversion (PR rtl-optimization/68730)

2015-12-10 Thread Jakub Jelinek
Hi! It seems some passes in between the combiner and ira aren't prepared to update dominance info. It usually is not a problem, because already before the combiner we call free_dominance_info. But we now have a new i?86 stv pass that is injected after the combiner that computes dominators but do

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-12-10 Thread Jeff Law
On 12/03/2015 07:38 AM, Richard Biener wrote: This pass is now enabled by default with -Os but has no limits on the amount of stmts it copies. The more statements it copies, the more likely it is that the path spitting will turn out to be useful! It's counter-intuitive. The primary benefit AF

Re: [testsuite][ARM target attributes] Fix effective_target tests

2015-12-10 Thread Christophe Lyon
On 10 December 2015 at 14:14, Kyrill Tkachov wrote: > > On 10/12/15 13:04, Christophe Lyon wrote: >> >> On 10 December 2015 at 13:30, Kyrill Tkachov >> wrote: >>> >>> Hi Christophe, >>> >>> >>> On 08/12/15 11:18, Christophe Lyon wrote: On 8 December 2015 at 11:50, Kyrill Tkachov w

Re: Request permission to delete gcc.dg/vect/costmodel/ppc/costmodel-fast-math-vect-pr29925.c

2015-12-10 Thread David Edelsohn
On Thu, Dec 10, 2015 at 2:23 PM, Bill Schmidt wrote: > Hi, > > The subject test case has been failing as follows: > > FAIL: gcc.dg/vect/costmodel/ppc/costmodel-fast-math-vect-pr29925.c > scan-tree-dump-times vect "vectorization not profitable" 1 > > The test has been failing since r223528, which

Request permission to delete gcc.dg/vect/costmodel/ppc/costmodel-fast-math-vect-pr29925.c

2015-12-10 Thread Bill Schmidt
Hi, The subject test case has been failing as follows: FAIL: gcc.dg/vect/costmodel/ppc/costmodel-fast-math-vect-pr29925.c scan-tree-dump-times vect "vectorization not profitable" 1 The test has been failing since r223528, which is: 2015-05-22 Richard Biener PR tree-optimization/657

Re: [PATCH 4/4] Add -Wmisleading-indentation to -Wall

2015-12-10 Thread David Malcolm
On Thu, 2015-10-29 at 11:38 -0600, Jeff Law wrote: > On 10/29/2015 10:49 AM, David Malcolm wrote: > > Our documentation describes -Wall as enabling "all the warnings about > > constructions that some users consider questionable, and that are easy to > > avoid > > (or modify to prevent the warning)

[google][gcc-4_9] update hardreg costs only when conflict_costs[] < 0

2015-12-10 Thread Wei Mi
Hi, The patch is for google branch only. In r216697, when a hardreg is assigned to an allocno, a positive cost will be added to those conflict allocnos to reflect the disfavor of the hardreg. However, the fact that conflict allocno disfavors a hard_regno doesn't necessarily mean current allocno

Patch to fix PR68691

2015-12-10 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68691 The patch was bootstrapped and tested on x86/x86-64. Committed as rev. 231538. Index: ChangeLog === --- ChangeLog (revision 231537) +++ ChangeLog

Re: [hsa 2/10] Modifications to libgomp proper

2015-12-10 Thread Martin Jambor
Hi, thanks for the feedback. I have incorporated most of it into the branch (the diff is below) but also have a few questions. On Wed, Dec 09, 2015 at 12:35:36PM +0100, Jakub Jelinek wrote: > On Mon, Dec 07, 2015 at 12:19:57PM +0100, Martin Jambor wrote: > > +/* Flag set when the subsequent ele

Re: [hsa 0/10] Merge of HSA branch

2015-12-10 Thread Martin Jambor
Hi, On Mon, Dec 07, 2015 at 12:46:45PM +0100, Jakub Jelinek wrote: > On Mon, Dec 07, 2015 at 12:17:58PM +0100, Martin Jambor wrote: > > Because I have not been able to come up with any solution to failing > > libgomp/testsuite/libgomp.c++/target-2.C, I have disabled use of > > dynamic parallelism

Re: [hsa 1/10] Configury changes and new options

2015-12-10 Thread Martin Jambor
Hi, On Mon, Dec 07, 2015 at 12:19:08PM +0100, Martin Jambor wrote: > Hi, > > this patch contains changes to the configuration mechanism and offload > bits, so that users can build compilers with HSA support. when writing up how to build an HSA-enabled GCC for the wiki page, and checking the proc

Re: [hsa 1/10] Configury changes and new options

2015-12-10 Thread Martin Jambor
Hi, On Tue, Dec 08, 2015 at 10:43:15PM +, Richard Sandiford wrote: > [Sorry for the low-quality review, was just reading out of interest...] > > Martin Jambor writes: > > +If you configure GCC with HSA offloading but do not have the HSA > > +run-time library installed in a standard location

[PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)

2015-12-10 Thread Daniel Kahn Gillmor
Work on the reproducible-builds project [0] has identified that build paths are one cause of output variation between builds. This changeset allows users to avoid this variation when building C objects with debug symbols, while leaving the default behavior unchanged. Background -- gcc in

Re: [v3] avoid alignment of static variables affecting stack's

2015-12-10 Thread Bernd Schmidt
On 12/10/2015 05:07 PM, Jan Beulich wrote: If not reaching if (TREE_CODE (origvar) == SSA_NAME) { gcc_assert (TREE_CODE (var) != VAR_DECL || (!DECL_EXTERNAL (var) && !DECL_HAS_VALUE_EXPR_P (var) && !TREE_STATIC (var)

Re: Free up bits in DECLs and TYPEs

2015-12-10 Thread Bernd Schmidt
On 12/10/2015 04:04 PM, Michael Matz wrote: This isn't stage 3 material really, OTOH fairly low risk. Anyway, okay for trunk now or once stage 1 opens? This is cool and we want it, but not now. Ok for stage 1, with the formatting problems quoted below fixed. Bernd +#define TYPE_ALIGN(NOD

Re: [RFA] [PATCH] [PR tree-optimization/68619] Avoid direct cfg cleanups in tree-ssa-dom.c [4/3] v2

2015-12-10 Thread Jeff Law
On 12/10/2015 10:05 AM, Uros Bizjak wrote: Finally the mechanical changes necessary due to the API change in the walker. You forgot to change the graphite part, as in the attached patch. 2015-12-10 Uros Bizjak PR tree-optimization/68619 * graphite-scop-detection.c (gather_bbs::be

Re: [RFA] [PATCH] [PR tree-optimization/68619] Avoid direct cfg cleanups in tree-ssa-dom.c [4/3] v2

2015-12-10 Thread Uros Bizjak
> Finally the mechanical changes necessary due to the API change in the walker. You forgot to change the graphite part, as in the attached patch. 2015-12-10 Uros Bizjak PR tree-optimization/68619 * graphite-scop-detection.c (gather_bbs::before_dom_children): Change return type to

Re: [PATCH] testsuite/lib/multline.exp: show test name and line numbers

2015-12-10 Thread Bernd Schmidt
On 12/10/2015 03:56 PM, David Malcolm wrote: The following patch updates multiline.exp to use the global $testname_with_flags as a prefix in such results. I also dropped the printing of the index in favor of printing the line numbers enclosed within dg-{begin|end}-multiline-output. After the

[PATCH 2/2] [graphite] update required isl versions

2015-12-10 Thread Sebastian Pop
we now check the isl version, as there are no real differences in existing files in between isl 0.14 and isl 0.15. --- config/isl.m4 | 41 +++-- configure | 112 -- 2 files changed, 123 insertions(+), 30 deletions(-) dif

[PATCH 1/2] [graphite] document minimal required version for isl

2015-12-10 Thread Sebastian Pop
also update ISL to isl as requested by its author Sven Verdoolaege. --- gcc/doc/install.texi | 9 + gcc/doc/invoke.texi | 4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index 0b71bef..b43a3ec 100644 --- a/gcc/doc/install.

Re: [PATCH] update -Wall and -Wextra documentation

2015-12-10 Thread Bernd Schmidt
On 12/10/2015 05:52 PM, Martin Sebor wrote: The updated patch is attached. Ok. Bernd

Re: ipa-cp heuristics fixes

2015-12-10 Thread Jan Hubicka
> Is this really necessary, is it not enough to remove the assignment to > ret below? If the parameter is not used, devirtualization time bonus, > which you then rely on estimate_local_effects, should be zero for it. > > It is a very minor point, I suppose, but if the function gets cloned > for a

Re: [PATCH] update -Wall and -Wextra documentation

2015-12-10 Thread Martin Sebor
On 12/10/2015 04:57 AM, Bernd Schmidt wrote: On 12/10/2015 12:07 AM, Martin Sebor wrote: * invoke.texi (Warning Options): Update -Wall options. Clarify when some -Wextra options are enabled. Add -Wplacement-new example. I tried to check this list against c.opt - I figure this should

Re: [PATCH] PR c/68473: sanitize source range-printing within certain macro expansions

2015-12-10 Thread Martin Sebor
On 11/23/2015 10:52 AM, David Malcolm wrote: This patch fixes PR c/68473 by bulletproofing the new diagnostic_show_locus implementation against ranges that finish before they start (which can happen when using the C preprocessor), falling back to simply printing a caret. Successfully bootstrappe

Re: [PATCH] v2 Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-10 Thread Tobias Burnus
David Malcolm wrote: > On Sat, 2015-12-05 at 20:53 +0100, Mikael Morin wrote: > > to get things moving again, a few comments on top of David Malcolm's: [...] > > It seems you are considering some candidates more than once here. [...] > > You have to start the lookup with the current namespace's sym

Re: [v3] avoid alignment of static variables affecting stack's

2015-12-10 Thread Jan Beulich
>>> On 10.12.15 at 14:53, wrote: > On 12/10/2015 01:38 PM, Jan Beulich wrote: >> --- 2015-12-09/gcc/cfgexpand.c >> +++ 2015-12-09/gcc/cfgexpand.c >> @@ -1544,12 +1544,15 @@ static HOST_WIDE_INT >> expand_one_var (tree var, bool toplevel, bool really_expand) >> { >> unsigned int align = BIT

Re: [PATCH][combine] Don't create LSHIFTRT of zero bits in change_zero_ext

2015-12-10 Thread Bernd Schmidt
On 12/10/2015 03:36 PM, Kyrill Tkachov wrote: I'm okay with delaying this for next stage 1 if people prefer, though I think it's pretty low risk. I think this is something we should fix now. + x = XEXP (x, 0); + if (start > 0) + x = gen_rtx_LSHIFTRT (mode, x, GEN_INT

[Fortran, Patch} Fix ICE for coarray Critical inside module procedure

2015-12-10 Thread Alessandro Fanfarillo
Dear all, the compiler returns an ICE when a coarray critical section is used inside a module procedure. The symbols related with the lock variables were left uncommitted inside resolve_critical(). A gfc_commit_symbol after each symbol or a gfc_commit_symbols at the end of resolve_critical() fixed

[committed 1/5] Fix -Wmisleading-indentation warning in function.c

2015-12-10 Thread David Malcolm
Fix this warning: ../../../src/gcc/function.c: In function ‘void locate_and_pad_parm(machine_mode, tree, int, int, int, tree, args_size*, locate_and_pad_arg_data*)’: ../../../src/gcc/function.c:4123:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] {

Re: [committed 1/5] Fix -Wmisleading-indentation warning in function.c

2015-12-10 Thread David Malcolm
FWIW, I believe trunk is clean for -Wmisleading-indentation after these 5 patches (for x86_64-pc-linux-gnu, at least).

Gather hash-tab statistics only with GATHER_STATISTICS

2015-12-10 Thread Michael Matz
Hi, while profiling cc1plus I noticed high hash-table activity for gathering statistics, even though I haven't configured with --enable-gather-detailed-mem-stats. Turns out the hash table rewrite hard-coded the relevant settings to true. This patch makes it initialized by GATHER_STATISTICS.

[committed 3/5] Fix -Wmisleading-indentation warning in gcc/regrename.c

2015-12-10 Thread David Malcolm
../../../src/gcc/regrename.c: In function ‘void scan_rtx_address(rtx_insn*, rtx_def**, reg_class, scan_actions, machine_mode, addr_space_t)’: ../../../src/gcc/regrename.c:1314:7: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] break; ^ ../..

[committed 5/5] Fix -Wmisleading-indentation warning in graphite-optimize-isl.c

2015-12-10 Thread David Malcolm
../../../src/gcc/graphite-optimize-isl.c: In function ‘isl_union_set* scop_get_domains(scop_p)’: ../../../src/gcc/graphite-optimize-isl.c:362:5: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] return res; ^~ In file included from ../../../s

[committed 4/5] Fix -Wmisleading-indentation warning in ifcvt.c

2015-12-10 Thread David Malcolm
../../../src/gcc/ifcvt.c: In function ‘bool noce_try_inverse_constants(noce_if_info*)’: ../../../src/gcc/ifcvt.c:1233:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] seq = end_ifcvt_sequence (if_info); ^~~ ../../../src/gcc/ifcvt.c:1230:7: note: ..

[committed 2/5] Fix misleading indentation in gcc/fortran/io.c

2015-12-10 Thread David Malcolm
Fix this warning: ../../../src/gcc/fortran/io.c: In function ‘match gfc_match_open()’: ../../../src/gcc/fortran/io.c:2003:4: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] if (!compare_to_allowed_values ("DELIM", delim, NULL, NULL, ^ ../../../src/

Re: [PATCH] Add testcase for c++/68348

2015-12-10 Thread Jason Merrill
OK. Jason

Re: [ARM] Use vector wide add for mixed-mode adds

2015-12-10 Thread Kyrill Tkachov
Hi Michael, A few comments while I look deeper into this patch... On 30/11/15 01:18, Michael Collison wrote: This is a modified version of my previous patch that supports vector wide add. I added support for vaddw on big endian when generating the parallel operand for the vector select. The

Free up bits in DECLs and TYPEs

2015-12-10 Thread Michael Matz
Hello, the other day Richi wondered why we specify alignment in bits, instead of in log2, as if e.g. a 12 byte alignment would make much sense (sure, an alignment of 12 byte means the address is evenly dividable by 12; great!). This patch changes the two places where we specify alignment (types

RE: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-10 Thread Claudiu Zissulescu
> > OTOH, the example you give also shows a much more nuanced approach to > throttling optimization: > the patch doesn't dead all epilogue scheduling, but specifically tests for the > presence of a frame related insn at the point where it could cause trouble. Actually, in my revised patch I do m

[patch] Update -std=gnu++1y in experimental::shared_ptr tests

2015-12-10 Thread Jonathan Wakely
Mechanical change to update the spelling of the -std option. Committed to trunk. commit ec7bb2c77a41d6e34e4e29e24195845380ef071f Author: Jonathan Wakely Date: Thu Dec 10 14:34:52 2015 + Change tests to use -std=gnu++14 not -std=gnu++1y * testsuite/experimental/memory/shared_

[PATCH] testsuite/lib/multline.exp: show test name and line numbers

2015-12-10 Thread David Malcolm
The output from multiline.exp doesn't scale well when reviewing and comparing .sum files. Lines in e.g. gcc.sum from a dg-{begin|end}-multiline-output pair are currently of the form: PASS: expected multiline pattern 0 was found: "\s*myvar = myvar\.x;.*\n ~\^~\n" as compared to e.g

[PATCH][combine] Don't create LSHIFTRT of zero bits in change_zero_ext

2015-12-10 Thread Kyrill Tkachov
Hi all, At the end of combine if it fails to recognise the patterns it produces it tries again after transforming all zero_extends and zero_extracts into and-immediate plus an LSHIFTRT if needed. However, it will construct an LSHIFTRT inside the AND even if the shift distance is 0, which can hu

[patch] libstdc++/68825 Fix dejagnu directives in shared_ptr test

2015-12-10 Thread Jonathan Wakely
This XFAIL test should have been used { dg-do compile } so it doesn't get marked UNRESOLVED when it fails to compile. The test was also broken, the assignment operator compiled OK, but because the test used dg-excess-errors instead of dg-error the later failure for the copy construction matched it

Fix PR ada/48013

2015-12-10 Thread Eric Botcazou
This reports an interesting case where the compiler emits an empty elaboration routine and doesn't report the violation of the associated No_Elaboration_Code restriction. Probably harmless in practice, but this small hole in gigi can easily be plugged. Tested on x86-64/Linux, applied on the ma

[PATCH] Fix IPA PTA wrong-code bug with LTO

2015-12-10 Thread Richard Biener
The following patch fixes a latent issue in IPA PTA with LTO where it doesn't properly honor partition boundaries. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-12-10 Richard Biener * tree-ssa-structalias.c (struct variable_info): Add is_ipa_esc

[PATCH][RX] v2 instructions support.

2015-12-10 Thread Yoshinori Sato
Add RX v2 enhancement instructions support. gcc/ChangeLog 2015/12/10 Yoshinori Sato * config/rx/constraints.md: Add constraint "q". * doc/md.texi: Likewise. * config/rx/rx-opts.h(rx_cpu_types): Add type RXV2. * config/rx/rx.c(rx_print_operand): Add a0, a1 and ex

[Ada] Fix internal error on call taking empty array Out parameter

2015-12-10 Thread Eric Botcazou
This is a regression present on the mainline only, for a pathological case where an empty array is passed as Out parameter to a procedure, but the code is actually never executed because it's inside an empty loop... Tested on x86-64/Linux, applied on the mainline. 2015-12-10 Eric Botcazou

[patch] Improve generated libstdc++ API docs

2015-12-10 Thread Jonathan Wakely
This adjusts some Doxygen comments and updates the Doxygen config file to ensure all headers are processed (previously doxygen was ignoring filenames without an extension, which is a lot of the library!) There's a workaround in include/std/bitset for the bug https://bugzilla.gnome.org/show_bug.c

Re: [v3] avoid alignment of static variables affecting stack's

2015-12-10 Thread Bernd Schmidt
On 12/10/2015 01:38 PM, Jan Beulich wrote: * cfgexpand.c (expand_one_var): Exclude static and external variables when adjusting stack alignment related state. gcc/testsuite/ 2015-12-10 Jan Beulich * gcc.c-torture/execute/stkalign.c: New. --- 2015-12-09/gcc/cfgexpand

Re: [PATCH] Fix detection of setrlimit in libstdc++ testsuite

2015-12-10 Thread Maxim Kuvyrkov
> On Nov 11, 2015, at 7:56 PM, Maxim Kuvyrkov wrote: > > Hi, > > This patch fixes an obscure cross-testing problem that crashed (OOMed) our > boards at Linaro. Several tests in libstdc++ (e.g., [1]) limit themselves to > some reasonable amount of RAM and then try to allocate 32 gigs. > Unfo

[Ada] Comment fixes

2015-12-10 Thread Eric Botcazou
Tested on x86-64/Linux, applied on the mainline. 2015-12-10 Eric Botcazou * gcc-interface/gigi.h (create_var_decl): Adjust comment. (create_subprog_decl): Likewise. * gcc-interface/utils.c (create_var_decl): Likewise. (create_subprog_decl): Likewise. -- Eric

Re: [PATCH PR68542]

2015-12-10 Thread Richard Biener
On Fri, Dec 4, 2015 at 4:07 PM, Yuri Rumyantsev wrote: > Hi Richard. > > Thanks a lot for your review. > Below are my answers. > > You asked why I inserted additional check to > ++ b/gcc/tree-ssa-forwprop.c > @@ -373,6 +373,11 @@ combine_cond_expr_cond (gimple *stmt, enum > tree_code code, tree ty

RE: [PATCH] [ARC] Add support for atomic memory built-in.

2015-12-10 Thread Claudiu Zissulescu
Patch applied: Committed r231509 Thanks, Claudiu > -Original Message- > From: Joern Wolfgang Rennecke [mailto:g...@amylaar.uk] > Sent: Wednesday, December 09, 2015 6:11 AM > To: Claudiu Zissulescu; gcc-patches@gcc.gnu.org > Cc: francois.bed...@synopsys.com; jeremy.benn...@embecosm.com >

Re: [PATCH] Fix up noce_try_abs again (PR rtl-optimization/68670)

2015-12-10 Thread Jakub Jelinek
On Thu, Dec 10, 2015 at 02:20:04PM +0100, Bernd Schmidt wrote: > This turns into a much simpler if statement, doesn't it? Ok with that > change. Ok, will do, thanks. > >+/* PR rtl-optimization/68670 */ > >+/* { dg-do run } */ > >+/* { dg-options "-O2 -ftracer" } */ > > Curious what effect -ftrac

[PATCH] Fix PR68817

2015-12-10 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-12-10 Richard Biener PR tree-optimization/68817 * tree-vect-slp.c (vect_attempt_slp_rearrange_stmts): Detect gaps early. * gfortran.dg/pr68817.f90: New testcase. Index: gcc/tree-vec

Re: [PATCH] Fix up noce_try_abs again (PR rtl-optimization/68670)

2015-12-10 Thread Bernd Schmidt
On 12/09/2015 11:37 PM, Jakub Jelinek wrote: Not sure what I've been thinking when writing the previous noce_try_abs fix. I thought that the optimization can be applied for all the conditions, and whether it can be applied depends on if it is cond ? ~x : x or cond ? x : ~x. But that is not the c

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-10 Thread Tom de Vries
[ copy-pasting-with-quote from https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00420.html , for some reason I didn't get this email ] On Thu, 3 Dec 2015, Tom de Vries wrote: The flag is set here in expand_omp_target: ... 12682 /* Prevent IPA from removing child_fn as unreachable,

Re: [testsuite][ARM target attributes] Fix effective_target tests

2015-12-10 Thread Kyrill Tkachov
On 10/12/15 13:04, Christophe Lyon wrote: On 10 December 2015 at 13:30, Kyrill Tkachov wrote: Hi Christophe, On 08/12/15 11:18, Christophe Lyon wrote: On 8 December 2015 at 11:50, Kyrill Tkachov wrote: Hi Christophe, On 27/11/15 13:00, Christophe Lyon wrote: Hi, After the recent commi

Re: [testsuite][ARM target attributes] Fix effective_target tests

2015-12-10 Thread Christophe Lyon
On 10 December 2015 at 13:30, Kyrill Tkachov wrote: > Hi Christophe, > > > On 08/12/15 11:18, Christophe Lyon wrote: >> >> On 8 December 2015 at 11:50, Kyrill Tkachov >> wrote: >>> >>> Hi Christophe, >>> >>> >>> On 27/11/15 13:00, Christophe Lyon wrote: Hi, After the recent co

Re: [RFA] [PATCH] [PR tree-optimization/68619] Avoid direct cfg cleanups in tree-ssa-dom.c [0/3] v2

2015-12-10 Thread Richard Biener
On Thu, Dec 10, 2015 at 12:23 AM, Jeff Law wrote: > Richi and I have been discussing revamping slightly how DOM handles > conditionals which it detects are always true or always false. > > During gcc6 stage1 I added code to allow DOM to clean them up > immediately, primarily to avoid the waste of

[v3] avoid alignment of static variables affecting stack's

2015-12-10 Thread Jan Beulich
Function (or more narrow) scope static variables (as well as others not placed on the stack) should also not have any effect on the stack alignment. I noticed the issue first with Linux'es dynamic_pr_debug() construct using an 8-byte aligned sub-file-scope local variable. According to my checking

Re: [testsuite][ARM target attributes] Fix effective_target tests

2015-12-10 Thread Kyrill Tkachov
Hi Christophe, On 08/12/15 11:18, Christophe Lyon wrote: On 8 December 2015 at 11:50, Kyrill Tkachov wrote: Hi Christophe, On 27/11/15 13:00, Christophe Lyon wrote: Hi, After the recent commits from Christian adding target attributes support for ARM FPU settings, I've noticed that some of

Re: [PATCH] rtlanal: Fix bits/bytes confusion in set_noop_p (PR68814)

2015-12-10 Thread Eric Botcazou
> My case comes from the gcc.dg/pr65492-2.c, the "test1int2" case. > combine has made an insn > modifying insn i321: zero_extract(%3:DI,0x20,0)=%3:DI > which is splatting the SImode parameter to both the high and low halves > of the dest reg. Then, it tries to combine it with the USE of

Re: [RFA] Transparent alias suport part 10: Fix base+offset alias analysis oracle WRT aliases

2015-12-10 Thread Eric Botcazou
> PR ipa/61886 > PR middle-end/25140 > * tree-ssa-alias.c (ptr_deref_may_alias_decl_p): Usecompare_base_decls > (nonoverlapping_component_refs_of_decl_p): Update sanity check. > (decl_refs_may_alias_p): Use compare_base_decls. > * alias.c: Include cgraph.h >

  1   2   >