Re: [PATCH] PR fortran/78033 -- This was a REAL pain

2016-10-21 Thread Paul Richard Thomas
Hi Steve, Thanks for persevering with this. The patch looks good to me. If it has regtested OK, please feel free to commit. Cheers Paul On 22 October 2016 at 02:22, Steve Kargl wrote: > All, > > The attached patch fixes PR fortran/78033. This was a REAL pain > to fix because Fortran overloads

Re: [PATCH] Extend -Wint-in-bool-context to warn for multiplications

2016-10-21 Thread Bernd Edlinger
On 10/22/16 04:17, Martin Sebor wrote: > On 10/21/2016 04:37 PM, Joseph Myers wrote: >> The quoting in the diagnostic should be %<&&%>, not '&&'. > > Presumably same for '*' (i.e., %<*%>). > > But I would actually suggest a somewhat more formal phrasing than > "better use xxx here" such as "suggest

Re: [PATCH] Extend -Wint-in-bool-context to warn for multiplications

2016-10-21 Thread Martin Sebor
On 10/21/2016 04:37 PM, Joseph Myers wrote: The quoting in the diagnostic should be %<&&%>, not '&&'. Presumably same for '*' (i.e., %<*%>). But I would actually suggest a somewhat more formal phrasing than "better use xxx here" such as "suggest %<&&%> instead" or something akin to what's alre

Re: [PATCH 2/5] [AARCH64] Change IMP and PART over to integers from strings.

2016-10-21 Thread Andrew Pinski
On Fri, Oct 21, 2016 at 9:28 AM, James Greenhalgh wrote: > On Fri, Oct 21, 2016 at 04:57:22PM +0100, Richard Earnshaw (lists) wrote: >> On 21/10/16 14:59, James Greenhalgh wrote: >> > On Sat, Oct 15, 2016 at 07:38:40PM -0700, Andrew Pinski wrote: >> >> On Wed, Nov 25, 2015 at 11:59 AM, Andrew Pins

Re: Ping Re: [PATCH] go-lang.c: remove a redundant cast

2016-10-21 Thread Ian Lance Taylor
David Malcolm writes: >> gcc/go/ChangeLog: >> > * go-lang.c (go_langhook_type_for_mode): Remove redundant cast >> > from result of GET_MODE_CLASS. Minor formatting fixes. This is OK. Thanks. Ian

[PATCH] PR fortran/78033 -- This was a REAL pain

2016-10-21 Thread Steve Kargl
All, The attached patch fixes PR fortran/78033. This was a REAL pain to fix because Fortran overloads REAL as an intrinsic type and an intrinsic subprogram. gfc_match_type_spec() in match.c is used to match Fortran 2003 type-specs in things like array constructors and TYPE IS statements. At some

relax rule for flexible array members in 6.x (78039 - fails to compile glibc tests)

2016-10-21 Thread Martin Sebor
Bug 78039 complains that the fix for c++/71912 recently backported to the GCC 6 branch causes GCC 6 to reject Glibc tests that expect to be able to define structs with multiple flexible array members, despite it violating the C standard(*). The rejected code is unsafe and was intended to be rejec

Fwd: [Patch, fortran] PR69834 - Collision in derived type hashes

2016-10-21 Thread Dominique d'Humières
> Début du message réexpédié : > > De: Dominique d'Humières > Objet: Rép : [Patch, fortran] PR69834 - Collision in derived type hashes > Date: 22 octobre 2016 à 01:04:21 UTC+2 > À: Paul Richard Thomas > Cc: Andre Vehreschild , fort...@gcc.gnu.org, gcc-patches List > > > Dear Paul, > > If I

[rs6000] Add support for signed overflow arithmetic

2016-10-21 Thread Eric Botcazou
Hi, this implements support for signed overflow arithmetic on PowerPC. It's an implementation for Power ISA v2.0x, i.e. it doesn't take account the new OV32 flag introduced in v3.0. It doesn't implement unsigned overflow arithmetic because my understanding is that the generic support already

Re: [PATCH] Extend -Wint-in-bool-context to warn for multiplications

2016-10-21 Thread Joseph Myers
The quoting in the diagnostic should be %<&&%>, not '&&'. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH v3] gcc/config/tilegx/tilegx.c (tilegx_function_profiler): Save r10 to stack before call mcount

2016-10-21 Thread Chen Gang
On 10/20/16 06:42, Jeff Law wrote: >> On 6/4/16 21:25, cheng...@emindsoft.com.cn wrote: >>> From: Chen Gang >>> >>> r10 may also be as parameter stack pointer for the nested function, so >>> need save it before call mcount. >>> >>> Also clean up code: use '!' instead of "== 0" for checking >>> sta

[PATCH, RFC] Fix PR71915, PR71490: Handle casts on strides consistently

2016-10-21 Thread Bill Schmidt
Hi, I've been meaning for some time now to do a better job handling strength reduction candidates where the stride of the candidate and its basis involves a cast (usually widening) from another type. The two PRs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71490 and https://gcc.gnu.org/bugzilla/s

[RFA][PR tree-optimization/72785] Avoid duplicating blocks with b_c_p or b_o_s calls.

2016-10-21 Thread Jeff Law
As noted in the BZ, jump threading is isolating a path which contains a b_c_p call. The result of the isolation is that on the original path, b_c_p continues to return 0 (not-constant), but on the isolated path it returns 1 (because the feeding PHI argument is constant). That in turn causes

Re: libgo patch committed: Rewrite interface code into Go

2016-10-21 Thread Ian Lance Taylor
On Fri, Oct 21, 2016 at 4:16 AM, Rainer Orth wrote: > >> This patch to libgo rewrites the interface code from C to Go. >> >> I started to copy the Go 1.7 interface code, but the gc and gccgo >> representations of interfaces are too different. So instead I rewrote >> the gccgo interface code from

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-21 Thread Mike Stump
On Oct 21, 2016, at 12:47 PM, Martin Sebor wrote: > > The latest patch works as expected for me, both with an operand > and with stdin. But since I'm not empowered to approve it one > of the others reviewers will need to give it their blessing. Seems fine from a test suite perspective, but not

Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

2016-10-21 Thread Jakub Jelinek
On Fri, Oct 21, 2016 at 02:38:11PM -0600, Tom Tromey wrote: > > "Jakub" == Jakub Jelinek writes: > > Jakub> Also, as this effectively requires the latest unreleased GDB under the > Jakub> default options for something that has been working previously, I > wonder > Jakub> if it e.g. for some

libgo patch committed: Fix int64 alignment on 32-bit SPARC

2016-10-21 Thread Ian Lance Taylor
This patch to libgo fixes the expected alignment of int64 types on 32-bit SPARC. Without this most calls to select fail at runtime, as the compiler and the library disagree about the expected size of the hselect struct. Bootstrapped and ran Go testsuite on x86_pc-linux-gnu, bootstrapped and ran a

Re: RFC [1/3] divmod transform v2

2016-10-21 Thread Jeff Law
On 10/21/2016 04:34 AM, Prathamesh Kulkarni wrote: On 20 October 2016 at 15:02, Richard Biener wrote: On Wed, 19 Oct 2016, Jeff Law wrote: On 10/15/2016 11:59 PM, Prathamesh Kulkarni wrote: Hi, After approval from Bernd Schmidt, I committed the patch to remove optab functions for sdivmod_opt

Minor testsuite fixes for 71947 tests

2016-10-21 Thread Jeff Law
This fixes minor issues in the recently added tests for 71947. First in two tests we use an x86 opcode. We don't actually assemble the tests, so it really doesn't matter, but just to make it clear the test is not x86 specific, the opcode was changed to "xyzzy" :-) One test is dependent on b

Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

2016-10-21 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> Also, as this effectively requires the latest unreleased GDB under the Jakub> default options for something that has been working previously, I wonder Jakub> if it e.g. for some time shouldn't be guarded with dwarf_version >= 5 Here's what that looks

[PATCH] Extend -Wint-in-bool-context to warn for multiplications

2016-10-21 Thread Bernd Edlinger
Hi! This patch extends -Wint-in-bool-context to warn for multiplications if used in boolean context. This is rarely useful, and where used, could be easily replaced with && for instance. I think that multiplications in boolean context should be warned about, regardless of the used data type. Thi

Ping Re: [PATCH] go-lang.c: remove a redundant cast

2016-10-21 Thread David Malcolm
On Fri, 2016-10-07 at 15:12 -0400, David Malcolm wrote: > Amongst many other changes, r146451 added this cast: > > -#define GET_MODE_CLASS(MODE) mode_class[MODE] > +#define GET_MODE_CLASS(MODE) ((enum mode_class) mode_class[MODE]) > > making a cast in go-lang.c redundant; remove it. > > Succ

libgo patch committed: Copy lfstack code from Go 1.7 runtime

2016-10-21 Thread Ian Lance Taylor
This patch to libgo copies the lfstack code from the Go 1.7 runtime to libgo. The older gccgo-specific copy of lfstack had some modifications that work on Solaris; those are implemented in a superior form in the new version. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Bootstrapped

[PATCH] print_rtx: implement support for reuse IDs

2016-10-21 Thread David Malcolm
On Thu, 2016-10-20 at 11:22 +0200, Bernd Schmidt wrote: > > Recognizing by SCRATCH wouldn't catch everything, I believe. You > > should > > be able to check n_dups and dup_loc in recog_data to identify cases > > where you need to ensure something is restored with pointer > > equality. Thanks. I a

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-21 Thread Martin Sebor
The latest patch works as expected for me, both with an operand and with stdin. But since I'm not empowered to approve it one of the others reviewers will need to give it their blessing. Thanks Martin On 10/21/2016 07:56 AM, Kyrill Tkachov wrote: Ping. https://gcc.gnu.org/ml/gcc-patches/2016-1

C++ PATCH to debug_tree of TEMPLATE_PARM_INDEX

2016-10-21 Thread Jason Merrill
It was bugging me that the default debug_tree of a TEMPLATE_PARM_INDEX didn't give the name of the template parameter, so I'm adding the corresponding _DECL to the dump. commit 56ee7ba41e0a1b6568f157a5a82230cb8f57 Author: Jason Merrill Date: Fri Oct 21 15:29:04 2016 -0400 * ptre

C++ PATCH for c++/77656 (bogus warning with non-type template parameters)

2016-10-21 Thread Jason Merrill
We were warning that shifting a uint64_t right by 32 bits exceeded the width of the type because we didn't do any conversion when substituting the 32-bit _X of Test2 for _Val in Test. This patch fixes this by doing conversions for value-dependent (but not type-dependent) arguments in convert_templ

Re: Use version namespace in normal mode

2016-10-21 Thread Jonathan Wakely
Some quick comments before I go offline ... On 21/10/16 21:21 +0200, François Dumont wrote: Hi I configured libstdc++ to use gnu-version-namespace and there are a number of failures, see below. But none of them related to this patch so is it ok to commit ? The results: FAIL: libstdc++

[PATCH] DWARF5 .debug_info headers, .debug_types -> .debug_info DW_UT_type

2016-10-21 Thread Jakub Jelinek
Hi! This patch changes the .debug_info headers to follow the current specification (I still hope the useless padding1/padding2 fields will be removed), and also changes the -gsplit-dwarf stuff to move dwo_id into the header and use DW_UT_{skeleton,split_*}. Bootstrapped/regtested on x86_64-linux

Re: [PATCH] Simplify conditions in EVRP, handle taken edge

2016-10-21 Thread Andrew Pinski
On Wed, Oct 19, 2016 at 11:10 PM, kugan wrote: > Hi, > > > On 20/10/16 02:54, Andrew Pinski wrote: >> >> On Wed, Oct 19, 2016 at 1:01 AM, Christophe Lyon >> wrote: >>> >>> On 18 October 2016 at 09:34, Richard Biener wrote: On Mon, 17 Oct 2016, Richard Biener wrote: > > Thi

Re: Use version namespace in normal mode

2016-10-21 Thread François Dumont
Hi I configured libstdc++ to use gnu-version-namespace and there are a number of failures, see below. But none of them related to this patch so is it ok to commit ? The results: FAIL: libstdc++-abi/abi_check 3709 symbols reported as added. I don't know what to think about it. I see

Re: [PATCH][v6] GIMPLE store merging pass

2016-10-21 Thread Richard Biener
On October 21, 2016 3:29:15 PM GMT+02:00, Kyrill Tkachov wrote: >Hi Richard, > >On 21/10/16 13:37, Richard Biener wrote: >> On Tue, 18 Oct 2016, Kyrill Tkachov wrote: >> >>> Hi Richard, >>> >>> This patch is a merge of [1] and [2] and implements the manual >merging of >>> bitfields >>> as outline

[COMMITED] PR78055 Many new gfortran test failures

2016-10-21 Thread Jerry DeLisle
Committed as obvious. M libgfortran/ChangeLog M libgfortran/io/io.h r241422 = 268e62788f36198cb64a3ce953daacbd3b0107ee (refs/remotes/svn/trunk) 2016-10-21 Jerry DeLisle PR libfortran/78055 * io/io.h (st_parameter_dt): Restore GFC_IO_INT to maintai

Re: [ada, testsuite] Parallelize check-gnat

2016-10-21 Thread Mike Stump
On Oct 21, 2016, at 7:01 AM, Rainer Orth wrote: > > I happened to notice that the gnat.dg testsuite run is slow > 2.6 GHz AMD Opteron 8435, -j24 43m 24s => 33m 4s > 2.93 GHz Intel Xeon X7350, -j16 30m 7s => 9m 8s > 2.67 GHz Intel Xeon X7542, -j48 14m 56s => 5m 50s > > Se

Re: RFC [1/3] divmod transform v2

2016-10-21 Thread Jeff Law
On 10/20/2016 03:32 AM, Richard Biener wrote: Starting with some high level design comments. If these conflict with comments from others, let me know and we'll work through the issues. I don't really like introducing code conditional on the target capabilities this early in the gimple optimizat

Re: [ada, testsuite] Parallelize check-gnat

2016-10-21 Thread Mike Stump
On Oct 21, 2016, at 9:54 AM, Eric Botcazou wrote: > >> I'm not strongly against your patch, I'm just very surprised it is really >> needed (acats is much larger, check-gnat is small). > > In what unit do you count? ACATS has fewer tests than gnat.dg nowadays. The only unit that matters, wall s

Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

2016-10-21 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> I admit I haven't looked at the GDB changes, but how will the debugger know Jakub> if it is an emutls emulation or normal ELF TLS, if the same op is used Jakub> in both cases? Because gdb never implemented DW_OP_form_tls_address, that emultls case h

Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

2016-10-21 Thread Jakub Jelinek
On Fri, Oct 21, 2016 at 11:17:33AM -0600, Tom Tromey wrote: > This patch changes gcc to emit DW_OP_form_tls_address rather than > DW_OP_GNU_push_tls_address. This is PR debug/77315. > > DW_OP_form_tls_address was added in DWARF 3, and this patch uses the > DWARF version to decide which opcode to

[PATCH] PR debug/77315 - use DW_OP_form_tls_address

2016-10-21 Thread Tom Tromey
This patch changes gcc to emit DW_OP_form_tls_address rather than DW_OP_GNU_push_tls_address. This is PR debug/77315. DW_OP_form_tls_address was added in DWARF 3, and this patch uses the DWARF version to decide which opcode to emit. Note that gdb did not implement the DWARF 3 opcode until recent

[PATCH] Start adding target-specific selftests

2016-10-21 Thread David Malcolm
On Fri, 2016-10-21 at 12:04 +0200, Bernd Schmidt wrote: > On 10/21/2016 02:36 AM, David Malcolm wrote: > > + /* Test dumping of hard regs. This is inherently target > > -specific due > > + to the name. */ > > +#ifdef I386_OPTS_H > > + ASSERT_RTL_DUMP_EQ ("(reg:SI ax)", gen_raw_REG (SImode,

[PATCH] Three patches for std::experimental::filesystem

2016-10-21 Thread Jonathan Wakely
This implements some DR resolutions for the filesystem lib. Tested x86_64-linux, committed to trunk. commit 03db1baaa50ea8d97b4442fffaae4e68a03eebad Author: Jonathan Wakely Date: Thu Oct 20 19:26:47 2016 +0100 LWG2720 implement filesystem::perms::symlink_nofollow * include/exp

Re: [ada, testsuite] Parallelize check-gnat

2016-10-21 Thread Eric Botcazou
> I'm not strongly against your patch, I'm just very surprised it is really > needed (acats is much larger, check-gnat is small). In what unit do you count? ACATS has fewer tests than gnat.dg nowadays. -- Eric Botcazou

Re: [Patch AArch64] Add floatdihf2 and floatunsdihf2 patterns

2016-10-21 Thread Kyrill Tkachov
On 06/09/16 10:19, James Greenhalgh wrote: Hi, This patch adds patterns for conversion from 64-bit integer to 16-bit floating-point values under AArch64 targets which don't have support for the ARMv8.2-A 16-bit floating point extensions. We implement these by first saturating to a SImode (we k

RE: [PATCHv2][GCC] Optimise the fpclassify builtin to perform integer operations when possible

2016-10-21 Thread Tamar Christina
Hi Richard, Jeff, Fair enough, I understand the reservations both of you have. I'll spend some time experimenting with what kind of code I'd Get out of it from lowering early and come up with an updated Patch. Thanks! Tamar > -Original Message- > From: Richard Biener [mailto:rguent...@s

Re: Ping^5 Re: [Patch AArch64] Add floatdihf2 and floatunsdihf2 patterns

2016-10-21 Thread James Greenhalgh
On Wed, Oct 12, 2016 at 04:56:52PM +0100, James Greenhalgh wrote: > On Wed, Sep 28, 2016 at 05:17:14PM +0100, James Greenhalgh wrote: > > On Wed, Sep 21, 2016 at 10:42:03AM +0100, James Greenhalgh wrote: > > > On Tue, Sep 13, 2016 at 10:31:28AM +0100, James Greenhalgh wrote: > > > > On Tue, Sep 06,

Re: [PATCH 2/5] [AARCH64] Change IMP and PART over to integers from strings.

2016-10-21 Thread James Greenhalgh
On Fri, Oct 21, 2016 at 04:57:22PM +0100, Richard Earnshaw (lists) wrote: > On 21/10/16 14:59, James Greenhalgh wrote: > > On Sat, Oct 15, 2016 at 07:38:40PM -0700, Andrew Pinski wrote: > >> On Wed, Nov 25, 2015 at 11:59 AM, Andrew Pinski wrote: > >> Here is finally an updated (fixed) patch (I did

Re: [PATCH 2/5] [AARCH64] Change IMP and PART over to integers from strings.

2016-10-21 Thread Richard Earnshaw (lists)
On 21/10/16 14:59, James Greenhalgh wrote: > On Sat, Oct 15, 2016 at 07:38:40PM -0700, Andrew Pinski wrote: >> On Wed, Nov 25, 2015 at 11:59 AM, Andrew Pinski wrote: >> Here is finally an updated (fixed) patch (I did not implement the two >> implementer big.LITTLE support yet, that will be for a d

Re: [patch, libstdc++] Optimize selection sampling by using generator to get two values at once

2016-10-21 Thread Jonathan Wakely
On 19/10/16 12:48 +0200, Eelis van der Weegen wrote: This is the same optimization as was recently applied to std::shuffle. It reduces the runtime of the following program by 20% on my machine: int main() { std::vector a(1), b(1000); std::mt19

Re: [PATCH] Formatting fixes for some x86 intrin headers

2016-10-21 Thread Uros Bizjak
On Fri, Oct 21, 2016 at 5:28 PM, Jakub Jelinek wrote: > Hi! > > While looking at the bextr/bextri/bzhi/pdep/pext intrinsics, > I've noticed some ugly formatted code in the headers, this patch fixes > what I found. Because the headers are installed, IMHO it is more important > to keep them properl

Re: [PATCH] Also fold bmi/bmi2/tbm bextr/bextri/bzhi/pext/pdep builtins

2016-10-21 Thread Uros Bizjak
On Fri, Oct 21, 2016 at 5:26 PM, Jakub Jelinek wrote: > Hi! > > This patch on top of the just posted patch adds folding for a couple more > builtins (though, hundreds or thousands of other md builtins remain unfolded > even though they actually could be folded for e.g. const arguments). > > Bootst

Re: [PATCH] Fold __builtin_ia32_[tl]zcnt_u{16,32,64} (PR target/78057)

2016-10-21 Thread Uros Bizjak
On Fri, Oct 21, 2016 at 5:31 PM, Jakub Jelinek wrote: > On Fri, Oct 21, 2016 at 05:28:42PM +0200, Uros Bizjak wrote: >> On Fri, Oct 21, 2016 at 5:23 PM, Jakub Jelinek wrote: >> > Hi! >> > >> > This patch adds folding for the new ia32 md builtins. >> > If they can be folded into constant, it is do

Re: RFC: Split into smaller pieces

2016-10-21 Thread Jonathan Wakely
On 13/10/16 18:34 +0100, Jonathan Wakely wrote: This splits the large (2200 lines) header into smaller pieces, so there are separate headers for: - std::less, std::equal_to etc. (already in their own header) - std::__invoke (already in its own header) - std::reference_wrapper (often used on its

[PATCH] Also fold bmi/bmi2/tbm bextr/bextri/bzhi/pext/pdep builtins

2016-10-21 Thread Jakub Jelinek
Hi! This patch on top of the just posted patch adds folding for a couple more builtins (though, hundreds or thousands of other md builtins remain unfolded even though they actually could be folded for e.g. const arguments). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 201

Re: [PATCH] Fold __builtin_ia32_[tl]zcnt_u{16,32,64} (PR target/78057)

2016-10-21 Thread Jakub Jelinek
On Fri, Oct 21, 2016 at 05:28:42PM +0200, Uros Bizjak wrote: > On Fri, Oct 21, 2016 at 5:23 PM, Jakub Jelinek wrote: > > Hi! > > > > This patch adds folding for the new ia32 md builtins. > > If they can be folded into constant, it is done in ix86_fold_builtin, > > if they can fold to corresponding

Re: [PATCH] Fold __builtin_ia32_[tl]zcnt_u{16,32,64} (PR target/78057)

2016-10-21 Thread Uros Bizjak
On Fri, Oct 21, 2016 at 5:23 PM, Jakub Jelinek wrote: > Hi! > > This patch adds folding for the new ia32 md builtins. > If they can be folded into constant, it is done in ix86_fold_builtin, > if they can fold to corresponding generic __builtin_c[lt]z* (which have > e.g. the advantage that VRP know

[PATCH] Formatting fixes for some x86 intrin headers

2016-10-21 Thread Jakub Jelinek
Hi! While looking at the bextr/bextri/bzhi/pdep/pext intrinsics, I've noticed some ugly formatted code in the headers, this patch fixes what I found. Because the headers are installed, IMHO it is more important to keep them properly formatted. Bootstrapped/regtested on x86_64-linux and i686-linu

[PATCH] Fold __builtin_ia32_[tl]zcnt_u{16,32,64} (PR target/78057)

2016-10-21 Thread Jakub Jelinek
Hi! This patch adds folding for the new ia32 md builtins. If they can be folded into constant, it is done in ix86_fold_builtin, if they can fold to corresponding generic __builtin_c[lt]z* (which have e.g. the advantage that VRP knows about what values it can have etc.), it is done in gimple_fold_b

Re: [C++ PATCH] RFC: implement P0386R2 - C++17 inline variables

2016-10-21 Thread Jakub Jelinek
On Fri, Oct 21, 2016 at 03:57:34PM +0100, Yao Qi wrote: > Hi Jakub, > > On Thu, Oct 20, 2016 at 5:21 PM, Andre Vieira (lists) > wrote: > > <2><8f5>: Abbrev Number: 38 (DW_TAG_member) > > <8f6> DW_AT_specification: <0x8be> > > <8fa> DW_AT_linkage_name: (indirect string, offset: 0x4a0)

Re: [PATCH] Emit DW_AT_const_expr for constexpr variables (take 2)

2016-10-21 Thread Jason Merrill
On Fri, Oct 21, 2016 at 10:40 AM, Jakub Jelinek wrote: > On Fri, Oct 21, 2016 at 09:58:01AM -0400, Jason Merrill wrote: >> On Thu, Oct 20, 2016 at 2:27 PM, Jakub Jelinek wrote: >> > + if ((dwarf_version >= 4 || !dwarf_strict) >> >> Why >=4? Isn't this a DWARF 5 feature? > > It is actually DWARF

Re: [C++ PATCH] RFC: implement P0386R2 - C++17 inline variables

2016-10-21 Thread Yao Qi
Hi Jakub, On Thu, Oct 20, 2016 at 5:21 PM, Andre Vieira (lists) wrote: > <2><8f5>: Abbrev Number: 38 (DW_TAG_member) > <8f6> DW_AT_specification: <0x8be> > <8fa> DW_AT_linkage_name: (indirect string, offset: 0x4a0): > _ZN6BANANA1sE > <8fe> DW_AT_location: 5 byte block: 3 64

Re: [ada, testsuite] Parallelize check-gnat

2016-10-21 Thread Jakub Jelinek
On Fri, Oct 21, 2016 at 04:01:48PM +0200, Rainer Orth wrote: > I happened to notice that the gnat.dg testsuite run is slow even on a > reasonably fast SPARC machine (3.6 GHz SPARC T5) and together with the > libgomp testsuite (PR libgomp/66005) dominates bootstrap time: within a > make -j96 -k chec

Re: [testsuite, i386] Work around 32-bit i386 STV testcases failing with -mstackrealign (PR target/77483)

2016-10-21 Thread Uros Bizjak
On Fri, Oct 21, 2016 at 4:17 PM, Rainer Orth wrote: > The following patch works around quite a number of i386 testcases > FAILing on Solaris/x86, as reported in the PR. To avoid tons of > testsuite noise, the following patch adds -mno-stackrealign to the > affected testcases and will thus benefit

Re: [PATCH] Emit DW_AT_const_expr for constexpr variables (take 2)

2016-10-21 Thread Jakub Jelinek
On Fri, Oct 21, 2016 at 09:58:01AM -0400, Jason Merrill wrote: > On Thu, Oct 20, 2016 at 2:27 PM, Jakub Jelinek wrote: > > + if ((dwarf_version >= 4 || !dwarf_strict) > > Why >=4? Isn't this a DWARF 5 feature? It is actually DWARF 4 already. Looking at DWARF4 DW_AT_* additions, we also don't

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope (v2)

2016-10-21 Thread Jakub Jelinek
On Wed, Oct 12, 2016 at 04:07:53PM +0200, Martin Liška wrote: > > Ok, first let me list some needed follow-ups that don't need to be handled > > right away: > > - r237814-like changes for ASAN_MARK > > Yes, that's missing. I'm wondering whether the same approach would be viable > as > the {un}poi

[testsuite, i386] Work around 32-bit i386 STV testcases failing with -mstackrealign (PR target/77483)

2016-10-21 Thread Rainer Orth
The following patch works around quite a number of i386 testcases FAILing on Solaris/x86, as reported in the PR. To avoid tons of testsuite noise, the following patch adds -mno-stackrealign to the affected testcases and will thus benefit other targets that default to -mstackrealign, too. Bootstra

Re: [ada, testsuite] Parallelize check-gnat

2016-10-21 Thread Arnaud Charlet
> Ok for mainline (and eventually for 5 and 6 branches given the small > size and low risk of the patch)? I'm not familiar with lang_checks_parallelized, but that's OK with me on principle. Arno

Re: [PATCH] Emit DW_AT_const_expr for constexpr variables (take 2)

2016-10-21 Thread Jason Merrill
On Thu, Oct 20, 2016 at 2:27 PM, Jakub Jelinek wrote: > + if ((dwarf_version >= 4 || !dwarf_strict) Why >=4? Isn't this a DWARF 5 feature? OK with that change. Jason

[PATCH] S/390: Add support for arch arch/tune options.

2016-10-21 Thread Andreas Krebbel
This patch adds an alternate CPU level naming following the architecture level number in the Principles of Operations manual. So instead of having z196, zEC12, and z13 you can use arch9, arch10, and arch11. The old cpu names stay valid and should preferably be used. The alternate names are suppo

[ada, testsuite] Parallelize check-gnat

2016-10-21 Thread Rainer Orth
I happened to notice that the gnat.dg testsuite run is slow even on a reasonably fast SPARC machine (3.6 GHz SPARC T5) and together with the libgomp testsuite (PR libgomp/66005) dominates bootstrap time: within a make -j96 -k check, it takes 1h 18m 37s. For unknown reasons, check-gnat isn't parall

Re: [PATCH 2/5] [AARCH64] Change IMP and PART over to integers from strings.

2016-10-21 Thread James Greenhalgh
On Sat, Oct 15, 2016 at 07:38:40PM -0700, Andrew Pinski wrote: > On Wed, Nov 25, 2015 at 11:59 AM, Andrew Pinski wrote: > Here is finally an updated (fixed) patch (I did not implement the two > implementer big.LITTLE support yet, that will be for a different patch > since I also fixed the part no

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

2016-10-21 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00982.html Thanks, Kyrill On 13/10/16 09:11, Kyrill Tkachov wrote: On 12/10/16 17:49, Martin Sebor wrote: On 10/12/2016 06:43 AM, Kyrill Tkachov wrote: On 12/10/16 11:18, Kyrill Tkachov wrote: On 12/10/16 10:57, Kyrill Tkachov wrote: O

Re: [PATCH] Do not disable aggressive loop opts for, -fsanitize=unreachable or leak

2016-10-21 Thread Jakub Jelinek
On Wed, Oct 19, 2016 at 01:39:16PM +0200, Martin Liška wrote: > >From 7f1648ef3480c6db856e567153cf9bb838c77d4f Mon Sep 17 00:00:00 2001 > From: marxin > Date: Mon, 17 Oct 2016 15:58:50 +0200 > Subject: [PATCH] Do not disable aggressive loop opts for > -fsanitize=unreachable or leak > > gcc/Chang

Re: [PATCH][v6] GIMPLE store merging pass

2016-10-21 Thread Kyrill Tkachov
Hi Richard, On 21/10/16 13:37, Richard Biener wrote: On Tue, 18 Oct 2016, Kyrill Tkachov wrote: Hi Richard, This patch is a merge of [1] and [2] and implements the manual merging of bitfields as outlined in [1] but actually makes it work on BYTES_BIG_ENDIAN too. It caused me a lot of headeach

Re: [PATCHv2] do not throw in std::make_exception_ptr

2016-10-21 Thread Jonathan Wakely
On 21/10/16 13:57 +0100, Jonathan Wakely wrote: On 21/10/16 15:33 +0300, Gleb Natapov wrote: On Fri, Oct 21, 2016 at 02:58:26PM +0300, Gleb Natapov wrote: On Fri, Oct 21, 2016 at 12:44:39PM +0100, Jonathan Wakely wrote: On 21/10/16 14:36 +0300, Gleb Natapov wrote: > On Thu, Oct 20, 2016 at 11:

Re: [PATCH][AArch64] Improve stack adjustment

2016-10-21 Thread James Greenhalgh
On Tue, Oct 18, 2016 at 07:10:07PM +0100, Wilco Dijkstra wrote: > James Greenhalgh wrote: > On Mon, Oct 17, 2016 at 12:38:36PM +, Wilco Dijkstra wrote: > > >> +  /* We need two add/sub instructions, each one perform part of the > >> + addition/subtraction, but don't this if the addend can

Re: [PATCHv2] do not throw in std::make_exception_ptr

2016-10-21 Thread Jonathan Wakely
On 21/10/16 15:33 +0300, Gleb Natapov wrote: On Fri, Oct 21, 2016 at 02:58:26PM +0300, Gleb Natapov wrote: On Fri, Oct 21, 2016 at 12:44:39PM +0100, Jonathan Wakely wrote: > On 21/10/16 14:36 +0300, Gleb Natapov wrote: > > On Thu, Oct 20, 2016 at 11:53:49PM -0400, Ryan Burn wrote: > > > Are exce

Re: [Patch, fortran] PR69566 - Failure of SELECT TYPE with unlimited polymorphic function result

2016-10-21 Thread Paul Richard Thomas
Hi Andre, Committed to trunk as revision 241403. Thanks for the review. Paul On 20 October 2016 at 11:43, Andre Vehreschild wrote: > Hi Paul, > > after looking at your patch again, I understood why these extra copies are > needed. May be a comment would prevent future gfortran hackers from try

Re: [PATCH][v6] GIMPLE store merging pass

2016-10-21 Thread Richard Biener
On Tue, 18 Oct 2016, Kyrill Tkachov wrote: > Hi Richard, > > This patch is a merge of [1] and [2] and implements the manual merging of > bitfields > as outlined in [1] but actually makes it work on BYTES_BIG_ENDIAN too. > It caused me a lot of headeache because the bit offset is counted from the

Re: [PATCHv2] do not throw in std::make_exception_ptr

2016-10-21 Thread Gleb Natapov
On Fri, Oct 21, 2016 at 02:58:26PM +0300, Gleb Natapov wrote: > On Fri, Oct 21, 2016 at 12:44:39PM +0100, Jonathan Wakely wrote: > > On 21/10/16 14:36 +0300, Gleb Natapov wrote: > > > On Thu, Oct 20, 2016 at 11:53:49PM -0400, Ryan Burn wrote: > > > > Are exception classes required to support emplac

Re: [Patch, rtl] PR middle-end/78016, keep REG_NOTE order during insn copy

2016-10-21 Thread Bernd Schmidt
On 10/21/2016 02:04 PM, Jiong Wang wrote: + /* Locate the end of existing REG_NOTES in NEW_RTX. */ + rtx *ptail = ®_NOTES (new_rtx); + while (*ptail != NULL_RTX) +ptail = &XEXP (*ptail, 1); I was thinking along the lines of something like this (untested, emit-rtl.c part omitted). Eri

[PATCH] Use SCEV in EVRP, fix single predecessor discovery

2016-10-21 Thread Richard Biener
This makes us derive ranges for loop IVs in EVRP using adjust_range_with_scevs. It also allows us to derive ranges from conditions in loop preheaders (I think that's still broken because we force simple preheaders and predecessor search doesn't follow forwarders -- sth for a followup). Bootstra

Re: [Patch, rtl] PR middle-end/78016, keep REG_NOTE order during insn copy

2016-10-21 Thread Jiong Wang
On 21/10/16 11:13, Bernd Schmidt wrote: On 10/21/2016 09:43 AM, Eric Botcazou wrote: I disagree: there are currently n ways of copying NOTEs in the RTL middle-end, with different properties each time. We need only one primitive in rtlanal.c. I feel the fact that they have different propertie

Re: [PATCHv2] do not throw in std::make_exception_ptr

2016-10-21 Thread Gleb Natapov
On Fri, Oct 21, 2016 at 12:44:39PM +0100, Jonathan Wakely wrote: > On 21/10/16 14:36 +0300, Gleb Natapov wrote: > > On Thu, Oct 20, 2016 at 11:53:49PM -0400, Ryan Burn wrote: > > > Are exception classes required to support emplace new construction > > > like that? With this change, Intel's TBB libr

Re: [PATCH] Change ranges_table and ranges_by_label arrays into vec<*, va_gc> *

2016-10-21 Thread Bernd Schmidt
On 10/20/2016 08:30 PM, Jakub Jelinek wrote: This patch changes these two manually maintained arrays into normal vec.h vectors. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Looks good. For safety, could you make a before/after comparison on one large sourcefile to make

Re: [PATCHv2] do not throw in std::make_exception_ptr

2016-10-21 Thread Jonathan Wakely
On 21/10/16 12:44 +0100, Jonathan Wakely wrote: On 21/10/16 14:36 +0300, Gleb Natapov wrote: On Thu, Oct 20, 2016 at 11:53:49PM -0400, Ryan Burn wrote: Are exception classes required to support emplace new construction like that? With this change, Intel's TBB library no longer compiles because

Re: [PATCHv2] do not throw in std::make_exception_ptr

2016-10-21 Thread Jonathan Wakely
On 21/10/16 14:36 +0300, Gleb Natapov wrote: On Thu, Oct 20, 2016 at 11:53:49PM -0400, Ryan Burn wrote: Are exception classes required to support emplace new construction like that? With this change, Intel's TBB library no longer compiles because its exception class declares it's own new operato

Re: [PATCHv2] do not throw in std::make_exception_ptr

2016-10-21 Thread Gleb Natapov
On Thu, Oct 20, 2016 at 11:53:49PM -0400, Ryan Burn wrote: > Are exception classes required to support emplace new construction > like that? With this change, Intel's TBB library no longer compiles > because its exception class declares it's own new operator (see > https://github.com/wjakob/tbb/blo

MAINTAINERS: Update Hartmut Penner's email address

2016-10-21 Thread Ulrich Weigand
Hello, as requested by Hartmut, I've updated the MAINTAINERS file to show his new email address since the old one no longer works. Bye, Ulrich Index: MAINTAINERS === --- MAINTAINERS (revision 241398) +++ MAINTAINERS (working copy) @

[PATCH][2/2] Early LTO debug -- main part

2016-10-21 Thread Richard Biener
This is the main part of the early LTO debug support. The main parts of the changes are to dwarf2out.c where most of the changes are related to the fact that we eventually have to output debug info twice, once for the early LTO part and once for the fat part of the object file. Bootstrapped and

Re: libgo patch committed: Rewrite interface code into Go

2016-10-21 Thread Rainer Orth
Hi Ian, > This patch to libgo rewrites the interface code from C to Go. > > I started to copy the Go 1.7 interface code, but the gc and gccgo > representations of interfaces are too different. So instead I rewrote > the gccgo interface code from C to Go. The code is largely the same > as it was,

Re: [libstdc++, testsuite] Add dg-require-thread-fence

2016-10-21 Thread Kyrill Tkachov
Hi all, On 21/10/16 09:00, Christophe Lyon wrote: [ccying Ramana] Ramana is currently OoO all of this week. Kyrill On 20 October 2016 at 18:34, Jonathan Wakely wrote: On 20/10/16 09:26 -0700, Mike Stump wrote: On Oct 20, 2016, at 5:20 AM, Jonathan Wakely wrote: I am considering leavin

[PATCH][1/2] Early LTO debug -- simple-object piece

2016-10-21 Thread Richard Biener
Apart from fixing a memleak this is unchanged from the last posting which means it still has no support for Mach-O or [X]COFF. Boostrapped / tested on x86_64-unknown-linux-gnu. Richard. 2016-10-21 Richard Biener include/ * simple-object.h (simple_object_copy_lto_debug_sectio

Re: [Patch, reload, tentative, PR 71627] Tweak conditions in find_valid_class_1

2016-10-21 Thread Bernd Schmidt
On 10/21/2016 12:46 PM, Senthil Kumar Selvaraj wrote: How does this look? Looks good, thanks. Bernd

Re: [PATCH] PR77985: DWARF: Emit DW_AT_comp_dir in all cases, even if source is an absolute path

2016-10-21 Thread Ximin Luo
Richard Biener: > On Tue, Oct 18, 2016 at 2:35 PM, Ximin Luo wrote: >> >> Thanks, I'll add the Changelog entry. My computer isn't very powerful, so I >> didn't bootstrap it yet, I only tested it on a stage1 compiler, on Debian >> testing/unstable. I'll find some time to bootstrap it and test it

Re: [Patch, reload, tentative, PR 71627] Tweak conditions in find_valid_class_1

2016-10-21 Thread Senthil Kumar Selvaraj
Bernd Schmidt writes: > On 10/18/2016 02:15 PM, Senthil Kumar Selvaraj wrote: >> Will do both the changes and re-run the reg tests. Ok for trunk if the >> tests pass for x86_64-pc-linux and avr? >> > Probably but let's see the patch first. How does this look? Bootstrapped and reg tested x86_64-

Re: RFC [1/3] divmod transform v2

2016-10-21 Thread Prathamesh Kulkarni
On 20 October 2016 at 15:02, Richard Biener wrote: > On Wed, 19 Oct 2016, Jeff Law wrote: > >> On 10/15/2016 11:59 PM, Prathamesh Kulkarni wrote: >> > Hi, >> > After approval from Bernd Schmidt, I committed the patch to remove >> > optab functions for >> > sdivmod_optab and udivmod_optab in optabs

[Patch, fortran] PR69834 - Collision in derived type hashes

2016-10-21 Thread Paul Richard Thomas
Dear All, I had the attached patch more or less working at the end of January. However, there was a regression with submodule_6.f03, which I had quite a struggle with and only resolved yesterday. Until now, select type used the hash value to do the type selection with the inevitable consequence t

PR libgcc/78064: Add missing include directive to unwind-c.c

2016-10-21 Thread Florian Weimer
See https://gcc.gnu.org/ml/gcc/2016-10/msg00165.html for the background. This causes pthread_cond_wait in glibc to write out of bounds on i386. Fix was suggested by Jim Wilson. Tested on x86_64-redhat-linux-gnu, with no new regressions. Also tested against the i386 glibc reproducer, and

Re: [Patch, rtl] PR middle-end/78016, keep REG_NOTE order during insn copy

2016-10-21 Thread Bernd Schmidt
On 10/21/2016 09:43 AM, Eric Botcazou wrote: I disagree: there are currently n ways of copying NOTEs in the RTL middle-end, with different properties each time. We need only one primitive in rtlanal.c. I feel the fact that they have different properties means we shouldn't try to unify them: w

Re: [PATCH] Start adding selftests for print_rtx

2016-10-21 Thread Bernd Schmidt
On 10/21/2016 02:36 AM, David Malcolm wrote: + /* Test dumping of hard regs. This is inherently target-specific due + to the name. */ +#ifdef I386_OPTS_H + ASSERT_RTL_DUMP_EQ ("(reg:SI ax)", gen_raw_REG (SImode, 0)); +#endif Generally putting in target dependencies like this isn't somet

  1   2   >