Re: [PATCH] Change default optimization level to -Og

2017-10-26 Thread Andrew Pinski
On Thu, Oct 26, 2017 at 10:12 AM, Wilco Dijkstra wrote: > GCC's default optimization level is -O0. Unfortunately unlike other > compilers, > GCC generates extremely inefficient code with -O0. It is almost unusable for > low-level debugging or manual inspection of

Re: Merge from trunk to gccgo branch

2017-10-26 Thread Ian Lance Taylor
On Tue, Oct 24, 2017 at 3:10 PM, Ian Lance Taylor wrote: > I merged trunk revision 254059 to the gccgo branch. I've now merged trunk revision 254126. Ian

Re: [Patch] Edit contrib/ files to download gfortran prerequisites

2017-10-26 Thread Jerry DeLisle
On 10/21/2017 11:17 AM, Bernhard Reutner-Fischer wrote: > On 21 October 2017 at 02:26, Damian Rouson > wrote: >> >> Hi Richard, >> >> Attached is a revised patch that makes the downloading of Fortran >> prerequisites optional via a new --no-fortran flag that can be

Re: [PATCH, version 5a], Add support for _Float and _FloatX sqrt, fma, fmin, fmax built-in functions

2017-10-26 Thread Segher Boessenkool
On Wed, Oct 25, 2017 at 07:57:09PM -0400, Michael Meissner wrote: > On Wed, Oct 25, 2017 at 11:41:24PM +, Joseph Myers wrote: > > My only comment on this version is that the documentation in cpp.texi of > > __FP_FAST_* should be updated to mention __FP_FAST_FMAF@var{n} and > >

Re: [PATCH, rs6000] add testcase coverage for vec_neg built-ins.

2017-10-26 Thread Segher Boessenkool
Hi, On Wed, Oct 25, 2017 at 10:26:46AM -0500, Will Schmidt wrote: > 2017-10-25 Will Schmidt > > * gcc.target/powerpc/fold-vec-neg-char.c: New. > * gcc.target/powerpc/fold-vec-neg-floatdouble.c: New. > * gcc.target/powerpc/fold-vec-neg-int.c: New.

[PATCH] Protect more algorithms from overloaded comma operators

2017-10-26 Thread Jonathan Wakely
LWG 2133 makes it a requirement for some of the algorithms to protect against overlaoded comma operators. This does so, and adapts some tests to verify it, using our iterator wrappers. Those wrappers have a member oeprator, but that only handles the case where the iterator is the left operand, so

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Martin Sebor
On 10/26/2017 11:52 AM, Richard Sandiford wrote: Martin Sebor writes: /* The tree and const_tree overload templates. */ namespace wi { + class unextended_tree + { + private: +const_tree m_t; + + public: +unextended_tree () {} Defining no-op ctors is quite

Re: [PATCH, rs6000] (v2) Gimple folding for vec_madd()

2017-10-26 Thread Segher Boessenkool
Hi Will, On Thu, Oct 26, 2017 at 05:13:38PM -0500, Will Schmidt wrote: > * config/rs6000/rs6000.c: (rs6000_gimple_fold_builtin) Add support for > gimple folding of vec_madd() intrinsics. The colon goes after the closing parenthesis, and continuation lines should not have extra

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Martin Sebor
On 10/26/2017 01:17 PM, Pedro Alves wrote: On 10/26/2017 07:54 PM, Martin Sebor wrote: (...) in the general case, it is preferable to declare each variable at the point where its initial value is known (or can be computed) and initialize it on its declaration. With that I fully agree, except

Go patch committed: Explicitly convert between type aliases

2017-10-26 Thread Ian Lance Taylor
This patch adds an explicit conversion between type aliases. Otherwise we can get a crash in the backend when GCC sees a fold_convert_loc between two record types that the GCC backend appear to be different. Adding the explicit conversion will insert a VIEW_CONVERT_EXPR where needed. The test

Re: [PATCH, rs6000] (v2) Gimple folding for vec_madd()

2017-10-26 Thread Will Schmidt
Hi, [PATCH, rs6000] (v2) Gimple folding for vec_madd() Add support for gimple folding of the vec_madd() (vector multiply-add) intrinsics. Per earlier feedback and education, this now includes the addition of a "define_expand fmav8hi4" in altivec.md. Testcase coverage is provided by

Re: [PATCH 06/13] remove sdb and -gcoff from non-target files

2017-10-26 Thread Jim Wilson
On Thu, 2017-10-26 at 11:38 +0200, Richard Biener wrote: > You can eventually keep the option, marking it as Ignore (like we do > for options we remove but "keep" for backward compatibility).  The > diagnostic (as warning, given the option will be just ignored) could > be emited from option

Re: [PATCH, rs6000 V3] Add Power 8 support to vec_revb

2017-10-26 Thread Segher Boessenkool
Hi Carl, On Mon, Oct 23, 2017 at 08:36:03AM -0700, Carl Love wrote: > The mode attribute wd will not work > for the define expand as the V16QI maps to "b" not "q". So I do need to > have VSX_XXBR. Why is that a problem? Why do you want to swap the order of the whole vector instead of changing

[PATCH] Fix x86-64 zero_extended_scalar_load_operand caused wrong-code (PR target/82703)

2017-10-26 Thread Jakub Jelinek
Hi! The following testcase is miscompiled, because due to STV we end up with a load from V2DFmode MEM for which get_pool_entry returns a V1TImode vector. maybe_get_pool_constant doesn't have code to handle mode differences between what get_pool_constant returns and the requested mode. While it

Re: [PATCH] expand -fdebug-prefix-map documentation

2017-10-26 Thread Jim Wilson
On Thu, 2017-10-26 at 12:35 -0600, Sandra Loosemore wrote: > On 10/26/2017 11:47 AM, Gerald Pfeifer wrote: > > Thanks you for fleshing this out, Jim! > > > > This looks fine to me (modula Sandra's note).  Just a question: > > would > > we refer to GDB instead of gdb here?  It feels a little in

[patch, nios2] add -mr0rel-sec= option

2017-10-26 Thread Sandra Loosemore
I've committed this patch, intended for bare-metal nios2-elf targets with custom linker scripts. In conjunction with section attributes, it provides a way to tell GCC that an object is assigned to the low or high 32K memory regions so that it can be addressed via a signed 16-bit offset from

[patch, nios2] add -mgprel-sec= option

2017-10-26 Thread Sandra Loosemore
I've committed this patch, which allows users to specify additional data sections (beyond the normal small-data sections) where GP-relative addressing can be used. It's intended for use on bare-metal nios2-elf targets in conjunction with section attributes and a custom linker script. -Sandra

Fix basic block reordering glitches

2017-10-26 Thread Eric Botcazou
old transitions found (bb 64) +===GNAT BUG DETECTED==+ | 8.0.0 20171026 (experimental) [trunk revision 254096] (x86_64-suse-linux) GCC error:| | verify_flow_info failed | It's the RTL basic block reorder

Re: Fix pretty printers for versioned namespace

2017-10-26 Thread Jonathan Wakely
On 26/10/17 21:37 +0100, Jonathan Wakely wrote: On 26/10/17 21:30 +0100, Jonathan Wakely wrote: On 26/10/17 22:19 +0200, François Dumont wrote: @@ -1232,7 +1232,7 @@ class Printer(object): # Add a name using _GLIBCXX_BEGIN_NAMESPACE_CONTAINER. def add_container(self, base, name, function):

Re: Fix pretty printers for versioned namespace

2017-10-26 Thread Jonathan Wakely
On 26/10/17 21:30 +0100, Jonathan Wakely wrote: On 26/10/17 22:19 +0200, François Dumont wrote: @@ -1232,7 +1232,7 @@ class Printer(object): # Add a name using _GLIBCXX_BEGIN_NAMESPACE_CONTAINER. def add_container(self, base, name, function): self.add_version(base, name, function)

Re: Fix pretty printers for versioned namespace

2017-10-26 Thread Jonathan Wakely
On 26/10/17 22:19 +0200, François Dumont wrote: @@ -1232,7 +1232,7 @@ class Printer(object): # Add a name using _GLIBCXX_BEGIN_NAMESPACE_CONTAINER. def add_container(self, base, name, function): self.add_version(base, name, function) -self.add_version(base +

Re: Rename cxx1998 into normal

2017-10-26 Thread Jonathan Wakely
On 26/10/17 21:45 +0200, François Dumont wrote: On 26/10/2017 19:09, Jonathan Wakely wrote: On 26/10/17 18:55 +0200, Daniel Krügler wrote: 2017-10-26 7:51 GMT+02:00 François Dumont : Hi     We once talk about rename the __cxx1998 namespace into something less C++98

Fix pretty printers for versioned namespace

2017-10-26 Thread François Dumont
Hi     When restoring versioned namespace feature I forgot to check for the pretty printer tests which are now broken.     Here is the patch to fix those. Tested under Linux x86_64 normal and versioned namepace modes, ok to commit ? François diff --git

Re: [PATCH v2] Add asan and ubsan support on NetBSD/amd64

2017-10-26 Thread Kamil Rytarowski
On 26.10.2017 21:43, Kamil Rytarowski wrote: > Tested on: > > $ uname -rms > NetBSD 8.99.4 amd64 > I forgot to amend everything in this patch, will fix in -v3. signature.asc Description: OpenPGP digital signature

[PATCH v3] Add asan and ubsan support on NetBSD/amd64

2017-10-26 Thread Kamil Rytarowski
Tested on: $ uname -rms NetBSD 8.99.4 amd64 The NetBSD support has been developed directly in the compiler-rt upstream source. Testing against the LLVM+Clang+compiler-rt (2017-10-25 snapshot from HEAD): $ make check-asan Failing Tests (2): AddressSanitizer-Unit ::

[PATCH v2] Add asan and ubsan support on NetBSD/amd64

2017-10-26 Thread Kamil Rytarowski
Tested on: $ uname -rms NetBSD 8.99.4 amd64 The NetBSD support has been developed directly in the compiler-rt upstream source. Testing against the LLVM+Clang+compiler-rt (2017-10-25 snapshot from HEAD): $ make check-asan Failing Tests (2): AddressSanitizer-Unit ::

Re: [PATCH] Change default optimization level to -Og

2017-10-26 Thread Jakub Jelinek
On Thu, Oct 26, 2017 at 05:12:40PM +, Wilco Dijkstra wrote: > GCC's default optimization level is -O0. Unfortunately unlike other > compilers, > GCC generates extremely inefficient code with -O0. It is almost unusable for > low-level debugging or manual inspection of generated code. So a

Re: [PATCH] Change default optimization level to -Og

2017-10-26 Thread Eric Botcazou
> GCC's default optimization level is -O0. Unfortunately unlike other > compilers, GCC generates extremely inefficient code with -O0. Agreed (but this can probably be worked on). > It is almost unusable for low-level debugging or manual inspection of > generated code. Likewise. > So a -O

Re: Rename cxx1998 into normal

2017-10-26 Thread François Dumont
On 26/10/2017 19:09, Jonathan Wakely wrote: On 26/10/17 18:55 +0200, Daniel Krügler wrote: 2017-10-26 7:51 GMT+02:00 François Dumont : Hi     We once talk about rename the __cxx1998 namespace into something less C++98 biased. Here is the patch to do so.     Ok with

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-26 Thread Jakub Jelinek
On Thu, Oct 26, 2017 at 02:43:55PM +0200, Richard Biener wrote: > On Thu, Oct 26, 2017 at 2:18 PM, Richard Sandiford > wrote: > > Richard Biener writes: > >> On Mon, Oct 23, 2017 at 1:22 PM, Richard Sandiford > >>

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-26 Thread Richard Sandiford
Richard Biener writes: > On Thu, Oct 26, 2017 at 2:18 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Mon, Oct 23, 2017 at 1:22 PM, Richard Sandiford >>> wrote:

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-26 Thread Eric Botcazou
> Can you figure what oldest GCC release supports the C++11/14 POD handling > that would be required? GCC needs to be buildable by other compilers than itself though. -- Eric Botcazou

Re: [PATCH] Include missing source file for sanitizers on NetBSD

2017-10-26 Thread Jakub Jelinek
On Thu, Oct 26, 2017 at 09:24:58PM +0200, Kamil Rytarowski wrote: > On 26.10.2017 21:19, Jakub Jelinek wrote: > > On Thu, Oct 26, 2017 at 09:02:25PM +0200, Kamil Rytarowski wrote: > >> 2017-10-26 Kamil Rytarowski > >> > >>* sanitizer_common/Makefile.am

Re: [PATCH] Include missing source file for sanitizers on NetBSD

2017-10-26 Thread Kamil Rytarowski
On 26.10.2017 21:19, Jakub Jelinek wrote: > On Thu, Oct 26, 2017 at 09:02:25PM +0200, Kamil Rytarowski wrote: >> 2017-10-26 Kamil Rytarowski >> >> * sanitizer_common/Makefile.am (sanitizer_common_files): Add >> sanitizer_platform_limits_netbsd.cc. >> *

Re: [Patch, fortran] PR81758 - [7/8 Regression] [OOP] Broken vtab

2017-10-26 Thread Andre Vehreschild
Hi Paul, Without having tested the patch, it looks reasonable to me. So ok from my side. - Andre Am 26. Oktober 2017 21:12:45 MESZ schrieb Paul Richard Thomas : >Dear All, > >Thanks to Dimitry Liakh for both reporting the problem and doing a lot >of the

Re: [PATCH] Include missing source file for sanitizers on NetBSD

2017-10-26 Thread Jakub Jelinek
On Thu, Oct 26, 2017 at 09:02:25PM +0200, Kamil Rytarowski wrote: > 2017-10-26 Kamil Rytarowski > > * sanitizer_common/Makefile.am (sanitizer_common_files): Add > sanitizer_platform_limits_netbsd.cc. > * sanitizer_common/Makefile.in: Regenerated. Why is this

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Pedro Alves
On 10/26/2017 07:54 PM, Martin Sebor wrote: > (...) in the general case, it is preferable to > declare each variable at the point where its initial value is known > (or can be computed) and initialize it on its declaration. With that I fully agree, except it's not always possible or natural.

[PATCH] Include missing source file for sanitizers on NetBSD

2017-10-26 Thread Kamil Rytarowski
2017-10-26 Kamil Rytarowski * sanitizer_common/Makefile.am (sanitizer_common_files): Add sanitizer_platform_limits_netbsd.cc. * sanitizer_common/Makefile.in: Regenerated. --- libsanitizer/ChangeLog| 6 ++

[Patch, fortran] PR81758 - [7/8 Regression] [OOP] Broken vtab

2017-10-26 Thread Paul Richard Thomas
Dear All, Thanks to Dimitry Liakh for both reporting the problem and doing a lot of the diagnostic work. Once the offending line in a very complicated code was located, the fix was trivial. Generating a reduced testcase took rather longer :-) The comment in the testcase tells the story. The fix

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Martin Sebor
On 10/26/2017 12:05 PM, Pedro Alves wrote: On 10/26/2017 05:37 PM, Martin Sebor wrote: I agree that the latter use case is more common in GCC, but I don't see it as a good thing. GCC was written in C and most code still uses now outdated C practices such as declaring variables at the top of a

Re: [PATCH] expand -fdebug-prefix-map documentation

2017-10-26 Thread Sandra Loosemore
On 10/26/2017 11:47 AM, Gerald Pfeifer wrote: On Wed, 25 Oct 2017, Jim Wilson wrote: The current documentation doesn't explain what the option is for, or how one might use it. The attached patch expands the documentation a bit to try to explain this. OK? Thanks you for fleshing this out,

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread Nathan Sidwell
On 10/26/2017 02:12 PM, Eric Gallager wrote: On 10/26/17, Nathan Sidwell wrote: On 10/26/2017 10:34 AM, David Malcolm wrote: Possibly a silly question, but is it OK to have a formatted string call in which some of the arguments aren't consumed? (here "col" is only consumed

Re: [patch][i386, AVX] Adding missing CMP* intrinsics

2017-10-26 Thread Kirill Yukhin
Hello Olga, Sebastian, On 20 Oct 08:36, Peryt, Sebastian wrote: > Hi, > > This patch written by Olga Makhotina adds listed below missing intrinsics: > _mm512_[mask_]cmpeq_[pd|ps]_mask > _mm512_[mask_]cmple_[pd|ps]_mask > _mm512_[mask_]cmplt_[pd|ps]_mask > _mm512_[mask_]cmpneq_[pd|ps]_mask >

Re: [PATCH] Change default optimization level to -Og

2017-10-26 Thread Eric Gallager
On 10/26/17, Wilco Dijkstra wrote: > GCC's default optimization level is -O0. Unfortunately unlike other > compilers, > GCC generates extremely inefficient code with -O0. It is almost unusable > for > low-level debugging or manual inspection of generated code. So a -O

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread Eric Gallager
On 10/26/17, Nathan Sidwell wrote: > On 10/26/2017 10:34 AM, David Malcolm wrote: >> [CCing Rainer and Mike for the gcc-dg.exp part] > >> Alternate idea: could show_column become a tri-state: >>* default: show non-zero columns >>* never: never show columns >>* always:

Re: [RFA][PATCH] Provide a class interface into substitute_and_fold.

2017-10-26 Thread Richard Biener
On October 26, 2017 6:50:15 PM GMT+02:00, Jeff Law wrote: >On 10/26/2017 03:24 AM, Richard Biener wrote: >> On Tue, Oct 24, 2017 at 8:44 PM, Jeff Law wrote: >>> This is similar to the introduction of the ssa_propagate_engine, but >for >>> the

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Pedro Alves
On 10/26/2017 05:37 PM, Martin Sebor wrote: > I agree that the latter use case is more common in GCC, but I don't > see it as a good thing. GCC was written in C and most code still > uses now outdated C practices such as declaring variables at the top > of a (often long) function, and usually

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Richard Sandiford
Martin Sebor writes: >> /* The tree and const_tree overload templates. */ >> namespace wi >> { >> + class unextended_tree >> + { >> + private: >> +const_tree m_t; >> + >> + public: >> +unextended_tree () {} > >

Re: [PATCH] expand -fdebug-prefix-map documentation

2017-10-26 Thread Gerald Pfeifer
On Wed, 25 Oct 2017, Jim Wilson wrote: > The current documentation doesn't explain what the option is for, or > how one might use it.  The attached patch expands the documentation a > bit to try to explain this. > OK? Thanks you for fleshing this out, Jim! This looks fine to me (modula Sandra's

Re: [PATCH], Enable IBM/IEEE long double format to overriden more easily

2017-10-26 Thread Michael Meissner
On Wed, Oct 25, 2017 at 07:11:07PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Sat, Oct 21, 2017 at 09:09:58AM -0400, Michael Meissner wrote: > > As Segher and I were discussing off-line, I have some problems with the > > current > > -mabi={ieee,ibm}longdouble switches as we start to

PING Re: [patch] configure option to override TARGET_LIBC_PROVIDES_SSP

2017-10-26 Thread Sandra Loosemore
This one. https://gcc.gnu.org/ml/gcc-patches/2017-10/msg00537.html There was discussion about documenting this, but the actual configure change hasn't been reviewed yet. -Sandra

[PATCH] Change default optimization level to -Og

2017-10-26 Thread Wilco Dijkstra
GCC's default optimization level is -O0. Unfortunately unlike other compilers, GCC generates extremely inefficient code with -O0. It is almost unusable for low-level debugging or manual inspection of generated code. So a -O option is always required for compilation. -Og not only allows for

Re: Rename cxx1998 into normal

2017-10-26 Thread Jonathan Wakely
On 26/10/17 18:55 +0200, Daniel Krügler wrote: 2017-10-26 7:51 GMT+02:00 François Dumont : Hi We once talk about rename the __cxx1998 namespace into something less C++98 biased. Here is the patch to do so. Ok with the new name ? IMO the name should somehow

Re: [PATCH] expand -fdebug-prefix-map documentation

2017-10-26 Thread Sandra Loosemore
On 10/25/2017 06:26 PM, Jim Wilson wrote: Index: gcc/doc/invoke.texi === --- gcc/doc/invoke.texi (revision 254023) +++ gcc/doc/invoke.texi (working copy) @@ -6981,7 +6981,12 @@ link processing time. Merging is enabled by defau

Re: Rename cxx1998 into normal

2017-10-26 Thread Daniel Krügler
2017-10-26 7:51 GMT+02:00 François Dumont : > Hi > > We once talk about rename the __cxx1998 namespace into something less > C++98 biased. Here is the patch to do so. > > Ok with the new name ? IMO the name should somehow still contain "cxx" somewhere, otherwise this

Re: [RFA][PATCH] Provide a class interface into substitute_and_fold.

2017-10-26 Thread Jeff Law
On 10/26/2017 03:24 AM, Richard Biener wrote: > On Tue, Oct 24, 2017 at 8:44 PM, Jeff Law wrote: >> This is similar to the introduction of the ssa_propagate_engine, but for >> the substitution/replacements bits. >> >> In a couple places the pass specific virtual functions are

[PATCH] RISC-V: Correct and improve the "-mabi" documentation

2017-10-26 Thread Palmer Dabbelt
The documentation for the "-mabi" argument on RISC-V was incorrect. We chose to treat this as a documentation bug rather than a code bug, and to make the documentation match what GCC currently does. In the process, I also improved the documentation a bit. Thanks to Alex Bradbury for finding the

Re: [006/nnn] poly_int: tree constants

2017-10-26 Thread Martin Sebor
/* The tree and const_tree overload templates. */ namespace wi { + class unextended_tree + { + private: +const_tree m_t; + + public: +unextended_tree () {} Defining no-op ctors is quite dangerous and error-prone. I suggest to instead default initialize the member(s):

Re: [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457).

2017-10-26 Thread Sandra Loosemore
On 10/26/2017 01:21 AM, Martin Liška wrote: On 10/20/2017 06:03 AM, Sandra Loosemore wrote: On 10/19/2017 12:26 PM, Eric Gallager wrote: On 10/19/17, Martin Liška wrote: Hi. As discussed in the PR, we should be more precise in our documentation. The patch does that. Ready

Re: [v3 PATCH] Deduction guides for associative containers, debug mode deduction guide fixes.

2017-10-26 Thread Jonathan Wakely
On 26/10/17 19:23 +0300, Ville Voutilainen wrote: On 26 October 2017 at 18:04, Jonathan Wakely wrote: Also, please put the deduction guides for a class immediately after the definition of that class, rather than grouping all the guides for unordered_map and

Re: [v3 PATCH] Deduction guides for associative containers, debug mode deduction guide fixes.

2017-10-26 Thread Ville Voutilainen
On 26 October 2017 at 18:04, Jonathan Wakely wrote: > Also, please put the deduction guides for a class immediately after > the definition of that class, rather than grouping all the guides for > unordered_map and unordered_multimap together. Alright. 2017-10-26 Ville

Re: [PATCH][AArch64] Introduce emit_frame_chain

2017-10-26 Thread James Greenhalgh
On Fri, Aug 04, 2017 at 01:26:15PM +0100, Wilco Dijkstra wrote: > The current frame code combines the separate concepts of a frame chain > (saving old FP,LR in a record and pointing new FP to it) and a frame > pointer used to access locals. Add emit_frame_chain to the aarch64_frame > descriptor

Re: [RFA][PATCH] Convert sprintf warning code to use a dominator walk

2017-10-26 Thread Jeff Law
On 10/26/2017 03:09 AM, Richard Biener wrote: > On Wed, Oct 25, 2017 at 5:44 PM, Jeff Law wrote: >> On 10/24/2017 11:35 AM, Martin Sebor wrote: >>> On 10/23/2017 05:14 PM, Jeff Law wrote: Martin, I'd like your thoughts on this patch. One of the

Re: [PATCH, rs6000] 2/2 Add x86 SSE2 <emmintrin,h> intrinsics to GCC PPC64LE target

2017-10-26 Thread Steven Munroe
On Wed, 2017-10-25 at 18:37 -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Oct 17, 2017 at 01:27:16PM -0500, Steven Munroe wrote: > > This it part 2/2 for contributing PPC64LE support for X86 SSE2 > > instrisics. This patch includes testsuite/gcc.target tests for the > > intrinsics included

Re: [PATCH][AArch64] Improve aarch64_legitimate_constant_p

2017-10-26 Thread James Greenhalgh
On Fri, Jul 07, 2017 at 12:28:11PM +0100, Wilco Dijkstra wrote: > This patch further improves aarch64_legitimate_constant_p. Allow all > integer, floating point and vector constants. Allow label references > and non-anchor symbols with an immediate offset. This allows such > constants to be

[PATCH] Fix PR81659

2017-10-26 Thread Richard Biener
The following fixes lower_eh_dispatch destroying dominator info that was still live from previous passes. This clears it from the obvious place (when we think we might have created unreachable blocks). Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2017-10-26 Richard

Re: [PATCH, rs6000] Gimple folding for vec_madd()

2017-10-26 Thread Will Schmidt
On Thu, 2017-10-26 at 17:18 +0200, Richard Biener wrote: > On Thu, Oct 26, 2017 at 5:13 PM, Richard Biener > wrote: > > On Thu, Oct 26, 2017 at 4:30 PM, Will Schmidt > > wrote: > >> On Thu, 2017-10-26 at 11:05 +0200, Richard Biener wrote: >

Re: [PATCH] Improve alloca alignment

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 4:55 PM, Jeff Law wrote: > On 10/17/2017 06:04 AM, Wilco Dijkstra wrote: >> Wilco Dijkstra wrote: >>> >>> Yes STACK_BOUNDARY applies to virtual_stack_dynamic_rtx and all other >>> virtual frame registers. It appears it's main purpose is to enable alignment

Re: [PATCH][AArch64] Simplify frame layout for stack probing

2017-10-26 Thread James Greenhalgh
On Tue, Jul 25, 2017 at 02:58:04PM +0100, Wilco Dijkstra wrote: > This patch makes some changes to the frame layout in order to simplify > stack probing. We want to use the save of LR as a probe in any non-leaf > function. With shrinkwrapping we may only save LR before a call, so it > is useful

Re: [PATCH, rs6000] Gimple folding for vec_madd()

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 5:13 PM, Richard Biener wrote: > On Thu, Oct 26, 2017 at 4:30 PM, Will Schmidt > wrote: >> On Thu, 2017-10-26 at 11:05 +0200, Richard Biener wrote: >>> On Wed, Oct 25, 2017 at 4:38 PM, Will Schmidt

Re: [PATCH, rs6000] Gimple folding for vec_madd()

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 4:30 PM, Will Schmidt wrote: > On Thu, 2017-10-26 at 11:05 +0200, Richard Biener wrote: >> On Wed, Oct 25, 2017 at 4:38 PM, Will Schmidt >> wrote: >> > Hi, >> > >> > Add support for gimple folding of the vec_madd()

Re: [PATCH][AArch64] Improve addressing of TI/TFmode

2017-10-26 Thread James Greenhalgh
On Thu, Jul 20, 2017 at 01:49:03PM +0100, Wilco Dijkstra wrote: > In https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01125.html Jiong > pointed out some addressing inefficiencies due to a recent change in > regcprop (https://gcc.gnu.org/ml/gcc-patches/2017-04/msg00775.html). > > This patch improves

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 4:38 PM, Richard Biener wrote: > On Thu, Oct 26, 2017 at 2:55 PM, Jan Hubicka wrote: >>> I think the limit should be on the number of generated copies and not >>> the overall size of the structure... If the struct were composed

Re: [v3 PATCH] Deduction guides for associative containers, debug mode deduction guide fixes.

2017-10-26 Thread Jonathan Wakely
On 26/10/17 15:36 +0100, Jonathan Wakely wrote: On 17/10/17 22:48 +0300, Ville Voutilainen wrote: Tested on Linux-PPC64. The debug mode fixes have been tested manually and individually on Linux-x64. 2017-10-17 Ville Voutilainen Deduction guides for

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-26 Thread Jeff Law
On 10/18/2017 10:59 AM, Egeyar Bagcioglu wrote: > Hello, > > Test case "guality.exp=nrv-1.c" fails on aarch64. Optimizations reorder > the instructions and cause the value of a variable to be checked before > its first assignment. The following patch is moving the > break point to the end of the

Re: [PATCH] Improve alloca alignment

2017-10-26 Thread Jeff Law
On 10/17/2017 06:04 AM, Wilco Dijkstra wrote: > Wilco Dijkstra wrote: >> >> Yes STACK_BOUNDARY applies to virtual_stack_dynamic_rtx and all other >> virtual frame registers. It appears it's main purpose is to enable alignment >> optimizations since PREFERRED_STACK_BOUNDARY is used to align >>

Re: [PATCH] Improve alloca alignment

2017-10-26 Thread Jeff Law
On 10/05/2017 03:16 AM, Richard Biener wrote: > On Thu, Oct 5, 2017 at 1:07 AM, Jeff Law wrote: >> On 10/04/2017 08:53 AM, Eric Botcazou wrote: This seems like a SPARC target problem to me -- essentially it's claiming a higher STACK_BOUNDARY than it really has. >>> >>>

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread Nathan Sidwell
On 10/26/2017 10:34 AM, David Malcolm wrote: [CCing Rainer and Mike for the gcc-dg.exp part] Alternate idea: could show_column become a tri-state: * default: show non-zero columns * never: never show columns * always: always show a column, printing 0 for the no-column case and then

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:55 PM, Jan Hubicka wrote: >> I think the limit should be on the number of generated copies and not >> the overall size of the structure... If the struct were composed of >> 32 individual chars we wouldn't want to emit 32 loads and 32 stores... >> >> I

Re: [v3 PATCH] Deduction guides for associative containers, debug mode deduction guide fixes.

2017-10-26 Thread Jonathan Wakely
On 17/10/17 22:48 +0300, Ville Voutilainen wrote: Tested on Linux-PPC64. The debug mode fixes have been tested manually and individually on Linux-x64. 2017-10-17 Ville Voutilainen Deduction guides for associative containers, debug mode deduction guide fixes.

Re: [Diagnostic Patch] don't print column zero

2017-10-26 Thread David Malcolm
[CCing Rainer and Mike for the gcc-dg.exp part] On Thu, 2017-10-26 at 07:33 -0400, Nathan Sidwell wrote: > On the modules branch, I'm starting to add location > information. Line > numbers don't really make sense when reporting errors reading a > binary > file, so I wanted to change the

Re: [PATCH, rs6000] Gimple folding for vec_madd()

2017-10-26 Thread Will Schmidt
On Thu, 2017-10-26 at 11:05 +0200, Richard Biener wrote: > On Wed, Oct 25, 2017 at 4:38 PM, Will Schmidt > wrote: > > Hi, > > > > Add support for gimple folding of the vec_madd() (vector multiply-add) > > intrinsics. > > Testcase coverage is provided by the existing

[Patch obvious][arm testsuite] Fixup expected location in require-pic-register-loc.c

2017-10-26 Thread James Greenhalgh
Hi, After r254010 we now add -gcolumn-info by default, that means the tests in gcc.target/arm/require-pic-register-loc.c need adjusting to not expect to see column zero. That's the obvious fix, and just extends what Jakub did in r254010 so I've applied it as r254106. Thanks, James ---

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Michael Matz
Hi, On Thu, 26 Oct 2017, Martin Jambor wrote: > > 35 bytes seems to be much - what is the code-size impact? > > I will find out and report on that. I need at least 32 bytes (four > long ints) to fix imagemagick, where the problematic structure is: Surely the final heuristic should look at the

Re: [PATCH 00/13] Removal of SDB debug info support

2017-10-26 Thread Jeff Law
On 10/26/2017 03:33 AM, Richard Biener wrote: > On Wed, Oct 25, 2017 at 11:24 PM, Jim Wilson wrote: >> We have no targets that emit SDB debug info by default. We dropped all >> of the SVR3 Unix and embedded COFF targets a while ago. The only >> targets that are still able

Re: [PING][PATCH][Aarch64] Improve int<->FP conversions

2017-10-26 Thread James Greenhalgh
On Tue, Oct 24, 2017 at 10:47:32PM +0100, Michael Collison wrote: > James, > > The patch was test as required. However when I tested with the latest trunk > there were two test failures that need to be updated because of my patch. > > The files gcc.target/aarch64/vect-vcvt.c was failing

Re: [PATCH PR79868 ][aarch64] Fix error calls in aarch64 code so they can be translated (version 2)

2017-10-26 Thread Richard Earnshaw (lists)
On 26/09/17 00:25, Steve Ellcey wrote: > This is a new version of my patch to fix PR target/79868, where some > error messages are impossible to translate correctly due to how the > strings are dynamically constructed.  It also includes some format > changes in the error messags to make the

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Jan Hubicka
> I think the limit should be on the number of generated copies and not > the overall size of the structure... If the struct were composed of > 32 individual chars we wouldn't want to emit 32 loads and 32 stores... > > I wonder how rep; movb; interacts with store to load forwarding? Is > that

Re: [C++ PATCH] Kill IDENTIFIER_LABEL_VALUE

2017-10-26 Thread Nathan Sidwell
On 10/25/2017 05:36 PM, Nathan Sidwell wrote: This patch removes 'label_value' from lang_identifier, shrinking it from 72 to 64 bytes (on 64-bit machine).   We replace this by augmenting the already used per-function named_labels hash table.  This is a major win, because labels are extremely

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:18 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Oct 23, 2017 at 1:22 PM, Richard Sandiford >> wrote: >>> This patch adds a POD version of fixed_size_mode. The

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:18 PM, Martin Jambor wrote: > Hi, > > On Tue, Oct 17, 2017 at 01:34:54PM +0200, Richard Biener wrote: >> On Fri, Oct 13, 2017 at 6:13 PM, Martin Jambor wrote: >> > Hi, >> > >> > I'd like to request comments to the patch below which aims

Re: [18/nn] Use (CONST_VECTOR|GET_MODE)_NUNITS in simplify-rtx.c

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:28 PM, Richard Sandiford wrote: > This patch avoids some calculations of the form: > > GET_MODE_SIZE (vector_mode) / GET_MODE_SIZE (element_mode) > > in simplify-rtx.c. If we're dealing with CONST_VECTORs, it's better > to use

Re: [14/nn] Add helpers for shift count modes

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:06 PM, Richard Biener wrote: > On Mon, Oct 23, 2017 at 1:25 PM, Richard Sandiford > wrote: >> This patch adds a stub helper routine to provide the mode >> of a scalar shift amount, given the mode of the values >>

Re: [06/nn] Add VEC_SERIES_{CST,EXPR} and associated optab

2017-10-26 Thread Richard Biener
On Thu, Oct 26, 2017 at 2:23 PM, Richard Biener wrote: > On Mon, Oct 23, 2017 at 1:20 PM, Richard Sandiford > wrote: >> Similarly to the VEC_DUPLICATE_{CST,EXPR}, this patch adds two >> tree code equivalents of the VEC_SERIES rtx code.

Re: [06/nn] Add VEC_SERIES_{CST,EXPR} and associated optab

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:20 PM, Richard Sandiford wrote: > Similarly to the VEC_DUPLICATE_{CST,EXPR}, this patch adds two > tree code equivalents of the VEC_SERIES rtx code. VEC_SERIES_EXPR > is for non-constant inputs and is a normal tcc_binary. VEC_SERIES_CST >

Re: [PATCH] Fix test-suite fallout of default -Wreturn-type.

2017-10-26 Thread Martin Liška
On 10/24/2017 04:39 PM, Jason Merrill wrote: > On 10/18/2017 08:48 AM, Martin Liška wrote: >> This is second patch that addresses test-suite fallout. All these tests fail >> because -Wreturn-type is >> now on by default. > >> +++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-diag3.C >> -constexpr T g(T

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-26 Thread Richard Sandiford
Richard Biener writes: > On Mon, Oct 23, 2017 at 1:22 PM, Richard Sandiford > wrote: >> This patch adds a POD version of fixed_size_mode. The only current use >> is for storing the __builtin_apply and __builtin_result register modes, >>

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-26 Thread Martin Jambor
Hi, On Tue, Oct 17, 2017 at 01:34:54PM +0200, Richard Biener wrote: > On Fri, Oct 13, 2017 at 6:13 PM, Martin Jambor wrote: > > Hi, > > > > I'd like to request comments to the patch below which aims to fix PR > > 80689, which is an instance of a store-to-load forwarding stall on

Re: [22/nn] Make dse.c use offset/width instead of start/end

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:30 PM, Richard Sandiford wrote: > store_info and read_info_type in dse.c represented the ranges as > start/end, but a lot of the internal code used offset/width instead. > Using offset/width throughout fits better with the poly_int.h >

Re: [21/nn] Minor vn_reference_lookup_3 tweak

2017-10-26 Thread Richard Biener
On Mon, Oct 23, 2017 at 1:30 PM, Richard Sandiford wrote: > The repeated checks for MEM_REF made this code hard to convert to > poly_ints as-is. Hopefully the new structure also makes it clearer > at a glance what the two cases are. > > > 2017-10-23 Richard

  1   2   >