C++ PATCH for c++/87150, wrong ctor with maybe-rvalue semantics

2018-09-06 Thread Marek Polacek
Another case where we weren't respecting the [class.copy.elision]/3 rule that "if the type of the first parameter of the selected constructor is not an rvalue reference to the object's type (possibly cv-qualified), overload resolution is performed again, considering the object as an lvalue." In

C++ PATCH for c++/87152, range-based for loops with initializer broken in templates

2018-09-06 Thread Marek Polacek
Turned out our range-based for loops with initializer are completely broken in templates, because I neglected to add the init-statement to RANGE_FOR_STMT. range-for18.C should verify we put it into the right scope. tsubst_expr then needs to recurse on it to avoid the ICE. Bootstrapped/regtested

Re: [PATCH v2] combine: perform jump threading at the end

2018-09-06 Thread Segher Boessenkool
On Thu, Sep 06, 2018 at 12:11:09PM -0600, Jeff Law wrote: > On 09/05/2018 06:11 AM, Richard Biener wrote: > > On Wed, Sep 5, 2018 at 2:01 PM Ilya Leoshkevich wrote: > >> + /* Combining insns can change basic blocks in a way that they end up > >> + containing a single jump_insn. This creates

Re: [PATCH] Use complete_array_type on flexible array member initializers

2018-09-06 Thread Jeff Law
On 09/06/2018 04:16 PM, Jeff Law wrote: > On 09/06/2018 04:01 PM, Jeff Law wrote: >> On 09/06/2018 11:12 AM, Bernd Edlinger wrote: >> >>> >>> Ah, thanks a lot. >>> >>> Okay, this is the status of the STRING-CST semantic-v2 patches: >>> >>> [PATCH] Check the STRING_CSTs in varasm.c >>>

Re: [PATCH] Use complete_array_type on flexible array member initializers

2018-09-06 Thread Jeff Law
On 09/06/2018 04:01 PM, Jeff Law wrote: > On 09/06/2018 11:12 AM, Bernd Edlinger wrote: > >>> >> >> Ah, thanks a lot. >> >> Okay, this is the status of the STRING-CST semantic-v2 patches: >> >> [PATCH] Check the STRING_CSTs in varasm.c >> https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01569.html

Re: [PATCH] Use complete_array_type on flexible array member initializers

2018-09-06 Thread Jeff Law
On 09/06/2018 11:12 AM, Bernd Edlinger wrote: >> > > Ah, thanks a lot. > > Okay, this is the status of the STRING-CST semantic-v2 patches: > > [PATCH] Check the STRING_CSTs in varasm.c > https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01569.html > => Unfortunately I forgot to change the Title to

[PATCH] Beautify reg_stack.c/get_true_reg a tiny bit

2018-09-06 Thread Uros Bizjak
2018-09-06 Uros Bizjak * reg-stack.c (get_true_reg) : Reorder to fallthru to FLOAT case. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Committed to mainline SVN. Uros. diff --git a/gcc/reg-stack.c b/gcc/reg-stack.c index 519ea6df75c..0f1b6d52f01 100644 ---

Re: [PATCH] Maybe fix PR87134

2018-09-06 Thread Rainer Orth
Hi Iain, > I can confirm the same, repeatable, fail on i686-darwin10 (and it > reproduces with -save-temps) > (and the vNULL change does not fix it there either) - don’t have access to > the machine now until > later in the month tho. same here on i386-apple-darwin11, and I can easily fire off

Re: Keep std::deque algos specializations in Debug mode

2018-09-06 Thread François Dumont
On 09/04/2018 02:59 PM, Jonathan Wakely wrote:   template     void -    fill(const _Deque_iterator<_Tp, _Tp&, _Tp*>& __first, - const _Deque_iterator<_Tp, _Tp&, _Tp*>& __last, const _Tp& __value) +    fill(const _GLIBCXX_STD_C::_Deque_iterator<_Tp, _Tp&, _Tp*>& __first, + const

Re: [PATCH] Maybe fix PR87134

2018-09-06 Thread Iain Sandoe
> On 6 Sep 2018, at 17:24, Gerald Pfeifer wrote: > > On Wed, 5 Sep 2018, Richard Biener wrote: >> So I'm testing the following then, leaving the placement new untouched >> (no init is fine) and then assign from vNULL. >> >> 2018-09-05 Richard Biener >> >> PR bootstrap/87134 >> *

[PATCH, i386]: Rewrite fix_trunc patterns

2018-09-06 Thread Uros Bizjak
Hello! Similar to recent float_truncate patch, IRA is able to generate output memory location by itself, so there is no need to manually provide one in the pattern. Attached patch rewrites fix_trunc (and similar) patterns to output directly to memory operand. 2018-09-06 Uros Bizjak *

Re: [PATCH v2] combine: perform jump threading at the end

2018-09-06 Thread Jeff Law
On 09/05/2018 06:11 AM, Richard Biener wrote: > On Wed, Sep 5, 2018 at 2:01 PM Ilya Leoshkevich wrote: >> >> gcc/ChangeLog: >> >> 2018-09-05 Ilya Leoshkevich >> >> PR target/80080 >> * combine.c (rest_of_handle_combine): Perform jump threading. >> >> gcc/testsuite/ChangeLog: >>

Re: [PATCH] Use complete_array_type on flexible array member initializers

2018-09-06 Thread Bernd Edlinger
On 09/06/18 17:43, Jeff Law wrote: > On 09/06/2018 05:05 AM, Bernd Edlinger wrote: >> On 09/04/18 16:30, Jeff Law wrote: >>> On 09/03/2018 06:35 AM, Bernd Edlinger wrote: >>> [ Big snip, dropping lots of context ] >>> >> No I don't think so, because at that time BRACE_ENCLOSED_INITIALIZER_P

Re: [PATCH][OBVIOUS] Close file on return from verify-intermediate

2018-09-06 Thread Mike Stump
On Sep 5, 2018, at 6:29 AM, Joey Ye wrote: > This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate > returns without closing the open file. > > This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases > that it invokes verify-intermediate. Not

Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority

2018-09-06 Thread Jeff Law
On 09/03/2018 08:32 AM, John David Anglin wrote: > The documentation for TARGET_SCHED_ADJUST_PRIORITY indicates that the > hook can > reduce the priority of INSN to execute it later.  The hppa hook only > reduces the priority > and it has been this way for years.  However, the assert in >

Re: [wwwdocs] Document 87137 fix

2018-09-06 Thread Gerald Pfeifer
Hi Nathan, On Wed, 5 Sep 2018, Nathan Sidwell wrote: > this documents the fix for pr87137. Discovered as a GCC-8 regression, > turned out to be an ABI bug. Decided to fix the entire bug in one go. > Are these changes.html changes ok? thanks for doing this! I have minor suggestions if you

Re: [PATCH] Maybe fix PR87134

2018-09-06 Thread Gerald Pfeifer
On Wed, 5 Sep 2018, Richard Biener wrote: > So I'm testing the following then, leaving the placement new untouched > (no init is fine) and then assign from vNULL. > > 2018-09-05 Richard Biener > > PR bootstrap/87134 > * tree-ssa-sccvn.c (rpo_elim::eliminate_push_avail): Make sure

Re: [PATCH] Use complete_array_type on flexible array member initializers

2018-09-06 Thread Jeff Law
On 09/06/2018 05:05 AM, Bernd Edlinger wrote: > On 09/04/18 16:30, Jeff Law wrote: >> On 09/03/2018 06:35 AM, Bernd Edlinger wrote: >> [ Big snip, dropping lots of context ] >> > No I don't think so, because at that time BRACE_ENCLOSED_INITIALIZER_P > property does no longer work, as I

Re: [PATCH 19/25] GCN libgfortran.

2018-09-06 Thread Andrew Stubbs
On 05/09/18 19:14, Janne Blomqvist wrote: Please send fortran patches to the fortran list as well! Apologies, I was not aware of this. Ok! Thanks, I will commit when the rest of the port is approved. Andrew

[PATCH] S/390: Use proper rounding mode for DFP to BFD conversions

2018-09-06 Thread Andreas Krebbel
According to IEEE 754 2008 4.3 'Rounding-direction attributes' the rounding mode of the target format needs to be used. By not setting the value so far we have always used the DFP rounding mode. gcc/ChangeLog: 2018-09-06 Andreas Krebbel * config/s390/s390.md (PFPO_RND_MODE_DFP,

Re: [PATCHv2] Handle overlength string literals in the fortan FE

2018-09-06 Thread Bernd Edlinger
On 09/05/18 20:16, Janne Blomqvist wrote: > On Tue, Sep 4, 2018 at 10:05 AM Bernd Edlinger > wrote: > > On 03/09/2018, 21:25 Janne Blomqvist wrote: > > On Fri, Aug 24, 2018 at 11:06 PM Bernd Edlinger > mailto:bernd.edlin...@hotmail.de>> > > wrote:

[PATCH v4 10/10] testsuite: Mark testsuite that PRU has different calling convention

2018-09-06 Thread Dimitar Dimitrov
For variadic functions, the last named and all anonymous arguments are passed on stack. Regular functions pass arguments in registers. gcc/testsuite/ChangeLog: 2018-08-29 Dimitar Dimitrov * gcc.dg/builtin-apply2.c: Skip for PRU. * gcc.dg/torture/stackalign/builtin-apply-2.c:

[PATCH v4 08/10] testsuite: Mark that PRU has one-cycle jumps

2018-09-06 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-08-29 Dimitar Dimitrov * gcc.dg/tree-ssa/20040204-1.c: XFAIL on pru. * gcc.dg/tree-ssa/reassoc-33.c: Ditto. * gcc.dg/tree-ssa/reassoc-34.c: Ditto. * gcc.dg/tree-ssa/reassoc-35.c: Ditto. * gcc.dg/tree-ssa/reassoc-36.c:

[PATCH v4 09/10] testsuite: Mark that PRU uses all function pointer bits

2018-09-06 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-08-29 Dimitar Dimitrov * g++.old-deja/g++.abi/ptrmem.C: Add PRU to list. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/g++.old-deja/g++.abi/ptrmem.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 07/10] testsuite: Define PRU stack usage

2018-09-06 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-08-29 Dimitar Dimitrov * gcc.dg/stack-usage-1.c: Define PRU stack usage. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/gcc.dg/stack-usage-1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/testsuite/gcc.dg/stack-usage-1.c

[PATCH v4 05/10] testsuite: Add check for unsupported TI ABI PRU features to testsuite

2018-09-06 Thread Dimitar Dimitrov
Not all C language features are supported when -mabi=ti option is used for PRU target. gcc/testsuite/ChangeLog: 2018-08-29 Dimitar Dimitrov * lib/gcc-dg.exp: Filter unsupported features in PRU's TI ABI mode. * lib/target-utils.exp: Ditto. * lib/target-supports.exp

[PATCH v4 06/10] testsuite: Remove PRU from test cases requiring hosted environment

2018-09-06 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-08-29 Dimitar Dimitrov * gcc.c-torture/execute/20101011-1.c: Define DO_TEST to 0 for PRU. * gcc.dg/20020312-2.c: No PIC register for PRU. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/gcc.c-torture/execute/20101011-1.c | 3 +++

[PATCH v4 03/10] testsuite: Add PRU tests

2018-09-06 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-08-29 Dimitar Dimitrov * gcc.target/pru/abi-arg-struct.c: New test. * gcc.target/pru/ashiftrt.c: New test. * gcc.target/pru/builtins-1.c: New test. * gcc.target/pru/builtins-error.c: New test. * gcc.target/pru/clearbit.c:

[PATCH v4 02/10] Initial TI PRU libgcc port

2018-09-06 Thread Dimitar Dimitrov
The floating point support has been borrowed from C6X libgcc port to help with TI PRU toolchain ABI compatibility. libgcc/ChangeLog: 2018-08-29 Dimitar Dimitrov * config.host: Add PRU target. * config/pru/asri.c: New file. * config/pru/eqd.c: New file. *

[PATCH v4 00/10] New backend for the TI PRU processor

2018-09-06 Thread Dimitar Dimitrov
This patch series adds support for the TI PRU I/O processor to GCC. This fourth patch set revision addresses comments from v1 [1], v2 [2] and v3 [3]. Test results can be downloaded from here: http://dinux.eu/gnupru/testresults/20180828-f4455d5f/ Changes since patch series v3 [3]: - Added

[PATCH v4 04/10] testsuite: Add check for overflowed IMEM region to testsuite

2018-09-06 Thread Dimitar Dimitrov
PRU architecture supports maximum 256k program memory (IMEM). Some GCC test cases manage to produce executables bigger than that. gcc/testsuite/ChangeLog: 2018-08-29 Dimitar Dimitrov * lib/gcc-dg.exp: Bail on region overflow for tiny targets. * lib/target-utils.exp: Ditto.

Re: [PATCH] Use complete_array_type on flexible array member initializers

2018-09-06 Thread Bernd Edlinger
On 09/04/18 16:30, Jeff Law wrote: > On 09/03/2018 06:35 AM, Bernd Edlinger wrote: > [ Big snip, dropping lots of context ] > > No I don't think so, because at that time BRACE_ENCLOSED_INITIALIZER_P property does no longer work, as I explained in the previous mail.

Re: [PATCH] Backport gettext fixes to get rid of warnings on macOS

2018-09-06 Thread Simon Marchi
On 2018-08-01 03:58 PM, Simon Marchi wrote: > This patch was tested to build binutils-gdb on GNU/Linux and macOS. It can be > applied to the gcc repo too, after fixing some trivial merge conflicts > (someone > else will need to do it, as I don't have push access to gcc). Although I > think >

[S/390] Re: [PATCH 1/2] zEC12 pipeline

2018-09-06 Thread Robin Dapp
Sorry, forgot the [S/390] tag in the subject.

[PATCH 2/2] z13 pipeline

2018-09-06 Thread Robin Dapp
Similar to zEC12, the change in latencies helps match the real machine's behavior better. -- gcc/ChangeLog: 2018-09-06 Robin Dapp * config/s390/2964.md: Increase latencies for some FP instructions. --- gcc/config/s390/2964.md | 80 ++--- 1 file

[PATCH 1/2] zEC12 pipeline

2018-09-06 Thread Robin Dapp
Hi, this patch increases the latency of some floating point instructions to better match the real machine's behavior. Regards Robin -- gcc/ChangeLog: 2018-09-06 Robin Dapp * config/s390/2827.md: Increase latencies for some FP instructions. --- gcc/config/s390/2827.md | 14

Re: [PATCH] S/390: Fix conditional returns

2018-09-06 Thread Andreas Krebbel
Hi Ilya, the S/390 parts look good to me. For the rest we will need approval from a middle-end maintainer. Andreas On 05.09.2018 10:34, Ilya Leoshkevich wrote: > S/390 epilogue ends with (parallel [(return) (use %r14)]) instead of > the more usual (return) or (simple_return). This sequence is

Re: [PATCH] S/390: Prohibit SYMBOL_REF in UNSPECV_CAS

2018-09-06 Thread Andreas Krebbel
On 05.09.2018 22:22, Ilya Leoshkevich wrote: > Inhibit constant propagation inlining SYMBOL_REF loads into > UNSPECV_CAS. Even though reload can later undo it, the resulting > code will be less efficient. > > gcc/ChangeLog: > > 2018-09-05 Ilya Leoshkevich > > PR target/80080 > *

Re: [PATCH 1/2] S/390: Register pass_s390_early_mach statically

2018-09-06 Thread Andreas Krebbel
gcc/ChangeLog: 2018-08-27 Ilya Leoshkevich PR target/80080 * config/s390/s390-passes.def: New file. * config/s390/s390-protos.h (class rtl_opt_pass): Add forward declaration. (make_pass_s390_early_mach): Add declaration. * config/s390/s390.c

Re: [PATCH] S/390: Remove UNSPEC_LTREL_BASE

2018-09-06 Thread Andreas Krebbel
On 14.08.2018 16:21, Ilya Leoshkevich wrote: > It was needed only for g5/g6 machines, which are now gone. gcc/ChangeLog: 2018-08-14 Ilya Leoshkevich * config/s390/s390.c (s390_decompose_constant_pool_ref): Remove UNSPEC_LTREL_BASE check. (annotate_constant_pool_refs):

Re: [patch,nvptx] Basic -misa support for nvptx

2018-09-06 Thread Tom de Vries
On 09/06/2018 12:24 AM, Cesar Philippidis wrote: > This is ok (with, as I mentioned above, the SI part split off into a > separate patch), on the condition that you test libgomp with > -foffload=-misa=sm_35. >>> Adding -foffload=misa=sm_35 didn't work because the host gcc doesn't >>>

Re: [patch,nvptx] Basic -misa support for nvptx

2018-09-06 Thread Tom de Vries
On 09/06/2018 12:24 AM, Cesar Philippidis wrote: > I'll commit the attached patch shortly. x86_64 with nvptx offloading > regression testing didn't yield any new failures, nor did the standalone > nvptx testing. I'll follow up with an SImode patch later. I'm sorry, I guess I was not clear enough