[PATCH] Fix objsz ICE (PR tree-optimization/92056)

2019-10-17 Thread Jakub Jelinek
Hi! The following bug has been introduced when cond_expr_object_size has been added in 2007. We want to treat a COND_EXPR like a PHI with 2 arguments, and PHI is handled in a loop that breaks if the lhs value is unknown, and then does the if (TREE_CODE (arg) == SSA_NAME) merge_object_sizes else e

Order symbols before section copying in the lto streamer

2019-10-17 Thread Jan Hubicka
Hi, this patch orders symbols where we copy sections to match the order of files in the command line. This optimizes streaming process since we are not opening and closing files randomly and also we read them more sequentially. This saves some kernel time though I think more can be done if we avo

Re: [patch] canonicalize unsigned [1,MAX] ranges into ~[0,0]

2019-10-17 Thread Aldy Hernandez
On 10/16/19 3:46 AM, Jakub Jelinek wrote: On Wed, Oct 16, 2019 at 03:38:38AM -0400, Aldy Hernandez wrote: Would you take care of this, or shall I? Will defer to you, I have quite a lot of stuff on my plate ATM. Jakub No problem. Thanks for your analysis though. The attached patch

Re: [PATCH] Fix ifcombine ICE (PR tree-optimization/92115)

2019-10-17 Thread Richard Biener
On Thu, 17 Oct 2019, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs, because ifcombine_ifandif attempts to set > GIMPLE_COND condition to a condition that might trap (which is allowed > only in COND_EXPR/VEC_COND_EXPR). > > Fixed thusly, bootstrapped/regtested on x86_64-linux and i68

Re: [PATCH] Fix objsz ICE (PR tree-optimization/92056)

2019-10-17 Thread Richard Biener
On Thu, 17 Oct 2019, Jakub Jelinek wrote: > Hi! > > The following bug has been introduced when cond_expr_object_size has been > added in 2007. We want to treat a COND_EXPR like a PHI with 2 arguments, > and PHI is handled in a loop that breaks if the lhs value is unknown, and > then does the if

[C++ PATCH] Fix handling of location wrappers in constexpr evaluation (PR c++/92015)

2019-10-17 Thread Jakub Jelinek
Hi! As written in the PR, location wrappers are stripped by cxx_eval_constant_expression as the first thing it does after dealing with jump_target. The problem is that when this function is called on a CONSTRUCTOR, is TREE_CONSTANT and reduced_constant_expression_p (which allows location wrappers

Re: [patch] canonicalize unsigned [1,MAX] ranges into ~[0,0]

2019-10-17 Thread Jakub Jelinek
On Thu, Oct 17, 2019 at 03:15:28AM -0400, Aldy Hernandez wrote: > On 10/16/19 3:46 AM, Jakub Jelinek wrote: > > On Wed, Oct 16, 2019 at 03:38:38AM -0400, Aldy Hernandez wrote: > > > Would you take care of this, or shall I? > > > > Will defer to you, I have quite a lot of stuff on my plate ATM. > >

[PATCH] Fix PR92129

2019-10-17 Thread Richard Biener
Committed as obvious. Richard. 2019-10-17 Richard Biener PR tree-optimization/92129 * tree-vect-loop.c (vectorizable_reduction): Also fail on GIMPLE_SINGLE_RHS. Index: gcc/tree-vect-loop.c === --- gcc/t

Re: [RFC, Darwin, PPC] Fix PR 65342.

2019-10-17 Thread Iain Sandoe
Thanks for the reviews, Segher, Alan, Alan Modra wrote: > On Sat, Oct 12, 2019 at 05:39:51PM -0500, Segher Boessenkool wrote: >> On Sat, Oct 12, 2019 at 10:13:16PM +0100, Iain Sandoe wrote: >>> For 32bit cases this isn't a problem since we can load/store to unaligned >>> addresses using D-mode i

Re: [PATCH, Fortran] Fix Automatics in equivalence test cases was Re: Automatics in Equivalences failures

2019-10-17 Thread Mark Eggleston
On 04/10/2019 11:39, Jakub Jelinek wrote: On Wed, Oct 02, 2019 at 03:31:53PM +0100, Mark Eggleston wrote: It was there because the code base has -fno-automatic for procedures are that aren't recursive and the -frecursive was used because the recursive routines don't have the recursive keyword.

Re: [PATCH] Communicate lto-wrapper and ld through a file

2019-10-17 Thread Richard Biener
On Wed, Oct 16, 2019 at 7:46 PM Giuliano Belinassi wrote: > > Hi, > > Previously, the lto-wrapper communicates with ld by creating a pipe from > lto-wrapper's stdout to ld's stdin. This patch uses a temporary file for > this communication, releasing stdout to be used for debugging. I'm not sure i

Re: [PATCH] i386: Add clear_ratio to processor_costs

2019-10-17 Thread Richard Biener
On Thu, Oct 17, 2019 at 8:47 AM Uros Bizjak wrote: > > On Wed, Oct 16, 2019 at 5:06 PM H.J. Lu wrote: > > > > i386.h has > > > > #define CLEAR_RATIO(speed) ((speed) ? MIN (6, ix86_cost->move_ratio) : 2) > > > > It is impossible to have CLEAR_RATIO > 6. This patch adds clear_ratio > > to process

Re: [PATCH, Fortran] Fix Automatics in equivalence test cases was Re: Automatics in Equivalences failures

2019-10-17 Thread Jakub Jelinek
On Thu, Oct 17, 2019 at 08:43:29AM +0100, Mark Eggleston wrote: > Please find attached patch for additional test cases. Are these sufficient? > If so, OK to commit? > > Change log: > >     Mark Eggleston > >     * gfortran.dg/auto_in_equiv_3.f90: New test. >     * gfortran.dg/auto_in_equiv_4.f9

Re: Add a constant_range_value_p function (PR 92033)

2019-10-17 Thread Christophe Lyon
On Tue, 15 Oct 2019 at 12:36, Richard Sandiford wrote: > > Richard Biener writes: > > On October 14, 2019 2:32:43 PM GMT+02:00, Richard Sandiford > > wrote: > >>Richard Biener writes: > >>> On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford > >>> wrote: > > The range-tracking code ha

Re: Add a constant_range_value_p function (PR 92033)

2019-10-17 Thread Richard Sandiford
Christophe Lyon writes: > On Tue, 15 Oct 2019 at 12:36, Richard Sandiford > wrote: >> >> Richard Biener writes: >> > On October 14, 2019 2:32:43 PM GMT+02:00, Richard Sandiford >> > wrote: >> >>Richard Biener writes: >> >>> On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford >> >>> wrote: >> >

[PATCH] Support multi-versioning on self-recursive function (ipa/92133)

2019-10-17 Thread Feng Xue OS
IPA does not allow constant propagation on parameter that is used to control function recursion. recur_fn (i) { if ( !terminate_recursion (i)) { ... recur_fn (i + 1); ... } ... } This patch is composed to enable multi-versioning for self-recursive function, and ve

[PATCH] Fix an omission in the recent strlen optimization (PR tree-optimization/92056)

2019-10-17 Thread Jakub Jelinek
Hi! objsz computation has two modes. One is a cheap one that doesn't handle SSA_NAMEs and is used in say random builtin folding. The other is where compute_builtin_object_size is called in between init_object_sizes () and fini_object_sizes () calls, where those set up data structures and the cal

RE: [AArch64][SVE2] Support for EOR3 and variants of BSL

2019-10-17 Thread Yuliang Wang
Hi Richard, Thanks for the suggestions, updated. Regards, Yuliang gcc/ChangeLog: 2019-10-17 Yuliang Wang * config/aarch64/aarch64-sve2.md (aarch64_sve2_eor3) (aarch64_sve2_nor, aarch64_sve2_nand) (aarch64_sve2_bsl, aarch64_sve2_nbsl) (aarch64_sve2_bsl1n, aar

Re: [PATCH] Fix an omission in the recent strlen optimization (PR tree-optimization/92056)

2019-10-17 Thread Richard Biener
On Thu, 17 Oct 2019, Jakub Jelinek wrote: > Hi! > > objsz computation has two modes. One is a cheap one that doesn't handle > SSA_NAMEs and is used in say random builtin folding. The other is > where compute_builtin_object_size is called in between init_object_sizes () > and fini_object_sizes (

Re: [RFC, Darwin, PPC] Fix PR 65342.

2019-10-17 Thread Segher Boessenkool
Okay for trunk. For backports maybe wait a bit longer than usual? So ask again in two weeks, maybe? I know it's important for the darwin port, but the generic part is a little scary. On Sat, Oct 12, 2019 at 10:13:16PM +0100, Iain Sandoe wrote: > 2) To resolve this we need to extend the handling

Re: [RFC, Darwin, PPC] Fix PR 65342.

2019-10-17 Thread Segher Boessenkool
On Thu, Oct 17, 2019 at 01:46:41PM +1030, Alan Modra wrote: > On Sat, Oct 12, 2019 at 05:39:51PM -0500, Segher Boessenkool wrote: > > On Sat, Oct 12, 2019 at 10:13:16PM +0100, Iain Sandoe wrote: > > > For 32bit cases this isn't a problem since we can load/store to unaligned > > > addresses using D-

Re: [RFC, Darwin, PPC] Fix PR 65342.

2019-10-17 Thread Iain Sandoe
Segher Boessenkool wrote: > Okay for trunk. For backports maybe wait a bit longer than usual? So ask > again in two weeks, maybe? I know it's important for the darwin port, but > the generic part is a little scary. No problem (I would like to get this in to the final issue of 7, if possible).

[PATCH] Fix TARGET_MEM_REF handling in PRE

2019-10-17 Thread Richard Biener
It's not exercised but I ran into this with trying PRE after IVOPTs. Committed as obvious. Richard. 2019-10-17 Richard Biener * tree-ssa-pre.c (create_component_ref_by_pieces_1): Fix TARGET_MEM_REF creation. Index: gcc/tree-ssa-pre.c ===

Re: [RFC, Darwin, PPC] Fix PR 65342.

2019-10-17 Thread Segher Boessenkool
On Thu, Oct 17, 2019 at 10:37:33AM +0100, Iain Sandoe wrote: > Segher Boessenkool wrote: > > > Okay for trunk. For backports maybe wait a bit longer than usual? So ask > > again in two weeks, maybe? I know it's important for the darwin port, but > > the generic part is a little scary. > > No

[PATCH][AArch64] Implement Armv8.5-A memory tagging (MTE) intrinsics

2019-10-17 Thread Dennis Zhang
Hi, Arm Memory Tagging Extension (MTE) is published with Armv8.5-A. It can be used for spatial and temporal memory safety detection and lightweight lock and key system. This patch enables new intrinsics leveraging MTE instructions to implement functionalities of creating tags, setting tags, rea

[patch,avr,testsuite,committed]: Fix location of an expected diagnostic.

2019-10-17 Thread Georg-Johann Lay
Hi, committed this patchlet that fixes a test case. Johann * gcc.target/avr/progmem-error-1.cpp: Fix location of the expected diagnostic. Index: gcc.target/avr/progmem-error-1.cpp === --- gcc.target/avr/progmem-erro

Re: [AArch64][SVE2] Support for EOR3 and variants of BSL

2019-10-17 Thread Richard Sandiford
Yuliang Wang writes: > Hi Richard, > > Thanks for the suggestions, updated. > > Regards, > Yuliang > > > gcc/ChangeLog: > > 2019-10-17 Yuliang Wang > > * config/aarch64/aarch64-sve2.md (aarch64_sve2_eor3) > (aarch64_sve2_nor, aarch64_sve2_nand) > (aarch64_sve2_bsl, aarch64_sve

RE: [AArch64][SVE2] Support for EOR3 and variants of BSL

2019-10-17 Thread Yuliang Wang
Thanks very much, updated. Regards, Yuliang gcc/ChangeLog: 2019-10-17 Yuliang Wang * config/aarch64/aarch64-sve2.md (aarch64_sve2_eor3) (aarch64_sve2_nor, aarch64_sve2_nand) (aarch64_sve2_bsl, aarch64_sve2_nbsl) (aarch64_sve2_bsl1n, aarch64_sve2_bsl2n):

[patch,avr] Fix avr build broken by r276985.

2019-10-17 Thread Georg-Johann Lay
Hi, r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from --params. The patch fixes that by using flag_store_data_races = 1 instead. Ok to apply? Johann * config/avr/avr.c (avr_option_override): Fix broken build introduced by r276985. Index: config/avr/avr.c

Re: [patch,avr] Fix avr build broken by r276985.

2019-10-17 Thread Richard Biener
On Thu, 17 Oct 2019, Georg-Johann Lay wrote: > Hi, > > r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from > --params. The patch fixes that by using flag_store_data_races = 1 instead. > > Ok to apply? OK and sorry for the breakage. Richard.

Re: [patch,avr] Fix avr build broken by r276985.

2019-10-17 Thread Eric Botcazou
> r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from > --params. The patch fixes that by using flag_store_data_races = 1 instead. Note that you'll unconditionally override the user, unlike the original code. -- Eric Botcazou

[patch,avr]: PR86040: Fix missing reset of RAMPZ after ELPM.

2019-10-17 Thread Georg-Johann Lay
Hi, for families avrxmega5/7 after ELPM the reset of RAMPZ to zero was missing in some situations due to shortcut-return in avr_out_lpm which which bypassed that reset. Ok to apply and backport? Johann PR target/86040 * config/avr/avr.c (avr_out_lpm): Do not shortcut-return. In

Re: [patch,avr] Fix avr build broken by r276985.

2019-10-17 Thread Jakub Jelinek
On Thu, Oct 17, 2019 at 01:22:54PM +0200, Eric Botcazou wrote: > > r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from > > --params. The patch fixes that by using flag_store_data_races = 1 instead. > > Note that you'll unconditionally override the user, unlike the original code

[COMMITTED][ARM,testsuite] Fix typo in arm_arch_v8a_ok effective target

2019-10-17 Thread Christophe Lyon
Hi, The arm_arch_v8a_ok effective-target lacks a closing bracket in these tests, resulting in it being ignored. 2019-10-17 Christophe Lyon gcc/testsuite/ * gcc.target/arm/vseleqdf.c: Add missing closing bracket. * gcc.target/arm/vseleqsf.c: Likewise.

Re: [patch,avr] Fix avr build broken by r276985.

2019-10-17 Thread Georg-Johann Lay
Am 10/17/19 um 1:22 PM schrieb Eric Botcazou: r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from --params. The patch fixes that by using flag_store_data_races = 1 instead. Note that you'll unconditionally override the user, unlike the original code. You're right. What ab

[PATCH] Move the rest of the validity checks from vect_is_simple_reduction

2019-10-17 Thread Richard Biener
to vectorizable_reduction, that is. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. * tree-vect-loop.c (needs_fold_left_reduction_p): Export. (vect_is_simple_reduction): Move all validity checks ... (vectorizable_reduction): ... here. Compute whe

[ARM,RFC] Avoid test failures when forcing incompatible options

2019-10-17 Thread Christophe Lyon
Hi, While making experiments with -mpure-code, I ran the testsuite with that flag, and noticed that several tests failed because they were forcing an architecture version incompatible with this option. I've just realized that I've come up with 2 different types of fixes: (1) add a dg-skip-if (lik

[committed][vect] Refactor versioning threshold

2019-10-17 Thread Andre Vieira (lists)
Hi, This piece of code was pre-approved by richi. Retested by bootstrapping and regression testing on x86_64 (AVX512) and aarch64. Committed in revision r277101. gcc/ChangeLog: 2019-10-17 Andre Vieira * tree-vect-loop.c (vect_transform_loop): Move code from here... * tree

[C++ PATCH] builtin fn creation

2019-10-17 Thread Nathan Sidwell
We're rather lax about setting DECL_CONTEXT correctly on several classes of builtins. This is affecting modules. But in cleaning it up I noticed cxx_builtin_function & cxx_builtin_function_ext_scope * are doing very similar work (they're identical except for a boolean value). * through a worke

[committed][vect] Outline code into new function: determine_peel_for_niter

2019-10-17 Thread Andre Vieira (lists)
Hi, This piece of code was pre-approved by richi. Retested by bootstrapping and regression testing on x86_64 (AVX512) and aarch64. Committed in revision r277103. gcc/ChangeLog: 2019-10-17 Andre Vieira * tree-vect-loop.c (determine_peel_for_niter): New function contained

Re: [patch,avr] Fix avr build broken by r276985.

2019-10-17 Thread Richard Biener
On Thu, 17 Oct 2019, Georg-Johann Lay wrote: > Am 10/17/19 um 1:22 PM schrieb Eric Botcazou: > >> r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from > >> --params. The patch fixes that by using flag_store_data_races = 1 instead. > > > > Note that you'll unconditionally overri

[committed][vect] Be consistent in versioning threshold use

2019-10-17 Thread Andre Vieira (lists)
Hi, This piece of code was pre-approved by richi. Retested by bootstrapping and regression testing on x86_64 (AVX512) and aarch64. Committed in revision r277105. gcc/ChangeLog: 2019-10-17 Andre Vieira * tree-vect-loop.c (vect_analyze_loop_2): Use same condition to decide

Re: [AArch64][SVE2] Support for EOR3 and variants of BSL

2019-10-17 Thread Segher Boessenkool
On Wed, Oct 16, 2019 at 11:44:37PM +0100, Richard Sandiford wrote: > Segher Boessenkool writes: > >> If someone wants to add a new canonical form then the ports should of > >> course adapt, but until then I think the patch is doing the right thing. > > > > We used to generate this, until GCC 5. T

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2019-10-17 Thread Alexander Monakov
On Tue, 8 Oct 2019, Alexander Monakov wrote: [massive snip] > So in my opinion our CFG is good enough, the real issues with -Wclobbered > false > positives are not due to phi nodes but other effects. > > If you agree: what would be the next steps? Hello, may I ping this discussion? I apologi

Re: [AArch64][SVE2] Support for EOR3 and variants of BSL

2019-10-17 Thread Richard Sandiford
Yuliang Wang writes: > Thanks very much, updated. > > Regards, > Yuliang > > > gcc/ChangeLog: > > 2019-10-17 Yuliang Wang > > * config/aarch64/aarch64-sve2.md (aarch64_sve2_eor3) > (aarch64_sve2_nor, aarch64_sve2_nand) > (aarch64_sve2_bsl, aarch64_sve2_nbsl) > (aarch64_s

Re: [Patch, fortran] PR91926 - assumed rank optional

2019-10-17 Thread Tobias Burnus
See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92027 for a tracking bug – I just added also some analysis. Tobias PS: A better patch submission, with the actual patch attached, would have been nice. Please re-post the committed patch – and the new patch, which fixes the fall out. – Tha

[arm] Add default FPU for Marvell-pj4

2019-10-17 Thread Richard Earnshaw (lists)
According to GAS, the Marvell PJ4 CPU has a VFPv3-D16 floating point unit, but GCC's CPU configuration tables omits this, meaning that -mfpu=auto will not correctly select the FPU. This patch fixes this by adding the +fp option to the architecture specification for this device. * conf

Re: [PATCH][wwwdocs] Purge CVS from gccmission.html

2019-10-17 Thread Kyrill Tkachov
On 10/15/19 5:29 PM, Gerald Pfeifer wrote: On Mon, 14 Oct 2019, Kyrill Tkachov wrote: Surely would be fine with me. I see, thanks. Here's a proposed patch then. My previous mail was meant to pre-approve your patch. ;-) Right, I meant to take it as such, but got distracted with the committi

[PATCH] Simplify vect_is_simple_reduction

2019-10-17 Thread Richard Biener
Now we can solely rely on check_reduction_path. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-10-17 Richard Biener * tree-vect-loop.c (check_reduction_path): Compute reduction operation here. (vect_is_simple_reduction): Remove special-c

Re: [PATCH] RISC-V: Include more registers in SIBCALL_REGS.

2019-10-17 Thread Andrew Burgess
* Jim Wilson [2019-10-16 14:04:45 -0700]: > This finishes the part 1 of 2 patch submitted by Andrew Burgess on Aug 19. > This adds the argument registers but not t0 (aka x5) to SIBCALL_REGS. It > also adds the missing riscv_regno_to_class change. > > Tested with cross riscv32-elf and riscv64-li

[wwwdocs] Improve markup/nicer formatting for GIT instructions.

2019-10-17 Thread Gerald Pfeifer
Committed. My first git push to the new wwwdocs repository ;-) Thank you, Joseph and everyone else who helped! Gerald >From 6df815817051ed1defc13eda2cbadc089da6d646 Mon Sep 17 00:00:00 2001 From: Gerald Pfeifer Date: Thu, 17 Oct 2019 10:19:42 +0200 Subject: [PATCH] Improve markup/nicer format

Re: [C++ Patch] Remove most uses of in_system_header_at

2019-10-17 Thread Paolo Carlini
Hi, On 17/10/19 05:15, Jason Merrill wrote: On 10/16/19 11:59 AM, Paolo Carlini wrote: ... the below, slightly extended patch: 1- Makes sure the in_system_header_at calls surviving in decl.c get the same location used for the corresponding diagnostic Hmm, we probably want to change permerror t

[PATCH] PR libstdc++/92124 fix incorrect container move assignment

2019-10-17 Thread Jonathan Wakely
The container requirements say that for move assignment "All existing elements of [the target] are either move assigned or destroyed". Some of our containers currently use __make_move_if_noexcept which makes the move depend on whether the element type is nothrow move constructible. This is incorre

[PATCH] fix constrained auto parsing issue

2019-10-17 Thread Andrew Sutton
This fixes a parsing bug with constrained placeholders uses as the first parameter of a constructor. Andrew Sutton 0001-Fix-a-bug-with-type-constraints-in-constructors.patch Description: Binary data

Re: [C++ Patch] Remove most uses of in_system_header_at

2019-10-17 Thread Paolo Carlini
.. hi again. We have an issue with this idea which I didn't notice earlier today: there are some libstdc++ *_neg testcases which rely on permerrors being emitted for code in library headers. For example 20_util/ratio/cons/cons_overflow_neg.cc relies on a permerror for the "overflow in constan

[patch,testuite]: Fix some fllout for small targets.

2019-10-17 Thread Georg-Johann Lay
Hi, this fixes some FAILs for small targets, fixed or skipped by size32plus, double64[plus] etc. Ok to apply? Johann Fix some fallout for small targets. * gcc.c-torture/execute/20190820-1.c: Add dg-require-effective-target int32plus. * gcc.c-torture/execute/pr8

[PATCH] Define [range.cmp] comparisons for C++20

2019-10-17 Thread Jonathan Wakely
Define std::identity, std::ranges::equal_to, std::ranges::not_equal_to, std::ranges::greater, std::ranges::less, std::ranges::greater_equal and std::ranges::less_equal. * include/Makefile.am: Add new header. * include/Makefile.in: Regenerate. * include/bits/range_cmp.h: Ne

[PATCH] Process new C++17 and C++20 headers with Doxygen

2019-10-17 Thread Jonathan Wakely
This won't do anything by default, because __cplusplus is set to 201402L when Doxygen runs. If/when that changes, these headers should be processed. * doc/doxygen/user.cfg.in (INPUT): Add new C++17 and C++20 headers. Committed to trunk. commit 14b2576d8c0ea76ccbb4cb90a1d30aea4993a03d A

Re: [PATCH] [x86] Add detection of Icelake Client and Server

2019-10-17 Thread Thiago Macieira
On Wednesday, 16 October 2019 23:51:30 PDT Uros Bizjak wrote: > > gcc/ChangeLog: > > * config/i386/driver-i386.c (host_detect_local_cpu): Handle > > > > icelake-client and icelake-server. > > > > * testsuite/gcc.target/i386/builtin_target.c (check_intel_

[AArch64][SVE2] Fix for r277110 (BSL variants)

2019-10-17 Thread Yuliang Wang
Hi, SVE2 vectorization for BSL and NBSL fails when the element type is unsigned 8/16-bit. The operands are being converted implicitly to corresponding signed types, which the mid-end fold pattern does not take into account; this patch augments the pattern with type conversion checks in order t

[PING] [WIP PATCH] add object access attributes (PR 83859)

2019-10-17 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01690.html Other than the suggestions I got for optimization (for GCC 11) and additional buffer overflow detection for [static] arrays), is there any feedback on the patch itself? Jeff? Martin On 9/29/19 1:51 PM, Martin Sebor wrote: -Wstring

[Patch, fortran] PR fortran/92142 - CFI_setpointer corrupts descriptor

2019-10-17 Thread José Rui Faustino de Sousa
Hi all! Proposed patch to solve the handling of the attribute value in the descriptor. Patch tested only on x86_64-pc-linux-gnu. CFI_setpointer does not check if it is setting a pointer and will set any type of object to the target. CFI_setpointer will also change the pointer attribute of

Re: [arm] PR target/89400 fix thumb1 unaligned access expansion

2019-10-17 Thread Richard Earnshaw (lists)
On 03/05/2019 14:47, Richard Earnshaw (lists) wrote: Armv6 has support for unaligned accesses to memory. However, the thumb1 code patterns were trying to use the 32-bit code constraints. One failure mode from this was that the patterns are designed to be compatible with conditional execution an

[PATCH] Cleanup more redundant stuff in reduction vect

2019-10-17 Thread Richard Biener
Bootstrapped and tested on x86_64-unknwon-linux-gnu, applied. Richard. 2019-10-17 Richard Biener * tree-vectorizer.h (_stmt_vec_info::cond_reduc_code): Remove. (STMT_VINFO_VEC_COND_REDUC_CODE): Likewise. * tree-vectorizer.c (vec_info::new_stmt_vec_info): Do not

Re: [Patch, fortran] PR fortran/92142 - CFI_setpointer corrupts descriptor

2019-10-17 Thread Tobias Burnus
Hi, +  fprintf (stderr, "CFI_setpointer: Result is NULL.\n"); … + return CFI_INVALID_DESCRIPTOR; +! { dg-do run } +! { dg-additional-options "-fbounds-check" } +! { dg-additional-sources ISO_Fortran_binding_15.c } If you generate to stdout/stderr like in this case, I think it makes sense

Re: Type representation in CTF and DWARF

2019-10-17 Thread Nick Alcock
On 11 Oct 2019, Indu Bhagat stated: > Compile with -g -gdwarf-like-ctf and use dwz -o (using > dwz compiled from the master branch) on the generated binaries: > > (coreutils-0.22) > .debug_info(D1) | .debug_abbrev(D2) | .debug_str(D4) | .ctf > (uncompressed) | ratio (.ctf/(D1+D2+0.5*D4)) >

Re: [PATCH] Communicate lto-wrapper and ld through a file

2019-10-17 Thread Giuliano Belinassi
Hi On 10/17, Richard Biener wrote: > On Wed, Oct 16, 2019 at 7:46 PM Giuliano Belinassi > wrote: > > > > Hi, > > > > Previously, the lto-wrapper communicates with ld by creating a pipe from > > lto-wrapper's stdout to ld's stdin. This patch uses a temporary file for > > this communication, releas

Re: [C++ Patch] Remove most uses of in_system_header_at

2019-10-17 Thread Jason Merrill
On 10/17/19 11:30 AM, Paolo Carlini wrote: .. hi again. We have an issue with this idea which I didn't notice earlier today: there are some libstdc++ *_neg testcases which rely on permerrors being emitted for code in library headers. For example 20_util/ratio/cons/cons_overflow_neg.cc relies

Re: Type representation in CTF and DWARF

2019-10-17 Thread Richard Biener
On Thu, Oct 17, 2019 at 7:36 PM Nick Alcock wrote: > > On 11 Oct 2019, Indu Bhagat stated: > > Compile with -g -gdwarf-like-ctf and use dwz -o (using > > dwz compiled from the master branch) on the generated binaries: > > > > (coreutils-0.22) > > .debug_info(D1) | .debug_abbrev(D2) | .debug

Re: [PATCH] LRA: side_effects_p stmts' output is not invariant (PR89721)

2019-10-17 Thread Segher Boessenkool
On Fri, Mar 15, 2019 at 05:14:48PM -0500, Segher Boessenkool wrote: > On Fri, Mar 15, 2019 at 04:25:01PM -0400, Vladimir Makarov wrote: > > On 2019-03-15 2:30 p.m., Segher Boessenkool wrote: > > >PR89721 shows LRA treating an unspec_volatile's result as invariant, > > >which of course isn't correct

Re: [PATCH] LRA: side_effects_p stmts' output is not invariant (PR89721)

2019-10-17 Thread Vladimir Makarov
On 10/17/19 2:09 PM, Segher Boessenkool wrote: On Fri, Mar 15, 2019 at 05:14:48PM -0500, Segher Boessenkool wrote: On Fri, Mar 15, 2019 at 04:25:01PM -0400, Vladimir Makarov wrote: On 2019-03-15 2:30 p.m., Segher Boessenkool wrote: PR89721 shows LRA treating an unspec_volatile's result as inva

Re: [ C++ ] [ PATCH ] [ RFC ] p1301 - [[nodiscard("should have a reason")]]

2019-10-17 Thread Jason Merrill
On 10/16/19 5:36 PM, JeanHeyd Meneide wrote: Thanks, Jason! I fixed those last things and I put the changelog below in the e-mail. I'll figure out how to write a good changelog in a commit message on the command line soon. :D In the e-mail like this is fine, thanks. 2019-10-16 JeanHeyd Menei

Re: [ C++ ] [ PATCH ] [ RFC ] p1301 - [[nodiscard("should have a reason")]]

2019-10-17 Thread Jakub Jelinek
On Thu, Oct 17, 2019 at 02:38:32PM -0400, Jason Merrill wrote: > On 10/16/19 5:36 PM, JeanHeyd Meneide wrote: > > Thanks, Jason! I fixed those last things and I put the changelog below > > in the e-mail. I'll figure out how to write a good changelog in a > > commit message on the command line soon.

Re: Type representation in CTF and DWARF

2019-10-17 Thread Nick Alcock
On 17 Oct 2019, Richard Biener verbalised: > On Thu, Oct 17, 2019 at 7:36 PM Nick Alcock wrote: >> >> On 11 Oct 2019, Indu Bhagat stated: >> > Compile with -g -gdwarf-like-ctf and use dwz -o >> > (using >> > dwz compiled from the master branch) on the generated binaries: >> > >> > (coreutils-0

Re: [ C++ ] [ PATCH ] [ RFC ] p1301 - [[nodiscard("should have a reason")]]

2019-10-17 Thread JeanHeyd Meneide
2019-10-17 JeanHeyd Meneide gcc/ * escaped_string.h (escaped_string): New header. * tree.c (escaped_string): Remove escaped_string class. gcc/c-family * c-lex.c (c_common_has_attribute): Update attribute value. gcc/cp/ * tree.c (handle_nodiscard_attribute):

[PATCH] * .gitattributes: Avoid {} in filename pattern.

2019-10-17 Thread Jason Merrill
Brace-expansion is a bash feature, not part of glob(7). Applying to trunk. --- .gitattributes | 6 +- ChangeLog | 4 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.gitattributes b/.gitattributes index b38d7f1b43b..183fdcaaa9a 100644 --- a/.gitattributes +++ b/.gitatt

Re: [ C++ ] [ PATCH ] [ RFC ] p1301 - [[nodiscard("should have a reason")]]

2019-10-17 Thread Jason Merrill
On 10/17/19 3:12 PM, JeanHeyd Meneide wrote: * tree.c (handle_nodiscard_attribute): Implements p1301 [[nodiscard("should have a reason")]]. This should be a heading at the top rather than specific to this file/function. It looks like you didn't run the testsuite, I'm seei

Re: [patch,avr]: PR86040: Fix missing reset of RAMPZ after ELPM.

2019-10-17 Thread Jeff Law
On 10/17/19 5:26 AM, Georg-Johann Lay wrote: > Hi, for families avrxmega5/7 after ELPM the reset of RAMPZ to > zero was missing in some situations due to  shortcut-return in > avr_out_lpm which which bypassed that reset. > > Ok to apply and backport? > > Johann > > PR target/86040 > * co

Re: [patch,testuite]: Fix some fllout for small targets.

2019-10-17 Thread Jeff Law
On 10/17/19 9:32 AM, Georg-Johann Lay wrote: > Hi, this fixes some FAILs for small targets, fixed or skipped by > size32plus, double64[plus] etc. > > Ok to apply? > > Johann > > Fix some fallout for small targets. > > * gcc.c-torture/execute/20190820-1.c: > Add dg-require-effective-

Re: [PATCH] RISC-V: Include more registers in SIBCALL_REGS.

2019-10-17 Thread Jim Wilson
On Thu, Oct 17, 2019 at 7:09 AM Andrew Burgess wrote: > I'm still working on part 2, I'm hoping to have a revised patch posted > by Monday next week. I started looking at the part 2 patch also. I noticed a problem where the NOTE_INSN_EPILOGUE_BEGIN can occur before the NOTE_INSN_PROLOGUE_END due

Re: [PATCH] RISC-V: Include more registers in SIBCALL_REGS.

2019-10-17 Thread Andrew Burgess
* Jim Wilson [2019-10-17 14:55:34 -0700]: > On Thu, Oct 17, 2019 at 7:09 AM Andrew Burgess > wrote: > > I'm still working on part 2, I'm hoping to have a revised patch posted > > by Monday next week. > > I started looking at the part 2 patch also. I noticed a problem where > the NOTE_INSN_EPIL

Re: [PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-17 Thread Jakub Jelinek
On Wed, Oct 16, 2019 at 04:36:07PM -0400, Jason Merrill wrote: > > As for CLEANUP_STMT, I've tried it (the second patch), but it didn't change > > anything, the diagnostics was still > > constexpr-dtor3.C:16:23: in ‘constexpr’ expansion of ‘f4()’ > > constexpr-dtor3.C:16:24: in ‘constexpr’ expa

Re: {PATCH v3, rs6000] Replace X-form addressing with D-form addressing in new pass for Power9

2019-10-17 Thread Segher Boessenkool
Hi Kelvin, On Wed, Oct 09, 2019 at 03:28:45PM -0500, Kelvin Nilsen wrote: > This new pass scans existing rtl expressions and replaces them with rtl > expressions that favor selection of the D-form instructions in contexts for > which the D-form instructions are preferred. The new pass runs afte

[PATCH][Demangler] Small fix for complex values

2019-10-17 Thread Miguel Saldivar
This is a small for Bug 67299, where symbol: `Z1fCf` becomes `f(float complex)` rather than: `f(floatcomplex )`. I thought this would be the preferred way of printing, because both `llvm-cxxfilt` and `cpp_filt` both print the former. Thanks, Miguel Saldivar

Re: [PATCH] Fix objsz ICE (PR tree-optimization/92056)

2019-10-17 Thread Martin Sebor
On 10/17/19 1:00 AM, Jakub Jelinek wrote: Hi! The following bug has been introduced when cond_expr_object_size has been added in 2007. We want to treat a COND_EXPR like a PHI with 2 arguments, and PHI is handled in a loop that breaks if the lhs value is unknown, and then does the if (TREE_CODE

[SVE] PR91272

2019-10-17 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR91272. Does it look OK ? With patch, I see following failures for aarch64-sve.exp: FAIL: gcc.target/aarch64/sve/clastb_1.c -march=armv8.2-a+sve scan-assembler \\tclastb\\tw[0-9]+, p[0-7], w[0-9]+, z[0-9]+\\.s FAIL: gcc.target/aarch64/sve/clastb_2.c -march=armv

Re: [PATCH] Support multi-versioning on self-recursive function (ipa/92133)

2019-10-17 Thread luoxhu
Hi Feng, On 2019/10/17 16:23, Feng Xue OS wrote: > IPA does not allow constant propagation on parameter that is used to control > function recursion. > > recur_fn (i) > { >if ( !terminate_recursion (i)) > { >... >recur_fn (i + 1); >... > } >... > } > > T

fruit juice

2019-10-17 Thread cherry029
Dear Sir I am from Xi'an, China. We are very interested in your juice drink. If you can, please send me a photo or catalog and look forward to working with you! Best regards Ms Ariel Mol:0086-13022879793 --

Re: [PATCH] Support multi-versioning on self-recursive function (ipa/92133)

2019-10-17 Thread Feng Xue OS
> I noticed similar issue when analyzing the SPEC, self-recursive function is > not versioned and posted my observations in > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92074. > Generally, this could be implemented well by your patch, while I am > wondering whether it is OK to convert the recur

Re: [SVE] PR86753

2019-10-17 Thread Prathamesh Kulkarni
On Wed, 16 Oct 2019 at 04:19, Richard Sandiford wrote: > > Richard Biener writes: > > On Tue, Oct 15, 2019 at 8:07 AM Prathamesh Kulkarni > > wrote: > >> > >> On Wed, 9 Oct 2019 at 08:14, Prathamesh Kulkarni > >> wrote: > >> > > >> > On Tue, 8 Oct 2019 at 13:21, Richard Sandiford > >> > wrote:

[Patch][Demangler] Fix for complex values

2019-10-17 Thread Miguel Saldivar
This is a small fix for Bug 67299, where symbol: `Z1fCf` which would become `f(float complex)` instead of `f(floatcomplex )`. I thought this would be the preferred way of printing, because both `llvm-cxxfilt` and `cpp_filt` both print the the mangled name in this fashion. Thanks, Miguel Saldivar

Re: [ C++ ] [ PATCH ] [ RFC ] p1301 - [[nodiscard("should have a reason")]]

2019-10-17 Thread JeanHeyd Meneide
Dear Jason, On Thu, Oct 17, 2019 at 3:51 PM Jason Merrill wrote: > > FAIL: g++.dg/cpp0x/gen-attrs-67.C -std=c++11 (test for errors, line 8) > > FAIL: g++.dg/cpp1z/feat-cxx1z.C -std=gnu++17 (test for excess errors) > > FAIL: g++.dg/cpp1z/nodiscard4.C -std=c++11 (test for excess errors) > >

Re: [ C++ ] [ PATCH ] [ RFC ] p1301 - [[nodiscard("should have a reason")]]

2019-10-17 Thread JeanHeyd Meneide
... And I am very tired and forgot to attach the patch. Again. Sorry...! On Fri, Oct 18, 2019 at 1:54 AM JeanHeyd Meneide wrote: > > Dear Jason, > > On Thu, Oct 17, 2019 at 3:51 PM Jason Merrill wrote: > > > FAIL: g++.dg/cpp0x/gen-attrs-67.C -std=c++11 (test for errors, line 8) > > > FAIL: g

[PATCH] [MIPS] Mark built-in functions as pure

2019-10-17 Thread Mihailo Stojanovic
Mips built-in functions are currently not marked as pure, which invalidates pointers across built-in function calls. If a pointer is alive across built-in call, dereferencing it before and after the call will generate two load instructions instead of one. This marks the built-ins as pure, which re

Re: [PATCH] Fix objsz ICE (PR tree-optimization/92056)

2019-10-17 Thread Jakub Jelinek
On Thu, Oct 17, 2019 at 06:07:37PM -0600, Martin Sebor wrote: > On 10/17/19 1:00 AM, Jakub Jelinek wrote: > > Hi! > > > > The following bug has been introduced when cond_expr_object_size has been > > added in 2007. We want to treat a COND_EXPR like a PHI with 2 arguments, > > and PHI is handled i

Re: [PATCH] Relax integer condition reduction, simplify vect_is_simple_reduction

2019-10-17 Thread Christophe Lyon
On Wed, 16 Oct 2019 at 15:09, Richard Biener wrote: > > > It happens we cannot have different typed data and index for > integer condition reductions right now, for whatever reason. > The following makes that work, even for double data and integer index. > There's hope this enables some relevant a