[testsuite] Fix PR93935 to guard case under vect_hw_misalign

2020-02-25 Thread Kewen.Lin
Hi, This patch is to apply the same fix as r267528 to another similar case bb-slp-over-widen-2.c which requires misaligned vector access. Verified it on ppc64-redhat-linux (Power7 BE). Is it ok for trunk? BR, Kewen --- gcc/testsuite/ChangeLog 2020-02-26 Kewen Lin PR

Re: [PATCH] fix -fdebug-prefix-map without gas .file support

2020-02-25 Thread Jason Merrill
On 2/21/20 5:02 AM, Richard Biener wrote: This applies file mapping when emitting the directory table directly instead of using the assemblers .file directive where we already correctly apply the map. Notably the non-assembler path is used for the early debug emission for LTO. Bootstrapped and

Re: [PATCH] c++: Fix ICE with constexpr init and [[no_unique_address]] [PR93803]

2020-02-25 Thread Jason Merrill
On 2/24/20 11:44 AM, Marek Polacek wrote: Here we crash when constexpr-initializing a class member of empty class type with [[no_unique_address]]. Without the attribute we would have a ctor (that initializes bar) of the form { .D.2173 = { .x = {} } } but with the attribute

Re: [PATCH] c++: Some improvements to concept diagnostics

2020-02-25 Thread Jason Merrill
On 2/24/20 12:30 PM, Patrick Palka wrote: On Mon, 24 Feb 2020, Jason Merrill wrote: On 2/20/20 7:27 PM, Patrick Palka wrote: This patch improves our concept diagnostics in two ways. First, it sets a more precise location for the constraint expressions built in finish_constraint_binary_op.

Re: [PATCH] c++: Add test for DR 1423, Convertibility of nullptr to bool.

2020-02-25 Thread Jason Merrill
On 2/24/20 1:09 PM, Marek Polacek wrote: DR 1423, which supersedes DR 654, says that you can't copy-init a bool from a std::nullptr_t: bool b = nullptr; // error Conversely, it works with direct-initialization which is more permissive than copy-initialization. No code changes necessary

Re: [PATCH] c++: Fix ICE with static_cast when converting from int[] [PR93862]

2020-02-25 Thread Jason Merrill
On 2/24/20 3:41 PM, Marek Polacek wrote: This ICEs since my patch for P0388, which allowed conversions to arrays of unknown bound, but not the reverse, so these two static_casts are ill-formed. [expr.static.cast]/3 says that "cv1 T1" and "cv2 T2" have to be reference-compatible and the comment

Re: [PATCH] c++: Fix rejects-valid bug in cxx_eval_outermost_constant_expr [PR93905]

2020-02-25 Thread Jason Merrill
On 2/25/20 6:07 PM, Jakub Jelinek wrote: Hi! The following testcase is rejected in 8.3, but was accepted in 8.2 and is in 9.x. This started with my PR87934 * constexpr.c (cxx_eval_constant_expression) : Do re-process TREE_CONSTANT CONSTRUCTORs if they aren't reduced constant

Re: [PATCH v5] c++: Fix value-init crash in template [PR93676]

2020-02-25 Thread Jason Merrill
On 2/25/20 1:55 PM, Marek Polacek wrote: On Tue, Feb 25, 2020 at 01:27:12PM -0500, Jason Merrill wrote: On 2/25/20 12:52 PM, Marek Polacek wrote: On Mon, Feb 24, 2020 at 05:15:45PM -0500, Jason Merrill wrote: On 2/20/20 11:52 AM, Marek Polacek wrote: On Thu, Feb 20, 2020 at 12:13:07AM +,

Re: GLIBC libmvec status

2020-02-25 Thread Bill Schmidt
On 2/25/20 12:45 PM, Segher Boessenkool wrote: Hi! On Tue, Feb 25, 2020 at 04:53:17PM +, GT wrote: ‐‐‐ Original Message ‐‐‐ On Sunday, February 23, 2020 11:45 AM, Bill Schmidt wrote: As I just wrote on gcc-patches, we should disable libmvec for powerpc64. The vector ABI as

[PATCH] store-merging: Fix coalesce_immediate_stores [PR93820]

2020-02-25 Thread Jakub Jelinek
Hi! The following testcase is miscompiled in 8+. The problem is that check_no_overlap has a special case for INTEGER_CST marked stores (i.e. stores of constants), if both all currenly merged stores and the one under consideration for merging with them are marked that way, it anticipates that

[PATCH] c++: Fix rejects-valid bug in cxx_eval_outermost_constant_expr [PR93905]

2020-02-25 Thread Jakub Jelinek
Hi! The following testcase is rejected in 8.3, but was accepted in 8.2 and is in 9.x. This started with my PR87934 * constexpr.c (cxx_eval_constant_expression) : Do re-process TREE_CONSTANT CONSTRUCTORs if they aren't reduced constant expressions. backport, where the

Re: Update gcc.target/powerpc/pr92132-fp test for power7 and older

2020-02-25 Thread will schmidt
On Sat, 2020-02-22 at 18:15 -0600, Segher Boessenkool wrote: > On Mon, Feb 17, 2020 at 02:48:20PM -0600, will schmidt wrote: > > On Thu, 2020-02-13 at 17:23 -0600, Segher Boessenkool wrote: > > > On Thu, Feb 13, 2020 at 04:41:09PM -0600, will schmidt wrote: > > > > -/* { dg-final {

PowerPC Add has_arch_pwr* checks

2020-02-25 Thread will schmidt
PowerPC Add has_arch_pwr* checks Hi, This adds some procs to target-supports.exp that will allow our testcases to accurately determine which -mcpu= option is enabled at the time of our testcase compile. For completeness I've added blobs to cover the ARCH_PWR5 through ARCH_PWR9 targets.

[PATCH] correctly handle attribute access (PR 92721)

2020-02-25 Thread Martin Sebor
Release checking has exposed a bug in the transformation of attribute access to the condensed internal format: the handler modifies the declaration's type in place, which subsequently triggers an ICE. A fix also exposed another bug where the condensed format sets the attribute argument's value

Re: [PATCH] rs6000: Fix broken gcc.target/powerpc/fold-vec-st-*.c test cases [PR93913]

2020-02-25 Thread Segher Boessenkool
On Tue, Feb 25, 2020 at 10:49:16AM -0600, Peter Bergner wrote: > POWER9 added the stxv instruction, which is d-form store. When we compile > the FAILing test cases in PR93913 when -mcpu=power9 is the default, then > we may sometimes get stxv rather than stvx generated. The fix here is > to allow

Re: [PATCH] rs6000: Use -mno-pcrel for tests requiring TOC

2020-02-25 Thread Bill Schmidt
On 2/25/20 4:00 PM, Segher Boessenkool wrote: On Mon, Feb 24, 2020 at 03:20:30PM -0600, Bill Schmidt wrote: These two test cases have assembly code that requires a valid TOC. Make sure that we don't use the PC-relative ABI extensions that violate this requirement. Tested and verified on

Re: [PATCH] rs6000: Use -mno-pcrel for tests requiring TOC

2020-02-25 Thread Segher Boessenkool
On Mon, Feb 24, 2020 at 03:20:30PM -0600, Bill Schmidt wrote: > These two test cases have assembly code that requires a valid TOC. > Make sure that we don't use the PC-relative ABI extensions that > violate this requirement. > > Tested and verified on powerpc64le-unknown-linux-gnu. Is this >

Re: [PATCH,rs6000] Fix documentation for __builtin_crypto_vpmsum* builtin functions.

2020-02-25 Thread Segher Boessenkool
Hi Carl, On Mon, Feb 24, 2020 at 11:37:11AM -0800, Carl Love wrote: > PR target/91276 > * doc/extend.texi (PowerPC AltiVec/VSX __builtin_crypto_vpmsum > Built-in Functions): Fix builtin name for function taking vector > unsigned short, vector unsigned int and vector

Re: GLIBC libmvec status

2020-02-25 Thread Joseph Myers
On Tue, 25 Feb 2020, GT wrote: > 2. In GCC making SIMD clones available only for powerpc64le should be > sufficient to guarantee that the Vector Function ABI is applied only for > systems implementing the ELFv2 ABI. Right? Then, which macro is to be > tested for in rs6000_simd_clone_usable? I

Re: GLIBC libmvec status

2020-02-25 Thread Tulio Magno Quites Machado Filho
GT writes: > Are we all agreed that the POWER Vector Function ABI will be implemented only > for powerpc64le? > > If so, here are a few more questions: > > 1. The GLIBC implementation has files Makefile, Versions, configure, > configure.ac among others > in directory

[committed] typo fix: Fix probablity, becuse, sucessor and destinarion typos [PR93912]

2020-02-25 Thread Jakub Jelinek
Hi! Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2020-02-25 Jakub Jelinek PR other/93912 * config/sh/sh.c (expand_cbranchdi4): Fix comment typo, probablity -> probability. * cfghooks.c (verify_flow_info): Likewise.

structurally compare type_arg_packs [93933]

2020-02-25 Thread Nathan Sidwell
We consider all TYPE_ARGUMENT_PACKS distinct types, leading to problems with redeclarations. This patch fixes things by: a) marking all such types for structural comparison b) teaching structural_comptypes how to compare them. 1) It appears that NONTYPE_ARGUMENT_PACKS just work, I think

define NO_DOT_IN_LABEL only in vxworks6

2020-02-25 Thread Alexandre Oliva
There was a mistake in forward-porting and contributing some vxworks7r2 changes, that caused a conditional to be dropped around a couple of preprocessor directives, needed only up to vxworks6, that change the compiler's behavior WRT introducing dollars and dots in symbol names. This deviates

work-around system header namespace pollution

2020-02-25 Thread Alexandre Oliva
Including limits.h on vxworks pollutes the global namespace with SH and many other platform names; work around it. Tested on the affected platform. Ok to install? for gcc/testsuite/ChangeLog * gcc.target/aarch64/vect-mull.x (SH): Undefine. ---

[PATCH] libstdc++: P1645R1 constexpr for algorithms

2020-02-25 Thread Patrick Palka
This adds constexpr to 11 algorithms defined in as per P1645R1. Tested on x86_64-pc-linux-gnu, OK to commit? libstdc++-v3/ChangeLog: P1645R1 constexpr for algorithms * include/bits/stl_numeric.h (iota, accumulate, inner_product, partial_sum, adjacent_difference): Make

Re: PR90763: PowerPC vec_xl_len should take const argument.

2020-02-25 Thread Segher Boessenkool
Hi! On Tue, Feb 25, 2020 at 12:15:52PM -0600, will schmidt wrote: > Adds some logic in altivec_resolve_overloaded_builtin() to handle the > scenario where const * arguments are passed in to the vec_xl_len() > builtin. > The existing logic to remove const from pointers does not kick in since >

Ping: [PATCH] wwwdocs: Document support for extended identifiers added to GCC 10

2020-02-25 Thread Lewis Hyatt
Hello- Just checking whether the below is OK for gcc 10 changes.html please. Thanks! https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01667.html -Lewis On Fri, Jan 24, 2020 at 10:25 AM Lewis Hyatt wrote: > > Hello- > > There was a comment on PR67224: >

Re: [PATCH v5] c++: Fix value-init crash in template [PR93676]

2020-02-25 Thread Marek Polacek
On Tue, Feb 25, 2020 at 01:55:24PM -0500, Marek Polacek wrote: > On Tue, Feb 25, 2020 at 01:27:12PM -0500, Jason Merrill wrote: > > On 2/25/20 12:52 PM, Marek Polacek wrote: > > > On Mon, Feb 24, 2020 at 05:15:45PM -0500, Jason Merrill wrote: > > > > On 2/20/20 11:52 AM, Marek Polacek wrote: > > >

Re: [PATCH v5] c++: Fix value-init crash in template [PR93676]

2020-02-25 Thread Marek Polacek
On Tue, Feb 25, 2020 at 01:27:12PM -0500, Jason Merrill wrote: > On 2/25/20 12:52 PM, Marek Polacek wrote: > > On Mon, Feb 24, 2020 at 05:15:45PM -0500, Jason Merrill wrote: > > > On 2/20/20 11:52 AM, Marek Polacek wrote: > > > > On Thu, Feb 20, 2020 at 12:13:07AM +, Jason Merrill wrote: > > >

Re: GLIBC libmvec status

2020-02-25 Thread Segher Boessenkool
Hi! On Tue, Feb 25, 2020 at 04:53:17PM +, GT wrote: > ‐‐‐ Original Message ‐‐‐ > On Sunday, February 23, 2020 11:45 AM, Bill Schmidt > wrote: > > As I just wrote on gcc-patches, we should disable libmvec for powerpc64. > > The vector ABI as written isn't compatible with ELFv1. We

Re: [GCC][PATCH][AArch64] Add bfloat16 vdup and vreinterpret ACLE intrinsics

2020-02-25 Thread Richard Sandiford
Mihail Ionescu writes: > Hi, > > On 02/17/2020 05:53 PM, Mihail Ionescu wrote: >> Hi, >> >> This patch adds support for the bf16 duplicate and reinterpret intrinsics. >> ACLE documents are at https://developer.arm.com/docs/101028/latest >> ISA documents are at

Re: [GCC][PATCH][AArch64] Add bfloat16 vldn/vstn intrinsics

2020-02-25 Thread Richard Sandiford
Mihail Ionescu writes: > Hi Richard, > > On 02/18/2020 05:06 PM, Richard Sandiford wrote: >> Thanks. When trying a bootstrap locally I get: >> >> include/arm_neon.h:34709:38: error: cannot convert ‘const __bf16*’ to ‘const >> __fp16*’ >> 34709 | __o = __builtin_aarch64_ld1x2v4hf ((const >>

Re: [PATCH v4] c++: Fix value-init crash in template [PR93676]

2020-02-25 Thread Jason Merrill
On 2/25/20 12:52 PM, Marek Polacek wrote: On Mon, Feb 24, 2020 at 05:15:45PM -0500, Jason Merrill wrote: On 2/20/20 11:52 AM, Marek Polacek wrote: On Thu, Feb 20, 2020 at 12:13:07AM +, Jason Merrill wrote: On 2/19/20 10:15 PM, Marek Polacek wrote: On Fri, Feb 14, 2020 at 12:24:30AM

PR90763: PowerPC vec_xl_len should take const argument.

2020-02-25 Thread will schmidt
PR90763: PowerPC vec_xl_len should take const argument. Hi, Adds some logic in altivec_resolve_overloaded_builtin() to handle the scenario where const * arguments are passed in to the vec_xl_len() builtin. The existing logic to remove const from pointers does not kick in since the return type

Re: [PATCH] libstdc++: LWG 3301 transform_view::iterator has incorrect iterator_category

2020-02-25 Thread Patrick Palka
On Tue, 25 Feb 2020, Jonathan Wakely wrote: > On 24/02/20 18:39 -0500, Patrick Palka wrote: > > On Mon, 24 Feb 2020, Patrick Palka wrote: > > > > > libstdc++-v3/ChangeLog: > > > > > > LWG 3301 transform_view::_Iterator has incorrect iterator_category > > > * include/std/ranges

Re: [PATCH v4] c++: Fix value-init crash in template [PR93676]

2020-02-25 Thread Marek Polacek
On Mon, Feb 24, 2020 at 05:15:45PM -0500, Jason Merrill wrote: > On 2/20/20 11:52 AM, Marek Polacek wrote: > > On Thu, Feb 20, 2020 at 12:13:07AM +, Jason Merrill wrote: > > > On 2/19/20 10:15 PM, Marek Polacek wrote: > > > > On Fri, Feb 14, 2020 at 12:24:30AM +0100, Jason Merrill wrote: > > >

Re: [Ping][PATCH][Arm] ACLE intrinsics for AdvSIMD bfloat16 dot product

2020-02-25 Thread Dennis Zhang
Hi Kyrill, On 25/02/2020 17:22, Kyrill Tkachov wrote: Hi Dennis, On 2/25/20 5:18 PM, Dennis Zhang wrote: Hi Kyrill, On 25/02/2020 12:18, Kyrill Tkachov wrote: Hi Dennis, On 2/25/20 11:54 AM, Dennis Zhang wrote: Hi all, On 07/01/2020 12:12, Dennis Zhang wrote: > Hi all, > > This patch is

Re: [PATCH] libstdc++: LWG 3397 basic_istream_view::iterator should not provide iterator_category

2020-02-25 Thread Jonathan Wakely
On 24/02/20 18:26 -0500, Patrick Palka wrote: libstdc++-v3/ChangeLog: LWG 3397 basic_istream_view::iterator should not provide iterator_category * include/std/ranges (basic_istream_view:_Iterator::iterator_category): Rename to ...

Re: [PATCH] libstdc++: LWG 3301 transform_view::iterator has incorrect iterator_category

2020-02-25 Thread Jonathan Wakely
On 24/02/20 18:39 -0500, Patrick Palka wrote: On Mon, 24 Feb 2020, Patrick Palka wrote: libstdc++-v3/ChangeLog: LWG 3301 transform_view::_Iterator has incorrect iterator_category * include/std/ranges (transform_view::_Iterator::_S_iter_cat): Adjust determination of

Re: [Ping][PATCH][Arm] ACLE intrinsics for AdvSIMD bfloat16 dot product

2020-02-25 Thread Kyrill Tkachov
Hi Dennis, On 2/25/20 5:18 PM, Dennis Zhang wrote: Hi Kyrill, On 25/02/2020 12:18, Kyrill Tkachov wrote: Hi Dennis, On 2/25/20 11:54 AM, Dennis Zhang wrote: Hi all, On 07/01/2020 12:12, Dennis Zhang wrote: > Hi all, > > This patch is part of a series adding support for Armv8.6-A features.

Re: [PATCH] libstdc++: LWG 3313 join_view::iterator::operator-- is incorrectly constrained

2020-02-25 Thread Jonathan Wakely
On 24/02/20 18:26 -0500, Patrick Palka wrote: libstdc++-v3/ChangeLog: LWG 3313 join_view::_Iterator::operator-- is incorrectly constrained * include/std/ranges (join_view::_Iterator::operator--): Require that range_reference_t<_Base> models common_range. *

Re: [PATCH] libstdc++: LWG 3325 Constrain return type of transformation function for transform_view

2020-02-25 Thread Jonathan Wakely
On 24/02/20 18:26 -0500, Patrick Palka wrote: libstdc++-v3/ChangeLog: LWG 3325 Constrain return type of transformation function for transform_view * include/std/ranges (transform_view): Constrain the return type of the transformation function as per LWG 3325.

Re: [PATCH] libstdc++: LWG 3292 iota_view is under-constrained

2020-02-25 Thread Jonathan Wakely
On 24/02/20 18:26 -0500, Patrick Palka wrote: libstdc++-v3/ChangeLog: LWG 3292 iota_view is under-constrained * include/std/ranges (iota_view): Require that _Winc models semiregular as per LWG 3292. * testsuite/std/ranges/iota/lwg3292_neg.cc: New test. OK.

Re: [committed] libstdc++: Fix regression in std::move algorithm (PR 93872)

2020-02-25 Thread Jonathan Wakely
On 25/02/20 16:01 +0200, Ville Voutilainen wrote: On Tue, 25 Feb 2020 at 15:36, Jonathan Wakely wrote: I think what I'd really like to do is get rid of __memmove entirely. We already have code that does the explicit assignment in a loop, for the cases where we can't use __builtin_memmove

Re: [Ping][PATCH][Arm] ACLE intrinsics for AdvSIMD bfloat16 dot product

2020-02-25 Thread Dennis Zhang
Hi Kyrill, On 25/02/2020 12:18, Kyrill Tkachov wrote: Hi Dennis, On 2/25/20 11:54 AM, Dennis Zhang wrote: Hi all, On 07/01/2020 12:12, Dennis Zhang wrote: > Hi all, > > This patch is part of a series adding support for Armv8.6-A features. > It depends on the patch enabling Arm BFmode >

Re: GLIBC libmvec status

2020-02-25 Thread GT
‐‐‐ Original Message ‐‐‐ On Sunday, February 23, 2020 11:45 AM, Bill Schmidt wrote: > On 2/21/20 6:49 AM, Tulio Magno Quites Machado Filho wrote: > > > +Bill, +Segher > > > > GT writes: > > > > > Can I have until tomorrow morning to figure out exactly where/how to link > > > the Power

[PATCH] rs6000: Fix broken gcc.target/powerpc/fold-vec-st-*.c test cases [PR93913]

2020-02-25 Thread Peter Bergner
POWER9 added the stxv instruction, which is d-form store. When we compile the FAILing test cases in PR93913 when -mcpu=power9 is the default, then we may sometimes get stxv rather than stvx generated. The fix here is to allow both mnemonics when counting. Ok for trunk and GCC 9, where these are

Re: [ARM] Fix -mpure-code for v6m

2020-02-25 Thread Christophe Lyon
On Tue, 25 Feb 2020 at 14:44, Kyrill Tkachov wrote: > > Hi Christophe, > > On 2/24/20 2:16 PM, Christophe Lyon wrote: > > Ping? > > > > I'd also like to backport this and the main patch (svn r279463, > > r10-5505-ge24f6408df1e4c5e8c09785d7b488c492dfb68b3) > > to the gcc-9 branch. > > > > I found

Re: Dead code in fortran/simplify.c

2020-02-25 Thread Steve Kargl
On Tue, Feb 25, 2020 at 09:28:59AM +0100, Tobias Burnus wrote: > Thanks for the cleanup. Committed (with "git commit --author 'St...'" + git > push) as Rev. r10-6836-gfe86f537f010828b7f77ff459cef138e84071660 > Thanks. -- Steve

Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-25 Thread Andrea Corallo
Hi all, Third version of the patch here addressing comments. This patch enables the Armv8.1-M Mainline LOB (low overhead branch) extension low overhead loops (LOL) feature by using the 'loop-doloop' pass. Given the following function: void loop (int *a) { for (int i = 0; i < 1000; i++)

Re: [GCC][PATCH][AArch64] Add bfloat16 vdup and vreinterpret ACLE intrinsics

2020-02-25 Thread Mihail Ionescu
Hi, On 02/17/2020 05:53 PM, Mihail Ionescu wrote: Hi, This patch adds support for the bf16 duplicate and reinterpret intrinsics. ACLE documents are at https://developer.arm.com/docs/101028/latest ISA documents are at https://developer.arm.com/docs/ddi0596/latest Regression tested on

Re: [GCC][PATCH][AArch64] Add bfloat16 vldn/vstn intrinsics

2020-02-25 Thread Mihail Ionescu
Hi Richard, On 02/18/2020 05:06 PM, Richard Sandiford wrote: Thanks. When trying a bootstrap locally I get: include/arm_neon.h:34709:38: error: cannot convert ‘const __bf16*’ to ‘const __fp16*’ 34709 | __o = __builtin_aarch64_ld1x2v4hf ((const __builtin_aarch64_simd_bf *) __a); |

Re: [committed] libstdc++: Fix regression in std::move algorithm (PR 93872)

2020-02-25 Thread Ville Voutilainen
On Tue, 25 Feb 2020 at 15:36, Jonathan Wakely wrote: > I think what I'd really like to do is get rid of __memmove entirely. > We already have code that does the explicit assignment in a loop, for > the cases where we can't use __builtin_memmove because the type is not > trivially copyable. > > We

Re: [ARM] Fix -mpure-code for v6m

2020-02-25 Thread Kyrill Tkachov
Hi Christophe, On 2/24/20 2:16 PM, Christophe Lyon wrote: Ping? I'd also like to backport this and the main patch (svn r279463, r10-5505-ge24f6408df1e4c5e8c09785d7b488c492dfb68b3) to the gcc-9 branch. I found the problem addressed by this patch while validating the backport to gcc-9: although

Re: [committed] libstdc++: Fix regression in std::move algorithm (PR 93872)

2020-02-25 Thread Jonathan Wakely
On 25/02/20 12:40 +, Jonathan Wakely wrote: The std::move and std::move_backward algorithms dispatch to the std::__memmove helper when appropriate. That function uses a pointer-to-const for the source values, preventing them from being moved. The two callers of that function have the same

Re: [PATCH] Add c++2a binary_semaphore

2020-02-25 Thread Jonathan Wakely
On 25/02/20 12:33 +, Jonathan Wakely wrote: On 25/02/20 09:52 +0100, Sebastian Huber wrote: Hello Thomas, some operating systems provide already an implementation of binary semaphores with a compatible API, e.g. RTEMS. It would be nice if I could use it in libstdc++. I guess you don't

Re: [committed] libstdc++: Fix regression in std::move algorithm (PR 93872)

2020-02-25 Thread Jonathan Wakely
On 25/02/20 12:40 +, Jonathan Wakely wrote: The std::move and std::move_backward algorithms dispatch to the std::__memmove helper when appropriate. That function uses a pointer-to-const for the source values, preventing them from being moved. The two callers of that function have the same

Re: [PATCH] combine: Fix find_split_point handling of constant store into ZERO_EXTRACT [PR93908]

2020-02-25 Thread Segher Boessenkool
Hi! On Tue, Feb 25, 2020 at 10:10:08AM +0100, Jakub Jelinek wrote: > git is miscompiled on s390x-linux with -O2 -march=zEC12 -mtune=z13. > I've managed to reduce it into the following testcase. The problem is that > during combine we see the s->k = -1; bitfield store and change the SET_SRC >

[committed] libstdc++: Fix regression in std::move algorithm (PR 93872)

2020-02-25 Thread Jonathan Wakely
The std::move and std::move_backward algorithms dispatch to the std::__memmove helper when appropriate. That function uses a pointer-to-const for the source values, preventing them from being moved. The two callers of that function have the same problem. Rather than altering __memmove and its

Re: [PATCH] Add c++2a binary_semaphore

2020-02-25 Thread Jonathan Wakely
On 25/02/20 09:52 +0100, Sebastian Huber wrote: Hello Thomas, some operating systems provide already an implementation of binary semaphores with a compatible API, e.g. RTEMS. It would be nice if I could use it in libstdc++. I guess you don't want to have #ifdef __rtems__ stuff in this code.

Re: [Ping][PATCH][Arm] ACLE intrinsics for AdvSIMD bfloat16 dot product

2020-02-25 Thread Kyrill Tkachov
Hi Dennis, On 2/25/20 11:54 AM, Dennis Zhang wrote: Hi all, On 07/01/2020 12:12, Dennis Zhang wrote: > Hi all, > > This patch is part of a series adding support for Armv8.6-A features. > It depends on the patch enabling Arm BFmode > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01448.html > >

[Ping][PATCH][Arm] ACLE intrinsics for AdvSIMD bfloat16 dot product

2020-02-25 Thread Dennis Zhang
Hi all, On 07/01/2020 12:12, Dennis Zhang wrote: Hi all, This patch is part of a series adding support for Armv8.6-A features. It depends on the patch enabling Arm BFmode https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01448.html This patch adds intrinsics for brain half-precision float-point

Re: [patch] Fix link failure with debug info in LTO mode

2020-02-25 Thread Richard Biener
On Tue, Feb 25, 2020 at 11:36 AM Eric Botcazou wrote: > > Hi, > > this is a regression present on all active branches: the attached testcase > fails to link with debug info in LTO mode because of an undefined reference to > a symbol coming from the object files containing the early debug info. >

[PATCH] testcase for last_vuse in FRE

2020-02-25 Thread Richard Biener
This adds a testcase for some basic FRE functionality. 2020-02-25 Richard Biener * gcc.dg/tree-ssa/ssa-fre-86.c: New testcase. --- gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-86.c | 20 1 file changed, 20 insertions(+) create mode 100644

Re: [PATCH] Fix PR66552, Missed optimization when shift amount is result of signed modulus

2020-02-25 Thread Li Jia He
Hi, On 2020/2/24 4:16 PM, Marc Glisse wrote: On Mon, 24 Feb 2020, Li Jia He wrote: Hi, On 2020/2/22 11:12 PM, Marc Glisse wrote: On Tue, 18 Feb 2020, Li Jia He wrote: Also the pattern doing the standalone transform does /* Optimize TRUNC_MOD_EXPR by a power of two into a BIT_AND_EXPR,    

Re: [PATCH] issues with configure --enable-checking option

2020-02-25 Thread Roman Zhuykov
Hi, Jakub! Jakub Jelinek writes: >> +When the option is not specified, the active set of checks depends on >> context. >> +Namely, bootstrap stage 1 defaults to @samp{--enable-checking=yes}, builds >> +from release archives default to @samp{--enable-checking=release}, and > Is archives the right

Re: [PATCH] issues with configure --enable-checking option

2020-02-25 Thread Jakub Jelinek
On Tue, Feb 25, 2020 at 01:36:13PM +0300, Roman Zhuykov wrote: > Not sure how to formulate it better, just "builds from release branch or > release archives default to ..." ? "from a release branch or" or "from release branches or", otherwise LGTM. Jakub

[patch] Fix link failure with debug info in LTO mode

2020-02-25 Thread Eric Botcazou
Hi, this is a regression present on all active branches: the attached testcase fails to link with debug info in LTO mode because of an undefined reference to a symbol coming from the object files containing the early debug info. Tested on x86_64-suse-linux, OK for all active branches?

Re: [PATCH] pass_manager: Fix ICE with -fdump-passes -fdisable-tree-* [PR93874]

2020-02-25 Thread Jan Hubicka
> Hi! > > dump_passes pushes a dummy function for which it evaluates the gates > and checks whether the pass is enabled or disabled. > Unfortunately, if any -fdisable-*-*/-fenable-*-* options were seen, > we ICE during is_pass_explicitly_enabled_or_disabled because slot > is non-NULL then and the

[committed] Backports to gcc-8

2020-02-25 Thread Richard Sandiford
I've applied the following backports to gcc 8 (all approved earlier). Tested on aarch64-linux-gnu and x86_64-linux-gnu. Richard >From 7a2f576c3b40eca0a846553af5b1dfb05d84eb71 Mon Sep 17 00:00:00 2001 From: Richard Sandiford Date: Fri, 9 Aug 2019 09:37:55 + Subject: [PATCH 1/5] Reject tail

[testsuite] Update several scev/IVOPTs cases

2020-02-25 Thread Kewen.Lin
Hi, Several scev/IVOPTs cases aim to check some array references are sceved and later marked as REFERENCE ADDRESS IV groups. With IV group type dumping improving, these check strings can be improved. Otherwise, they become fragile with dumping changes. This patch is to keep check strings

[PATCH 3/4 V2 GCC11] IVOPTs Consider cost_step on different forms during unrolling

2020-02-25 Thread Kewen.Lin
Hi, As the proposed hook changes, updated this with main changes: 1) Check with addr_offset_valid_p instead. 2) Check the 1st and the last use for the whole address group. 3) Scale up group costs accordingly. Bootstrapped/regtested on powerpc64le-linux-gnu (LE). BR, Kewen ---

Re: [PATCH 2/4 GCC11] Add target hook stride_dform_valid_p

2020-02-25 Thread Kewen.Lin
on 2020/1/20 下午9:14, Segher Boessenkool wrote: > Hi! > > On Mon, Jan 20, 2020 at 10:42:12AM +, Richard Sandiford wrote: >> "Kewen.Lin" writes: >>> gcc/ChangeLog >>> >>> 2020-01-16 Kewen Lin >>> >>> * config/rs6000/rs6000.c (TARGET_STRIDE_DFORM_VALID_P): New macro. >>>

[PATCH] tree-optimization/93868 copy SLP tree before re-arranging stmts

2020-02-25 Thread Richard Biener
This avoids altering possibly shared SLP subtrees when attempting to get rid of permutations in SLP reductions by copying the SLP subtree before re-arranging stmts in it. It's a little bit awkward and some refactoring I've done for GCC11 would make this less so but it's not the point to push this

[PATCH] s390: Fix --with-arch=... --with-tune=... [PR26877]

2020-02-25 Thread Jakub Jelinek
Hi! In Fedora we configure GCC with --with-arch=zEC12 --with-tune=z13 right now and furthermore redhat-rpm-config adds to rpm packages -march=zEC12 -mtune=z13 options (among others). While looking at the git compilation, I've been surprised that -O2 actually behaves differently from -O2

Re: [PATCH] pass_manager: Fix ICE with -fdump-passes -fdisable-tree-* [PR93874]

2020-02-25 Thread Richard Biener
On Tue, 25 Feb 2020, Jakub Jelinek wrote: > Hi! > > dump_passes pushes a dummy function for which it evaluates the gates > and checks whether the pass is enabled or disabled. > Unfortunately, if any -fdisable-*-*/-fenable-*-* options were seen, > we ICE during

[PATCH] combine: Fix find_split_point handling of constant store into ZERO_EXTRACT [PR93908]

2020-02-25 Thread Jakub Jelinek
Hi! git is miscompiled on s390x-linux with -O2 -march=zEC12 -mtune=z13. I've managed to reduce it into the following testcase. The problem is that during combine we see the s->k = -1; bitfield store and change the SET_SRC from a pseudo into a constant: (set (zero_extract:DI (mem/j:HI (plus:DI

Re: [PATCH] Add c++2a binary_semaphore

2020-02-25 Thread Sebastian Huber
Hello Thomas, some operating systems provide already an implementation of binary semaphores with a compatible API, e.g. RTEMS. It would be nice if I could use it in libstdc++. I guess you don't want to have #ifdef __rtems__ stuff in this code. What about defining a binary semaphore API for

[PATCH] pass_manager: Fix ICE with -fdump-passes -fdisable-tree-* [PR93874]

2020-02-25 Thread Jakub Jelinek
Hi! dump_passes pushes a dummy function for which it evaluates the gates and checks whether the pass is enabled or disabled. Unfortunately, if any -fdisable-*-*/-fenable-*-* options were seen, we ICE during is_pass_explicitly_enabled_or_disabled because slot is non-NULL then and the code will do:

Re: [PATCH] issues with configure --enable-checking option

2020-02-25 Thread Jakub Jelinek
On Tue, Feb 25, 2020 at 11:20:58AM +0300, Roman Zhuykov wrote: > Sandra and Richard, thank you for review! > > Since 'types' checks are included into 'yes' and I addressed all other > hints, I have pushed updated patch as r10-6832. > > Jakub, Richard B, can I apply it to 8 and 9 ? Yes. > +When

Re: Dead code in fortran/simplify.c

2020-02-25 Thread Tobias Burnus
Thanks for the cleanup. Committed (with "git commit --author 'St...'" + git push) as Rev. r10-6836-gfe86f537f010828b7f77ff459cef138e84071660 Tobias On 2/25/20 1:40 AM, Steve Kargl wrote: Dead code is probably not the right description. Something like 'result that is not used' is better. In

Re: [PATCH] issues with configure --enable-checking option

2020-02-25 Thread Roman Zhuykov
Hi all! 22.02.2020 6:25, Sandra Loosemore wrote: > On 2/11/20 7:46 AM, Roman Zhuykov wrote: >> Since I have to ask again about backports, I've decided to make few more >> steps and with Alexander's help created new patch which rewords the >> whole option description and covers items (3), (4) and

[committed] c: Small diagnostics tweak - add missing ? after did you mean [PR93858]

2020-02-25 Thread Jakub Jelinek
Hi! All other diagnostic messages have ? after ; did you mean ..., but this one doesn't. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2020-02-25 Jakub Jelinek PR c/93858 * c-pragma.c (handle_pragma_diagnostic): Add

[committed] Fix typo: paramter -> parameter [PR93864]

2020-02-25 Thread Jakub Jelinek
Hi! Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2020-02-25 Jakub Jelinek PR translation/93864 * config/lm32/lm32.c (lm32_setup_incoming_varargs): Fix comment typo paramter -> parameter. * config/aarch64/aarch64.c