Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types

2020-12-16 Thread Nikhil Benesch via Gcc-patches
On 12/16/20 3:13 PM, Nikhil Benesch wrote: On 12/16/20 2:20 PM, Rainer Orth wrote: Hi Nikhil, On 12/15/20 3:00 AM, Nikhil Benesch wrote: If this patch looks good, I'll submit it upstream tomorrow. Assuming no news is good news, I sent https://go-review.googlesource.com/c/gofrontend/+/278672

Patch RFA: Support non-ASCII file names in git-changelog

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
As discussed at https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561995.html , the ChangeLog checker does not correctly handle files with non-ASCII file names. This patch fixes the problem. I have little experience with Python, so I may have made some foolish mistakes here. OK to commit?

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 16, 2020 at 8:01 PM Ian Lance Taylor wrote: > > Thanks for the pointer to git-verify. It also fails. It looks like > when the file name contains a non-ASCII character, it comes back with > quotation marks around it. That causes the test "if > path.startswith(ignored):" in git_commit

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 16, 2020 at 7:38 PM Kewen.Lin wrote: > > With the helper gcc-verify from contrib/gcc-git-customization.sh [1], > you can verify your local commit to meet required ChangeLog formats. > Does gcc-verify claim that it's ok locally? > > If no, probably you can amend the commit message with

Re: [PATCH 3/3] RISC-V: Support version controling for ISA standard extensions

2020-12-16 Thread Kito Cheng via Gcc-patches
Hi Gerald: Thanks for notifying me, we'll update that page soon :) On Tue, Dec 15, 2020 at 4:08 PM Gerald Pfeifer wrote: > > On Fri, 13 Nov 2020, Kito Cheng wrote: > > - New option -misa-spec support: -misa-spec=[2.2|20190608|20191213] and > >corresponding configuration option --with-isa-sp

Re: Go testsuite patch committed: Add some new tests

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
And another set of new tests. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian patch.txt.bz2 Description: application/bzip

Re: Go testsuite patch committed: Add some new tests

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
This patch adds some more new tests from the fixedbugs subdirectory of the source repo that currently pass with gccgo. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian patch.txt.bz2 Description: application/bzip

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Kewen.Lin via Gcc-patches
on 2020/12/17 上午11:26, Ian Lance Taylor wrote: > On Wed, Dec 16, 2020 at 6:54 PM Kewen.Lin wrote: >> >> on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: >>> On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote:

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 16, 2020 at 6:54 PM Kewen.Lin wrote: > > on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: > > On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: > >> > >> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote: > >>> > >>> I'm trying to commit a change that adds a b

PING^6 [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2020-12-16 Thread Kewen.Lin via Gcc-patches
Hi, Gentle ping^6 for: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546698.html BR, Kewen on 2020/11/19 下午1:50, Kewen.Lin via Gcc-patches wrote: > Hi, > > Gentle ping^5 for: > > https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546698.html > > BR, > Kewen > > on 2020/11/2 下午5:13, Kew

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Kewen.Lin via Gcc-patches
Hi Ian, on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: > On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: >> >> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote: >>> >>> I'm trying to commit a change that adds a bunch of new files to >>> gcc/testsuite/go.test/test. I

[PATCH] correct -Wmismatched-new-delete for template instantiations (PR 98305)

2020-12-16 Thread Martin Sebor via Gcc-patches
The -Wmismatched-new-delete detection of operator members of class template instantiations is incomplete and overly simplistic, leading to incorrect results and false positives. Rather than reinventing the wheel and parsing the mangled qualified names of the operators the attached patch uses the

Re: [x86] recompute opt flags after opt level change

2020-12-16 Thread Alexandre Oliva
Hello, Martin, On Dec 16, 2020, Martin Liška wrote: > On 10/1/19 10:58 AM, Alexandre Oliva wrote: >> + if (opts->x_flag_asynchronous_unwind_tables == 2) >> +opts->x_flag_unwind_tables >> + = opts->x_flag_asynchronous_unwind_tables = 1; > Anyway the code seems fishy, shouldn't it b

[COMMITTED] gcc: xtensa: add optimizations for shift operations

2020-12-16 Thread Max Filippov via Gcc-patches
From: Takayuki 'January June' Suwa 2020-12-16 Takayuki 'January June' Suwa gcc/ * config/xtensa/xtensa.md (*ashlsi3_1, *ashlsi3_3x, *ashrsi3_3x) (*lshrsi3_3x): New patterns. gcc/testsuite/ * gcc.target/xtensa/shifts.c: New test. --- gcc/config/xtensa/xtensa.md

Re: [20/23] rtlanal: Add simple_regno_set

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law writes: > On 11/13/20 1:21 AM, Richard Sandiford via Gcc-patches wrote: >> This patch adds a routine for finding a “simple” SET for a register >> definition. See the comment in the patch for details. >> >> gcc/ >> * rtl.h (simple_regno_set): Declare. >> * rtlanal.c (simple_regn

Re: [PATCH 23/23] fwprop: Rewrite to use RTL SSA

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law via Gcc-patches writes: > On 11/13/20 1:24 AM, Richard Sandiford via Gcc-patches wrote: >> This patch rewrites fwprop.c to use the RTL SSA framework. It tries >> as far as possible to mimic the old behaviour, even in caes where >> that doesn't fit naturally with the new framework. I've

Re: [PATCH 22/23] Add rtl-ssa

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law via Gcc-patches writes: > On 11/13/20 1:23 AM, Richard Sandiford via Gcc-patches wrote: >> This patch adds the RTL SSA infrastructure itself. The following >> fwprop.c patch will make use of it. >> >> gcc/ >> * configure.ac: Add rtl-ssa to the list of dependence directories. >>

Re: [08/23] Add an alternative splay tree implementation

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law writes: > On 11/13/20 1:15 AM, Richard Sandiford via Gcc-patches wrote: >> We already have two splay tree implementations: the old C one in >> libiberty and a templated reimplementation of it in typed-splay-tree.h. >> However, they have some drawbacks: >> >> - They hard-code the assumptio

Re: [16/23] recog: Add a way of temporarily undoing changes

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law via Gcc-patches writes: > On 11/13/20 1:19 AM, Richard Sandiford via Gcc-patches wrote: >> In some cases, it can be convenient to roll back the changes that >> have been made by validate_change to see how things looked before, >> then reroll the changes. For example, this makes it possib

Re: [07/23] Add a class that multiplexes two pointer types

2020-12-16 Thread Richard Sandiford via Gcc-patches
Martin Sebor writes: > On 11/26/20 10:06 AM, Richard Sandiford wrote: >> Martin Sebor writes: >>> I do have one concern: the tendency to prioritize efficiency >>> over safety (this can be said about most GCC code). Specifically >>> in this class, the address bit twiddling makes me uneasy. I don'

Re: [PATCH v2] Add --ld-path= to specify an arbitrary executable as the linker

2020-12-16 Thread Fāng-ruì Sòng via Gcc-patches
On Fri, Dec 4, 2020 at 5:45 AM Martin Liška wrote: > > PING > > May I please ping the patch, it's waiting here for a review > for quite some time. > > Thanks, > Martin Ping. I think Martin LGTMed this patch and was waiting for a maintainer to merge it > On 7/23/20 12:17 PM, Martin Liška wrote: >

Re: [PATCH 4/1] c++: More precise tracking of potentially unstable satisfaction

2020-12-16 Thread Patrick Palka via Gcc-patches
On Wed, 16 Dec 2020, Jason Merrill wrote: > On 12/14/20 3:29 PM, Patrick Palka wrote: > > On Mon, 14 Dec 2020, Jason Merrill wrote: > > > > > On 12/14/20 1:07 PM, Patrick Palka wrote: > > > > This makes tracking of potentially unstable satisfaction results more > > > > precise by recording the sp

[PATCH] c++tools: Fix up c++tools for --with-gcc-major-version-only

2020-12-16 Thread Jakub Jelinek via Gcc-patches
Hi! Seems c++tools doesn't honor --with-gcc-major-version-only. Our distro uses that flag and so everything is installed in /usr/lib/gcc//11/... /usr/libexec/gcc//11/... except /usr/libexec/gcc//11.0.0/g++-mapper-server The following patch should fix that, ok for trunk if it passes testing? 2020

Re: rs6000: add support for powerpc64le-unknown-freebsd

2020-12-16 Thread Segher Boessenkool
On Tue, Dec 15, 2020 at 12:29:45AM +0100, Gerald Pfeifer wrote: > > The patch looks fine. Okay for trunk. Also okay for any backports you > > want (after waiting to see if it creates problems on trunk, as usual). > > Thank you! Segher doesn't have write access, and usually I'd help out, > alas

Go testsuite patch committed: Add some new tests

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
This patch adds some new tests from the fixedbugs subdirectory of the source repo that currently pass with gccgo. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian e38c912700f001ea1c8a32533bedb4c802e38d3f diff --git a/gcc/testsuite/go.test/test/fixedbugs/bug133

Re: [PATCH] maintainer-scripts: Prefer temp dir /sourceware/snapshot-tmp/gcc for update_version_git

2020-12-16 Thread Joseph Myers
On Tue, 15 Dec 2020, Jakub Jelinek via Gcc-patches wrote: > On Mon, Dec 14, 2020 at 11:58:05PM +, Joseph Myers wrote: > > > Thanks for heads up. I'm aware of it and I don't see reason why (running > > > the > > > update script in dry mode works). > > > > https://gcc.gnu.org/pipermail/gccadmi

Re: rs6000: add support for powerpc64le-unknown-freebsd

2020-12-16 Thread Segher Boessenkool
On Tue, Dec 15, 2020 at 12:52:05AM +0100, Piotr Kubaj wrote: > Yes, there is, thanks for noticing that! > > Fixed patch attached. Hi! Could you send this as plain text? It now is quoted-printable, which is really hard to handle. Thanks! Hrm, this is really short, I'll just try to fix it by ha

[Patch] Fortran: Delay vtab generation until after parsing [PR92587]

2020-12-16 Thread Tobias Burnus
Calling gfc_find_vtab during resolution during parsing comes too early for finalizers. This patch just moves it to the resolution, which seems to be the simplest solution. (I tried way more complicated ones which do not work; thus, I settled for the simple solution ...) OK for GCC 9/10/mainline?

Re: [PATCH] add g_nonstandard_bool attribute for GIMPLE FE use

2020-12-16 Thread Joseph Myers
On Sun, 13 Dec 2020, Martin Sebor via Gcc-patches wrote: > "nonstandard" isn't a very descriptive name. The leading g_ prefix > also looks a little too terse (is that supposed to stand dor GIMPLE?). > I would suggest choosing a better name, say, bool_precision. Since Indeed, g_ suggests the GLi

Re: [C PATCH] Avoid incorrect warning for volatile in compound expressions [PR 98260]

2020-12-16 Thread Joseph Myers
On Sun, 13 Dec 2020, Uecker, Martin wrote: > Here is a patch that fixes an incorrect warning for volatile > that appeared with the lvalue change.  > > > -- Martin > > C: Avoid incorrect warning for volatile in compound expressions [PR98260] OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH 4/1] c++: More precise tracking of potentially unstable satisfaction

2020-12-16 Thread Jason Merrill via Gcc-patches
On 12/14/20 3:29 PM, Patrick Palka wrote: On Mon, 14 Dec 2020, Jason Merrill wrote: On 12/14/20 1:07 PM, Patrick Palka wrote: This makes tracking of potentially unstable satisfaction results more precise by recording the specific types for which completion failed during satisfaction. We now r

Re: [PATCH] d: Fix ICE in in force_decl_die, at dwarf2out.c with -gdwarf-2 -gstrict-dwarf [PR98067]

2020-12-16 Thread Jason Merrill via Gcc-patches
On 12/15/20 7:15 PM, Iain Buclaw wrote: Hi, This patch fixes an ICE in dwarf2out.c that occurs when compiling a selective import declaration in D with strict dwarf2 in effect. Manifest constants in D are represented as CONST_DECLs, which can be imported from one module to another. However, whe

Re: C++ 20 modules

2020-12-16 Thread Nathan Sidwell
Several issues have been fixed today: * Solaris headers 98315 (hopefully finally) * install-strip 98328 * clang offsetof 98323 (I typoed the PR in the commit) * libcody enable-checking 98311 (thanks Jakub for the followup) * source_location etc fix from Jonathan * More dashisms * detailed-mem-sta

Re: [C PATCH] Drop qualifiers of assignment expressions [PR 97981]

2020-12-16 Thread Joseph Myers
On Sun, 13 Dec 2020, Uecker, Martin wrote: > Here is a patch to drop qualifiers in assignment expressions. > > -- Martin > > > > C: Drop qualifiers of assignment expressions. [PR98047] > > ISO C17 6.5.15.1 specifies that the result is the > type the LHS would have after lvalue conversion. OK

Re: [PATCH v5] Practical Improvement to libgcc Complex Divide

2020-12-16 Thread Joseph Myers
On Thu, 10 Dec 2020, Patrick McGehearty via Gcc-patches wrote: > Thank you for your rapid feedback. > I'll fix the various formatting issues (spaces in the wrong places > and such as well as revise the Changelog magic) in the next submission. I'll await a patch with the formatting issues fixed to

[COMMITTED] gcc: xtensa: rearrange DI mode constant loading

2020-12-16 Thread Max Filippov via Gcc-patches
From: Takayuki 'January June' Suwa 2020-12-16 Takayuki 'January June' Suwa gcc/ * config/xtensa/xtensa.c (xtensa_emit_move_sequence): Try to replace 'l32r' with 'movi' + 'slli' when optimizing for size. * config/xtensa/xtensa.md (movdi): Split loading DI mode constant

[PATCH] PR fortran/98307 - Dependency check fails when using "allocatable"

2020-12-16 Thread Harald Anlauf via Gcc-patches
Dear all, since the introduction of check_forall_dependencies() we mishandled the dependencies of ALLOCATABLE components of derived types, while POINTER was dealt with. Fix that. Regtested on x86_64-pc-linux-gnu. OK for master? Since we generate wrong code under the given circumstances, what d

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2020-12-16 Thread abebeos via Gcc-patches
On Wed, 16 Dec 2020 at 22:44, abebeos wrote: [...] > And look at this: > > * 200h (estimation) for the patch > Not my work, other author(s).

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2020-12-16 Thread abebeos via Gcc-patches
+cc: Law, Biener, On Wed, 16 Dec 2020 at 20:27, Dimitar Dimitrov wrote: > On понеделник, 14 декември 2020 г. 20:53:36 EET Dimitar Dimitrov wrote: > > On петък, 11 декември 2020 г. 19:00:35 EET abebeos wrote: > > > After "digesting" a bit more your review, I need to thank you for > opening > > > m

[PATCH][AArch32] MVE: Split refactoring of remaining complex instrinsics

2020-12-16 Thread Tamar Christina via Gcc-patches
Hi All, This refactors the complex numbers bits of MVE to go through the same unspecs as the NEON variant. This is pre-work to allow code to be shared between NEON and MVE for the complex vectorization patches. Bootstrapped Regtested on arm-none-linux-gnueabihf and no issues. Codegen tested for

Re: [PATCH] genemit: Handle `const_double_zero' rtx

2020-12-16 Thread Maciej W. Rozycki
On Wed, 16 Dec 2020, Paul Koning wrote: > > NB the PDP-11 pieces affected here and tripping this assertion are I > > believe dead code, as these insns are only ever produced by splitters and > > do not appear to be referred by their names. > > Right; I gave them names for documentation purpos

[PATCH 2/2]Arm: Add NEON and MVE RTL patterns for Complex Addition.

2020-12-16 Thread Tamar Christina via Gcc-patches
Hi All, This adds implementation for the optabs for complex additions. With this the following C code: void f90 (float complex a[restrict N], float complex b[restrict N], float complex c[restrict N]) { for (int i=0; i < N; i++) c[i] = a[i] + (b[i] * I); } generates

Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types

2020-12-16 Thread Nikhil Benesch via Gcc-patches
On 12/16/20 2:20 PM, Rainer Orth wrote: Hi Nikhil, On 12/15/20 3:00 AM, Nikhil Benesch wrote: If this patch looks good, I'll submit it upstream tomorrow. Assuming no news is good news, I sent https://go-review.googlesource.com/c/gofrontend/+/278672. sorry for the delay, but unfortunately n

c++: Another solaris header use [PR 98315]

2020-12-16 Thread Nathan Sidwell
Rather than early-include sys/socket.h, let's allow the includer to tell cody no networking. libcody/ * cody.hh: Allow user to set CODY_NETWORKING. gcc/cp/ * mapper-resolver.cc: Remove early include of sys/socket.h. Specify no CODY_NETWORKING instead.

c++: Fix template parm ICE [PR 98297]

2020-12-16 Thread Nathan Sidwell
I think this is nonsense code, we seem to be naming an instantiation of a template template parm. But this fixes the ICE. Perhaps we should diagnose the issue earlier? gcc/cp/ * parser.c (cp_parser_elaborated_type_specifier): Test BOUND_TEMPLATE_TEMPLATE_PARM before che

Re: c++tools: fix install-strip [PR 98328]

2020-12-16 Thread H.J. Lu via Gcc-patches
On Wed, Dec 16, 2020 at 11:49 AM Nathan Sidwell wrote: > > > I'd missed an install-strip rule in c++tools. Here it is, cribbed > from gcc/ subdir. > > c++tools/ Missing PR other/98328 here. > * Makefile.in (INSTALL): Replace with ... > (INSTALL_PROGRAM): ... this. >

c++tools: fix install-strip [PR 98328]

2020-12-16 Thread Nathan Sidwell
I'd missed an install-strip rule in c++tools. Here it is, cribbed from gcc/ subdir. c++tools/ * Makefile.in (INSTALL): Replace with ... (INSTALL_PROGRAM): ... this. (INSTALL_STRIP_PROGRAM): New. (install-strip): New target. (install): Use INSTALL_

Re: [committed] libstdc++: Only use __builtin_sprintf if supported [PR 96083]

2020-12-16 Thread Jonathan Wakely via Gcc-patches
On 16/12/20 17:02 +, Jonathan Wakely wrote: On 16/12/20 09:23 -0700, Martin Sebor via Libstdc++ wrote: On 12/16/20 8:00 AM, Jonathan Wakely via Gcc-patches wrote: Clang doesn't support __builtin_sprintf, so use std::sprintf instead. libstdc++-v3/ChangeLog: PR libstdc++/96083

[committed] libstdc++: Warn if __STRICT_ANSI has been undefined

2020-12-16 Thread Jonathan Wakely via Gcc-patches
Recent changes to use __int128 as an integer-like type in and to optimize std::uniform_int_distribution mean that the library relies on __int128 more heavily than in the past. The library expects that if __int128 is supported then either __GLIBCXX_TYPE_INT_N_0 is defined (and we treat is like the

Re: [PATCH] doc: reflect the publication of C++20 in invoke.texi and standards.texi

2020-12-16 Thread Jonathan Wakely via Gcc-patches
On 16/12/20 19:36 +0100, Jakub Jelinek wrote: Hi! Jonathan mentioned on IRC that ISO/IEC 14882:2020 has been published yesterday (and indeed it appears on www.iso.org for sale). I think we should reflect that in our documentation and in cxx-status.html, patches attached. I understand we want to

Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types

2020-12-16 Thread Rainer Orth
Hi Nikhil, > On 12/15/20 3:00 AM, Nikhil Benesch wrote: >> If this patch looks good, I'll submit it upstream tomorrow. > > Assuming no news is good news, I sent > https://go-review.googlesource.com/c/gofrontend/+/278672. sorry for the delay, but unfortunately news is not so good: I get runtime_s

Re: [PATCH] genemit: Handle `const_double_zero' rtx

2020-12-16 Thread Paul Koning via Gcc-patches
> On Dec 16, 2020, at 6:35 AM, Maciej W. Rozycki wrote: > > ... > NB the PDP-11 pieces affected here and tripping this assertion are I > believe dead code, as these insns are only ever produced by splitters and > do not appear to be referred by their names. Right; I gave them names for do

[PATCH] configure: Extend SHF_GNU_RETAIN conftest to check for unsupported gold

2020-12-16 Thread Jozef Lawrynowicz
Since "6fbec038f7a Use SHF_GNU_RETAIN to preserve symbol definitions", GCC could create sections with the 'R' flag, which GAS would map to SHF_GNU_RETAIN. SHF_GNU_RETAIN support was not available in gold until Binutils commit ff4bc37d77, on 2020-12-14. Until the support was added, invalid binaries

[PATCH] doc: reflect the publication of C++20 in invoke.texi and standards.texi

2020-12-16 Thread Jakub Jelinek via Gcc-patches
Hi! Jonathan mentioned on IRC that ISO/IEC 14882:2020 has been published yesterday (and indeed it appears on www.iso.org for sale). I think we should reflect that in our documentation and in cxx-status.html, patches attached. I understand we want to keep C++20 support experimental even in GCC 11,

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2020-12-16 Thread Dimitar Dimitrov
On понеделник, 14 декември 2020 г. 20:53:36 EET Dimitar Dimitrov wrote: > On петък, 11 декември 2020 г. 19:00:35 EET abebeos wrote: > > After "digesting" a bit more your review, I need to thank you for opening > > my eyes re "cherrypick" suggestion and... the missing g++ summaries. I > > need > > t

Re: [committed] libstdc++: Only use __builtin_sprintf if supported [PR 96083]

2020-12-16 Thread Martin Sebor via Gcc-patches
On 12/16/20 10:04 AM, Jonathan Wakely wrote: On 16/12/20 17:02 +, Jonathan Wakely wrote: On 16/12/20 09:23 -0700, Martin Sebor via Libstdc++ wrote: On 12/16/20 8:00 AM, Jonathan Wakely via Gcc-patches wrote: Clang doesn't support __builtin_sprintf, so use std::sprintf instead. libstdc++-v

c++: Fix offsetof use [PR 98232]

2020-12-16 Thread Nathan Sidwell
offsetof is underspecified. GCC happened to accept an unneeded explicit scoping, clang does not. gcc/cp/ * module.cc (dumper::push): Clangify offsetof use. pushed -- Nathan Sidwell diff --git i/gcc/cp/module.cc w/gcc/cp/module.cc index d2806966e43..e9ea18636b4 100644 --- i/gcc

Re: [PATCH] shrink-wrap: Don't put on incoming EDGE_CROSSING [PR98289]

2020-12-16 Thread Segher Boessenkool
On Wed, Dec 16, 2020 at 06:31:35PM +0100, Jakub Jelinek wrote: > On Wed, Dec 16, 2020 at 11:17:29AM -0600, Segher Boessenkool wrote: > > It was just a bootstrap+regression check, so no new testcase was needed. > > I don't remember what target, but powerpc (32+64, BE) probably. > > I'll bootstrap/r

Re: [PATCH] shrink-wrap: Don't put on incoming EDGE_CROSSING [PR98289]

2020-12-16 Thread Jakub Jelinek via Gcc-patches
On Wed, Dec 16, 2020 at 11:17:29AM -0600, Segher Boessenkool wrote: > It was just a bootstrap+regression check, so no new testcase was needed. > I don't remember what target, but powerpc (32+64, BE) probably. I'll bootstrap/regtest the patch on powerpc64 and powerpc64le then. > > > The testcase i

Re: [PATCH] shrink-wrap: Don't put on incoming EDGE_CROSSING [PR98289]

2020-12-16 Thread Segher Boessenkool
On Wed, Dec 16, 2020 at 04:36:37PM +0100, Jakub Jelinek wrote: > On Wed, Dec 16, 2020 at 09:28:56AM -0600, Segher Boessenkool wrote: > > This used to not work, as mentioned in the original patch submission: > > https://patchwork.ozlabs.org/project/gcc/patch/52f14532eb742ac8d878a185a46a88da7b0326eb.

Re: [PATCH] libgcc: Thumb-1 Floating-Point Library for Cortex M0

2020-12-16 Thread Christophe Lyon via Gcc-patches
On Wed, 2 Dec 2020 at 04:31, Daniel Engel wrote: > > Hi Christophe, > > On Thu, Nov 26, 2020, at 1:14 AM, Christophe Lyon wrote: > > Hi, > > > > On Fri, 13 Nov 2020 at 00:03, Daniel Engel wrote: > > > > > > Hi, > > > > > > This patch adds an efficient assembly-language implementation of IEEE- > >

Re: libcody: fix --enable-checking=... [PR 98311]

2020-12-16 Thread Nathan Sidwell
On 12/16/20 10:40 AM, Jakub Jelinek wrote: On Wed, Dec 16, 2020 at 09:22:49AM -0500, Nathan Sidwell wrote: Thanks Jakub for pointing at libcpp. The -enable-checking configure code in libcody didn't play well with us. This just uses libcpp's configurey for that piece. libcody/

Re: [committed] libstdc++: Only use __builtin_sprintf if supported [PR 96083]

2020-12-16 Thread Jonathan Wakely via Gcc-patches
On 16/12/20 17:02 +, Jonathan Wakely wrote: On 16/12/20 09:23 -0700, Martin Sebor via Libstdc++ wrote: On 12/16/20 8:00 AM, Jonathan Wakely via Gcc-patches wrote: Clang doesn't support __builtin_sprintf, so use std::sprintf instead. libstdc++-v3/ChangeLog: PR libstdc++/96083

Re: [committed] libstdc++: Only use __builtin_sprintf if supported [PR 96083]

2020-12-16 Thread Jonathan Wakely via Gcc-patches
On 16/12/20 09:23 -0700, Martin Sebor via Libstdc++ wrote: On 12/16/20 8:00 AM, Jonathan Wakely via Gcc-patches wrote: Clang doesn't support __builtin_sprintf, so use std::sprintf instead. libstdc++-v3/ChangeLog: PR libstdc++/96083 * include/ext/throw_allocator.h: Use __has_bui

Re: [committed] libstdc++: Only use __builtin_sprintf if supported [PR 96083]

2020-12-16 Thread Martin Sebor via Gcc-patches
On 12/16/20 8:00 AM, Jonathan Wakely via Gcc-patches wrote: Clang doesn't support __builtin_sprintf, so use std::sprintf instead. libstdc++-v3/ChangeLog: PR libstdc++/96083 * include/ext/throw_allocator.h: Use __has_builtin to check for __builtin_sprintf support, and use

Re: [PATCH] improve caching and enhance array bounds checking

2020-12-16 Thread Martin Sebor via Gcc-patches
On 12/15/20 10:29 PM, Jeff Law wrote: On 11/11/20 6:09 PM, Martin Sebor via Gcc-patches wrote: The attached patch builds on top of the series I posted last week(*) to improve the detection of out of bounds pointers and C++ references, as well as a subset of invalid pointer relational and subtr

Re: libcody: fix --enable-checking=... [PR 98311]

2020-12-16 Thread Jakub Jelinek via Gcc-patches
On Wed, Dec 16, 2020 at 09:22:49AM -0500, Nathan Sidwell wrote: > Thanks Jakub for pointing at libcpp. > > The -enable-checking configure code in libcody didn't play well with > us. This just uses libcpp's configurey for that piece. > > libcody/ > * configure.ac:

Re: [PATCH] shrink-wrap: Don't put on incoming EDGE_CROSSING [PR98289]

2020-12-16 Thread Jakub Jelinek via Gcc-patches
On Wed, Dec 16, 2020 at 09:28:56AM -0600, Segher Boessenkool wrote: > This used to not work, as mentioned in the original patch submission: > https://patchwork.ozlabs.org/project/gcc/patch/52f14532eb742ac8d878a185a46a88da7b0326eb.1442588483.git.seg...@kernel.crashing.org/ > I wonder what changed?

Re: [PATCH] shrink-wrap: Don't put on incoming EDGE_CROSSING [PR98289]

2020-12-16 Thread Segher Boessenkool
Hi! On Wed, Dec 16, 2020 at 02:35:32PM +0100, Jakub Jelinek wrote: > As mentioned in the PR, shrink-wrapping disqualifies for prologue > placement basic blocks that have EDGE_CROSSING incoming edge. > I don't see why that is necessary, those edges seem to be redirected > just fine, both on x86_64

Re: Libcody breaks configure

2020-12-16 Thread Nathan Sidwell
On 12/16/20 3:38 AM, Kewen.Lin via Gcc-patches wrote: on 2020/12/16 下午2:35, Stott Graham via Gcc-patches wrote: If any ---checking options used The related PR PR98311[1] has been filed by David. BR, Kewen [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98311 now fixed -- Nathan Sidwell

[PATCH, OpenMP 5.0] Basic support of release/delete clauses on target/target-data directives

2020-12-16 Thread Chung-Lin Tang
Hi Jakub, we have some other sollve_vv tests for OpenMP 5.0, which tests the occurrence of 'delete' map kind on the target directive. Looking through the specification, as early as 4.5, it seems that there's no wording that release/delete map kinds are explicitly prohibited on structured block d

[PATCH, OpenMP 5.0] Allow duplicate mapping of variables

2020-12-16 Thread Chung-Lin Tang
Hi Jakub, when running sollve_vv tests (which we're trying to make work out-of-the-box), some of the 5.0 tests which were testing map clause ordering also required supporting mapping the same variable multiple times. This was not allowed before, so besides the small changes needed in the front-en

[committed] libstdc++: Only use __builtin_sprintf if supported [PR 96083]

2020-12-16 Thread Jonathan Wakely via Gcc-patches
Clang doesn't support __builtin_sprintf, so use std::sprintf instead. libstdc++-v3/ChangeLog: PR libstdc++/96083 * include/ext/throw_allocator.h: Use __has_builtin to check for __builtin_sprintf support, and use std::sprtinf if necessary. Tested powerpc64le-linux. Committ

libcody: fix --enable-checking=... [PR 98311]

2020-12-16 Thread Nathan Sidwell
Thanks Jakub for pointing at libcpp. The -enable-checking configure code in libcody didn't play well with us. This just uses libcpp's configurey for that piece. libcody/ * configure.ac: Use libcpp's enable-checking code. * configure: Rebuilt. pushing to trunk -- Nathan

Re: [PATCH] varasm: Fix up __patchable_function_entries handling

2020-12-16 Thread Jeff Law via Gcc-patches
On 12/16/20 6:47 AM, Jakub Jelinek wrote: > On Wed, Dec 16, 2020 at 05:36:04AM -0800, H.J. Lu wrote: >> gas is correct. >> >>> comdat or for retain), then we should do something like the following >>> untested change, but if it is gas bug, it should be fixed there. >>> >>> 2020-12-15 Jakub Jeli

Re: [PATCH] libcody: Fix build for older GCC versions

2020-12-16 Thread Nathan Sidwell
On 12/16/20 8:05 AM, Jonathan Wakely wrote: Before CWG DR 1955 the controlling expression for an #elif must be syntactically correct, meaning this won't compile with C++11 compilers such as gcc 4.8: The solution is to define __has_include(X) as 0 for compilers that don't support it. The second

Re: libcody: Fix for dash

2020-12-16 Thread Nathan Sidwell
On 12/16/20 5:02 AM, Richard Sandiford wrote: Nathan Sidwell writes: Apparently 'var+=...' is not a dash thing. Fixed thusly. * config.m4: Avoid non-dash idiom * configure: Rebuilt. pushed (2 patches, because I didn't look carefully enough the first time) Thanks. I think

Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types

2020-12-16 Thread Nikhil Benesch via Gcc-patches
On 12/15/20 3:00 AM, Nikhil Benesch wrote: If this patch looks good, I'll submit it upstream tomorrow. Assuming no news is good news, I sent https://go-review.googlesource.com/c/gofrontend/+/278672.

c++: Fix detailed-mem-stat breakage

2020-12-16 Thread Nathan Sidwell
module.cc has a static initializer that ends up in a circular dependency when detailed mem stats are enabled. This removes the need for that initializer to be dynamic, and we punt to the lazy initializing we already had inside the object in question anyway. At the cost of an additional indirect

Re: [PATCH] varasm: Fix up __patchable_function_entries handling

2020-12-16 Thread Jakub Jelinek via Gcc-patches
On Wed, Dec 16, 2020 at 05:36:04AM -0800, H.J. Lu wrote: > gas is correct. > > > comdat or for retain), then we should do something like the following > > untested change, but if it is gas bug, it should be fixed there. > > > > 2020-12-15 Jakub Jelinek > > > > * varasm.c (default_elf_as

[committed] libstdc++: Fix errors from Library Fundamentals TS headers in C++11 [PR 98319]

2020-12-16 Thread Jonathan Wakely via Gcc-patches
Currently the , and headers can be included in C++98 and C++11 modes, but gives errors. With this change they can be included, but define nothing. libstdc++-v3/ChangeLog: PR libstdc++/98319 * include/experimental/random: Only define contents for C++14 and later.

[committed] libstdc++: Test errno macros directly, not via autoconf [PR 93151]

2020-12-16 Thread Jonathan Wakely via Gcc-patches
This fixes a bug caused by a mismatch between the macros defined by when GCC is built and the macros defined by when users include . If the user code is compiled with _XOPEN_SOURCE defined to 500 or 600, Darwin suppresses the ENOTRECOVERABLE and EOWNERDEAD macros, which are not defined by SUSv3 (

[committed] libstdc++: Add performance test for atomic_flag [PR 46447]

2020-12-16 Thread Jonathan Wakely via Gcc-patches
This adds a test to compare the performance of std::atomic_flag with similar operations on std::atomic_uchar and std::atomic_int. libstdc++-v3/ChangeLog: PR libstdc++/46447 * testsuite/performance/29_atomics/atomic_flag.cc: New test. Tested powerpc64le-linux. Committed to trunk.

Re: [PATCH] varasm: Fix up __patchable_function_entries handling

2020-12-16 Thread H.J. Lu via Gcc-patches
On Wed, Dec 16, 2020 at 5:05 AM Jakub Jelinek wrote: > > On Wed, Dec 02, 2020 at 05:15:21AM -0800, H.J. Lu via Gcc-patches wrote: > > gcc/ > > > > PR middle-end/93195 > > PR middle-end/93197 > > * configure.ac (HAVE_GAS_SECTION_LINK_ORDER): New. Define 1 if > > the assembl

[PATCH] shrink-wrap: Don't put on incoming EDGE_CROSSING [PR98289]

2020-12-16 Thread Jakub Jelinek via Gcc-patches
Hi! As mentioned in the PR, shrink-wrapping disqualifies for prologue placement basic blocks that have EDGE_CROSSING incoming edge. I don't see why that is necessary, those edges seem to be redirected just fine, both on x86_64 and powerpc64. In the former case, they are usually conditional jumps

Re: [x86] recompute opt flags after opt level change

2020-12-16 Thread Uros Bizjak via Gcc-patches
On Wed, Dec 16, 2020 at 2:18 PM Martin Liška wrote: > > On 10/1/19 10:58 AM, Alexandre Oliva wrote: > > + if (opts->x_flag_asynchronous_unwind_tables == 2) > > + opts->x_flag_unwind_tables > > + = opts->x_flag_asynchronous_unwind_tables = 1; > > Hello. > > Spotted that when I tried

Re: [PATCH] genemit: Handle `const_double_zero' rtx

2020-12-16 Thread Maciej W. Rozycki
On Wed, 16 Dec 2020, Richard Sandiford wrote: > >> Presumably you can't use CONST0_RTX (mode) here?  Assuming that's the > >> case, then this is fine. > > > > Well, `mode' is VOID for simplicity and to match what the middle end > > presents as an operand to the COMPARE operation, as also shown w

[PATCH] doc: Document that libstdc++ uses __STRICT_ANSI__

2020-12-16 Thread Jonathan Wakely via Gcc-patches
Libstdc++ has been using __STRICT_ANSI__ for years, e.g. to decide whether or not std::is_integral<__int128> should be true. gcc/ChangeLog: * doc/cpp.texi (Common Predefined Macros): Mention that __STRICT_ANSI__ is used by libstdc++ too. OK for trunk? I'd also like to tell users

Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-16 Thread Rainer Orth
Hi Pierre-Marie, > On Wed, Dec 16, 2020 at 1:18 PM Pierre-Marie de Rodat > wrote: >> Thank you. I can reproduce the issue: at this point I suspect that my >> testing hasn’t detected this because of some inconsistency with my >> incremental builds. The actual correction is a few patches later in m

Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-16 Thread Pierre-Marie de Rodat
On Wed, Dec 16, 2020 at 1:18 PM Pierre-Marie de Rodat wrote: > Thank you. I can reproduce the issue: at this point I suspect that my > testing hasn’t detected this because of some inconsistency with my > incremental builds. The actual correction is a few patches later in my > porting queue: I’m ab

c++tools: Fix (an) install issue

2020-12-16 Thread Nathan Sidwell
David reported an AIX problem, which I think this addresses. I've not looked at pr98314 yet but there's certainly overlap This fixes installers that don't understand -p. c++tools/ (install): Do not use -p, use mkinstalldirs. (clean): Fix typo. pushing to trunk -- Natha

Re: [x86] recompute opt flags after opt level change

2020-12-16 Thread Martin Liška
On 10/1/19 10:58 AM, Alexandre Oliva wrote: + if (opts->x_flag_asynchronous_unwind_tables == 2) + opts->x_flag_unwind_tables + = opts->x_flag_asynchronous_unwind_tables = 1; Hello. Spotted that when I tried to make x_flag_asynchronous_unwind_tables a boolean flag. Anyway t

[Ada] armhf-linux: symbolic tracebacks

2020-12-16 Thread Pierre-Marie de Rodat
Implement symbolic tracebacks on armhf-linux. It's an ELF target so just a matter of some bookkeeping changes. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/s-objrea.ads (Object_Arch): Add ARM enum * libgnat/s-objrea.adb (Initialize): Add EM_ARM case.

[Ada] Handle iterator filters on loop specifications over containers

2020-12-16 Thread Pierre-Marie de Rodat
A loop parameter specification over a container is rewrtten as an iterator specification, so that expansion can use the Iterator opwrations declared for the container type. If an Ada2020 interator filter appears on the loop_parameter_specification it must be transfered to the iterator, and preanaly

[Ada] Add contracts to Ada.Strings.Fixed

2020-12-16 Thread Pierre-Marie de Rodat
This adds complete postconditions and contract cases to subprograms in Ada.Strings.Fixed. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/a-strfix.ads: Add postconditions and contract cases to subprograms. patch.diff.gz Description: application/gzip

[Ada] Code cleanup: rename ALI.Scope

2020-12-16 Thread Pierre-Marie de Rodat
Rename it to IS_Scope so that calling scope (node) under gdb is unambiguous, so ease debugging sessions. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * ali.ads, ali.adb, bindo-writers.adb, lib-writ.adb (Scope): Renamed to IS_Scope.diff --git a/gcc/ada/ali.adb b/gcc/

[Ada] Simplify membership tests with N_Delay_Statement subtype

2020-12-16 Thread Pierre-Marie de Rodat
Simplify membership test on N_Delay_Relative_Statement and N_Delay_Until_Statement using the collective N_Delay_Statement subtype. Cleanup only; semantics is unaffected. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * exp_ch9.adb, sem_warn.adb: Simplify membership test.diff

[Ada] Fix typo in checks for implementation defined units

2020-12-16 Thread Pierre-Marie de Rodat
Fix mismatch in iterating over a range for Ada 2012 and referencing an array for Ada 95. This didn't affect the behaviour, because the referenced boolean flags in both arrays were the same for the iterated subrange. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * impunit.adb

[Ada] Remove inconsistent colons in messages for Ada 83 violations

2020-12-16 Thread Pierre-Marie de Rodat
Most of the errors of the form "(Ada 83) ..." don't have a colon; fix inconsistencies. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * par-ch3.adb (P_Modular_Type_Definition): Remove colon from error message. * sem_ch11.adb (Check_Duplication): Likewise.

[Ada] Fix memory leak in GNAT.Expect.Non_Blocking_Spawn on Windows

2020-12-16 Thread Pierre-Marie de Rodat
It is not leaking on Linux because the memory heap is reinitialized when the new executable is loaded into the child process after calling fork. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/g-expect.adb (Non_Blocking_Spawn): Deallocate elements on Arg_List

  1   2   >