Re: [PATCH] PR tree-optimization/101403: Incorrect folding of ((T)bswap(x))>>C

2021-07-11 Thread Richard Biener via Gcc-patches
On Sun, Jul 11, 2021 at 11:48 AM Roger Sayle wrote: > > > My sincere apologies for the breakage. My recent patch to fold > bswapN(x)>>C where the constant C was large enough that the result > only contains bits from the low byte, and can therefore avoid > the byte swap contains a minor logic erro

Re: [PATCH 10/10] vect: Reuse reduction accumulators between loops

2021-07-11 Thread Richard Biener via Gcc-patches
On Fri, Jul 9, 2021 at 3:12 PM Richard Sandiford wrote: > > Thanks for the review. > > Richard Biener writes: > >> @@ -588,6 +600,23 @@ public: > >>/* Unrolling factor */ > >>poly_uint64 vectorization_factor; > >> > >> + /* If this loop is an epilogue loop whose main loop can be skipped

Re: [PATCH v3 1/2] Add -f[no-]direct-extern-access

2021-07-11 Thread Fāng-ruì Sòng via Gcc-patches
> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c > index cff26909292..7dee311051d 100644 > --- a/gcc/config/i386/i386.c > +++ b/gcc/config/i386/i386.c > @@ -10312,13 +10312,17 @@ darwin_local_data_pic (rtx disp) > } > > /* True if the function symbol operand X should be loaded from

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-11 Thread Richard Biener
On Fri, 9 Jul 2021, Segher Boessenkool wrote: > On Fri, Jul 09, 2021 at 08:43:59AM +0200, Richard Biener wrote: > > I wonder if there's a way to query the target what modes the doloop > > pattern can handle (not being too familiar with the doloop code). > > You can look what modes are allowed for

Re: [PATCH] Change the type of memory classification functions to bool

2021-07-11 Thread Richard Biener via Gcc-patches
On Fri, Jul 9, 2021 at 5:07 PM Uros Bizjak via Gcc-patches wrote: > > 2021-07-09 Uroš Bizjak > > gcc/ > * recog.c (memory_address_addr_space_p): Change the type to bool. > Return true/false instead of 1/0. > (offsettable_memref_p): Ditto. > (offsettable_nonstrict_memref_p): Ditt

Re: [PATCH v3 1/2] Add -f[no-]direct-extern-access

2021-07-11 Thread Richard Biener via Gcc-patches
On Fri, Jul 9, 2021 at 4:50 PM H.J. Lu wrote: > > -fdirect-extern-access is the default. With -fno-direct-extern-access: > > 1. Always use GOT to access undefined data and function symbols, >including in PIE and non-PIE. These will avoid copy relocations >in executables. This is compati

Re: [PATCH v2] docs: Add 'S' to Machine Constraints for RISC-V

2021-07-11 Thread Fangrui Song
On 2021-07-12, Kito Cheng wrote: It was undocument before, but it might used in linux kernel for resolve code model issue, so LLVM community suggest we should document that, so that make it become supported/documented/non-internal machine constraints. gcc/ChangeLog: PR target/101275

[PATCH v2] docs: Add 'S' to Machine Constraints for RISC-V

2021-07-11 Thread Kito Cheng
It was undocument before, but it might used in linux kernel for resolve code model issue, so LLVM community suggest we should document that, so that make it become supported/documented/non-internal machine constraints. gcc/ChangeLog: PR target/101275 * config/riscv/constraints.md

Re: [PATCH] rs6000: Fix restored rs6000_long_double_type_size.

2021-07-11 Thread Martin Liška
PING^1 On 6/28/21 2:19 PM, Martin Liška wrote: On 6/24/21 12:46 AM, Segher Boessenkool wrote: Hi! On Wed, Jun 23, 2021 at 03:22:34PM +0200, Martin Liška wrote: As mentioned in the "Fallout: save/restore target options in handle_optimize_attribute" thread, we need to support target option rest

Re: Ping ^ 2: [PATCH] rs6000: Expand fmod and remainder when built with fast-math [PR97142]

2021-07-11 Thread Xionghu Luo via Gcc-patches
On 2021/7/10 02:40, will schmidt wrote: > On Wed, 2021-06-30 at 09:44 +0800, Xionghu Luo via Gcc-patches wrote: >> Gentle ping ^2, thanks. >> >> https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568143.html >> >> >> On 2021/5/14 15:13, Xionghu Luo via Gcc-patches wrote: >>> Test SPEC2017 Ofas

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Mike, On 7/7/21 3:04 PM, Michael Meissner wrote: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10. This patch updates the vector long long multiply and divide tests to supply the correct code information if power10 code generation is used. 2021-07-07 Michael Meissne

Re: Repost: [PATCH] PR 100170: Fix eq/ne tests on power10.

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Mike, ENOPATCH Thanks, Bill :-) On 7/7/21 3:06 PM, Michael Meissner wrote: [PATCH] PR 100170: Fix eq/ne tests on power10. This patch updates eq/ne tests in the testsuite to adjust the test if power10 code generation is used. I have verified that these tests run on a power10 system using t

Re: Repost: [PATCH] PR 100168: Fix call test on power10.

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Mike, LGTM.  I can't approve, but recommend approval. Thanks, Bill On 7/7/21 3:08 PM, Michael Meissner wrote: [PATCH] PR 100168: Fix call test on power10. Fix a test that was checking for 64-bit TOC calls, to also allow for PC-relative calls. I have verified that this test passes when run

Re: [PATCH 2/2] rs6000: Add tests for SSE4.1 "floor" intrinsics

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Paul, On 7/6/21 5:50 PM, Paul A. Clarke via Gcc-patches wrote: Add the tests for _mm_floor_pd, _mm_floor_ps, _mm_floor_sd, _mm_floor_ss. These are modelled after (and depend upon parts of) the tests for _mm_ceil intrinsics, recently posted. Copy a test for _mm_floor_sd from gcc/testsuite/gcc

Re: [PATCH 1/2] rs6000: Add support for SSE4.1 "floor" intrinsics

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Paul, On 7/6/21 5:50 PM, Paul A. Clarke via Gcc-patches wrote: 2021-07-06 Paul A. Clarke gcc/ChangeLog: * config/rs6000/smmintrin.h (_mm_floor_pd, _mm_floor_ps, _mm_floor_sd, _mm_floor_ss): New. --- gcc/config/rs6000/smmintrin.h | 28 1 file

Re: [PATCH 2/2] rs6000: Add tests for SSE4.1 "ceil" intrinsics

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Paul, On 7/1/21 9:11 PM, Paul A. Clarke via Gcc-patches wrote: Add the tests for _mm_ceil_pd, _mm_ceil_ps, _mm_ceil_sd, _mm_ceil_ss. Copy a test for _mm_ceil_pd and _mm_ceil_ps from gcc/testsuite/gcc.target/i386. Define __VSX_SSE2__ to pick up some union definitons in typo ("definitions").

Re: [PATCH 1/2] rs6000: Add support for SSE4.1 "ceil" intrinsics

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Paul, On 7/1/21 9:11 PM, Paul A. Clarke via Gcc-patches wrote: 2021-07-01 Paul A. Clarke gcc/ChangeLog: * config/rs6000/smmintrin.h (_mm_ceil_pd, _mm_ceil_ps, _mm_ceil_sd, _mm_ceil_ss): New. --- gcc/config/rs6000/smmintrin.h | 28 1 file cha

Re: [committed] input.c: move file caching globals to a new file_cache class

2021-07-11 Thread Lewis Hyatt via Gcc-patches
Hi David- I thought this might be a good opportunity to ask about the patch that supports -finput-charset in diagnostic.c please? https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564527.html The patch will require some work to adapt to the new changes below. I am happy to do that, but thoug

Re: [PATCH 3/4] rs6000: Add support for SSE4.1 "blend" intrinsics

2021-07-11 Thread Bill Schmidt via Gcc-patches
On 7/11/21 11:17 AM, Bill Schmidt wrote: Hi Paul, On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: _mm_blend_epi16 and _mm_blendv_epi8 were added earlier. Add these four to complete the set. 2021-06-29  Paul A. Clarke  gcc/ChangeLog: * config/rs6000/smmintrin.h (_mm_blend_pd, _m

Re: [PATCH 4/4] rs6000: Add tests for SSE4.1 "blend" intrinsics

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Paul, Please resubmit this when you resubmit 3/4, in case any adjustments are needed. Thanks! Bill On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: Copy the tests for _mm_blend_pd, _mm_blendv_pd, _mm_blend_ps, _mm_blendv_ps from gcc/testsuite/gcc.target/i386. 2021-06-29 Paul A.

Re: [PATCH 3/4] rs6000: Add support for SSE4.1 "blend" intrinsics

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Paul, On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: _mm_blend_epi16 and _mm_blendv_epi8 were added earlier. Add these four to complete the set. 2021-06-29 Paul A. Clarke gcc/ChangeLog: * config/rs6000/smmintrin.h (_mm_blend_pd, _mm_blendv_pd, _mm_blend_ps, _mm

Re: [PATCH 2/4] rs6000: Add tests for SSE4.1 "test" intrinsics

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Paul, LGTM.  I can't approve, but recommend approval as is. Thanks, Bill On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: Copy the test for _mm_testz_si128, _mm_testc_si128, _mm_testnzc_si128, _mm_test_all_ones, _mm_test_all_zeros, _mm_test_mix_ones_zeros from gcc/testsuite/gcc.tar

Re: [PATCH 1/4] rs6000: Add support for SSE4.1 "test" intrinsics

2021-07-11 Thread Bill Schmidt via Gcc-patches
Hi Paul, On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: 2021-06-29 Paul A. Clarke gcc/ChangeLog: * config/rs6000/smmintrin.h (_mm_testz_si128, _mm_testc_si128, _mm_testnzc_si128, _mm_test_all_ones, _mm_test_all_zeros, _mm_test_mix_ones_zeros): New. --- g

[PATCH] x86: Don't enable UINTR in 32-bit mode

2021-07-11 Thread H.J. Lu via Gcc-patches
UINTR is available only in 64-bit mode. Since the codegen target is unknown when the the gcc driver is processing -march=native, to properly handle UINTR for -march=native: 1. Add an undocumented option, -muintr-native. 2. Update the gcc driver to pass -muintr-native with -march=native if UINTR i

[PATCH V2] coroutines: Adjust outlined function names [PR95520].

2021-07-11 Thread Iain Sandoe
Hi Jason, > On 9 Jul 2021, at 22:40, Jason Merrill wrote: > > On 7/9/21 2:18 PM, Iain Sandoe wrote: > How about handling this in write_encoding, along the lines of the > devel/c++-contracts branch? OK, so I took a look at this and implemented as below. Some small differences from your cont

[PATCH] PR tree-optimization/101403: Incorrect folding of ((T)bswap(x))>>C

2021-07-11 Thread Roger Sayle
My sincere apologies for the breakage. My recent patch to fold bswapN(x)>>C where the constant C was large enough that the result only contains bits from the low byte, and can therefore avoid the byte swap contains a minor logic error. The pattern contains a convert? allowing an extension to occ