Re: [PATCH 1/2] arm: Fix vcond_mask expander for MVE (PR target/100757)

2021-07-13 Thread Christophe Lyon via Gcc-patches
Ping? Le ven. 2 juil. 2021 à 10:53, Christophe Lyon a écrit : > Hi, > > On Wed, 9 Jun 2021 at 17:04, Richard Sandiford > wrote: > > > > Christophe Lyon writes: > > > The problem in this PR is that we call VPSEL with a mask of vector > > > type instead

Re: PING 2 [PATCH] correct handling of variable offset minus constant in -Warray-bounds (PR 100137)

2021-07-08 Thread Christophe Lyon via Gcc-patches
On Thu, 8 Jul 2021 at 12:42, Andreas Schwab wrote: > > On Jul 07 2021, Marek Polacek via Gcc-patches wrote: > > > On Wed, Jul 07, 2021 at 02:38:11PM -0600, Martin Sebor via Gcc-patches > > wrote: > >> I certainly will. Pushed in r12-2132. > > > > I think this patch breaks bootstrap on x86_64: >

Re: [PATCH] testsuite: Add arm_arch_v7a_ok effective-target to pr57351.c

2021-07-07 Thread Christophe Lyon via Gcc-patches
ping? On Wed, Jun 30, 2021 at 3:58 PM Christophe LYON via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > I've noticed that overriding cpu/arch flags when running the testsuite > can cause this test to fail rather than being skipped because of > incompatible flags combination

Re: [PATCH 4/4] remove %G and %K support from pretty printer and -Wformat (PR 98512)

2021-07-07 Thread Christophe Lyon via Gcc-patches
On Wed, Jul 7, 2021 at 11:38 AM Andreas Schwab wrote: > This broke bootstrap on aarch64. > > This is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101363 Christophe > Andreas. > > -- > Andreas Schwab, sch...@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA A

Re: [ARM] PR98435: Missed optimization in expanding vector constructor

2021-07-06 Thread Christophe Lyon via Gcc-patches
On Tue, 6 Jul 2021 at 11:28, Kyrylo Tkachov via Gcc-patches wrote: > > > > > -Original Message- > > From: Prathamesh Kulkarni > > Sent: 06 July 2021 10:25 > > To: Kyrylo Tkachov > > Cc: Christophe LYON ; gcc Patches > patc...@gcc.gnu.o

[COMMITTED] [PATCH] testsuite: gcc.dg/debug/btf/btf-bitfields-3.c requires -fno-short-enums PR debug/101321

2021-07-05 Thread Christophe LYON - foss via Gcc-patches
arm-eabi uses -fshort-enums by default while arm-linux-gnueabi* do not, like most (all?) other targets, but this test relies -fno-short-enums. Fix it by forcing -fno-short-enums. 2021-07-05 Christophe Lyon PR debug/101321 gcc/testsuite/ * gcc.dg/debug/btf/btf-bitfields

Re: [PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Christophe Lyon via Gcc-patches
On Fri, Jul 2, 2021 at 4:29 PM Jakub Jelinek via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > On Fri, Jul 02, 2021 at 05:20:33PM +0300, Maxim Kuvyrkov wrote: > > Hi Jakub, > > > > Thanks for helping me on IRC with debugging testsuite problems. Does > this write up look good? > > Hi Maxim, Than

Re: [PATCH 1/2] arm: Fix vcond_mask expander for MVE (PR target/100757)

2021-07-02 Thread Christophe Lyon via Gcc-patches
On Fri, 2 Jul 2021 at 10:53, Christophe Lyon wrote: > > Hi, > > On Wed, 9 Jun 2021 at 17:04, Richard Sandiford > wrote: > > > > Christophe Lyon writes: > > > The problem in this PR is that we call VPSEL with a mask of vector > > > type instead

Re: [PATCH 1/2] arm: Fix vcond_mask expander for MVE (PR target/100757)

2021-07-02 Thread Christophe Lyon via Gcc-patches
Hi, On Wed, 9 Jun 2021 at 17:04, Richard Sandiford wrote: > > Christophe Lyon writes: > > The problem in this PR is that we call VPSEL with a mask of vector > > type instead of HImode. This happens because operand 3 in vcond_mask > > is the pre-computed vector compar

Re: [PATCH 3/4] remove %K from error() calls in the aarch64/arm back ends (PR 98512)

2021-07-01 Thread Christophe LYON via Gcc-patches
On 30/06/2021 21:56, Martin Sebor via Gcc-patches wrote: On 6/11/21 8:46 AM, Martin Sebor wrote: On 6/11/21 3:58 AM, Richard Sandiford wrote: Martin Sebor via Gcc-patches writes: diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 7b37e1b602c..7cdc824730c 100644 --- a/gcc/config/

Re: [ARM] PR98435: Missed optimization in expanding vector constructor

2021-06-30 Thread Christophe LYON via Gcc-patches
On 29/06/2021 12:46, Prathamesh Kulkarni wrote: On Mon, 28 Jun 2021 at 14:48, Christophe LYON wrote: On 28/06/2021 10:40, Kyrylo Tkachov via Gcc-patches wrote: -Original Message- From: Prathamesh Kulkarni Sent: 28 June 2021 09:38 To: Kyrylo Tkachov Cc: Christophe Lyon ; gcc

[PATCH] testsuite: Add arm_arch_v7a_ok effective-target to pr57351.c

2021-06-30 Thread Christophe LYON via Gcc-patches
06-30  Christophe Lyon      gcc/testsuite/     * gcc.dg/debug/pr57351.c: Require arm_arch_v7a_ok     effective-target. From f49096dc6925a0b28785debdee8fdc323e4f6e82 Mon Sep 17 00:00:00 2001 From: Christophe Lyon Date: Wed, 30 Jun 2021 13:47:07 + Subject: [PATCH] testsuite

Re: [COMMITTED V10 4/7] CTF/BTF testsuites

2021-06-30 Thread Christophe Lyon via Gcc-patches
Hi, I have just committed the following small patch as obvious: Author: Christophe Lyon Date: Wed Jun 30 11:44:00 2021 + [testsuite]: Add missing dg-add-options float16 to gcc.dg/debug/ctf/ctf-skip-types-2.c The test already checks dg-require-effective-target float16, but this

Re: [Patch] Add 'default' to -foffload=; document that flag [PR67300]

2021-06-29 Thread Christophe Lyon via Gcc-patches
On Tue, Jun 29, 2021 at 10:48 PM Rainer Orth wrote: > Hi Tobias, > > > On 29.06.21 13:58, Jakub Jelinek wrote: > > > >> Also, wonder if we shouldn't print the list of configured targets in > that > >> case, see candidates_list_and_hint functions and its callers. > >> And it is unclear why we use

Re: [committed] libstdc++: More workarounds in 17_intro/names.cc test [PR 97088]

2021-06-28 Thread Christophe LYON via Gcc-patches
On 28/06/2021 17:26, Jonathan Wakely wrote: On Mon, 28 Jun 2021 at 15:20, Jonathan Wakely wrote: On Mon, 28 Jun 2021 at 12:56, Christophe LYON wrote: On 25/06/2021 21:51, Jonathan Wakely via Libstdc++ wrote: Conditionally #undef some more names that are used in system headers. libstdc

Re: [committed] libstdc++: More workarounds in 17_intro/names.cc test [PR 97088]

2021-06-28 Thread Christophe LYON via Gcc-patches
On 25/06/2021 21:51, Jonathan Wakely via Libstdc++ wrote: Conditionally #undef some more names that are used in system headers. libstdc++-v3/ChangeLog: PR libstdc++/97088 * testsuite/17_intro/names.cc: Undef more names for newlib and also for arm-none-linux-gnueabi.

Re: [ARM] PR98435: Missed optimization in expanding vector constructor

2021-06-28 Thread Christophe LYON via Gcc-patches
On 28/06/2021 10:40, Kyrylo Tkachov via Gcc-patches wrote: -Original Message- From: Prathamesh Kulkarni Sent: 28 June 2021 09:38 To: Kyrylo Tkachov Cc: Christophe Lyon ; gcc Patches Subject: Re: [ARM] PR98435: Missed optimization in expanding vector constructor On Thu, 24 Jun

Re: [PATCH v3] libstdc++: Improve std::lock algorithm

2021-06-23 Thread Christophe LYON via Gcc-patches
On 23/06/2021 12:11, Jonathan Wakely wrote: On Wed, 23 Jun 2021 at 10:43, Christophe LYON wrote: On 23/06/2021 11:17, Jonathan Wakely via Libstdc++ wrote: On Wed, 23 Jun 2021 at 08:21, Christophe Lyon wrote: This patch causes GCC build failures for bare-metal targets (aarch64-elf, arm-eabi

Re: [PATCH v3] libstdc++: Improve std::lock algorithm

2021-06-23 Thread Christophe Lyon via Gcc-patches
Hi Jonathan, On Tue, 22 Jun 2021 at 22:34, Jonathan Wakely via Gcc-patches wrote: > > On Tue, 22 Jun 2021 at 20:51, Jonathan Wakely wrote: > > > > On Tue, 22 Jun 2021 at 17:03, Matthias Kretz wrote: > > > > > > On Dienstag, 22. Juni 2021 17:20:41 CEST Jonathan Wakely wrote: > > > > On Tue, 22 Ju

Re: [PATCH 3/6] return auto_vec from get_loop_hot_path

2021-06-17 Thread Christophe Lyon via Gcc-patches
On Thu, Jun 17, 2021 at 4:53 PM Trevor Saunders wrote: > On Thu, Jun 17, 2021 at 03:48:28PM +0200, Christophe Lyon wrote: > > On Tue, 15 Jun 2021 at 08:47, Richard Biener via Gcc-patches > > wrote: > > > > > > On Tue, Jun 15, 2021 at 8:01 AM Trevor Saunde

Re: [PATCH 3/6] return auto_vec from get_loop_hot_path

2021-06-17 Thread Christophe Lyon via Gcc-patches
On Tue, 15 Jun 2021 at 08:47, Richard Biener via Gcc-patches wrote: > > On Tue, Jun 15, 2021 at 8:01 AM Trevor Saunders wrote: > > > > This ensures callers take ownership of the returned vector. > > > > Signed-off-by: Trevor Saunders > > > > bootstrapped and regtested on x86_64-linux-gnu, ok? >

Re: [committed] analyzer: bitfield fixes [PR99212]

2021-06-17 Thread Christophe Lyon via Gcc-patches
On Wed, 16 Jun 2021 at 00:03, David Malcolm wrote: > > On Wed, 2021-06-09 at 11:00 -0400, David Malcolm wrote: > > On Wed, 2021-06-09 at 16:17 +0200, Christophe Lyon wrote: > > > On Tue, 8 Jun 2021 at 21:34, David Malcolm via Gcc-patches > > > wrote: > >

Re: [PATCH] teach compute_objsize about placement new (PR 100876)

2021-06-15 Thread Christophe Lyon via Gcc-patches
Hi, On Tue, 15 Jun 2021 at 00:58, Martin Sebor via Gcc-patches wrote: > > On 6/2/21 3:46 PM, Marek Polacek wrote: > > On Wed, Jun 02, 2021 at 03:40:49PM -0600, Martin Sebor via Gcc-patches > > wrote: > >> + if (!gimple_call_builtin_p (stmt, BUILT_IN_NORMAL)) > >> +{ > >> + /* See if th

Re: [PATCH 2/2] arm: Auto-vectorization for MVE: add pack/unpack patterns

2021-06-14 Thread Christophe Lyon via Gcc-patches
On Mon, 14 Jun 2021 at 18:01, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Fri, 11 Jun 2021 at 18:25, Richard Sandiford > > wrote: > >> > >> Christophe Lyon writes: > >> > Thanks for the feedback. How about v2 attached? &g

Re: [PATCH 2/2] arm: Auto-vectorization for MVE: add pack/unpack patterns

2021-06-14 Thread Christophe Lyon via Gcc-patches
On Fri, 11 Jun 2021 at 18:25, Richard Sandiford wrote: > > Christophe Lyon writes: > > Thanks for the feedback. How about v2 attached? > > Do you want me to merge neon_vec_unpack and > > mve_vec_unpack and only have different assembly? > > if (TARGET_HAVE_MVE) &g

Re: [committed] libstdc++: Fix filesystem::path comparisons for C++23

2021-06-14 Thread Christophe Lyon via Gcc-patches
Hi Jonathan, On Fri, 11 Jun 2021 at 20:25, Jonathan Wakely via Gcc-patches wrote: > > In C++23 there is a basic_string_view(Range&&) constructor, which is > constrained to take a range (specifically, a contiguous_range). When the > filesystem::path comparison operators call lhs.compare(rhs) the o

Re: [PATCH 2/2] arm: Auto-vectorization for MVE: add pack/unpack patterns

2021-06-11 Thread Christophe Lyon via Gcc-patches
On Fri, 11 Jun 2021 at 12:20, Richard Sandiford wrote: > > Christophe Lyon writes: > > In the meantime, I tried to make some progress, and looked at how > > things work on aarch64. > > > > This led me to define (in mve.md): > > > > (define_insn "@mv

Re: [PATCH 3/4] remove %K from error() calls in the aarch64/arm back ends (PR 98512)

2021-06-11 Thread Christophe Lyon via Gcc-patches
On Fri, 11 Jun 2021 at 09:53, Christophe Lyon wrote: > > On Fri, 11 Jun 2021 at 01:29, Martin Sebor via Gcc-patches > wrote: > > > > This patch removes the uses of %K from error() calls in the aarch64 > > and arm back ends. I tested this change only by building a cros

Re: [PATCH 2/2] arm: Auto-vectorization for MVE: add pack/unpack patterns

2021-06-11 Thread Christophe Lyon via Gcc-patches
On Fri, 11 Jun 2021 at 11:38, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Tue, 8 Jun 2021 at 14:10, Richard Sandiford > > wrote: > >> > >> Christophe Lyon writes: > >> > This patch adds vec_unpack_hi_, vec_unpack_lo_, > >

Re: [PATCH 3/4] remove %K from error() calls in the aarch64/arm back ends (PR 98512)

2021-06-11 Thread Christophe Lyon via Gcc-patches
On Fri, 11 Jun 2021 at 01:29, Martin Sebor via Gcc-patches wrote: > > This patch removes the uses of %K from error() calls in the aarch64 > and arm back ends. I tested this change only by building a cross- > compiler but I can't easily run the tests so I'd appreciate some help > validating it. T

Re: [PATCH 2/2] arm: Auto-vectorization for MVE: add pack/unpack patterns

2021-06-10 Thread Christophe Lyon via Gcc-patches
On Thu, 10 Jun 2021 at 11:50, Christophe Lyon wrote: > > On Tue, 8 Jun 2021 at 14:10, Richard Sandiford > wrote: > > > > Christophe Lyon writes: > > > This patch adds vec_unpack_hi_, vec_unpack_lo_, > > > vec_pack_trunc_ patterns for MVE. > > >

Re: [PATCH 2/2] arm: Auto-vectorization for MVE: add pack/unpack patterns

2021-06-10 Thread Christophe Lyon via Gcc-patches
On Tue, 8 Jun 2021 at 14:10, Richard Sandiford wrote: > > Christophe Lyon writes: > > This patch adds vec_unpack_hi_, vec_unpack_lo_, > > vec_pack_trunc_ patterns for MVE. > > > > It does so by moving the unpack patterns from neon.md to > > vec-common.md, wh

Re: [PATCH] tree-optimization/97832 - handle associatable chains in SLP discovery

2021-06-09 Thread Christophe Lyon via Gcc-patches
On Wed, 9 Jun 2021 at 18:56, Alex Coplan via Gcc-patches wrote: > > Hi Richi, > > On 09/06/2021 14:42, Richard Biener via Gcc-patches wrote: > > On Mon, May 31, 2021 at 5:00 PM Richard Biener wrote: > > > > > > This makes SLP discovery handle associatable (including mixed > > > plus/minus) chains

Re: [PATCH] arm: Auto-vectorization for MVE and Neon: vhadd/vrhadd

2021-06-09 Thread Christophe Lyon via Gcc-patches
On Wed, 9 Jun 2021 at 17:39, Richard Sandiford wrote: > > Christophe Lyon writes: > > This patch adds support for auto-vectorization of average value > > computation using vhadd or vrhadd, for both MVE and Neon. > > > > The patch adds the needed [u]avg3_[floor|ceil]

Re: [PATCH 1/2] arm: Auto-vectorization for MVE: vclz

2021-06-09 Thread Christophe Lyon via Gcc-patches
On Tue, 8 Jun 2021 at 13:58, Richard Sandiford wrote: > > Christophe Lyon writes: > > This patch adds support for auto-vectorization of clz for MVE. > > > > It does so by removing the unspec from mve_vclzq_ and uses > > 'clz' instead. It moves to ne

Re: [PATCH] arm: Auto-vectorization for MVE and Neon: vhadd/vrhadd

2021-06-09 Thread Christophe Lyon via Gcc-patches
On Tue, 8 Jun 2021 at 13:50, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Wed, 2 Jun 2021 at 20:19, Richard Sandiford > > wrote: > >> > >> Christophe Lyon writes: > >> > This patch adds support for auto-vectorization of average val

Re: [PATCH] libstdc++: Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889]

2021-06-09 Thread Christophe Lyon via Gcc-patches
Hi, On Wed, 9 Jun 2021 at 01:05, Thomas Rodgers via Gcc-patches wrote: > > Tested x86_64-pc-linux-gnu, committed to master, backported to > releases/gcc-11. > > On Tue, Jun 8, 2021 at 8:44 AM Jonathan Wakely wrote: > > > On Tue, 8 Jun 2021 at 01:29, Thomas Rodgers wrote: > > > >> This time with

Re: [committed] analyzer: bitfield fixes [PR99212]

2021-06-09 Thread Christophe Lyon via Gcc-patches
On Tue, 8 Jun 2021 at 21:34, David Malcolm via Gcc-patches wrote: > > This patch verifies the previous fix for bitfield sizes by implementing > enough support for bitfields in the analyzer to get the test cases to pass. > > The patch implements support in the analyzer for reading from a > BIT_FIEL

[PATCH 1/2] arm: Fix vcond_mask expander for MVE (PR target/100757)

2021-06-08 Thread Christophe Lyon via Gcc-patches
1082130432 .word 1082130432 .word 1084227584 .word 1084227584 .word 1084227584 .word 1084227584 2021-06-09 Christophe Lyon PR target/100757 gcc/ * config/arm/vec-common.md (vcond_mask_): Fix expansion for MVE.

[PATCH 2/2] arm: Fix fix arm_expand_vcond for MVE

2021-06-08 Thread Christophe Lyon via Gcc-patches
This patch fixes a problem in arm_expand_vcond() where the result would be a vector of 0 or 1 instead of operand 1 or 2. The mve-vcmp-f32-2.c testcase is an update from mve-vcmp-f32.c using a conditional with 2.0f and 3.0f constants to help scan-assembler-times. 2021-06-09 Christophe Lyon

[PATCH 2/2] arm: Auto-vectorization for MVE: add pack/unpack patterns

2021-06-07 Thread Christophe Lyon via Gcc-patches
.32q0, [r0] vclz.i32q0, q1 vstrh.32q0, [r0, #8] 2021-06-03 Christophe Lyon gcc/ * config/arm/mve.md (mve_vmovltq_): Prefix with '@'. (mve_vmovlbq_): Likewise. (mve_vmovnbq_): Likewise. (mve_vmovntq_)

[PATCH 1/2] arm: Auto-vectorization for MVE: vclz

2021-06-07 Thread Christophe Lyon via Gcc-patches
This patch adds support for auto-vectorization of clz for MVE. It does so by removing the unspec from mve_vclzq_ and uses 'clz' instead. It moves to neon_vclz expander from neon.md to vec-common.md and renames it into the standard name clz2. 2021-06-03 Christophe Lyon

Re: [PATCH] arm: Auto-vectorization for MVE and Neon: vhadd/vrhadd

2021-06-04 Thread Christophe Lyon via Gcc-patches
On Wed, 2 Jun 2021 at 20:19, Richard Sandiford wrote: > > Christophe Lyon writes: > > This patch adds support for auto-vectorization of average value > > computation using vhadd or vrhadd, for both MVE and Neon. > > > > The patch adds the needed [u]avg3_[floor|ceil]

Re: [ARM] PR98435: Missed optimization in expanding vector constructor

2021-06-04 Thread Christophe Lyon via Gcc-patches
On Fri, 4 Jun 2021 at 09:27, Prathamesh Kulkarni via Gcc-patches wrote: > > Hi, > As mentioned in PR, for the following test-case: > > #include > > bfloat16x4_t f1 (bfloat16_t a) > { > return vdup_n_bf16 (a); > } > > bfloat16x4_t f2 (bfloat16_t a) > { > return (bfloat16x4_t) {a, a, a, a}; > }

Re: [backport gcc10, gcc9] Requet to backport PR97969

2021-06-03 Thread Christophe Lyon via Gcc-patches
On Thu, 3 Jun 2021 at 10:54, Przemyslaw Wirkus wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: 03 June 2021 09:45 > > To: Przemyslaw Wirkus > > Cc: Vladimir Makarov ; ja...@redhat.com; Richard > > Earnshaw ; Richard

Re: [backport gcc10, gcc9] Requet to backport PR97969

2021-06-03 Thread Christophe Lyon via Gcc-patches
On Thu, 3 Jun 2021 at 00:31, Przemyslaw Wirkus via Gcc-patches wrote: > > Hi, > > > -Original Message- > > From: Vladimir Makarov > > Sent: 31 May 2021 16:52 > > To: Przemyslaw Wirkus ; Richard Biener > > > > Cc: gcc-patches@gcc.gnu.org; ja...@redhat.com; ni...@redhat.com; > > Richard Ea

Re: [arm/testsuite]: Skip pr97969.c if -mthumb is not compatible [PR target/97969]

2021-06-03 Thread Christophe Lyon via Gcc-patches
On Thu, 3 Jun 2021 at 10:38, Christophe Lyon wrote: > > On Mon, 15 Mar 2021 at 17:03, Christophe Lyon > wrote: > > > > On Wed, 3 Mar 2021 at 15:00, Richard Earnshaw > > wrote: > > > > > > On 02/03/2021 18:35, Christophe Lyon wrote: > >

Re: [arm/testsuite]: Skip pr97969.c if -mthumb is not compatible [PR target/97969]

2021-06-03 Thread Christophe Lyon via Gcc-patches
On Mon, 15 Mar 2021 at 17:03, Christophe Lyon wrote: > > On Wed, 3 Mar 2021 at 15:00, Richard Earnshaw > wrote: > > > > On 02/03/2021 18:35, Christophe Lyon wrote: > > > On Tue, 2 Mar 2021 at 19:18, Richard Earnshaw > > > wrote: > > >> &

Re: [PATCH] Replace conditional_replacement with match and simplify

2021-06-02 Thread Christophe Lyon via Gcc-patches
On Tue, 1 Jun 2021 at 08:06, apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > This is the first of series of patches to simplify phi-opt > to use match and simplify in many cases. This simplification > will more things to optimize. > > This is what Richard requested in > https://gcc

[PATCH] arm: Auto-vectorization for MVE and Neon: vhadd/vrhadd

2021-05-31 Thread Christophe Lyon via Gcc-patches
the IR. As noted in neon-vhadd-1.c, I couldn't write a test able to use Neon vectorization with 64-bit vectors: we default to -mvectorize-with-neon-quad, and attempts to use -mvectorize-with-neon-double resulted in much worse code, which this patch does not aim at improving. 2021-05-31

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-31 Thread Christophe Lyon via Gcc-patches
On Sat, 29 May 2021 at 10:03, Jakub Jelinek via Gcc-patches wrote: > > On Fri, May 28, 2021 at 12:59:20AM +0200, Tobias Burnus wrote: > > * gfortran.dg/gomp/depend-iterator-1.f90: New test. > > * gfortran.dg/gomp/depend-iterator-2.f90: New test. > > Something I've missed during the rev

Re: [PATCH] arm: Auto-vectorization for MVE: vabs

2021-05-27 Thread Christophe Lyon via Gcc-patches
At the moment I sent that patch I remembered that Victor is also working on vabs, so sorry if this conflicts with his work. On Thu, 27 May 2021 at 13:21, Christophe Lyon wrote: > > This patch adds support for auto-vectorization of absolute value > computation using vabs. > > W

[PATCH] arm: Auto-vectorization for MVE: vabs

2021-05-27 Thread Christophe Lyon via Gcc-patches
o avoid a clash with the new expander with the same name. 2021-05-26 Christophe Lyon gcc/ * config/arm/mve.md (mve_vabsq_f): Use 'abs' instead of unspec. (mve_vabsq_s): Likewise. * config/arm/neon.md (abs2): Rename to neon_abs2. * config/ar

Re: [PATCH 2/5] Convert Walloca pass to RANGE_QUERY(cfun).

2021-05-27 Thread Christophe Lyon via Gcc-patches
Hi, On Tue, 25 May 2021 at 18:17, Aldy Hernandez via Gcc-patches wrote: > > Adjustments per discussion. > > OK pending tests? > The xfail removal causes failures on 32 bits platforms (eg arm, or aarch64 with -mabi=ilp32): FAIL: gcc.dg/Wstringop-overflow-55.c pr? (test for warnings, line 86)

Re: [PATCH] arm: Auto-vectorization for MVE: vaddv

2021-05-26 Thread Christophe Lyon via Gcc-patches
On Wed, 26 May 2021 at 11:32, Richard Sandiford wrote: > > Christophe Lyon writes: > > This patch adds support for the reduc_plus_scal optab with MVE, which > > maps to the vaddv instruction. > > > > It moves the reduc_plus_scal_ expander from neon.md to > >

[PATCH] arm: Auto-vectorization for MVE: vaddv

2021-05-25 Thread Christophe Lyon via Gcc-patches
q3, but truncate with uxtbr0, r0. 2021-05-25 Christophe Lyon gcc/ * config/arm/mve.md (mve_vaddvq_): Prefix with '@'. * config/arm/neon.md (reduc_plus_scal_): Move to .. * config/arm/vec-common.md: .. here. Add support for MVE.

Re: [PATCH 9/9] arm: Auto-vectorization for MVE: vld4/vst4

2021-05-24 Thread Christophe Lyon via Gcc-patches
ping? On Mon, 17 May 2021 at 11:55, Christophe Lyon wrote: > > ping? > > On Tue, 4 May 2021 at 16:57, Christophe Lyon > wrote: > > > > On Tue, 4 May 2021 at 14:03, Andre Vieira (lists) > > wrote: > > > > > > Hi Christophe, > > >

Re: [PATCH 8/9] arm: Auto-vectorization for MVE: vld2/vst2

2021-05-24 Thread Christophe Lyon via Gcc-patches
ping? On Mon, 17 May 2021 at 11:55, Christophe Lyon wrote: > > ping? > > On Fri, 30 Apr 2021 at 16:09, Christophe Lyon > wrote: > > > > This patch enables MVE vld2/vst2 instructions for auto-vectorization. > > We move the existing expanders from neon.md and ena

Re: [PATCH v2] vect: Replace hardcoded weight factor with param

2021-05-20 Thread Christophe Lyon via Gcc-patches
On Thu, 20 May 2021 at 10:52, Kewen.Lin via Gcc-patches wrote: > > on 2021/5/19 下午6:01, Richard Biener wrote: > > On Wed, May 19, 2021 at 11:47 AM Kewen.Lin wrote: > >> > >> Hi Richi, > >> > >> on 2021/5/19 下午4:15, Richard Biener wrote: > >>> On Wed, May 19, 2021 at 8:20 AM Kewen.Lin wrote: > >>

Re: [PATCH] c: Add support for __FILE_NAME__ macro (PR c/42579)

2021-05-19 Thread Christophe Lyon via Gcc-patches
desourcery.com commit d0e79f75dc3723231609f24e2840ac5858a652e1 Author: Christophe Lyon Date: Wed May 19 20:28:08 2021 + c: Add support for __FILE_NAME__ macro (PR c/42579) The toolchain provided by ST for stm32 has had support for __FILENAME__ for a while, but clang/llvm has recently implemented support for

Re: [PATCH] arm/testsuite: Fix testcase for PR99977

2021-05-19 Thread Christophe Lyon via Gcc-patches
On Wed, 19 May 2021 at 16:40, Richard Earnshaw wrote: > > > > On 19/05/2021 09:10, Christophe Lyon via Gcc-patches wrote: > > Some targets (eg arm-none-uclinuxfdpiceabi) do not support Thumb-1, > > and since the testcase forces -march=armv8-m.base, we need to check &g

Re: [PATCH] phiopt: Simplify (X & Y) == X -> (X & ~Y) == 0 even in presence of integral conversions [PR94589]

2021-05-19 Thread Christophe Lyon via Gcc-patches
On Wed, 19 May 2021 at 13:29, Christophe Lyon wrote: > > On Wed, 19 May 2021 at 13:13, Richard Biener wrote: > > > > On Wed, 19 May 2021, Jakub Jelinek wrote: > > > > > On Wed, May 19, 2021 at 11:09:19AM +0200, Jakub Jelinek via Gcc-patches > > > wr

Re: [PATCH] phiopt: Simplify (X & Y) == X -> (X & ~Y) == 0 even in presence of integral conversions [PR94589]

2021-05-19 Thread Christophe Lyon via Gcc-patches
On Wed, 19 May 2021 at 13:13, Richard Biener wrote: > > On Wed, 19 May 2021, Jakub Jelinek wrote: > > > On Wed, May 19, 2021 at 11:09:19AM +0200, Jakub Jelinek via Gcc-patches > > wrote: > > > On Wed, May 19, 2021 at 10:15:53AM +0200, Christophe Lyon via Gcc-patch

[PATCH] c: Add support for __FILE_NAME__ macro (PR c/42579)

2021-05-19 Thread Christophe Lyon via Gcc-patches
har* mystring_filename = "mysrc.c"; char* mystring_base_file = "mydir/mysrc.c"; 2021-05-19 Christophe Lyon Torbjörn Svensson PR c/42579 libcpp/ * include/cpplib.h (cpp_builtin_type): Add BT_FILE_NAME entry. * init.c (builtin_array): Likewise.

Re: [PATCH] phiopt: Optimize partial_ordering spaceship >= 0 -ffinite-math-only [PR94589]

2021-05-19 Thread Christophe Lyon via Gcc-patches
On Tue, 18 May 2021 at 09:42, Jakub Jelinek via Gcc-patches wrote: > > Hi! > > As mentioned earlier, spaceship_replacement didn't optimize partial_ordering > >= 0 comparisons, because the possible values are -1, 0, 1, 2 and the > >= comparison is implemented as (res & 1) == res to choose the 0 and

[PATCH] arm/testsuite: Fix testcase for PR99977

2021-05-19 Thread Christophe Lyon via Gcc-patches
Some targets (eg arm-none-uclinuxfdpiceabi) do not support Thumb-1, and since the testcase forces -march=armv8-m.base, we need to check whether this option is actually supported. Using dg-add-options arm_arch_v8m_base ensure that we pass -mthumb as needed too. 2021-05-19 Christophe Lyon

Re: [PATCH 6/9] arm: Auto-vectorization for MVE: vcmp

2021-05-17 Thread Christophe Lyon via Gcc-patches
On Mon, 17 May 2021 at 12:35, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Gcc-patches On Behalf Of > > Christophe Lyon via Gcc-patches > > Sent: 05 May 2021 15:08 > > To: Andre Simoes Dias Vieira > > Cc: gcc Patches > &g

Re: [PATCH 9/9] arm: Auto-vectorization for MVE: vld4/vst4

2021-05-17 Thread Christophe Lyon via Gcc-patches
ping? On Tue, 4 May 2021 at 16:57, Christophe Lyon wrote: > > On Tue, 4 May 2021 at 14:03, Andre Vieira (lists) > wrote: > > > > Hi Christophe, > > > > The series LGTM but you'll need the approval of an arm port maintainer > > before committing. I on

Re: [PATCH 8/9] arm: Auto-vectorization for MVE: vld2/vst2

2021-05-17 Thread Christophe Lyon via Gcc-patches
ping? On Fri, 30 Apr 2021 at 16:09, Christophe Lyon wrote: > > This patch enables MVE vld2/vst2 instructions for auto-vectorization. > We move the existing expanders from neon.md and enable them for MVE, > calling the respective emitter. > > 2021-03-12 Christophe Lyon

Re: [PATCH 7/9] arm: Auto-vectorization for MVE: add __fp16 support to VCMP

2021-05-17 Thread Christophe Lyon via Gcc-patches
ping? On Wed, 5 May 2021 at 16:09, Christophe Lyon wrote: > > On Tue, 4 May 2021 at 19:03, Christophe Lyon > wrote: > > > > On Tue, 4 May 2021 at 15:43, Christophe Lyon > > wrote: > > > > > > On Tue, 4 May 2021 at 13:48, Andre Vieira (lists) >

Re: [PATCH 6/9] arm: Auto-vectorization for MVE: vcmp

2021-05-17 Thread Christophe Lyon via Gcc-patches
ping? On Wed, 5 May 2021 at 16:08, Christophe Lyon wrote: > > On Tue, 4 May 2021 at 15:41, Christophe Lyon > wrote: > > > > On Tue, 4 May 2021 at 13:29, Andre Vieira (lists) > > wrote: > > > > > > Hi Christophe, > > > > >

Re: [PATCH] testsuite/arm: Add mve-vadd-scalar-1.c test

2021-05-17 Thread Christophe Lyon via Gcc-patches
ping? On Mon, 10 May 2021 at 13:22, Christophe Lyon wrote: > > Ping? > > On Fri, 30 Apr 2021 at 16:06, Christophe Lyon > wrote: > > > > This patch adds a test for the scalar mode of vadd, precisely noting > > that we do not yet use the T2 variants of vadd,

Re: [PATCH] testsuite/arm: Add mve-vadd-1.c test

2021-05-17 Thread Christophe Lyon via Gcc-patches
ping? On Mon, 10 May 2021 at 13:22, Christophe Lyon wrote: > > Ping? > > On Tue, 27 Apr 2021 at 13:32, Christophe Lyon > wrote: > > > > Support for vadd has been present for a while, but it was lacking a > > test. > > > > 2021-04-22 Ch

Re: [PATCH] testsuite/arm: Factorize and increase coverage in mve-sub_1.c

2021-05-17 Thread Christophe Lyon via Gcc-patches
ping? On Mon, 10 May 2021 at 13:22, Christophe Lyon wrote: > > Ping? > > On Tue, 27 Apr 2021 at 13:32, Christophe Lyon > wrote: > > > > Use a template macro to factorize the existing test functions. > > > > This patch also adds a version to check subtracti

Re: [PATCH] testsuite/arm: Improve mve-vshr.c

2021-05-17 Thread Christophe Lyon via Gcc-patches
ping? On Mon, 10 May 2021 at 13:22, Christophe Lyon wrote: > > Ping? > > On Tue, 27 Apr 2021 at 13:32, Christophe Lyon > wrote: > > > > Vector right shifts by immediate use vshr, while right shifts by > > vectors instead use vneg and vshl. > > >

Re: [PATCH] testsuite/arm: Fix and rename arm_qbit_ok into arm_sat_ok effective-target

2021-05-17 Thread Christophe Lyon via Gcc-patches
ping? On Fri, 30 Apr 2021 at 16:22, Christophe Lyon wrote: > > ping? > > On Wed, 21 Apr 2021 at 22:48, Christophe Lyon > wrote: > > > > The acle/saturation.c test uses __[su]sat() and > > __saturation_occurred() intrinsics but __[su]sat() are defined in >

Re: [PATCH] Fix ICE in output_rnglists, at dwarf2out.c:12294 [PR100515]

2021-05-17 Thread Christophe Lyon via Gcc-patches
t OK for trunk? > > OK. > > Richard. > Hi, As the new test uses -fopenmp, it fails on targets that do not support it. I've committed the attached patch to skip the test in such cases. Christophe > > > > Thanks > > Bernd. > > commit b050cf6a4

[PATCH] arm: remove error in CPP_SPEC when -mlittle-endian and -mbig-endian are used together

2021-05-12 Thread Christophe Lyon via Gcc-patches
the testsuite results. 2021-05-12 Christophe Lyon gcc/ * config/arm/arm.h (CPP_SPEC): Remove error message about -mlittle-endian/-mbig-endian conflict. --- gcc/config/arm/arm.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gcc/config/arm/arm.h b

Re: [PATCH] arm: remove error in CPP_SPEC when float-abi soft and hard are used together

2021-05-10 Thread Christophe Lyon via Gcc-patches
On Mon, 10 May 2021 at 18:32, Richard Earnshaw wrote: > > > > On 22/04/2021 08:01, Christophe Lyon via Gcc-patches wrote: > > arm.h has had this error message since 1997, and was never updated to > > take softfp into account. Anyway, it seems it was useful long ago, but &g

Re: [PATCH] testsuite/arm: Add mve-vmul-scalar-1.c test

2021-05-10 Thread Christophe Lyon via Gcc-patches
On Mon, 10 May 2021 at 13:50, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Gcc-patches On Behalf Of > > Christophe Lyon via Gcc-patches > > Sent: 30 April 2021 15:06 > > To: gcc-patches@gcc.gnu.org > > Subject: [PATCH

Re: [PATCH] testsuite/arm: Improve mve-vshr.c

2021-05-10 Thread Christophe Lyon via Gcc-patches
Ping? On Tue, 27 Apr 2021 at 13:32, Christophe Lyon wrote: > > Vector right shifts by immediate use vshr, while right shifts by > vectors instead use vneg and vshl. > > This patch adds the corresponding scan-assembler-times that were > missing. > > 2021-04-22 Christoph

Re: [PATCH] testsuite/arm: Factorize and increase coverage in mve-sub_1.c

2021-05-10 Thread Christophe Lyon via Gcc-patches
Ping? On Tue, 27 Apr 2021 at 13:32, Christophe Lyon wrote: > > Use a template macro to factorize the existing test functions. > > This patch also adds a version to check subtraction with __fp16 type. > > 2021-04-26 Christophe Lyon > > gcc/testsuite/ >

Re: [PATCH] testsuite/arm: Add mve-vadd-1.c test

2021-05-10 Thread Christophe Lyon via Gcc-patches
Ping? On Tue, 27 Apr 2021 at 13:32, Christophe Lyon wrote: > > Support for vadd has been present for a while, but it was lacking a > test. > > 2021-04-22 Christophe Lyon > > gcc/testsuite/ > * gcc.target/arm/simd/mve-vadd-1.c: New. > --- > gcc

Re: [PATCH] testsuite/arm: Add mve-vadd-scalar-1.c test

2021-05-10 Thread Christophe Lyon via Gcc-patches
Ping? On Fri, 30 Apr 2021 at 16:06, Christophe Lyon wrote: > > This patch adds a test for the scalar mode of vadd, precisely noting > that we do not yet use the T2 variants of vadd, which take a scalar as > final argument. > > 2021-04-22 Christophe Lyon > &g

Re: [PATCH] testsuite/arm: Add mve-vmul-scalar-1.c test

2021-05-10 Thread Christophe Lyon via Gcc-patches
Ping? On Fri, 30 Apr 2021 at 16:06, Christophe Lyon wrote: > > Support for vmul has been present for a while, but it was lacking a > test for the scalar variant. > > This patch adds one, precisely noting that we do not yet use the T2 > variants of vmul, which take a scalar

Re: [PATCH] testsuite/arm: Add mve-vsub-scalar-1.c test

2021-05-10 Thread Christophe Lyon via Gcc-patches
Ping? On Fri, 30 Apr 2021 at 16:06, Christophe Lyon wrote: > > This patchs adds a test similar to mve-vsub_1.c, but operates on a > scalar as second argument. For the moment we do not select the T2 vsub > variant operating on a scalar final argument, and we use vadd of the > opp

Re: [PATCH 1/9] arm: MVE: Convert vcmp[eq|ne]* in arm_mve.h to use only 's' builtin version

2021-05-10 Thread Christophe Lyon via Gcc-patches
Ping for the series? On Fri, 30 Apr 2021 at 16:09, Christophe Lyon wrote: > > There is no need to have a signed and an unsigned version of these > builtins. This is similar to what we do for Neon in arm_neon.h. > This mechanical patch enables later cleanup patches. > > 2021

Re: [PATCH] tree-optimization/79333 - fold stmts following SSA edges in VN

2021-05-07 Thread Christophe Lyon via Gcc-patches
On Wed, 5 May 2021 at 09:56, Richard Biener wrote: > > This makes sure to follow SSA edges when folding eliminated stmts. > This reaps the same benefit as forwprop folding all stmts, not > waiting for one to produce copysign in the new testcase. > > Bootstrapped on x86_64-unknown-linux-gnu, testin

Re: [PATCH 3/4][AArch32]: Add support for sign differing dot-product usdot for NEON.

2021-05-06 Thread Christophe Lyon via Gcc-patches
On Wed, 5 May 2021 at 19:39, Tamar Christina via Gcc-patches wrote: > > Hi All, > > This adds optabs implementing usdot_prod. > > The following testcase: > > #define N 480 > #define SIGNEDNESS_1 unsigned > #define SIGNEDNESS_2 signed > #define SIGNEDNESS_3 signed > #define SIGNEDNESS_4 unsigned >

Re: [PATCH 7/9] arm: Auto-vectorization for MVE: add __fp16 support to VCMP

2021-05-05 Thread Christophe Lyon via Gcc-patches
On Tue, 4 May 2021 at 19:03, Christophe Lyon wrote: > > On Tue, 4 May 2021 at 15:43, Christophe Lyon > wrote: > > > > On Tue, 4 May 2021 at 13:48, Andre Vieira (lists) > > wrote: > > > > > > It would be good to also add tests for NEON as you also

Re: [PATCH 6/9] arm: Auto-vectorization for MVE: vcmp

2021-05-05 Thread Christophe Lyon via Gcc-patches
On Tue, 4 May 2021 at 15:41, Christophe Lyon wrote: > > On Tue, 4 May 2021 at 13:29, Andre Vieira (lists) > wrote: > > > > Hi Christophe, > > > > On 30/04/2021 15:09, Christophe Lyon via Gcc-patches wrote: > > > Since MVE has a different set of vecto

testsuite: gcc.c-torture/execute/ieee/cdivchkld.c needs fmaxl

2021-05-04 Thread Christophe Lyon via Gcc-patches
The new test gcc.c-torture/execute/ieee/cdivchkld.c needs fmaxl(), which may not be available, for instance on aarch64-elf with newlib. As discussed in the PR, requiring c99_runtime enables to skip the test in this case. 2021-05-04 Christophe Lyon PR testsuite/100355 gcc

Re: [PATCH 7/9] arm: Auto-vectorization for MVE: add __fp16 support to VCMP

2021-05-04 Thread Christophe Lyon via Gcc-patches
On Tue, 4 May 2021 at 15:43, Christophe Lyon wrote: > > On Tue, 4 May 2021 at 13:48, Andre Vieira (lists) > wrote: > > > > It would be good to also add tests for NEON as you also enable auto-vec > > for it. I checked and I do think the necessary 'neon_vc

Re: [PATCH 9/9] arm: Auto-vectorization for MVE: vld4/vst4

2021-05-04 Thread Christophe Lyon via Gcc-patches
> Kind regards, > Andre > > On 30/04/2021 15:09, Christophe Lyon via Gcc-patches wrote: > > This patch enables MVE vld4/vst4 instructions for auto-vectorization. > > We move the existing expanders from neon.md and enable them for MVE, > > calling the respective emitter. &g

Re: [PATCH 7/9] arm: Auto-vectorization for MVE: add __fp16 support to VCMP

2021-05-04 Thread Christophe Lyon via Gcc-patches
nce I posted the patch series, I've noticed a regression in armv8_2-fp16-arith-1.c, because we now vectorize all the float16x[48]_t loops, but we lose the fact that some FP comparisons can throw exceptions. I'll have to revisit this patch. Thanks, Christophe > On 30/04/2021 15:09,

Re: [PATCH 6/9] arm: Auto-vectorization for MVE: vcmp

2021-05-04 Thread Christophe Lyon via Gcc-patches
On Tue, 4 May 2021 at 13:29, Andre Vieira (lists) wrote: > > Hi Christophe, > > On 30/04/2021 15:09, Christophe Lyon via Gcc-patches wrote: > > Since MVE has a different set of vector comparison operators from > > Neon, we have to update the expansion to take into accou

[PATCH, OBVIOUS] testsuite: Fix dg directives order in arm/aarch64 vml[as]_float_not_fused.c

2021-05-03 Thread Christophe Lyon via Gcc-patches
dg-do must come before dg-skip-if, this patch fixes this oversight in these two tests. Committed as obvious. 2021-05-03 Christophe Lyon gcc/testsuite/ * gcc.target/aarch64/advsimd-intrinsics/vmla_float_not_fused.c: Fix dg directives order. * gcc.target/aarch64

Re: [PATCH] testsuite/arm: Fix and rename arm_qbit_ok into arm_sat_ok effective-target

2021-04-30 Thread Christophe Lyon via Gcc-patches
ping? On Wed, 21 Apr 2021 at 22:48, Christophe Lyon wrote: > > The acle/saturation.c test uses __[su]sat() and > __saturation_occurred() intrinsics but __[su]sat() are defined in > acle.h if __ARM_FEATURE_SAT true, while __saturation_occurred() > depends on __ARM_FEATURE_QBIT. >

Re: [PATCH] arm: remove error in CPP_SPEC when float-abi soft and hard are used together

2021-04-30 Thread Christophe Lyon via Gcc-patches
ping? On Thu, 22 Apr 2021 at 09:01, Christophe Lyon wrote: > > arm.h has had this error message since 1997, and was never updated to > take softfp into account. Anyway, it seems it was useful long ago, but > it is no longer needed since option parsing has been improved: > -mfloat

Re: [PATCH] testsuite/arm: Improve unsigned-float.c

2021-04-30 Thread Christophe Lyon via Gcc-patches
ping? On Thu, 22 Apr 2021 at 15:32, Christophe Lyon wrote: > > The test requires an FPU, so use -march=armv7-a+fp -mfpu=auto instead > of -march=armv7-a. > > We also remove dg-require-effective-target arm_fp_ok, but keep > dg-add-options arm_fp: this enables the test t

<    3   4   5   6   7   8   9   10   11   12   >