Re: [PATCH] PR target/71549: Convert V1TImode register to TImode in debug insn

2016-06-28 Thread Gary Funck
On 06/20/16 04:55:16, H.J. Lu wrote: > TImode register referenced in debug insn can be converted to V1TImode > by scalar to vector optimization. We need to convert a debug insn if > it has a variable in a TImode register. Hello, We have a situation on a few of the UPC tests, where they ICE on th

Re: [UPC 02/22] tree-related changes

2015-12-05 Thread Gary Funck
On 12/03/15 12:07:35, Richard Biener wrote: > On Wed, 2 Dec 2015, Gary Funck wrote: > > OK. As I mentioned in a previous reply, originally we prefixed > > all "UPC" specific tree node fields and functions with UPC_ or upc_, > > but as we transitioned away from UPC

Re: [UPC 14/22] constant folding changes

2015-12-05 Thread Gary Funck
On 12/01/15 12:46:01, Richard Biener wrote: > On Mon, 30 Nov 2015, Gary Funck wrote: > > UPC pointers-to-shared (aka shared pointers) are not interchangeable > > with integers as they are in regular "C". Therefore, additions > > and subtraction operations wh

Re: [UPC 07/22] lowering, pointer-to-shared ops

2015-12-05 Thread Gary Funck
On 12/01/15 12:42:48, Richard Biener wrote: > On Mon, 30 Nov 2015, Gary Funck wrote: > [...] > > + if (bitpos) > > +{ > > + t_offset = size_int (bitpos / BITS_PER_UNIT); > > + if (offset) > > + t_offset = fold (build_binary_op (loc, PLUS_EXPR,

Re: [UPC 07/22] lowering, pointer-to-shared ops

2015-12-05 Thread Gary Funck
On 12/01/15 12:42:48, Richard Biener wrote: > On Mon, 30 Nov 2015, Gary Funck wrote: > [...] > > + get_lc_mode_name (mname, (op_mode)); > > + sprintf (libfunc_name, "__get%s%s%s%s", > > + strict_mode ? "s" : "", &

Re: RFC: Merge the GUPC branch into the GCC 6.0 trunk

2015-12-05 Thread Gary Funck
On 12/02/15 10:40:50, Richard Biener wrote: > On Tue, 1 Dec 2015, Gary Funck wrote: > > The main change recommended to reduce tree space was moving the > > "layout factor" (blocking factor) out of the tree node, and using > > only two bits there, one bit for a relat

Re: [UPC 15/22] RTL changes

2015-12-02 Thread Gary Funck
On 12/02/15 13:10:44, Richard Guenther wrote: > On Tue, Dec 1, 2015 at 7:02 AM, Gary Funck wrote: > > UPC pointers-to-shared have an internal representation which is > > defined as a 'struct' with three fields. Special logic is > > needed in promote_mode() to ha

Re: [UPC 02/22] tree-related changes

2015-12-02 Thread Gary Funck
On 12/01/15 12:26:32, Richard Biener wrote: > On Mon, 30 Nov 2015, Gary Funck wrote: > > -struct GTY(()) tree_type_common { > > +struct GTY((user)) tree_type_common { > >struct tree_common common; > >tree size; > >tree size_unit; >

Re: RFC: Merge the GUPC branch into the GCC 6.0 trunk

2015-12-02 Thread Gary Funck
On 12/01/15 12:19:48, Bernd Schmidt wrote: > On 12/01/2015 06:31 AM, Gary Funck wrote: > >At this time, we would like to re-submit the UPC patches for comment > >with the goal of introducing these changes into GCC 6.0. > > This has missed stage 1 by a few weeks, we'd ha

Re: [UPC 01/22] front-end changes

2015-12-02 Thread Gary Funck
On 12/01/15 09:12:44, Eric Botcazou wrote: > > All languages (c, c++, fortran, go, lto, objc, obj-c++) have been > > bootstrapped; no test suite regressions were introduced, > > relative to the GCC trunk. > > That's not all languages though, Ada and Java are missing. Full bootstrap, no regression

Re: RFC: Merge the GUPC branch into the GCC 6.0 trunk

2015-12-01 Thread Gary Funck
On 12/01/15 12:12:29, Richard Biener wrote: > On Mon, 30 Nov 2015, Gary Funck wrote: > > At this time, we would like to re-submit the UPC patches for comment > > with the goal of introducing these changes into GCC 6.0. > > First of all let me say that it is IMNSHO now t

Re: [UPC 01/22] front-end changes

2015-12-01 Thread Gary Funck
On 12/01/15 09:12:44, Eric Botcazou wrote: > > All languages (c, c++, fortran, go, lto, objc, obj-c++) have been > > bootstrapped; no test suite regressions were introduced, > > relative to the GCC trunk. > > That's not all languages though, Ada and Java are missing. OK. I'll bootstrap and run te

[UPC 20/22] libgupc runtime library [6/9]

2015-11-30 Thread Gary Funck
in the directory where other "C" header files are located. 2015-11-30 Gary Funck libgupc/collectives/ * upc_coll_reduce.upc: New. * upc_coll_scatter.upc: New. * upc_coll_sort.upc: Ne

[UPC 20/22] libgupc runtime library [4/9]

2015-11-30 Thread Gary Funck
in the directory where other "C" header files are located. 2015-11-30 Gary Funck libgupc/collectives/ * upc_coll.h: New. * upc_coll_broadcast.upc: New. * upc_coll_err.upc: New. * upc_coll_exchange.upc: New. * upc_coll_gathe

[UPC 20/22] libgupc runtime library [1/9]

2015-11-30 Thread Gary Funck
in the directory where other "C" header files are located. 2015-11-30 Gary Funck libgupc/ * upc-crtstuff.c: New. libgupc/include/ * gasp.h: New. * gasp_upc.h: New. * gcc-upc.h: New. * pupc.h: New. * upc.h: New.

[UPC 21/22] gcc.dg test suite

2015-11-30 Thread Gary Funck
UPC runtime library that would have otherwise been declared in the gcc-upc.h file built under libgupc/include. 2015-11-30 Gary Funck gcc/testsuite/gcc.dg/gupc/ * addr-of-shared-bit-field.upc: New. * assign-local-ptr-to-pts.upc: New. * assign-pts-to-local-ptr.u

[UPC 04/22] Make, Config changes

2015-11-30 Thread Gary Funck
t has perl installed. 2015-11-30 Gary Funck * Makefile.def (libgupc): New. Define libgupc module. * Makefile.in: Re-generate. * Makefile.tpl (BUILD_EXPORTS, EXTRA_TARGET_FLAGS): Add GUPC and GUPCFLAGS. (BASE_TARGET_EXPORTS, EXTRA_H

[UPC 07/22] lowering, pointer-to-shared ops

2015-11-30 Thread Gary Funck
c_common_parse_file(), just after calling c_parse_file(). 2015-11-30 Gary Funck gcc/c-family/ * c-upc-pts.h: New. Define the sizes and types of fields in the UPC pointer-to-shared representation. gcc/c/ * c-upc-low.c: New. Lower UPC constructs to G

[UPC 11/22] documentation

2015-11-30 Thread Gary Funck
the command line as if they were .upc files. In addition, it describes how to run UPC programs, along with details on the command line switches processed by the UPC runtime. 2015-11-30 Gary Funck gcc/doc/ * gupc.texi: New. * install.texi (disable-libgupc, en

[UPC 16/22] gimple/gimplify changes

2015-11-30 Thread Gary Funck
exported as an external function rather than being defined as a static function. It is called from upc_genericize_function() defined in c/c-upc-low.c, when -fupc-instrument-functions is asserted. 2015-11-30 Gary Funck gcc/ * gimple-expr.c: #include "langho

[UPC 17/22] misc/common changes

2015-11-30 Thread Gary Funck
to coalesce file scoped UPC shared variables. This section is used only to assign offsets into UPC's shared data area for the UPC shared variables. When UPC linker scripts are supported, this shared section is not loaded and has an origin of 0. 2015-11-30 Gary Funck gcc/

[UPC 12/22] DWARF support

2015-11-30 Thread Gary Funck
back into the mainline. A couple of commercial parallel debuggers implemented support for GNU UPC, utilizing these DWARF extensions. 2015-11-30 Gary Funck gcc/ * dwarf2out.c (modified_type_die): If the type is shared qualified, generate UPC debugging information as defined

[UPC 18/22] libatomic changes

2015-11-30 Thread Gary Funck
ts them using a spin lock. 2015-11-30 Gary Funck libatomic/ * Makefile.am (LIBAT_SRC_NO_LOCK, libatomic_convenience_no_lock*): New. Add rules to build libatomic_convenience_no_lock.a, used by libgupc. * Makefile.in: Re-gene

[UPC 14/22] constant folding changes

2015-11-30 Thread Gary Funck
simplified. 2015-11-30 Gary Funck gcc/ * fold-const.c (fold_unary_loc): Do not perform this simplification if either of the types are UPC pointer-to-shared types. (fold_binary_loc): Disable optimizations involving UPC pointers-to-shared because intege

[UPC 03/22] options processing, driver

2015-11-30 Thread Gary Funck
be compiled as UPC source files. This implicit handling of .c files as .upc files provides compatibility with other UPC compilers. 2015-11-30 Gary Funck gcc/ * gcc.c (upc_crtbegin_spec, link_upc_spec, upc_crtend_spec, upc_options): New. Define UPC-related spec

[UPC 05/22] language hooks changes

2015-11-30 Thread Gary Funck
If it does, then layout_decl() is called. A few new UPC-specific language hooks are defined in a 'upc' sub-structure of the language hooks structure. They are defined as hooks because they are called from code in the 'c-family/' directory, but are implemented in the 'c/&

[UPC 13/22] C++ changes

2015-11-30 Thread Gary Funck
et_qualified_type_1 (TYPE, QUALS, 0) This patch adjusts the C++ front-end so that it works with the changes described above. 2015-11-30 Gary Funck gcc/cp/ * lex.c (init_reswords): Disable UPC keywords. * tree.c (c_build_qualified_type_1): Rename.

[UPC 10/22] target - rs6000

2015-11-30 Thread Gary Funck
cks for UPC pointers-to-shared that are represented as an aggregate type and insures that these pointers are passed as struct's. 2015-11-30 Gary Funck gcc/config/rs6000/ * rs6000.c (rs6000_return_in_memory): If TYPE is a UPC PTS type with a "struct" int

[UPC 15/22] RTL changes

2015-11-30 Thread Gary Funck
be distributed to the appropriate ChangeLog file. Overview UPC pointers-to-shared have an internal representation which is defined as a 'struct' with three fields. Special logic is needed in promote_mode() to handle this case. 2015-11-30 Gary Funck gcc/

[UPC 09/22] target - x86

2015-11-30 Thread Gary Funck
t the parameter passing logic forces "C" pointer type parameters to be 'word mode', but that rule doesn't apply to UPC pointers-to-shared due to their "fat" struct representation. 2015-11-30 Gary Funck gcc/config/i386/ * i386.c (classify_ar

[UPC 06/22] target hooks

2015-11-30 Thread Gary Funck
be distributed to the appropriate ChangeLog file. Overview Four new target hooks are defined for UPC. They relate to naming the various linker sections used by UPC as well as testing for the availability of the "UPC linker script" feature. 2015-11-30 Gary Funck

[UPC 08/22] target - Darwin

2015-11-30 Thread Gary Funck
be distributed to the appropriate ChangeLog file. Overview For Darwin, if -fupc is given, then define various UPC-specific spec's. Also, override default section names for the UPC-related linker sections. 2015-11-30 Gary Funck gcc/config/ * dar

[UPC 02/22] tree-related changes

2015-11-30 Thread Gary Funck
ss; -const char * GTY ((tag ("TYPE_SYMTAB_IS_POINTER"))) pointer; -struct die_struct * GTY ((tag ("TYPE_SYMTAB_IS_DIE"))) die; - } GTY ((desc ("debug_hooks->tree_type_symtab_field"))) symtab; +int address; +const char *pointer; +struct die

RFC: Merge the GUPC branch into the GCC 6.0 trunk

2015-11-30 Thread Gary Funck
Some time ago, we submitted an RFC for the introduction of UPC support into GCC. During the intervening time period, we have continued to keep the 'gupc' (GNU UPC) branch in sync with the GCC trunk and have incorporated feedback and contributions from various GCC developers (Joseph Myers, Tom Tro

Re: top-level configure.ac: factor the libgomp check for posix-like OS

2015-08-25 Thread Gary Funck
Ended up using the same approach as libatomic, moving the checking logic into libgupc/configure.tgt. +# Disable libgupc on unsupported systems. +if test -d ${srcdir}/libgupc; then +if test x$enable_libgupc = x; then + AC_MSG_CHECKING([for libgupc support]) + if (srcdir=${srcdir}/l

Re: top-level configure.ac: factor the libgomp check for posix-like OS

2015-08-18 Thread Gary Funck
On 08/18/15 08:52:31, Thomas Schwinge wrote: > Even if applicable regarding the libgomp configuration (because > nvptx-none has its own libgomp "port": libgomp/config/nvptx/), it seems a > bit strange to qualify nvptx-none as a POSIX-like system. Hmm... > > + > > +# Enable libgomp by default on P

top-level configure.ac: factor the libgomp check for posix-like OS

2015-08-17 Thread Gary Funck
ds libgomp to $noconfigdirs on non POSIX-like OS's. We'd like to re-use that logic for libgupc, which has a similar requirement and propose this re-factoring for trunk. 2015-08-17 Gary Funck * configure.ac (noconfigdirs): Factor libgomp logic testing for

Re: c-family/c-pretty-print.c - fix for 'restrict' quliafiers

2015-08-17 Thread Gary Funck
On 08/17/15 12:06:08, Marek Polacek wrote: > No, I don't think this assignment is missing here. The restrict qualifier > is printed last so we don't need to mark that we've printed something. > > Actually, the whole "previous" flag seems to be redundant; pp_c_ws_string > calls pp_c_maybe_whitespa

c-family/c-pretty-print.c - fix for 'restrict' quliafiers

2015-08-16 Thread Gary Funck
While reviewing some code, I noticed that the logic for pretty-printing 'restrict' qualifiers is likely missing a statement that sets 'previous'. OK to commit? 2015-08-l6 Gary Funck * c-pretty-print.c (pp_c_cv_qualifiers): Set 'previous' for

Re: [PATCH] Fix PR middle-end/66984 - mis-optimization of CEIL_DIV_EXPR and FLOOR_DIV_EXPR

2015-07-24 Thread Gary Funck
On 07/24/15 08:43:05, Gary Funck wrote: > > See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66984 > > Confirmed that GCC trunk bootstraps without issue and > that this patch fixes the issue noted in the GUPC branch. > > 2015-07-24 Gary Funck > >

[PATCH] Fix PR middle-end/66984 - mis-optimization of CEIL_DIV_EXPR and FLOOR_DIV_EXPR

2015-07-24 Thread Gary Funck
See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66984 Confirmed that GCC trunk bootstraps without issue and that this patch fixes the issue noted in the GUPC branch. 2015-07-24 Gary Funck PR middle-end/66984 * fold-const.c (fold_binary_loc): Call fold_convert on arguments

Re: Copy TYPE_NO_FORCE_BLK in finalize_type_size

2015-05-26 Thread Gary Funck
On 05/22/15 17:44:23, Jan Hubicka wrote: > PR 66181 is about ICE in verify_type that complains that type and its variant > differs > by TYPE_NO_FORCE_BLK. Also PR 66283, on IA64. Has a small test case.

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Gary Funck
On Mon, Jun 9, 2014 at 5:36 PM, Ian Lance Taylor wrote: > There is no bug here, the control flow is just too complicated > for the compiler to sort out. I don't know why I'm > not seeing the warning [...] We have these compilation flags set: CFLAGS='-g3 -O3' CFLAGS_FOR_BUILD='-g3 -O3' CFL

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Gary Funck
On 06/04/14 18:28:17, Ian Lance Taylor wrote: > I have committed a patch to libgo to merge from revision > 18783:00cce3a34d7e of the master library. Based on trunk rev. 211365, we're seeing this warning: libgo/runtime/chan.c:484:7: error: ‘received’ may be used uninitialized in this function [-We

Re: Symtab cleanups 4/17 - ICE in GUPC due to use of init section

2013-06-19 Thread Gary Funck
On 06/19/13 09:26:30, Gary Funck wrote: > The variable declaration tree node looks about right to me. > However, it never makes it into the output assembler file. > > What is the recommended method for making sure that the > static variable created above is associated w

Re: Symtab cleanups 4/17 - ICE in GUPC due to use of init section

2013-06-19 Thread Gary Funck
On 06/18/13 16:37:04, Gary Funck wrote: > The initialization function is currently generated in tree form in the > usual way (it will be gimplified when the gimple pass is run). > > The code that is being generated is roughly equivalent to: > > static void > _

Re: Symtab cleanups 4/17 - ICE in GUPC due to use of init section

2013-06-18 Thread Gary Funck
On 06/18/13 22:27:51, Steven Bosscher wrote: > The advice would have to be that the front end should not write out > anything to the assembler file. > > Why not just emit the function as GIMPLE (even if your stmt_list is > empty) and let your main() call it? The initialization function is current

Re: Symtab cleanups 4/17 - ICE in GUPC due to use of init section

2013-06-18 Thread Gary Funck
On 06/05/13 16:18:52, Jan Hubicka wrote: > Hi, > this patch deals with C++ keyed methods and explicit instantiations. > Currently> C++ calls mark_used that ultimately sets force_output > on the functions. This is equivalent to attribute ((used)) > on the function/variable and it is bit too strong.

Re: patch to fix PR55106

2012-10-31 Thread Gary Funck
On 10/28/12 20:43:05, Vladimir Makarov wrote: > The following patch fixes PR55106. A value in GENERAL_REGS is > inherited into a move with destination pseudo of SSE_REGS. It > results into secondary move for which inheritance is tried again an > again. It means cycling LRA passes. > > The pat

Re: RFC: Merge the GUPC branch into the GCC 4.8 trunk (patch 01 of 16)

2012-10-18 Thread Gary Funck
Joseph, In this rather long reply, I have attempted to collect all your recent feedback, and to provide a response where possible. JSM: On Mon, 15 Oct 2012, Gary Funck wrote: JSM: GF: Various UPC language related checks and operations JSM: GF: are called in the "C" front-end and middl

Re: Propagate profile counts during switch expansion

2012-10-17 Thread Gary Funck
On 10/08/12 17:46:03, Easwaran Raman wrote: > I have attached a revised patch. The updated ChangeLog is given below > and I have responded to your comments inline: > > 2012-10-08 Easwaran Raman > * optabs.c (emit_cmp_and_jump_insn_1): Add a new parameter to > specificy the probability of takin

Re: RFC: Merge the GUPC branch into the GCC 4.8 trunk (patch 01 of 16)

2012-10-15 Thread Gary Funck
On 10/15/12 21:59:34, Joseph S. Myers wrote: > On Mon, 15 Oct 2012, Gary Funck wrote: > > > Some UPC-specific configuration options are added to > > the top-level configure.ac and gcc/configure.ac scripts. > > Any patch that includes new configure options should include

RFC: Merge the GUPC branch into the GCC 4.8 trunk (patch 02 of 16)

2012-10-15 Thread Gary Funck
Attached, patch 02 of 16. This patch set lists the small set of changes required in the C++ and Objective C front-end to accommodate changes needed for UPC. gcc/c/c-decl.c is also included here, to illustrate both the UPC front-end changes and to motivate the introduction of c_build_qualified_typ

RFC: Merge the GUPC branch into the GCC 4.8 trunk (patch 01 of 16)

2012-10-15 Thread Gary Funck
/default-c.c $(CONFIG_H) $(SYSTEM_H) coretypes.h \ $(C_TARGET_H) $(C_TARGET_DEF_H) $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) \ Index: gcc/objc/Make-lang.in === --- gcc/objc/Make-lang.in (.../trunk) (revisi

Re: RFC: Merge the GUPC branch into the GCC 4.8 trunk (patch 0 of 16)

2012-10-15 Thread Gary Funck
On 10/15/12 17:06:28, Joseph S. Myers wrote: > On Mon, 15 Oct 2012, Gary Funck wrote: > > Various UPC language related checks and operations > > are called in the "C" front-end and middle-end. > > To insure that these operations are defined, > > when link

Re: RFC: Merge the GUPC branch into the GCC 4.8 trunk (patch 0 of 16)

2012-10-15 Thread Gary Funck
On 10/15/12 17:51:14, Richard Guenther wrote: > On Mon, Oct 15, 2012 at 5:47 PM, Gary Funck wrote: [...] > > UPC-Related Front-End Changes > > - > > > > GCC's internal tree representation is > > extended to record the UPC "

RFC: Merge the GUPC branch into the GCC 4.8 trunk (patch 0 of 16)

2012-10-15 Thread Gary Funck
We have maintained the gupc (GNU Unified Parallel C) branch for a couple of years now, and would like to merge these changes into the GCC trunk. It is our goal to integrate the GUPC changes into the GCC 4.8 trunk, in order to provide a UPC (Unified Parallel C) capability in the subsequent GCC 4.8

RFC: Merge the GUPC branch into the GCC 4.8 trunk

2012-08-23 Thread Gary Funck
We have maintained the gupc (GNU Unified Parallel C) branch for a couple of years now, and would like to merge these changes into the GCC trunk. The purpose of this note is to ask for suggestions on the best way to proceed through the GUPC review and merge process. For reference, The GUPC projec

Re: [SH] PR 54089 - Add support for rotcr insn

2012-08-20 Thread Gary Funck
On 08/20/12 01:02:39, Oleg Endo wrote: > Hello, > > This adds support for SH's rotcr insn. > Tested on rev 190459 with > make -k check RUNTESTFLAGS="--target_board=sh-sim > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" > > and no new failures. > OK? > > Cheers, > Oleg > > Chang

Re: CXX conversion: min g++ version pre-requisite?

2012-08-19 Thread Gary Funck
I filed two bug reports: "GCC install document does not list minimum required g++ version" http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54324 "GCC does not build with G++ version 3.4.0" http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54326 Re: the latter bug report (54326), it might be further divide

Re: CXX conversion: min g++ version pre-requisite?

2012-08-18 Thread Gary Funck
On 08/18/12 09:51:43, Richard Guenther wrote: > The code is clearly buggy and should use CONST_CAST - well, or now, > finally, const_cast to cast const char * to char *. It is interesting that an old version of g++ caught this but a newer version didn't? - Gary

CXX conversion: min g++ version pre-requisite?

2012-08-17 Thread Gary Funck
Paul Hargrove noted the following build failure on an older x86-32 Linux (Redhat 8.0) system. g++ -c -g -O2 -DIN_GCC -fno-exceptions -fno-rtti -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -fno-common -DHAVE_CONFIG_H -DGENERATOR_FILE -I. -Ibuild -I/usr/local/pkg/upc/nightly

Re: Interaction between first stage build with g++ and $PATH

2012-08-16 Thread Gary Funck
On 08/16/12 08:44:09, Jakub Jelinek wrote: > Having . in $PATH is a serious bug (especially from security POV). > Just never do that. > Jakub Jakub, thanks. I'm aware of the potential risks and pitfalls. I probably should use better practice ... - Gary

Re: Interaction between first stage build with g++ and $PATH

2012-08-15 Thread Gary Funck
On 08/15/12 22:26:08, Ian Lance Taylor wrote: > it's a bug. OK, thanks. I submitted a bug report. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54279 - Gary

Interaction between first stage build with g++ and $PATH

2012-08-15 Thread Gary Funck
1. I have "." on $PATH. 2. In one build of the latest GCC trunk, I specify CC=/usr/bin/gcc and CXX=/usr/bin/g++ and everything works. 3. In another build, I don't specify CC or CXX. Therefore they default to 'gcc' and 'g++'. This fails: g++: error trying to exec 'cc1plus': execvp:

Re: PATCH [x86_64] PR20020 - 128 bit structs not targeted to TImode

2012-08-14 Thread Gary Funck
eLog (revision 190398) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,10 @@ +2012-08-14 Gary Funck + + PR target/20020 + * config/i386/i386.h (MAX_FIXED_MODE_SIZE): Allow use of TImode + for use with appropriately sized structures and unions + on 64-bit (x86) targets.

Re: PATCH [x86_64] PR20020 - 128 bit structs not targeted to TImode

2012-08-14 Thread Gary Funck
On 08/14/12 15:33:10, Joseph S. Myers wrote: > On Tue, 14 Aug 2012, Jakub Jelinek wrote: > > > On Mon, Aug 13, 2012 at 09:20:32PM -0700, Gary Funck wrote: > > > --- gcc/testsuite/gcc.dg/pr20020-1.c (revision 0) > > > +++ gcc/testsuite/gcc.dg/pr20020-1.c (r

Re: PATCH [x86_64] PR20020 - 128 bit structs not targeted to TImode

2012-08-14 Thread Gary Funck
On 08/14/12 08:30:59, Jakub Jelinek wrote: > On Mon, Aug 13, 2012 at 09:20:32PM -0700, Gary Funck wrote: > > --- gcc/testsuite/gcc.dg/pr20020-1.c(revision 0) > > +++ gcc/testsuite/gcc.dg/pr20020-1.c(revision 0) > > @@ -0,0 +1,25 @@ > > +/* Target i

PATCH [x86_64] PR20020 - 128 bit structs not targeted to TImode

2012-08-13 Thread Gary Funck
Attached, is a patch to fix PR20020, and three test cases. This patch improves the code generated for structs that can be represented in a TImode value on an x86_64 target. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20020 The test cases scan the generated RTL and verify that TImode operations are

Re: RFA: update comment in dwarf2.def re: UPC extensions

2012-05-19 Thread Gary Funck
On 05/19/12 20:37:19, Jason Merrill wrote: > OK. Done. Thanks.

RFA: update comment in dwarf2.def re: UPC extensions

2012-05-19 Thread Gary Funck
In the past, the UPC extensions to the DWARF2 debugging information format were described in a proposal. That proposal was subsequently accepted and documented in the DWARF4 specification. Index: include/dwarf2.def === --- include/d

Re: [RFC]: Add support for pragma pointer_size

2012-03-13 Thread Gary Funck
On 03/06/12 14:09:23, Tristan Gingold wrote: > The patch is simple: the C front-end will now calls > c_build_pointer_type (instead of build_pointer_type), which in > turn calls build_pointer_type_for_mode using the right mode. [...] Joining this discussion a bit late ... I have a few questions. Th

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-09 Thread Gary Funck
On 01/09/12 06:04:28, Gary Funck wrote: > On 01/09/12 12:08:22, Tobias Burnus wrote: > > I get the build failure: > > > > libcpp/macro.c:220:26: error: variable 'map' set but not used > > [-Werror=unused-but-set-variable] Richard, thanks. 2012-01-0

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-09 Thread Gary Funck
On 01/09/12 12:08:22, Tobias Burnus wrote: > I get the build failure: > > libcpp/macro.c:220:26: error: variable 'map' set but not used > [-Werror=unused-but-set-variable] Tobias, thanks. Will fix. - Gary

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-09 Thread Gary Funck
On 01/06/12 08:34:52, Tom Tromey wrote: > The patch is ok with either that change or with those 2 lines removed. Applied as svn version 183003.

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-06 Thread Gary Funck
On 01/06/12 08:34:52, Tom Tromey wrote: Tom> The patch is ok with either that change or with those 2 lines removed. Tom, thanks for the review. Another question ... The test case tries to sanity check the __FILE__ value by comparing the 'basename' part. #define BASE_NAME "pr33919.c" in

[PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-02 Thread Gary Funck
revision 182805) +++ gcc/testsuite/ChangeLog (working copy) @@ -1,3 +1,11 @@ +2012-01-02 Gary Funck + + PR preprocessor/33919 + * gcc.dg/pr33919.c: New test. + * gcc.dg/pr33919-0.h: New test header file. + * gcc.dg/pr33919-1.h: Ditto. + * gcc.dg/pr33919-2.h: Dit

[PATCH] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2011-12-21 Thread Gary Funck
+char *inc_base_file = __BASE_FILE__; Index: gcc/testsuite/ChangeLog === --- gcc/testsuite/ChangeLog (revision 182601) +++ gcc/testsuite/ChangeLog (working copy) @@ -1,3 +1,11 @@ +2011-12-21 Gary Funck + + PR preprocessor/pr33

--enable-checking=all results in long running compiles, where the compiler spends long periods of time in the garbage collector (GC)

2011-11-22 Thread Gary Funck
On 11/22/11 12:57:38, Diego Novillo wrote: > --enable-checking=all enables GC checking, so I am not really > surprised at the behaviour you observe. Good to know. Thanks. > > I will try rebuilding with --disable-build-poststage1-with-cxx and > > --enable-checking=all to try to determine if this

Re: PATCH RFA: Build stages 2 and 3 with C++

2011-11-22 Thread Gary Funck
On 11/22/11 11:32:03, Ian Lance Taylor wrote: > > If CXXFLAGS, is this a potentially surprising departure from > > previous configure behavior? > > Perhaps. I don't see how we could reasonably make any other choice,though. Agreed. Just wondering if there might be potential documentation impact,

Re: PATCH RFA: Build stages 2 and 3 with C++

2011-11-22 Thread Gary Funck
On 07/15/11 23:52:46, Ian Lance Taylor wrote: [...] > @@ -444,6 +448,9 @@ STAGE1_LANGUAGES = @stage1_languages@ > # the last argument when conflicting --enable arguments are passed. > # * Likewise, we force-disable coverage flags, since the installed > # compiler probably has never heard of

Re: building trunk fails due to C++

2011-11-22 Thread Gary Funck
On 11/22/11 18:19:55, Michael Matz wrote: > > This particular compilation (insn-emit.c) has been running for > > 5.5 hours. Typically, a full bootstrap (with minimal checks) would > > finish in much less than 30 minutes on this server. > > Yes, don't use --enable-checking=all for bootstraps. =al

Re: PATCH RFA: Build stages 2 and 3 with C++

2011-11-22 Thread Gary Funck
A comment on the documentation: > Index: gcc/doc/install.texi > === > --- gcc/doc/install.texi (revision 176348) > +++ gcc/doc/install.texi (working copy) > @@ -1286,6 +1286,13 @@ will try to guess whether the @code{.ini >

Re: building trunk fails due to C++

2011-11-22 Thread Gary Funck
On 11/09/11 14:22:22, Steve Kargl wrote: > > Besides bootstrapping, you could use --disable-libitm or it might also > > work to specify --disable-build-poststage1-with-cxx which also saves you > > from building the C++ compiler if you don't want it. > > Doing a full bootstrap adds 3+ hours on my

Re: int_cst_hash_table mapping persistence and the garbage collector

2011-10-13 Thread Gary Funck
On 10/13/11 06:15:31, Laurynas Biveinis wrote: > [...] In your case (correct me if I misunderstood something) > you have one hash table, marking of which will mark more objects > which are required for the correct marking of the second hash table. > GC might be simply walking the second one first.

Re: int_cst_hash_table mapping persistence and the garbage collector

2011-10-12 Thread Gary Funck
On 10/12/11 14:00:54, Richard Guenther wrote: > I think there is an issue when two cache htabs refer to each other > with respect to GC, you might search the list to find out more. Richard, thanks. I thought that might be the case, but I don't understand the GC well enough to make this determinat

Re: int_cst_hash_table mapping persistence and the garbage collector

2011-10-12 Thread Gary Funck
On 10/12/11 09:27:43, Eric Botcazou wrote: > > The problem is that the references to object C1 and C2 live in > > a hash table, and that although the referenced nodes will be retained > > by the garbage collector, their mapping in int_cst_hash_table is > > deleted by the GC. > > This isn't a simpl

Re: int_cst_hash_table mapping persistence and the garbage collector

2011-10-11 Thread Gary Funck
On 10/11/11 11:05:18, Eric Botcazou wrote: > > One easy way to address the current issue is to call > > tree_int_cst_equal() if the integer constant tree pointers > > do not match: > > > > if ((c1 != c2) && !tree_int_cst_equal (c1, c2)) > > /* integer constants aren't equal. */ > > You

Re: int_cst_hash_table mapping persistence and the garbage collector

2011-10-11 Thread Gary Funck
On 10/11/11 10:24:52, Richard Guenther wrote: > GF: 1. Is it valid to assume that pointer equality is sufficient > GF: to compare two integer constants for equality as long as they > GF: have identical type and value? > > Yes, if both constants are "live" The upc blocking factor hash table is dec

int_cst_hash_table mapping persistence and the garbage collector

2011-10-10 Thread Gary Funck
Recently, a few UPC test programs failed to compile due to mis-matches of parameters in a prototype and its corresponding function definition. The mis-match was based upon the apparent inequality of UPC layout qualifiers (blocking factors). UPC blocking factors are integer constants. They are re

Re: [Patch, C] options generation and language count

2011-09-02 Thread Gary Funck
On 09/02/11 13:42:32, Joseph S. Myers wrote: > [..] you should just generate #if/#error in the output [...] OK, take two, attached. (Confirmed that the #if works for the (<, ==, >) relationships between n_langs and the max. number of languages supported.) - Gary 2011-09-02 G

[Patch, C] options generation and language count

2011-09-01 Thread Gary Funck
2011-09-01 Gary Funck * opts.c (print_specific_help): Fix off-by-one compare in assertion check. * opts.h (CL_PARAMS, CL_WARNING, CL_OPTIMIZATION, CL_DRIVER, CL_TARGET, CL_COMMON, CL_JOINED, CL_SEPARATE, CL_UNDOCUMENTED): Increase by +5 to allow for

Re: tree hash maps and 'discards qualifiers' warnings?

2011-08-30 Thread Gary Funck
On 08/17/11 08:38:44, Gary Funck wrote: > > I have been looking at changing UPC's method of > recording the blocking factor so that it uses less space > in the tree type node. The suggested method for > achieving this space reduction is to use a hash table to > map poin

Re: options generation and language count

2011-08-30 Thread Gary Funck
On 08/30/11 15:52:12, Joseph S. Myers wrote: > Please send a patch. [... on points 1, 2, and 3]0 OK, will do. > GF: Also, the use of fixed masks is problematic. Perhaps the AWK script > GF: could be changed to also generate values for CL_PARAMS, etc., ensuring > GF: that will not conflict with t

options generation and language count

2011-08-29 Thread Gary Funck
Recently, we ran "make check" on the GCC built from the GUPC branck and compared it against "make check" run against the GCC trunk version of the most recent merge with the trunk. The following failure was detected on the GUPC branch. cc1: internal compiler error: in print_specific_help, at opts

Re: Add __builtin_complex to construct complex values (C1X CMPLX* macros)

2011-08-22 Thread Gary Funck
On 08/22/11 22:39:04, Joseph S. Myers wrote: [...] > This isn't a type modifier; neither is __builtin_types_compatible_p. It's > not within the first 28. [...] > I don't believe the comment is accurate; I'm not aware of any code for any > C-family front end that uses these values as mask bits at

Re: Add __builtin_complex to construct complex values (C1X CMPLX* macros)

2011-08-22 Thread Gary Funck
On 08/19/11 15:55:12, Joseph S. Myers wrote: > Index: gcc/c-family/c-common.h > === > --- gcc/c-family/c-common.h (revision 177894) > +++ gcc/c-family/c-common.h (working copy) > @@ -103,7 +103,7 @@ enum rid >/* C extensions *

tree hash maps and 'discards qualifiers' warnings?

2011-08-17 Thread Gary Funck
I have been looking at changing UPC's method of recording the blocking factor so that it uses less space in the tree type node. The suggested method for achieving this space reduction is to use a hash table to map pointers to type nodes into UPC blocking factors (for less commonly used blocking

Re: RFC: [GUPC] UPC-related front-end changes

2011-07-02 Thread Gary Funck
Off list, Mike S. pointed out that the Objective C front-end uses the lang-specific extensions to GCC's tree node, and it shares logic with the C and C++ front ends. Therefore, the lang-specific extensions might offer an alternative approach for storing UPC's layout qualifier. The current plan, h

Re: RFC: [GUPC] UPC-related front-end changes

2011-07-02 Thread Gary Funck
On 07/02/11 15:21:32, Joseph S. Myers wrote: [...] > In general configure options aren't really a good idea in many cases: > > * If something is always best on a particular architecture, maybe you want > a target hook (not macro) rather than a configure option, with the target > hook being set a

  1   2   >