[gitignore] Add cscope.out to .gitignore

2021-06-23 Thread Prathamesh Kulkarni via Gcc-patches
Hi, This patch adds an entry for cscope.out in .gitignore. OK to commit ? Thanks, Prathamesh ignore-cscope.diff Description: Binary data

[ARM] PR66791: Gate comparison in vca intrinsics on __FAST_MATH__

2021-06-22 Thread Prathamesh Kulkarni via Gcc-patches
Hi, The attached patch gates abs(__a) cmp abs(__b) for vca intrinsics on __FAST_MATH__. I moved vabs intrinsics before vcage_f32 since vca intrinsics use those. Bootstrapped+tested on arm-linux-gnueabihf. OK to commit ? Thanks, Prathamesh 2021-06-22 Prathamesh Kulkarni PR target/66791

Re: [ARM] PR66791: Replace calls to builtin in vmul_n (a, b) intrinsics with __a * __b

2021-06-21 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 14 Jun 2021 at 13:27, Prathamesh Kulkarni wrote: > > On Mon, 7 Jun 2021 at 12:45, Prathamesh Kulkarni > wrote: > > > > On Mon, 31 May 2021 at 16:01, Prathamesh Kulkarni > > wrote: > > > > > > On Mon, 31 May 2021 at 15:22, Prathamesh Kulkarni

Re: [ARM] PR98435: Missed optimization in expanding vector constructor

2021-06-21 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 14 Jun 2021 at 13:31, Prathamesh Kulkarni wrote: > > On Wed, 9 Jun 2021 at 15:58, Prathamesh Kulkarni > wrote: > > > > On Fri, 4 Jun 2021 at 13:15, Christophe Lyon > > wrote: > > > > > > On Fri, 4 Jun 2021 at 09:27, Prathamesh Kulkarni via

Re: [ARM] PR97906 - Missed lowering abs(a) >= abs(b) to vacge

2021-06-21 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 16 Jun 2021 at 15:49, Prathamesh Kulkarni wrote: > > On Mon, 14 Jun 2021 at 16:15, Kyrylo Tkachov wrote: > > > > > > > > > -Original Message- > > > From: Prathamesh Kulkarni > > > Sent: 14 June 2021 08:58 > > > To:

Re: [ARM] PR97906 - Missed lowering abs(a) >= abs(b) to vacge

2021-06-16 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 14 Jun 2021 at 16:15, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Prathamesh Kulkarni > > Sent: 14 June 2021 08:58 > > To: gcc Patches ; Kyrylo Tkachov > > > > Subject: Re: [ARM] PR97906 - Missed lowering abs(a)

Re: [ARM] PR98435: Missed optimization in expanding vector constructor

2021-06-14 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 9 Jun 2021 at 15:58, Prathamesh Kulkarni wrote: > > On Fri, 4 Jun 2021 at 13:15, Christophe Lyon > wrote: > > > > On Fri, 4 Jun 2021 at 09:27, Prathamesh Kulkarni via Gcc-patches > > wrote: > > > > > > Hi, > > > As mentioned in

Re: [ARM NEON] PR66791: Replace builtins in vceq_* (a, b) with a == b.

2021-06-14 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 9 Jun 2021 at 14:49, Prathamesh Kulkarni wrote: > > Hi, > The attached patch replaces calls to _builtin_neon_vceq (a, b) with a > == b > for integral variants, and for fp variants it gates the equality > comparison on __FAST_MATH__ because for fp variants a == b result

Re: [ARM] PR97906 - Missed lowering abs(a) >= abs(b) to vacge

2021-06-14 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 7 Jun 2021 at 12:46, Prathamesh Kulkarni wrote: > > On Tue, 1 Jun 2021 at 16:03, Prathamesh Kulkarni > wrote: > > > > Hi, > > As mentioned in PR, for following test-case: > > > > #include > > > > uint32x2_t f1(float32x2_t a, float32x2_

Re: [ARM] PR66791: Replace calls to builtin in vmul_n (a, b) intrinsics with __a * __b

2021-06-14 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 7 Jun 2021 at 12:45, Prathamesh Kulkarni wrote: > > On Mon, 31 May 2021 at 16:01, Prathamesh Kulkarni > wrote: > > > > On Mon, 31 May 2021 at 15:22, Prathamesh Kulkarni > > wrote: > > > > > > On Wed, 26 May 2021 at 14:07, Marc Gliss

Re: [ARM] PR98435: Missed optimization in expanding vector constructor

2021-06-09 Thread Prathamesh Kulkarni via Gcc-patches
On Fri, 4 Jun 2021 at 13:15, Christophe Lyon wrote: > > On Fri, 4 Jun 2021 at 09:27, Prathamesh Kulkarni via Gcc-patches > wrote: > > > > Hi, > > As mentioned in PR, for the following test-case: > > > > #include > > > > bfloat16x4

[ARM NEON] PR66791: Replace builtins in vceq_* (a, b) with a == b.

2021-06-09 Thread Prathamesh Kulkarni via Gcc-patches
both produce vceq.f32 with -ffast-math. Thanks, Prathamesh 2021-06-09 Prathamesh Kulkarni * config/arm/arm_neon.h (vceq_s8): Replace builtin with __a == __b. (vceq_s16): Likewise. (vceq_s32): Likewise. (vceq_u8): Likewise. (vceq_u16): Likewise

Re: [ARM] PR97906 - Missed lowering abs(a) >= abs(b) to vacge

2021-06-07 Thread Prathamesh Kulkarni via Gcc-patches
On Tue, 1 Jun 2021 at 16:03, Prathamesh Kulkarni wrote: > > Hi, > As mentioned in PR, for following test-case: > > #include > > uint32x2_t f1(float32x2_t a, float32x2_t b) > { > return vabs_f32 (a) >= vabs_f32 (b); > } > > uint32x2_t f2(float32x2_t a, fl

Re: [ARM] PR66791: Replace calls to builtin in vmul_n (a, b) intrinsics with __a * __b

2021-06-07 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 31 May 2021 at 16:01, Prathamesh Kulkarni wrote: > > On Mon, 31 May 2021 at 15:22, Prathamesh Kulkarni > wrote: > > > > On Wed, 26 May 2021 at 14:07, Marc Glisse wrote: > > > > > > On Wed, 26 May 2021, Prathamesh Kulkarni via Gcc-patches wrote: &

[ARM] PR98435: Missed optimization in expanding vector constructor

2021-06-04 Thread Prathamesh Kulkarni via Gcc-patches
Hi, As mentioned in PR, for the following test-case: #include bfloat16x4_t f1 (bfloat16_t a) { return vdup_n_bf16 (a); } bfloat16x4_t f2 (bfloat16_t a) { return (bfloat16x4_t) {a, a, a, a}; } Compiling with arm-linux-gnueabi -O3 -mfpu=neon -mfloat-abi=softfp -march=armv8.2-a+bf16+fp16

[ARM] PR97906 - Missed lowering abs(a) >= abs(b) to vacge

2021-06-01 Thread Prathamesh Kulkarni via Gcc-patches
ss-tested on arm*-*-*. OK to commit ? Thanks, Prathamesh 2021-06-01 Prathamesh Kulkarni PR target/97906 * config/arm/iterators.md (NEON_VACMP): Remove. * config/arm/neon.md (neon_vca): Use GLTE instead of GTGE iterator. (neon_vca_insn):

Re: [ARM] PR66791: Replace calls to builtin in vmul_n (a, b) intrinsics with __a * __b

2021-05-31 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 31 May 2021 at 15:22, Prathamesh Kulkarni wrote: > > On Wed, 26 May 2021 at 14:07, Marc Glisse wrote: > > > > On Wed, 26 May 2021, Prathamesh Kulkarni via Gcc-patches wrote: > > > > > The attached patch removes calls to builtins in vmul_n* (a, b) wi

Re: [ARM] PR66791: Replace calls to builtin in vmul_n (a, b) intrinsics with __a * __b

2021-05-31 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 26 May 2021 at 14:07, Marc Glisse wrote: > > On Wed, 26 May 2021, Prathamesh Kulkarni via Gcc-patches wrote: > > > The attached patch removes calls to builtins in vmul_n* (a, b) with __a * > > __b. > > I am not familiar with neon, but are __a and __b unsigned h

[ARM] PR66791: Replace calls to builtin in vmul_n (a, b) intrinsics with __a * __b

2021-05-26 Thread Prathamesh Kulkarni via Gcc-patches
lr -.L13: - .align 3 -.L12: - .short 0 - .short 0 - .short 0 - .short 0 .size test_vmul_n_16x8, .-test_vmul_n_16x8 Adjusted the test, to fix the failing tests. OK to commit if testing passes ? Thanks, Prathamesh 2021-26-05 Prathamesh Kulkarni

Re: [PR66791][ARM] Replace __builtin_neon_vtst*

2021-05-13 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 12 May 2021 at 20:33, Richard Earnshaw wrote: > > On 12/05/2021 12:05, Prathamesh Kulkarni via Gcc-patches wrote: > > On Wed, 12 May 2021 at 16:02, Richard Earnshaw > > wrote: > >> > >> > >> > >> On 12/05/2021 08:46, Prathamesh Kul

Re: [PR66791][ARM] Replace __builtin_neon_vtst*

2021-05-12 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 12 May 2021 at 16:02, Richard Earnshaw wrote: > > > > On 12/05/2021 08:46, Prathamesh Kulkarni via Gcc-patches wrote: > > On Mon, 10 May 2021 at 19:55, Richard Earnshaw > > wrote: > >> > >> > >> > >> On 06/05/202

Re: [PR66791][ARM] Replace __builtin_neon_vtst*

2021-05-12 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 10 May 2021 at 19:55, Richard Earnshaw wrote: > > > > On 06/05/2021 01:14, Prathamesh Kulkarni via Gcc-patches wrote: > > Hi, > > The attached patch replaces __builtin_neon_vtst* (a, b) with (a & b) != 0. > > Bootstrapped and tested on arm-linux

[PR66791][ARM] Replace __builtin_neon_vtst*

2021-05-05 Thread Prathamesh Kulkarni via Gcc-patches
Hi, The attached patch replaces __builtin_neon_vtst* (a, b) with (a & b) != 0. Bootstrapped and tested on arm-linux-gnueabihf and cross-tested on arm*-*-*. OK to commit ? Thanks, Prathamesh vtst-1.diff Description: Binary data

Re: [PR97903][ARM] Missed optimization in lowering to vtst

2021-05-05 Thread Prathamesh Kulkarni via Gcc-patches
On Fri, 5 Feb 2021 at 15:42, Kyrylo Tkachov wrote: > > Hi Prathamesh, > > > -Original Message- > > From: Prathamesh Kulkarni > > Sent: 05 February 2021 09:53 > > To: gcc Patches ; Kyrylo Tkachov > > > > Subject: [PR97903][ARM] Misse

Re: [PR94092] Re: [RFC] test builtin ratio for loop distribution

2021-05-03 Thread Prathamesh Kulkarni via Gcc-patches
On Tue, 4 May 2021 at 07:30, Alexandre Oliva wrote: > > On May 3, 2021, Richard Biener wrote: > > > On Fri, Apr 30, 2021 at 4:42 PM Jeff Law wrote: > >> > >> > >> On 4/28/2021 10:26 PM, Alexandre Oliva wrote: > >> > On Feb 22, 2021, Richard Biener wrote: > >> > > >> >> On Fri, Feb 19, 2021 at

Re: [PATCH] tree-optimization/99912 - delete trivially dead stmts during DSE

2021-04-27 Thread Prathamesh Kulkarni via Gcc-patches
On Tue, 27 Apr 2021 at 19:19, Richard Biener wrote: > > DSE performs a backwards walk over stmts removing stores but it > leaves removing resulting dead SSA defs to later passes. This > eats into its own alias walking budget if the removed stores kept > loads live. The following patch adds

Re: [PATCH] testsuite/arm: Add mve-vadd-1.c test

2021-04-27 Thread Prathamesh Kulkarni via Gcc-patches
On Tue, 27 Apr 2021 at 17:02, Christophe Lyon via Gcc-patches wrote: > > Support for vadd has been present for a while, but it was lacking a > test. > > 2021-04-22 Christophe Lyon > > gcc/testsuite/ > * gcc.target/arm/simd/mve-vadd-1.c: New. > --- >

Re: [PATCH 1/1] libiberty(argv.c): Fix memory leak in expandargv.

2021-02-18 Thread Prathamesh Kulkarni via Gcc-patches
On Thu, 18 Feb 2021 at 16:32, Ayush Mittal via Gcc-patches wrote: > > Dynamic memory referenced by 'buffer' was allocated using xmalloc but fails > to free it > when jump to 'error' label. > > Issue as per static analysis tool. > > Signed-off-by: Ayush Mittal > Signed-off-by: Maninder Singh >

[PR97903][ARM] Missed optimization in lowering to vtst

2021-02-05 Thread Prathamesh Kulkarni via Gcc-patches
Hi, For the following test-case: #include uint8x8_t f1(int8x8_t a, int8x8_t b) { return (uint8x8_t) ((a & b) != 0); } gcc fails to lower test operation to vtst, and instead emits: f1: vandd0, d0, d1 vceq.i8 d0, d0, #0 vmvnd0, d0 bx lr The

Re: [ARM] PR98636 - ICE on passing incompatible options for fp16

2021-01-22 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 20 Jan 2021 at 17:23, Martin Liška wrote: > > On 1/19/21 5:55 PM, Prathamesh Kulkarni wrote: > > Hi, > > The attached patch fixes the issue mentioned in PR, by adding > > arm_fp16_format to checked_options in optc-save-gen.awk. > > Is this OK to commi

[ARM] PR98636 - ICE on passing incompatible options for fp16

2021-01-19 Thread Prathamesh Kulkarni via Gcc-patches
Hi, The attached patch fixes the issue mentioned in PR, by adding arm_fp16_format to checked_options in optc-save-gen.awk. Is this OK to commit in stage-4 if testing passes or should we hold it till next stage-1 ? Thanks, Prathamesh pr98636-2.diff Description: Binary data

[PR66791][ARM] Replace __builtin_neon_vcge* with >= and <= for vcge and vcle intrinsics

2021-01-14 Thread Prathamesh Kulkarni via Gcc-patches
Hi, The attached patch removes __builtin_neon_vcge* function with >= and <= operators for vcge and vcle intrinsics respectively. Cross tested on arm*-*-*. OK for trunk ? Thanks, Prathamesh vcge-1.diff Description: Binary data

Re: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in vext intrinsics

2021-01-05 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 4 Jan 2021 at 16:01, Kyrylo Tkachov wrote: > > Hi Prathamesh > > > -Original Message- > > From: Prathamesh Kulkarni > > Sent: 04 January 2021 10:27 > > To: gcc Patches ; Kyrylo Tkachov > > > > Subject: [PR66791][ARM] Replace __bui

[PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in vext intrinsics

2021-01-04 Thread Prathamesh Kulkarni via Gcc-patches
Hi Kyrill, The attached patch replaces __builtin_vextv8qi with __builtin_shuffle for vext_s8. Just wanted to confirm if this is in the correct direction ? If yes, I will send a follow up patch that converts for all vext intrinsics. Thanks, Prathamesh vext-1.diff Description: Binary data

Re: [PATCH] arm: Fix bootstrap

2020-12-17 Thread Prathamesh Kulkarni via Gcc-patches
On Thu, 17 Dec 2020 at 21:04, Andrea Corallo wrote: > > Kyrylo Tkachov writes: > > >> -Original Message- > >> From: Andrea Corallo > >> Sent: 17 December 2020 14:56 > >> To: gcc-patches@gcc.gnu.org > >> Cc: Kyrylo Tkac

Re: [PATCH] Fix up testcase.

2020-12-10 Thread Prathamesh Kulkarni via Gcc-patches
On Fri, 11 Dec 2020 at 10:46, Hongtao Liu wrote: > > On Thu, Dec 10, 2020 at 8:52 PM Prathamesh Kulkarni > wrote: > > > > On Wed, 9 Dec 2020 at 15:52, Hongtao Liu wrote: > > > > > > On Wed, Dec 9, 2020 at 5:22 PM Prathamesh Kulkarni via Gcc-patches >

Re: Help with PR97872

2020-12-10 Thread Prathamesh Kulkarni via Gcc-patches
On Thu, 10 Dec 2020 at 17:11, Richard Biener wrote: > > On Wed, 9 Dec 2020, Prathamesh Kulkarni wrote: > > > On Tue, 8 Dec 2020 at 14:36, Prathamesh Kulkarni > > wrote: > > > > > > On Mon, 7 Dec 2020 at 17:37, Hongtao Liu wrote: > > > > > &g

Re: [PATCH] Fix up testcase.

2020-12-10 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 9 Dec 2020 at 15:52, Hongtao Liu wrote: > > On Wed, Dec 9, 2020 at 5:22 PM Prathamesh Kulkarni via Gcc-patches > wrote: > > > > On Wed, 9 Dec 2020 at 00:29, sunil.k.pandey wrote: > > > > > > On Linux/x86_64, > > > > > > 3a6e3ad

Re: Help with PR97872

2020-12-09 Thread Prathamesh Kulkarni via Gcc-patches
On Tue, 8 Dec 2020 at 14:36, Prathamesh Kulkarni wrote: > > On Mon, 7 Dec 2020 at 17:37, Hongtao Liu wrote: > > > > On Mon, Dec 7, 2020 at 7:11 PM Prathamesh Kulkarni > > wrote: > > > > > > On Mon, 7 Dec 2020 at 16:15, Hongtao Liu wrote: > > &g

Re: [r11-5839 Regression] FAIL: gcc.target/i386/pr78102.c scan-assembler-times pcmpeqq 3 on Linux/x86_64

2020-12-09 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 9 Dec 2020 at 00:29, sunil.k.pandey wrote: > > On Linux/x86_64, > > 3a6e3ad38a17a03ee0139b49a0946e7b9ded1eb1 is the first bad commit > commit 3a6e3ad38a17a03ee0139b49a0946e7b9ded1eb1 > Author: Prathamesh Kulkarni > Date: Tue Dec 8 14:30:04 2020 +0530 > >

[ARM][PR66791] Replace builtins for vclt and vcgt intrinsics in arm_neon.h

2020-12-08 Thread Prathamesh Kulkarni via Gcc-patches
Hi, This patch replaces calls to __builtin_neon_vcgt* by < and > in vclt and vcgt intrinsics respectively, and removes entry to vcgt from arm_neon_builtins.def. OK to commit ? Thanks, Prathamesh vclt-2.diff Description: Binary data

Re: [PR66791][ARM] Replace __builtin_neon_vneg* by - for vneg intrinsics

2020-12-08 Thread Prathamesh Kulkarni via Gcc-patches
On Thu, 3 Dec 2020 at 16:23, Prathamesh Kulkarni wrote: > > Hi, > This patch replaces calls to __builtin_neon_vneg* builtins by - > operator, for vneg intrinsics in arm_neon.h. > Cross-tested on arm*-*-*. > OK to commit ? This patch removes call to entry for vneg from arm

Re: [PR66791][ARM] Replace __builtin_neon_vcreate* for vcreate intrinsics

2020-12-08 Thread Prathamesh Kulkarni via Gcc-patches
On Fri, 4 Dec 2020 at 16:26, Prathamesh Kulkarni wrote: > > On Thu, 3 Dec 2020 at 16:50, Kyrylo Tkachov wrote: > > > > Hi Prathamesh, > > > > > -Original Message- > > > From: Prathamesh Kulkarni > > > Sent: 03 Decembe

Re: Help with PR97872

2020-12-08 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 7 Dec 2020 at 17:37, Hongtao Liu wrote: > > On Mon, Dec 7, 2020 at 7:11 PM Prathamesh Kulkarni > wrote: > > > > On Mon, 7 Dec 2020 at 16:15, Hongtao Liu wrote: > > > > > > On Mon, Dec 7, 2020 at 5:47 PM Richard Biener wrote: > > > > &g

Re: [PR66791][ARM] Replace calls to __builtin_neon_vmvn* by ~ for vmvn intrinsics

2020-12-07 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 7 Dec 2020 at 16:34, Kyrylo Tkachov wrote: > > Hi Prathamesh, > > > -Original Message- > > From: Prathamesh Kulkarni > > Sent: 07 December 2020 11:01 > > To: Kyrylo Tkachov > > Cc: gcc-patches@gcc.gnu.org > > Subject: Re: [PR667

Re: [PR66791][ARM] Replace calls to __builtin_neon_vmvn* by ~ for vmvn intrinsics

2020-12-07 Thread Prathamesh Kulkarni via Gcc-patches
On Thu, 3 Dec 2020 at 16:05, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Gcc-patches On Behalf Of > > Prathamesh Kulkarni via Gcc-patches > > Sent: 03 December 2020 10:30 > > To: gcc Patches ; Kyrill Tkachov > >

Re: [PR66791][ARM] Replace __builtin_neon_vcreate* for vcreate intrinsics

2020-12-04 Thread Prathamesh Kulkarni via Gcc-patches
On Thu, 3 Dec 2020 at 16:50, Kyrylo Tkachov wrote: > > Hi Prathamesh, > > > -Original Message- > > From: Prathamesh Kulkarni > > Sent: 03 December 2020 10:50 > > To: gcc Patches ; Kyrylo Tkachov > > > > Subject: [PR66791][ARM] Replace __bui

[PR66791][ARM] Replace __builtin_neon_vneg* by - for vneg intrinsics

2020-12-03 Thread Prathamesh Kulkarni via Gcc-patches
Hi, This patch replaces calls to __builtin_neon_vneg* builtins by - operator, for vneg intrinsics in arm_neon.h. Cross-tested on arm*-*-*. OK to commit ? Thanks, Prathamesh vneg-1.diff Description: Binary data

[PR66791][ARM] Replace __builtin_neon_vcreate* for vcreate intrinsics

2020-12-03 Thread Prathamesh Kulkarni via Gcc-patches
Hi, This patch replaces calls to __builtin_neon_vcreate* builtins for vcreate intrinsics in arm_neon.h. Cross-tested on arm*-*-*. OK to commit ? Thanks, Prathamesh vcreate-1.diff Description: Binary data

Re: [PR66791][ARM] Replace calls to __builtin_neon_vmvn* by ~ for vmvn intrinsics

2020-12-03 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 25 Nov 2020 at 22:01, Prathamesh Kulkarni wrote: > > Hi, > This patch replaces calls to __builtin_neon_vmvnv* builtins with ~ > operator in arm_neon.h. > Cross-tested on arm*-*-*. > OK to commit ? ping https://gcc.gnu.org/pipermail/gcc-patches/2020-November/560223.html

[PR66791][ARM] Replace calls to __builtin_neon_vmvn* by ~ for vmvn intrinsics

2020-11-25 Thread Prathamesh Kulkarni via Gcc-patches
Hi, This patch replaces calls to __builtin_neon_vmvnv* builtins with ~ operator in arm_neon.h. Cross-tested on arm*-*-*. OK to commit ? Thanks, Prathamesh vmvn-1.diff Description: Binary data

Re: PR97849: aarch64: ICE (segfault) during GIMPLE pass: ifcvt

2020-11-23 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 18 Nov 2020 at 19:13, Richard Biener wrote: > > On Wed, 18 Nov 2020, Prathamesh Kulkarni wrote: > > > Hi, > > For the following test-case (slightly reduced from PR) > > int a, b, c; > > > > int g() { > > char i = 0; > > for (

PR97849: aarch64: ICE (segfault) during GIMPLE pass: ifcvt

2020-11-18 Thread Prathamesh Kulkarni via Gcc-patches
Hi, For the following test-case (slightly reduced from PR) int a, b, c; int g() { char i = 0; for (c = 0; c <= 8; c++) --i; while (b) { _Bool f = i <= 0; a = (a == 0) ? 0 : f / a; } } The compiler segfaults with -O1 -march=armv8.2-a+sve in ifcvt_local_dce. IIUC, the issue

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-24 Thread Prathamesh Kulkarni
On Mon, 24 Feb 2020 at 18:40, Christophe Lyon wrote: > > On Mon, 24 Feb 2020 at 07:32, Prathamesh Kulkarni > wrote: > > > > On Wed, 19 Feb 2020 at 19:54, Richard Biener > > wrote: > > > > > > On Wed, Feb 19, 2020 at 12:19 AM Prathamesh Kulkarni >

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-23 Thread Prathamesh Kulkarni
On Wed, 19 Feb 2020 at 19:54, Richard Biener wrote: > > On Wed, Feb 19, 2020 at 12:19 AM Prathamesh Kulkarni > wrote: > > > > On Tue, 18 Feb 2020 at 19:40, Richard Biener > > wrote: > > > > > > On Tue, Feb 18, 2020 at 1:52 PM Prathamesh Kulkarni

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-18 Thread Prathamesh Kulkarni
On Tue, 18 Feb 2020 at 19:40, Richard Biener wrote: > > On Tue, Feb 18, 2020 at 1:52 PM Prathamesh Kulkarni > wrote: > > > > On Mon, 17 Feb 2020 at 19:52, Richard Biener > > wrote: > > > > > > On Mon, Feb 17, 2020 at 10:28 AM Prathamesh Kulkarni >

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-18 Thread Prathamesh Kulkarni
On Mon, 17 Feb 2020 at 19:52, Richard Biener wrote: > > On Mon, Feb 17, 2020 at 10:28 AM Prathamesh Kulkarni > wrote: > > > > On Thu, 6 Feb 2020 at 20:03, Prathamesh Kulkarni > > wrote: > > > > > > On Thu, 6 Feb 2020 at 18:42, Richard Biener >

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-17 Thread Prathamesh Kulkarni
On Thu, 6 Feb 2020 at 20:03, Prathamesh Kulkarni wrote: > > On Thu, 6 Feb 2020 at 18:42, Richard Biener > wrote: > > > > On Thu, Feb 6, 2020 at 1:48 PM Prathamesh Kulkarni > > wrote: > > > > > > On Tue, 4 Feb 2020 at 19:44, Richard Biener >

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-02-11 Thread Prathamesh Kulkarni
On Tue, 4 Feb 2020 at 14:54, Prathamesh Kulkarni wrote: > > On Mon, 3 Feb 2020 at 14:56, Prathamesh Kulkarni > wrote: > > > > On Mon, 3 Feb 2020 at 14:41, Prathamesh Kulkarni > > wrote: > > > > > > On Thu, 30 Jan 2020 at 19:17, Richard Biener >

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-06 Thread Prathamesh Kulkarni
On Thu, 6 Feb 2020 at 18:42, Richard Biener wrote: > > On Thu, Feb 6, 2020 at 1:48 PM Prathamesh Kulkarni > wrote: > > > > On Tue, 4 Feb 2020 at 19:44, Richard Biener > > wrote: > > > > > > On Mon, Feb 3, 2020 at 12:37 PM Prathamesh Kulkarni >

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-06 Thread Prathamesh Kulkarni
On Tue, 4 Feb 2020 at 19:44, Richard Biener wrote: > > On Mon, Feb 3, 2020 at 12:37 PM Prathamesh Kulkarni > wrote: > > > > On Thu, 30 Jan 2020 at 19:10, Richard Biener > > wrote: > > > > > > On Thu, Jan 30, 2020 at 5:31 AM Prathamesh Kulkarni >

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-02-04 Thread Prathamesh Kulkarni
On Mon, 3 Feb 2020 at 14:56, Prathamesh Kulkarni wrote: > > On Mon, 3 Feb 2020 at 14:41, Prathamesh Kulkarni > wrote: > > > > On Thu, 30 Jan 2020 at 19:17, Richard Biener > > wrote: > > > > > > On Thu, Jan 30, 2020 at 11:49 AM Prathamesh Kulkarni

Re: [PR47785] COLLECT_AS_OPTIONS

2020-02-03 Thread Prathamesh Kulkarni
On Thu, 30 Jan 2020 at 19:10, Richard Biener wrote: > > On Thu, Jan 30, 2020 at 5:31 AM Prathamesh Kulkarni > wrote: > > > > On Tue, 28 Jan 2020 at 17:17, Richard Biener > > wrote: > > > > > > On Fri, Jan 24, 2020 at 7:04 AM Prathamesh Kulkarni >

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-02-03 Thread Prathamesh Kulkarni
On Mon, 3 Feb 2020 at 14:41, Prathamesh Kulkarni wrote: > > On Thu, 30 Jan 2020 at 19:17, Richard Biener > wrote: > > > > On Thu, Jan 30, 2020 at 11:49 AM Prathamesh Kulkarni > > wrote: > > > > > > On Wed, 29 Jan 2020 at 14:38, Richard Biener >

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-02-03 Thread Prathamesh Kulkarni
On Thu, 30 Jan 2020 at 19:17, Richard Biener wrote: > > On Thu, Jan 30, 2020 at 11:49 AM Prathamesh Kulkarni > wrote: > > > > On Wed, 29 Jan 2020 at 14:38, Richard Biener > > wrote: > > > > > > On Tue, Jan 28, 2020 at 1:02 PM Jakub Jelinek wrote:

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-01-30 Thread Prathamesh Kulkarni
On Wed, 29 Jan 2020 at 14:38, Richard Biener wrote: > > On Tue, Jan 28, 2020 at 1:02 PM Jakub Jelinek wrote: > > > > On Tue, Jan 28, 2020 at 05:09:36PM +0530, Prathamesh Kulkarni wrote: > > > On Tue, 28 Jan 2020 at 17:00, Jakub Jelinek wrote: > > > > >

Re: [PR47785] COLLECT_AS_OPTIONS

2020-01-29 Thread Prathamesh Kulkarni
On Tue, 28 Jan 2020 at 17:17, Richard Biener wrote: > > On Fri, Jan 24, 2020 at 7:04 AM Prathamesh Kulkarni > wrote: > > > > On Mon, 20 Jan 2020 at 15:44, Richard Biener > > wrote: > > > > > > On Wed, Jan 8, 2020 at 11:20 AM Prathamesh Kulkarni >

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-01-28 Thread Prathamesh Kulkarni
On Tue, 28 Jan 2020 at 17:00, Jakub Jelinek wrote: > > On Tue, Jan 28, 2020 at 04:56:59PM +0530, Prathamesh Kulkarni wrote: > > Thanks for the suggestions. In the attached patch I bumped up value of > > ERF_RETURNS_ARG_MASK > > to UINT_MAX >> 2, and use hi

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-01-28 Thread Prathamesh Kulkarni
On Mon, 27 Jan 2020 at 17:36, Richard Biener wrote: > > On Fri, Jan 24, 2020 at 11:53 PM Joseph Myers wrote: > > > > On Fri, 24 Jan 2020, Prathamesh Kulkarni wrote: > > > > > The middle-end representation issue of ERF_RETURNS_ARG still remains, > > > whi

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-01-24 Thread Prathamesh Kulkarni
On Tue, 21 Jan 2020 at 04:35, Joseph Myers wrote: > > On Mon, 20 Jan 2020, Prathamesh Kulkarni wrote: > > > Hi, > > This patch attempts to add returns_arg attribute for c-family > > languages. For C++ methods, first arg is assumed to be this pointer, > > Th

Re: [PR47785] COLLECT_AS_OPTIONS

2020-01-23 Thread Prathamesh Kulkarni
On Mon, 20 Jan 2020 at 15:44, Richard Biener wrote: > > On Wed, Jan 8, 2020 at 11:20 AM Prathamesh Kulkarni > wrote: > > > > On Tue, 5 Nov 2019 at 17:38, Richard Biener > > wrote: > > > > > > On Tue, Nov 5, 2019 at 12:17 AM Kugan Vive

[RFC] [c-family] PR92867 - Add returns_arg attribute

2020-01-20 Thread Prathamesh Kulkarni
Hi, This patch attempts to add returns_arg attribute for c-family languages. For C++ methods, first arg is assumed to be this pointer, similar to alloc_size. I have a couple of doubts: (a) I am not sure why DECL_ARGUMENTS (decl) in handle_returns_arg_attribute returns NULL ? My intent was to

Re: [PR47785] COLLECT_AS_OPTIONS

2020-01-14 Thread Prathamesh Kulkarni
On Wed, 8 Jan 2020 at 15:50, Prathamesh Kulkarni wrote: > > On Tue, 5 Nov 2019 at 17:38, Richard Biener > wrote: > > > > On Tue, Nov 5, 2019 at 12:17 AM Kugan Vivekanandarajah > > wrote: > > > > > > Hi, > > > Thanks for the review. &

Re: [PR47785] COLLECT_AS_OPTIONS

2020-01-08 Thread Prathamesh Kulkarni
On Tue, 5 Nov 2019 at 17:38, Richard Biener wrote: > > On Tue, Nov 5, 2019 at 12:17 AM Kugan Vivekanandarajah > wrote: > > > > Hi, > > Thanks for the review. > > > > On Tue, 5 Nov 2019 at 03:57, H.J. Lu wrote: > > > > > > On Sun, Nov 3, 2019 at 6:45 PM Kugan Vivekanandarajah > > > wrote: > > >

Re: [SVE] PR89007 - Implement generic vector average expansion

2019-12-09 Thread Prathamesh Kulkarni
On Thu, 5 Dec 2019 at 18:17, Richard Biener wrote: > > On Thu, 5 Dec 2019, Prathamesh Kulkarni wrote: > > > On Fri, 29 Nov 2019 at 15:41, Richard Biener > > wrote: > > > > > > On Fri, Nov 22, 2019 at 12:40 PM Prathamesh Kulkarni > > > wro

Re: [SVE] PR89007 - Implement generic vector average expansion

2019-12-05 Thread Prathamesh Kulkarni
On Fri, 29 Nov 2019 at 15:41, Richard Biener wrote: > > On Fri, Nov 22, 2019 at 12:40 PM Prathamesh Kulkarni > wrote: > > > > On Wed, 20 Nov 2019 at 16:54, Richard Biener wrote: > > > > > > On Wed, 20 Nov 2019, Richard Sandiford wrote: > > &

Re: [SVE] PR89007 - Implement generic vector average expansion

2019-11-29 Thread Prathamesh Kulkarni
On Fri, 22 Nov 2019 at 17:09, Prathamesh Kulkarni wrote: > > On Wed, 20 Nov 2019 at 16:54, Richard Biener wrote: > > > > On Wed, 20 Nov 2019, Richard Sandiford wrote: > > > > > Hi, > > > > > > Thanks for doing this. Adding Richard on cc:, sin

Re: [SVE] PR89007 - Implement generic vector average expansion

2019-11-22 Thread Prathamesh Kulkarni
> > here apart from the testcase. > > Ah. > > > > 2019-11-19 Prathamesh Kulkarni > > > > > > PR tree-optimization/89007 > > > * tree-vect-patterns.c (vect_recog_average_pattern): If there is no > > > target support avail

Re: PR92608 - ICE: Segmentation fault (in find_loop_guard)

2019-11-21 Thread Prathamesh Kulkarni
On Thu, 21 Nov 2019 at 13:42, Richard Biener wrote: > > On Thu, 21 Nov 2019, Prathamesh Kulkarni wrote: > > > Hi, > > The issue seems to happen with -O1, because header only contains phi: > > > >[local count: 118111600]: > > # iter.12_9 = PHI <0(2

PR92608 - ICE: Segmentation fault (in find_loop_guard)

2019-11-20 Thread Prathamesh Kulkarni
Hi, The issue seems to happen with -O1, because header only contains phi: [local count: 118111600]: # iter.12_9 = PHI <0(2), iter.12_10(10)> and thus we hit segfault in following hunk in find_loop_guard: else { cond = dyn_cast (last_stmt (header)); if (!

Re: [SVE] PR89007 - Implement generic vector average expansion

2019-11-19 Thread Prathamesh Kulkarni
On Mon, 18 Nov 2019 at 16:17, Kyrill Tkachov wrote: > > Hi Prathamesh, > > On 11/14/19 6:47 PM, Prathamesh Kulkarni wrote: > > Hi, > > As suggested in PR, the attached patch falls back to distributing > > rshift over plus_expr instead of fallback widening -> ari

[SVE] PR89007 - Implement generic vector average expansion

2019-11-14 Thread Prathamesh Kulkarni
hamesh 2019-11-15 Prathamesh Kulkarni PR tree-optimization/89007 * tree-vect-patterns.c (vect_recog_average_pattern): If there is no target support available, generate code to distribute rshift over plus and add one depending upon floor or ceil rounding. tes

Re: PR92163

2019-11-06 Thread Prathamesh Kulkarni
On Tue, 5 Nov 2019 at 18:36, Christophe Lyon wrote: > > On Tue, 5 Nov 2019 at 05:46, Prathamesh Kulkarni > wrote: > > > > On Mon, 4 Nov 2019 at 18:37, Christophe Lyon > > wrote: > > > > > > On Mon, 28 Oct 2019 at 16:03, Prathamesh Kulkarni >

Re: PR92163

2019-11-04 Thread Prathamesh Kulkarni
On Mon, 4 Nov 2019 at 18:37, Christophe Lyon wrote: > > On Mon, 28 Oct 2019 at 16:03, Prathamesh Kulkarni > wrote: > > > > On Mon, 28 Oct 2019 at 07:18, Richard Biener > > wrote: > > > > > > On Fri, Oct 25, 2019 at 9:58 PM Prathamesh Kulkarni >

Re: PR92163

2019-10-28 Thread Prathamesh Kulkarni
On Mon, 28 Oct 2019 at 07:18, Richard Biener wrote: > > On Fri, Oct 25, 2019 at 9:58 PM Prathamesh Kulkarni > wrote: > > > > On Fri, 25 Oct 2019 at 13:19, Richard Biener > > wrote: > > > > > > On Wed, Oct 23, 2019 at 11:45 PM Pratham

Re: [SVE] PR91272

2019-10-28 Thread Prathamesh Kulkarni
On Sun, 27 Oct 2019 at 06:08, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > @@ -10288,6 +10261,23 @@ vectorizable_condition (stmt_vec_info stmt_info, > > gimple_stmt_iterator *gsi, > > vect_finish_stmt_generation (

Re: PR92163

2019-10-25 Thread Prathamesh Kulkarni
On Fri, 25 Oct 2019 at 13:19, Richard Biener wrote: > > On Wed, Oct 23, 2019 at 11:45 PM Prathamesh Kulkarni > wrote: > > > > Hi, > > The attached patch tries to fix PR92163 by calling > > gimple_purge_dead_eh_edges from ifcvt_local_dce if we need eh cleanup.

Re: [SVE] PR91272

2019-10-25 Thread Prathamesh Kulkarni
the state > before the patch wouldn't have been that meaningful. In particular... > > Prathamesh Kulkarni writes: > > diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c > > index a70d52eb2ca..82814e2c2af 100644 > > --- a/gcc/tree-vect-loop.c > >

Re: [SVE] PR91272

2019-10-23 Thread Prathamesh Kulkarni
On Tue, 22 Oct 2019 at 13:12, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c > > index acdd90784dc..dfd33b142ed 100644 > > --- a/gcc/tree-vect-stmts.c > > +++ b/gcc/tree-vect-stmt

PR92163

2019-10-23 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR92163 by calling gimple_purge_dead_eh_edges from ifcvt_local_dce if we need eh cleanup. Does it look OK ? Thanks, Prathamesh 2019-10-24 Prathamesh Kulkarni PR tree-optimization/92163 * tree-if-conv.c (ifcvt_local_dce): Call

Re: [SVE] PR91272

2019-10-21 Thread Prathamesh Kulkarni
On Fri, 18 Oct 2019 at 14:36, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch tries to fix PR91272. > > Does it look OK ? > > > > With patch, I see following failures for aarch64-sve.exp: > > FAIL: gcc.target/a

Re: [testsuite] Add test for PR91532

2019-10-20 Thread Prathamesh Kulkarni
On Sat, 19 Oct 2019 at 23:45, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi Richard, > > Sorry for not adding the test in PR91532 fix. > > Is the attached patch OK to commit ? > > > > Thanks, > > Prathamesh > > > > 2

[testsuite] Add test for PR91532

2019-10-18 Thread Prathamesh Kulkarni
Hi Richard, Sorry for not adding the test in PR91532 fix. Is the attached patch OK to commit ? Thanks, Prathamesh 2019-10-18 Prathamesh Kulkarni PR tree-optimization/91532 testsuite/ * gcc.target/aarch64/sve/fmla_2.c: Add dg-scan check for deleted store. diff --git a/gcc

Re: [SVE] PR86753

2019-10-17 Thread Prathamesh Kulkarni
On Wed, 16 Oct 2019 at 04:19, Richard Sandiford wrote: > > Richard Biener writes: > > On Tue, Oct 15, 2019 at 8:07 AM Prathamesh Kulkarni > > wrote: > >> > >> On Wed, 9 Oct 2019 at 08:14, Prathamesh Kulkarni > >> wrote: > >> > > >&

[SVE] PR91272

2019-10-17 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR91272. Does it look OK ? With patch, I see following failures for aarch64-sve.exp: FAIL: gcc.target/aarch64/sve/clastb_1.c -march=armv8.2-a+sve scan-assembler \\tclastb\\tw[0-9]+, p[0-7], w[0-9]+, z[0-9]+\\.s FAIL: gcc.target/aarch64/sve/clastb_2.c

Re: PR92085

2019-10-15 Thread Prathamesh Kulkarni
On Mon, 14 Oct 2019 at 23:23, Jakub Jelinek wrote: > > On Mon, Oct 14, 2019 at 03:24:02PM -0700, Prathamesh Kulkarni wrote: > > The patch fixes this by simply putting gsi_next in else, which avoids > > the above issue. > > Bootstrap+test in progress on x86_64-unknown-lin

Re: [SVE] PR86753

2019-10-15 Thread Prathamesh Kulkarni
On Wed, 9 Oct 2019 at 08:14, Prathamesh Kulkarni wrote: > > On Tue, 8 Oct 2019 at 13:21, Richard Sandiford > wrote: > > > > Leaving the main review to Richard, just some comments... > > > > Prathamesh Kulkarni writes: > > > @@ -9774,6 +9777,10 @@ vect_

PR92085

2019-10-14 Thread Prathamesh Kulkarni
Hi, The issue with PR91532 patch was in following hunk in ifcvt_local_dce: if (dse_classify_store (, stmt, false, NULL, NULL, latch_vdef) == DSE_STORE_DEAD) delete_dead_or_redundant_assignment (, "dead"); gsi_next (); continue; which

Re: [SVE] PR86753

2019-10-08 Thread Prathamesh Kulkarni
On Tue, 8 Oct 2019 at 13:21, Richard Sandiford wrote: > > Leaving the main review to Richard, just some comments... > > Prathamesh Kulkarni writes: > > @@ -9774,6 +9777,10 @@ vect_is_simple_cond (tree cond, vec_info *vinfo, > > > > When STMT_INFO i

Re: [SVE] PR86753

2019-10-07 Thread Prathamesh Kulkarni
On Fri, 4 Oct 2019 at 16:08, Richard Biener wrote: > > On Thu, Oct 3, 2019 at 1:42 AM Prathamesh Kulkarni > wrote: > > > > On Wed, 25 Sep 2019 at 09:17, Prathamesh Kulkarni > > wrote: > > > > > > On Mon, 16 Sep 2019 at 08:54, Prathamesh Kulkarni >

<    1   2   3   4   5   6   7   8   9   10   >