This test relies on wrap behavior of signed overflow. Without -fwrapv
it is known to fail on mips (and maybe some other targets as well).
gcc/testsuite/
* gcc.c-torture/execute/950704-1.c: Add -fwrapv to avoid
undefined behavior.
---
Middle-end started to emit vec_cmp and vec_cmpu since GCC 11, causing
ICE on MIPS with MSA enabled. Add the pattern to prevent it.
Bootstrapped and regression tested on mips64el-linux-gnu.
Ok for trunk?
gcc/
* config/mips/mips-protos.h (mips_expand_vec_cmp_expr): Declare.
*
Check if the vector mode is really supported by MSA in certain cases,
instead of testing ISA_HAS_MSA. Simply testing ISA_HAS_MSA can cause
ICE when MSA is enabled besides other MIPS SIMD extensions (notably,
Loongson MMI).
Bootstrapped and tested on mips64el-linux-gnu. OK to commit?
gcc/
On 2021-02-16 11:59 +0800, Xi Ruoyao wrote:
> On 2021-02-15 16:16 -0700, Jeff Law wrote:
> >
> >
> > On 2/12/21 7:17 AM, Xi Ruoyao wrote:
> > > On 2021-01-11 01:01 +0800, Xi Ruoyao wrote:
> > > > Hi Jeff and Jakub,
> > > >
> > > >
On 2021-02-15 16:16 -0700, Jeff Law wrote:
>
>
> On 2/12/21 7:17 AM, Xi Ruoyao wrote:
> > On 2021-01-11 01:01 +0800, Xi Ruoyao wrote:
> > > Hi Jeff and Jakub,
> > >
> > > On 2021-01-04 14:19 -0700, Jeff Law wrote:
> > > > On 1/4/21 2:00 P
Nope. I can't reach Robert, so CC MIPS maintainer.
On 2021-02-12 22:57 +0800，Xi Ruoyao wrote:
> Well, it just dislike my mail server :(. Switch to the mail server of my
> university.
>
> On 2021-02-12 22:54 +0800, Xi Ruoyao wrote:
> > Resend the mail. I had to fill in a
Well, it just dislike my mail server :(. Switch to the mail server of my
university.
On 2021-02-12 22:54 +0800, Xi Ruoyao wrote:
> Resend the mail. I had to fill in a form to send mail to Robert.
>
> On 2021-02-12 22:17 +0800, Xi Ruoyao wrote:
> > On 2021-01-11 01:01 +0800,
Resend the mail. I had to fill in a form to send mail to Robert.
On 2021-02-12 22:17 +0800, Xi Ruoyao wrote:
> On 2021-01-11 01:01 +0800, Xi Ruoyao wrote:
> > Hi Jeff and Jakub,
> >
> > On 2021-01-04 14:19 -0700, Jeff Law wrote:
> > > On 1/4/21 2:00 PM, Jakub Jeli
On 2021-01-11 01:01 +0800, Xi Ruoyao wrote:
> Hi Jeff and Jakub,
>
> On 2021-01-04 14:19 -0700, Jeff Law wrote:
> > On 1/4/21 2:00 PM, Jakub Jelinek wrote:
> > > On Mon, Jan 04, 2021 at 01:51:59PM -0700, Jeff Law via Gcc-patches wrote:
> > > > > S
On 2021-01-11 01:01 +0800, Xi Ruoyao wrote:
> CC Robert to get some help.
Unfortunately Robert's mail in MAINTAINER file seems no longer valid :(.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
gcc/ChangeLog:
> > > >
> > > > 2020-12-31 Xi Ruoyao
> > > >
> > > > PR target/98491
> > > > * config/mips/mips.c (mips_symbol_insns): Do not use
> > > > MSA_SUPPORTED_MODE_P
On 2021-01-01 07:29 +0800, Xi Ruoyao wrote:
> An invalid use of MSA_SUPPORTED_MODE_P is causing ICE on mips64el with -mmsa.
> The detailed analysis is posted on bugzilla:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98491
>
> The attached patch fixes this issue by handlin
since I'm not a subscriber.
And, I don't have GIT write access.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
index 58e474e063d..8f80dcfada8 100644
--- a/gcc/config/mips/mips.c
+++ b/gcc/config/mips/mips.c
suite/ext/pb_ds/example/tree_order_statistics_join.cc:
Likewise.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
From c0ee85f492872ba164ad3c1c9636aace1de02e96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?X=E2=84=B9=20Ruoyao?=
Date: Sun, 12 Jul 2020 16:12:18 +080
_::operator[]): Likewise.
(bin_search_tree_const_it_::iterator_category):
Change to std::random_access_iterator_tag.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
From 5149d3156b0b1ae5d8cf82c54d041bd47451c995 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?X=E2=84=B9=20Ruoyao?=
ee_/split_join_fn_imps.hpp
(split_finish): Use maintained size, instead of calling
std::distance.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
From 4434da1b2b45797204f4fd978dcc4fbba4b17c6e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?X=E2=84=B9=20Ruoyao?=
D
AME::update_subtree_size): Declare new member
function.
* include/ext/pb_ds/detail/bin_search_tree_/rotate_fn_imps.hpp
(update_subtree_size): Define.
(apply_update, update_to_top): Call update_subtree_size.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xid
stdc++-v3/ChangeLog:
* include/ext/pb_ds/detail/bin_search_tree_/insert_fn_imps.hpp
(insert_leaf_new, insert_imp_empty): remove redundant statements.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
From 4eea45261ebf974ddf02f6154166c5cb6aa180da Mon Sep 17
rch_tree_/insert_fn_imps.hpp
(insert_leaf_new, insert_imp_empty): remove redundant statements.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
From 4eea45261ebf974ddf02f6154166c5cb6aa180da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?X=E2=84=B9=20Ruoyao?=
Date: Fri, 10 Jul 2
. GCC
does not use pb_ds so it should be unnecessary to run a bootstrap.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
On 2019-12-19 19:12 +0800, Xi Ruoyao wrote:
> On 2019-12-19 11:06 +0100, Jan Hubicka wrote:
> > - /* See if we have linker information about symbol not being used or
> > - if we need to make guess based on the declaration.
> > + /* Limitation of gas requires us to out
r clams the symbol is unused, never bring internal
> - symbols that are declared by user as used or externally visible.
> - This is needed for i.e. references from asm statements. */
> - if (used_from_object_file_p ())
> -return true;
Are these two lines removed intentionally?
>if (reso
2. Add some mangled symbol name in GCC (like ".LSYMVERx" or
"foo_v2.symver_export").
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
ymbol, it will inline
> calls to it and do other things), while in the second case we need to
> treat foo_v2 specially.
> > So if it's safe we can force a ".globl foo_v2" before ".symver foo_v2,
> > foo@@VERS_2". But I can't prove it's safe so I think it's better to
> > consider
> > this case in cgraph_externally_visible_p.
>
> It sort of makes things work, but for example it will prevent gcc from
> inlining calls to foo_v2. I think we will still need to do something
> about -fvisibility=hidden.
>
> It is sad that we do not have way to produce symbol version without a
> corresponding symbol of global visiblity. If we had we could support
> multiple symver aliases from one symbol and avoid the need to explicitly
> hide the unnecesary symbols in the map files...
Explicitly hiding the unnecessary symbols in map files is now how we handle this
[with __asm__(".symver foo_v2, foo@@VERS_2")]. We can continue to do in this
way and leave it as an enhancement.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
believe we should consider symver targets to be externally visible in
cgraph_externally_visible_p. There is a comment saying "if linker counts on us,
we must preserve the function". That's true in our case.
And, I think
.globl .LSYMVER0
.set.LSYMVER0, foo_v2
.symver .LSYMVER0, foo@@VERS_2
is
erminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make: *** [Makefile:4: obj/test.so] Error 1
The change to lto/lto-common.c makes sense. I tried it instead of my change to
cgraph.h and everything is OK. I'll investigate the change to varasm.c a
little.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
sion
script). And foo (VERS_2) would be missing. With this patch foo (VERS_2) would
show up.
We can't mark "foo_v2" to be "global" because it should not be a part of DSO
ABI.
The other 1% chance would be a regression in Binutils.
--
Xi Ruoyao
School of Aerospace Science and Technology, Xidian University
pr48200.tar.gz
Description: application/compressed-tar
an be built with LTO enabled and no problem.
I'll test symver patch and this patch with more packages.
Bootstrapped/regtested x86_64-linux. I'm not a maintainer.
gcc/ChangeLog:
2019-12-17 Xi Ruoyao
* cgraph.h (symtab_node::used_from_object_file_p): Symver nodes are
part of DS
On 2017-08-24 20:17 +0800, Xi Ruoyao wrote:
> On 2017-08-22 10:17 +0200, Richard Biener wrote:
> >
> > Ok for the gcc 7 branch.
> >
>
> Well, I think I should say I don't have SVN write access...
Still not installed. Make a rediff.
We don't have a Cilk mainta
On 2017-08-22 10:17 +0200, Richard Biener wrote:
>
> Ok for the gcc 7 branch.
>
Well, I think I should say I don't have SVN write access...
--
Xi Ruoyao <r...@stu.xidian.edu.cn>
School of Aerospace Science and Technology, Xidian University
On 2017-08-21 23:37 +0800, Xi Ruoyao wrote:
> On 2017-04-25 09:30 -0600, Jeff Law wrote:
> > On 04/14/2017 06:44 PM, Xi Ruoyao wrote:
> > > On 2017-04-14 15:00 +0800, Xi Ruoyao wrote:
> > > > On 2017-04-13 09:05 +0200, Richard Biener wrote:
> > > >
&g
On 2017-04-25 09:30 -0600, Jeff Law wrote:
> On 04/14/2017 06:44 PM, Xi Ruoyao wrote:
> > On 2017-04-14 15:00 +0800, Xi Ruoyao wrote:
> > > On 2017-04-13 09:05 +0200, Richard Biener wrote:
> > >
> > > > Did you verify LTO bootstrap still works with the p
On 2017-06-19 12:44 -0600, Martin Sebor wrote:
> On 06/19/2017 11:28 AM, Xi Ruoyao wrote:
> > On 2017-06-19 10:51 -0600, Martin Sebor wrote:
> > > On 06/11/2017 07:32 PM, Xi Ruoyao wrote:
> > > > This patch adds warning option -Wstring-plus-int for C/C++.
On 2017-06-19 12:44 -0600, Martin Sebor wrote:
> On 06/19/2017 11:28 AM, Xi Ruoyao wrote:
> > On 2017-06-19 10:51 -0600, Martin Sebor wrote:
> > > On 06/11/2017 07:32 PM, Xi Ruoyao wrote:
> > > > This patch adds warning option -Wstring-plus-int for C/C++.
On 2017-06-19 10:30 -0600, Martin Sebor wrote:
> On 06/11/2017 07:34 PM, Xi Ruoyao wrote:
> > This patch adds warning option -Wstring-plus-char for C/C++.
> >
>
> +void
> +warn_if_string_plus_char (location_t loc, tree ptrtype, tree inttype)
> +{
>
On 2017-06-19 10:51 -0600, Martin Sebor wrote:
> On 06/11/2017 07:32 PM, Xi Ruoyao wrote:
> > This patch adds warning option -Wstring-plus-int for C/C++.
> >
> > gcc/ChangeLog:
> >
> > 2017-06-12 Xi Ruoyao <r...@stu.xidian.edu.cn>
> >
> >
On 2017-06-12 09:26 +0800, Xi Ruoyao wrote:
> Hi,
>
> I've implemented -Wstring-plus-int and -Wstring-plus-char (like their
> counterpart in Clang) for GCC.
>
> This series of patch has been bootstrapped and regtested. OK for trunk?
>
> Currently these options are not
This patch adds document of -Wstring-plus-int and -Wstring-plus-char.
gcc/ChangeLog:
2017-06-12 Xi Ruoyao <r...@stu.xidian.edu.cn>
* doc/invoke.texi (Warning Options): Document -Wstring-plus-int
and -Wstring-plus-char.
---
gcc/doc/invoke.texi | 22 +++
This patch adds tests for -Wstring-plus-char.
gcc/ChangeLog:
2017-06-12 Xi Ruoyao <r...@stu.xidian.edu.cn>
* testsuite/c-c++-common/Wstring-plus-char.c: New test.
* testsuite/g++.dg/Wstring-plus-char-1.C: Ditto.
* testsuite/g++.dg/Wstring-plus-char-2.C:
This patch adds tests for -Wstring-plus-int.
gcc/ChangeLog:
2017-06-12 Xi Ruoyao <r...@stu.xidian.edu.cn>
* testsuite/c-c++-common/Wstring-plus-int.c: New test.
* testsuite/g++.dg/Wstring-plus-int-1.C: Ditto.
* testsuite/g++.dg/Wstring-plus-int-2.C: Ditto.
--
This patch adds warning option -Wstring-plus-char for C/C++.
gcc/ChangeLog:
2017-06-12 Xi Ruoyao <r...@stu.xidian.edu.cn>
* c-family/c-common.h (warn_if_string_plus_char): New prototype.
* c-family/c-warn.c (warn_if_string_plus_char): New function.
* c-family
This patch adds warning option -Wstring-plus-int for C/C++.
gcc/ChangeLog:
2017-06-12 Xi Ruoyao <r...@stu.xidian.edu.cn>
* c-family/c.opt: New option -Wstring-plus-int.
* c-family/c-common.c (pointer_int_sum): Checking for
-Wstring-plus-int.
---
gcc/c-fa
This patch moves prototype of char_type_p into c-common.h, so we can
use it in c-family/*.
gcc/ChangeLog:
2017-06-12 Xi Ruoyao <r...@stu.xidian.edu.cn>
* c-family/c-common.h (char_type_p): New prototype.
* c/c-typeck.c (char_type_p): Make the function extern.
*
or by -Wall/-Wextra later.
Xi Ruoyao (6):
Move char_type_p prototype into c-common.h
New warning option -Wstring-plus-int
New warning option -Wstring-plus-char
New tests for -Wstring-plus-int
New tests for -Wstring-plus-char
Document new warning options
gcc/c-family/c-common.c
On 2017-05-22Mon的 14:50 +0100, Jonathan Wakely wrote:
> On 22/05/17 21:41 +0800, Xi Ruoyao wrote:
> > On 2017-05-22 14:00 +0100, Jonathan Wakely wrote:
> > > On 18/05/17 19:27 +0800, Xi Ruoyao wrote:
> > > > This patch use ioctl to get entropy of std::random_de
On 2017-05-22 14:50 +0100, Jonathan Wakely wrote:
> On 22/05/17 21:41 +0800, Xi Ruoyao wrote:
> > On 2017-05-22 14:00 +0100, Jonathan Wakely wrote:
> > > On 18/05/17 19:27 +0800, Xi Ruoyao wrote:
> > > > This patch use ioctl to get entropy of std::random_device usin
On 2017-05-22 14:00 +0100, Jonathan Wakely wrote:
> On 18/05/17 19:27 +0800, Xi Ruoyao wrote:
> > This patch use ioctl to get entropy of std::random_device using
> > /dev/random and /dev/urandom.
>
> This is a nice addition, thanks.
>
> N.B. I couldn't apply your patc
On 2017-05-19 15:38 +0100, Jonathan Wakely wrote:
> On 18/05/17 19:10 +0800, Xi Ruoyao wrote:
> > This UB has been hiding so long...
>
> Indeed! Thanks for the patch.
>
> > 2017-03-11 Xi Ruoyao <r...@stu.xidian.edu.cn>
> >
> > PR libstdc++/6721
This patch use ioctl to get entropy of std::random_device using
/dev/random and /dev/urandom.
Regenerated files are mentioned in ChangeLog but not included
in the patch.
2017-03-12 Xi Ruoyao <r...@stu.xidian.edu.cn>
PR libstdc++/67578
* config.h.in: Rege
This UB has been hiding so long...
2017-03-11 Xi Ruoyao <r...@stu.xidian.edu.cn>
PR libstdc++/67214
* include/bits/locale_facets.tcc (_M_extract_int):
Add explicit conversion to avoid signed overflow.
---
libstdc++-v3/include/bits/locale_facets.tcc | 3 ++-
t; ../../gcc/c-family/cilk.c:115:9: note: in expansion of macro 'EXPR_CILK_SPAWN'
> EXPR_CILK_SPAWN (TREE_OPERAND (fcall, 1)) = 1;
> ^
>
> Andreas.
>
Sorry T_T. I've made a stupid mistake in tree.h.
Let's apply following patch, and alert the RM wh
On 2017-04-28 08:42 -0600, Jeff Law wrote:
> On 04/28/2017 08:31 AM, Xi Ruoyao wrote:
> > Should I prepare (re-diff) a patch for current trunk?
> If you want for the trunk, yes.
Rediff for current GCC trunk.
--
Xi Ruoyao <r...@stu.xidian.edu.cn>
School of Aerospace Science and
tch. I'm not keen on
> the way we stash away the arguments into orig_argX. Perhaps he's got a
> better suggestion.
In the recent version of Clang, this warning options has been seperated
into two options -Wstring-plus-int and -Wstring-plus-char. Maybe I should
do the same.
-
er it's been on the trunk for at least a week.
>
I just noticed GCC 7.0 has been frozen.
--
Xi Ruoyao <r...@stu.xidian.edu.cn>
School of Aerospace Science and Technology, Xidian University
On 2017-04-14 15:00 +0800, Xi Ruoyao wrote:
> On 2017-04-13 09:05 +0200, Richard Biener wrote:
>
> > Did you verify LTO bootstrap still works with the patch?
>
> I've just done a LTO bootstrapp (boarding a train :) ).
> It works with my patch.
I've done dejagnu tests
On 2017-04-13 09:05 +0200, Richard Biener wrote:
> Did you verify LTO bootstrap still works with the patch?
I've just done a LTO bootstrapp (boarding a train :) ).
It works with my patch.
--
Xi Ruoyao <r...@stu.xidian.edu.cn>
School of Aerospace Science and Technology, Xidian University
my patch ICEed with _Cilk_spawn and
-flto -O3 -fcilkplus since __cilkrts_stack_frame.ctx's type (array of void *)
was not TYPE_STRUCTURAL_EQUALITY_P in lto stage.
If this change is not proper, I'll work on modifying my patch to work
without touching in_lto_p.
--
Xi Ruoyao <r...@stu.xidian.ed
ot;middle-end".
Maybe we should reclassify PR 80038 and modify the ChangeLog as well.
This patch has been bootstrapped and regtested in x86_64-linux-gnu. Is it
OK for trunk?
--
Xi Ruoyao <r...@stu.xidian.edu.cn>
School of Aerospace Science and Technology, Xidian University
From dfbce2c4
On 2017-03-24 05:26 +0800, Xi Ruoyao wrote:
> The patch has 500+ lines so I attach it. ChangeLog is pasted here:
Damn it... I attached the draft of patch where some useless functions had
not been removed.
This time the attachment is correct.
> 2017-03-24 Xi Ruoyao <r...@stu.xidi
and copying with function call).
The pedigree operations are merged into built-in __cilkrts_detach (just like
libcilkrts cilk_fake.h).
Bootstrapped and regtested on x86_64-linux-gnu.
The patch has 500+ lines so I attach it. ChangeLog is pasted here:
2017-03-24 Xi Ruoyao <r...@stu.xidian.edu.cn
and tested on x86_64-linux-gnu.
2017-03-09 Xi Ruoyao <r...@stu.xidian.edu.cn>
PR libstdc++/62045:
* include/ext/pb_ds/qdetail/binary_heap_/binary_heap_.hpp
(is_heap): Remove.
(push_heap): Remove the wrong checking using is_heap.
(make_heap):
Hi,
The ill-formed checking in binary_heap::push_heap has made it
O(n). Remove this checking.
Since assert_valid also checks if (*this) is a legal heap, we can
remove is_heap and the assertions using it completely.
Bootstrapped and tested on x86_64-linux-gnu.
2017-03-09 Xi Ruoyao &l
.
Bootstrapped/regtested on x86_64-linux-gnu. Is this ok for trunk?
2017-03-06 Xi Ruoyao <r...@stu.xidian.edu.cn>
PR rtl-optimization/79728
* reginfo.c (init_reg_sets_1): Use fixed_nonglobal_reg_set
(instead of fixed_regs) to deduce ok_regs.
* gcc.targe
lly
> the description is correct, since character constants are integers.
>
> Perhaps add something like
>
> "A typical example this warns about is @samp{"abc" + 'd'}."
>
> ?
Thanks for the advise. I'll make it clear and resubmit the patches
in early s
This patch adds tests for -Wstring-plus-int.
gcc/ChangeLog:
2017-02-22 Xi Ruoyao <r...@stu.xidian.edu.cn>
* testsuite/c-c++-common/Wstring-plus-int.c: New test
* testsuite/g++.dg/Wstring-plus-int-1.C: New test
* testsuite/g++.dg/Wstring-plus-int-2.C: Ne
This patch adds warning option -Wstring-plus-int for C.
gcc/ChangeLog:
2017-02-22 Xi Ruoyao <r...@stu.xidian.edu.cn>
* c/c-typeck.c (parser_build_binary_op, build_modify_expr): checking
for -Wstring-plus-int
---
gcc/c/c-typeck.c | 28
1 file chang
This patch adds document of -Wstring-plus-int.
gcc/ChangeLog:
2017-02-22 Xi Ruoyao <r...@stu.xidian.edu.cn>
* doc/invoke.texi (Warning Options): Document -Wstring-plus-int
---
gcc/doc/invoke.texi | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/g
This patch adds warning option -Wstring-plus-int for C++.
gcc/ChangeLog:
2017-02-22 Xi Ruoyao <r...@stu.xidian.edu.cn>
* c-family/c-common.h (maybe_warn_string_plus_int): new prototype
* c-family/c-warn.h (maybe_warn_string_plus_int): new function
* c-family/c-op
This patch moves prototype of char_type_p into c-common.h, so we can
use it in c-family/*.
gcc/ChangeLog:
2017-02-22 Xi Ruoyao <r...@stu.xidian.edu.cn>
* c-family/c-common.h (char_type_p): New prototype
* c/c-typeck.c (char_type_p): Make the function extern
*
Hi,
I've implemented -Wstring-plus-int (like the one in CLANG) for GCC. I've
bootstrapped GCC with my patches and runned dejaGNU tests.
My patches are for both C and C++ (like CLANG).
Unlike CLANG, this option is not enabled by default (or GCC won't
bootstrap with -Werror).
Xi Ruoyao (5
901 - 970 of 970 matches
Mail list logo
