Re: [C++ Patch] for c++/52465

2012-04-12 Thread Fabien Chêne
2012/4/11 Jason Merrill : [...] > Your ChangeLog needs to be adjusted.  :) I did write an updated ChangeLog, but I pasted here the wrong one... I committed it to trunk yesterday, hopefully with the correct ChangeLog . I'll be backporting it to 4.7 after a relaxing weekend :-) -- Fabien

Re: [C++ Patch] for c++/52465

2012-04-10 Thread Jason Merrill
On 04/10/2012 04:23 PM, Fabien Chêne wrote: Ah yes, that's slightly better. (I've kept the NULL check in strip_using_decl, it seems safer to me. Just tell me if you prefer not) Tested x86_64-unkown-linux-gnu. OK for trunk and 4.7 ? 2012-03-08 Fabien Chêne PR c++/52465 * decl.c

Re: [C++ Patch] for c++/52465

2012-04-10 Thread Fabien Chêne
2012/4/7 Jason Merrill : > On 04/07/2012 11:37 AM, Fabien Chêne wrote: >> >> Perhaps it is more correct like that, in cp_parser_set_decl_spec_type ? > > Even that seems late.  Why not just return the target decl from > cp_parser_class_name? Ah yes, that's slightly better. (I've kept the NULL check

Re: [C++ Patch] for c++/52465

2012-04-07 Thread Jason Merrill
On 04/07/2012 11:37 AM, Fabien Chêne wrote: Perhaps it is more correct like that, in cp_parser_set_decl_spec_type ? Even that seems late. Why not just return the target decl from cp_parser_class_name? Jason

Re: [C++ Patch] for c++/52465

2012-04-07 Thread Fabien Chêne
2012/3/12 Fabien Chêne : > Salut Dodji, > > 2012/3/12 Dodji Seketeli : > [...] >>> Index: gcc/cp/decl.c >>> === >>> --- gcc/cp/decl.c     (revision 184891) >>> +++ gcc/cp/decl.c     (working copy) >>> @@ -8686,6 +8686,9 @@ grokdeclarat

Re: [C++ Patch] for c++/52465

2012-04-07 Thread Fabien Chêne
2012/3/29 Jason Merrill : > On 03/08/2012 04:34 PM, Fabien Chêne wrote: >> >>        * decl.c (grokdeclarator): Call strip_using_decl. > > > I would think we ought to be stripping USING_DECLs at a lower level, when we > first look up the name in the parser.  They shouldn't make it as far as > grokd

Re: [C++ Patch] for c++/52465

2012-03-29 Thread Jason Merrill
On 03/08/2012 04:34 PM, Fabien Chêne wrote: * decl.c (grokdeclarator): Call strip_using_decl. I would think we ought to be stripping USING_DECLs at a lower level, when we first look up the name in the parser. They shouldn't make it as far as grokdeclarator. Jason

Re: [C++ Patch] for c++/52465

2012-03-12 Thread Fabien Chêne
Salut Dodji, 2012/3/12 Dodji Seketeli : [...] >> Index: gcc/cp/decl.c >> === >> --- gcc/cp/decl.c     (revision 184891) >> +++ gcc/cp/decl.c     (working copy) >> @@ -8686,6 +8686,9 @@ grokdeclarator (const cp_declarator *dec >>      

Re: [C++ Patch] for c++/52465

2012-03-12 Thread Dodji Seketeli
Hello Fabien, Fabien Chêne a écrit: [...] > Index: gcc/cp/decl.c > === > --- gcc/cp/decl.c (revision 184891) > +++ gcc/cp/decl.c (working copy) > @@ -8686,6 +8686,9 @@ grokdeclarator (const cp_declarator *dec >type

[C++ Patch] for c++/52465

2012-03-08 Thread Fabien Chêne
Hi, In the end, I think we need again to strip some USING_DECLs in a couple of places. Tested x86_64-unknown-linux-gnu. OK to commit (for whatever appropriate) ? gcc/testsuite/ChangeLog 2012-03-08 Fabien Chêne PR c++/52465 * g++.dg/lookup/using52.C: New. gcc/cp/ChangeLog 20