Re: [PATCH, rs6000] Fix PR83969: ICE in final_scan_insn, at final.c:2997

2018-04-20 Thread Peter Bergner
On 4/20/18 9:34 AM, Peter Bergner wrote: > Neither test case fails on GCC 6, but I haven't tested on BE which is > where the PR83969 test case was failing (-m32 BE). I'll do a build on > BE and verify whether the tests compile there or not. If they PASS, > I'd probably just leave it alone until

Re: [PATCH, rs6000] Fix PR83969: ICE in final_scan_insn, at final.c:2997

2018-04-20 Thread Peter Bergner
On 4/19/18 5:40 PM, Segher Boessenkool wrote: > On Thu, Apr 19, 2018 at 01:23:51PM -0500, Peter Bergner wrote: >> On 3/9/18 4:25 PM, Peter Bergner wrote: >>> Technically, it is broken there too, but until trunk, we never really >>> generated the altivec mems that trigger this bug, so I think I

Re: [PATCH, rs6000] Fix PR83969: ICE in final_scan_insn, at final.c:2997

2018-04-19 Thread Segher Boessenkool
On Thu, Apr 19, 2018 at 01:23:51PM -0500, Peter Bergner wrote: > On 3/9/18 4:25 PM, Peter Bergner wrote: > > On 3/9/18 1:31 PM, Segher Boessenkool wrote: > >> On Wed, Mar 07, 2018 at 06:50:41PM -0600, Peter Bergner wrote: > >>> This passed bootstrap and regtesting on powerpc64-linux, running the >

Re: [PATCH, rs6000] Fix PR83969: ICE in final_scan_insn, at final.c:2997

2018-04-19 Thread Peter Bergner
On 3/9/18 4:25 PM, Peter Bergner wrote: > On 3/9/18 1:31 PM, Segher Boessenkool wrote: >> On Wed, Mar 07, 2018 at 06:50:41PM -0600, Peter Bergner wrote: >>> This passed bootstrap and regtesting on powerpc64-linux, running the >>> testsuite in both 32-bit and 64-bit modes with no regressions. >>>

Re: [PATCH, rs6000] Fix PR83969: ICE in final_scan_insn, at final.c:2997

2018-03-09 Thread Peter Bergner
On 3/9/18 1:31 PM, Segher Boessenkool wrote: > On Wed, Mar 07, 2018 at 06:50:41PM -0600, Peter Bergner wrote: >> This passed bootstrap and regtesting on powerpc64-linux, running the >> testsuite in both 32-bit and 64-bit modes with no regressions. >> Ok for trunk? > > Sorry this took a while to

Re: [PATCH, rs6000] Fix PR83969: ICE in final_scan_insn, at final.c:2997

2018-03-09 Thread Segher Boessenkool
On Wed, Mar 07, 2018 at 06:50:41PM -0600, Peter Bergner wrote: > PR83969 shows another bug in mem_operand_gpr() (which implements the "Y" > constraint) accepting reg+reg addresses.  This was fixed by adding a call > to rs6000_offsettable_memref_p() to verify the address is a valid offsettable >

Re: [PATCH, rs6000] Fix PR83969: ICE in final_scan_insn, at final.c:2997

2018-03-08 Thread Peter Bergner
On 3/7/18 6:50 PM, Peter Bergner wrote: > This passed bootstrap and regtesting on powerpc64-linux, running the > testsuite in both 32-bit and 64-bit modes with no regressions. > Ok for trunk? FYI, this also passed bootstrap and regtesting on powerpc64le-linux without regressions also. Peter

[PATCH, rs6000] Fix PR83969: ICE in final_scan_insn, at final.c:2997

2018-03-07 Thread Peter Bergner
PR83969 shows another bug in mem_operand_gpr() (which implements the "Y" constraint) accepting reg+reg addresses.  This was fixed by adding a call to rs6000_offsettable_memref_p() to verify the address is a valid offsettable address.  Fixing that exposed a problem in the *movdi_internal64 pattern