Re: C++ PATCH for c++/88979 - further P0634 fix for constructors

2019-03-13 Thread Marek Polacek
On Wed, Mar 13, 2019 at 02:32:36PM -0400, Jason Merrill wrote: > On 3/13/19 1:25 PM, Marek Polacek wrote: > > This PR points out that our P0634 implementation misses constructor > > parameters > > and still requires 'typename'. I'm not 100% sure if the standard really > > says > > we should

Re: C++ PATCH for c++/88979 - further P0634 fix for constructors

2019-03-13 Thread Jason Merrill
On 3/13/19 1:25 PM, Marek Polacek wrote: This PR points out that our P0634 implementation misses constructor parameters and still requires 'typename'. I'm not 100% sure if the standard really says we should also handle constructors. Does a constructor have a function type? Not that we can

C++ PATCH for c++/88979 - further P0634 fix for constructors

2019-03-13 Thread Marek Polacek
This PR points out that our P0634 implementation misses constructor parameters and still requires 'typename'. I'm not 100% sure if the standard really says we should also handle constructors. Does a constructor have a function type? But I guess it makes sense, so this patch handles it. To