m checking in.
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
From: Alexandre Oliva
g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
that use the AAPCS variant. ARM is the only target that overrides
TARGET_CXX_KEY_METHOD_MAY_BE_INLINE. It's not clear to m
d.
I think if you suppress the dg-do run line (with the target selector) then it
will just do the default (which is to compile only?)
Skip seems like the correct thing to do here ..
Iain
>
>> [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
>> From: Alexandre O
?
Erhm, actually, that version still ran the assembler scans and failed.
This one skips the testset entirely.
Yeah, I tried something like that and it didn't appear to work. Perhaps
it's a bug in the way dg-do-module is implemented.
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key
on x86_64-linux-gnu (trunk) and
> arm-wrs-vxworks7 (gcc-12). Ok to install?
Erhm, actually, that version still ran the assembler scans and failed.
This one skips the testset entirely.
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
From: Alexandre Oliva
g++.dg/
d, thanks. Here's the updated patch, retested. Ok to install?
> Based on Nathan's comments, we should just skip the test on arm_eabi,
> it's simply not applicable.
Like this, I suppose. Retested on x86_64-linux-gnu (trunk) and
arm-wrs-vxworks7 (gcc-12). Ok to install?
[PR105224] C++ mod
skip the test on arm_eabi,
it's simply not applicable.
R.
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
From: Alexandre Oliva
g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
that use the AAPCS variant. ARM is the only target that overrides
On Feb 21, 2023, Richard Earnshaw wrote:
> Rather than scanning for the triplet, a better test would be
> { xfail { arm_eabi } }
Indeed, thanks. Here's the updated patch, retested. Ok to install?
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
From: Alexandre
On 2/21/23 11:31, Richard Earnshaw wrote:
I started looking at this a few weeks back, but I was a bit confused by the
testcase and then never got around to following up.
The Arm C++ binding rules normally exclude using an inline function definition
from being chosen as the key function
, but the result on
them will be an unexpected pass, which is not quite as bad as the
unexpected fail we get on most arm variants now.
Ping?
https://gcc.gnu.org/pipermail/gcc-patches/2022-April/592763.html
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
g++.dg/modules/virt-2_a.C
as bad as the
unexpected fail we get on most arm variants now.
Ping?
https://gcc.gnu.org/pipermail/gcc-patches/2022-April/592763.html
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
that use the AAPCS
on most arm variants now.
Ping?
https://gcc.gnu.org/pipermail/gcc-patches/2022-April/592763.html
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
that use the AAPCS variant. ARM is the only target th
On Mar 31, 2022, Alexandre Oliva wrote:
> g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
> that use the AAPCS variant. ARM is the only target that overrides
> TARGET_CXX_KEY_METHOD_MAY_BE_INLINE. It's not clear to me which way the
> clash between AAPCS and C++ Modules
g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
that use the AAPCS variant. ARM is the only target that overrides
TARGET_CXX_KEY_METHOD_MAY_BE_INLINE. It's not clear to me which way the
clash between AAPCS and C++ Modules design should be resolved, but
currently it
13 matches
Mail list logo
