Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)

2016-07-13 Thread Jeff Law
On 07/13/2016 08:47 AM, Martin Liška wrote: Hello. As mentioned in [1], one slsr transformation is gone, thus we need to change expected number of multiplications. Ready to be installed? Thanks, Martin [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71490#c5 Isn't that a code quality regress

Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)

2016-07-14 Thread Martin Liška
On 07/13/2016 07:21 PM, Jeff Law wrote: > Isn't that a code quality regression? So instead shouldn't we be keeping the > same expectation, but xfailing the test? > > jeff Hello. Disabling a pass before slsr makes the test to catch both opportunities. Is the patch fine? Thanks, Martin >From 59

Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)

2016-07-14 Thread Richard Biener
On Thu, Jul 14, 2016 at 1:06 PM, Martin Liška wrote: > On 07/13/2016 07:21 PM, Jeff Law wrote: >> Isn't that a code quality regression? So instead shouldn't we be keeping >> the same expectation, but xfailing the test? >> >> jeff > > Hello. > > Disabling a pass before slsr makes the test to catc

Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)

2016-07-14 Thread Martin Liška
On 07/14/2016 01:21 PM, Richard Biener wrote: > On Thu, Jul 14, 2016 at 1:06 PM, Martin Liška wrote: >> On 07/13/2016 07:21 PM, Jeff Law wrote: >>> Isn't that a code quality regression? So instead shouldn't we be keeping >>> the same expectation, but xfailing the test? >>> >>> jeff >> >> Hello.

Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)

2016-07-15 Thread Richard Biener
On Thu, Jul 14, 2016 at 6:10 PM, Martin Liška wrote: > On 07/14/2016 01:21 PM, Richard Biener wrote: >> On Thu, Jul 14, 2016 at 1:06 PM, Martin Liška wrote: >>> On 07/13/2016 07:21 PM, Jeff Law wrote: Isn't that a code quality regression? So instead shouldn't we be keeping the same ex

Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)

2016-07-15 Thread Bill Schmidt
> On Jul 15, 2016, at 2:24 AM, Richard Biener > wrote: > > On Thu, Jul 14, 2016 at 6:10 PM, Martin Liška wrote: >> On 07/14/2016 01:21 PM, Richard Biener wrote: >>> On Thu, Jul 14, 2016 at 1:06 PM, Martin Liška wrote: On 07/13/2016 07:21 PM, Jeff Law wrote: > Isn't that a code qualit