[gem5-dev] Cron m5test@zizzer /z/m5/regression/do-regression quick

2012-11-07 Thread Cron Daemon
scons: `build/ALPHA/gem5.debug' is up to date. scons: `build/ALPHA_MOESI_hammer/gem5.debug' is up to date. scons: `build/ALPHA_MESI_CMP_directory/gem5.debug' is up to date. scons: `build/ALPHA_MOESI_CMP_directory/gem5.debug' is up to date. scons: `build/ALPHA_MOESI_CMP_token/gem5.debug' is up to

[gem5-dev] Review Request: mem: Fix DRAM draining to ensure write queue is empty

2012-11-07 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1535/ --- Review request for Default. Description --- Changeset 9352:da54b298aa83

Re: [gem5-dev] Review Request: mem: Remove the IIC replacement policy

2012-11-07 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1531/#review3677 --- Ship it! Ship It! - Andreas Hansson On Nov. 2, 2012, 10:19 a.m., Ali

Re: [gem5-dev] Review Request: sim, arch: Add support for invalidating TLBs when draining

2012-11-07 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1532/#review3678 --- Ship it! With the addition of a comment it looks good to me

Re: [gem5-dev] Review Request: base: Create a central header listing all signals used within gem5

2012-11-07 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1530/#review3679 --- Ship it! Ship It! - Andreas Hansson On Nov. 2, 2012, 10:17 a.m., Ali

Re: [gem5-dev] Review Request: TournamentBP: Fix some bugs with table sizes and counters

2012-11-07 Thread Erik Tomusk
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1523/ --- (Updated Nov. 7, 2012, 3:24 a.m.) Review request for Default. Description

Re: [gem5-dev] Review Request: TournamentBP: Fix some bugs with table sizes and counters

2012-11-07 Thread Erik Tomusk
On Nov. 6, 2012, 5:25 a.m., Ali Saidi wrote: src/cpu/pred/tournament.cc, line 112 http://reviews.gem5.org/r/1523/diff/5/?file=31001#file31001line112 could you switch these to use mask() instead af creating the mask yourself? It just makes it a bit clearer about what is going on.

Re: [gem5-dev] Review Request: TournamentBP: Fix some bugs with table sizes and counters

2012-11-07 Thread Erik Tomusk
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1523/#review3681 --- src/cpu/pred/tournament.cc http://reviews.gem5.org/r/1523/#comment3647

Re: [gem5-dev] Review Request: mem: Remove the IIC replacement policy

2012-11-07 Thread Anthony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1531/#review3682 --- Ship it! Ship It! - Anthony Gutierrez On Nov. 2, 2012, 10:19 a.m.,

Re: [gem5-dev] Review Request: mem: Fix DRAM draining to ensure write queue is empty

2012-11-07 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1535/ --- (Updated Nov. 7, 2012, 5:40 a.m.) Review request for Default. Description

[gem5-dev] Review Request: ARM: Set movret_uop as Conditional or Unconditional control

2012-11-07 Thread Nathanael Premillieu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1536/ --- Review request for Default. Description --- Like

Re: [gem5-dev] Review Request: mem: Fix DRAM draining to ensure write queue is empty

2012-11-07 Thread Anthony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1535/#review3684 --- Ship it! Ship It! - Anthony Gutierrez On Nov. 7, 2012, 5:40 a.m.,

Re: [gem5-dev] Review Request: mem: Fix DRAM draining to ensure write queue is empty

2012-11-07 Thread Anthony Gutierrez
On Nov. 7, 2012, 10:17 a.m., Anthony Gutierrez wrote: Ship It! Previous problems seemed to be fixed while switching. - Anthony --- This is an automatically generated e-mail. To reply, visit:

Re: [gem5-dev] Review Request: sim, arch: Add support for invalidating TLBs when draining

2012-11-07 Thread Anthony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1532/#review3687 --- Ship it! Ship It! - Anthony Gutierrez On Nov. 2, 2012, 10:19 a.m.,

Re: [gem5-dev] Review Request: InOrderCPU: Add Missing DPRINTF Argument to Fetch Unit

2012-11-07 Thread Anthony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1526/#review3688 --- Ship it! Ship It! - Anthony Gutierrez On Oct. 31, 2012, 8:11 a.m.,

Re: [gem5-dev] Review Request: ARM: Set movret_uop as Conditional or Unconditional control

2012-11-07 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1536/#review3689 --- Ship it! Ship It! - Ali Saidi On Nov. 7, 2012, 9:33 a.m., Nathanael

Re: [gem5-dev] Review Request: base: Create a central header listing all signals used within gem5

2012-11-07 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1530/#review3690 --- What exactly is the point of this? For those that know how signals

Re: [gem5-dev] Review Request: base: Create a central header listing all signals used within gem5

2012-11-07 Thread Andreas Sandberg
On Nov. 7, 2012, 1:46 p.m., Nathan Binkert wrote: What exactly is the point of this? For those that know how signals work, this is just unnecessary confusion. If you want to centralize all signal handlers, then move them. This came about as a way to avoid having to grep through the

Re: [gem5-dev] Review Request: base: Create a central header listing all signals used within gem5

2012-11-07 Thread Nathan Binkert
On Nov. 7, 2012, 1:46 p.m., Nathan Binkert wrote: What exactly is the point of this? For those that know how signals work, this is just unnecessary confusion. If you want to centralize all signal handlers, then move them. Andreas Sandberg wrote: This came about as a way to

Re: [gem5-dev] Review Request: TournamentBP: Fix some bugs with table sizes and counters

2012-11-07 Thread Andreas Hansson
On Nov. 6, 2012, 3:58 a.m., Andreas Hansson wrote: I'm curious about the testing statement. No regressions should be failing. Erik Tomusk wrote: The tgen-simple-dram regression is failing for me even on a clean gem5 and has been for a while. It goes through all my RAM (4GB), a