[gem5-dev] Issue with O3 and interrupts

2014-11-26 Thread Castillo Villar, Emilio via gem5-dev
Good evening, I am experiencing a weird issue with the O3CPU, X86 and the interrupt handling. I am running in FS mode and one simulation just experienced a weird hang. The simulated machine is doing an spinlock over a value that an interrupt handler writes. After some debug I found that when th

Re: [gem5-dev] KvmCPU Behaviour

2014-11-26 Thread Dutu, Alexandru via gem5-dev
Hi Andreas, Sorry for the late reply, I have missed your email. I will investigate more the issues with memory controller refresh events and let you know what I find out. Best regards, Alex ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/m

Re: [gem5-dev] Review Request 2523: config: Get rid of some extra spaces around default arguments.

2014-11-26 Thread Andreas Hansson via gem5-dev
Thanks Steve, it sounds good to me. Coincidentally, the use of default arguments in C++ is probably worth actively discouraging (but not prohibit). Andreas From: Steve Reinhardt mailto:ste...@gmail.com>> Date: Wednesday, 26 November 2014 18:11 To: gem5 Developer List mailto:gem5-dev@gem5.org>>

Re: [gem5-dev] Review Request 2523: config: Get rid of some extra spaces around default arguments.

2014-11-26 Thread Steve Reinhardt via gem5-dev
On Wed, Nov 26, 2014 at 4:30 AM, Gabe Black via gem5-dev wrote: > > > Just to make sure we're all on the same page, I removed the spaces here > because these are default values for arguments. My brain might have just > pattern matched and applied a rule for named function arguments in python > we

Re: [gem5-dev] KVM broken on x86 due to changeset 1bd64b294fe4

2014-11-26 Thread Andreas Sandberg via gem5-dev
Thanks! I should have checked the upstream commit log. //Andreas On 26/11/14 13:54, Gabe Black via gem5-dev wrote: I already fixed it. The change should be checked in, I think. Gabe On Nov 26, 2014 5:52 AM, "Andreas Sandberg via gem5-dev" wrote: I just ran into some issues with kvm on x86.

Re: [gem5-dev] KVM broken on x86 due to changeset 1bd64b294fe4

2014-11-26 Thread Gabe Black via gem5-dev
I already fixed it. The change should be checked in, I think. Gabe On Nov 26, 2014 5:52 AM, "Andreas Sandberg via gem5-dev" wrote: > I just ran into some issues with kvm on x86. It seems like changeset > 1bd64b294fe4 (x86: add LongModeAddressSize function to cpuid) breaks > Linux running in kvm.

[gem5-dev] KVM broken on x86 due to changeset 1bd64b294fe4

2014-11-26 Thread Andreas Sandberg via gem5-dev
I just ran into some issues with kvm on x86. It seems like changeset 1bd64b294fe4 (x86: add LongModeAddressSize function to cpuid) breaks Linux running in kvm. It seems like the offending change makes cpuid report the virtual and physical address length as 255 bits, which clearly doesn't make sens

Re: [gem5-dev] Review Request 2523: config: Get rid of some extra spaces around default arguments.

2014-11-26 Thread Gabe Black via gem5-dev
> On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote: > > I thought the style guide said there were supposed to be spaces around > > operators and assignments, or am I missing something? > > Gabe Black wrote: > I don't think the style guide says, or at least not that I see. I may be > ten

Re: [gem5-dev] Review Request 2523: config: Get rid of some extra spaces around default arguments.

2014-11-26 Thread Andreas Hansson via gem5-dev
> On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote: > > I thought the style guide said there were supposed to be spaces around > > operators and assignments, or am I missing something? > > Gabe Black wrote: > I don't think the style guide says, or at least not that I see. I may be > ten

Re: [gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

2014-11-26 Thread Andreas Hansson via gem5-dev
> On Nov. 26, 2014, 10:49 a.m., Andreas Hansson wrote: > > src/dev/x86/i8042.cc, line 261 > > > > > > for (auto& k : keys) > >bufferData(&k, 1) > > Gabe Black wrote: > What is this sorcery? :-) Seriously though,

Re: [gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

2014-11-26 Thread Gabe Black via gem5-dev
> On Nov. 26, 2014, 10:49 a.m., Andreas Hansson wrote: > > src/dev/x86/i8042.cc, line 261 > > > > > > for (auto& k : keys) > >bufferData(&k, 1) What is this sorcery? :-) Seriously though, what's this from? Does gcc

Re: [gem5-dev] Review Request 2523: config: Get rid of some extra spaces around default arguments.

2014-11-26 Thread Gabe Black via gem5-dev
> On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote: > > I thought the style guide said there were supposed to be spaces around > > operators and assignments, or am I missing something? I don't think the style guide says, or at least not that I see. I may be tending to the style we use at wo

Re: [gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

2014-11-26 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2520/#review5554 --- src/dev/x86/i8042.cc

Re: [gem5-dev] Review Request 2521: ps2: Support translating left and right ALT keys.

2014-11-26 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2521/#review5553 --- Ship it! The keyword needs updating, for the rest it looks fine. - Andr

Re: [gem5-dev] Review Request 2523: config: Get rid of some extra spaces around default arguments.

2014-11-26 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2523/#review5552 --- I thought the style guide said there were supposed to be spaces around o

Re: [gem5-dev] Review Request 2499: mem: Clean up packet data allocation

2014-11-26 Thread Andreas Hansson via gem5-dev
> On Nov. 25, 2014, 10:11 p.m., Nilay Vaish wrote: > > src/mem/packet.hh, line 884 > > > > > > We need better explanation here. What do you mean by "nature of > > copying static pointers into forwarded packets"? I have ad

Re: [gem5-dev] Review Request 2499: mem: Clean up packet data allocation

2014-11-26 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2499/ --- (Updated Nov. 26, 2014, 10:05 a.m.) Review request for Default. Repository: gem5

[gem5-dev] Cron /z/m5/regression/do-regression quick

2014-11-26 Thread Cron Daemon via gem5-dev
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple