[gem5-dev] Cron /z/m5/regression/do-regression quick

2015-11-20 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/lin

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

2015-11-20 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7616 --- Ship it! Thanks! My concerns have been addressed, but please make sure t

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

2015-11-20 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/#review7617 --- Looks like a good design to me. I'm currently testing it in aarch32 and i

Re: [gem5-dev] Review Request 3029: cpu: Add TraceCPU to playback elastic traces

2015-11-20 Thread Radhika Jagtap
> On Nov. 6, 2015, 7:43 a.m., Nilay Vaish wrote: > > src/cpu/trace/trace_cpu.hh, line 447 > > > > > > Reference Done. > On Nov. 6, 2015, 7:43 a.m., Nilay Vaish wrote: > > src/cpu/trace/trace_cpu.hh, line 485 > >

Re: [gem5-dev] Review Request 3029: cpu: Add TraceCPU to playback elastic traces

2015-11-20 Thread Radhika Jagtap
> On Sept. 20, 2015, 6:06 p.m., Nilay Vaish wrote: > > src/cpu/trace/trace_cpu.cc, lines 741-795 > > > > > > Would it make sense to use either a heap or an orderded map? Assuming > > that you only do insertions and deletio

Re: [gem5-dev] Review Request 3029: cpu: Add TraceCPU to playback elastic traces

2015-11-20 Thread Radhika Jagtap
> On Nov. 6, 2015, 10:14 a.m., Stephan Diestelhorst wrote: > > src/cpu/trace/trace_cpu.cc, line 168 > > > > > > space around / Done. > On Nov. 6, 2015, 10:14 a.m., Stephan Diestelhorst wrote: > > src/cpu/trace/trace_cpu.c

Re: [gem5-dev] Review Request 3031: config: Enable elastic trace capture and replay in se/fs

2015-11-20 Thread Radhika Jagtap
> On Nov. 6, 2015, 7:50 a.m., Nilay Vaish wrote: > > configs/example/etrace_replay.py, lines 107-109 > > > > > > I think these are the only lines that extra > > over what se.py has. Why not just move these to se.py? Th

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

2015-11-20 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7622 --- src/mem/request.hh (line 158)

Re: [gem5-dev] Style Checker: Includes Order Warning

2015-11-20 Thread Andreas Sandberg
Joe, This is an unfortunate mis-match between the style checker and the wiki. The style checker is right in this case. I have updated the wiki to reflect this behavior. The reason for this new include order is that it ensures that header files are independent. I.e., you¹ll never depend on the inc

Re: [gem5-dev] Style Checker: Includes Order Warning

2015-11-20 Thread Gross, Joe
Andreas, Alright, thanks for updating the wiki entry. Although the style checker didn't seem to catch this for all the files, I'll try to be sure that we still match what's on the wiki and hopefully this resolves the issues our group has been having. Joe __

Re: [gem5-dev] Style Checker: Includes Order Warning

2015-11-20 Thread Gutierrez, Anthony
I see these changes were pushed around Feb 2015, but can you point to the rb posts? I am unable to find them in your history. -Original Message- From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Andreas Sandberg Sent: Friday, November 20, 2015 8:36 AM To: gem5 Developer List

Re: [gem5-dev] Style Checker: Includes Order Warning

2015-11-20 Thread Andreas Hansson
http://reviews.gem5.org/r/2614/ On 20/11/2015, 17:29, "gem5-dev on behalf of Gutierrez, Anthony" wrote: >I see these changes were pushed around Feb 2015, but can you point to the >rb posts? I am unable to find them in your history. > >-Original Message- >From: gem5-dev [mailto:gem5-dev-b

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2015-11-20 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3189/#review7623 --- src/mem/protocol/RubySlicc_Types.sm (line 136)

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

2015-11-20 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/ --- (Updated Nov. 20, 2015, 12:04 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

2015-11-20 Thread Tony Gutierrez
On Nov. 20, 2015, 5:33 a.m., Tony Gutierrez wrote: > > I am still not really understanding the request and the packet part. How > > are the two related (are they)? I have a patch to undo the packet ACQ/REL changes, and will post it soon. Honestly I think the original author of this patch may h

Re: [gem5-dev] Review Request 3192: ruby: split CPU and GPU latency stats

2015-11-20 Thread Joel Hestness
> On Nov. 12, 2015, 8:08 p.m., Joel Hestness wrote: > > src/mem/slicc/symbols/StateMachine.py, line 313 > > > > > > Not sure if this should be fixed before commit, but I feel it should be > > fixed at some point: > > >

Re: [gem5-dev] Review Request 3176: ruby: imported from reviewboard patch 2550

2015-11-20 Thread Sooraj Puthoor
> On Nov. 2, 2015, 8:45 p.m., Joel Hestness wrote: > > Please give this a real description. Why do we need to remove this > > functionality? > > Sooraj Puthoor wrote: > This patch is the same as patch 2550 (reviews.gem5.org/r/2550/). So, > would it help if we use the same description used

[gem5-dev] Review Request 3232: dev, arm: Add gem5 extensions to support more than 8 cores

2015-11-20 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3232/ --- Review request for Default. Repository: gem5 Description --- Changeset 11221

[gem5-dev] Review Request 3233: sys: Bootloader fix for v8 over 16 cores

2015-11-20 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3233/ --- Review request for Default. Repository: gem5 Description --- Changeset 11222

Re: [gem5-dev] Review Request 3131: base: support gzip-compressed object files

2015-11-20 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3131/ --- (Updated Nov. 20, 2015, 8:47 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3177: ruby: imported from reviewboard patch 2551

2015-11-20 Thread Sooraj Puthoor
> On Nov. 2, 2015, 8:56 p.m., Joel Hestness wrote: > > Please provide a description for this patch. > > Sooraj Puthoor wrote: > This patch is imported from reviewboard and the original patch is > http://reviews.gem5.org/r/2551/.So, would it help if we use the same > description used in tha

[gem5-dev] changeset in gem5: cpu: Enforce 1 interrupt controller per thread

2015-11-20 Thread Andreas Sandberg
changeset 2fb745f69681 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=2fb745f69681 description: cpu: Enforce 1 interrupt controller per thread Consider it a fatal configuration error if the number of interrupt controllers doesn't match the number of t

Re: [gem5-dev] Style Checker: Includes Order Warning

2015-11-20 Thread Andreas Sandberg
It was also brought up on the dev list before the style checker was updated: https://www.mail-archive.com/gem5-dev@gem5.org/msg11768.html //Andreas On 20/11/2015, 18:35, "gem5-dev on behalf of Andreas Hansson" wrote: >http://reviews.gem5.org/r/2614/ > >On 20/11/2015, 17:29, "gem5-dev on beha

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

2015-11-20 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/ --- (Updated Nov. 20, 2015, 1:52 p.m.) Review request for Default. Repository: gem5

[gem5-dev] Review Request 3234: mem: remove aqcuire/release cmd from packet

2015-11-20 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3234/ --- Review request for Default. Repository: gem5 Description --- Changeset 11221

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

2015-11-20 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7628 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 20, 2015, 9:52 p.m., Ton