Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

2016-10-17 Thread Anastasiia Butko
> On oct. 17, 2016, 2:12 après-midi, Jason Lowe-Power wrote: > > The diff doesn't apply correctly. Could you fix and re-upload? I've combined both patches in one. And these changes do not include the MemConfig support. - Anastasiia

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

2016-10-17 Thread Anastasiia Butko
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 18, 2016, 4:08 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

2016-10-17 Thread Anastasiia Butko
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 18, 2016, 4:04 a.m.) Review request for Default. Summary (updated)

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

2016-10-17 Thread Anastasiia Butko
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3665/#review8886 --- Ship it! Ship It! - Anastasiia Butko On oct. 18, 2016, 3:43 matin,

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

2016-10-17 Thread Anastasiia Butko
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3665/ --- (Updated Oct. 18, 2016, 3:43 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8885 --- Seems reasonable to me, but do we have any historical context for

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3676/#review8881 --- src/sim/fd_array.hh (line 109)

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8884 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 3:08 p.m.,

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3660/#review8883 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 3:07 p.m.,

Re: [gem5-dev] Review Request 3682: syscall_emul: remove TGT_MMAP_* flags that break OSX build

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3682/#review8882 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 7:47 p.m.,

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

2016-10-17 Thread Gutierrez, Anthony
Agreed. I certainly prefer to simply remove it, and I think I speak for most folks at AMD (although I'd need to double check), but I'm not going to force the issue if others still use it and would like to keep it around. -Original Message- From: gem5-dev

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

2016-10-17 Thread Jason Lowe-Power
I just copied it from the previous email conversation, no real reason. Digging through that chain I found this from Steve: > > > 1. Let's prune a lot of the long regressions that don't add much value, > particularly for less-supported ISAs. Concretely, getting rid of all the > long SE-mode ALPHA

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

2016-10-17 Thread Andreas Hansson
Hi all, Why not grab the opportunity? Jason, what is the reason for the weeks/months? Why couldn’t we remove Alpha this week if we decide that’s the right thing to do? Andreas On 17/10/2016, 16:37, "gem5-dev on behalf of Gutierrez, Anthony"

[gem5-dev] Review Request 3682: syscall_emul: remove TGT_MMAP_* flags that break OSX build

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3682/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3674/#review8879 --- Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 3:23 p.m.,

Re: [gem5-dev] Review Request 3673: syscall_emul: [patch 7/22] remove numCpus method

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3673/#review8878 --- src/sim/process.hh

Re: [gem5-dev] Review Request 3679: style: [patch 12/22] fix preliminary style issues for subsequent fault patch

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3679/#review8877 --- Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 4:11 p.m.,

Re: [gem5-dev] Review Request 3675: syscall_emul: [patch 9/22] remove unused global variable (num_processes)

2016-10-17 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3675/#review8875 --- Ship it! Ship It! - Tony Gutierrez On Oct. 17, 2016, 8:25 a.m.,

Re: [gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

2016-10-17 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3672/#review8876 --- Ship it! Ship It! - Alexandru Dutu On Oct. 17, 2016, 3:19 p.m.,

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

2016-10-17 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review8873 --- src/sim/process.cc

Re: [gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

2016-10-17 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3672/#review8872 --- Ship it! Ship It! - Tony Gutierrez On Oct. 17, 2016, 8:19 a.m.,

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8871 --- Ship it! Ship It! - Alexandru Dutu On Oct. 17, 2016, 3:08 p.m.,

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

2016-10-17 Thread Tony Gutierrez
> On Oct. 17, 2016, 7:15 a.m., Jason Lowe-Power wrote: > > With this patch, if you run multiple processes in SE mode they all have the > > same PID (100) by default. Will this cause issues? I haven't tested a > > pthreads application, but that seems like it might cause problems. > > > > Would

[gem5-dev] Review Request 3680: syscall_emul: [patch 13/22] add system call retry capability

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3680/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8869 --- Ship it! Ship It! - Tony Gutierrez On Oct. 17, 2016, 8:08 a.m.,

Re: [gem5-dev] Review Request 3675: syscall_emul: [patch 9/22] remove unused global variable (num_processes)

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3675/#review8867 --- Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 3:25 p.m.,

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-17 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3660/#review8868 --- Ship it! Ship It! - Tony Gutierrez On Oct. 17, 2016, 8:07 a.m.,

Re: [gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3672/#review8865 --- Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 3:19 p.m.,

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8864 --- src/arch/arm/process.hh (line 54)

[gem5-dev] Review Request 3679: style: [patch 12/22] fix preliminary style issues for subsequent fault patch

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3679/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3643: style: [patch 3/22] reduce include dependencies in some headers

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3643/#review8863 --- Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 3:12 p.m.,

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8862 --- Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 3:08 p.m.,

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3660/#review8861 --- Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 3:07 p.m.,

[gem5-dev] Review Request 3677: syscall_emul: [patch 11/22] extend functionality of fcntl

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3677/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3676/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

2016-10-17 Thread Gutierrez, Anthony
I would like to see this clarified before we ask Brandon to go work on fixing ALPHA. If it is going to be phased out in a matter of months, I don't think we should be asking him to waste his time on fixing it. -Original Message- From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On

[gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3674/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3675: syscall_emul: [patch 9/22] remove unused global variable (num_processes)

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3675/ --- (Updated Oct. 17, 2016, 3:25 p.m.) Review request for Default. Summary (updated)

[gem5-dev] Review Request 3673: syscall_emul: [patch 7/22] remove numCpus method

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3673/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3672/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/ --- (Updated Oct. 17, 2016, 3:14 p.m.) Review request for Default. Summary (updated)

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/ --- (Updated Oct. 17, 2016, 3:08 p.m.) Review request for Default. Summary (updated)

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3660/ --- (Updated Oct. 17, 2016, 3:07 p.m.) Review request for Default. Summary (updated)

Re: [gem5-dev] Review Request 3643: style: [patch 3/22] reduce include dependencies in some headers

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3643/ --- (Updated Oct. 17, 2016, 3:12 p.m.) Review request for Default. Summary (updated)

Re: [gem5-dev] Review Request 3660: style: [patch 1/~22] use /r/3648/ to reorganize includes

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3660/ --- (Updated Oct. 17, 2016, 3:03 p.m.) Review request for Default. Summary (updated)

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

2016-10-17 Thread Potter, Brandon
Well, it's good that someone else has similar feelings, but I feel that Alpha is more of a drag on development than Power or MIPS. I've run into several issues where I'd like to change a system call to be templated to give it more functionality and then I run into the issue of needing to a)

Re: [gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

2016-10-17 Thread Brandon Potter
> On Oct. 17, 2016, 2:15 p.m., Jason Lowe-Power wrote: > > With this patch, if you run multiple processes in SE mode they all have the > > same PID (100) by default. Will this cause issues? I haven't tested a > > pthreads application, but that seems like it might cause problems. > > > > Would

Re: [gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

2016-10-17 Thread Jason Lowe-Power
> On Oct. 17, 2016, 2:15 p.m., Jason Lowe-Power wrote: > > With this patch, if you run multiple processes in SE mode they all have the > > same PID (100) by default. Will this cause issues? I haven't tested a > > pthreads application, but that seems like it might cause problems. > > > > Would

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

2016-10-17 Thread Jason Lowe-Power
Hi Brandon, We've had this discussion before. See this thread: http://www.mail-archive.com/gem5-dev@gem5.org/msg19380.html In summary... I think we're planning on phasing out ALPHA, but that won't happen in the very short term (weeks), but may happen in the medium term (months). Cheers, Jason

Re: [gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review8858 --- With this patch, if you run multiple processes in SE mode they all have

Re: [gem5-dev] Review Request 3669: arm, config: [2/2] added support for ex5 model of big.LITTLE

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3669/#review8857 --- No diff uploaded? - Jason Lowe-Power On Oct. 17, 2016, 3:32 a.m.,

Re: [gem5-dev] Review Request 3666: arm, config: [1/2] added support for ex5 model of big.LITTLE

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/#review8856 --- The diff doesn't apply correctly. Could you fix and re-upload? - Jason

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3665/#review8855 --- Ship it! One small thing and a comment below.

[gem5-dev] Review Request 3675: syscall_emul: remove unused global variable (num_processes)

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3675/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3662: syscall_emul: move SyscallDesc into its own .hh and .cc files

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/ --- (Updated Oct. 17, 2016, 12:49 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

2016-10-17 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3665/#review8853 --- Thanks for submitting this! The change looks good other than a coupld of

Re: [gem5-dev] Review Request 3662: syscall_emul: move SyscallDesc into its own .hh and .cc files

2016-10-17 Thread Brandon Potter
> On Oct. 11, 2016, 11:43 p.m., Tony Gutierrez wrote: > > src/sim/syscall_desc.hh, line 66 > > > > > > (void) is not necessary in c++. also this is not gem5 convention. I tried to get the same change past Steve once and he

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-10-17 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic: CHANGED! *