Hi
An alternative solution could be to flag these commits with "pending adoption."
In the past, I've been interested in pending commits, and I've added them to my
watchlist, waiting to know the outcome. In other cases, I have personally used
a commit waiting to be submitted (for example, all th
Gem5 “historically” sticks to a compiler version that is already part of
shipping LTS distros and RHE or similar[1].
The C++14 right now is implemented in the main LTS distros, and the recent
compiler are full c++14 complaint.
I’d like to reopen the discussion about the general feeling behind b
Hi,
On my local dev branch, I use C++14, but I don’t have the opportunity to
compile/test all the possible Scons targets.
Before April, we could upload a [WIP] patch on Gerrit with the new compiler
flag(s) and share our thoughts from a different environment and on different
targets.
I agree wi
Hi
In the src/cpu folder, the header base_dyn_inst.hh (shared by all the CPU
models) uses the PhysRegIdPtr object, that is a pointer to a PhysReg
implemented in the o3/comm.hh
There is a specific reason why the class BaseDynInst (defined for all models)
needs a model-specific object (defined on
This is one of the flaws: a cpu class (MinorCPU) that needs an header defined
in the top level folder (dynamic insts) that includes another header defined in
a specific CPU model (O3). The implementation of the Physical Register in O3 is
also used by the CPUChecker that, correct if I am wrong, c
Follow up:
https://gem5-review.googlesource.com/c/public/gem5/+/16908
I will think a better way to refactor the code, but any idea is welcome.
Bests,
A.
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/18128
Change subject: mem-cache: missing override specifier
..
mem-cache: missing override specifier
Change-Id
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ied4817bcda317826303a1bb688b41823b18b489b
Gerrit-Change-Number: 18128
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Nikos Nikoleris
Gerrit-CC: kokoro
G
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/18128 )
Change subject: mem: missing override specifier
..
mem: missing override specifier
Change-Id
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/18348
Change subject: cpu,mem: missing override specifier
..
cpu,mem: missing override specifier
Change-Id
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/18348 )
Change subject: cpu,mem: missing override specifier
..
cpu,mem: missing override specifier
Change-Id
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/18668
Change subject: sim-se: correct statfs inclusion on !linux host
..
sim-se: correct statfs inclusion on !linux
Andrea Mondelli has uploaded a new patch set (#2). (
https://gem5-review.googlesource.com/c/public/gem5/+/18668 )
Change subject: sim-se: correct statfs inclusion on !linux host
..
sim-se: correct statfs inclusion on !linux
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/18948
Change subject: cpu: Added correct return type for ROB::countInsts
..
cpu: Added correct return type for ROB
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/18948 )
Change subject: cpu: Added correct return type for ROB::countInsts
..
cpu: Added correct return type
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/20959 )
Change subject: dev: Terminal output's dump name conflicts
..
dev: Terminal output's dump name
Andrea Mondelli has uploaded a new patch set (#2). (
https://gem5-review.googlesource.com/c/public/gem5/+/20959 )
Change subject: dev: Terminal output's dump name conflicts
..
dev: Terminal output's dump name conf
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/21019 )
Change subject: misc: Disable warning on deprecated experimental header
..
misc: Disable warning on
Andrea Mondelli has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/20959 )
Change subject: dev: Terminal output's dump name conflicts
..
dev: Terminal output's dump name conflicts
Th
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/23380 )
Change subject: cpu: missing override specifier
..
cpu: missing override specifier
Change-Id
Andrea Mondelli has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/23380 )
Change subject: arch-x86: missing override specifier
..
arch-x86: missing override specifier
Change-Id
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/15175
Change subject: scons: Disable PyTrafficGen module on Mac OS
..
scons: Disable PyTrafficGen module on Mac OS
hange-Id: I5d3af95de491e1d50481bda7d63c4b4e969864fa
Gerrit-Change-Number: 15175
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Andreas Sandberg
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-CC: Giacomo Gabrielli
G
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/15195
Change subject: misc: Suppress of deprecated keyword usage warning in
Python2
..
misc: Suppress of
Hello Andrea Mondelli,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15375
to review the following change.
Change subject: scons: added support of default Python installation on
Hello Andrea Mondelli,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15376
to review the following change.
Change subject: misc: Suppress of deprecated keyword usage warning in
Py
Hello Gabe Black, Andrea Mondelli,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15376
to look at the new patch set (#2).
Change subject: misc: Suppress of deprecated keyword usage warning in
Py
Hello Gabe Black, Andrea Mondelli,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15376
to look at the new patch set (#3).
Change subject: misc: Suppress of deprecated keyword usage warning in
Py
Hello Gabe Black, Andrea Mondelli, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15376
to look at the new patch set (#4).
Change subject: misc: Suppress of deprecated keyword usage warning in
Py
Hello Andrea Mondelli, Jason Lowe-Power,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15375
to look at the new patch set (#2).
Change subject: misc: updated shabang for python s
Hello Andrea Mondelli,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15475
to review the following change.
Change subject: scons: added support of default Python installation on
Hello Gabe Black, Andrea Mondelli, Jason Lowe-Power,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15475
to look at the new patch set (#2).
Change subject: scons: added support of default Python installation on
Hello Gabe Black, Andrea Mondelli, Jason Lowe-Power, Nikos Nikoleris,
Matteo Andreozzi,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15475
to look at the new patch set (#3).
Change subject: scons: added support of default P
Hello Gabe Black, Andrea Mondelli, Jason Lowe-Power, Nikos Nikoleris,
Matteo Andreozzi,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15475
to look at the new patch set (#4).
Change subject: scons: added support of default P
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/15375 )
Change subject: misc: updated shabang for python script
..
misc: updated shabang for python script
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/15475 )
Change subject: scons: added support of default Python installation on MacOS
..
scons: added support
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16082
Change subject: scons: use of data len const in Embed python files
..
scons: use of data len const in Embed
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16102
Change subject: sim: added missed macro definition on MacOS
..
sim: added missed macro definition on MacOS
A
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16103
Change subject: misc: added missing override specifier
..
misc: added missing override specifier
Added
tings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I4783e92d78789a9ae182fad79aadceafb00b2458
Gerrit-Change-Number: 16103
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Andreas Sandberg
Gerrit-Reviewer: Gabe Black
G
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/16103 )
Change subject: misc: added missing override specifier
..
misc: added missing override specifier
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/16102 )
Change subject: sim: added missed macro definition on MacOS
..
sim: added missed macro definition on
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16322
Change subject: misc: Segmentation Fault during O3PipeView execution
..
misc: Segmentation Fault during
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16648
Change subject: misc: un-hide MemObject::getMasterPort in TLB class
..
misc: un-hide MemObject::getMasterPort
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16649
Change subject: scons: conditional use of new RPATH inclusion
..
scons: conditional use of new RPATH inclusion
umber: 16649
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Gabe Black
Gerrit-CC: Jason Lowe-Power
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/lis
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/16649 )
Change subject: scons: conditional use of new RPATH inclusion
..
scons: conditional use of new RPATH
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16728
Change subject: misc: added missing override specifier in BoP
..
misc: added missing override specifier in BoP
chSet: 2
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/16728 )
Change subject: mem-cache: added missing override specifier in BoP
..
mem-cache: added missing
ublic/gem5
Gerrit-Branch: master
Gerrit-Change-Id: If4f61189094a706d59805cd10f4f814e5830eda8
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-CC: Ivan Pizarro
G
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/16322 )
Change subject: misc: Segmentation Fault during O3PipeView execution
..
misc: Segmentation Fault
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16828
Change subject: scons: Use the correct env value to create defines.py
..
scons: Use the correct env value to
Andrea Mondelli has uploaded a new patch set (#2) to the change originally
created by Gabe Black. (
https://gem5-review.googlesource.com/c/public/gem5/+/16810 )
Change subject: systemc: Move systemc disabling checks to SConsopts
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16908
Change subject: cpu: Refactor of Physical Register implementation
..
cpu: Refactor of Physical Register
/gem5/+/16648
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: If4f61189094a706d59805cd10f4f814e5830eda8
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 7
Gerrit-Owner: Andrea Mon
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/16648 )
Change subject: mem-cache: alias to mem::getMasterPort in TLB class
..
mem-cache: alias to mem
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/16908 )
Change subject: cpu: Refactor of Physical Register implementation
..
cpu: Refactor of Physical
950
Gerrit-PatchSet: 4
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Anthony Gutierrez
Gerrit-Reviewer: Giacomo Travaglini
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-CC: Andreas Sandberg
Gerrit-CC: Gabe Black
Gerrit-MessageType: n
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/17248
Change subject: misc: Removed inconsistency in BPRED* debug msgs
..
misc: Removed inconsistency in BPRED
ge-Id: I4761c49fc12b874a7d8b46779475b606865cad4b
Gerrit-Change-Number: 17248
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/17308
Change subject: arm: Correct cast of template parameter
..
arm: Correct cast of template parameter
Clang with
Andrea Mondelli has uploaded a new patch set (#2). (
https://gem5-review.googlesource.com/c/public/gem5/+/17308 )
Change subject: arch-arm: Correct cast of template parameter
..
arch-arm: Correct cast of template parameter
ge-Id: I4761c49fc12b874a7d8b46779475b606865cad4b
Gerrit-Change-Number: 17248
Gerrit-PatchSet: 3
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
ge-Id: I4761c49fc12b874a7d8b46779475b606865cad4b
Gerrit-Change-Number: 17248
Gerrit-PatchSet: 4
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Bradley Wang
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-MessageType: newpatchset
___
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/17388
Change subject: misc: tautological comparison of byteOrder
..
misc: tautological comparison of byteOrder
e, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I3deb154c2fe5b92c4ddf499176cb185c4ec7cf64
Gerrit-Change-Number: 17388
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: J
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/17388 )
Change subject: mem-cache: tautological comparison of byteOrder
..
mem-cache: tautological comparison
aster
Gerrit-Change-Id: I4761c49fc12b874a7d8b46779475b606865cad4b
Gerrit-Change-Number: 17248
Gerrit-PatchSet: 6
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Bradley Wang
Gerrit-Reviewer: Giacomo Travaglini
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Messag
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/17468
Change subject: misc: missing override specifier
..
misc: missing override specifier
Missing specifier of
Andrea Mondelli has uploaded a new patch set (#3). (
https://gem5-review.googlesource.com/c/public/gem5/+/17308 )
Change subject: dev-arm: Correct cast of template parameter
..
dev-arm: Correct cast of template parameter
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/17469
Change subject: dev-arm: ambiguous use of getPort()
..
dev-arm: ambiguous use of getPort()
The recent
ublic/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I4761c49fc12b874a7d8b46779475b606865cad4b
Gerrit-Change-Number: 17248
Gerrit-PatchSet: 7
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Bradley Wang
Gerrit-Reviewer: Giacomo Travaglini
Gerrit-Reviewer: Jason Lowe-
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/17469 )
Change subject: dev-arm: ambiguous use of getPort()
..
dev-arm: ambiguous use of getPort()
The
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I42aa3349b537c9e62607bce20cf1b3aabdb99bf2
Gerrit-Change-Number: 17468
Gerrit-PatchSet: 3
Gerrit-Owner: Andrea Mondelli
Gerrit-Reviewer: Andrea Mondelli
Gerrit-Reviewer: Andreas Sandberg
Gerrit
mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I3aa1e77da2565799feadc32317d5faa111b2de86
Gerrit-Change-Number: 17308
Gerrit-PatchSet: 5
Gerrit-Owner: Andrea Mondelli
Gerrit-Assignee: Giacomo Travaglini
Gerrit-Rev
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/17648
Change subject: arch-mips: added missing override specifier (o3)
..
arch-mips: added missing override
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/17308 )
Change subject: dev-arm: Correct cast of template parameter
..
dev-arm: Correct cast of template
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/17648 )
Change subject: arch-mips: added missing override specifier (o3)
..
arch-mips: added missing override
Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/17248 )
Change subject: misc: Removed inconsistency in O3* debug msgs
..
misc: Removed inconsistency in O3
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/17788
Change subject: mem-cache: ambiguous use of abs function
..
mem-cache: ambiguous use of abs function
std::abs
Andrea Mondelli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/29252 )
Change subject: cpu: fixed unused variable on fast binary
..
cpu: fixed unused variable on fast binary
When
Andrea Mondelli has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/29252 )
Change subject: cpu: fixed unused variable on fast binary
..
cpu: fixed unused variable on fast binary
When gem5.fast
Hello Andrea Mondelli,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/30035
to review the following change.
Change subject: mem: model data array bank in classic cache - revi
Andrea Mondelli has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/41933 )
Change subject: arch-riscv: Fixed CPU switching and PLIC issue with MinorCPU
..
arch-riscv: Fixed CPU switching and
85 matches
Mail list logo