Re: [gem5-dev] Review Request 3623: arm, dev: pl011 console interactivity

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3623/#review8847 --- Can you mark this as submitted? Thanks. - Jason Lowe-Power On Sept. 19

Re: [gem5-dev] Review Request 3623: arm, dev: pl011 console interactivity

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3623/ --- (Updated Sept. 19, 2016, 10:31 p.m.) Review request for Default and Andreas Sandber

Re: [gem5-dev] Review Request 3623: arm, dev: pl011 console interactivity

> On Sept. 6, 2016, 10:52 a.m., Andreas Sandberg wrote: > > src/dev/arm/pl011.cc, line 232 > > > > > > I'm not sure I understand exactly what this condition is supposed to > > test. The check currently tests if there is an

Re: [gem5-dev] Review Request 3623: arm, dev: pl011 console interactivity

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3623/#review8711 --- src/dev/arm/pl011.cc (line 232)

Re: [gem5-dev] Review Request 3623: arm, dev: pl011 console interactivity

> On Sept. 6, 2016, 9:34 a.m., Andreas Sandberg wrote: > > src/dev/arm/pl011.cc, line 232 > > > > > > Do you actually need the check against maskInt() here? The necessary > > checks should already be inplace in dataAvailabl

Re: [gem5-dev] Review Request 3623: arm, dev: pl011 console interactivity

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3623/#review8709 --- Ship it! Minor issue/question. Looks good otherwise. Thanks! src/dev/a

[gem5-dev] Review Request 3623: arm, dev: pl011 console interactivity

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3623/ --- Review request for Default and Andreas Sandberg. Repository: gem5 Description ---